Re: FBR: Update module pungi conf with correct signing key

2018-03-07 Thread Pierre-Yves Chibon
On Wed, Mar 07, 2018 at 01:21:31AM -, Patrick  マルタインアンドレアス  Uiterwijk wrote:
> For F28+ modular, the modules are signed by the keys of the underlying 
> platform rather than the fedora-modular key.
> +1s for this patch to set the correct key?
> 
> 
> diff --git a/roles/bodhi2/backend/templates/pungi.module.conf.j2 
> b/roles/bodhi2/backend/templates/pungi.module.conf.j2
> index 77eceb500..974c933f6 100644
> --- a/roles/bodhi2/backend/templates/pungi.module.conf.j2
> +++ b/roles/bodhi2/backend/templates/pungi.module.conf.j2
> @@ -10,7 +10,9 @@ bootable = False
>  
>  variants_file='module-variants.xml'
>  sigkeys = [
> -   'a3cc4e62',
> +[% if release.version_int == 28 %]
> +   '9db62fb1',
> +[% endif %]
>  {% if env == "staging" %}
> None
>  {% endif %}

+1 as well


Pierre


signature.asc
Description: PGP signature
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org


Re: FBR: Update module pungi conf with correct signing key

2018-03-06 Thread Kevin Fenzi
On 03/06/2018 05:21 PM, Patrick  マルタインアンドレアス  Uiterwijk wrote:
> For F28+ modular, the modules are signed by the keys of the underlying 
> platform rather than the fedora-modular key.
> +1s for this patch to set the correct key?
> 
> 
> diff --git a/roles/bodhi2/backend/templates/pungi.module.conf.j2 
> b/roles/bodhi2/backend/templates/pungi.module.conf.j2
> index 77eceb500..974c933f6 100644
> --- a/roles/bodhi2/backend/templates/pungi.module.conf.j2
> +++ b/roles/bodhi2/backend/templates/pungi.module.conf.j2
> @@ -10,7 +10,9 @@ bootable = False
>  
>  variants_file='module-variants.xml'
>  sigkeys = [
> -   'a3cc4e62',
> +[% if release.version_int == 28 %]
> +   '9db62fb1',
> +[% endif %]
>  {% if env == "staging" %}
> None
>  {% endif %}

Looks ok to me. +1

kevin




signature.asc
Description: OpenPGP digital signature
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org


FBR: Update module pungi conf with correct signing key

2018-03-06 Thread Patrick マルタインアンドレアス Uiterwijk
For F28+ modular, the modules are signed by the keys of the underlying platform 
rather than the fedora-modular key.
+1s for this patch to set the correct key?


diff --git a/roles/bodhi2/backend/templates/pungi.module.conf.j2 
b/roles/bodhi2/backend/templates/pungi.module.conf.j2
index 77eceb500..974c933f6 100644
--- a/roles/bodhi2/backend/templates/pungi.module.conf.j2
+++ b/roles/bodhi2/backend/templates/pungi.module.conf.j2
@@ -10,7 +10,9 @@ bootable = False
 
 variants_file='module-variants.xml'
 sigkeys = [
-   'a3cc4e62',
+[% if release.version_int == 28 %]
+   '9db62fb1',
+[% endif %]
 {% if env == "staging" %}
None
 {% endif %}
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org