Re: [ITK-dev] -fvisibility=hidden link warnings with GetMetaDataObjectTypeName()

2016-11-30 Thread Sean McBride
On Wed, 30 Nov 2016 01:58:38 +, Lowekamp, Bradley (NIH/NLM/LHC) [C] said: >One more question, if you have a moment: > >What is the purpose or goal of adding the hidden visibility flag when >building ITK with static libraries? What API are you trying to expose on >your "Application"? Brad, We

Re: [ITK-dev] -fvisibility=hidden link warnings with GetMetaDataObjectTypeName()

2016-11-29 Thread Lowekamp, Bradley (NIH/NLM/LHC) [C]
McBride [s...@rogue-research.com] Sent: Monday, November 28, 2016 4:59 PM To: Lowekamp, Bradley (NIH/NLM/LHC) [C] Cc: insight-developers@itk.org Subject: Re: [ITK-dev] -fvisibility=hidden link warnings with GetMetaDataObjectTypeName() On Fri, 25 Nov 2016 20:55:31 +, Lowekamp, Bradley (NIH/NLM/LHC) [C]

Re: [ITK-dev] -fvisibility=hidden link warnings with GetMetaDataObjectTypeName()

2016-11-29 Thread Matt McCormick
On Mon, Nov 28, 2016 at 12:14 PM, Isaiah Norton wrote: >> It sorta reminds me of the 'dynamic_cast on Mac OSX' thread, is it >> related? > > > Yes. This is a symptom of the same issue: missing export annotations. Hans > emailed about the same warnings in April (the mailing list archive is > curren

Re: [ITK-dev] -fvisibility=hidden link warnings with GetMetaDataObjectTypeName()

2016-11-29 Thread Lowekamp, Bradley (NIH/NLM/LHC) [C]
You are right! I am surprised CMake does not generate warning about that. Thank you for the suggestion: https://github.com/SimpleITK/SimpleITK/pull/76 Brad > On Nov 29, 2016, at 10:04 AM, Johnson, Hans J wrote: > > Brad, > > Is that command line correct? > > :BOOL=hidden ? Is that true

Re: [ITK-dev] -fvisibility=hidden link warnings with GetMetaDataObjectTypeName()

2016-11-29 Thread Johnson, Hans J
Brad, Is that command line correct? :BOOL=hidden ? Is that true, or false, or should it be :STRING=hidden ? Hans -- On 11/29/16, 8:19 AM, "Insight-developers on behalf of Lowekamp, Bradley (NIH/NLM/LHC) [C]" wrote: Thanks for the update, and the work to narrow your problem down.

Re: [ITK-dev] -fvisibility=hidden link warnings with GetMetaDataObjectTypeName()

2016-11-29 Thread Lowekamp, Bradley (NIH/NLM/LHC) [C]
Thanks for the update, and the work to narrow your problem down. Just to let you know, another alternative to managing the flags is to use CMake preset property variables. When I build ITK for SimpleITK I apply (depending on the configuration) the following CMake options: -DCMAKE_C_VISIBILITY_P

Re: [ITK-dev] -fvisibility=hidden link warnings with GetMetaDataObjectTypeName()

2016-11-28 Thread Sean McBride
On Fri, 25 Nov 2016 20:55:31 +, Lowekamp, Bradley (NIH/NLM/LHC) [C] said: >I presume you are compiling ITK with shared libraries? No, as static libraries. >Would you happen to have a minimal example of “MyOwnCode.cxx” that >reproduces this warning? I reduced it to a very small Xcode project

Re: [ITK-dev] -fvisibility=hidden link warnings with GetMetaDataObjectTypeName()

2016-11-28 Thread Isaiah Norton
> > It sorta reminds me of the 'dynamic_cast on Mac OSX' thread, is it related? Yes. This is a symptom of the same issue: missing export annotations. Hans emailed about the same warnings in April (the mailing list archive is currently down so I can't provide a link, but I can find it in my gmail

Re: [ITK-dev] -fvisibility=hidden link warnings with GetMetaDataObjectTypeName()

2016-11-25 Thread Lowekamp, Bradley (NIH/NLM/LHC) [C]
Hello, I presume you are compiling ITK with shared libraries? Would you happen to have a minimal example of “MyOwnCode.cxx” that reproduces this warning? Thanks, Brad > On Nov 25, 2016, at 3:47 PM, Sean McBride wrote: > > Hi all, > > I'm trying to rebuild my app and all its C++ libraries wi

[ITK-dev] -fvisibility=hidden link warnings with GetMetaDataObjectTypeName()

2016-11-25 Thread Sean McBride
Hi all, I'm trying to rebuild my app and all its C++ libraries with -fvisibility=hidden -fvisibility-inlines-hidden. It all builds, but I get 3 very similar link warnings building my app; the first is: ld: warning: direct access in function 'itk::MetaDataObject >::GetMetaDataObjectTypeName()