Re: [ITK-dev] Proper ThirdParty (GDCM specifically) update procedure?

2017-10-05 Thread Matt McCormick
Jon has created an UpdatingThirdParty.md doc: http://review.source.kitware.com/#/c/22670/ On Mon, Sep 25, 2017 at 4:32 PM, Matt McCormick wrote: > Hi Sean, > > Thanks for helping to update these third party libraries. > >> I'm going to try to update ITK's GDCM... are there docs for this proced

Re: [ITK-dev] Proper ThirdParty (GDCM specifically) update procedure?

2017-09-25 Thread Mathieu Malaterre
Sean, On Mon, Sep 25, 2017 at 8:25 PM, Sean McBride wrote: > On Mon, 25 Sep 2017 20:19:03 +0200, Mathieu Malaterre said: > >>Hi Sean, >> >>On Mon, Sep 25, 2017 at 7:40 PM, Sean McBride wrote: >>> Hi all, >>> >>> I'm going to try to update ITK's GDCM... are there docs for this procedure? >>> >>>

Re: [ITK-dev] Proper ThirdParty (GDCM specifically) update procedure?

2017-09-25 Thread Matt McCormick
Hi Sean, Thanks for helping to update these third party libraries. > I'm going to try to update ITK's GDCM... are there docs for this procedure? Essentially, run the UpdateFromUpstream.sh script, but we should add some instructions in comments at the top of that file to address your questions.

Re: [ITK-dev] Proper ThirdParty (GDCM specifically) update procedure?

2017-09-25 Thread Sean McBride
On Mon, 25 Sep 2017 20:19:03 +0200, Mathieu Malaterre said: >Hi Sean, > >On Mon, Sep 25, 2017 at 7:40 PM, Sean McBride wrote: >> Hi all, >> >> I'm going to try to update ITK's GDCM... are there docs for this procedure? >> >> I know about the ITK/Modules/ThirdParty/GDCM/UpdateFromUpstream.sh >scri

Re: [ITK-dev] Proper ThirdParty (GDCM specifically) update procedure?

2017-09-25 Thread Mathieu Malaterre
Hi Sean, On Mon, Sep 25, 2017 at 7:40 PM, Sean McBride wrote: > Hi all, > > I'm going to try to update ITK's GDCM... are there docs for this procedure? > > I know about the ITK/Modules/ThirdParty/GDCM/UpdateFromUpstream.sh script, > but I'm wondering things like: > - do I run it on the master b

[ITK-dev] Proper ThirdParty (GDCM specifically) update procedure?

2017-09-25 Thread Sean McBride
Hi all, I'm going to try to update ITK's GDCM... are there docs for this procedure? I know about the ITK/Modules/ThirdParty/GDCM/UpdateFromUpstream.sh script, but I'm wondering things like: - do I run it on the master branch, or should I first create a branch of my own? - running the script c