On Fri, 14 Oct 2011 12:43:49 -0400, Adam Jackson a...@redhat.com wrote:
The previous code was confused about units, which is pretty reasonable
given that the units themselves are confusing.
Thanks for actually figuring this out; the comment before that function
should have indicated to any
On Fri, 14 Oct 2011 12:43:50 -0400, Adam Jackson a...@redhat.com wrote:
These were just working around the math being wrong.
One wonders whether this might break some machines which are currently
working. Should we emit an error or something if an eDP panel asks for
the impossible?
--
On Tue, Oct 11, 2011 at 04:51:16PM -0700, Ben Widawsky wrote:
I thought we all agreed that PIPE_CONTROL_WRITE_FLUSH doesn't make
sense for Gen6? Or was that just me agreeing with myself?
I couldn't find any comment of yours to that effect ... :p You'd be much
happier if I add a
On Sat, 15 Oct 2011 16:01:17 +0200
Daniel Vetter dan...@ffwll.ch wrote:
On Tue, Oct 11, 2011 at 04:51:16PM -0700, Ben Widawsky wrote:
I thought we all agreed that PIPE_CONTROL_WRITE_FLUSH doesn't make
sense for Gen6? Or was that just me agreeing with myself?
I couldn't find any comment of
From: David Woodhouse dw...@infradead.org
To work around a hardware issue, we have to submit IOTLB flushes while
the graphics engine is idle. The graphics driver will (we hope) go to
great lengths to ensure that it gets that right on the affected
chipset(s)... so let's not screw it over by
Tested-by: Ben Widawsky b...@bwidawsk.net
I ran the airlied test on it for 4 minutes. It normally hangs in 1
minute.
Changes from the last version:
Rebased on the new patches from David Woodhouse
Use the new global to determine if we need workaround.
Idling can fail now, instead of being
From: David Woodhouse david.woodho...@intel.com
We really don't want this to work in the general case; device drivers
*shouldn't* care whether they are behind an IOMMU or not. But the
integrated graphics is a special case, because the IOMMU and the GTT are
all kind of smashed into one and
[Description from: Daniel Vetter]
I've just discussed this quickly with Chris on irc and it's probably
best to just kill the list_empty early bailout. gpu_idle isn't a
fastpath, so who cares. One candidate where we emit commands to the ring
without adding anything onto these lists is e.g.
Idle the GPU before doing any unmaps. We know if VT-d is in use through
an exported variable from iommu code.
This should avoid a known HW issue.
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
drivers/char/agp/intel-gtt.c| 28
On Sat, Oct 15, 2011 at 01:47:15PM -0700, Ben Widawsky wrote:
[Description from: Daniel Vetter]
I've just discussed this quickly with Chris on irc and it's probably
best to just kill the list_empty early bailout. gpu_idle isn't a
fastpath, so who cares. One candidate where we emit commands to
On Sat, Oct 15, 2011 at 01:47:16PM -0700, Ben Widawsky wrote:
Idle the GPU before doing any unmaps. We know if VT-d is in use through
an exported variable from iommu code.
This should avoid a known HW issue.
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
drivers/char/agp/intel-gtt.c
On Sat, 15 Oct 2011 13:47:16 -0700, Ben Widawsky b...@bwidawsk.net wrote:
Idle the GPU before doing any unmaps. We know if VT-d is in use through
an exported variable from iommu code.
This should avoid a known HW issue.
Signed-off-by: Ben Widawsky b...@bwidawsk.net
Just one minor comment
On Sat, 15 Oct 2011 13:47:15 -0700, Ben Widawsky b...@bwidawsk.net wrote:
[Description from: Daniel Vetter]
I've just discussed this quickly with Chris on irc and it's probably
best to just kill the list_empty early bailout. gpu_idle isn't a
fastpath, so who cares. One candidate where we emit
13 matches
Mail list logo
