Re: [Intel-gfx] Find bugs in i915 driver

2012-07-31 Thread Chris Wilson
On Tue, 31 Jul 2012 02:29:01 +, Xu, Anhua anhua...@intel.com wrote: Hi, I found some bugs in i915 driver when reviewing intel_display.c The parameter passed-in for function hdmi/adpa/lvds_pipe_enabled() are not coherent with functions' definition. This is the patch. Patch looks good,

Re: [Intel-gfx] [PATCH] drm/i915: Don't forget to apply SNB PIPE_CONTROL GTT workaround.

2012-07-31 Thread Chris Wilson
On Mon, 30 Jul 2012 18:24:26 -0700, Eric Anholt e...@anholt.net wrote: If a buffer that was the target of a PIPE_CONTROL from userland was a reused one that hadn't been evicted which had not previously had this workaround applied, then we would not bind it into the GTT and the write would land

Re: [Intel-gfx] [PATCH V2 4/4] ALSA HDA: Force HDMI pins enabled

2012-07-31 Thread Takashi Iwai
At Tue, 31 Jul 2012 10:47:05 +0800, Wang Xingchao wrote: There's one issue for HDMI pins, even the related pin will be enabled when the stream is active but the GPU registers show the PIN is not in active state, so we force all pins in active state and donot close it when the stream is

Re: [Intel-gfx] Find bugs in i915 driver

2012-07-31 Thread Greg KH
On Tue, Jul 31, 2012 at 09:17:15AM +, Xu, Anhua wrote: Thanks Chris. I add this in the the commit description. The updated patch is below: commit 71c3ff04834a01c81a5843996b87397273eb538d Author: Xu Anhua anhua...@intel.com Date: Tue Jul 31 17:16:50 2012 +0800 i915: make the

Re: [Intel-gfx] [Mesa-dev] [PATCH 1/5] intel gen4/5: fix GL_VERTEX_PROGRAM_TWO_SIDE.

2012-07-31 Thread Eric Anholt
Olivier Galibert galib...@pobox.com writes: On Mon, Jul 30, 2012 at 10:30:57AM -0700, Eric Anholt wrote: I'm perfectly fine with the VUE containing slots for both when the app has gone out of its way to ask for deprecated two-sided color rendering. Are you also ok with recompiler the

Re: [Intel-gfx] [PATCH] drm/i915: Don't forget to apply SNB PIPE_CONTROL GTT workaround.

2012-07-31 Thread Carl Worth
Eric Anholt e...@anholt.net writes: I have not tested it yet, but hopefully when cworth gets home he will. Reviewed-by: Carl Worth cwo...@cworth.org Tested-by: Carl Worth cwo...@cworth.org Thanks, Eric! This is perfect. -Carl -- carl.d.wo...@intel.com pgp0yyvRoVr80.pgp Description: PGP

[Intel-gfx] [PATCH] drm/i915: Don't forget to apply SNB PIPE_CONTROL GTT workaround.

2012-07-31 Thread Eric Anholt
If a buffer that was the target of a PIPE_CONTROL from userland was a reused one that hadn't been evicted which had not previously had this workaround applied, then the early return for a correct presumed_offset in this function meant we would not bind it into the GTT and the write would land

Re: [Intel-gfx] Macbook Pro Retina display problems

2012-07-31 Thread Greg KH
On Tue, Jul 31, 2012 at 03:00:52PM +1000, Dave Airlie wrote: On Tue, Jul 31, 2012 at 1:41 PM, Greg KH gre...@linuxfoundation.org wrote: On Tue, Jul 31, 2012 at 12:06:28PM +1000, Dave Airlie wrote: On Tue, Jul 31, 2012 at 8:33 AM, Greg KH gre...@linuxfoundation.org wrote: Hi all,

Re: [Intel-gfx] [PATCH V2 4/4] ALSA HDA: Force HDMI pins enabled

2012-07-31 Thread Wang, Xingchao
Hi Takashi, -Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Tuesday, July 31, 2012 7:18 PM To: Wang, Xingchao Cc: intel-gfx@lists.freedesktop.org; Zanoni, Paulo R Subject: Re: [Intel-gfx] [PATCH V2 4/4] ALSA HDA: Force HDMI pins enabled At Tue, 31 Jul 2012

[Intel-gfx] [PATCH] tests/testdisplay.c: Add a option '-g' to save images which intended to paint on screen during each mode setting.

2012-07-31 Thread Yi Sun
That option will save all the images which are created and intended to paint on screen. The images will be saved in folder saveimages with PNG format. Signed-off-by: Yi Sun yi@intel.com diff --git a/tests/testdisplay.c b/tests/testdisplay.c index 4430d07..2d1fdb0 100644 ---

Re: [Intel-gfx] [PATCH] tests/testdisplay.c: Add a option '-g' to save images which intended to paint on screen during each mode setting.

2012-07-31 Thread Ben Widawsky
On 2012-07-31 18:51, Yi Sun wrote: That option will save all the images which are created and intended to paint on screen. The images will be saved in folder saveimages with PNG format. Signed-off-by: Yi Sun yi@intel.com diff --git a/tests/testdisplay.c b/tests/testdisplay.c index