Re: [Intel-gfx] assertion on intel_disable_transcoder

2012-09-27 Thread Daniel Vetter
On Thu, Sep 27, 2012 at 06:32:06AM +, Wang, Xingchao wrote: Hi Ben, I have no idea about the resolution, maybe Paulo and Daniel know more details? Oh, it's just an older assert for pre-hsw that we haven't properly disabled yet. Since this code will change quite a bit with Paulo's new way

Re: [Intel-gfx] [PATCH] drm/i915: use adjusted_mode instead of mode for checking the 6bpc force flag

2012-09-27 Thread Daniel Vetter
On Wed, Sep 26, 2012 at 11:50:36AM -0400, Adam Jackson wrote: On Wed, 2012-09-26 at 18:43 +0300, Jani Nikula wrote: The dithering introduced in commit 3b5c78a35cf7511c15e09a9b0ffab290a42d9bcf Author: Adam Jackson a...@redhat.com Date: Tue Dec 13 15:41:00 2011 -0800

Re: [Intel-gfx] [PATCH] intel_infoframes: Dump HDMI vendor infoframes

2012-09-27 Thread Daniel Vetter
On Wed, Sep 26, 2012 at 08:01:09PM -0300, Rodrigo Vivi wrote: Reviewed-by: Rodrigo Vivi rodrigo.v...@gmail.com On Wed, Sep 26, 2012 at 2:17 PM, Damien Lespiau damien.lesp...@gmail.com wrote: From: Damien Lespiau damien.lesp...@intel.com Those infoframes are programmed when using stereo

Re: [Intel-gfx] [PATCH] drm/i915: Fix set_caching locking

2012-09-27 Thread Daniel Vetter
On Wed, Sep 26, 2012 at 04:15:20PM -0700, Ben Widawsky wrote: On the EINVAL case we don't release struct_mutex. It should be safe to grab the lock after checking the parameters, which also resolves the issues. Signed-off-by: Ben Widawsky b...@bwidawsk.net Nice catch, thanks for the patch,

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Add eDP support for Valleyview

2012-09-27 Thread Jani Nikula
On Wed, 26 Sep 2012, Daniel Vetter dan...@ffwll.ch wrote: On Wed, Sep 26, 2012 at 07:07:35PM +0530, Vijay Purushothaman wrote: diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index a8a81d1..aee6151 100644 --- a/drivers/gpu/drm/i915/intel_display.c

Re: [Intel-gfx] [PATCH] drm/i915: Disallow preallocation of requests

2012-09-27 Thread Jani Nikula
On Wed, 26 Sep 2012, Chris Wilson ch...@chris-wilson.co.uk wrote: The intention was to allow the caller to avoid a failure to queue a request having already written commands to the ring. However, this is a moot point as the i915_add_request() can fail for other reasons than a mere allocation

[Intel-gfx] [PATCH] drm/i915: Detect invalid pages for SandyBridge

2012-09-27 Thread Chris Wilson
As SandyBridge returns garbage when decoding certain addresses through the GTT (all memory below 1MiB and a very small number of individual pages) we need to prevent the GPU from utilizing those pages. The ultimate goal would be to prevent our allocator from handing us those pages, but that is a

Re: [Intel-gfx] Question regarding libva encoding

2012-09-27 Thread Charlie Good
This is great news. I will watch for the udpate. Charlie -Original Message- From: Xiang, Haihao [mailto:haihao.xi...@intel.com] Sent: Wednesday, September 26, 2012 9:17 PM To: Charlie Good Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] Question regarding libva encoding

Re: [Intel-gfx] assertion on intel_disable_transcoder

2012-09-27 Thread Ben Guthro
FWIW, I am able to get graphics on the screen now - Apparently only the hdmi port works on HSW right now - which I was unaware of. This stack was a red-herring to that problem. Thanks for the response. Ben On Thu, Sep 27, 2012 at 2:34 AM, Daniel Vetter dan...@ffwll.ch wrote: On Thu, Sep 27,

Re: [Intel-gfx] [PATCH] drm/i915: Disallow preallocation of requests

2012-09-27 Thread Daniel Vetter
On Thu, Sep 27, 2012 at 10:39:53AM +0300, Jani Nikula wrote: On Wed, 26 Sep 2012, Chris Wilson ch...@chris-wilson.co.uk wrote: The intention was to allow the caller to avoid a failure to queue a request having already written commands to the ring. However, this is a moot point as the

Re: [Intel-gfx] [RFC] [PATCH] quick_dump: A dump utility different than reg_dumper

2012-09-27 Thread Daniel Vetter
On Wed, Sep 26, 2012 at 11:40:26AM -0700, Ben Widawsky wrote: On Wed, 26 Sep 2012 13:51:01 +0200 Daniel Vetter dan...@ffwll.ch wrote: On Sat, Sep 22, 2012 at 01:58:37PM -0700, Ben Widawsky wrote: On 2012-09-22 11:05, Daniel Vetter wrote: And a quick comment on your approach here: I'm

Re: [Intel-gfx] [PATCH] drm/i915: Detect invalid pages for SandyBridge

2012-09-27 Thread Daniel Vetter
On Thu, Sep 27, 2012 at 09:27:57AM +0100, Chris Wilson wrote: As SandyBridge returns garbage when decoding certain addresses through the GTT (all memory below 1MiB and a very small number of individual pages) we need to prevent the GPU from utilizing those pages. The ultimate goal would be to

Re: [Intel-gfx] [PATCH] drm/i915: Detect invalid pages for SandyBridge

2012-09-27 Thread Daniel Vetter
On Thu, Sep 27, 2012 at 02:14:22PM +0200, Daniel Vetter wrote: On Thu, Sep 27, 2012 at 09:27:57AM +0100, Chris Wilson wrote: As SandyBridge returns garbage when decoding certain addresses through the GTT (all memory below 1MiB and a very small number of individual pages) we need to prevent

Re: [Intel-gfx] [PATCH] drm/i915: Detect invalid pages for SandyBridge

2012-09-27 Thread Chris Wilson
On Thu, 27 Sep 2012 14:16:11 +0200, Daniel Vetter dan...@ffwll.ch wrote: On Thu, Sep 27, 2012 at 02:14:22PM +0200, Daniel Vetter wrote: On Thu, Sep 27, 2012 at 09:27:57AM +0100, Chris Wilson wrote: As SandyBridge returns garbage when decoding certain addresses through the GTT (all memory

Re: [Intel-gfx] [PATCH] drm/i915: Flush pending operations to the CRTC prior to modeset

2012-09-27 Thread Ville Syrjälä
On Thu, Sep 20, 2012 at 11:17:51AM +0200, Daniel Vetter wrote: On Thu, Sep 20, 2012 at 10:56 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: We need to wait for pending operations on the CRTC to retire before we can modify the CRTC. For example, if userspace has queued a batch that uses

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Fix lanecontrol, vswing, preemp for Valleyview DisplayPort

2012-09-27 Thread Vijay Purushothaman
On 9/26/2012 7:54 PM, Daniel Vetter wrote: On Wed, Sep 26, 2012 at 07:07:34PM +0530, Vijay Purushothaman wrote: In Valleyview voltage swing, pre-emphasis and lane control registers can be programmed only through the h/w side band fabric. Also use i9xx_update_pll to program the correct DPLL

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Reverse min, max vco limits for VLV HDMI

2012-09-27 Thread Vijay Purushothaman
On 9/26/2012 8:08 PM, Daniel Vetter wrote: On Wed, Sep 26, 2012 at 07:07:37PM +0530, Vijay Purushothaman wrote: Fixed min, max vco limits for VLV HDMI. Also fixed correct register offset for VLV_VIDEO_DIP_CTL_A Signed-off-by: Vijay Purushothaman vijay.a.purushotha...@intel.com Signed-off-by:

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Enable multi display support in VLV

2012-09-27 Thread Vijay Purushothaman
On 9/26/2012 8:10 PM, Daniel Vetter wrote: On Wed, Sep 26, 2012 at 07:07:38PM +0530, Vijay Purushothaman wrote: From: Bhat, Gajanan gajanan.b...@intel.com Clened up DPLL calculations for Valleyview. Moved DPLL register and DPIO programming to vlv_update_pll function. With all the changes multi

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Add eDP support for Valleyview

2012-09-27 Thread Vijay Purushothaman
On 9/26/2012 8:19 PM, Daniel Vetter wrote: On Wed, Sep 26, 2012 at 04:31:46PM +0200, Daniel Vetter wrote: On Wed, Sep 26, 2012 at 07:07:35PM +0530, Vijay Purushothaman wrote: Eventhough Valleyview display block is derived from Cantiga, VLV supports eDP. So, added eDP checks in

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Add eDP support for Valleyview

2012-09-27 Thread Vijay Purushothaman
On 9/27/2012 12:48 PM, Jani Nikula wrote: On Wed, 26 Sep 2012, Daniel Vetter dan...@ffwll.ch wrote: On Wed, Sep 26, 2012 at 07:07:35PM +0530, Vijay Purushothaman wrote: diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index a8a81d1..aee6151 100644 ---

[Intel-gfx] [PATCH v2 0/9] Enable all display interfaces in Valleyview

2012-09-27 Thread Vijay Purushothaman
This patch set enables all supported display interfaces like HDMI, DisplayPort and eDP for Valleyview. This also enables support for multi-display configurations. v2: Addressed review comments from Daniel and Jani Nikula. Gajanan Bhat (1): drm/i915: Add eDP support for Valleyview Vijay

[Intel-gfx] [PATCH v2 1/9] drm/i915: Set aux clk to 100MHz for Valleyview

2012-09-27 Thread Vijay Purushothaman
Set hrawclk to 200 MHz and aux divider clock to 100 MHz for Valleyview. This enables the aux transactions in Valleyview. Signed-off-by: Vijay Purushothaman vijay.a.purushotha...@intel.com Signed-off-by: Ben Widawsky benjamin.widaw...@intel.com --- drivers/gpu/drm/i915/intel_dp.c |8 +++-

[Intel-gfx] [PATCH v2 2/9] drm/i915: Fix SDVO IER and status bits for Valleyview

2012-09-27 Thread Vijay Purushothaman
Fixed SDVOB and SDVOC bit definitions for Valleyview. Signed-off-by: Vijay Purushothaman vijay.a.purushotha...@intel.com Signed-off-by: Ben Widawsky benjamin.widaw...@intel.com --- drivers/gpu/drm/i915/i915_irq.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[Intel-gfx] [PATCH v2 4/9] drm/i915: Program correct m n tu register for Valleyview

2012-09-27 Thread Vijay Purushothaman
m n tu register offset has changed in Valleyview. Also fixed DP limit frequencies. Signed-off-by: Vijay Purushothaman vijay.a.purushotha...@intel.com Signed-off-by: Ben Widawsky benjamin.widaw...@intel.com --- drivers/gpu/drm/i915/intel_display.c |6 +++--- drivers/gpu/drm/i915/intel_dp.c

[Intel-gfx] [PATCH v2 3/9] drm/i915: Add Valleyview lane control definitions

2012-09-27 Thread Vijay Purushothaman
Added DPIO data lane register definitions for Valleyview Signed-off-by: Vijay Purushothaman vijay.a.purushotha...@intel.com Signed-off-by: Ben Widawsky benjamin.widaw...@intel.com --- drivers/gpu/drm/i915/i915_reg.h |8 1 file changed, 8 insertions(+) diff --git

[Intel-gfx] [PATCH v2 6/9] drm/i915: Enable DisplayPort in Valleyview

2012-09-27 Thread Vijay Purushothaman
In valleyview voltageswing, pre-emphasis and lane control registers can be programmed only through the h/w side band fabric. Cleaned up DPLL calculations for Valleyview to support multi display configurations. v2: Based on Daniel's feedbacak, moved crt hotplug detect work around as separate

[Intel-gfx] [PATCH v2 5/9] drm/i915: Disable CRT hotplug detection for valleyview

2012-09-27 Thread Vijay Purushothaman
Temporary work around to avoid spurious crt hotplug interrupts. Signed-off-by: Vijay Purushothaman vijay.a.purushotha...@intel.com Signed-off-by: Gajanan Bhat gajanan.b...@intel.com --- drivers/gpu/drm/i915/intel_crt.c |7 +++ 1 file changed, 7 insertions(+) diff --git

[Intel-gfx] [PATCH v2 7/9] drm/i915: Add eDP support for Valleyview

2012-09-27 Thread Vijay Purushothaman
From: Gajanan Bhat gajanan.b...@intel.com Eventhough Valleyview display block is derived from Cantiga, VLV supports eDP. So, added eDP checks in i9xx_crtc_mode_set path. v2: use different DPIO_DIVISOR values for VGA, DP and eDP v3: fix DPIO value calculation to use same values for all display

[Intel-gfx] [PATCH v2 9/9] drm/i915: Fixup HDMI output on Valleyview

2012-09-27 Thread Vijay Purushothaman
Fixed correct min, max vco limits and dip ctl reg Signed-off-by: Vijay Purushothaman vijay.a.purushotha...@intel.com Signed-off-by: Gajanan Bhat gajanan.b...@intel.com Signed-off-by: Ben Widawsky benjamin.widaw...@intel.com --- drivers/gpu/drm/i915/i915_reg.h |2 +-

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Add eDP support for Valleyview

2012-09-27 Thread Daniel Vetter
On Thu, Sep 27, 2012 at 07:08:41PM +0530, Vijay Purushothaman wrote: On 9/26/2012 8:19 PM, Daniel Vetter wrote: On Wed, Sep 26, 2012 at 04:31:46PM +0200, Daniel Vetter wrote: On Wed, Sep 26, 2012 at 07:07:35PM +0530, Vijay Purushothaman wrote: Eventhough Valleyview display block is derived

Re: [Intel-gfx] [PATCH v2 1/9] drm/i915: Set aux clk to 100MHz for Valleyview

2012-09-27 Thread Jesse Barnes
On Thu, 27 Sep 2012 19:13:01 +0530 Vijay Purushothaman vijay.a.purushotha...@intel.com wrote: Set hrawclk to 200 MHz and aux divider clock to 100 MHz for Valleyview. This enables the aux transactions in Valleyview. Signed-off-by: Vijay Purushothaman vijay.a.purushotha...@intel.com

Re: [Intel-gfx] [PATCH v2 2/9] drm/i915: Fix SDVO IER and status bits for Valleyview

2012-09-27 Thread Jesse Barnes
On Thu, 27 Sep 2012 19:13:02 +0530 Vijay Purushothaman vijay.a.purushotha...@intel.com wrote: Fixed SDVOB and SDVOC bit definitions for Valleyview. Signed-off-by: Vijay Purushothaman vijay.a.purushotha...@intel.com Signed-off-by: Ben Widawsky benjamin.widaw...@intel.com ---

Re: [Intel-gfx] [PATCH v2 4/9] drm/i915: Program correct m n tu register for Valleyview

2012-09-27 Thread Jesse Barnes
On Thu, 27 Sep 2012 19:13:04 +0530 Vijay Purushothaman vijay.a.purushotha...@intel.com wrote: m n tu register offset has changed in Valleyview. Also fixed DP limit frequencies. Signed-off-by: Vijay Purushothaman vijay.a.purushotha...@intel.com Signed-off-by: Ben Widawsky

Re: [Intel-gfx] [PATCH v2 5/9] drm/i915: Disable CRT hotplug detection for valleyview

2012-09-27 Thread Jesse Barnes
On Thu, 27 Sep 2012 19:13:05 +0530 Vijay Purushothaman vijay.a.purushotha...@intel.com wrote: Temporary work around to avoid spurious crt hotplug interrupts. Signed-off-by: Vijay Purushothaman vijay.a.purushotha...@intel.com Signed-off-by: Gajanan Bhat gajanan.b...@intel.com ---

Re: [Intel-gfx] [PATCH v2 6/9] drm/i915: Enable DisplayPort in Valleyview

2012-09-27 Thread Jesse Barnes
On Thu, 27 Sep 2012 19:13:06 +0530 Vijay Purushothaman vijay.a.purushotha...@intel.com wrote: In valleyview voltageswing, pre-emphasis and lane control registers can be programmed only through the h/w side band fabric. Cleaned up DPLL calculations for Valleyview to support multi display

Re: [Intel-gfx] [PATCH] drm/i915: Valleyview doesn't have rc6+ or rc6++

2012-09-27 Thread Daniel Vetter
On Thu, Sep 27, 2012 at 5:34 PM, Ben Widawsky b...@bwidawsk.net wrote: On Wed, 26 Sep 2012 14:06:36 +0200 Daniel Vetter dan...@ffwll.ch wrote: On Mon, Sep 17, 2012 at 05:10:15PM -0700, Ben Widawsky wrote: I do not currently have a VLV to test this on, but hopefully it only removes

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Extract PCU communication

2012-09-27 Thread Jesse Barnes
On Wed, 26 Sep 2012 10:34:00 -0700 Ben Widawsky b...@bwidawsk.net wrote: There is a special mechanism for communicating with the PCU already being used for the ring frequency stuff. As we'll be needing this for other commands, extract it now to make future code less error prone and the

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Workaround to bump rc6 voltage to 450

2012-09-27 Thread Jesse Barnes
On Wed, 26 Sep 2012 10:34:01 -0700 Ben Widawsky b...@bwidawsk.net wrote: BIOS should be setting the minimum voltage for rc6 to be 450mV. Old or buggy BIOSen may not be doing this, so we correct it for them. Ideally customers should update the BIOS as only it would know the optimal values for

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Add rc6vids to debugfs

2012-09-27 Thread Jesse Barnes
On Wed, 26 Sep 2012 10:34:02 -0700 Ben Widawsky b...@bwidawsk.net wrote: CC: Jesse Barnes jbar...@virtuousgeek.org Signed-off-by: Ben Widawsky b...@bwidawsk.net --- drivers/gpu/drm/i915/i915_debugfs.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] Stereo 3D modes support v2

2012-09-27 Thread Damien Lespiau
This series is the second revison of: http://lists.freedesktop.org/archives/intel-gfx/2012-September/020457.html It changes the way 3d modes are exposed to user-space: - An expose 3D modes property can be installed on connectors that support stereo 3D - User space can indicate through that

[Intel-gfx] [PATCH 1/3] drm: Add an expose 3d modes property

2012-09-27 Thread Damien Lespiau
From: Damien Lespiau damien.lesp...@intel.com The expose 3D modes property can be attached to connectors to allow user space to indicate it can deal with 3D modes and that the drm driver should expose those 3D modes. Signed-off-by: Damien Lespiau damien.lesp...@intel.com ---

[Intel-gfx] [PATCH 3/3] drm/i915: Add HDMI vendor info frame support

2012-09-27 Thread Damien Lespiau
From: Damien Lespiau damien.lesp...@intel.com When scanning out a 3D framebuffer, send the corresponding infoframe to the HDMI sink. See http://www.hdmi.org/manufacturer/specification.aspx for details. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- drivers/gpu/drm/i915/intel_drv.h

[Intel-gfx] [PATCH 2/3] drm: Parse the HDMI cea vendor block for 3D present

2012-09-27 Thread Damien Lespiau
From: Damien Lespiau damien.lesp...@intel.com For now, let's just look at the 3D_present flag of the CEA HDMI vendor block to detect if the sink supports a small list of then mandatory 3D formats. See the HDMI 1.4a 3D extraction for detail: http://www.hdmi.org/manufacturer/specification.aspx

[Intel-gfx] [PATCH 1/2] lib: Dump information about the supported 3D stereo formats

2012-09-27 Thread Damien Lespiau
From: Damien Lespiau damien.lesp...@intel.com When dumping the details of a mode, let's add the 3D formats the mode supports. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- lib/drmtest.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/lib/drmtest.c

[Intel-gfx] [PATCH] drm/i915: Flush the pending flips on the CRTC before modification

2012-09-27 Thread Chris Wilson
This was meant to be the purpose of the intel_crtc_wait_for_pending_flips() function which is called whilst preparing the CRTC for a modeset or before disabling. However, as Ville Syrjala pointed out, we set the pending flip notification on the old framebuffer that is no longer attached to the

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Workaround to bump rc6 voltage to 450

2012-09-27 Thread Dave Airlie
On Fri, Sep 28, 2012 at 4:05 AM, Jesse Barnes jbar...@virtuousgeek.org wrote: On Wed, 26 Sep 2012 10:34:01 -0700 Ben Widawsky b...@bwidawsk.net wrote: BIOS should be setting the minimum voltage for rc6 to be 450mV. Old or buggy BIOSen may not be doing this, so we correct it for them. Ideally