[Intel-gfx] Question about pci memory space address

2013-05-20 Thread ZHANG Zhaolong
Here is a system for example: Pentium M processor with 32bits address pins, Intel 440FX chip, A PCI device with 32bits address pins. See the ascii picture below. Assume that the pci device BAR0 is in memory space, 10Mb in size. After initialization, BAR0 is assigned an address. I don't

[Intel-gfx] [PATCH 1/2 V4] i915/drm: Add private api for power well usage

2013-05-20 Thread Wang Xingchao
Haswell Display audio depends on power well in graphic side, it should request power well before use it and release power well after use. I915 will not shutdown power well if it detects audio is using. This patch protects display audio crash for Intel Haswell C3 stepping board. Signed-off-by:

Re: [Intel-gfx] [PATCH 1/2 V3] drm/915: Add private api for power well usage

2013-05-20 Thread Wang, Xingchao
Hi Jesse, -Original Message- From: Barnes, Jesse Sent: Friday, May 17, 2013 11:44 PM To: Wang Xingchao Cc: ti...@suse.de; dan...@ffwll.ch; Girdwood, Liam R; david.hennings...@canonical.com; Lin, Mengdong; Li, Jocelyn; alsa-de...@alsa-project.org; intel-gfx@lists.freedesktop.org;

Re: [Intel-gfx] [PATCH 9/9] drm/i915: set FORCE_ARB_IDLE_PLANES workaround

2013-05-20 Thread Ville Syrjälä
On Fri, May 03, 2013 at 05:23:45PM -0300, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com Commit 1544d9d57396d5c0c6b7644ed5ae1f4d6caad07a added a workaround inside haswell_init_clock_gating and mentioned it is a workaround for early silicon revisions and should be removed

Re: [Intel-gfx] [PATCH 8/9] drm/i915: MCH_SSKPD is a 64 bit register on Haswell

2013-05-20 Thread Ville Syrjälä
On Fri, May 03, 2013 at 05:23:44PM -0300, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com And the SNB_READ_WM0_LATENCY macro is not valid anymore because we have the New WM0 at 63:56, so the Old WM0 could maybe be zero if the new one is not zero. Signed-off-by: Paulo

Re: [Intel-gfx] [PATCH 1/9] drm/i915: ILK, SNB and IVB don't have linetime watermarks

2013-05-20 Thread Ville Syrjälä
On Fri, May 03, 2013 at 05:23:37PM -0300, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com So don't call intel_update_linetime_watermarks from ironlake_crtc_mode_set. Only Haswell has these watermarks. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com Reviewed-by: Ville

Re: [Intel-gfx] [PATCH 3/9] drm/i915: use the mode-htotal to calculate linetime watermarks

2013-05-20 Thread Ville Syrjälä
On Fri, May 03, 2013 at 05:23:39PM -0300, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com ... instead of mode-crtc_display. The spec says pipe horizontal total number of pixels and the Haswell Watermark Calculator tool uses the Pipe H Total instead of Pipe H Src as the value.

Re: [Intel-gfx] [PATCH 2/9] drm/i915: remove intel_update_linetime_watermarks

2013-05-20 Thread Ville Syrjälä
On Thu, May 09, 2013 at 04:55:50PM -0300, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com The spec says the linetime watermarks must be programmed before enabling any display low power watermarks, but we're currently updating the linetime watermarks after we call

Re: [Intel-gfx] [PATCH 4/9] drm/i915: fix haswell linetime watermarks calculation

2013-05-20 Thread Ville Syrjälä
On Fri, May 03, 2013 at 05:23:40PM -0300, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com Move the *8 calculation to the left side so we don't propagate rounding errors. Also use DIV_ROUND_CLOSEST because that's what the spec says we need to do. Signed-off-by: Paulo

Re: [Intel-gfx] [PATCH 5/9] drm/i915: use the correct clock when calculating linetime watermarks

2013-05-20 Thread Ville Syrjälä
On Fri, May 03, 2013 at 05:23:41PM -0300, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com If we're using DP/eDP, adjusted_mode-clock may be just the port link clock, but we also can't use mode-clock because it's wrong when we're using the using panel fitter. Signed-off-by:

Re: [Intel-gfx] [PATCH 7/9] drm/i915: set the IPS linetime watermark

2013-05-20 Thread Ville Syrjälä
On Fri, May 03, 2013 at 05:23:43PM -0300, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com Remove the placeholder comment and set the actual value described by the specification. We still don't enable IPS, but it won't hurt to already have the value set here. While at it,

Re: [Intel-gfx] [PATCH 6/9] drm/i915: make intel_ddi_get_cdclk_freq return values in KHz

2013-05-20 Thread Ville Syrjälä
On Fri, May 03, 2013 at 05:23:42PM -0300, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com With this, that 338 can finally become the correct 337500. Due to the change we need to adjust the intel_dp_aux_ch function to set the correct value, so adjust the division and also

[Intel-gfx] Updated drm-intel-test

2013-05-20 Thread Daniel Vetter
Hi all, New testing round with a bit fewer patches since I've been travelling last week. Usual pace should pick up again ;-) Highlights: - fbc support for Haswell (Rodrigo) - streamlined workaround comments, including an igt tool to grep for them (Damien) - sdvo and TV out cleanups, including a

Re: [Intel-gfx] [PATCH V2] drm/i915: force full modeset if the connector is in DPMS OFF mode

2013-05-20 Thread Jesse Barnes
On Fri, 3 May 2013 19:44:07 +0200 Egbert Eich e...@suse.de wrote: From: Imre Deak imre.d...@intel.com Currently the driver's assumed behavior for a modeset with an attached FB is that the corresponding connector will be switched to DPMS ON mode if it happened to be in DPMS OFF (or another

[Intel-gfx] linux-next: manual merge of the drm-intel tree with Linus' tree

2013-05-20 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in drivers/gpu/drm/i915/intel_dp.c between commit 657445fe8660 (Revert drm/i915: revert eDP bpp clamping code changes) from Linus' tree and commits c6bb353815c3 (drm/i915: move dp clock computations to encoder-compute_config),