Re: [Intel-gfx] [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-14 Thread Aaron Lu
On 06/10/2013 07:01 AM, Matthew Garrett wrote: Windows 8 leaves backlight control up to individual graphics drivers rather than making ACPI calls itself. There's plenty of evidence to suggest that the Intel driver for Windows doesn't use the ACPI interface, including the fact that it's broken

Re: [Intel-gfx] [PATCH] drm/i915: Remove extra ring from error message

2013-06-14 Thread Daniel Vetter
On Thu, Jun 13, 2013 at 09:33:33PM -0700, Ben Widawsky wrote: The ring names already have ring in it. CC: Chris Wilson ch...@chris-wilson.co.uk Signed-off-by: Ben Widawsky b...@bwidawsk.net Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation

Re: [Intel-gfx] [PATCH] drm/i915: Kill useless Enable panel fitter comments

2013-06-14 Thread Daniel Vetter
On Thu, Jun 13, 2013 at 06:19:39PM -0700, Jesse Barnes wrote: On Fri, 14 Jun 2013 00:51:23 +0200 Daniel Vetter daniel.vet...@ffwll.ch wrote: Now that we have this all nicely abstract into separate functions with self-documenting names this is pointless. And as Yuly Novikov spotted in the

[Intel-gfx] [PATCH 2/2] drm/i915: s/LFP/LPF in DPIO PLL register names

2013-06-14 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com LPF is short for low pass filter. Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com --- drivers/gpu/drm/i915/i915_debugfs.c | 8 drivers/gpu/drm/i915/i915_reg.h | 6 +++--- drivers/gpu/drm/i915/intel_display.c | 4 ++-- 3

[Intel-gfx] [PATCH 2/10 v2] drm/i915: We implement WaFbcAsynchFlipDisableFbcQueue on ilk and snb

2013-06-14 Thread Damien Lespiau
v2: Put the comment a bit closer to the actual write (Paulo Zanoni) Reviewed-by: Paulo Zanoni paulo.r.zan...@intel.com Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- drivers/gpu/drm/i915/intel_pm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_pm.c

[Intel-gfx] [PATCH 0/4] Haswell Display audio routing bug fix

2013-06-14 Thread Wang Xingchao
This patchset used to fix some display audio issues on Haswell platform. I tested this patch on Haswell ult board, C0 stepping, with eDP pannel, HDMI monitor, DP monitor. The fixed issues: 1) when only HDMI or DP monitor connected, hear sound on ALL three HDMI devices. 2) when HDMI + DP monitors

[Intel-gfx] [PATCH 2/4] ALSA: hda - Return error when open empty hdmi device

2013-06-14 Thread Wang Xingchao
when user open HDMI device 3/7/8, if it has no physical device connected, return error. The bug is from Haswell platform, All pins choose converter 0 by default in hardware level, maybe only pin 1 had valid monitor connected. if user play audio on pin 0/2, pin 1 can get audio data too.

[Intel-gfx] [PATCH 3/4] drm/i915: Add display audio routing APIs for ALSA

2013-06-14 Thread Wang Xingchao
ALSA audio driver need know current audio routing infomation. i.e. Route map between codec pins(DDI ports) and Transcoders(Pipe). Also the new API let audio driver disable unused audio pin's output. This fixed the bug when three pins *ALL* have monitors connected, playing audio on one pin would

[Intel-gfx] [PATCH 4/4] ALSA: hda - Add display audio routing API for haswell

2013-06-14 Thread Wang Xingchao
ALSA side use these apis to know display audio routing map in gfx side. And use the API to disable unused pin's audio output. Signed-off-by: Wang Xingchao xingchao.w...@linux.intel.com --- sound/pci/hda/hda_i915.c | 83 ++ sound/pci/hda/hda_i915.h

Re: [Intel-gfx] [PATCH 27/31] drm/i915: move i9xx dpll enabling into crtc enable function

2013-06-14 Thread Imre Deak
On Wed, 2013-06-05 at 13:34 +0200, Daniel Vetter wrote: Now that we have the proper pipe config to track this, we don't need to write any registers any more. v2: Drop a few now unnecessary local variables and switch the enable function to take a struct intel_crtc * to simply arguments.

Re: [Intel-gfx] [PATCH 01/13] drm: Added SDP and VSC structures for handling PSR for eDP

2013-06-14 Thread Paulo Zanoni
2013/6/12 Rodrigo Vivi rodrigo.v...@gmail.com: From: Shobhit Kumar shobhit.ku...@intel.com v2: Modified and corrected the structures to be more in line for kernel coding guidelines and rebased the code on Paulo's DP patchset v3: removing unecessary identation at DP_RECEIVER_CAP_SIZE v4:

Re: [Intel-gfx] [PATCH 0/3]

2013-06-14 Thread Greg Kroah-Hartman
On Thu, Jun 13, 2013 at 10:22:05AM +0200, Daniel Vetter wrote: On Thu, Jun 06, 2013 at 04:59:26PM +0300, Jani Nikula wrote: With Greg's address fixed. Please drop the old one from any replies. Sorry for the noise. Oops, replied with the old one still there. Greg, Andrew: Imo it's

Re: [Intel-gfx] [PATCH 02/13] drm/i915: Read the EDP DPCD and PSR Capability

2013-06-14 Thread Paulo Zanoni
2013/6/12 Rodrigo Vivi rodrigo.v...@gmail.com: From: Shobhit Kumar shobhit.ku...@intel.com v2: reuse of just created is_edp_psr and put it at right place. v3: move is_edp_psr above intel_edp_disable Signed-off-by: Shobhit Kumar shobhit.ku...@intel.com Signed-off-by: Rodrigo Vivi

Re: [Intel-gfx] [PATCH 04/13] drm/i915: split aux_clock_divider logic in a separated function for reuse.

2013-06-14 Thread Paulo Zanoni
2013/6/12 Rodrigo Vivi rodrigo.v...@gmail.com: Prep patch for reuse aux_clock_divider with EDP_PSR_AUX_CTL setup. Signed-off-by: Rodrigo Vivi rodrigo.v...@gmail.com I've seen this patch on this mailing list a few times already, and it's just a prep-work for PSR, so I guess we could merge it

Re: [Intel-gfx] [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-14 Thread Matthew Garrett
On Fri, 2013-06-14 at 14:47 +0800, Aaron Lu wrote: What about a priority based solution? We can introduce a new field named priority to backlight_device and instead of calling another module's function like the unregister one here(which cause unnecessary module dependency), we only need to

Re: [Intel-gfx] [PATCH 2/2] drm/i915: repin bound framebuffers on resume

2013-06-14 Thread Stéphane Marchesin
On Wed, Jun 12, 2013 at 3:06 PM, Jesse Barnes jbar...@virtuousgeek.org wrote: On Wed, 12 Jun 2013 00:48:25 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, Jun 11, 2013 at 04:01:21PM -0700, Stéphane Marchesin wrote: On Tue, Jun 11, 2013 at 3:57 PM, Chris Wilson

Re: [Intel-gfx] [PATCH 1/2] drm/i915: tune the RC6 threshold for stability

2013-06-14 Thread Stéphane Marchesin
On Wed, Jun 12, 2013 at 2:41 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, Jun 11, 2013 at 03:49:26PM -0700, Stéphane Marchesin wrote: It's basically the same deal as the RC6+ issues on ivy bridge except this time with RC6 on sandy bridge. Like last time the core of the issue is

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Add display audio routing APIs for ALSA

2013-06-14 Thread Daniel Vetter
On Fri, Jun 14, 2013 at 5:20 PM, Wang Xingchao xingchao.w...@linux.intel.com wrote: ALSA audio driver need know current audio routing infomation. i.e. Route map between codec pins(DDI ports) and Transcoders(Pipe). Also the new API let audio driver disable unused audio pin's output. This fixed

Re: [Intel-gfx] [PATCH 2/2] drm/i915: repin bound framebuffers on resume

2013-06-14 Thread Daniel Vetter
On Fri, Jun 14, 2013 at 9:12 PM, Stéphane Marchesin marc...@chromium.org wrote: On Wed, Jun 12, 2013 at 3:06 PM, Jesse Barnes jbar...@virtuousgeek.org wrote: On Wed, 12 Jun 2013 00:48:25 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, Jun 11, 2013 at 04:01:21PM -0700, Stéphane

Re: [Intel-gfx] [PATCH 1/2] drm/i915: tune the RC6 threshold for stability

2013-06-14 Thread Daniel Vetter
On Fri, Jun 14, 2013 at 9:13 PM, Stéphane Marchesin marc...@chromium.org wrote: On Wed, Jun 12, 2013 at 2:41 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, Jun 11, 2013 at 03:49:26PM -0700, Stéphane Marchesin wrote: It's basically the same deal as the RC6+ issues on ivy bridge

Re: [Intel-gfx] [PATCH 0/3]

2013-06-14 Thread Daniel Vetter
On Fri, Jun 14, 2013 at 6:23 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Jun 13, 2013 at 10:22:05AM +0200, Daniel Vetter wrote: On Thu, Jun 06, 2013 at 04:59:26PM +0300, Jani Nikula wrote: With Greg's address fixed. Please drop the old one from any replies. Sorry for

Re: [Intel-gfx] [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-14 Thread Aaron Lu
On 06/15/2013 01:29 AM, Matthew Garrett wrote: On Fri, 2013-06-14 at 14:47 +0800, Aaron Lu wrote: What about a priority based solution? We can introduce a new field named priority to backlight_device and instead of calling another module's function like the unregister one here(which cause

Re: [Intel-gfx] [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-14 Thread Matthew Garrett
On Sat, 2013-06-15 at 09:26 +0800, Aaron Lu wrote: On 06/15/2013 01:29 AM, Matthew Garrett wrote: How would that work with existing userspace? User space tool will need to be updated to use this as stated in the gist page, I've patches for gsd-backlight-helper and xorg-x11-drv-intel, for

Re: [Intel-gfx] [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-14 Thread Aaron Lu
On 06/15/2013 09:38 AM, Matthew Garrett wrote: On Sat, 2013-06-15 at 09:26 +0800, Aaron Lu wrote: It's not easy to decide if they work or not sometimes, e.g. I came across a system that claims win8 in ACPI table and has an Intel GPU, while its ACPI video interface also works. With this patch,

Re: [Intel-gfx] [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-14 Thread Matthew Garrett
On Sat, Jun 15, 2013 at 12:14:42PM +0800, Aaron Lu wrote: On 06/15/2013 09:38 AM, Matthew Garrett wrote: Well, Windows 8 will only use the ACPI backlight interface if the GPU driver decides to, right? So the logic for deciding whether to remove the ACPI backlight control or not should be