[Intel-gfx] [PATCH v2] drm/i915: restore backlight precision when converting from opregion

2014-05-04 Thread Aaron Lu
On 04/28/2014 09:41 PM, Daniel Vetter wrote: 64bit divisions won't compile on 32bit. You need one of the DO_DIV macros, or whatever they're called again. I pain, I know ;-) Thanks for the correction, here is an updated patch :-) From: Aaron Lu aaron...@intel.com Date: Mon, 28 Apr 2014 11:02:52

Re: [Intel-gfx] [PATCH v2] drm/i915: restore backlight precision when converting from opregion

2014-05-04 Thread Chris Wilson
On Sun, May 04, 2014 at 03:16:05PM +0800, Aaron Lu wrote: On 04/28/2014 09:41 PM, Daniel Vetter wrote: 64bit divisions won't compile on 32bit. You need one of the DO_DIV macros, or whatever they're called again. I pain, I know ;-) Thanks for the correction, here is an updated patch :-)

Re: [Intel-gfx] [PATCH v2] drm/i915: restore backlight precision when converting from opregion

2014-05-04 Thread Aaron Lu
On 05/04/2014 03:22 PM, Chris Wilson wrote: On Sun, May 04, 2014 at 03:16:05PM +0800, Aaron Lu wrote: On 04/28/2014 09:41 PM, Daniel Vetter wrote: 64bit divisions won't compile on 32bit. You need one of the DO_DIV macros, or whatever they're called again. I pain, I know ;-) Thanks for the

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Changed the return type from 'void', so as to return an error

2014-05-04 Thread Akash Goel
On Tue, 2014-04-29 at 16:33 +0300, Ville Syrjälä wrote: On Sun, Apr 20, 2014 at 04:22:48PM +0530, akash.g...@intel.com wrote: From: Akash Goel akash.g...@intel.com This patch changes the return type of panel fitter configuration functions from 'void', so that an error could be returned

Re: [Intel-gfx] [PATCH v4 2/4] drm/i915: New drm crtc property for varying the Pipe Src size

2014-05-04 Thread Akash Goel
On Tue, 2014-04-29 at 17:06 +0300, Ville Syrjälä wrote: On Sun, Apr 20, 2014 at 04:14:18PM +0530, akash.g...@intel.com wrote: From: Akash Goel akash.g...@intel.com This patch adds a new drm crtc property for varying the Pipe Src size or the Panel fitter input size. Pipe Src controls the

Re: [Intel-gfx] [PATCH v2] drm/i915: restore backlight precision when converting from opregion

2014-05-04 Thread Chris Wilson
On Sun, May 04, 2014 at 03:31:01PM +0800, Aaron Lu wrote: On 05/04/2014 03:22 PM, Chris Wilson wrote: Also this still has the same rounding error as before. I didn't get this, care to explain? The calculation you use, truncates, rather than say round to nearest, would is the same

[Intel-gfx] [RFC 1/2] drm/i915: Pre-allocation of shmem pages of a GEM object

2014-05-04 Thread akash . goel
From: Akash Goel akash.g...@intel.com This patch could help to reduce the time, 'struct_mutex' is kept locked during either the exec-buffer path or Page fault handling path as now the backing pages are requested from shmem layer without holding the 'struct_mutex'. Signed-off-by: Akash Goel

[Intel-gfx] [RFC 0/2] Reduce the time for which 'struct_mutex' is held

2014-05-04 Thread akash . goel
From: Akash Goel akash.g...@intel.com We are trying to reduce the time for which the global 'struct_mutex' is locked. Execbuffer ioctl is one place where it is generally held for the longest time. And sometimes because of this occasional glitches/flickers are being observed in 60 fps playback

Re: [Intel-gfx] [RFC 0/2] Reduce the time for which 'struct_mutex' is held

2014-05-04 Thread Chris Wilson
On Sun, May 04, 2014 at 04:48:23PM +0530, akash.g...@intel.com wrote: From: Akash Goel akash.g...@intel.com We are trying to reduce the time for which the global 'struct_mutex' is locked. Execbuffer ioctl is one place where it is generally held for the longest time. And sometimes because of

Re: [Intel-gfx] [PATCH v2] drm/i915: restore backlight precision when converting from opregion

2014-05-04 Thread Aaron Lu
On 05/04/2014 06:41 PM, Chris Wilson wrote: On Sun, May 04, 2014 at 03:31:01PM +0800, Aaron Lu wrote: On 05/04/2014 03:22 PM, Chris Wilson wrote: Also this still has the same rounding error as before. I didn't get this, care to explain? The calculation you use, truncates, rather than say

[Intel-gfx] [PATCH v2] drm/i915: Pre-allocation of shmem pages of a GEM object

2014-05-04 Thread akash . goel
From: Akash Goel akash.g...@intel.com This patch could help to reduce the time, 'struct_mutex' is kept locked during either the exec-buffer path or Page fault handling path as now the backing pages are requested from shmem layer without holding the 'struct_mutex'. v2: Fixed the merge issue, due

Re: [Intel-gfx] [PATCH 04/10] drm/i915/chv: Added CHV specific register read and write

2014-05-04 Thread Deepak S
Thanks Ben. Apologies for delayed response. I am incorporating the review comment changes next set of patch review. On Saturday 26 April 2014 03:24 AM, Ben Widawsky wrote: On Mon, Apr 21, 2014 at 01:34:08PM +0530, deepa...@linux.intel.com wrote: From: Deepak S deepa...@linux.intel.com