Hey Gideon,
[CCing intel-gfx mailing list]
On Wed, 4 Jun 2014 20:22:13 +0530 Gideon D'souza wrote:
Thank you so much for your reply.
I did manage to move a bit forward with my issue since my email here.
When the system kinda stuck, I realized I could press Ctrl + Alt + F2
and I had access
On Mon, May 26, 2014 at 03:37:42PM +0530, Vandana Kannan wrote:
In case user has specified an input for aspect ratio through the property,
then the user space value for PAR would take preference over the value from
CEA mode list.
v2: Thierry's review comments.
- Modified the comment
On Mon, May 26, 2014 at 03:34:43PM +0530, Vandana Kannan wrote:
[...]
@@ -1344,6 +1350,27 @@ int drm_mode_create_scaling_mode_property(struct
drm_device *dev)
EXPORT_SYMBOL(drm_mode_create_scaling_mode_property);
/**
+ * drm_mode_create_aspect_ratio_property - create aspect ratio
For no reason at all the public docs lack them, and Dave needs them
for his hpd interrupt rework.
Cc: Dave Airlie airl...@gmail.com
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/i915_reg.h | 6 ++
1 file changed, 6 insertions(+)
diff --git
Added a property to enable user space to set aspect ratio.
This patch contains declaration of the property and code to create the
property.
v2: Thierry's review comments.
- Made aspect ratio enum generic instead of HDMI/CEA specfic
- Removed usage of temporary aspect_ratio
In case user has specified an input for aspect ratio through the property,
then the user space value for PAR would take preference over the value from
CEA mode list.
v2: Thierry's review comments.
- Modified the comment Populate... as per review comments
v3: Thierry's review comments.
On Thu, Jun 05, 2014 at 10:27:42AM +0800, Wendy Wang wrote:
Move rc6_residency_check to subtest, add new rc6_residency_counter subtest
for pm_rc6_residency IGT case.
I don't really understand what you're trying to do here really. Please
explain better in the commit message not just what the
I've fumbled my own idea and enthusiastically wrapped all the
getconnector code with the connection_mutex. But we only need it to
chase the connector-encoder link. Even there it's not really needed
since races with userspace won't matter, but better paranoid and
consistent about this stuff.
If we
On Wed, Jun 04, 2014 at 04:55:20PM -0300, Paulo Zanoni wrote:
2014-06-04 15:47 GMT-03:00 Rodrigo Vivi rodrigo.v...@gmail.com:
Signed-off-by: Rodrigo Vivi rodrigo.v...@gmail.com
Yeah, this seems to make -nightly compile.
Reviewed-by: Paulo Zanoni paulo.r.zan...@intel.com
Sorry my script
On Wed, Jun 04, 2014 at 12:17:14PM -0700, Rodrigo Vivi wrote:
On Wed, May 28, 2014 at 5:57 AM, Daniel Vetter dan...@ffwll.ch wrote:
On Tue, May 27, 2014 at 04:50:14PM -0700, Rodrigo Vivi wrote:
Some registers set during setup might not be persistent after
suspend/resume.
This was
On Wed, Jun 04, 2014 at 01:45:22PM -0700, Jesse Barnes wrote:
This allows the system to enter the lowest power mode during system freeze.
v2: delete force wake timer at suspend (Imre)
v3: add GT work suspend function (Imre)
v4: use uncore forcewake reset (Daniel)
Signed-off-by: Kristen
On Wed, Jun 04, 2014 at 03:29:41PM -0700, clinton.a.tay...@intel.com wrote:
From: Clint Taylor clinton.a.tay...@intel.com
Remove OUI read function from the lower half interrupt handler. Upon
closing the eDP panel lid an HPD interrupt is generated. The lower half
handler calls
On Thu, Jun 05, 2014 at 02:45:29PM +0530, Vandana Kannan wrote:
In case user has specified an input for aspect ratio through the property,
then the user space value for PAR would take preference over the value from
CEA mode list.
v2: Thierry's review comments.
- Modified the comment
On Wed, Jun 04, 2014 at 05:16:25PM -0700, Ben Widawsky wrote:
On Wed, Jun 04, 2014 at 05:09:30PM -0700, Rodrigo Vivi wrote:
BDW uses IVB cursor offsets.
Whithout this patch it is not possible to use multiple outputs with cursor
on BDW.
The cursor gets completely crazy because update
On Thu, Jun 05, 2014 at 11:13:58AM +0200, Daniel Vetter wrote:
On Wed, Jun 04, 2014 at 04:55:20PM -0300, Paulo Zanoni wrote:
2014-06-04 15:47 GMT-03:00 Rodrigo Vivi rodrigo.v...@gmail.com:
Signed-off-by: Rodrigo Vivi rodrigo.v...@gmail.com
Yeah, this seems to make -nightly compile.
On Thu, Jun 05, 2014 at 02:40:08PM +0530, Vandana Kannan wrote:
[...]
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
[...]
/**
+ * drm_mode_create_aspect_ratio_property - create aspect ratio property
+ * @dev: DRM device
+ *
+ * Called by a driver the first time it's
If a semaphore is waiting on another ring, which in turn happens to be
waiting on the first ring, but that second semaphore has been signalled,
we will be able to kick the second ring and so can treat the first ring
as a valid WAIT and not as HUNG.
References:
The DEVICE_TYPE_eDP has been changed to 0x1806 in case of BYT which
can causes wrong detection failures for eDP. Reduce the number of bits
of interest in DEVICE_TYPE_eDP_BITS to just check most relevant and
conclusive ones and ensure they are set in device_class from VBT. This
will ensure that eDP
On Thu, Jun 05, 2014 at 06:25:13PM +0530, Shobhit Kumar wrote:
The DEVICE_TYPE_eDP has been changed to 0x1806 in case of BYT which
can causes wrong detection failures for eDP. Reduce the number of bits
of interest in DEVICE_TYPE_eDP_BITS to just check most relevant and
conclusive ones and
We've several reports from users where the backlight comes up turned off
on starting X, when using video.use_native_backlight=1 (true dmi quirks, will
be the default for 3.16), in combination with having an external display
plugged in:
https://bugzilla.redhat.com/show_bug.cgi?id=1032978
On Thu, 05 Jun 2014, Hans de Goede hdego...@redhat.com wrote:
We've several reports from users where the backlight comes up turned off
on starting X, when using video.use_native_backlight=1 (true dmi quirks, will
be the default for 3.16), in combination with having an external display
plugged
On Thu, Jun 5, 2014 at 5:12 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote:
I've fumbled my own idea and enthusiastically wrapped all the
getconnector code with the connection_mutex. But we only need it to
chase the connector-encoder link. Even there it's not really needed
since races with
On Thu, Jun 05, 2014 at 05:01:23PM +0300, Jani Nikula wrote:
On Thu, 05 Jun 2014, Hans de Goede hdego...@redhat.com wrote:
We've several reports from users where the backlight comes up turned off
on starting X, when using video.use_native_backlight=1 (true dmi quirks,
will
be the default
The global gtt is setup up in 2 parts, so we need to be careful
with the cleanup. For consistency shovel it all into the -cleanup
callback, like with ppgtt.
Noticed because it blew up in the out_gtt: cleanup code while
fiddling with the vgacon code.
Signed-off-by: Daniel Vetter
I don't fully understand the magic of the vt register/unregister
logic, but apparently everything but the inital console (as set
in the conswitchp pointer) is marked with FLAG_MODULE. Which means
if something unregistered the boot vt driver (e.g. i915.ko kicking
out vga_con) there's nothing left
Touching the VGA resources on an IVB EFI machine causes hard hangs when
we then kick out the efifb. Ouch.
Apparently this also prevents unclaimed register errors on hsw and
hard machine hangs on my i855gm when trying to unbind fbcon.
Also, we want this to make I915_FBDEV=n safe.
v2: Rebase and
A bunch of issues:
- We should not kick out the default console (which is tracked in
conswitchp), so check for that.
- Add better error codes so callers can differentiate between something
went wrong and your driver isn't registered already. i915 needs
that so it doesn't fall over when
Currently objects for which the hardware needs a contiguous physical
address are allocated a shadow backing storage to satisfy the contraint.
This shadow buffer is not wired into the normal obj-pages and so the
physical object is incoherent with accesses via the GPU, GTT and CPU. By
setting up the
---
drivers/gpu/drm/i915/i915_drv.c | 6 ++
drivers/gpu/drm/i915/intel_display.c | 9 +
2 files changed, 15 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 0f9e836..a2036b2 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++
On Thu, 5 Jun 2014 11:21:02 +0200
Daniel Vetter dan...@ffwll.ch wrote:
On Wed, Jun 04, 2014 at 01:45:22PM -0700, Jesse Barnes wrote:
This allows the system to enter the lowest power mode during system freeze.
v2: delete force wake timer at suspend (Imre)
v3: add GT work suspend function
On Thu, 5 Jun 2014 16:09:29 +0300
Ville Syrjälä ville.syrj...@linux.intel.com wrote:
On Thu, Jun 05, 2014 at 06:25:13PM +0530, Shobhit Kumar wrote:
The DEVICE_TYPE_eDP has been changed to 0x1806 in case of BYT which
can causes wrong detection failures for eDP. Reduce the number of bits
of
In digging into the async crtc stuff, I found it was going to be really
difficult to prevent other functions from getting clobbered by a delayed
crtc enable or disable. Daniel's work to remove a bunch of the
-mode_set callbacks is a good start, but we still end up doing some reg
reads and writes
From: Ville Syrjälä ville.syrj...@linux.intel.com
Since the 830M dragon popped up again, I figured I'd dig out my old patches
that try to fix it.
I ended up reworking the primary plane code a bit also to eliminate the
DSPCNTR/DSPADDR RMW accesses since those are dangerous on 830M. But I think
From: Ville Syrjälä ville.syrj...@linux.intel.com
Using names initializers when filling out the watermark structs
saves you from having go look up the struct definition every
single time.
Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com
---
drivers/gpu/drm/i915/intel_pm.c | 130
From: Ville Syrjälä ville.syrj...@linux.intel.com
Calling the mode_set hook on DPMS changes doesn't seem to be necessary
for ns2501. Just drop it.
Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com
---
drivers/gpu/drm/i915/intel_dvo.c | 4
1 file changed, 4 deletions(-)
diff --git
From: Ville Syrjälä ville.syrj...@linux.intel.com
The max watermark value for gen2 planes B and C is 0x1f, instead of
the 0x3f that plane A uses.
Also check against the max even if the pipe is disabled since the
FIFO size exceeds the plane B and C max watermark value.
Signed-off-by: Ville
From: Ville Syrjälä ville.syrj...@linux.intel.com
My Fujitsu-Siemens Lifebook S6010 definitely has a VGA connector, but
the VBT says different. Ignore the VBT for 830M since it seems such
old machines would generally have a VGA connector.
This is a regression caused by:
commit
From: Ville Syrjälä ville.syrj...@linux.intel.com
This reverts commit ac6696d3236bd61503f89a1a99680fd7894d5d53.
---
drivers/gpu/drm/i915/intel_display.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index
From: Ville Syrjälä ville.syrj...@linux.intel.com
830M has problems when some of the pipes are disabled. Namely if a
plane, DVO port etc. is currently assigned to a disabled pipe, it
can't moved to the other pipe until the current pipe is also enabled.
To keep things simple just leave both pipes
From: Ville Syrjälä ville.syrj...@linux.intel.com
To more closely match the IEGD ns2501 driver behaviour, call the
mode_set hook while the DVO port is still disabled, then enable the DVO
port, and finally call the dpms hook.
Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com
---
From: Ville Syrjälä ville.syrj...@linux.intel.com
Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com
---
drivers/gpu/drm/i915/dvo_ns2501.c | 17 -
1 file changed, 17 deletions(-)
diff --git a/drivers/gpu/drm/i915/dvo_ns2501.c
b/drivers/gpu/drm/i915/dvo_ns2501.c
index
From: Ville Syrjälä ville.syrj...@linux.intel.com
Try to use the same programming sequence as used by the IEGD driver.
Also shovel the magic register values into a big static const array.
The register values are actually the based on what the BIOS programs
on the Fujitsu-Siemens Lifebook S6010.
From: Ville Syrjälä ville.syrj...@linux.intel.com
Move the entire DSPCNTR register setup into the .update_primary_plane()
functions. That's where it belongs anyway and it'll also help 830M which
has the extra problem that plane registers reads will return the value
latched at the last vblank, not
From: Ville Syrjälä ville.syrj...@linux.intel.com
Make the intel_{enable,disable}_primary_hw_plane() simply call
.update_primary_plane(), thus eliminating the rmw from these functions
which should help the poor old 830M.
Now we can also remove the .update_primary_plane() from the
.crtc_enable()
From: Ville Syrjälä ville.syrj...@linux.intel.com
The vbt on my Fujitsu-Siemens Lifebook S6010 provides two 800x600 modes,
60Hz and 56Hz. The magic register values we have correspond to the 60Hz
mode, and as I don't know how one would trick the VGA BIOS to set up
the 56Hz mode we can't get the
From: Ville Syrjälä ville.syrj...@linux.intel.com
The spec says:
For the correct operation of the muxed DVO pins (GDEVSELB/ I2Cdata,
GIRDBY/I2CClk) and (GFRAMEB/DVI_Data, GTRDYB/DVI_Clk): Bit 31
(DPLL VCO Enable) and Bit 30 (2X Clock Enable) must be set to “1” in
both the DPLL A Control Register
From: Ville Syrjälä ville.syrj...@linux.intel.com
On Fujitsu-Siememens S6010 the ns2501 chip is hooked up to DVOB instead
of DVOC.
FIXME: Maybe need to dig out the correct DVO port from VBT
Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com
---
drivers/gpu/drm/i915/intel_dvo.c | 2 +-
On Wed, 4 Jun 2014 08:04:53 -0700
Stéphane Marchesin marc...@chromium.org wrote:
We could have dpms standby mean backlight off, everything else on,
similarly to what you want by 0 backlight meaning off. So you could
switch between dpms on/standby more quickly. The point in that is that
On Wed, 2014-06-04 at 08:04 -0700, Stéphane Marchesin wrote:
Well, for example ACPI backlight isn't the default on intel, instead
i915 implements its own backlight. ACPI backlight doesn't support as
many backlight levels as the native backlight for example. So I do
think that ACPI backlight
From: Ville Syrjälä ville.syrj...@linux.intel.com
On most gen2-4 platforms the GTT can be (or maybe always is?)
inside the stolen memory region. If that's the case, reduce the
size of the stolen memory appropriately to make make sure we
don't clobber the GTT.
v2: Deal with gen4 36 bit physical
On Thu, Jun 05, 2014 at 10:27:42AM +0800, Wendy Wang wrote:
Move rc6_residency_check to subtest, add new rc6_residency_counter subtest
for pm_rc6_residency IGT case.
Looks good to me. You have some formatting issues:
for loops don't use the right coding style
useless comment to fopen
bad
Jesse noticed that the punit communication needed to query the VLV power
well status can cause substantial delays. Since we can query the state
frequently, for example during I2C transfers, maintain a cached version
of the HW state to get rid of this delay.
This fixes at least one reported
On Thu, 5 Jun 2014 20:31:47 +0300
Imre Deak imre.d...@intel.com wrote:
Jesse noticed that the punit communication needed to query the VLV power
well status can cause substantial delays. Since we can query the state
frequently, for example during I2C transfers, maintain a cached version
of
On Thu, 2014-06-05 at 10:35 -0700, Jesse Barnes wrote:
On Thu, 5 Jun 2014 20:31:47 +0300
Imre Deak imre.d...@intel.com wrote:
Jesse noticed that the punit communication needed to query the VLV power
well status can cause substantial delays. Since we can query the state
frequently, for
Let them eat mincemeat pie.
Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org
---
drivers/gpu/drm/i915/i915_params.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_params.c
b/drivers/gpu/drm/i915/i915_params.c
index d05a2af..081ab2f 100644
Some machines may have a broken VBT or no VBT at all, but we still want
to use SSC there. So check for it and keep it enabled if we see it
already on. Based on an earlier fix from Kristian.
v2: honor modparam if set too (Daniel)
read out at init time and store for panel_use_ssc() use
From: Kristian Høgsberg hoegsb...@gmail.com
The BIOS may set a native mode that doesn't quite match the preferred
mode timings. It should be ok to use however if it uses the same size,
so try to avoid a mode set in that case.
Signed-off-by: Kristian Høgsberg hoegsb...@gmail.com
Signed-off-by:
From: Kristian Høgsberg hoegsb...@gmail.com
Like mode_equal but w/o the clock checks. Useful for checking if modes
are close enough to re-use to avoid a boot time mode set for example.
Signed-off-by: Kristian Høgsberg hoegsb...@gmail.com
Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org
---
Some machines (like MBAs) might use a tiled framebuffer but not enable
display swizzling at boot time. We want to preserve that configuration
if possible to prevent a boot time mode set. On IVB+ it shouldn't
affect performance anyway since the memory controller does internal
swizzling anyway.
Hi,
On 06/05/2014 04:29 PM, Chris Wilson wrote:
On Thu, Jun 05, 2014 at 05:01:23PM +0300, Jani Nikula wrote:
On Thu, 05 Jun 2014, Hans de Goede hdego...@redhat.com wrote:
We've several reports from users where the backlight comes up turned off
on starting X, when using
On Thu, Jun 5, 2014 at 7:19 PM, Ben Widawsky b...@bwidawsk.net wrote:
On Thu, Jun 05, 2014 at 10:27:42AM +0800, Wendy Wang wrote:
Move rc6_residency_check to subtest, add new rc6_residency_counter subtest
for pm_rc6_residency IGT case.
Looks good to me. You have some formatting issues:
for
On Thu, Jun 05, 2014 at 09:08:33PM +0200, Hans de Goede wrote:
Note that it is read after the framebuffer has been resized and a new mode
has been set on pipe 0 using LVDS1, could this perhaps cause the 0 to be
read when using actual_brightness ?
Indeed, that is likely the explanation, and
On Thu, Jun 05, 2014 at 07:15:50PM +0300, ville.syrj...@linux.intel.com wrote:
From: Ville Syrjälä ville.syrj...@linux.intel.com
Using names initializers when filling out the watermark structs
saves you from having go look up the struct definition every
single time.
Signed-off-by: Ville
This may take awhile (~10ms), and we don't need to make noise about it.
References: https://bugs.freedesktop.org/show_bug.cgi?id=75244
Tested-by: huax...@intel.com
Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org
---
drivers/gpu/drm/i915/intel_pm.c | 4
1 file changed, 4 deletions(-)
Am 05.06.2014 22:43, schrieb Chris Wilson:
On Thu, Jun 05, 2014 at 07:15:50PM +0300, ville.syrj...@linux.intel.com wrote:
From: Ville Syrjäläville.syrj...@linux.intel.com
Using names initializers when filling out the watermark structs
saves you from having go look up the struct definition
Adding missing Display mmio reg offset.
Credits-to: Laws, Philip philip.l...@intel.com
Cc: He, Shuang shuang...@intel.com
Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com
---
drivers/gpu/drm/i915/i915_reg.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Update on the 830MG Updates:
As Ville already said, resume from suspend-to-ram is broken. No
surprise, old broken bios. However, there is a big difference between
the kernel with the pipe-A quirk disabled, and the one with pipe-a and
pipe-b quirks enabled: If resumed without the quirk, the
On Thu, Jun 05, 2014 at 07:16:02PM +0300, ville.syrj...@linux.intel.com wrote:
From: Ville Syrjälä ville.syrj...@linux.intel.com
Move the entire DSPCNTR register setup into the .update_primary_plane()
functions. That's where it belongs anyway and it'll also help 830M which
has the extra
On Thu, Jun 05, 2014 at 07:16:03PM +0300, ville.syrj...@linux.intel.com wrote:
From: Ville Syrjälä ville.syrj...@linux.intel.com
Make the intel_{enable,disable}_primary_hw_plane() simply call
.update_primary_plane(), thus eliminating the rmw from these functions
which should help the poor
on Linus' trees ...
but here it include all of yesterday's drm tree as well.
I have used the drm-intel-fixes tree from next-20140605 for today.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
signature.asc
Description: PGP signature
On 6/5/2014 9:34 PM, Jesse Barnes wrote:
On Thu, 5 Jun 2014 16:09:29 +0300
Ville Syrjälä ville.syrj...@linux.intel.com wrote:
On Thu, Jun 05, 2014 at 06:25:13PM +0530, Shobhit Kumar wrote:
The DEVICE_TYPE_eDP has been changed to 0x1806 in case of BYT which
can causes wrong detection failures
On 6/6/2014 9:33 AM, Kumar, Shobhit wrote:
On 6/5/2014 9:34 PM, Jesse Barnes wrote:
On Thu, 5 Jun 2014 16:09:29 +0300
Ville Syrjälä ville.syrj...@linux.intel.com wrote:
On Thu, Jun 05, 2014 at 06:25:13PM +0530, Shobhit Kumar wrote:
The DEVICE_TYPE_eDP has been changed to 0x1806 in case of
72 matches
Mail list logo
