Re: [Intel-gfx] [PATCH 11/11] tests/kms_rotation_crc: IGT for 180 degree HW rotation

2014-06-25 Thread Jindal, Sonika
On 6/25/2014 11:27 AM, Chris Wilson wrote: On Wed, Jun 25, 2014 at 11:24:27AM +0530, Jindal, Sonika wrote: On 6/18/2014 5:09 PM, Chris Wilson wrote: On Wed, Jun 18, 2014 at 12:32:00PM +0100, Damien Lespiau wrote: On Wed, Jun 18, 2014 at 02:27:27PM +0530, sonika.jin...@intel.com wrote:

[Intel-gfx] [v2] drm/i915: vlv_prepare_pll is only needed in case of non DSI interfaces

2014-06-25 Thread Shobhit Kumar
For MIPI, DSI PLL is configured separately in vlv_configure_dsi_pll during the DSI enable sequence Causing WARN dump otherwise in dpio_reads v2: Add IS_CHERRYVIEW check as suggested by Ville Signed-off-by: Shobhit Kumar shobhit.ku...@intel.com Reviewed-by: Ville Syrjälä

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Add a delay in Displayport AUX transactions for compliance testing

2014-06-25 Thread Chris Wilson
On Tue, Jun 24, 2014 at 03:12:50PM -0700, Todd Previte wrote: Several compliance tests require that follow-up AUX transactions (after a failure or no response) are not resent sooner than 400us later. Add a 400us delay to the response time of any failed transaction to account for this.

Re: [Intel-gfx] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type

2014-06-25 Thread Paolo Bonzini
Il 22/06/2014 10:25, Chen, Tiejun ha scritto: In qemu-upstream, as you commented we can't create this as a ISA class type explicitly. Note I didn't say that QEMU doesn't like having two ISA bridges. I commented that the firmware will see two ISA bridges and will try to initialize both of

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Implement basic Displayport automated testing function for EDID operations

2014-06-25 Thread Jani Nikula
On Wed, 25 Jun 2014, Todd Previte tprev...@gmail.com wrote: Implements some of the basic EDID tests for Displayport compliance. These tests include reading the EDID, verifying the checksum and writing the test responses back to the sink device. Signed-off-by: Todd Previte

Re: [Intel-gfx] [PATCH] drm/i915: Don't try to look up object for non-existent fb

2014-06-25 Thread Jani Nikula
On Wed, 25 Jun 2014, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, Jun 24, 2014 at 05:05:02PM -0700, Matt Roper wrote: crtc-primary-fb may be NULL upon entry to intel_pipe_set_base() if the primary plane has previously been disabled via the universal plane interface. We need to check

Re: [Intel-gfx] [RFC] drm/i915: Add variable gem object size support to i915

2014-06-25 Thread Damien Lespiau
On Mon, Apr 28, 2014 at 04:01:29PM +0100, arun.siluv...@linux.intel.com wrote: From: Siluvery, Arun arun.siluv...@intel.com This patch adds support to have gem objects of variable size. The size of the gem object obj-size is always constant and this fact is tightly coupled in the driver;

Re: [Intel-gfx] [PATCH] drm/i915/opregion: ignore firmware requests for backlight change

2014-06-25 Thread Jani Nikula
On Tue, 24 Jun 2014, Aaron Lu aaron...@intel.com wrote: Some Thinkpad laptops' firmware will initiate a backlight level change request through operation region on the events of AC plug/unplug, but since we are not using firmware's interface to do the backlight setting on these affected

Re: [Intel-gfx] [RFC] drm/i915: Add variable gem object size support to i915

2014-06-25 Thread Damien Lespiau
On Wed, Jun 25, 2014 at 11:51:33AM +0100, Damien Lespiau wrote: (This is not necessarily things one would need to take into account for this work, just a few thoughts). One thing I'm wondering is how fitting the size parameter really is when talking about inherently 2D buffers. For

Re: [Intel-gfx] [RFC] drm/i915: Add variable gem object size support to i915

2014-06-25 Thread Siluvery, Arun
On 25/06/2014 12:14, Damien Lespiau wrote: On Wed, Jun 25, 2014 at 11:51:33AM +0100, Damien Lespiau wrote: (This is not necessarily things one would need to take into account for this work, just a few thoughts). One thing I'm wondering is how fitting the size parameter really is when talking

Re: [Intel-gfx] [PATCH 2/3] drm/i915: correct BLC vs PWM enable/disable ordering

2014-06-25 Thread Jani Nikula
On Mon, 31 Mar 2014, Jesse Barnes jbar...@virtuousgeek.org wrote: With the new checks in place, we can see we're doing things backwards, so fix them up per the spec. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_dp.c | 13 +++-- 1 file changed,

Re: [Intel-gfx] [RFC] drm/i915: Add variable gem object size support to i915

2014-06-25 Thread Damien Lespiau
On Wed, Jun 25, 2014 at 12:46:57PM +0100, Siluvery, Arun wrote: On 25/06/2014 12:14, Damien Lespiau wrote: On Wed, Jun 25, 2014 at 11:51:33AM +0100, Damien Lespiau wrote: (This is not necessarily things one would need to take into account for this work, just a few thoughts). One thing I'm

Re: [Intel-gfx] drm/i915 KMS regression in Linux 3.16-rc2 (with git bisect result)

2014-06-25 Thread Chris Wilson
On Wed, Jun 25, 2014 at 03:03:44PM +0200, Tom Van Braeckel wrote: Hi, There seems to be a regression in the upcoming Linux 3.16-rc2 release candidate that I bisected down to this first bad commit: [dbb42748ac4929987c1449ecb296b39ef8956b62] drm/i915: Move the C3 LP write bit setup to

Re: [Intel-gfx] [RFC] drm/i915: Add variable gem object size support to i915

2014-06-25 Thread Tvrtko Ursulin
On 06/25/2014 01:57 PM, Damien Lespiau wrote: On Wed, Jun 25, 2014 at 12:46:57PM +0100, Siluvery, Arun wrote: On 25/06/2014 12:14, Damien Lespiau wrote: On Wed, Jun 25, 2014 at 11:51:33AM +0100, Damien Lespiau wrote: (This is not necessarily things one would need to take into account for

Re: [Intel-gfx] [RFC] drm/i915: Add variable gem object size support to i915

2014-06-25 Thread Damien Lespiau
On Wed, Jun 25, 2014 at 02:26:52PM +0100, Tvrtko Ursulin wrote: That's a good question to ask a GL team. In the light of sparse textures I think the region idea would be better. We would need to define what the coordinates mean, for instance: - 2D view of the buffer, and the kernel takes

Re: [Intel-gfx] Regression in i915 driver in 3.16-rc2

2014-06-25 Thread Ville Syrjälä
On Wed, Jun 25, 2014 at 02:06:55PM -0400, Alan Stern wrote: Daniel: I encountered a new problem in the i915 driver the first time I booted a 3.16-rc kernel on this computer. When it switched over to the frame buffer driver, the screen went blank and stayed that way. 3.15 works okay.

Re: [Intel-gfx] [PATCH] drm/i915: only apply crt_present check on VLV

2014-06-25 Thread Ville Syrjälä
On Wed, Jun 25, 2014 at 08:24:29AM -0700, Jesse Barnes wrote: Apparently we can't trust this field on other platforms and need to find some other way. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org Reviewed-by: Ville Syrjälä ville.syrj...@linux.intel.com Since it's a regression it

Re: [Intel-gfx] [PATCH 01/11] drm/i915: Change vlv cdclk to use kHz units

2014-06-25 Thread Jesse Barnes
On Fri, 13 Jun 2014 13:37:47 +0300 ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Use kHz units in vlv cdclk code since that's more customary. Also replace the precomputed 90% values with *9/10 computation for extra clarity. Signed-off-by: Ville

Re: [Intel-gfx] Regression in i915 driver in 3.16-rc2

2014-06-25 Thread Alan Stern
On Wed, 25 Jun 2014, Ville [iso-8859-1] Syrj�l� wrote: On Wed, Jun 25, 2014 at 02:06:55PM -0400, Alan Stern wrote: Daniel: I encountered a new problem in the i915 driver the first time I booted a 3.16-rc kernel on this computer. When it switched over to the frame buffer driver, the

Re: [Intel-gfx] [PATCH 04/11] drm/i915: Handle 320 vs. 333 MHz cdclk on vlv

2014-06-25 Thread Jesse Barnes
On Fri, 13 Jun 2014 13:37:50 +0300 ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Depending on the HPLL frequency one of the supported cdclk frquencies is either 320MHz or 333MHz. Figure out which one it is to accurately pick the minimal required

[Intel-gfx] [PATCH 19/19] drm/i915: ddi: enable runtime pm during dpms

2014-06-25 Thread Imre Deak
From: Daniel Vetter daniel.vet...@ffwll.ch Signed-off-by: Imre Deak imre.d...@intel.com --- drivers/gpu/drm/i915/intel_display.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c

[Intel-gfx] [PATCH 11/19] drm/i915: Precompute static ddi_pll_sel values in encoders

2014-06-25 Thread Imre Deak
From: Daniel Vetter daniel.vet...@ffwll.ch This way only the dynamic WRPLL selection for hdmi ddi mode is done in intel_ddi_pll_select. v2: Don't clobber the precomputed values when selecting clocks fro hdmi encoders. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch ---

[Intel-gfx] [PATCH 06/19] drm/i915: Move the SPLL enabling into hsw_crt_pre_enable

2014-06-25 Thread Imre Deak
From: Daniel Vetter daniel.vet...@ffwll.ch The call to intel_ddi_pll_enable in haswell_crtc_mode_set is the only function that still touches the hardware state from the crtc mode_set callback on hsw. Since the SPLL isn't ever shared we can easily take it out into the hsw crt encoder functions.

[Intel-gfx] [PATCH 08/19] drm/i915: Add a debugfs file for the shared dpll state

2014-06-25 Thread Imre Deak
From: Daniel Vetter daniel.vet...@ffwll.ch Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch Reviewed-by: Damien Lespiau damien.lesp...@intel.com --- drivers/gpu/drm/i915/i915_debugfs.c | 26 ++ 1 file changed, 26 insertions(+) diff --git

[Intel-gfx] [PATCH 16/19] drm/i915: -enable hook for WRPLLs

2014-06-25 Thread Imre Deak
From: Daniel Vetter daniel.vet...@ffwll.ch This time around another cute hack to pre-fill the pll-hw_state with the right values. And also remove a bunch of checks which will be replaced by lots more checks in the common framework. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch Reviewed-by:

[Intel-gfx] [PATCH 05/19] drm/i915: ddi: move pch cleanup before encoder-post_disable

2014-06-25 Thread Imre Deak
This is needed by an upcoming patch that moves the PCH/CRT PLL disabling into the post_disable hook, after which we want to keep the modeset sequence at its current state. At this point this won't have an effect since the PCH/CRT post_disable hook is atm a NOP. Signed-off-by: Imre Deak

[Intel-gfx] [PATCH 09/19] drm/i915: Move ddi_pll_sel into the pipe config

2014-06-25 Thread Imre Deak
From: Daniel Vetter daniel.vet...@ffwll.ch Just boring sed job for preparation. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch Reviewed-by: Damien Lespiau damien.lesp...@intel.com [imre: rebased on patchset version w/o pch/crt/fdi refactoring] Signed-off-by: Imre Deak imre.d...@intel.com

[Intel-gfx] [PATCH 12/19] drm/i915: Basic shared dpll support for WRPLLs

2014-06-25 Thread Imre Deak
From: Daniel Vetter daniel.vet...@ffwll.ch Just filing in names and ids, but not yet officially registering them so that the hw state cross checker doesn't completely freak out about them. Still since we do already read out and cross check config-shared_dpll the basics are now there to flesh out

[Intel-gfx] [PATCH 07/19] drm/i915: Move SPLL disabling into hsw_crt_post_disable

2014-06-25 Thread Imre Deak
From: Daniel Vetter daniel.vet...@ffwll.ch Similar to how the -crtc_mode_set hook should touch the hardware to enable anything the -crtc_off hook should disable anything in the hardware. Otherwise runtime pm for dpms will not work. Currently the only things left int the haswell_crtc_off hook is

[Intel-gfx] [PATCH 02/19] drm/i915: Remove spll_refcount for hsw

2014-06-25 Thread Imre Deak
From: Daniel Vetter daniel.vet...@ffwll.ch SPLL would be a reference clock we could potentially share, especially if we want to use the SSC mode. But currently we don't, so let's rip out this complexity for a simpler conversion to the new display pll framework. Signed-off-by: Daniel Vetter

[Intel-gfx] [PATCH 15/19] drm/i915: -disable hook for WRPLLs

2014-06-25 Thread Imre Deak
From: Daniel Vetter daniel.vet...@ffwll.ch Currently still with a redudant WARN_ON in there, the common shared dpll code will take care of this in the future. Also we need to flip the switch for the transitional hack now to make sure that we disable the right pll. Signed-off-by: Daniel Vetter

[Intel-gfx] [PATCH 10/19] drm/i915: State readout and cross-checking for ddi_pll_sel

2014-06-25 Thread Imre Deak
From: Daniel Vetter daniel.vet...@ffwll.ch To make things a bit more manageable extract a new function for reading out common ddi port state. This means a bit of duplication between encoders and the core since both look at the same registers, but doesn't seem worth to make a fuzz about. We can

[Intel-gfx] [PATCH 18/19] drm/i915: Only touch WRPLL hw state in enable/disable hooks

2014-06-25 Thread Imre Deak
From: Daniel Vetter daniel.vet...@ffwll.ch To be able to do this we need to separately keep track of how many crtcs need a given WRPLL and how many actually actively use it. The common shared dpll framework already has all this, including massive state readout and cross checking. Which allows us

Re: [Intel-gfx] [PATCH 05/11] drm/i915: Use 200MHz cdclk on vlv when all pipes are off

2014-06-25 Thread Ville Syrjälä
On Wed, Jun 25, 2014 at 11:54:06AM -0700, Jesse Barnes wrote: On Fri, 13 Jun 2014 13:37:51 +0300 ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Drop the cdclk frequency to 200MHz on vlv when all pipes are off. In theory we should be able to use

Re: [Intel-gfx] [PATCH 07/11] drm/i915: Warn if there's a cdclk change in progess

2014-06-25 Thread Ville Syrjälä
On Wed, Jun 25, 2014 at 11:55:58AM -0700, Jesse Barnes wrote: On Fri, 13 Jun 2014 13:37:53 +0300 ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com If someone is interested in the current cdclk frquency it should be stable and not in process of

Re: [Intel-gfx] [PATCH 10/11] drm/i915: Move VLV cmnlane workaround to intel_power_domains_init_hw()

2014-06-25 Thread Ville Syrjälä
On Wed, Jun 25, 2014 at 12:03:01PM -0700, Jesse Barnes wrote: On Fri, 13 Jun 2014 13:37:56 +0300 ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Now that the CMNRESET deassert is part of the cmnlane power well, intel_reset_dpio() is called too

Re: [Intel-gfx] mmu_notifier and i915_gem_userptr.c

2014-06-25 Thread Joerg Roedel
On Fri, Jun 20, 2014 at 01:43:50PM +0200, Joerg Roedel wrote: Change_pte is also called when the underlying page of an address changes in the kernel which would matter for DMA. But that can only happen in KSM and uprobes code which is probably not of interest for the i915 driver. The other

Re: [Intel-gfx] 3.15-rc: regression in suspend

2014-06-25 Thread Pavel Machek
On Mon 2014-06-09 13:03:31, Jiri Kosina wrote: On Mon, 9 Jun 2014, Pavel Machek wrote: Strange. It seems 3.15 with the patch reverted only boots in 30% or so cases... And I've seen resume failure, too, so maybe I was just lucky that it worked for a while. git bisect really

[Intel-gfx] [PATCH] drm/i915: fix sanitize_enable_ppgtt for full PPGTT

2014-06-25 Thread Jesse Barnes
Apparently trinary logic is hard. We were falling through all the forced cases and simply enabling aliasing PPGTT or not based on hardware, rather than full PPGTT if available. References: https://bugs.freedesktop.org/show_bug.cgi?id=80083 Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org ---