Re: [Intel-gfx] [PATCH v4 1/4] drm/crtc: Add property for aspect ratio

2014-07-14 Thread Thierry Reding
On Wed, Jun 11, 2014 at 10:46:48AM +0530, Vandana Kannan wrote: Added a property to enable user space to set aspect ratio. This patch contains declaration of the property and code to create the property. v2: Thierry's review comments. - Made aspect ratio enum generic instead of

Re: [Intel-gfx] drm: i915: plane B assertion failure, should be off on pipe B but is still active

2014-07-14 Thread Daniel Vetter
On Sun, Jul 13, 2014 at 10:32:41PM +0200, Paul Bolle wrote: Paul Bolle schreef op wo 02-07-2014 om 10:53 [+0200]: On Tue, 2014-07-01 at 12:17 +0300, Jani Nikula wrote: This does not ring any bells to me (but that doesn't prove anything). A bisect result would be awesome. The bisect

Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

2014-07-14 Thread Daniel Vetter
On Mon, Jul 14, 2014 at 04:22:44AM +, Sun, Daisy wrote: 3) The function will be called when flip happened, this should cover most of the cases. One exception is background media process without any display output, it's relatively rare. Please let me know if you have concern on other

Re: [Intel-gfx] [PATCH] Revert drm/i915: reverse dp link param selection, prefer fast over wide again

2014-07-14 Thread Daniel Vetter
On Mon, Jul 14, 2014 at 11:04:39AM +1000, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com This reverts commit 38aecea0ccbb909d635619cba22f1891e589b434. This breaks Haswell Thinkpad + Lenovo dock in SST mode with a HDMI monitor attached. Before this we can 1920x1200 mode, after

Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

2014-07-14 Thread Daniel Vetter
On Mon, Jul 14, 2014 at 8:59 AM, Daniel Vetter dan...@ffwll.ch wrote: On Mon, Jul 14, 2014 at 04:22:44AM +, Sun, Daisy wrote: 3) The function will be called when flip happened, this should cover most of the cases. One exception is background media process without any display output, it's

Re: [Intel-gfx] drm: i915: plane B assertion failure, should be off on pipe B but is still active

2014-07-14 Thread Paul Bolle
On Mon, 2014-07-14 at 08:56 +0200, Daniel Vetter wrote: Please test the below patch, thanks. -Daniel diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 82e7d57f0a8a..f0be855ddf45 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++

Re: [Intel-gfx] drm: i915: plane B assertion failure, should be off on pipe B but is still active

2014-07-14 Thread Daniel Vetter
On Mon, Jul 14, 2014 at 09:13:40AM +0200, Paul Bolle wrote: On Mon, 2014-07-14 at 08:56 +0200, Daniel Vetter wrote: Please test the below patch, thanks. -Daniel diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 82e7d57f0a8a..f0be855ddf45

Re: [Intel-gfx] [PATCH] drm/i915/chv: Drop WaGsvBringDownFreqInRc6

2014-07-14 Thread Deepak S
On Saturday 28 June 2014 11:26 AM, deepa...@linux.intel.com wrote: From: Deepak S deepa...@linux.intel.com Drop WaGsvBringDownFreq on CHV. When in RC6 requesting the min freq should be fine to bring the voltage down. Signed-off-by: Deepak S deepa...@linux.intel.com ---

Re: [Intel-gfx] [PATCH v4] drm/i915: Force GPU Freq to lowest while suspending.

2014-07-14 Thread Deepak S
On Friday 20 June 2014 08:03 PM, deepa...@linux.intel.com wrote: From: Deepak S deepa...@linux.intel.com We might be leaving the GPU Frequency (and thus vnn) high during the suspend. Force gt to move to lowest freq while suspending. v2: Fixed typo in commit message (Deepak) v3: Force gt to

Re: [Intel-gfx] [patch 48/55] drm: i915: Use nsec based interfaces

2014-07-14 Thread Daniel Vetter
On Fri, Jul 11, 2014 at 3:45 PM, Thomas Gleixner t...@linutronix.de wrote: No point in converting timespecs back and forth. Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Daniel Vetter daniel.vet...@ffwll.ch I guess simplest to merge together with the new ktime_get_raw_ns. Acked-by: me

Re: [Intel-gfx] [PATCH 0/4] Introduce a new create ioctl for user specified

2014-07-14 Thread Gupta, Sourab
On Sun, 2014-07-06 at 18:29 +0530, sourab gupta wrote: On Fri, 2014-06-20 at 10:02 +, Gupta, Sourab wrote: From: Sourab Gupta sourab.gu...@intel.com This patch series introduces a new gem create ioctl for user specified placement. Despite being a unified memory architecture

[Intel-gfx] [PATCH] tests/gem_userptr_blits: Race between object creation and multi-threaded mm ops

2014-07-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin tvrtko.ursu...@intel.com Userptr v23 was not thread safe against memory map operations and object creation from separate threads. MMU notifier callback would get triggered on a partially constructed object causing a NULL pointer dereference. This test excercises that path a

Re: [Intel-gfx] [PATCH 07/10] drm/i915/bdw: collect semaphore error state

2014-07-14 Thread Damien Lespiau
On Mon, Jun 30, 2014 at 09:53:41AM -0700, Rodrigo Vivi wrote: + for_each_ring(useless, dev_priv, i) { + u16 signal_offset = + (GEN8_SIGNAL_OFFSET(ring, i) PAGE_MASK) / 4; + u32 *tmp = error-semaphore_obj-pages[0]; + +

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Provide a config option to select a target platform

2014-07-14 Thread Barbalho, Rafael
-Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Damien Lespiau Sent: Friday, July 11, 2014 6:34 PM To: intel-gfx@lists.freedesktop.org Subject: [Intel-gfx] [PATCH 1/2] drm/i915: Provide a config option to select a target platform

Re: [Intel-gfx] [PATCH] tests/gem_userptr_blits: Race between object creation and multi-threaded mm ops

2014-07-14 Thread Chris Wilson
On Mon, Jul 14, 2014 at 11:03:26AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com Userptr v23 was not thread safe against memory map operations and object creation from separate threads. MMU notifier callback would get triggered on a partially constructed object

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Provide a config option to select a target platform

2014-07-14 Thread Damien Lespiau
On Mon, Jul 14, 2014 at 11:18:30AM +0100, Barbalho, Rafael wrote: -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Damien Lespiau Sent: Friday, July 11, 2014 6:34 PM To: intel-gfx@lists.freedesktop.org Subject: [Intel-gfx]

Re: [Intel-gfx] [PATCH] tests/gem_userptr_blits: Race between object creation and multi-threaded mm ops

2014-07-14 Thread Tvrtko Ursulin
On 07/14/2014 11:34 AM, Chris Wilson wrote: On Mon, Jul 14, 2014 at 11:03:26AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com Userptr v23 was not thread safe against memory map operations and object creation from separate threads. MMU notifier callback would get

[Intel-gfx] [PATCH] lib: Add argc/argv to igt_simple_init

2014-07-14 Thread Daniel Vetter
There's a pile of ideas around to add generally useful options like --debug to all igt tests. Or unify the runtime behaviour between simple and subtest tests a bit more. The first step to get there is to add argc/argv to igt_simple_init so that we can get at the argument list. Cc: Tim Gore

Re: [Intel-gfx] [PATCH] tests/gem_userptr_blits: Race between object creation and multi-threaded mm ops

2014-07-14 Thread Chris Wilson
You don't have any cancellation points in the loop. (mmap may or may not be, it is not required to be.) But rather than use a global, just pass a pointer to a local struct. It doesn't need both a cancellation point and a flag. Should I just add pthread_testcancel in the loop and not have

Re: [Intel-gfx] [PATCH] tests/gem_userptr_blits: Race between object creation and multi-threaded mm ops

2014-07-14 Thread Tvrtko Ursulin
On 07/14/2014 02:07 PM, Chris Wilson wrote: You don't have any cancellation points in the loop. (mmap may or may not be, it is not required to be.) But rather than use a global, just pass a pointer to a local struct. It doesn't need both a cancellation point and a flag. Should I just add

[Intel-gfx] [PATCH] tests/gem_userptr_blits: Race between object creation and multi-threaded mm ops

2014-07-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin tvrtko.ursu...@intel.com Userptr v23 was not thread safe against memory map operations and object creation from separate threads. MMU notifier callback would get triggered on a partially constructed object causing a NULL pointer dereference. This test excercises that path a

Re: [Intel-gfx] [PATCH] tests/gem_userptr_blits: Race between object creation and multi-threaded mm ops

2014-07-14 Thread Chris Wilson
On Mon, Jul 14, 2014 at 02:13:22PM +0100, Tvrtko Ursulin wrote: On 07/14/2014 02:07 PM, Chris Wilson wrote: You don't have any cancellation points in the loop. (mmap may or may not be, it is not required to be.) But rather than use a global, just pass a pointer to a local struct. It

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add get_config implementation for DSI encoder

2014-07-14 Thread Kumar, Shobhit
On 7/12/2014 5:28 PM, Daniel Vetter wrote: On Sat, Jul 12, 2014 at 1:47 PM, Shobhit Kumar shobhit.ku...@intel.com wrote: Call to vlv_crtc_clock_get is not needed for DSI and was causing dpio read WARN dumps as well. Absence of -get_config was casuing othet WARN dumps as well. With this the last

Re: [Intel-gfx] [PATCH 1/4] drm/i915: don't warn if IRQs are disabled when shutting down display IRQs

2014-07-14 Thread Paulo Zanoni
2014-07-07 18:53 GMT-03:00 Jesse Barnes jbar...@virtuousgeek.org: On Mon, 7 Jul 2014 18:48:47 -0300 Paulo Zanoni przan...@gmail.com wrote: (documenting what we discussed on IRC) 2014-06-20 13:29 GMT-03:00 Jesse Barnes jbar...@virtuousgeek.org: This was always the case on our suspend path,

Re: [Intel-gfx] [PATCH 2/4] drm/i915: add helper for checking whether IRQs are enabled

2014-07-14 Thread Paulo Zanoni
2014-06-20 13:29 GMT-03:00 Jesse Barnes jbar...@virtuousgeek.org: Now that we use the runtime IRQ enable/disable functions in our suspend path, we can simply check the pm._irqs_disabled flag everywhere. So rename it to catch the users, and add an inline for it to make the checks clear

Re: [Intel-gfx] [PATCH 3/4] drm/i915: drop runtime PM get/put pair around DP detect

2014-07-14 Thread Paulo Zanoni
2014-06-20 13:29 GMT-03:00 Jesse Barnes jbar...@virtuousgeek.org: We're taking the right power well refs now, so this shouldn't be needed. Reported-by: Imre Deak imre.d...@intel.com Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org I submitted the exact same patch back in April, and got a

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Handle failure to kick out a conflicting fb driver

2014-07-14 Thread Daniel Vetter
On Tue, Dec 17, 2013 at 09:33:27AM +0200, Jani Nikula wrote: On Mon, 16 Dec 2013, Chris Wilson ch...@chris-wilson.co.uk wrote: Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Reviewed-by: Jani Nikula jani.nik...@intel.com Queued for -next, thanks for the patch. -Daniel ---

Re: [Intel-gfx] [PATCH] drm/i915/chv: Drop WaGsvBringDownFreqInRc6

2014-07-14 Thread Jesse Barnes
On Tue, 15 Jul 2014 13:03:55 +0530 Deepak S deepa...@linux.intel.com wrote: On Saturday 28 June 2014 11:26 AM, deepa...@linux.intel.com wrote: From: Deepak S deepa...@linux.intel.com Drop WaGsvBringDownFreq on CHV. When in RC6 requesting the min freq should be fine to bring the

Re: [Intel-gfx] [PATCH v4] drm/i915: Force GPU Freq to lowest while suspending.

2014-07-14 Thread Jesse Barnes
On Tue, 15 Jul 2014 13:05:48 +0530 Deepak S deepa...@linux.intel.com wrote: On Friday 20 June 2014 08:03 PM, deepa...@linux.intel.com wrote: From: Deepak S deepa...@linux.intel.com We might be leaving the GPU Frequency (and thus vnn) high during the suspend. Force gt to move to

Re: [Intel-gfx] [PATCH 2/4] drm/i915: add helper for checking whether IRQs are enabled

2014-07-14 Thread Paulo Zanoni
2014-07-14 12:06 GMT-03:00 Paulo Zanoni przan...@gmail.com: 2014-06-20 13:29 GMT-03:00 Jesse Barnes jbar...@virtuousgeek.org: Now that we use the runtime IRQ enable/disable functions in our suspend path, we can simply check the pm._irqs_disabled flag everywhere. So rename it to catch the

Re: [Intel-gfx] [PATCH 4/4] drm/i915: set pm._irqs_disabled at IRQ init time

2014-07-14 Thread Paulo Zanoni
2014-06-20 13:29 GMT-03:00 Jesse Barnes jbar...@virtuousgeek.org: Before we've installed the handler, we can set this and avoid confusing init code that then thinks IRQs are enabled and spews complaints everywhere. But then at some point the DRM layer will call our IRQ init callbacks, which

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add get_config implementation for DSI encoder

2014-07-14 Thread Daniel Vetter
On Mon, Jul 14, 2014 at 4:36 PM, Kumar, Shobhit shobhit.ku...@intel.com wrote: /* XXX: read flags, set to adjusted_mode */ + pipe_config-quirks = 1; Nack. First you need to use one of the symbolic quirk definitions (there's a bunch of them). Second this needs a comment why

Re: [Intel-gfx] [PATCH 2/4] drm/i915: add helper for checking whether IRQs are enabled

2014-07-14 Thread Jesse Barnes
On Mon, 14 Jul 2014 12:19:54 -0300 Paulo Zanoni przan...@gmail.com wrote: 2014-07-14 12:06 GMT-03:00 Paulo Zanoni przan...@gmail.com: 2014-06-20 13:29 GMT-03:00 Jesse Barnes jbar...@virtuousgeek.org: Now that we use the runtime IRQ enable/disable functions in our suspend path, we can

Re: [Intel-gfx] [PATCH 4/4] drm/i915: remove useless runtime PM get calls

2014-07-14 Thread Daniel Vetter
On Thu, Apr 24, 2014 at 05:05:21PM +0300, Ville Syrjälä wrote: On Thu, Apr 24, 2014 at 10:50:56AM -0300, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com We already call intel_dp_power_get, which will get a power domain, and ^^ Commit

Re: [Intel-gfx] drm: i915: plane B assertion failure, should be off on pipe B but is still active

2014-07-14 Thread Paul Bolle
Daniel Vetter schreef op ma 14-07-2014 om 09:18 [+0200]: On Mon, Jul 14, 2014 at 09:13:40AM +0200, Paul Bolle wrote: On Mon, 2014-07-14 at 08:56 +0200, Daniel Vetter wrote: diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index

[Intel-gfx] [PATCH] tests: Move gem_render_copy_redux to the list of multi-subtests tests

2014-07-14 Thread Damien Lespiau
Can we find a way to fix those for good? My preference goes to not having that single/multi split but always have a test being a list of one or more subtests. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- tests/Makefile.sources | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Intel-gfx] [PATCH] drm,drm/i915: Export cmdline mode parsing

2014-07-14 Thread Rodrigo Vivi
This patch got a conflict on latest -collector. Is it still needed? If yes, could you please rebase? I was also going to tell about the Make the pysical object coherent... but I noticed you already rebased. Thanks, Rodrigo. On Wed, May 14, 2014 at 1:46 AM, Chris Wilson

Re: [Intel-gfx] [PATCH 4/4] drm/i915: set pm._irqs_disabled at IRQ init time

2014-07-14 Thread Daniel Vetter
On Mon, Jul 14, 2014 at 12:23:11PM -0300, Paulo Zanoni wrote: 2014-06-20 13:29 GMT-03:00 Jesse Barnes jbar...@virtuousgeek.org: Before we've installed the handler, we can set this and avoid confusing init code that then thinks IRQs are enabled and spews complaints everywhere. But then at

Re: [Intel-gfx] [PATCH] drm/i915/chv: Drop WaGsvBringDownFreqInRc6

2014-07-14 Thread Daniel Vetter
On Mon, Jul 14, 2014 at 08:17:15AM -0700, Jesse Barnes wrote: On Tue, 15 Jul 2014 13:03:55 +0530 Deepak S deepa...@linux.intel.com wrote: On Saturday 28 June 2014 11:26 AM, deepa...@linux.intel.com wrote: From: Deepak S deepa...@linux.intel.com Drop WaGsvBringDownFreq on CHV.

Re: [Intel-gfx] [PATCH 1/4] drm/i915: don't warn if IRQs are disabled when shutting down display IRQs

2014-07-14 Thread Daniel Vetter
On Mon, Jul 14, 2014 at 11:56:57AM -0300, Paulo Zanoni wrote: 2014-07-07 18:53 GMT-03:00 Jesse Barnes jbar...@virtuousgeek.org: On Mon, 7 Jul 2014 18:48:47 -0300 Paulo Zanoni przan...@gmail.com wrote: (documenting what we discussed on IRC) 2014-06-20 13:29 GMT-03:00 Jesse Barnes

[Intel-gfx] [PATCH] drm/i915: Track the primary plane correctly when reassigning planes

2014-07-14 Thread Daniel Vetter
commit 98ec77397a5c68ce753dc283aaa6f4742328bcdd Author: Ville Syrjälä ville.syrj...@linux.intel.com Date: Wed Apr 30 17:43:01 2014 +0300 drm/i915: Make primary_enabled match the actual hardware state introduced more accurate tracking of the primary plane and some checks. It missed the

Re: [Intel-gfx] [PATCH] tests: Move gem_render_copy_redux to the list of multi-subtests tests

2014-07-14 Thread Daniel Vetter
On Mon, Jul 14, 2014 at 06:10:29PM +0100, Damien Lespiau wrote: Can we find a way to fix those for good? My preference goes to not having that single/multi split but always have a test being a list of one or more subtests. We're working on this ... We = Thomasme and Tim Gore a bit. -Daniel

Re: [Intel-gfx] [PATCH 4/4] drm/i915: set pm._irqs_disabled at IRQ init time

2014-07-14 Thread Paulo Zanoni
2014-07-14 14:26 GMT-03:00 Daniel Vetter dan...@ffwll.ch: On Mon, Jul 14, 2014 at 12:23:11PM -0300, Paulo Zanoni wrote: 2014-06-20 13:29 GMT-03:00 Jesse Barnes jbar...@virtuousgeek.org: Before we've installed the handler, we can set this and avoid confusing init code that then thinks IRQs

Re: [Intel-gfx] [PATCH] drm/i915: Track the primary plane correctly when reassigning planes

2014-07-14 Thread Paul Bolle
On Mon, 2014-07-14 at 19:39 +0200, Daniel Vetter wrote: commit 98ec77397a5c68ce753dc283aaa6f4742328bcdd Author: Ville Syrjälä ville.syrj...@linux.intel.com Date: Wed Apr 30 17:43:01 2014 +0300 drm/i915: Make primary_enabled match the actual hardware state introduced more accurate

Re: [Intel-gfx] [PATCH 07/10] drm/i915/bdw: collect semaphore error state

2014-07-14 Thread Ben Widawsky
On Mon, Jul 14, 2014 at 11:04:22AM +0100, Damien Lespiau wrote: On Mon, Jun 30, 2014 at 09:53:41AM -0700, Rodrigo Vivi wrote: + for_each_ring(useless, dev_priv, i) { + u16 signal_offset = + (GEN8_SIGNAL_OFFSET(ring, i) PAGE_MASK) / 4; + u32 *tmp =

Re: [Intel-gfx] [PATCH] drm: Perform cmdline mode parsing during connector initialisation

2014-07-14 Thread Rodrigo Vivi
When getting this patch for -collector I noticed it conflicts with mgag200 and break its compilation. On Wed, Jun 11, 2014 at 3:55 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: i915.ko has a custom fbdev initialisation routine that aims to preserve the current mode set by the BIOS, unless

[Intel-gfx] [PATCH v2] Displayport compliance testing

2014-07-14 Thread Todd Previte
This patch set adds the foundational support for Displayport compliance testing in the i915 driver. It implements the framework for automated test support that preclude the need (most) for operator input during testing. Tests for AUX transactions, EDID reads and basic link training have also

[Intel-gfx] [PATCH 01/12] drm/i915: Add automated testing support for Displayport compliance testing

2014-07-14 Thread Todd Previte
Add the skeleton framework for supporting automation for Displayport compliance testing. This patch adds the necessary framework for the source device to appropriately responded to test automation requests from a sink device. Signed-off-by: Todd Previte tprev...@gmail.com ---

[Intel-gfx] [PATCH 05/12] drm/i915: Add a function to get the EDID preferred mode for Displayport compliance testing

2014-07-14 Thread Todd Previte
Add a simple function to pull the preferred mode out of an EDID block. This function is designed for use during Displayport compliance testing. Signed-off-by: Todd Previte tprev...@gmail.com --- drivers/gpu/drm/i915/intel_dp.c | 25 + 1 file changed, 25 insertions(+)

[Intel-gfx] [PATCH 06/12] drm/i915: Add a constant and function for getting the Displayport compliance failsafe video mode

2014-07-14 Thread Todd Previte
Adds the failsafe mode (640x480@60hz) as a constant and a function that retrieves it. These are designed for use in Displayport compliance testing only and should not be used outside that context. Signed-off-by: Todd Previte tprev...@gmail.com --- drivers/gpu/drm/i915/intel_dp.c | 12

[Intel-gfx] [PATCH 02/12] drm/i915: Add a function to compute the EDID checksum for Displayport compliance

2014-07-14 Thread Todd Previte
This function computes the EDID checksum for a block of EDID data. This function is necessary for Displayport compliance testing as it does not not require the complete EDID checking functionality provided by the DRM layer functions. Signed-off-by: Todd Previte tprev...@gmail.com ---

[Intel-gfx] [PATCH 04/12] drm/i915: Add wrapper function for intel_crtc_set_config()

2014-07-14 Thread Todd Previte
Add a wrapper around intel_crtc_set_config() to allow it to be called from the DP compliance test functions. This is necessary to perform the internal mode set operations required for compliance testing. Signed-off-by: Todd Previte tprev...@gmail.com --- drivers/gpu/drm/i915/intel_display.c | 6

[Intel-gfx] [PATCH 03/12] drm/i915: Add counters in the drm_dp_aux struct for I2C NACKs and DEFERs

2014-07-14 Thread Todd Previte
These counters are used for Displayort complinace testing to detect error conditions when executing certain compliance tests. Currently these are used in the EDID tests to determine if the video mode needs to be set to the preferred mode or the failsafe mode. Signed-off-by: Todd Previte

[Intel-gfx] [PATCH 08/12] drm/i915: Improve reliability for Displayport link training

2014-07-14 Thread Todd Previte
Link training for Displayport can fail in many ways and at multiple different points during the training process. Previously, errors were logged but no additional action was taken based on them. Consequently, training attempts could continue even after errors have occured that would prevent

[Intel-gfx] [PATCH 12/12] drm/i915: Add a delay in Displayport AUX transactions for compliance testing

2014-07-14 Thread Todd Previte
The Displayport Link Layer Compliance Testing Specification 1.2 rev 1.1 specifies that repeated AUX transactions after a failure (NACK, DEFER or no response) must have a minimum delay of 400us before the resend can occur. Tests 4.2.1.1 and 4.2.1.2 are two tests that require this specifically.

[Intel-gfx] [PATCH 07/12] drm/i915: Update EDID automated test function for Displayport compliance

2014-07-14 Thread Todd Previte
Implements an updated version of the automated testing function that handles Displayport compliance for EDID operations. Signed-off-by: Todd Previte tprev...@gmail.com --- drivers/gpu/drm/i915/intel_dp.c | 77 - 1 file changed, 76 insertions(+), 1

[Intel-gfx] [PATCH 11/12] drm/i915: Minor code clean up in intel_dp.c

2014-07-14 Thread Todd Previte
Cleans up a couple of unused variables and an extraneous debug log message that was unintentionally left behind. Signed-off-by: Todd Previte tprev...@gmail.com --- drivers/gpu/drm/i915/intel_dp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[Intel-gfx] [PATCH 09/12] drm/i915: Update intel_dp_check_link_status() for Displayport compliance testing

2014-07-14 Thread Todd Previte
Move the DPCD read to the top and check for an interrupt from the sink to catch Displayport automated testing requests necessary to support Displayport compliance testing. The checks for active connectors and link status are moved below the check for the interrupt. Adds a check at the top to

[Intel-gfx] [PATCH 10/12] drm/i915: Update link training automated test function for Displayport compliance

2014-07-14 Thread Todd Previte
Implements basic link training functionality for Displayport automated compliance testing. Signed-off-by: Todd Previte tprev...@gmail.com --- drivers/gpu/drm/i915/intel_dp.c | 47 + 1 file changed, 47 insertions(+) diff --git

[Intel-gfx] [PATCH 01/11] drm/i915: Bring UP Power Wells before disabling RC6.

2014-07-14 Thread Rodrigo Vivi
From: Deepak S deepa...@intel.com We need do forcewake before Disabling RC6, This is what the BIOS expects while going into suspend. v2: updated commit message. (Daniel) Reviewer: Paulo Zanoni paulo.r.zan...@intel.com Cc: Paulo Zanoni paulo.r.zan...@intel.com Signed-off-by: Deepak S

[Intel-gfx] [PATCH 00/11] drm-intel-collector - update

2014-07-14 Thread Rodrigo Vivi
This is another drm-intel-collector updated notice: http://cgit.freedesktop.org/~vivijim/drm-intel/log/?h=drm-intel-collector Here goes the update list in order for better reviewers assignment: Patch drm/i915: Bring UP Power Wells before disabling RC6. - Reviewer: Paulo Zanoni

[Intel-gfx] [PATCH 10/11] drm/i915: Bring GPU Freq to min while suspending.

2014-07-14 Thread Rodrigo Vivi
From: Deepak S deepa...@linux.intel.com We might be leaving the PGU Frequency (and thus vnn) high during the suspend. Flusing the delayed work queue should take care of this. Signed-off-by: Deepak S deepa...@linux.intel.com Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com ---

[Intel-gfx] [PATCH 04/11] drm/i915: Add property to set HDMI aspect ratio

2014-07-14 Thread Rodrigo Vivi
From: Vandana Kannan vandana.kan...@intel.com Added a property to enable user space to set aspect ratio for HDMI displays. If there is no user specified value, then PAR_NONE/Automatic option is set by default. User can select aspect ratio 4:3 or 16:9. The aspect ratio selected by user would come

[Intel-gfx] [PATCH 06/11] drm/i915: Don't promote UC to WT automagically

2014-07-14 Thread Rodrigo Vivi
From: Ville Syrjälä ville.syrj...@linux.intel.com If the object is already UC leave it as UC instead of automagically promoting it to WT in i915_gem_object_pin_to_display_plane() when the hardware is WT capable. Supposedly the user wanted UC for a reason, so let's respect that. Signed-off-by:

[Intel-gfx] [PATCH 02/11] drm/i915: Don't save/restore RS when not used

2014-07-14 Thread Rodrigo Vivi
From: Ben Widawsky benjamin.widaw...@intel.com v2: fix conflict on rebase. Cc: Kenneth Graunke kenn...@whitecape.org Signed-off-by: Ben Widawsky b...@bwidawsk.net Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com --- drivers/gpu/drm/i915/i915_gem_context.c | 10 ++ 1 file changed, 6

[Intel-gfx] [PATCH 03/11] drm/i915: Upgrade execbuffer fail after resume failure to EIO

2014-07-14 Thread Rodrigo Vivi
From: Chris Wilson ch...@chris-wilson.co.uk If we try to execute on a known ring, but it has failed to be initialised correctly, report that the GPU is hung rather than the command invalid. This leaves us reporting EINVAL only if the user requests execution on a ring that is not supported by the

[Intel-gfx] [PATCH 05/11] drm/i915: honour forced connector modes

2014-07-14 Thread Rodrigo Vivi
From: Chris Wilson ch...@chris-wilson.co.uk In the move over to use BIOS connector configs, we lost the ability to force a specific set of connectors on or off. Try to remedy that by dropping back to the old behavior if we detect a hard coded connector config that tries to enable a connector

[Intel-gfx] [PATCH 07/11] drm/i915: Refactor the physical and virtual page hws setup

2014-07-14 Thread Rodrigo Vivi
From: Chris Wilson ch...@chris-wilson.co.uk We duplicated the legacy physical HWS setup routine for no good reason. Combine it with the more recent virtual HWS setup for simplicity. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com ---

[Intel-gfx] [PATCH 08/11] drm/i915: clean up PPGTT checking logic

2014-07-14 Thread Rodrigo Vivi
From: Jesse Barnes jbar...@virtuousgeek.org sanitize_enable_ppgtt is the function that checks all the conditions, honoring a forced ppgtt status or doing auto-detect as necessary. Just make sure it returns the right value in all cases and use that in the macros instead of the confusing

[Intel-gfx] [PATCH 09/11] drm/i915: re-order ppgtt sanitize logic v2

2014-07-14 Thread Rodrigo Vivi
From: Jesse Barnes jbar...@virtuousgeek.org Put hw limitations first, disabling ppgtt if necessary right away. After that, check user passed args or auto-detect and do the right thing, falling back to aliasing PPGTT if the user tries to enable full PPGTT but it isn't available. v2: simplify

Re: [Intel-gfx] [PATCH 4/4] drm/i915: set pm._irqs_disabled at IRQ init time

2014-07-14 Thread Jesse Barnes
On Mon, 14 Jul 2014 14:47:07 -0300 Paulo Zanoni przan...@gmail.com wrote: 2014-07-14 14:26 GMT-03:00 Daniel Vetter dan...@ffwll.ch: On Mon, Jul 14, 2014 at 12:23:11PM -0300, Paulo Zanoni wrote: 2014-06-20 13:29 GMT-03:00 Jesse Barnes jbar...@virtuousgeek.org: Before we've installed the

[Intel-gfx] [PATCH] lib/igt_core: Fixup gtkdoc for logging functions

2014-07-14 Thread Daniel Vetter
Without the () gtkdoc won't recognize them as function references. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- lib/igt_core.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/igt_core.h b/lib/igt_core.h index 8438d0063d81..a30d0d141acf 100644 ---

Re: [Intel-gfx] [PATCH] Revert drm/i915: reverse dp link param selection, prefer fast over wide again

2014-07-14 Thread Daniel Vetter
On Mon, Jul 14, 2014 at 11:04:39AM +1000, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com This reverts commit 38aecea0ccbb909d635619cba22f1891e589b434. This breaks Haswell Thinkpad + Lenovo dock in SST mode with a HDMI monitor attached. Before this we can 1920x1200 mode, after

Re: [Intel-gfx] [PATCH] drm/i915/chv: Drop WaGsvBringDownFreqInRc6

2014-07-14 Thread Deepak S
On Monday 14 July 2014 08:47 PM, Jesse Barnes wrote: On Tue, 15 Jul 2014 13:03:55 +0530 Deepak S deepa...@linux.intel.com wrote: On Saturday 28 June 2014 11:26 AM, deepa...@linux.intel.com wrote: From: Deepak S deepa...@linux.intel.com Drop WaGsvBringDownFreq on CHV. When in RC6 requesting

Re: [Intel-gfx] [PATCH v4] drm/i915: Force GPU Freq to lowest while suspending.

2014-07-14 Thread Deepak S
On Monday 14 July 2014 08:47 PM, Jesse Barnes wrote: On Tue, 15 Jul 2014 13:05:48 +0530 Deepak S deepa...@linux.intel.com wrote: On Friday 20 June 2014 08:03 PM, deepa...@linux.intel.com wrote: From: Deepak S deepa...@linux.intel.com We might be leaving the GPU Frequency (and thus vnn) high