Re: [Intel-gfx] [PATCH] drm/i915: remove bogus intel_increase_pllclock

2014-10-09 Thread Daniel Vetter
On Tue, Oct 07, 2014 at 04:18:38PM -0300, Paulo Zanoni wrote: 2014-10-07 12:15 GMT-03:00 Mika Kuoppala mika.kuopp...@linux.intel.com: commit b680c37a4d145cf4d8f2b24e46b1163e5ceb1d35 Author: Daniel Vetter daniel.vet...@ffwll.ch Date: Fri Sep 19 18:27:27 2014 +0200 drm/i915: DocBook

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Make *_crtc_mode_set work on new_config

2014-10-09 Thread Daniel Vetter
On Wed, Oct 08, 2014 at 06:32:21PM +0300, Ander Conselvan de Oliveira wrote: From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com This shouldn't change the behavior of those functions, since they are called after the new_config is made effective and that points to the

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Compute clocks and choose DPLLs before disabling crtcs

2014-10-09 Thread Daniel Vetter
On Wed, Oct 08, 2014 at 06:32:23PM +0300, Ander Conselvan de Oliveira wrote: From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com It is possible for a mode set to fail if there aren't shared DPLLS that match the new configuration requirement or other errors in clock

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Compute clocks and choose DPLLs before disabling crtcs

2014-10-09 Thread Jani Nikula
On Thu, 09 Oct 2014, Daniel Vetter dan...@ffwll.ch wrote: On Wed, Oct 08, 2014 at 06:32:23PM +0300, Ander Conselvan de Oliveira wrote: From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com It is possible for a mode set to fail if there aren't shared DPLLS that match the new

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Make *_crtc_mode_set work on new_config

2014-10-09 Thread Daniel Vetter
On Wed, Oct 08, 2014 at 06:32:21PM +0300, Ander Conselvan de Oliveira wrote: From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com This shouldn't change the behavior of those functions, since they are called after the new_config is made effective and that points to the

Re: [Intel-gfx] [PATCH] drm/i915: use delayed work for resume hotplug v2

2014-10-09 Thread Chris Wilson
On Wed, Oct 08, 2014 at 07:32:12AM -0700, Jesse Barnes wrote: On Wed, 8 Oct 2014 07:43:34 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, Oct 07, 2014 at 01:25:23PM -0700, Jesse Barnes wrote: Gets the detect code (which may take awhile) out of the resume path, speeding

Re: [Intel-gfx] [PATCH 2/2] Don't use += to append to a shell variable.

2014-10-09 Thread Thomas Wood
On 7 October 2014 17:41, Adam Sampson a...@offog.org wrote: POSIX only requires = to be supported; += works in bash but not in dash. Signed-off-by: Adam Sampson a...@offog.org Both patches merged, thanks. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Intel-gfx] Fast User Switching does not seem to work

2014-10-09 Thread constantine
Thank you for the reply! Does your Arch use systemd? Is your *buntu not using systemd? Yes to both. I am aware of the on-demand feature and did what you proposed (had already done the same for half of the terminals). After testing I noticed something more specific. Suppose the following

Re: [Intel-gfx] [PATCH] drm/i915: use delayed work for resume hotplug v2

2014-10-09 Thread Jesse Barnes
On Thu, 9 Oct 2014 11:11:32 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: On Wed, Oct 08, 2014 at 07:32:12AM -0700, Jesse Barnes wrote: On Wed, 8 Oct 2014 07:43:34 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, Oct 07, 2014 at 01:25:23PM -0700, Jesse Barnes wrote:

Re: [Intel-gfx] Fast User Switching does not seem to work

2014-10-09 Thread Felix Miata
constantine composed on 2014-10-09 13:35 (UTC): Does your Arch use systemd? Is your *buntu not using systemd? Yes to both. I am aware of the on-demand feature and did what you proposed (had already done the same for half of the terminals). After testing I noticed something more specific.

[Intel-gfx] [PATCH] drm/i915: use delayed work for resume hotplug v4

2014-10-09 Thread Jesse Barnes
Gets the detect code (which may take awhile) out of the resume path, speeding things up a bit. v2: use a delayed work queue instead (Daniel) v3: cancel delayed work at unload and suspend time (Jesse) v4: make delayed work comment less scary (Chris) Signed-off-by: Jesse Barnes

[Intel-gfx] [PATCH 02/10] drm/i915: Add counters in the drm_dp_aux struct for I2C NACKs and DEFERs

2014-10-09 Thread Todd Previte
These counters are used for Displayort complinace testing to detect error conditions when executing certain compliance tests. Currently these are used in the EDID tests to determine if the video mode needs to be set to the preferred mode or the failsafe mode. Cc:

[Intel-gfx] [PATCH 05/10] drm/i915: Add debugfs interface for Displayport debug and compliance testing

2014-10-09 Thread Todd Previte
Adds an interface that allows for Displayport configuration information to be accessed through debugfs. The information paramters provided here are as follows: Link rate Lane count Bits per pixel Voltage swing level Preemphasis level Display mode These parameters are intended

[Intel-gfx] [PATCH 03/10] drm/i915: Update intel_dp_check_link_status() for Displayport compliance testing

2014-10-09 Thread Todd Previte
Move the DPCD read to the top and check for an interrupt from the sink to catch Displayport automated testing requests necessary to support Displayport compliance testing. The checks for active connectors and link status are moved below the check for the interrupt. Adds a check at the top to

[Intel-gfx] [intel-gfx] Displayport compliance testing

2014-10-09 Thread Todd Previte
The kernel side is responsible for the acknowledgement of the test requests and setup of the required parameters. It also handles the necessary AUX transactions for reading the EDID and DPCD as well as writing response codes or checksums as necessary. Performing these operations in userspace

[Intel-gfx] [PATCH 06/10] drm/i915: Add debugfs interface and support functions to notify userspace apps for Displayport compliance testing

2014-10-09 Thread Todd Previte
Adds the capability for the driver to signal a userspace application for Displayport compliance testing. The userspace app must write its PID to the appropriate debugfs file, at which time the kernel will read and store that PID internally. PIDs are specified on a per-connector basis.

[Intel-gfx] [PATCH 01/10] drm/i915: Add automated testing support for Displayport compliance testing

2014-10-09 Thread Todd Previte
Add the skeleton framework for supporting automation for Displayport compliance testing. This patch adds the necessary framework for the source device to appropriately respond to test automation requests from a sink device. Signed-off-by: Todd Previte tprev...@gmail.com ---

[Intel-gfx] [PATCH 09/10] drm/i915: Update intel_dp_compute_config() to respond to Displayport compliance test requests appropriately

2014-10-09 Thread Todd Previte
Adds provisions in intel_dp_compute_config() to accommodate compliance testing. Mostly this invovles circumventing the automatic link configuration paramters and allowing the compliance code to set those parameters as required by the tests. Signed-off-by: Todd Previte tprev...@gmail.com ---

[Intel-gfx] [PATCH 10/10] drm/i915: Fix intel_dp_hot_plug()

2014-10-09 Thread Todd Previte
The hot plug function for DP appears to have been broken somewhere along the way. Without this function being operational, hot plug events are not correctly received for compliance testing. This patch implements the necessary functionality to resolve that issue. Signed-off-by: Todd Previte

[Intel-gfx] [PATCH 07/10] drm/i915: Add structures for Displayport compliance testing parameters

2014-10-09 Thread Todd Previte
Adds a struct to hold link configuration parameters and several other variables for use during Displayport compliance testing. Adding these items here allows for efficient handling of compliance test data and configuration parameters where necessary in the driver. Also updates the debugfs

Re: [Intel-gfx] [RFC 0/6] Rearranging PPS related code

2014-10-09 Thread Daniel Vetter
On Tue, Oct 07, 2014 at 08:39:38PM +0530, Vandana Kannan wrote: Since panel power sequencing is a feature common to all internal displays, moving relevant code to intel_panel.c. This patch series contains changes to setup PPS data and program register values as required. The implementation

Re: [Intel-gfx] [PATCH 10/10] drm/i915: Fix intel_dp_hot_plug()

2014-10-09 Thread Chris Wilson
On Thu, Oct 09, 2014 at 08:38:10AM -0700, Todd Previte wrote: The hot plug function for DP appears to have been broken somewhere along the way. Without this function being operational, hot plug events are not correctly received for compliance testing. This patch implements the necessary

[Intel-gfx] [PATCH i-g-t 1/2] tests/kms_force_connector: ensure igt_exit is called at exit

2014-10-09 Thread Thomas Wood
Since commit 5782eca (lib/igt_core.c: disable lowmemorykiller during tests), igt_exit needs to be called before the test exits. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=84771 Cc: Tim Gore tim.g...@intel.com Signed-off-by: Thomas Wood thomas.w...@intel.com ---

[Intel-gfx] [PATCH i-g-t 2/2] tests/kms_force_connect: skip if a VGA connector is not available

2014-10-09 Thread Thomas Wood
Signed-off-by: Thomas Wood thomas.w...@intel.com --- tests/kms_force_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_force_connector.c b/tests/kms_force_connector.c index 96881c7..361bf84 100644 --- a/tests/kms_force_connector.c +++

Re: [Intel-gfx] [PATCH i-g-t 2/2] tests/kms_force_connect: skip if a VGA connector is not available

2014-10-09 Thread Chris Wilson
On Thu, Oct 09, 2014 at 04:50:53PM +0100, Thomas Wood wrote: Signed-off-by: Thomas Wood thomas.w...@intel.com --- tests/kms_force_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_force_connector.c b/tests/kms_force_connector.c index 96881c7..361bf84

Re: [Intel-gfx] [PATCH i-g-t 1/2] tests/kms_force_connector: ensure igt_exit is called at exit

2014-10-09 Thread Gore, Tim
-Original Message- From: Thomas Wood [mailto:thomas.w...@intel.com] Sent: Thursday, October 09, 2014 4:51 PM To: intel-gfx@lists.freedesktop.org Cc: Gore, Tim Subject: [PATCH i-g-t 1/2] tests/kms_force_connector: ensure igt_exit is called at exit Since commit 5782eca

Re: [Intel-gfx] [PATCH i-g-t 1/2] tests/kms_force_connector: ensure igt_exit is called at exit

2014-10-09 Thread Thomas Wood
On 9 October 2014 17:00, Gore, Tim tim.g...@intel.com wrote: -Original Message- From: Thomas Wood [mailto:thomas.w...@intel.com] Sent: Thursday, October 09, 2014 4:51 PM To: intel-gfx@lists.freedesktop.org Cc: Gore, Tim Subject: [PATCH i-g-t 1/2] tests/kms_force_connector: ensure

[Intel-gfx] [PATCH] drm/i915: Change order of operations for VLV/CHV to not train DP link before PHYs are ready

2014-10-09 Thread Todd Previte
Reorder the function calls in chv/vlv_pre_enable_dp() such that link training is not initiated before the PHYs come up out of reset. Also check the status of vlv_wait_port_ready() and only attempt to train if the PHYs are actually running. The specification lists the wait for the PHYs as one of

[Intel-gfx] [PATCH] drm/i915: Don't trust the DP_DETECT bit for eDP ports on CHV

2014-10-09 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com On CHV the display DDC pins may be muxed to an alternate function if there's no need for DDC on a specific port, which is the case for eDP ports since there's no way to plug in a DP++ HDMI dongle. This causes problems when trying to determine if

[Intel-gfx] [PATCH] drm/i915: Improve reliability for Displayport link training

2014-10-09 Thread Todd Previte
Link training for Displayport can fail in many ways and at multiple different points during the training process. Previously, errors were logged but no additional action was taken based on them. Consequently, training attempts could continue even after errors have occured that would prevent

[Intel-gfx] [PATCH 5/6] tools/null_state_gen: Add Gen8 golden state

2014-10-09 Thread Mika Kuoppala
Previously we didn't have a clear understanding what is necessary for a pipeline state to be properly initialized. So we had to improvise and use a stripped out render copy. Now we have a more clear understanding so switch out render copy based frankenstate to state we can call golden state. v2:

[Intel-gfx] [PATCH 1/6] tools/null_state_gen: Add copyrights

2014-10-09 Thread Mika Kuoppala
to files where they were missing. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- tools/null_state_gen/intel_null_state_gen.c | 27 +++ tools/null_state_gen/intel_renderstate_gen6.c | 26 ++ tools/null_state_gen/intel_renderstate_gen7.c

[Intel-gfx] [PATCH 6/6] tools/null_state_gen: Add GEN9 golden context batch buffer creation

2014-10-09 Thread Mika Kuoppala
From: Armin Reese armin.c.re...@intel.com Modifications to 'null_state_gen' so it can generate GEN9 golden context batch buffer source for SKL. v2: - rebased on top of gen8 changes (Mika) - fixed state base address command size (Mika) - base address size macro as pages (Mika) v3: -

[Intel-gfx] [PATCH 2/6] tools/null_state_gen: Add more debug output

2014-10-09 Thread Mika Kuoppala
Be more verbose about the state size we generate. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- tools/null_state_gen/intel_null_state_gen.c | 36 ++--- 1 file changed, 28 insertions(+), 8 deletions(-) diff --git a/tools/null_state_gen/intel_null_state_gen.c

[Intel-gfx] [PATCH 4/6] tools/null_state_gen: Add macro to emit commands with null state

2014-10-09 Thread Mika Kuoppala
In null/golden context there are multiple state commands where the actual state is always zero. For more compact batch representation add a macro which just emits command and the rest of the state as zero. v2: - Be more verbose about length bias (Bradley Volkin) - strip out unrelated

[Intel-gfx] [PATCH 3/6] tools/null_state_gen: Limit the total state len to 4096 bytes

2014-10-09 Thread Mika Kuoppala
Currently our kernel side buffer object is only one page. Limit the amount of dwords to 1024 to enforce this. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- tools/null_state_gen/intel_batchbuffer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH] drm/i915: run intel_uncore_early_sanitize earlier on resume

2014-10-09 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com As far as I understand, intel_uncore_early_sanitize() was supposed to be ran before any register access, but currently intel_resume_prepare() is ran earlier, and it does register access. I don't think it should be safe to be calling I915_{READ,WRITE}

[Intel-gfx] [PATCH 2/4] drm/i915: preserve swizzle settings if necessary v4

2014-10-09 Thread Jesse Barnes
Some machines (like MBAs) might use a tiled framebuffer but not enable display swizzling at boot time. We want to preserve that configuration if possible to prevent a boot time mode set. On IVB+ it shouldn't affect performance anyway since the memory controller does internal swizzling anyway.

[Intel-gfx] [PATCH 3/4] drm: add drm_mode_same_size function

2014-10-09 Thread Jesse Barnes
From: Kristian Høgsberg hoegsb...@gmail.com Like mode_equal but w/o the clock checks. Useful for checking if modes are close enough to re-use to avoid a boot time mode set for example. Signed-off-by: Kristian Høgsberg hoegsb...@gmail.com Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org ---

[Intel-gfx] [PATCH 4/4] drm/i915: use current mode if the size matches the preferred mode

2014-10-09 Thread Jesse Barnes
From: Kristian Høgsberg hoegsb...@gmail.com The BIOS may set a native mode that doesn't quite match the preferred mode timings. It should be ok to use however if it uses the same size, so try to avoid a mode set in that case. Signed-off-by: Kristian Høgsberg hoegsb...@gmail.com Signed-off-by:

[Intel-gfx] [PATCH] drm/i915/bdw: Remove BDW preproduction W/As until C stepping.

2014-10-09 Thread Rodrigo Vivi
Let's clean this a bit v2: Rebase after other Mika's patch that removed some BDW production workarounds. v3: Removed stepping info. Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com --- drivers/gpu/drm/i915/intel_pm.c | 10 --

Re: [Intel-gfx] [PATCH 10/10] drm/i915: Fix intel_dp_hot_plug()

2014-10-09 Thread Dave Airlie
On 10 October 2014 01:49, Chris Wilson ch...@chris-wilson.co.uk wrote: On Thu, Oct 09, 2014 at 08:38:10AM -0700, Todd Previte wrote: The hot plug function for DP appears to have been broken somewhere along the way. Without this function being operational, hot plug events are not correctly