[Intel-gfx] [PATCH 1/2] drm/i915: Removed orphaned prototype intel_dp_handle_hpd_irq()

2014-10-31 Thread Damien Lespiau
The function was removed in: commit 0e32b39ceed665bfa4a77a4bc307b6652b991632 Author: Dave Airlie Date: Fri May 2 14:02:48 2014 +1000 drm/i915: add DP 1.2 MST support (v0.7) Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_drv.h | 1 - 1 file changed, 1 deletion(-) d

[Intel-gfx] [PATCH 2/2] drm/i915: Remove orphaned prototype gen6_set_pm_mask()

2014-10-31 Thread Damien Lespiau
The function was removed in: commit 037bde19a43e299d30f0490bba9be32ab355975c Author: Chris Wilson Date: Thu Mar 27 08:24:19 2014 + Revert "drm/i915: Disable/Enable PM Intrrupts based on the current freq." Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_drv.h | 2

Re: [Intel-gfx] [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode v2

2014-10-31 Thread Jesse Barnes
Thanks for the review, Ander. Daniel, in case you're tempted to merge this, don't just yet. Shaung's test bot found an issue with the refactoring patch I'm still tracking down. I'll post a v3 with the fix in reply to this... Thanks, Jesse On Thu, 30 Oct 2014 11:53:59 -0700 Jesse Barnes wrote:

Re: [Intel-gfx] [PATCH] drm/i915: Disable caches for Global GTT.

2014-10-31 Thread Ausmus, James
On Fri, Oct 31, 2014 at 5:27 AM, Rodrigo Vivi wrote: > > Global GTT doesn't have pat_sel[2:0] so it always point to pat_sel = 000; > So the only way to avoid screen corruptions is setting PAT 0 to Uncached. > > MOCS can still be used though. But if userspace is trusting PTE for > cache selection t

Re: [Intel-gfx] [PATCH 17/68] Revert "drm/i915/bdw: Use timeout mode for RC6 on bdw"

2014-10-31 Thread Rodrigo Vivi
Please ignore my command and this revert. It seems original version that is currently applied is a needed Workaround. On Fri, Oct 31, 2014 at 12:45 PM, Rodrigo Vivi wrote: > I'm wondering how many hangs we could have fixed with this patch. > > Althougth it can end up in worst RC6 residency this i

Re: [Intel-gfx] [PATCH 17/68] Revert "drm/i915/bdw: Use timeout mode for RC6 on bdw"

2014-10-31 Thread Rodrigo Vivi
I'm wondering how many hangs we could have fixed with this patch. Althougth it can end up in worst RC6 residency this is what spec shows. From our experience with SNB it is always better to stay with spec, mainly on threshold values. So, Reviewed-by: Rodrigo Vivi On Thu, Aug 21, 2014 at 8:11

[Intel-gfx] [PATCH] drm/i915: Disable caches for Global GTT.

2014-10-31 Thread Rodrigo Vivi
Global GTT doesn't have pat_sel[2:0] so it always point to pat_sel = 000; So the only way to avoid screen corruptions is setting PAT 0 to Uncached. MOCS can still be used though. But if userspace is trusting PTE for cache selection the safest thing to do is to let caches disabled. BSpec: "For GGT

Re: [Intel-gfx] [PATCH 1/3] drm: Add a note to drm_property_create() about property lifetime

2014-10-31 Thread Daniel Vetter
On Fri, Oct 31, 2014 at 02:39:11PM +, Damien Lespiau wrote: > Cc: Chandra Konduru > Cc: Daniel Vetter > Signed-off-by: Damien Lespiau On the entire series: Reviewed-by: Daniel Vetter Merged into topic/core-stuff for shepherding until it lands in drm-next. -Daniel > --- > drivers/gpu/dr

Re: [Intel-gfx] [PATCH 1/3] drm: Pull drm_crtc.h into the kerneldoc template

2014-10-31 Thread Daniel Vetter
On Fri, Oct 31, 2014 at 07:25:08AM -0400, Sean Paul wrote: > On Wed, Oct 29, 2014 at 5:12 AM, Daniel Vetter wrote: > > While writing atomic docs I've noticed that I don't get any errors > > for my screw-ups in drm_crtc.h. Fix this immediately. > > > > This just does the bare minimum to get starts,

Re: [Intel-gfx] [PATCH] drm/i915: Add debugfs file to dump entire logical context

2014-10-31 Thread Volkin, Bradley D
On Thu, Oct 30, 2014 at 04:03:23PM -0700, armin.c.re...@intel.com wrote: > From: Armin Reese > > The new 'i915_context_dump' file generates a hex dump of the > entire logical context DRM object. It is useful for > validating the contents of the default context set up by > the golden state batch

Re: [Intel-gfx] [PATCH] drm/i915: Fix null pointer dereference in ring cleanup code

2014-10-31 Thread Chris Wilson
On Fri, Oct 31, 2014 at 02:52:40PM +, Damien Lespiau wrote: > On Fri, Oct 31, 2014 at 12:00:26PM +, john.c.harri...@intel.com wrote: > > From: John Harrison > > > > If a ring failed to initialise for any reason then the error path would try > > to > > clean up all rings including those t

Re: [Intel-gfx] [RFC] drm: Add utility function to check for edp1.4

2014-10-31 Thread Daniel Vetter
On Wed, Oct 29, 2014 at 02:42:29PM +0100, Thierry Reding wrote: > On Wed, Oct 22, 2014 at 11:45:23AM +0530, sonika.jin...@intel.com wrote: > > From: Sonika Jindal > > > > v2: Reading DP_EDP_REV, only when DISPLAY_CONTROL_CAPABLE field is set > > (Satheesh) > > > > v3: Moving the utility functio

[Intel-gfx] [PATCH] drm/i915: Pass vmas to i915_error_object_create

2014-10-31 Thread Mika Kuoppala
to move the interface to the ppgtt era. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gpu_error.c | 49 +++ 1 file changed, 27 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c

Re: [Intel-gfx] [PATCH] drm/i915: Fix null pointer dereference in ring cleanup code

2014-10-31 Thread Damien Lespiau
On Fri, Oct 31, 2014 at 12:00:26PM +, john.c.harri...@intel.com wrote: > From: John Harrison > > If a ring failed to initialise for any reason then the error path would try to > clean up all rings including those that had not yet been allocated. The ring > clean up code did a check that the r

[Intel-gfx] [PATCH 2/3] drm/i915: Don't destroy DRM properties in the driver

2014-10-31 Thread Damien Lespiau
When drm properties are created, they are added to mode_config.property_list, which is then used in drm_mode_config_cleanup() to destroy every single property created by the driver. Cc: Chandra Konduru Cc: Daniel Vetter Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_sdvo.c | 47 -

[Intel-gfx] [PATCH 3/3] drm/gma500: Don't destroy DRM properties in the driver

2014-10-31 Thread Damien Lespiau
When drm properties are created, they are added to mode_config.property_list which is then used in drm_mode_config_cleanup() to destroy every single property created by the driver. Cc: Patrik Jakobsson Signed-off-by: Damien Lespiau --- drivers/gpu/drm/gma500/psb_intel_sdvo.c | 49 --

[Intel-gfx] [PATCH 1/3] drm: Add a note to drm_property_create() about property lifetime

2014-10-31 Thread Damien Lespiau
Cc: Chandra Konduru Cc: Daniel Vetter Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_crtc.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 4081d7a..0f3c24c 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm

[Intel-gfx] [PATCH 1/2] drm/i915: Only mark as map-and-fenceable when bound into the GGTT

2014-10-31 Thread Chris Wilson
We use the obj->map_and_fenceable hint for when we already have a valid mapping of this object in the aperture. This hint can only apply to the GGTT and not to the aliasing-ppGTT. One user of the hint is execbuffer relocation, which began to fail when it tried to follow the hint and perform the rel

[Intel-gfx] [PATCH 2/2] drm/i915: Request PIN_GLOBAL when pinning a vma for GTT relocations

2014-10-31 Thread Chris Wilson
Always require PIN_GLOBAL when we want a mappable offset (PIN_MAPPABLE). This causes the pin to fixup the global binding in cases were the vma was already bound (and due to the proceeding bug, we considered it to be already mappable). References: https://bugs.freedesktop.org/show_bug.cgi?id=85671

[Intel-gfx] [PATCH] drm/i915: Fix null pointer dereference in ring cleanup code

2014-10-31 Thread John . C . Harrison
From: John Harrison If a ring failed to initialise for any reason then the error path would try to clean up all rings including those that had not yet been allocated. The ring clean up code did a check that the ring was valid before starting its work. Unfortunately, that was after it had already

Re: [Intel-gfx] [PATCH] drm/i915: Fix execlist cleanup bug

2014-10-31 Thread John Harrison
This is an old version. I have a new and improved patch that also fixes the legacy ring buffer case (which was equally broken). Will post shortly... On 30/10/2014 15:30, Dave Gordon wrote: From: John Harrison Check whether each engine exists before trying to clean up the corresponding logical

Re: [Intel-gfx] [PATCH 8/8] drm/i915/skl: Provide a Skylake version of get_plane_config()

2014-10-31 Thread Tvrtko Ursulin
On 10/29/2014 05:22 PM, Damien Lespiau wrote: Universal planes have changed a bit the register organization. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_display.c | 108 --- 1 file changed, 101 insertions(+), 7 deletions(-) diff --git a/driv

[Intel-gfx] [PATCH v3] drm/i915: Deflate error objects upon capture

2014-10-31 Thread Chris Wilson
When we capture the GPU error state, we allocate large amounts of memory to preserve copies of the active objects on the GPU. We can compress the copy in memory, and use an asci85 encoding when printing them out (to avoid presenting binary data to unsuspecting catting of debugfs/procfs). v2: Trail

[Intel-gfx] [PATCH] intel_error_decode: Inflate compressed error state

2014-10-31 Thread Chris Wilson
Recent kernels compress the active objects using zlib + ascii85 encoding. This adapts the tool to decompress those inplace. Signed-off-by: Chris Wilson --- tools/Makefile.sources | 1 + tools/intel_error_decode.c | 93 ++ 2 files changed, 94 inser

Re: [Intel-gfx] [PATCH 2/3] drm: fixup kerneldoc in drm_crtc.h

2014-10-31 Thread Sean Paul
On Wed, Oct 29, 2014 at 5:12 AM, Daniel Vetter wrote: > I've tried to cc all the people who have recently added new stuff > but forgotten to update documentation. > > I've also decided not to bother documenting the massive property list > in struct drm_mode_config. If that beast keeps on growing w

Re: [Intel-gfx] [PATCH 1/3] drm: Pull drm_crtc.h into the kerneldoc template

2014-10-31 Thread Sean Paul
On Wed, Oct 29, 2014 at 5:12 AM, Daniel Vetter wrote: > While writing atomic docs I've noticed that I don't get any errors > for my screw-ups in drm_crtc.h. Fix this immediately. > > This just does the bare minimum to get starts, lots of stuff isn't > properly documented yet unfortunately. > > Sig

Re: [Intel-gfx] [PATCH] drm/i915: Disable caches for Global GTT.

2014-10-31 Thread Chris Wilson
On Fri, Oct 31, 2014 at 12:14:25PM +0200, Ville Syrjälä wrote: > On Fri, Oct 31, 2014 at 07:44:34AM +, Chris Wilson wrote: > > On Thu, Oct 30, 2014 at 09:18:18AM -0700, Rodrigo Vivi wrote: > > > Global GTT doesn't have pat_sel[2:0] so it always point to pat_sel = 000; > > > So the only way to a

Re: [Intel-gfx] [PATCH] drm/i915: Disable caches for Global GTT.

2014-10-31 Thread Ville Syrjälä
On Fri, Oct 31, 2014 at 07:44:34AM +, Chris Wilson wrote: > On Thu, Oct 30, 2014 at 09:18:18AM -0700, Rodrigo Vivi wrote: > > Global GTT doesn't have pat_sel[2:0] so it always point to pat_sel = 000; > > So the only way to avoid screen corruptions is setting PAT 0 to Uncached. > > > > MOCS can

Re: [Intel-gfx] [PATCH 13/14] drm/i915: Use vlv display irq setup code for chv

2014-10-31 Thread Ville Syrjälä
On Thu, Oct 30, 2014 at 06:41:11PM -0200, Paulo Zanoni wrote: > 2014-10-30 15:43 GMT-02:00 : > > From: Ville Syrjälä > > > > Throw away the hand rolled display irq setup code on chv, and instead > > just call vlv_display_irq_postinstall() and vlv_display_irq_uninstall(). > > > > Signed-off-by: Vi

[Intel-gfx] [PATCH 15/14] drm/i915: Kill leftover GTIIR writes from valleyview_irq_preinstall()

2014-10-31 Thread ville . syrjala
From: Ville Syrjälä There are two leftover GTIIR writes in valleyview_irq_preinstall(). Looks like the were originally left behind by: commit d18ea1b58a5003eb6fca03aff03c4c01321e6cb1 Author: Daniel Vetter Date: Fri Jul 12 22:43:25 2013 +0200 drm/i915: unify PM interrupt preinstall seq

Re: [Intel-gfx] [PATCH 07/14] drm/i915: Call gen5_gt_irq_reset() from valleyview_irq_uninstall()

2014-10-31 Thread Ville Syrjälä
On Fri, Oct 31, 2014 at 11:35:52AM +0200, Ville Syrjälä wrote: > On Thu, Oct 30, 2014 at 05:51:49PM -0200, Paulo Zanoni wrote: > > 2014-10-30 15:42 GMT-02:00 : > > > From: Ville Syrjälä > > > > > > Looks like we forgot to call gen5_gt_irq_reset() for vlv in the > > > uninstall phase. Do so. > >

Re: [Intel-gfx] [PATCH 10/14] drm/i915: Refactor vlv_display_irq_uninstall()

2014-10-31 Thread Ville Syrjälä
On Thu, Oct 30, 2014 at 06:37:46PM -0200, Paulo Zanoni wrote: > 2014-10-30 18:22 GMT-02:00 Paulo Zanoni : > > 2014-10-30 15:42 GMT-02:00 : > >> From: Ville Syrjälä > >> > >> Pull the vlv display irq uninstall code into a separate function, for > >> eventual sharing with chv. > >> > >> Signed-off-

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-10-31 Thread Jani Nikula
[off-topic] On Fri, 31 Oct 2014, Ville Syrjälä wrote: > On Thu, Oct 30, 2014 at 12:57:04PM -0700, Kenneth Graunke wrote: >> I don't think HALF_SLICE_CHICKEN3 is part of the logical context, FWIW. > > Oh but it is. Lots of chickens like to nest in the context. In the context of lunch, HALF_SLICE

Re: [Intel-gfx] [PATCH 08/14] drm/i915: Make valleyview_display_irqs_(un)install() work for chv

2014-10-31 Thread Ville Syrjälä
On Thu, Oct 30, 2014 at 06:12:51PM -0200, Paulo Zanoni wrote: > 2014-10-30 15:42 GMT-02:00 : > > From: Ville Syrjälä > > > > Genralize valleyview_display_irqs_install() and > > valleyview_display_irqs_uninstall() enough so that they work on chv. > > The only difference to vlv here being the third

Re: [Intel-gfx] [PATCH 6/6] drm/i915: calculate pfit changes in set_config v2

2014-10-31 Thread Ander Conselvan de Oliveira
For the series, Reviewed-by: Ander Conselvan de Oliveira On 10/30/2014 08:54 PM, Jesse Barnes wrote: > This should allow us to avoid mode sets for some panel fitter config > changes. > > v2: >- fixup pfit comment (Ander) > > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/i915/intel

Re: [Intel-gfx] [PATCH 07/14] drm/i915: Call gen5_gt_irq_reset() from valleyview_irq_uninstall()

2014-10-31 Thread Ville Syrjälä
On Thu, Oct 30, 2014 at 05:51:49PM -0200, Paulo Zanoni wrote: > 2014-10-30 15:42 GMT-02:00 : > > From: Ville Syrjälä > > > > Looks like we forgot to call gen5_gt_irq_reset() for vlv in the > > uninstall phase. Do so. > > I also see that valleyview_irq_preinstall() contains 2 writes to GTIIR > ju

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-10-31 Thread Ville Syrjälä
On Thu, Oct 30, 2014 at 12:57:04PM -0700, Kenneth Graunke wrote: > On Thursday, October 30, 2014 09:26:01 PM Ville Syrjälä wrote: > > On Thu, Oct 30, 2014 at 10:32:38AM -0700, Kenneth Graunke wrote: > > > On Thursday, October 30, 2014 01:01:30 PM Ville Syrjälä wrote: > > > > On Thu, Oct 30, 2014 at

Re: [Intel-gfx] [PATCH v3] drm/i915/audio: rewrite vlv/chv and gen 5-7 audio codec enable sequence

2014-10-31 Thread Jani Nikula
On Thu, 30 Oct 2014, Rodrigo Vivi wrote: > On Tue, Oct 28, 2014 at 5:04 AM, Jani Nikula wrote: >> Similar to the hsw/bdw enable sequence rewrite. >> >> v3: replace vblank wait with a comment >> >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/i915/intel_audio.c | 58 >> +

[Intel-gfx] [PATCH] drm/i915: Deflate error objects upon capture

2014-10-31 Thread Chris Wilson
When we capture the GPU error state, we allocate large amounts of memory to preserve copies of the active objects on the GPU. We can compress the copy in memory, and use an asci85 encoding when printing them out (to avoid presenting binary data to unsuspecting catting of debugfs/procfs). v2: Trail

Re: [Intel-gfx] [PATCH v3] drm/i915: rewrite hsw/bdw audio codec enable/disable sequences

2014-10-31 Thread Jani Nikula
On Thu, 30 Oct 2014, Rodrigo Vivi wrote: > On Tue, Oct 28, 2014 at 5:03 AM, Jani Nikula wrote: >> There's some serious confusion regarding ELD valid bit that gets set and >> cleared back and forth etc. Rewrite it all based on the documented audio >> codec enable/disable sequences. >> >> v3: repla

Re: [Intel-gfx] [PATCH] drm/i915: Disable caches for Global GTT.

2014-10-31 Thread Chris Wilson
On Thu, Oct 30, 2014 at 09:18:18AM -0700, Rodrigo Vivi wrote: > Global GTT doesn't have pat_sel[2:0] so it always point to pat_sel = 000; > So the only way to avoid screen corruptions is setting PAT 0 to Uncached. > > MOCS can still be used though. But if userspace is trusting PTE for > cache sele