[Intel-gfx] [PATCH] drm: Per-plane locking

2014-11-03 Thread Daniel Vetter
Turned out to be much simpler on top of my latest atomic stuff than what I've feared. Some details: - Drop the modeset_lock_all snakeoil in drm_plane_init. Same justification as for the equivalent change in drm_crtc_init done in commit d0fa1af40e784aaf7ebb7ba8a17b229bb3fa4c21

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Only mark as map-and-fenceable when bound into the GGTT

2014-11-03 Thread Chris Wilson
On Fri, Oct 31, 2014 at 01:53:52PM +, Chris Wilson wrote: We use the obj-map_and_fenceable hint for when we already have a valid mapping of this object in the aperture. This hint can only apply to the GGTT and not to the aliasing-ppGTT. One user of the hint is execbuffer relocation, which

Re: [Intel-gfx] [RFC] drm: Add utility function to check for edp1.4

2014-11-03 Thread Thierry Reding
On Fri, Oct 31, 2014 at 05:06:39PM +0100, Daniel Vetter wrote: On Wed, Oct 29, 2014 at 02:42:29PM +0100, Thierry Reding wrote: On Wed, Oct 22, 2014 at 11:45:23AM +0530, sonika.jin...@intel.com wrote: From: Sonika Jindal sonika.jin...@intel.com v2: Reading DP_EDP_REV, only when

Re: [Intel-gfx] [RFC] drm: Add utility function to check for edp1.4

2014-11-03 Thread Daniel Vetter
On Mon, Nov 3, 2014 at 9:25 AM, Thierry Reding tred...@nvidia.com wrote: The idea is that you'd grab the DPCD field anyway since it's needed all over the place. We have a pile of helpers already that take exactly this block and decode parts of it. So I think this makes sense - dp aux is fast

Re: [Intel-gfx] [PATCH] drm: Per-plane locking

2014-11-03 Thread Ville Syrjälä
On Mon, Nov 03, 2014 at 12:07:02AM +0100, Daniel Vetter wrote: Turned out to be much simpler on top of my latest atomic stuff than what I've feared. Some details: - Drop the modeset_lock_all snakeoil in drm_plane_init. Same justification as for the equivalent change in drm_crtc_init done

Re: [Intel-gfx] [PATCH] drm: Per-plane locking

2014-11-03 Thread Daniel Vetter
On Mon, Nov 3, 2014 at 9:42 AM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: Were you planning to convert setplane over to this? Well yeah, I've forgotten about that one ... Will fix and resend. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 -

Re: [Intel-gfx] [PATCH] drm: Per-plane locking

2014-11-03 Thread Daniel Vetter
On Mon, Nov 3, 2014 at 10:02 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote: On Mon, Nov 3, 2014 at 9:42 AM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: Were you planning to convert setplane over to this? Well yeah, I've forgotten about that one ... Will fix and resend. Hm,

[Intel-gfx] [PATCH] demos/intel_sprite_on: Added support to compile intel_sprite_on on Android.

2014-11-03 Thread Gagandeep S Arora
From: gsarora gagandeep.s.ar...@intel.com Added Android.mk for intel_sprite_on. Signed-off-by: Gagandeep S Arora gagandeep.s.ar...@intel.com --- Android.mk | 2 +- demos/Android.mk| 27 ++ demos/intel_sprite_on.c | 61

[Intel-gfx] Macbook Air 6, 2: i915-related interrupt storm after Yosemite update

2014-11-03 Thread Christian Kastner
Hi, I have a Macbook Air (2013) (6,2) which until recently was working flawlessly with Debian unstable, which I use almost exclusively on that machine. I did keep the OSX installation, mainly because it's the only way to get firmware updates. Recently, in a moment of weakness, I said yes to the

Re: [Intel-gfx] [PATCH] drm/i915: Reject modeset when the same digital port is used more than once

2014-11-03 Thread Daniel Vetter
On Tue, Oct 28, 2014 at 11:20:37AM -0200, Paulo Zanoni wrote: 2014-05-19 11:19 GMT-03:00 ville.syrj...@linux.intel.com: From: Ville Syrjälä ville.syrj...@linux.intel.com On pre-HSW we have two encoders per digital port: one HDMI, one DP. However they are the same physical port in

Re: [Intel-gfx] [drm] 3.18 regression: backlight dark after resume

2014-11-03 Thread Jani Nikula
On Sat, 01 Nov 2014, Ortwin Glück o...@odi.ch wrote: Hi, Since 3.18-rc1 backlight is dark after resume from suspend. This is on a Samsung laptop with i5 IvyBridge 00:02.0 VGA compatible controller: Intel Corporation 3rd Gen Core processor Graphics Controller (rev 09) I have bisected

Re: [Intel-gfx] [RFC 21/21] drm/i915: Remove 'obj-ring'

2014-11-03 Thread Daniel Vetter
On Tue, Oct 28, 2014 at 03:09:07PM +, John Harrison wrote: On 19/10/2014 15:12, Daniel Vetter wrote: On Mon, Oct 06, 2014 at 03:15:25PM +0100, john.c.harri...@intel.com wrote: From: John Harrison john.c.harri...@intel.com For: VIZ-4377 Signed-off-by: john.c.harri...@intel.com I think

[Intel-gfx] [PATCH] drm/i915/dp: Don't stop the link when retraining

2014-11-03 Thread Daniel Vetter
On pre-ddi platforms we don't shut down the link when changing link training parameters. Except when clock recovery fails too hard and we restart with channel eq training. Which doesn't make a lot of sense really, since just stopping/restarting the DP port at this point violates the modeset

Re: [Intel-gfx] [PATCH 09/10] drm/i915: PSR Baytrail: Not available on Pipe C.

2014-11-03 Thread Imre Deak
On Tue, 2014-10-28 at 11:45 -0700, Rodrigo Vivi wrote: Altought VLV/CHV PSR supports per pipe PSR on VLV it isn't available on pipe C. Cherryview supports on all 3 pipes. Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com --- drivers/gpu/drm/i915/intel_dp.c | 8 1 file changed,

Re: [Intel-gfx] [RFC 20/21] drm/i915: Convert 'ring_idle()' to use requests not seqnos

2014-11-03 Thread Daniel Vetter
On Tue, Oct 28, 2014 at 02:03:14PM +, John Harrison wrote: On 19/10/2014 15:09, Daniel Vetter wrote: We have places that shovel stuff onto the ring without an explicit add_request. Or at least we've had, so this needs a full audit, and that audit needs to be in the commit message. Not

Re: [Intel-gfx] [RFC 09/21] drm/i915: Make 'i915_gem_check_olr' actually check by request not seqno

2014-11-03 Thread Daniel Vetter
On Tue, Oct 28, 2014 at 02:01:52PM +, John Harrison wrote: On 19/10/2014 13:55, Daniel Vetter wrote: On Mon, Oct 06, 2014 at 03:15:13PM +0100, john.c.harri...@intel.com wrote: From: John Harrison john.c.harri...@intel.com To thin commit message. Also I wonder whethere we should track

Re: [Intel-gfx] [RFC 22/21] drm/i915: Cache request completion status

2014-11-03 Thread Daniel Vetter
On Tue, Oct 28, 2014 at 03:36:29PM +, John Harrison wrote: On 19/10/2014 15:14, Daniel Vetter wrote: On Tue, Oct 07, 2014 at 05:47:29PM +0100, john.c.harri...@intel.com wrote: From: John Harrison john.c.harri...@intel.com For: VIZ-4377 Signed-off-by: john.c.harri...@intel.com Why? If

Re: [Intel-gfx] [RFC 24/25] drm/i915: Zero fill the request structure

2014-11-03 Thread Daniel Vetter
On Tue, Oct 28, 2014 at 03:55:21PM +, John Harrison wrote: On 19/10/2014 15:15, Daniel Vetter wrote: On Fri, Oct 10, 2014 at 12:41:12PM +0100, john.c.harri...@intel.com wrote: From: John Harrison john.c.harri...@intel.com For: VIZ-4377 Signed-off-by: john.c.harri...@intel.com I think

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Do vlv cmnlane toggle w/a in more cases

2014-11-03 Thread Daniel Vetter
On Tue, Oct 28, 2014 at 08:12:30PM +0200, Ville Syrjälä wrote: On Tue, Oct 28, 2014 at 10:57:38AM -0700, Jesse Barnes wrote: On Thu, 16 Oct 2014 20:52:33 +0300 ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com In case the cmnlane power well is

Re: [Intel-gfx] [PATCH 1/2] drm/i915: kill intel_resume_prepare()

2014-11-03 Thread Daniel Vetter
On Tue, Oct 28, 2014 at 04:47:14PM +0200, Imre Deak wrote: On Tue, 2014-10-28 at 11:43 -0200, Paulo Zanoni wrote: 2014-10-28 11:12 GMT-02:00 Imre Deak imre.d...@intel.com: On Mon, 2014-10-27 at 17:54 -0200, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com Because,

Re: [Intel-gfx] [PATCH] drm/i915: Add support for CHV pipe B sprite CSC

2014-11-03 Thread Daniel Vetter
On Thu, Oct 30, 2014 at 12:59:09PM -0700, Rodrigo Vivi wrote: [snip] Thanks for the explanation. I've copied most of them into the commmit message so that they'll stick around. Patch looks good. Reviewed-by Rodrigo Vivi rodrigo.v...@intel.com Queued for -next, thanks for the patch.

[Intel-gfx] fb.h

2014-11-03 Thread Patrick Welche
xf86-video-intel contains the file src/sna/fb/fb.h. Many source files in src/sna and src/uxa, and even src/legacy/i810/i810_driver.c #include fb.h Given that xserver provides and installs fb/fb.h, I would like to change the name of src/sna/fb/fb.h to something else to avoid the confusion in

[Intel-gfx] [PATCH i-g-t 3/5] testdisplay: ensure invalid long option exit status is non-zero

2014-11-03 Thread Thomas Wood
The optopt variable is not set if an invalid long option is used, so check the current option character instead. Signed-off-by: Thomas Wood thomas.w...@intel.com --- tests/testdisplay.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/testdisplay.c

[Intel-gfx] [PATCH i-g-t 4/5] testdiplay: add a --help option

2014-11-03 Thread Thomas Wood
Signed-off-by: Thomas Wood thomas.w...@intel.com --- tests/testdisplay.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/testdisplay.c b/tests/testdisplay.c index 8c6bc62..b7e1541 100644 --- a/tests/testdisplay.c +++ b/tests/testdisplay.c @@ -642,6 +642,7 @@ int main(int argc, char

[Intel-gfx] [PATCH i-g-t 2/5] lib/tests: don't use hard error status to indicate test failure

2014-11-03 Thread Thomas Wood
Signed-off-by: Thomas Wood thomas.w...@intel.com --- lib/tests/igt_command_line.sh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/tests/igt_command_line.sh b/lib/tests/igt_command_line.sh index 7e6ca67..5cf2584 100755 --- a/lib/tests/igt_command_line.sh +++

[Intel-gfx] [PATCH i-g-t 5/5] configure: fix issues when running outside the source tree

2014-11-03 Thread Thomas Wood
Signed-off-by: Thomas Wood thomas.w...@intel.com --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index d3faa19..a2569b8 100644 --- a/configure.ac +++ b/configure.ac @@ -203,7 +203,7 @@ AC_DEFINE_UNQUOTED(TARGET_CPU_PLATFORM,

[Intel-gfx] [PATCH i-g-t 1/5] lib/tests: fix tests and test list location

2014-11-03 Thread Thomas Wood
The igt_command_line.sh script was moved by commit 685e577 (Move library selftests to lib/tests), but the location of the tests and the test lists was not updated. Cc: Daniel Vetter daniel.vet...@ffwll.ch Signed-off-by: Thomas Wood thomas.w...@intel.com --- lib/tests/Makefile.am | 4

Re: [Intel-gfx] fb.h

2014-11-03 Thread Patrick Welche
On Mon, Nov 03, 2014 at 11:08:04AM +, Patrick Welche wrote: xf86-video-intel contains the file src/sna/fb/fb.h. Many source files in src/sna and src/uxa, and even src/legacy/i810/i810_driver.c #include fb.h Given that xserver provides and installs fb/fb.h, I would like to change the

Re: [Intel-gfx] [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode

2014-11-03 Thread Daniel Vetter
On Thu, Oct 30, 2014 at 11:38:20AM -0700, Jesse Barnes wrote: On Wed, 29 Oct 2014 16:30:43 +0200 Ander Conselvan de Oliveira conselv...@gmail.com wrote: On 10/23/2014 09:50 PM, Jesse Barnes wrote: +static int intel_modeset_compute_config(struct drm_crtc *crtc, s/drm_crtc/intel_crtc/

Re: [Intel-gfx] [PATCH] drm/i915: Report the actual swizzling back to userspace

2014-11-03 Thread Daniel Vetter
On Thu, Oct 30, 2014 at 10:40:53AM +, Chris Wilson wrote: On Mon, Oct 27, 2014 at 10:08:29AM +0100, Daniel Vetter wrote: On Fri, Oct 24, 2014 at 04:16:14PM +0100, Chris Wilson wrote: On Fri, Oct 24, 2014 at 04:39:29PM +0200, Daniel Vetter wrote: On Fri, Oct 24, 2014 at 12:11:11PM

Re: [Intel-gfx] [PATCH] drm/i915: Enable pipe-a power well on chv

2014-11-03 Thread Daniel Vetter
On Tue, Oct 28, 2014 at 10:59:05AM -0700, Jesse Barnes wrote: Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH v2 05/18] drm/i915/audio: pass intel_encoder on to platform specific ELD functions

2014-11-03 Thread Daniel Vetter
On Thu, Oct 30, 2014 at 10:52:39AM +0200, Jani Nikula wrote: On Wed, 29 Oct 2014, Rodrigo Vivi rodrigo.v...@gmail.com wrote: Oh, I was going to review the rest... but based on this comment I guess I might wait for a new v2 series right? No, I think it was in reference to *your* comments!

Re: [Intel-gfx] [PATCH v2 09/18] drm/i915/audio: remove misleading checks for !eld[0]

2014-11-03 Thread Daniel Vetter
On Mon, Oct 27, 2014 at 11:27:18AM -0700, Rodrigo Vivi wrote: I'm not 100% convinced drm_select_eld will always cover this check... so What do you think about changing it to a BUG_ON or at least a WARN_ON? Please don't kill the driver with a BUG_ON, always use WARN_ON instead. Except when the

Re: [Intel-gfx] [PATCH v3] drm/i915: rewrite hsw/bdw audio codec enable/disable sequences

2014-11-03 Thread Daniel Vetter
On Fri, Oct 31, 2014 at 11:12:33AM +0200, Jani Nikula wrote: We have drm_crtc_vblank_off very early in the disable sequence, and drm_crtc_vblank_on very late in the enable sequence. Especially early/late since commit 4b3a9526fc3228e74011b88f58088336acd2c9e2 Author: Ville Syrjälä

Re: [Intel-gfx] [PATCH 1/2] drm/i915: introduce pipe_config-ddi_personality

2014-11-03 Thread Daniel Vetter
On Tue, Oct 28, 2014 at 04:30:41PM +0200, Ville Syrjälä wrote: On Tue, Oct 28, 2014 at 11:26:51AM -0200, Paulo Zanoni wrote: + /* + * We can't change the DDI type if we already have a connected + * device on this port. The first time a DDI is

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Initialize PPS timetamps on vlv/chv

2014-11-03 Thread Daniel Vetter
On Tue, Oct 28, 2014 at 05:48:34PM +0200, Imre Deak wrote: On Tue, 2014-10-28 at 16:15 +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com The pps timestamp initialization was accidentally lost on vlv/chv in commit

Re: [Intel-gfx] [PATCH i-g-t 1/4] lib: add the ability to include a description with a test

2014-11-03 Thread Daniel Vetter
On Tue, Oct 28, 2014 at 03:10:25PM +, Damien Lespiau wrote: On Tue, Oct 28, 2014 at 03:03:53PM +, Thomas Wood wrote: +extern const char* __igt_test_description __attribute__((weak)); +#define IGT_TEST_DESCRIPTION(a) const char* __igt_test_description = a; It's usual to omit the ';'

Re: [Intel-gfx] [PATCH] drm/i915: Redefine WARN_ON to include the condition

2014-11-03 Thread Daniel Vetter
On Tue, Oct 28, 2014 at 05:32:30PM +0200, Mika Kuoppala wrote: When looking at the bug report logs with triggered WARN_ON, the person doing bug triaging will have to find exact kernel source and match file/line. Attach the condition that triggered the WARN_ON to kernel log. In most cases

Re: [Intel-gfx] [PATCH 02/10] drm/i915: VLV PSR: Status/enabled function.

2014-11-03 Thread Daniel Vetter
On Tue, Oct 28, 2014 at 11:45:35AM -0700, Rodrigo Vivi wrote: VLV PSR support PSR per pipe, including the status. So we have to check if it is enabled per pipe on status. Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com --- drivers/gpu/drm/i915/intel_dp.c | 23 +-- 1

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add kerneldoc for intel_pipe_update_{start, end}

2014-11-03 Thread Daniel Vetter
On Tue, Oct 28, 2014 at 03:10:12PM +0200, Ander Conselvan de Oliveira wrote: Signed-off-by: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com --- drivers/gpu/drm/i915/intel_sprite.c | 25 + 1 file changed, 25 insertions(+) diff --git

Re: [Intel-gfx] [PATCH 1/2] drm/i915: introduce pipe_config-ddi_personality

2014-11-03 Thread Daniel Vetter
On Mon, Nov 03, 2014 at 01:15:24PM +0100, Daniel Vetter wrote: On Tue, Oct 28, 2014 at 04:30:41PM +0200, Ville Syrjälä wrote: On Tue, Oct 28, 2014 at 11:26:51AM -0200, Paulo Zanoni wrote: + /* + * We can't change the DDI type if we already have a connected

Re: [Intel-gfx] [PATCH i-g-t 2/2] lib/tests: use the check_ prefix for tests

2014-11-03 Thread Daniel Vetter
On Wed, Oct 29, 2014 at 05:30:52PM +, Thomas Wood wrote: The check_ prefix ensures the test programs are not installed and are only built when make check is run. Signed-off-by: Thomas Wood thomas.w...@intel.com This was actually fairly intentional since when developing I always forget to

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add kerneldoc for intel_pipe_update_{start, end}

2014-11-03 Thread Ander Conselvan de Oliveira
On 11/03/2014 02:33 PM, Daniel Vetter wrote: On Tue, Oct 28, 2014 at 03:10:12PM +0200, Ander Conselvan de Oliveira wrote: Signed-off-by: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com --- drivers/gpu/drm/i915/intel_sprite.c | 25 + 1 file changed,

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-11-03 Thread Daniel Vetter
On Fri, Oct 31, 2014 at 11:27:33AM +0200, Ville Syrjälä wrote: On Thu, Oct 30, 2014 at 12:57:04PM -0700, Kenneth Graunke wrote: Before we get too much further...we should check if libva is actually broken. I don't know if this means the sampler palette completely doesn't work, or if

Re: [Intel-gfx] [PATCH] drm/i915: HSW/BDW PSR Set idle_frames=2 since sometimes it can be off by 1.

2014-11-03 Thread Daniel Vetter
On Thu, Oct 30, 2014 at 05:35:55AM -0700, Rodrigo Vivi wrote: It was identified that in some cases when moving cursor Hardware can do mistake with idle_frame count. So Spec is being updated to use 2 as minimum idle_frames. Reference:

Re: [Intel-gfx] [PATCH] drm/i915: Fix null pointer dereference in ring cleanup code

2014-11-03 Thread Daniel Vetter
On Fri, Oct 31, 2014 at 04:07:35PM +, Chris Wilson wrote: On Fri, Oct 31, 2014 at 02:52:40PM +, Damien Lespiau wrote: On Fri, Oct 31, 2014 at 12:00:26PM +, john.c.harri...@intel.com wrote: From: John Harrison john.c.harri...@intel.com If a ring failed to initialise for any

Re: [Intel-gfx] [PATCH] drm/i915: Remove redundant return value and WARN_ON

2014-11-03 Thread Daniel Vetter
On Thu, Oct 30, 2014 at 03:41:56PM +, Dave Gordon wrote: execlists_submit_context() always returns 0, which is redundant. And its name is inaccurate, since it actually submits (up to) TWO contextS. So we rename it, change it to void, and remove the WARN_ON() testing its return value.

[Intel-gfx] [PATCH] drm/i915: Bug fixes to ring 'head' updating

2014-11-03 Thread Dave Gordon
Fixes to both the LRC and the legacy ringbuffer code to correctly calculate and update the available space in a ring. The logical ring code was updating the software ring 'head' value by reading the hardware 'HEAD' register. In LRC mode, this is not valid as the hardware is not necessarily

[Intel-gfx] fix non-XVMC build

2014-11-03 Thread Patrick Welche
It seems that inclusion of intel_xvmc.h is usually protected by INTEL_XVMC. The unprotected inclusion in src/uda/i965_video.c doesn't seem to be necessary so rather than protect it, the following should be sufficient? Cheers, Patrick diff --git a/src/uxa/i965_video.c b/src/uxa/i965_video.c

[Intel-gfx] [PATCH 2/2] drm/i915: Check pipe_config.has_dp_encoder instead of encoder types

2014-11-03 Thread Daniel Vetter
More concise. Noticed while reviewing Ander's patch which touched a lot of the pipe_has_type checks. Signed-off-by: Daniel Vetter daniel.vet...@intel.com --- drivers/gpu/drm/i915/intel_display.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git

[Intel-gfx] [PATCH 1/2] drm/i915: Simplify the pfit check in the fastboot hack

2014-11-03 Thread Daniel Vetter
Checking for lvds/edp is wrong (since we also support dsi panels now) and not terribly useless. If we want to be more intelligent about all this then we need to look at the old state to figure out whether the pfit adjustment is needed. This goes all the way back to the original fastboot pfit

Re: [Intel-gfx] [PATCH 1/9] drm/i915: Make *_crtc_mode_set work on new_config

2014-11-03 Thread Daniel Vetter
On Wed, Oct 29, 2014 at 11:32:30AM +0200, Ander Conselvan de Oliveira wrote: + if (num_encoders != 1) + WARN(1, %d encoders on crtc for pipe %c\n, num_encoders, + pipe_name(crtc-pipe)); I've folded the check into the WARN here. -Daniel -- Daniel Vetter

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Simplify the pfit check in the fastboot hack

2014-11-03 Thread Jani Nikula
On Mon, 03 Nov 2014, Daniel Vetter daniel.vet...@ffwll.ch wrote: Checking for lvds/edp is wrong (since we also support dsi panels now) and not terribly useless. If we want to be more intelligent about all wrong ... and not terribly useless? useful? BR, Jani. this then we need to look at the

Re: [Intel-gfx] [PATCH 4/9] drm/i915: Add infrastructure for choosing DPLLs before disabling crtcs

2014-11-03 Thread Daniel Vetter
On Wed, Oct 29, 2014 at 11:32:33AM +0200, Ander Conselvan de Oliveira wrote: It is possible for a mode set to fail if there aren't shared DPLLS that match the new configuration requirement or other errors in clock computation. If that step is executed after disabling crtcs, in the failure case

Re: [Intel-gfx] [PATCH 4/9] drm/i915: Add infrastructure for choosing DPLLs before disabling crtcs

2014-11-03 Thread Daniel Vetter
On Mon, Nov 03, 2014 at 02:51:27PM +0100, Daniel Vetter wrote: On Wed, Oct 29, 2014 at 11:32:33AM +0200, Ander Conselvan de Oliveira wrote: It is possible for a mode set to fail if there aren't shared DPLLS that match the new configuration requirement or other errors in clock computation.

Re: [Intel-gfx] [PATCH v2 0/9] Stage shared dpll config

2014-11-03 Thread Daniel Vetter
On Wed, Oct 29, 2014 at 11:32:29AM +0200, Ander Conselvan de Oliveira wrote: Version 2 of the series with the comments I got so far resolved. Ander Conselvan de Oliveira (9): drm/i915: Make *_crtc_mode_set work on new_config drm/i915: Convert shared dpll reference count to a crtc mask

Re: [Intel-gfx] [PATCH] drm/i915: Make intel_pipe_has_type() take an output type enum

2014-11-03 Thread Daniel Vetter
On Wed, Oct 29, 2014 at 01:48:15PM +0200, Jani Nikula wrote: On Wed, 29 Oct 2014, Damien Lespiau damien.lesp...@intel.com wrote: As Paulo said when introducing the enum, having more types is really good to document what should go where (int foo(int, int, bool, bool). Cc: Paulo Zanoni

Re: [Intel-gfx] [PATCH] drm/i915: Remove unused WATCH_GTT define

2014-11-03 Thread Daniel Vetter
On Wed, Oct 29, 2014 at 12:03:45PM +, Damien Lespiau wrote: Chris removed the code using it in: commit be2d599b5da3936ca92e0187ff50b34b6b8ff997 Author: Chris Wilson ch...@chris-wilson.co.uk Date: Wed Sep 10 19:52:18 2014 +0100 drm/i915: Remove dead code,

Re: [Intel-gfx] [PATCH i-g-t 2/2] lib/igt_core.h: add debug messages for test requirements

2014-11-03 Thread Daniel Vetter
On Wed, Oct 29, 2014 at 03:20:47PM +, Thomas Wood wrote: @@ -380,6 +382,7 @@ void igt_exit(void) __attribute__((noreturn)); */ #define igt_require_f(expr, f...) do { \ if (!(expr)) igt_skip_check(#expr , f); \ + else igt_debug(Test requirement passed: #expr\n); \ } while

[Intel-gfx] [PATCH 1/8 v2] drm/i915/skl: Make 'end' of the DDB allocation entry exclusive

2014-11-03 Thread Damien Lespiau
Ville suggested that we should use the same semantics as C arrays to reduce the number of those pesky +1/-1 in the allocation code. This patch leaves the debugfs file as is, showing the internal DDB allocation structure, not the values written in the registers. v2: Remove the test on -end in

Re: [Intel-gfx] [PATCH] drm/i915: Pass vmas to i915_error_object_create

2014-11-03 Thread Daniel Vetter
On Fri, Oct 31, 2014 at 05:38:31PM +0200, Mika Kuoppala wrote: to move the interface to the ppgtt era. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_gpu_error.c | 49 +++ 1 file changed, 27 insertions(+), 22

[Intel-gfx] [PATCH] drm/i915: Move pll state commit into intel_modeset_update_state

2014-11-03 Thread Daniel Vetter
It's really part of the push all new_* state into current state pointers done in that function. So let's move it there to make this clear. Also, with the conversion done the num_shared_dpll check the function does in it's loop is enough, so we can drop the check for the dpll compute callback,

[Intel-gfx] [PULL] drm-intel-next

2014-11-03 Thread Daniel Vetter
Hi Dave, drm-intel-next-2014-10-24: - suspend/resume/freeze/thaw unification from Imre - wa list improvements from MikaArun - display pll precomputation from Ander Conselvan prep work - more kerneldoc for the interrupt code - 180 rotation for cursors (VilleSonika) - ULT/ULX feature check macros

Re: [Intel-gfx] [PATCH] demos/intel_sprite_on: Added support to compile intel_sprite_on on Android.

2014-11-03 Thread Daniel Vetter
On Tue, Nov 04, 2014 at 02:20:38PM +0530, Gagandeep S Arora wrote: +/* + * The macros and structures inside the conditional statement + * #if (ANDROID_HAS_CAIRO == 1) are defined in lib/igt_kms.c + * when the flag ANDROID_HAS_CAIRO is 1. + */ +#if (ANDROID_HAS_CAIRO == 0) +struct type_name

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Simplify the pfit check in the fastboot hack

2014-11-03 Thread Daniel Vetter
On Mon, Nov 03, 2014 at 03:49:32PM +0200, Jani Nikula wrote: On Mon, 03 Nov 2014, Daniel Vetter daniel.vet...@ffwll.ch wrote: Checking for lvds/edp is wrong (since we also support dsi panels now) and not terribly useless. If we want to be more intelligent about all wrong ... and not

Re: [Intel-gfx] [PATCH 15/17] drm/atomic-helpers: functions for state duplicate/destroy/reset

2014-11-03 Thread Daniel Vetter
On Mon, Nov 03, 2014 at 02:45:28PM +, Daniel Thompson wrote: index 70bd67cf86e3..bd38df3cbe55 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -1429,7 +1429,7 @@ EXPORT_SYMBOL(drm_atomic_helper_set_config); /** *

Re: [Intel-gfx] [PATCH i-g-t 2/5] lib/tests: don't use hard error status to indicate test failure

2014-11-03 Thread Daniel Vetter
On Mon, Nov 03, 2014 at 11:31:02AM +, Thomas Wood wrote: Signed-off-by: Thomas Wood thomas.w...@intel.com --- lib/tests/igt_command_line.sh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/tests/igt_command_line.sh b/lib/tests/igt_command_line.sh index

Re: [Intel-gfx] [PATCH 0/8] Skylake primary plane read-out

2014-11-03 Thread Daniel Vetter
On Wed, Oct 29, 2014 at 05:22:39PM +, Damien Lespiau wrote: Skylake changed a few things here and there in the plane registers and we weren't correctly reading out the primary plane state when trying to re-use the BIOS stolen allocated fb (especially the stride was all wrong). Of course,

Re: [Intel-gfx] [PATCH 15/17] drm/atomic-helpers: functions for state duplicate/destroy/reset

2014-11-03 Thread Daniel Vetter
On Mon, Nov 03, 2014 at 03:06:07PM +, Daniel Thompson wrote: kfree is a nop when the argument is NULL, which is a crucial property of this - memset would oops on driver load. Oops. Missed that (I think I misread who as assuming there was always obj-state in the patch header). Do you

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Only mark as map-and-fenceable when bound into the GGTT

2014-11-03 Thread Daniel Vetter
On Fri, Oct 31, 2014 at 01:53:52PM +, Chris Wilson wrote: @@ -4091,6 +4078,7 @@ i915_gem_object_pin(struct drm_i915_gem_object *obj, } } + bound = vma ? vma-bound : 0; if (vma == NULL || !drm_mm_node_allocated(vma-node)) { vma =

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Request PIN_GLOBAL when pinning a vma for GTT relocations

2014-11-03 Thread Daniel Vetter
On Fri, Oct 31, 2014 at 01:53:53PM +, Chris Wilson wrote: Always require PIN_GLOBAL when we want a mappable offset (PIN_MAPPABLE). This causes the pin to fixup the global binding in cases were the vma was already bound (and due to the proceeding bug, we considered it to be already

[Intel-gfx] [PATCH 3/8 v2] drm/i915/skl: Make res_blocks/lines intermediate values 32 bits

2014-11-03 Thread Damien Lespiau
To align with the ilk WM code and because it makes sense to test against the upper bounds as soon as possible on variables that are bigger than the number of bits in the register, let's move the maximum checks from skl_compute_wm_results() to skl_compute_plane_wm(). v2: Leave the result values to

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Remove orphaned prototype gen6_set_pm_mask()

2014-11-03 Thread Daniel Vetter
On Sat, Nov 01, 2014 at 05:05:57AM +, Damien Lespiau wrote: The function was removed in: commit 037bde19a43e299d30f0490bba9be32ab355975c Author: Chris Wilson ch...@chris-wilson.co.uk Date: Thu Mar 27 08:24:19 2014 + Revert drm/i915: Disable/Enable PM Intrrupts based

Re: [Intel-gfx] [PATCH 15/17] drm/atomic-helpers: functions for state duplicate/destroy/reset

2014-11-03 Thread Daniel Thompson
On 02/11/14 13:19, Daniel Vetter wrote: The atomic users and helpers assume that there is always a obj-state structure around. Which means drivers need to somehow create that at driver load time. Also it should obviously reset hardware state, so needs to be reset upon resume. Finally the

Re: [Intel-gfx] [PATCH 15/17] drm/atomic-helpers: functions for state duplicate/destroy/reset

2014-11-03 Thread Daniel Thompson
On 03/11/14 14:53, Daniel Vetter wrote: On Mon, Nov 03, 2014 at 02:45:28PM +, Daniel Thompson wrote: index 70bd67cf86e3..bd38df3cbe55 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -1429,7 +1429,7 @@

Re: [Intel-gfx] Macbook Air 6, 2: i915-related interrupt storm after Yosemite update

2014-11-03 Thread Daniel Vetter
On Sat, Nov 01, 2014 at 06:08:00PM +0100, Christian Kastner wrote: Hi, I have a Macbook Air (2013) (6,2) which until recently was working flawlessly with Debian unstable, which I use almost exclusively on that machine. I did keep the OSX installation, mainly because it's the only way to get

Re: [Intel-gfx] [PATCH 1/4] drm/i915/bdw: Clean up execlist queue items in retire_work

2014-11-03 Thread Daniel Vetter
On Wed, Oct 29, 2014 at 09:52:50AM +, Thomas Daniel wrote: No longer create a work item to clean each execlist queue item. Instead, move retired execlist requests to a queue and clean up the items during retire_requests. v2: Fix legacy ring path broken during overzealous cleanup v3:

Re: [Intel-gfx] [PATCH 2/4] drm/i915/bdw: Setup global hardware status page in execlists mode

2014-11-03 Thread Daniel Vetter
On Wed, Oct 29, 2014 at 09:52:51AM +, Thomas Daniel wrote: Write HWS_PGA address even in execlists mode as the global hardware status page is still required. This address was previously uninitialized and HWSP writes would clobber whatever buffer happened to reside at GGTT address 0.

Re: [Intel-gfx] [RFC 3/5] drm/i915: Infrastructure for supporting different GGTT views per object

2014-11-03 Thread Daniel Vetter
On Thu, Oct 30, 2014 at 04:39:36PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com Things like reliable GGTT mappings and mirrored 3d display will need to be to map the same object twice into the GGTT. Add a ggtt_view field per VMA and select the page view based

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Make scatter-gather helper available to the driver

2014-11-03 Thread Daniel Vetter
On Thu, Oct 30, 2014 at 04:39:37PM +, Tvrtko Ursulin wrote: Just a sideline comment here for now ;-) +/* intel_dma.c */ +int i915_st_set_pages(struct sg_table **st, struct page **pvec, int num_pages); Comments all over should tell you that i915_dma.c is super legacy territory and really

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Make scatter-gather helper available to the driver

2014-11-03 Thread Daniel Vetter
On Thu, Oct 30, 2014 at 04:39:37PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com It will be used by other call sites shortly. Signed-off-by: Tvrtko Ursulin tvrtko.ursu...@intel.com --- drivers/gpu/drm/i915/i915_dma.c | 38 +

Re: [Intel-gfx] [PATCH 1/4] drm/i915/bdw: Clean up execlist queue items in retire_work

2014-11-03 Thread Daniel, Thomas
-Original Message- From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter Sent: Monday, November 03, 2014 3:33 PM To: Daniel, Thomas Cc: intel-gfx@lists.freedesktop.org; shuang...@linux.intel.com Subject: Re: [Intel-gfx] [PATCH 1/4] drm/i915/bdw: Clean up

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-11-03 Thread Dave Gordon
On 30/10/14 19:26, Ville Syrjälä wrote: On Thu, Oct 30, 2014 at 10:32:38AM -0700, Kenneth Graunke wrote: On Thursday, October 30, 2014 01:01:30 PM Ville Syrjälä wrote: On Thu, Oct 30, 2014 at 02:32:40AM -0700, Kenneth Graunke wrote: On Thursday, October 30, 2014 11:00:51 AM Ville Syrjälä

Re: [Intel-gfx] [RFC 5/5] drm/i915: Make intel_pin_and_fence_fb_obj take plane and framebuffer

2014-11-03 Thread Daniel Vetter
On Thu, Oct 30, 2014 at 04:39:38PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com It will help future code if this function knows something about of the context of the display setup object is being pinned for. Signed-off-by: Tvrtko Ursulin

Re: [Intel-gfx] [PATCH 1/4] drm/i915/bdw: Clean up execlist queue items in retire_work

2014-11-03 Thread Daniel Vetter
On Mon, Nov 03, 2014 at 04:05:03PM +, Daniel, Thomas wrote: -Original Message- From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter Sent: Monday, November 03, 2014 3:33 PM To: Daniel, Thomas Cc: intel-gfx@lists.freedesktop.org;

[Intel-gfx] [PATCH] drm: More specific locking for get* ioctls

2014-11-03 Thread Daniel Vetter
Motivated by the per-plane locking I've gone through all the get* ioctls and reduced the locking to the bare minimum required. Signed-off-by: Daniel Vetter daniel.vet...@intel.com --- drivers/gpu/drm/drm_crtc.c | 43 +-- 1 file changed, 17 insertions(+),

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Make scatter-gather helper available to the driver

2014-11-03 Thread Tvrtko Ursulin
On 11/03/2014 04:02 PM, Daniel Vetter wrote: On Thu, Oct 30, 2014 at 04:39:37PM +, Tvrtko Ursulin wrote: Just a sideline comment here for now ;-) +/* intel_dma.c */ +int i915_st_set_pages(struct sg_table **st, struct page **pvec, int num_pages); Comments all over should tell you that

Re: [Intel-gfx] [PATCH 07/14] drm/i915: Call gen5_gt_irq_reset() from valleyview_irq_uninstall()

2014-11-03 Thread Daniel Vetter
On Fri, Oct 31, 2014 at 11:48:01AM +0200, Ville Syrjälä wrote: On Fri, Oct 31, 2014 at 11:35:52AM +0200, Ville Syrjälä wrote: On Thu, Oct 30, 2014 at 05:51:49PM -0200, Paulo Zanoni wrote: 2014-10-30 15:42 GMT-02:00 ville.syrj...@linux.intel.com: From: Ville Syrjälä

Re: [Intel-gfx] [PATCH 08/14] drm/i915: Make valleyview_display_irqs_(un)install() work for chv

2014-11-03 Thread Daniel Vetter
On Fri, Oct 31, 2014 at 11:40:36AM +0200, Ville Syrjälä wrote: On Thu, Oct 30, 2014 at 06:12:51PM -0200, Paulo Zanoni wrote: While trying to check for the correctness of the lines above, I noticed that in __i915_enable_pipestat(), if the enable mask is already what we want, we won't

Re: [Intel-gfx] [RFC 3/5] drm/i915: Infrastructure for supporting different GGTT views per object

2014-11-03 Thread Tvrtko Ursulin
On 11/03/2014 03:58 PM, Daniel Vetter wrote: On Thu, Oct 30, 2014 at 04:39:36PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com Things like reliable GGTT mappings and mirrored 3d display will need to be to map the same object twice into the GGTT. Add a ggtt_view

Re: [Intel-gfx] [PATCH 13/14] drm/i915: Use vlv display irq setup code for chv

2014-11-03 Thread Daniel Vetter
On Thu, Oct 30, 2014 at 06:41:11PM -0200, Paulo Zanoni wrote: 2014-10-30 15:43 GMT-02:00 ville.syrj...@linux.intel.com: gen8_gt_irq_postinstall(dev_priv); @@ -3620,7 +3594,6 @@ static void valleyview_irq_uninstall(struct drm_device *dev) static void

Re: [Intel-gfx] [PATCH 00/14] drm/i915: IRQ work for chv mostly

2014-11-03 Thread Daniel Vetter
On Thu, Oct 30, 2014 at 07:42:49PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com After enabling the pipe-a power well on CHV I noticed that hpd and interrupts didn't work too well anymore. The reason is the same as on VLV; the power well kills

Re: [Intel-gfx] [PATCH] drm/i915: fix Unexpected fault error message line break

2014-11-03 Thread Daniel Vetter
On Thu, Oct 30, 2014 at 03:52:45PM -0200, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com Fix the message, not the fault :) This is what I see: [ 282.108597] [drm:i915_check_and_clear_faults] Unexpected fault [ 282.108597]Addr: 0x\n Address space:

Re: [Intel-gfx] [PATCH] drm/i915: fix RPS on runtime suspend

2014-11-03 Thread Daniel Vetter
On Thu, Oct 30, 2014 at 10:36:23PM +0200, Imre Deak wrote: On Thu, 2014-10-30 at 15:59 -0200, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com With this patch, the RPS sequence for runtime suspend/resume is exactly like the sequence for S3 suspend/resume: -

Re: [Intel-gfx] [PATCH i-g-t 2/5] lib/tests: don't use hard error status to indicate test failure

2014-11-03 Thread Daniel Vetter
On Mon, Nov 03, 2014 at 03:42:06PM +, Thomas Wood wrote: On 3 November 2014 15:02, Daniel Vetter dan...@ffwll.ch wrote: On Mon, Nov 03, 2014 at 11:31:02AM +, Thomas Wood wrote: Signed-off-by: Thomas Wood thomas.w...@intel.com --- lib/tests/igt_command_line.sh | 8 1

Re: [Intel-gfx] [RFC 3/5] drm/i915: Infrastructure for supporting different GGTT views per object

2014-11-03 Thread Daniel Vetter
On Mon, Nov 03, 2014 at 04:34:29PM +, Tvrtko Ursulin wrote: On 11/03/2014 03:58 PM, Daniel Vetter wrote: On Thu, Oct 30, 2014 at 04:39:36PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com Things like reliable GGTT mappings and mirrored 3d display will need to

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Make scatter-gather helper available to the driver

2014-11-03 Thread Daniel Vetter
On Mon, Nov 03, 2014 at 04:18:30PM +, Tvrtko Ursulin wrote: On 11/03/2014 04:02 PM, Daniel Vetter wrote: On Thu, Oct 30, 2014 at 04:39:37PM +, Tvrtko Ursulin wrote: Just a sideline comment here for now ;-) +/* intel_dma.c */ +int i915_st_set_pages(struct sg_table **st, struct

Re: [Intel-gfx] [PATCH 3/4] drm/i915/bdw: Pin the context backing objects to GGTT on-demand

2014-11-03 Thread Daniel Vetter
On Wed, Oct 29, 2014 at 09:52:52AM +, Thomas Daniel wrote: From: Oscar Mateo oscar.ma...@intel.com Up until now, we have pinned every logical ring context backing object during creation, and left it pinned until destruction. This made my life easier, but it's a harmful thing to do,

Re: [Intel-gfx] [PATCH 3/4] drm/i915/bdw: Pin the context backing objects to GGTT on-demand

2014-11-03 Thread Daniel, Thomas
-Original Message- From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter Sent: Monday, November 03, 2014 4:54 PM To: Daniel, Thomas Cc: intel-gfx@lists.freedesktop.org; shuang...@linux.intel.com Subject: Re: [Intel-gfx] [PATCH 3/4] drm/i915/bdw: Pin the

Re: [Intel-gfx] [PATCH 01/29] drm/i915: Remove redundant parameter to i915_gem_object_wait_rendering__tail()

2014-11-03 Thread Daniel Vetter
On Thu, Oct 30, 2014 at 06:40:53PM +, john.c.harri...@intel.com wrote: From: John Harrison john.c.harri...@intel.com An earlier commit (c8725f3dc0911d4354315a65150aecd8b7d0d74a: Do not call retire_requests from wait_for_rendering) removed the use of the ring parameter within

  1   2   >