Re: [Intel-gfx] [PATCH 2/3] drm/i915: Android sync points for i915 v3

2014-12-04 Thread Chris Wilson
On Wed, Dec 03, 2014 at 11:49:06AM -0800, Jesse Barnes wrote: Expose an ioctl to create Android fences based on the Android sync point infrastructure (which in turn is based on DMA-buf fences). Just a sketch at this point, no testing has been done. There are a couple of goals here: 1)

Re: [Intel-gfx] [PATCH] drm/i915/chv: Enable HDMI Clock recovery for Pipe C

2014-12-04 Thread Jani Nikula
On Wed, 03 Dec 2014, Clint Taylor clinton.a.tay...@intel.com wrote: On 12/03/2014 01:01 PM, Ville Syrjälä wrote: On Wed, Dec 03, 2014 at 10:10:30AM -0800, clinton.a.tay...@intel.com wrote: From: Clint Taylor clinton.a.tay...@intel.com Added PIPE C register support for CHV audio programming.

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Android sync points for i915 v3

2014-12-04 Thread Chris Wilson
On Thu, Dec 04, 2014 at 08:10:22AM +, Chris Wilson wrote: If I understand correctly, the fence timeline are indeed per-ring, but here you set them up (and name them) on a per-engine basis. On reflection, the timeline are per-fd, so using the engine name is not confusing after all. -Chris

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Clean up pinned bo capture

2014-12-04 Thread Chris Wilson
On Wed, Dec 03, 2014 at 03:16:09PM +0100, Daniel Vetter wrote: On Tue, Dec 02, 2014 at 04:46:38PM +, Chris Wilson wrote: On Tue, Dec 02, 2014 at 04:19:43PM +0100, Daniel Vetter wrote: /* Generate a semi-unique error code. The code is not meant to have meaning, The @@ -1085,7

Re: [Intel-gfx] [PATCH 3/3] drm/i915: add fences to the request struct

2014-12-04 Thread Chris Wilson
On Wed, Dec 03, 2014 at 11:49:07AM -0800, Jesse Barnes wrote: This simplifies the sync code quite a bit. I don't think we'll be able to get away with using the core fence code's seqno support, since we'll be moving away from simple seqno comparisions with the scheduler and preemption, but the

Re: [Intel-gfx] [PATCH 01/10] drm/i915: New functions added for enabling disabling MIPI Port Ctrl reg

2014-12-04 Thread Jani Nikula
On Thu, 04 Dec 2014, Gaurav K Singh gaurav.k.si...@intel.com wrote: This patch is in preparation for the DSI dual link port enable and disable related changes. Signed-off-by: Gaurav K Singh gaurav.k.si...@intel.com Signed-off-by: Shobhit Kumar shobhit.ku...@intel.com Reviewed-by: Jani Nikula

Re: [Intel-gfx] [PATCH 02/10] drm/i915: Added port as parameter to the functions which does read/write of DSI Controller

2014-12-04 Thread Jani Nikula
On Thu, 04 Dec 2014, Gaurav K Singh gaurav.k.si...@intel.com wrote: This patch is in preparation of DSI dual link panels. For dual link panels, few packets needs to be sent to Port A or Port C or both. Based on the portno from MIPI Sequence Block#53, these sequences needs to be sent

Re: [Intel-gfx] [PATCH 03/10] drm/i915: Add support for port enable/disable for dual link configuration

2014-12-04 Thread Jani Nikula
On Thu, 04 Dec 2014, Gaurav K Singh gaurav.k.si...@intel.com wrote: For Dual Link MIPI Panels, both Port A and Port C should be enabled during the MIPI encoder enabling sequence. Similarly, during the disabling sequence, both ports needs to be disabled. v2: Used for_each_dsi_port macro

[Intel-gfx] [PULL] drm-intel-fixes

2014-12-04 Thread Jani Nikula
Hi Dave - Silence some pch fifo underrun reports and panel locking backtraces, both cc: stable. BR, Jani. The following changes since commit 009d0431c3914de64666bec0d350e54fdd59df6a: Linux 3.18-rc7 (2014-11-30 16:42:27 -0800) are available in the git repository at:

Re: [Intel-gfx] [PATCH 04/10] drm/i915: Pixel Clock changes for DSI dual link

2014-12-04 Thread Jani Nikula
On Thu, 04 Dec 2014, Gaurav K Singh gaurav.k.si...@intel.com wrote: For dual link MIPI Panels, each port needs half of pixel clock. Pixel overlap can be enabled if needed by panel, then in that case, pixel clock will be increased for extra pixels. v2 : Address review comments by Jani -

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Stop putting GGTT VMA at the head of the list

2014-12-04 Thread Chris Wilson
On Wed, Dec 03, 2014 at 02:59:24PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com Multiple GGTT VMAs per object will be introduced in the near future which will make it impossible to guarantee normal GGTT view is at the head of the list. Purpose of this patch is

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Infrastructure for supporting different GGTT views per object

2014-12-04 Thread Chris Wilson
On Wed, Dec 03, 2014 at 02:59:25PM +, Tvrtko Ursulin wrote: +void i915_vma_bind(struct i915_vma *vma, enum i915_cache_level cache_level, +u32 flags) +{ + struct sg_table *pages = i915_ggtt_view_pages(vma); + + if (pages !IS_ERR(pages)) { +

[Intel-gfx] [PULL] drm-intel-next-fixes

2014-12-04 Thread Daniel Vetter
Hi Dave, Fixes for 3.20. I did stick the gen3/4 reset work from Ville in because we have an awful lot of gen4 mesa hangs, and with this reset should also work on vintage i965g/gm (we already have reset for g4x/gen4.5). So should help to appease users suffering from these hangs. Otherwise all

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Stop putting GGTT VMA at the head of the list

2014-12-04 Thread Tvrtko Ursulin
On 12/04/2014 09:48 AM, Chris Wilson wrote: On Wed, Dec 03, 2014 at 02:59:24PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com Multiple GGTT VMAs per object will be introduced in the near future which will make it impossible to guarantee normal GGTT view is at the

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Stop putting GGTT VMA at the head of the list

2014-12-04 Thread Chris Wilson
On Thu, Dec 04, 2014 at 10:02:19AM +, Tvrtko Ursulin wrote: On 12/04/2014 09:48 AM, Chris Wilson wrote: On Wed, Dec 03, 2014 at 02:59:24PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com Multiple GGTT VMAs per object will be introduced in the near future

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Infrastructure for supporting different GGTT views per object

2014-12-04 Thread Tvrtko Ursulin
On 12/04/2014 09:53 AM, Chris Wilson wrote: On Wed, Dec 03, 2014 at 02:59:25PM +, Tvrtko Ursulin wrote: +void i915_vma_bind(struct i915_vma *vma, enum i915_cache_level cache_level, + u32 flags) +{ + struct sg_table *pages = i915_ggtt_view_pages(vma); + + if

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Infrastructure for supporting different GGTT views per object

2014-12-04 Thread Chris Wilson
On Thu, Dec 04, 2014 at 10:19:09AM +, Tvrtko Ursulin wrote: On 12/04/2014 09:53 AM, Chris Wilson wrote: On Wed, Dec 03, 2014 at 02:59:25PM +, Tvrtko Ursulin wrote: +void i915_vma_bind(struct i915_vma *vma, enum i915_cache_level cache_level, + u32 flags) +{ + struct

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Stop putting GGTT VMA at the head of the list

2014-12-04 Thread Tvrtko Ursulin
On 12/04/2014 10:17 AM, Chris Wilson wrote: On Thu, Dec 04, 2014 at 10:02:19AM +, Tvrtko Ursulin wrote: On 12/04/2014 09:48 AM, Chris Wilson wrote: On Wed, Dec 03, 2014 at 02:59:24PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com Multiple GGTT VMAs per

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Stop putting GGTT VMA at the head of the list

2014-12-04 Thread Chris Wilson
On Thu, Dec 04, 2014 at 10:30:30AM +, Tvrtko Ursulin wrote: On 12/04/2014 10:17 AM, Chris Wilson wrote: On Thu, Dec 04, 2014 at 10:02:19AM +, Tvrtko Ursulin wrote: On 12/04/2014 09:48 AM, Chris Wilson wrote: On Wed, Dec 03, 2014 at 02:59:24PM +, Tvrtko Ursulin wrote: From:

Re: [Intel-gfx] [PATCH 05/10] drm/i915: Dual link needs Shutdown and Turn on packet for both ports

2014-12-04 Thread Jani Nikula
On Thu, 04 Dec 2014, Gaurav K Singh gaurav.k.si...@intel.com wrote: For dual link MIPI panels, SHUTDOWN packet needs to send to both Ports A C during MIPI encoder disabling sequence. Similarly, TURN ON packet to be sent to both Ports during MIPI encoder enabling sequence. v2: Address review

Re: [Intel-gfx] [PATCH] drm/i915: compute wait_ioctl timeout correctly

2014-12-04 Thread Daniel Vetter
On Wed, Dec 03, 2014 at 11:07:08AM -0800, John Stultz wrote: On Wed, Dec 3, 2014 at 6:30 AM, Daniel Vetter dan...@ffwll.ch wrote: On Tue, Dec 02, 2014 at 08:54:13AM -0800, John Stultz wrote: On Tue, Dec 2, 2014 at 8:35 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, Dec 02,

[Intel-gfx] [PATCH] drm/i915: compute wait_ioctl timeout correctly

2014-12-04 Thread Daniel Vetter
We've lost the +1 required for correct timeouts in commit 5ed0bdf21a85d78e04f89f15ccf227562177cbd9 Author: Thomas Gleixner t...@linutronix.de Date: Wed Jul 16 21:05:06 2014 + drm: i915: Use nsec based interfaces Use ktime_get_raw_ns() and get rid of the back and forth timespec

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Clean up pinned bo capture

2014-12-04 Thread Daniel Vetter
On Thu, Dec 04, 2014 at 09:11:10AM +, Chris Wilson wrote: On Wed, Dec 03, 2014 at 03:16:09PM +0100, Daniel Vetter wrote: On Tue, Dec 02, 2014 at 04:46:38PM +, Chris Wilson wrote: On Tue, Dec 02, 2014 at 04:19:43PM +0100, Daniel Vetter wrote: /* Generate a semi-unique error code.

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Stop putting GGTT VMA at the head of the list

2014-12-04 Thread Tvrtko Ursulin
On 12/04/2014 10:39 AM, Chris Wilson wrote: On Thu, Dec 04, 2014 at 10:30:30AM +, Tvrtko Ursulin wrote: So personally you don't think it should be of any concern if a GGTT VMA is at the head of the list, but it is not the same GGTT VMA which you would find there in majority of cases?

Re: [Intel-gfx] X hang with quirk VT switches

2014-12-04 Thread Takashi Iwai
At Wed, 3 Dec 2014 18:31:45 +, Chris Wilson wrote: On Wed, Dec 03, 2014 at 03:45:35PM +0100, Takashi Iwai wrote: Hi, while checking the reported bug about VT switch hang on openSUSE 13.2, I also could reproduce a similar issue as reported: namely, X hangs when repeatedly

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Stop putting GGTT VMA at the head of the list

2014-12-04 Thread Daniel Vetter
On Thu, Dec 04, 2014 at 09:48:11AM +, Chris Wilson wrote: On Wed, Dec 03, 2014 at 02:59:24PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com Multiple GGTT VMAs per object will be introduced in the near future which will make it impossible to guarantee

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Infrastructure for supporting different GGTT views per object

2014-12-04 Thread Daniel Vetter
On Thu, Dec 04, 2014 at 10:26:14AM +, Chris Wilson wrote: On Thu, Dec 04, 2014 at 10:19:09AM +, Tvrtko Ursulin wrote: On 12/04/2014 09:53 AM, Chris Wilson wrote: On Wed, Dec 03, 2014 at 02:59:25PM +, Tvrtko Ursulin wrote: +void i915_vma_bind(struct i915_vma *vma, enum

Re: [Intel-gfx] [PATCH i-g-t 3/5] lib: introduce log domains

2014-12-04 Thread Thomas Wood
On 3 December 2014 at 14:22, Daniel Vetter dan...@ffwll.ch wrote: On Tue, Dec 02, 2014 at 05:15:37PM +, Thomas Wood wrote: diff --git a/lib/igt_core.h b/lib/igt_core.h index a258348..5c5ee25 100644 --- a/lib/igt_core.h +++ b/lib/igt_core.h @@ -512,16 +512,20 @@ bool

Re: [Intel-gfx] [PATCH] drm/i915/chv: Add additional workarounds for CHV

2014-12-04 Thread Ville Syrjälä
On Wed, Dec 03, 2014 at 07:15:31PM +, Arun Siluvery wrote: These w/a were recently identified while debugging another issue, +WaClearFlowControlGpgpuContextSave:chv +Wa4x4STCOptimizationDisable:chv For: VIZ-4090 Change-Id: I08d2176dec609396c3a7c2e48b2413e233799fc4 Signed-off-by: Arun

Re: [Intel-gfx] [PATCH] drm/i915: Don't display nonsensical values in i915_ddb_info on gen 9

2014-12-04 Thread Daniel Vetter
On Wed, Dec 03, 2014 at 10:19:24PM +0200, Ville Syrjälä wrote: On Wed, Dec 03, 2014 at 05:33:24PM +, Damien Lespiau wrote: When playing around with debugfs and a HSW machine I noticed that we were displaying some garbled value in i915_ddb_info. This debugfs file is only meaningful for

Re: [Intel-gfx] [PATCH 3/3] drm/i915: add fences to the request struct

2014-12-04 Thread Daniel Vetter
On Thu, Dec 04, 2014 at 09:13:21AM +, Chris Wilson wrote: On Wed, Dec 03, 2014 at 11:49:07AM -0800, Jesse Barnes wrote: This simplifies the sync code quite a bit. I don't think we'll be able to get away with using the core fence code's seqno support, since we'll be moving away from

Re: [Intel-gfx] [PATCH] drm/i915/chv: Add additional workarounds for CHV

2014-12-04 Thread Daniel Vetter
On Thu, Dec 04, 2014 at 12:58:40PM +0200, Ville Syrjälä wrote: On Wed, Dec 03, 2014 at 07:15:31PM +, Arun Siluvery wrote: These w/a were recently identified while debugging another issue, +WaClearFlowControlGpgpuContextSave:chv +Wa4x4STCOptimizationDisable:chv For: VIZ-4090

Re: [Intel-gfx] [PATCH 06/10] drm/i915: Enable DSI PLL for both DSI0 and DSI1 in case of dual link

2014-12-04 Thread Jani Nikula
On Thu, 04 Dec 2014, Gaurav K Singh gaurav.k.si...@intel.com wrote: For Dual link MIPI Panels, dsipll clock for both DSI0 and DSI1 needs to be enabled. v2: Address review comments by Jani - Added wait time for PLL to be locked. v3: separate patch created for cck read for checking PLL

[Intel-gfx] [PATCH i-g-t] tests: add gem_gpgpu_fill to .gitignore

2014-12-04 Thread Thomas Wood
gem_gpgpu_fill was added in commit 4ec8479 (tests: Add gem_gpgpu_fill), but wasn't added to .gitignore. Cc: Zhenyu Wang zhen...@linux.intel.com Signed-off-by: Thomas Wood thomas.w...@intel.com --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Android sync points for i915 v3

2014-12-04 Thread Daniel Vetter
On Wed, Dec 03, 2014 at 11:49:06AM -0800, Jesse Barnes wrote: Expose an ioctl to create Android fences based on the Android sync point infrastructure (which in turn is based on DMA-buf fences). Just a sketch at this point, no testing has been done. There are a couple of goals here: 1)

Re: [Intel-gfx] X hang with quirk VT switches

2014-12-04 Thread Chris Wilson
On Thu, Dec 04, 2014 at 11:53:05AM +0100, Takashi Iwai wrote: At Wed, 3 Dec 2014 18:31:45 +, Chris Wilson wrote: On Wed, Dec 03, 2014 at 03:45:35PM +0100, Takashi Iwai wrote: Hi, while checking the reported bug about VT switch hang on openSUSE 13.2, I also could reproduce a

Re: [Intel-gfx] [PATCH 02/10] drm/i915: Added port as parameter to the functions which does read/write of DSI Controller

2014-12-04 Thread Daniel Vetter
On Thu, Dec 04, 2014 at 11:14:01AM +0200, Jani Nikula wrote: On Thu, 04 Dec 2014, Gaurav K Singh gaurav.k.si...@intel.com wrote: This patch is in preparation of DSI dual link panels. For dual link panels, few packets needs to be sent to Port A or Port C or both. Based on the portno from

Re: [Intel-gfx] [PATCH 07/10] drm/i915: cck reg used for checking DSI Pll locked

2014-12-04 Thread Jani Nikula
On Thu, 04 Dec 2014, Gaurav K Singh gaurav.k.si...@intel.com wrote: Instead of pipe configuration reg, cck reg to be used for checking whether DSI Pll is getting locked or not. Signed-off-by: Gaurav K Singh gaurav.k.si...@intel.com Signed-off-by: Shobhit Kumar shobhit.ku...@intel.com ---

Re: [Intel-gfx] [PATCH 08/10] drm/i915: MIPI Timings related changes for dual link

2014-12-04 Thread Jani Nikula
On Thu, 04 Dec 2014, Gaurav K Singh gaurav.k.si...@intel.com wrote: hactive, hfp, hbp, hsync needs to be halved for dual link MIPI Panels. Accordingly timing related mmio regs needs to be programmed for both MIPI Ports. v2: Address review comments by Jani - Used a for loop instead of

Re: [Intel-gfx] [PATCH 3/3] drm/i915: add fences to the request struct

2014-12-04 Thread Chris Wilson
On Thu, Dec 04, 2014 at 12:05:34PM +0100, Daniel Vetter wrote: On Thu, Dec 04, 2014 at 09:13:21AM +, Chris Wilson wrote: On Wed, Dec 03, 2014 at 11:49:07AM -0800, Jesse Barnes wrote: This simplifies the sync code quite a bit. I don't think we'll be able to get away with using the

Re: [Intel-gfx] [PATCH 09/10] drm/i915: Update the DSI disable path to support dual link panel disabling

2014-12-04 Thread Jani Nikula
On Thu, 04 Dec 2014, Gaurav K Singh gaurav.k.si...@intel.com wrote: We need to program both port registers during dual link disable path. v2: Address review comments by Jani - Used a for loop instead of do-while loop. v3: Used for_each_dsi_port macro instead of for loop Signed-off-by:

Re: [Intel-gfx] X hang with quirk VT switches

2014-12-04 Thread Takashi Iwai
At Thu, 4 Dec 2014 11:21:47 +, Chris Wilson wrote: On Thu, Dec 04, 2014 at 11:53:05AM +0100, Takashi Iwai wrote: At Wed, 3 Dec 2014 18:31:45 +, Chris Wilson wrote: On Wed, Dec 03, 2014 at 03:45:35PM +0100, Takashi Iwai wrote: Hi, while checking the reported bug

Re: [Intel-gfx] [PATCH 10/10] drm/i915: Update the DSI enable path to support dual link panel enabling

2014-12-04 Thread Jani Nikula
On Thu, 04 Dec 2014, Gaurav K Singh gaurav.k.si...@intel.com wrote: We need to program both port registers during dual link enable path. v2: Address review comments by Jani - Used a for loop instead of do-while loop. v3: Used for_each_dsi_port macro instead of for loop Signed-off-by:

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Infrastructure for supporting different GGTT views per object

2014-12-04 Thread Tvrtko Ursulin
On 12/04/2014 10:59 AM, Daniel Vetter wrote: On Thu, Dec 04, 2014 at 10:26:14AM +, Chris Wilson wrote: On Thu, Dec 04, 2014 at 10:19:09AM +, Tvrtko Ursulin wrote: On 12/04/2014 09:53 AM, Chris Wilson wrote: On Wed, Dec 03, 2014 at 02:59:25PM +, Tvrtko Ursulin wrote: +void

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Infrastructure for supporting different GGTT views per object

2014-12-04 Thread Chris Wilson
On Thu, Dec 04, 2014 at 12:17:51PM +, Tvrtko Ursulin wrote: On 12/04/2014 10:59 AM, Daniel Vetter wrote: On Thu, Dec 04, 2014 at 10:26:14AM +, Chris Wilson wrote: On Thu, Dec 04, 2014 at 10:19:09AM +, Tvrtko Ursulin wrote: On 12/04/2014 09:53 AM, Chris Wilson wrote: On Wed, Dec

Re: [Intel-gfx] [PATCH 3/3] drm/i915: add fences to the request struct

2014-12-04 Thread Daniel Vetter
On Thu, Dec 4, 2014 at 12:29 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: It uses locked atomic operations, which are unnecessary for the very frequent is-complete checks (due to the nice ordering constraints of x86). So let's look at the fastpaths: - fence already signaled: Just a test_bit

[Intel-gfx] [PATCH v2 0/2] drm/i915: sanitize RPS resetting during GPU reset

2014-12-04 Thread Imre Deak
This is v2 of patchset [1], with one issue fixed that was noticed by Paulo. Patch 1/1 of the original patchset is already merged. [1] http://lists.freedesktop.org/archives/intel-gfx/2014-November/055969.html Imre Deak (2): drm/i915: move RPS PM_IER enabling to gen6_enable_rps_interrupts

[Intel-gfx] [PATCH v2 1/2] drm/i915: move RPS PM_IER enabling to gen6_enable_rps_interrupts

2014-12-04 Thread Imre Deak
Paulo noticed that we don't enable RPS interrupts via PM_IER in gen6_enable_rps_interrupts(). This wasn't a problem so far, since the only place we disabled RPS interrupts was during system/runtime suspend and after that we reenable all interrupts in the IRQ pre/postinstall hooks. In the next

[Intel-gfx] [PATCH v2 2/2] drm/i915: sanitize RPS resetting during GPU reset

2014-12-04 Thread Imre Deak
Atm, we don't disable RPS interrupts and related work items before resetting the GPU. This may interfere with the following GPU initialization and cause RPS interrupts to show up in PM_IIR too early before calling gen6_enable_rps_interrupts() (triggering a WARN there). Solve this by disabling RPS

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Infrastructure for supporting different GGTT views per object

2014-12-04 Thread Daniel Vetter
On Thu, Dec 4, 2014 at 1:17 PM, Tvrtko Ursulin tvrtko.ursu...@linux.intel.com wrote: I looked at propagating errors from i915_vma_bind() out to callers and it is mostly all fine apart from the i915_gem_restore_gtt_mappings during i915_drm_resume. Bummer. I don't see how this is fixable apart

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Organize bind_vma funcs

2014-12-04 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV -1 364/364

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: sanitize RPS resetting during GPU reset

2014-12-04 Thread Daniel Vetter
On Thu, Dec 04, 2014 at 02:59:32PM +0200, Imre Deak wrote: Atm, we don't disable RPS interrupts and related work items before resetting the GPU. This may interfere with the following GPU initialization and cause RPS interrupts to show up in PM_IIR too early before calling

[Intel-gfx] [PATCH i-g-t] gem_bad_reloc: Don't flip-flop between SKIP and PASS

2014-12-04 Thread Damien Lespiau
Here is a cheap way for this test to give consistent results. This doesn't change the usefulness of this test, hopefully. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- tests/gem_bad_reloc.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

Re: [Intel-gfx] [PATCH i-g-t] gem_bad_reloc: Don't flip-flop between SKIP and PASS

2014-12-04 Thread Damien Lespiau
On Thu, Dec 04, 2014 at 01:58:54PM +, Damien Lespiau wrote: Here is a cheap way for this test to give consistent results. This doesn't change the usefulness of this test, hopefully. Signed-off-by: Damien Lespiau damien.lesp...@intel.com And: Bugzilla:

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: sanitize RPS resetting during GPU reset

2014-12-04 Thread Imre Deak
On Thu, 2014-12-04 at 14:58 +0100, Daniel Vetter wrote: On Thu, Dec 04, 2014 at 02:59:32PM +0200, Imre Deak wrote: Atm, we don't disable RPS interrupts and related work items before resetting the GPU. This may interfere with the following GPU initialization and cause RPS interrupts to show

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Android sync points for i915 v3

2014-12-04 Thread Jesse Barnes
On Thu, 4 Dec 2014 12:21:01 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Wed, Dec 03, 2014 at 11:49:06AM -0800, Jesse Barnes wrote: Expose an ioctl to create Android fences based on the Android sync point infrastructure (which in turn is based on DMA-buf fences). Just a sketch at this

[Intel-gfx] [PATCH] drm/i915/bdw: Add WaHdcDisableFetchWhenMasked

2014-12-04 Thread Michel Thierry
We already have it for chv, but was missing for bdw. Signed-off-by: Michel Thierry michel.thie...@intel.com --- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Add WaHdcDisableFetchWhenMasked

2014-12-04 Thread Ville Syrjälä
On Thu, Dec 04, 2014 at 03:07:52PM +, Michel Thierry wrote: We already have it for chv, but was missing for bdw. Signed-off-by: Michel Thierry michel.thie...@intel.com --- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Add WaHdcDisableFetchWhenMasked

2014-12-04 Thread Michel Thierry
On 12/4/2014 3:25 PM, Ville Syrjälä wrote: On Thu, Dec 04, 2014 at 03:07:52PM +, Michel Thierry wrote: We already have it for chv, but was missing for bdw. Signed-off-by: Michel Thierry michel.thie...@intel.com --- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 ++ 1 file changed, 2

[Intel-gfx] [PATCH v2] drm/i915/bdw: Add WaHdcDisableFetchWhenMasked

2014-12-04 Thread Michel Thierry
We already have it for chv, but was missing for bdw. v2: Label WaForceEnableNonCoherent (Ville) Cc: Ville Syrjälä ville.syrj...@linux.intel.com Signed-off-by: Michel Thierry michel.thie...@intel.com --- drivers/gpu/drm/i915/intel_ringbuffer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[Intel-gfx] [PATCH 2/3] tests/pm_rps: vlv: load gpu for idle min/max tests

2014-12-04 Thread Imre Deak
When changing the sysfs GT min/max frequencies, the kernel won't explicitly change the current frequency, unless it becomes out of bound based on the new min/max values. The test happens to work on non-VLV platforms because on those the kernel resets the current frequency unconditionally (to

[Intel-gfx] [PATCH 0/3] igt/pm_rps: fix some subcases for vlv

2014-12-04 Thread Imre Deak
While checking my latest RPS patchset, this test was failing on VLV, so I went ahead and fixed a couple of issues I found. With these fixes and a related kernel change to fix the VLV minimum frequency value the basic-api and min-max-config subtests are passing for me on VLV. The reset and

[Intel-gfx] [PATCH 3/3] tests/pm_rps: vlv: round middle point to freq supported by HW

2014-12-04 Thread Imre Deak
Atm the test assumes that the calculated middle frequency point is supported by the HW, but it's not so at least on VLV. On my B0 BYT-M there is a 22MHz step between the allowed values, so the test will fail trying to set the calculated middle freq that isn't aligned to this. To fix this get the

Re: [Intel-gfx] [PATCH i-g-t] gem_bad_reloc: Don't flip-flop between SKIP and PASS

2014-12-04 Thread Chris Wilson
On Thu, Dec 04, 2014 at 01:58:54PM +, Damien Lespiau wrote: Here is a cheap way for this test to give consistent results. This doesn't change the usefulness of this test, hopefully. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- tests/gem_bad_reloc.c | 8 +++- 1 file

Re: [Intel-gfx] [PATCH 3/3] tests/pm_rps: vlv: round middle point to freq supported by HW

2014-12-04 Thread Ville Syrjälä
On Thu, Dec 04, 2014 at 06:09:40PM +0200, Imre Deak wrote: Atm the test assumes that the calculated middle frequency point is supported by the HW, but it's not so at least on VLV. On my B0 BYT-M there is a 22MHz step between the allowed values, so the test will fail trying to set the

[Intel-gfx] [PATCH] drm/i915: vlv: clamp minimum RPS frequency to what Punit allows

2014-12-04 Thread Imre Deak
As described in the code comment, I couldn't set the minimum RPS frequency on my BYT-M B0 to the minimum allowed as reported by Punit. Fix this by clamping the minimum value to the first one that was accepted on my machine. This fixes at least the pm_rpm basic-api and min-max-config subtests.

Re: [Intel-gfx] [PATCH i-g-t] gem_bad_reloc: Don't flip-flop between SKIP and PASS

2014-12-04 Thread Damien Lespiau
On Thu, Dec 04, 2014 at 04:18:39PM +, Chris Wilson wrote: On Thu, Dec 04, 2014 at 01:58:54PM +, Damien Lespiau wrote: Here is a cheap way for this test to give consistent results. This doesn't change the usefulness of this test, hopefully. Signed-off-by: Damien Lespiau

Re: [Intel-gfx] [PATCH] drm/i915: compute wait_ioctl timeout correctly

2014-12-04 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV 364/364

Re: [Intel-gfx] [RFC 0/7+1] Add in-kernel vblank delaying mechanism

2014-12-04 Thread Daniel Vetter
On Wed, Nov 19, 2014 at 8:47 PM, Paulo Zanoni przan...@gmail.com wrote: 2. How should the driver interface look like? a. All the possibilities are passed through the function call, so the drm.ko code needs to set the struct members itself. b. The caller already sets the struct

Re: [Intel-gfx] [PATCH] drm/i915: compute wait_ioctl timeout correctly

2014-12-04 Thread John Stultz
On Thu, Dec 4, 2014 at 2:42 AM, Daniel Vetter dan...@ffwll.ch wrote: On Wed, Dec 03, 2014 at 11:07:08AM -0800, John Stultz wrote: On Wed, Dec 3, 2014 at 6:30 AM, Daniel Vetter dan...@ffwll.ch wrote: On Tue, Dec 02, 2014 at 08:54:13AM -0800, John Stultz wrote: On Tue, Dec 2, 2014 at 8:35 AM,

Re: [Intel-gfx] [PATCH] drm/i915: compute wait_ioctl timeout correctly

2014-12-04 Thread John Stultz
On Thu, Dec 4, 2014 at 2:12 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote: We've lost the +1 required for correct timeouts in commit 5ed0bdf21a85d78e04f89f15ccf227562177cbd9 Author: Thomas Gleixner t...@linutronix.de Date: Wed Jul 16 21:05:06 2014 + drm: i915: Use nsec based

Re: [Intel-gfx] [PATCH] drm/i915: compute wait_ioctl timeout correctly

2014-12-04 Thread Daniel Vetter
On Thu, Dec 4, 2014 at 6:42 PM, John Stultz john.stu...@linaro.org wrote: On Thu, Dec 4, 2014 at 2:42 AM, Daniel Vetter dan...@ffwll.ch wrote: On Wed, Dec 03, 2014 at 11:07:08AM -0800, John Stultz wrote: On Wed, Dec 3, 2014 at 6:30 AM, Daniel Vetter dan...@ffwll.ch wrote: On Tue, Dec 02, 2014

[Intel-gfx] Issues with Guessed macro values for registers in i915_reg.h

2014-12-04 Thread nick
Greetings Daniel and the other maintainers, I am wondering if you have access to the hardware spec for these drivers supported by this header file. If you do I would really appreciate the correct values for the registers pasted below as the person who wrote this code, stated he guessed them. Due

Re: [Intel-gfx] [PATCH] drm/i915: compute wait_ioctl timeout correctly

2014-12-04 Thread John Stultz
On Thu, Dec 4, 2014 at 9:50 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote: On Thu, Dec 4, 2014 at 6:42 PM, John Stultz john.stu...@linaro.org wrote: Sigh. So you're going to make me write a separate patch that moves it over? We've written it already, Imre posted the link to the old

[Intel-gfx] [PATCH 10/10] drm/i915: Make all plane disables use 'update_plane' (v5)

2014-12-04 Thread Matt Roper
If we extend the commit_plane handlers for each plane type to be able to handle fb=0, then we can easily implement plane disable via the update_plane handler. The cursor plane already works this way, and this is the direction we need to go to integrate with the atomic plane handler. We can now

Re: [Intel-gfx] [PATCH] drm/i915: compute wait_ioctl timeout correctly

2014-12-04 Thread Daniel Vetter
On Thu, Dec 4, 2014 at 7:16 PM, John Stultz john.stu...@linaro.org wrote: On Thu, Dec 4, 2014 at 9:50 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote: On Thu, Dec 4, 2014 at 6:42 PM, John Stultz john.stu...@linaro.org wrote: Sigh. So you're going to make me write a separate patch that moves it

Re: [Intel-gfx] [PATCH] drm/i915/chv: Enable HDMI Clock recovery for Pipe C

2014-12-04 Thread Clint Taylor
On 12/04/2014 12:41 AM, Jani Nikula wrote: On Wed, 03 Dec 2014, Clint Taylor clinton.a.tay...@intel.com wrote: On 12/03/2014 01:01 PM, Ville Syrjälä wrote: On Wed, Dec 03, 2014 at 10:10:30AM -0800, clinton.a.tay...@intel.com wrote: From: Clint Taylor clinton.a.tay...@intel.com Added PIPE C

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: sanitize RPS resetting during GPU reset

2014-12-04 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV 364/364

Re: [Intel-gfx] [ANNOUNCE][RFC] KVMGT - the implementation of Intel GVT-g(full GPU virtualization) for KVM

2014-12-04 Thread Igor Gnatenko
On Dec 4, 2014 5:27 AM, Jike Song jike.s...@intel.com wrote: Hi all, Hi, We are pleased to announce the first release of KVMGT project. KVMGT is the implementation of Intel GVT-g technology, a full GPU virtualization solution. Under Intel GVT-g, a virtual GPU instance is maintained for each

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Add WaHdcDisableFetchWhenMasked

2014-12-04 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV 364/364

Re: [Intel-gfx] [PATCH] drm/i915: compute wait_ioctl timeout correctly

2014-12-04 Thread John Stultz
On Thu, Dec 4, 2014 at 10:51 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote: On Thu, Dec 4, 2014 at 7:16 PM, John Stultz john.stu...@linaro.org wrote: On Thu, Dec 4, 2014 at 9:50 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote: On Thu, Dec 4, 2014 at 6:42 PM, John Stultz john.stu...@linaro.org

Re: [Intel-gfx] [PATCH] drm/i915: don't always do full mode sets when infoframes are enabled

2014-12-04 Thread Jesse Barnes
On Mon, 1 Dec 2014 09:54:28 -0800 Jesse Barnes jbar...@virtuousgeek.org wrote: Partial revert of commit 206645910b9796bff13fcdb67bdca166b724ba62 Author: Jesse Barnes jbar...@virtuousgeek.org Date: Wed Nov 5 14:26:09 2014 -0800 drm/i915: check for audio and infoframe changes across

[Intel-gfx] [PATCH] drm: Make drm_read() more robust against multithreaded races

2014-12-04 Thread Chris Wilson
The current implementation of drm_read() faces a number of issues: 1. Upon an error, it consumes the event which may lead to the client blocking. 2. Upon an error, it forgets about events already copied 3. If it fails to copy a single event with O_NONBLOCK it falls into a infinite loop of

[Intel-gfx] [PATCH] drm/i915: Organize Fence registers for future enablement.

2014-12-04 Thread Rodrigo Vivi
Let's be optimistic that for future platforms this will remain the same and reorg a bit. This reorg in if blocks instead of switch make life easier for future platform support addition. v2: Jani pointed out I was missing reg_830 for some gen3 platforms. So let's make this platforms subcases

Re: [Intel-gfx] [PATCH] drm/i915/chv: Enable HDMI Clock recovery for Pipe C

2014-12-04 Thread Clint Taylor
On 12/04/2014 11:08 AM, Clint Taylor wrote: On 12/04/2014 12:41 AM, Jani Nikula wrote: On Wed, 03 Dec 2014, Clint Taylor clinton.a.tay...@intel.com wrote: On 12/03/2014 01:01 PM, Ville Syrjälä wrote: On Wed, Dec 03, 2014 at 10:10:30AM -0800, clinton.a.tay...@intel.com wrote: From: Clint

Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: Add WaHdcDisableFetchWhenMasked

2014-12-04 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV 364/364

Re: [Intel-gfx] [PATCH 2/2] present: Fix use of vsynced pageflips and honor PresentOptionAsync. (v3)

2014-12-04 Thread Eric Anholt
Mario Kleiner mario.kleiner...@gmail.com writes: Pageflips for Pixmap presents were not synchronized to vblank on drivers with support for PresentCapabilityAsync, due to some missing init for vblank-sync_flips. The PresentOptionAsync flag was completely ignored for pageflipped presents.

Re: [Intel-gfx] [RFC 2/7] drm: allow drm_wait_vblank_kernel() callback from workqueues

2014-12-04 Thread Matt Roper
On Wed, Nov 19, 2014 at 05:47:10PM -0200, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com This is going to be needed by i915.ko, and I guess other drivers could use it too. You may want to explain what we plan to use this for in i915 so that other driver developers will more

[Intel-gfx] [PATCH -next] drm/i915: Fix missing unlock on error in i915_gem_init_hw()

2014-12-04 Thread weiyj_lk
From: Wei Yongjun yongjun_...@trendmicro.com.cn Add the missing unlock before return from function i915_gem_init_hw() in the error handling case. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/gpu/drm/i915/i915_gem.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [Intel-gfx] [PATCH] drm/i915/chv: Add additional workarounds for CHV

2014-12-04 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV 364/364

Re: [Intel-gfx] [RFC 3/7] drm: introduce struct drm_vblank_wait_item

2014-12-04 Thread Matt Roper
On Wed, Nov 19, 2014 at 05:47:11PM -0200, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com It's supposed to contain all the information that is required for both kernel and user space vblank wait items, but not hold any information required by just one of them. For now, we

Re: [Intel-gfx] [RFC 6/7] drm: make vblank_event_list handle drm_vblank_wait_item types

2014-12-04 Thread Matt Roper
On Wed, Nov 19, 2014 at 05:47:14PM -0200, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com Which means the list doesn't really need to know if the event is from user space or kernel space. The only place here where we have to break the abstraction is at drm_fops, when we're

Re: [Intel-gfx] [PATCH] drm/i915: vlv: clamp minimum RPS frequency to what Punit allows

2014-12-04 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV 364/364

Re: [Intel-gfx] [PATCH 10/10] drm/i915: Update the DSI enable path to support dual link panel enabling

2014-12-04 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV 364/364

Re: [Intel-gfx] [PATCH] drm/i915: Organize Fence registers for future enablement.

2014-12-04 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV 364/364