Re: [Intel-gfx] [PATCH 10/10] drm/i915: Make all plane disables use 'update_plane' (v5)

2014-12-05 Thread Ander Conselvan de Oliveira
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com On 12/04/2014 08:27 PM, Matt Roper wrote: If we extend the commit_plane handlers for each plane type to be able to handle fb=0, then we can easily implement plane disable via the update_plane handler. The cursor

Re: [Intel-gfx] [PATCH 2/2] present: Fix use of vsynced pageflips and honor PresentOptionAsync. (v3)

2014-12-05 Thread Mario Kleiner
On 12/05/2014 12:56 AM, Eric Anholt wrote: Mario Kleiner mario.kleiner...@gmail.com writes: Pageflips for Pixmap presents were not synchronized to vblank on drivers with support for PresentCapabilityAsync, due to some missing init for vblank-sync_flips. The PresentOptionAsync flag was

Re: [Intel-gfx] [PATCH] drm/i915/chv: Enable HDMI Clock recovery for Pipe C

2014-12-05 Thread Jani Nikula
On Fri, 05 Dec 2014, Clint Taylor clinton.a.tay...@intel.com wrote: On 12/04/2014 11:08 AM, Clint Taylor wrote: On 12/04/2014 12:41 AM, Jani Nikula wrote: On Wed, 03 Dec 2014, Clint Taylor clinton.a.tay...@intel.com wrote: On 12/03/2014 01:01 PM, Ville Syrjälä wrote: On Wed, Dec 03, 2014 at

[Intel-gfx] [PATCH v4 03/10] drm/i915: Add support for port enable/disable for dual link configuration

2014-12-05 Thread Gaurav K Singh
For Dual Link MIPI Panels, both Port A and Port C should be enabled during the MIPI encoder enabling sequence. Similarly, during the disabling sequence, both ports needs to be disabled. v2: Used for_each_dsi_port macro instead of for loop v3: Used intel_dsi-ports instead of dual_link var for

Re: [Intel-gfx] [PATCH] drm: Make drm_read() more robust against multithreaded races

2014-12-05 Thread Takashi Iwai
At Thu, 4 Dec 2014 21:03:25 +, Chris Wilson wrote: The current implementation of drm_read() faces a number of issues: 1. Upon an error, it consumes the event which may lead to the client blocking. 2. Upon an error, it forgets about events already copied 3. If it fails to copy a

Re: [Intel-gfx] [PATCH] drm: Make drm_read() more robust against multithreaded races

2014-12-05 Thread Daniel Vetter
On Thu, Dec 04, 2014 at 09:03:25PM +, Chris Wilson wrote: The current implementation of drm_read() faces a number of issues: 1. Upon an error, it consumes the event which may lead to the client blocking. 2. Upon an error, it forgets about events already copied 3. If it fails to copy a

[Intel-gfx] [PATCH v2 07/10] drm/i915: cck reg used for checking DSI Pll locked

2014-12-05 Thread Gaurav K Singh
Instead of pipe configuration reg, cck reg to be used for checking whether DSI Pll is getting locked or not. v2: dpio_lock unlocked now in case DSI PLL lock fails Signed-off-by: Gaurav K Singh gaurav.k.si...@intel.com Signed-off-by: Shobhit Kumar shobhit.ku...@intel.com ---

Re: [Intel-gfx] [ANNOUNCE][RFC] KVMGT - the implementation of Intel GVT-g(full GPU virtualization) for KVM

2014-12-05 Thread Gerd Hoffmann
Hi, In KVMGT, we need to register an iodev only *after* BAR registers are written by guest. Oh, the guest can write the bar register at any time. Typically it happens at boot only, but it can also happen at runtime, for example on reboot. I've also seen the

[Intel-gfx] [PATCH v4 09/10] drm/i915: Update the DSI disable path to support dual link panel disabling

2014-12-05 Thread Gaurav K Singh
We need to program both port registers during dual link disable path. v2: Address review comments by Jani - Used a for loop instead of do-while loop. v3: Used for_each_dsi_port macro instead of for loop v4: Added comments for the usage of AFE latchout bit Signed-off-by: Gaurav K Singh

[Intel-gfx] [PATCH v4 10/10] drm/i915: Update the DSI enable path to support dual

2014-12-05 Thread Gaurav K Singh
We need to program both port registers during dual link enable path. v2: Address review comments by Jani - Used a for loop instead of do-while loop. v3: Used for_each_dsi_port macro instead of for loop v4: Renamed mode_hactive variable to mode_hdisplay Signed-off-by: Gaurav K Singh

Re: [Intel-gfx] [PATCH] drm/i915: compute wait_ioctl timeout correctly

2014-12-05 Thread Daniel Vetter
On Thu, Dec 04, 2014 at 12:35:44PM -0800, John Stultz wrote: On Thu, Dec 4, 2014 at 10:51 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote: On Thu, Dec 4, 2014 at 7:16 PM, John Stultz john.stu...@linaro.org wrote: On Thu, Dec 4, 2014 at 9:50 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote:

Re: [Intel-gfx] [PATCH] drm/i915: don't always do full mode sets when infoframes are enabled

2014-12-05 Thread Daniel Vetter
On Thu, Dec 04, 2014 at 12:59:07PM -0800, Jesse Barnes wrote: On Mon, 1 Dec 2014 09:54:28 -0800 Jesse Barnes jbar...@virtuousgeek.org wrote: Partial revert of commit 206645910b9796bff13fcdb67bdca166b724ba62 Author: Jesse Barnes jbar...@virtuousgeek.org Date: Wed Nov 5 14:26:09

Re: [Intel-gfx] [PATCH] drm/i915/chv: Enable HDMI Clock recovery for Pipe C

2014-12-05 Thread Imre Deak
On Fri, 2014-12-05 at 10:37 +0200, Jani Nikula wrote: On Fri, 05 Dec 2014, Clint Taylor clinton.a.tay...@intel.com wrote: On 12/04/2014 11:08 AM, Clint Taylor wrote: On 12/04/2014 12:41 AM, Jani Nikula wrote: On Wed, 03 Dec 2014, Clint Taylor clinton.a.tay...@intel.com wrote: On

Re: [Intel-gfx] [PATCH -next] drm/i915: Fix missing unlock on error in i915_gem_init_hw()

2014-12-05 Thread Jeremiah Mahler
Wei Yongjun, On Fri, Dec 05, 2014 at 08:55:59AM +0800, weiyj...@163.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Add the missing unlock before return from function i915_gem_init_hw() in the error handling case. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn ---

Re: [Intel-gfx] [Xen-devel] [Announcement] 2014-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2014-12-05 Thread Fabio Fantoni
Il 04/12/2014 03:45, Jike Song ha scritto: Hi all, We're pleased to announce a public release to Intel Graphics Virtualization Technology (Intel GVT-g, formerly known as XenGT). Intel GVT-g is a complete vGPU solution with mediated pass-through, supported today on 4th generation Intel

Re: [Intel-gfx] [PATCH] drm/i915/chv: Enable HDMI Clock recovery for Pipe C

2014-12-05 Thread Jani Nikula
On Fri, 05 Dec 2014, Imre Deak imre.d...@intel.com wrote: On Fri, 2014-12-05 at 10:37 +0200, Jani Nikula wrote: On Fri, 05 Dec 2014, Clint Taylor clinton.a.tay...@intel.com wrote: On 12/04/2014 11:08 AM, Clint Taylor wrote: On 12/04/2014 12:41 AM, Jani Nikula wrote: On Wed, 03 Dec 2014,

[Intel-gfx] [PATCH 1/2] drm/i915: Infrastructure for supporting different GGTT views per object

2014-12-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin tvrtko.ursu...@intel.com Things like reliable GGTT mappings and mirrored 2d-on-3d display will need to map objects into the same address space multiple times. Added a GGTT view concept and linked it with the VMA to distinguish between multiple instances per address space.

[Intel-gfx] [PATCH v2 0/2] Multiple GGTT views

2014-12-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin tvrtko.ursu...@intel.com This series continues what was previously a single patch called drm/i915: Infrastructure for supporting different GGTT views per object. v2: * One less patch due early prep work getting merged. * Main patch reworked to keep the pages pointer around

[Intel-gfx] [PATCH 2/2] drm/i915: Documentation for multiple GGTT views

2014-12-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin tvrtko.ursu...@intel.com A short section describing background, implementation and intended usage. For: VIZ-4544 Signed-off-by: Tvrtko Ursulin tvrtko.ursu...@intel.com --- Documentation/DocBook/drm.tmpl | 5 drivers/gpu/drm/i915/i915_gem_gtt.c | 60

Re: [Intel-gfx] drm/i915: Fix missing unlock on error in i915_gem_init_hw()

2014-12-05 Thread Jani Nikula
On Fri, 05 Dec 2014, Jeremiah Mahler jmmah...@gmail.com wrote: There are other places in i915_gem_init_hw() where it returns without unlocking the mutex. Why is it only necessary here and not any of the other places? There's probably some rebase/merge confusion going on. The following patch

Re: [Intel-gfx] drm/i915: Fix missing unlock on error in i915_gem_init_hw()

2014-12-05 Thread Jani Nikula
On Fri, 05 Dec 2014, Jeremiah Mahler jmmah...@gmail.com wrote: There are other places in i915_gem_init_hw() where it returns without unlocking the mutex. Why is it only necessary here and not any of the other places? There's probably some rebase/merge confusion going on. The following patch

[Intel-gfx] [PATCH] drm/i915: release struct_mutex on the i915_gem_init_hw fail path

2014-12-05 Thread Jani Nikula
Release struct_mutex if init_rings() fails. This is a regression introduced in commit 35a57ffbb10840af219eeaf64718434242bb7c76 Author: Daniel Vetter daniel.vet...@ffwll.ch Date: Thu Nov 20 00:33:07 2014 +0100 drm/i915: Only init engines once Reported-by: Wei Yongjun

Re: [Intel-gfx] [PATCH 02/10] drm/i915: Added port as parameter to the functions which does read/write of DSI Controller

2014-12-05 Thread Singh, Gaurav K
On 12/4/2014 4:52 PM, Daniel Vetter wrote: On Thu, Dec 04, 2014 at 11:14:01AM +0200, Jani Nikula wrote: On Thu, 04 Dec 2014, Gaurav K Singh gaurav.k.si...@intel.com wrote: This patch is in preparation of DSI dual link panels. For dual link panels, few packets needs to be sent to Port A or

Re: [Intel-gfx] [PATCH] drm/i915: s/MI_STORE_DWORD_IMM_GEN8/MI_STORE_DWORD_IMM_GEN4/

2014-12-05 Thread Ville Syrjälä
On Fri, Nov 14, 2014 at 06:16:56PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com MI_STORE_DWORD_IMM length has been the same ever since gen4. Rename the define to avoid potential confusion if someone tries to use this on pre-gen8. Also

Re: [Intel-gfx] [PATCH v4 03/10] drm/i915: Add support for port enable/disable for dual link configuration

2014-12-05 Thread Jani Nikula
On Fri, 05 Dec 2014, Gaurav K Singh gaurav.k.si...@intel.com wrote: For Dual Link MIPI Panels, both Port A and Port C should be enabled during the MIPI encoder enabling sequence. Similarly, during the disabling sequence, both ports needs to be disabled. v2: Used for_each_dsi_port macro

Re: [Intel-gfx] [PATCH] drm/i915: release struct_mutex on the i915_gem_init_hw fail path

2014-12-05 Thread Jeremiah Mahler
Jani, On Fri, Dec 05, 2014 at 02:17:42PM +0200, Jani Nikula wrote: Release struct_mutex if init_rings() fails. This is a regression introduced in commit 35a57ffbb10840af219eeaf64718434242bb7c76 Author: Daniel Vetter daniel.vet...@ffwll.ch Date: Thu Nov 20 00:33:07 2014 +0100

Re: [Intel-gfx] [ANNOUNCE][RFC] KVMGT - the implementation of Intel GVT-g(full GPU virtualization) for KVM

2014-12-05 Thread Paolo Bonzini
On 05/12/2014 09:50, Gerd Hoffmann wrote: A few comments on the kernel stuff (brief look so far, also compile-tested only, intel gfx on my test machine is too old). * Noticed the kernel bits don't even compile when configured as module. Everything (vgt, i915, kvm) must be compiled

Re: [Intel-gfx] [RFC PATCH] drm/i915: avoid round-trip scaling errors in actual_brightness

2014-12-05 Thread Jani Nikula
On Tue, 02 Dec 2014, Eoff, Ullysses A ullysses.a.e...@intel.com wrote: bump Talked about this with Daniel a while back, his take was, preemptively catering to bonghits userspace means we'll have less wiggle-room in the future BR, Jani. -Original Message- From: Intel-gfx

[Intel-gfx] [PATCH] igt/drm_read: Abuse read(drm)

2014-12-05 Thread Chris Wilson
Check that the more obvious userspace error conditions are handled by the kernel, ideally without loss of data. These include nonblocking waits, passing invalid buffers and passing buffers of the incorrect length. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- tests/.gitignore |

Re: [Intel-gfx] [PATCH -next] drm/i915: Fix missing unlock on error in i915_gem_init_hw()

2014-12-05 Thread Daniel Vetter
On Fri, Dec 05, 2014 at 08:55:59AM +0800, weiyj...@163.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Add the missing unlock before return from function i915_gem_init_hw() in the error handling case. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn Applied, thanks for

Re: [Intel-gfx] [PATCH] drm/i915/chv: Enable HDMI Clock recovery for Pipe C

2014-12-05 Thread Imre Deak
On Fri, 2014-12-05 at 13:57 +0200, Jani Nikula wrote: On Fri, 05 Dec 2014, Imre Deak imre.d...@intel.com wrote: On Fri, 2014-12-05 at 10:37 +0200, Jani Nikula wrote: On Fri, 05 Dec 2014, Clint Taylor clinton.a.tay...@intel.com wrote: On 12/04/2014 11:08 AM, Clint Taylor wrote: On

[Intel-gfx] [PATCH] drm/i915: allow requesting the audio power well for all platforms

2014-12-05 Thread Imre Deak
So far we only allowed HSW and BDW to request for the audio power domain, but it is also needed at least on VLV/CHV. There is no need for this restriction, since the power domain-power well mapping should take care of the distinctions between platforms. Spotted-by: Jani Nikula

[Intel-gfx] [PATCH] tests/gem_userptr_blits: add test to check blit aligns

2014-12-05 Thread Mika Kuoppala
Copy a block into a destination object with varying base offset into the destination and source. Put guard area before and after the blit target to see that it didn't touch memory out of blit boundaries. References: https://bugs.freedesktop.org/show_bug.cgi?id=79053 Cc: Chris Wilson

Re: [Intel-gfx] [PATCH] tests/gem_userptr_blits: add test to check blit aligns

2014-12-05 Thread Chris Wilson
On Fri, Dec 05, 2014 at 03:32:30PM +0200, Mika Kuoppala wrote: Copy a block into a destination object with varying base offset into the destination and source. Put guard area before and after the blit target to see that it didn't touch memory out of blit boundaries. This doesn't belong in

[Intel-gfx] [PATCH v4 1/4] drm/i915: Fix up seqno - request merge issues

2014-12-05 Thread John . C . Harrison
From: John Harrison john.c.harri...@intel.com The display related patches earlier in this series were edited during merge to improve the request unreferencing. Specifically, the need for de-referencing at interrupt time was removed. However, the resulting code did a 'deref(req) ; req = NULL'

[Intel-gfx] [PATCH v4 2/4] drm/i915: Zero fill the request structure

2014-12-05 Thread John . C . Harrison
From: John Harrison john.c.harri...@intel.com There is a general theory that kzmalloc is better/safer than kmalloc, especially for interesting data structures. This change updates the request structure allocation to be zero filled. Change-Id: I68715ef758025fab8db763941ef63bf60d7031e2 For:

[Intel-gfx] [PATCH v4 0/4] Replace seqno values with request structures

2014-12-05 Thread John . C . Harrison
From: John Harrison john.c.harri...@intel.com There is a general feeling that it is better to move away from using a simple integer 'seqno' value to track batch buffer completion. Instead, the request structure should be used. That provides for much more flexibility going forwards. Especially

[Intel-gfx] [PATCH v4 3/4] drm/i915: Add unique id to the request structure for debugging

2014-12-05 Thread John . C . Harrison
From: John Harrison john.c.harri...@intel.com For debugging purposes, it is useful to be able to uniquely identify a given request structure as it works its way through the system. This becomes especially tricky once the seqno value is lazily allocated as then the request has nothing but its

[Intel-gfx] [PATCH v4 4/4] drm/i915: Additional request structure tracing

2014-12-05 Thread John . C . Harrison
From: John Harrison john.c.harri...@intel.com Added the request structure's 'uniq' identifier to the trace information. Also renamed the '_complete' trace event to '_notify' as it actually happens in the IRQ 'notify_ring()' function. The intention is to add a new '_complete' trace event which

Re: [Intel-gfx] [ANNOUNCE][RFC] KVMGT - the implementation of Intel GVT-g(full GPU virtualization) for KVM

2014-12-05 Thread Daniel Vetter
On Fri, Dec 05, 2014 at 09:50:21AM +0100, Gerd Hoffmann wrote: https://www.usenix.org/conference/atc14/technical-sessions/presentation/tian /me goes read this. A few comments on the kernel stuff (brief look so far, also compile-tested only, intel gfx on my test machine is too old).

Re: [Intel-gfx] [PATCH] drm/i915: allow requesting the audio power well for all platforms

2014-12-05 Thread Imre Deak
On Fri, 2014-12-05 at 15:28 +0200, Imre Deak wrote: So far we only allowed HSW and BDW to request for the audio power domain, but it is also needed at least on VLV/CHV. There is no need for this restriction, since the power domain-power well mapping should take care of the distinctions between

Re: [Intel-gfx] [PATCH] drm/i915: release struct_mutex on the i915_gem_init_hw fail path

2014-12-05 Thread Daniel Vetter
On Fri, Dec 05, 2014 at 05:03:14AM -0800, Jeremiah Mahler wrote: Jani, On Fri, Dec 05, 2014 at 02:17:42PM +0200, Jani Nikula wrote: Release struct_mutex if init_rings() fails. This is a regression introduced in commit 35a57ffbb10840af219eeaf64718434242bb7c76 Author: Daniel Vetter

[Intel-gfx] [PATCH 2/2] drm/i915: Reorder hw init to avoid executing with invalid context/mm state

2014-12-05 Thread Chris Wilson
Currently we initialise the rings, add the first context switch to the ring and execute our golden state then enable (aliasing or full) ppgtt. However, as we enable ppgtt using direct MMIO but load the PD using MI_LRI, we end up executing the context switch and golden render state with an invalid

[Intel-gfx] [PATCH 1/2] drm/i915: Detect page faults during hangcheck

2014-12-05 Thread Chris Wilson
On Sandybridge+, the GPU provides the ERROR register for detecting page faults. Hook this up to our hangcheck so that we can dump the error state soon after such an event occurs. This would be better inside an interrupt handler, but it serves a purpose here as it detects that our initial context

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Infrastructure for supporting different GGTT views per object

2014-12-05 Thread Daniel Vetter
On Fri, Dec 05, 2014 at 12:11:45PM +, Tvrtko Ursulin wrote: +struct i915_ggtt_view { + enum i915_ggtt_view_type type; + + struct sg_table *pages; +}; Minor nit on semantics, not really worth a resend (except when you need one anyway because of the detailed review): Imo the

Re: [Intel-gfx] [PATCH] drm/i915/chv: Enable HDMI Clock recovery for Pipe C

2014-12-05 Thread Daniel Vetter
On Fri, Dec 05, 2014 at 03:23:59PM +0200, Imre Deak wrote: Hm, right I should have checked that first. And it could be also the reason why AZX_DCAPS_I915_POWERWELL was left out for everything but HSW/BDW. I will send a patch to fix that in i915. Not terribly in favour of perpetuing that hack.

[Intel-gfx] [PATCH v2 3/3] tests/pm_rps: vlv: round middle point to freq supported by HW

2014-12-05 Thread Imre Deak
When setting the calculated middle frequency value the test assumes that the HW/kernel rounds this value according to a 50MHz step value. This is not so at least on VLV/CHV, on my B0 BYT-M for example this step value is 22MHz, so there the test will fail. To fix this get the nearest supported

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Reorder hw init to avoid executing with invalid context/mm state

2014-12-05 Thread Ville Syrjälä
On Fri, Dec 05, 2014 at 02:15:22PM +, Chris Wilson wrote: Currently we initialise the rings, add the first context switch to the ring and execute our golden state then enable (aliasing or full) ppgtt. However, as we enable ppgtt using direct MMIO but load the PD using MI_LRI, we end up

Re: [Intel-gfx] [PATCH 02/10] drm/i915: Added port as parameter to the functions which does read/write of DSI Controller

2014-12-05 Thread Daniel Vetter
On Fri, Dec 05, 2014 at 06:20:43PM +0530, Singh, Gaurav K wrote: On 12/4/2014 4:52 PM, Daniel Vetter wrote: On Thu, Dec 04, 2014 at 11:14:01AM +0200, Jani Nikula wrote: On Thu, 04 Dec 2014, Gaurav K Singh gaurav.k.si...@intel.com wrote: This patch is in preparation of DSI dual link panels.

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Reorder hw init to avoid executing with invalid context/mm state

2014-12-05 Thread Chris Wilson
On Fri, Dec 05, 2014 at 04:31:35PM +0200, Ville Syrjälä wrote: On Fri, Dec 05, 2014 at 02:15:22PM +, Chris Wilson wrote: Currently we initialise the rings, add the first context switch to the ring and execute our golden state then enable (aliasing or full) ppgtt. However, as we enable

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Add WaHdcDisableFetchWhenMasked

2014-12-05 Thread Daniel Vetter
On Thu, Dec 04, 2014 at 05:25:56PM +0200, Ville Syrjälä wrote: On Thu, Dec 04, 2014 at 03:07:52PM +, Michel Thierry wrote: We already have it for chv, but was missing for bdw. Signed-off-by: Michel Thierry michel.thie...@intel.com --- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 ++

Re: [Intel-gfx] [PATCH] igt/drm_read: Abuse read(drm)

2014-12-05 Thread Daniel Vetter
On Fri, Dec 05, 2014 at 01:14:40PM +, Chris Wilson wrote: +static void assert_empty(int fd) +{ + struct pollfd pfd = {fd, POLLIN }; + igt_assert(poll(pfd, 1, 0) == 0); +} + +static void generate_event(int fd) +{ + union drm_wait_vblank vbl; + + /* We assume that pipe

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Reorder hw init to avoid executing with invalid context/mm state

2014-12-05 Thread Ville Syrjälä
On Fri, Dec 05, 2014 at 02:38:46PM +, Chris Wilson wrote: On Fri, Dec 05, 2014 at 04:31:35PM +0200, Ville Syrjälä wrote: On Fri, Dec 05, 2014 at 02:15:22PM +, Chris Wilson wrote: Currently we initialise the rings, add the first context switch to the ring and execute our golden

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Reorder hw init to avoid executing with invalid context/mm state

2014-12-05 Thread Daniel Vetter
On Fri, Dec 05, 2014 at 02:38:46PM +, Chris Wilson wrote: On Fri, Dec 05, 2014 at 04:31:35PM +0200, Ville Syrjälä wrote: On Fri, Dec 05, 2014 at 02:15:22PM +, Chris Wilson wrote: Currently we initialise the rings, add the first context switch to the ring and execute our golden

[Intel-gfx] Updated drm-intel-testing

2014-12-05 Thread Daniel Vetter
Hi all, New -testing cycle with cool stuff, first round for 3.20 - hah no typo this time around in the version ;-) - dual-dsi enabling from Gaurav with prep work from Jani - reshuffling the ring init code to move towards a clean sw/hw state setup split - ring free space refactoring from Dave

[Intel-gfx] [PATCH i-g-t 1/3] lib: Add swap() macro

2014-12-05 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com swap() will swap its two arguments while keeping the required tmp variable hidden. Makes for neater code. Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com --- lib/igt_aux.h | 6 ++ 1 file changed, 6 insertions(+) diff --git

[Intel-gfx] [PATCH i-g-t 2/3] lib/igt.cocci: Deal with min/max/swap

2014-12-05 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com Replace open coded min/max/swap with the macro invocation. Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com --- lib/igt.cocci | 36 1 file changed, 36 insertions(+) diff --git a/lib/igt.cocci

[Intel-gfx] [PATCH i-g-t 3/3] tests: Run lib/igt.cocci

2014-12-05 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com Found some open coded min()/max()/swap() macros. Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com --- tests/drv_hangman.c | 4 ++-- tests/eviction_common.c | 5 + tests/gem_seqno_wrap.c | 5 + tests/gem_stress.c |

[Intel-gfx] [PATCH i-g-t 1/4] tests/kms_flip: Refactor blit code

2014-12-05 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com Pull the code to emit a single blit to a separate function. Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com --- tests/kms_flip.c | 47 --- 1 file changed, 28 insertions(+), 19 deletions(-)

[Intel-gfx] [PATCH i-g-t 2/4] tests/kms_flip: Use fixed size (2kx2k) buffers for dummy load

2014-12-05 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com Make the dummy load independent of the display resolution by using a two fixed size dummy bos to generate the load. As a final step do another copy from one of the dummy bos to the fb to make sure there's a dependency between the dummy load and

[Intel-gfx] [PATCH i-g-t 4/4] tests/kms_flip: Target the back buffer with the dummy load

2014-12-05 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com Aim the dummy load to the current back buffer instead if the front buffer. Assuming the idea is to get the next flip to be stuck behind the dummy load? Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com --- tests/kms_flip.c | 6 +++--- 1

[Intel-gfx] [PATCH i-g-t 3/4] tests/kms_flip: Calibrate the dummy load delay in kms_flip

2014-12-05 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com Try to tune the dummy load to ~1 second. The calibration happens the first time dummy load is generated. Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com --- tests/kms_flip.c | 81

[Intel-gfx] [PATCH i-g-t v2 3/4] tests/kms_flip: Calibrate the dummy load delay in kms_flip

2014-12-05 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com Try to tune the dummy load to ~1 second. The calibration happens the first time dummy load is generated. v2: Actually do the number of ops intended and calibrate to 1 second and not 2 Signed-off-by: Ville Syrjälä

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Reorder hw init to avoid executing with invalid context/mm state

2014-12-05 Thread Chris Wilson
On Fri, Dec 05, 2014 at 03:58:40PM +0100, Daniel Vetter wrote: On Fri, Dec 05, 2014 at 02:38:46PM +, Chris Wilson wrote: On Fri, Dec 05, 2014 at 04:31:35PM +0200, Ville Syrjälä wrote: On Fri, Dec 05, 2014 at 02:15:22PM +, Chris Wilson wrote: Currently we initialise the rings, add

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Reorder hw init to avoid executing with invalid context/mm state

2014-12-05 Thread Chris Wilson
On Fri, Dec 05, 2014 at 04:53:49PM +0200, Ville Syrjälä wrote: On Fri, Dec 05, 2014 at 02:38:46PM +, Chris Wilson wrote: On Fri, Dec 05, 2014 at 04:31:35PM +0200, Ville Syrjälä wrote: On Fri, Dec 05, 2014 at 02:15:22PM +, Chris Wilson wrote: Currently we initialise the rings, add

Re: [Intel-gfx] [PATCH] igt/drm_read: Abuse read(drm)

2014-12-05 Thread Chris Wilson
On Fri, Dec 05, 2014 at 03:46:54PM +0100, Daniel Vetter wrote: On Fri, Dec 05, 2014 at 01:14:40PM +, Chris Wilson wrote: +static void assert_empty(int fd) +{ + struct pollfd pfd = {fd, POLLIN }; + igt_assert(poll(pfd, 1, 0) == 0); +} + +static void generate_event(int fd)

Re: [Intel-gfx] [PATCH i-g-t 1/3] lib: Add swap() macro

2014-12-05 Thread Jani Nikula
On Fri, 05 Dec 2014, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com swap() will swap its two arguments while keeping the required tmp variable hidden. Makes for neater code. Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com ---

Re: [Intel-gfx] [PATCH 04/10] drm/i915: Pixel Clock changes for DSI dual link

2014-12-05 Thread Siluvery, Arun
On 05/12/2014 16:33, Singh, Gaurav K wrote: On 12/4/2014 2:57 PM, Jani Nikula wrote: On Thu, 04 Dec 2014, Gaurav K Singh gaurav.k.si...@intel.com wrote: For dual link MIPI Panels, each port needs half of pixel clock. Pixel overlap can be enabled if needed by panel, then in that case, pixel

Re: [Intel-gfx] [PATCH 04/10] drm/i915: Pixel Clock changes for DSI dual link

2014-12-05 Thread Singh, Gaurav K
On 12/4/2014 2:57 PM, Jani Nikula wrote: On Thu, 04 Dec 2014, Gaurav K Singh gaurav.k.si...@intel.com wrote: For dual link MIPI Panels, each port needs half of pixel clock. Pixel overlap can be enabled if needed by panel, then in that case, pixel clock will be increased for extra pixels. v2 :

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Reorder hw init to avoid executing with invalid context/mm state

2014-12-05 Thread Ville Syrjälä
On Fri, Dec 05, 2014 at 04:26:23PM +, Chris Wilson wrote: On Fri, Dec 05, 2014 at 04:53:49PM +0200, Ville Syrjälä wrote: On Fri, Dec 05, 2014 at 02:38:46PM +, Chris Wilson wrote: On Fri, Dec 05, 2014 at 04:31:35PM +0200, Ville Syrjälä wrote: On Fri, Dec 05, 2014 at 02:15:22PM

Re: [Intel-gfx] [PATCH i-g-t 1/3] lib: Add swap() macro

2014-12-05 Thread Ville Syrjälä
On Fri, Dec 05, 2014 at 06:44:19PM +0200, Jani Nikula wrote: On Fri, 05 Dec 2014, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com swap() will swap its two arguments while keeping the required tmp variable hidden. Makes for neater code.

Re: [Intel-gfx] [PATCH] drm/i915: allow requesting the audio power well for all platforms

2014-12-05 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV 364/364

Re: [Intel-gfx] [PATCH 04/10] drm/i915: Pixel Clock changes for DSI dual link

2014-12-05 Thread Singh, Gaurav K
On 12/5/2014 10:24 PM, Siluvery, Arun wrote: On 05/12/2014 16:33, Singh, Gaurav K wrote: On 12/4/2014 2:57 PM, Jani Nikula wrote: On Thu, 04 Dec 2014, Gaurav K Singh gaurav.k.si...@intel.com wrote: For dual link MIPI Panels, each port needs half of pixel clock. Pixel overlap can be enabled

Re: [Intel-gfx] [PATCH 04/10] drm/i915: Pixel Clock changes for DSI dual link

2014-12-05 Thread Jani Nikula
On Fri, 05 Dec 2014, Siluvery, Arun arun.siluv...@linux.intel.com wrote: On 05/12/2014 16:33, Singh, Gaurav K wrote: On 12/4/2014 2:57 PM, Jani Nikula wrote: On Thu, 04 Dec 2014, Gaurav K Singh gaurav.k.si...@intel.com wrote: For dual link MIPI Panels, each port needs half of pixel clock.

Re: [Intel-gfx] [PATCH i-g-t 1/3] lib: Add swap() macro

2014-12-05 Thread Jani Nikula
On Fri, 05 Dec 2014, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Fri, Dec 05, 2014 at 06:44:19PM +0200, Jani Nikula wrote: On Fri, 05 Dec 2014, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com swap() will swap its two arguments while keeping

Re: [Intel-gfx] [PATCH 04/10] drm/i915: Pixel Clock changes for DSI dual link

2014-12-05 Thread Siluvery, Arun
On 05/12/2014 17:36, Jani Nikula wrote: On Fri, 05 Dec 2014, Siluvery, Arun arun.siluv...@linux.intel.com wrote: On 05/12/2014 16:33, Singh, Gaurav K wrote: On 12/4/2014 2:57 PM, Jani Nikula wrote: On Thu, 04 Dec 2014, Gaurav K Singh gaurav.k.si...@intel.com wrote: For dual link MIPI

[Intel-gfx] [PATCH] drm/i915: Clean the request structure on alloc

2014-12-05 Thread Mika Kuoppala
Otherwise we might end up referencing uninitialized fields. This is apparent when we try to cleanup the preallocated request on ring reset, before any request has been submitted to the ring. The request-ctx is foobar and we end up freeing the foobarness. References:

Re: [Intel-gfx] [PATCH] drm/i915: Clean the request structure on alloc

2014-12-05 Thread John Harrison
This is already part of the seqno/request patch series and has been right from the start. See email 'drm/i915: Zero fill the request structure'. On 05/12/2014 17:54, Mika Kuoppala wrote: Otherwise we might end up referencing uninitialized fields. This is apparent when we try to cleanup the

Re: [Intel-gfx] [PATCH] drm/i915: Clean the request structure on alloc

2014-12-05 Thread John Harrison
But yes, the reasoning why it crashes without the zero fill is correct. Dodgy context pointers that used to be ignored now get processed. Doing the zero fill keeps it all sane. On 05/12/2014 17:54, John Harrison wrote: This is already part of the seqno/request patch series and has been right

Re: [Intel-gfx] [PATCH] drm/i915: Clean the request structure on alloc

2014-12-05 Thread Mika Kuoppala
John Harrison john.c.harri...@intel.com writes: This is already part of the seqno/request patch series and has been right from the start. See email 'drm/i915: Zero fill the request structure'. Indeed. Sorry for missing this one. My patch can be ignored. But do you agree on failure path?

Re: [Intel-gfx] [PATCH] drm/i915: Don't complain about stolen conflicts on gen3

2014-12-05 Thread Jesse Barnes
On Fri, 11 Apr 2014 15:55:17 +0200 Daniel Vetter daniel.vet...@ffwll.ch wrote: Apparently stuff works that way on those machines. I agree with Chris' concern that this is a bit risky but imo worth a shot in -next just for fun. Afaics all these machines have the pci resources allocated like

Re: [Intel-gfx] [PATCH v4 4/4] drm/i915: Additional request structure tracing

2014-12-05 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV 364/364

[Intel-gfx] [PATCH 5/5] drm/i915: Dual link needs Shutdown and Turn on packet for both ports

2014-12-05 Thread Gaurav K Singh
For dual link MIPI panels, SHUTDOWN packet needs to send to both Ports A C during MIPI encoder disabling sequence. Similarly, TURN ON packet to be sent to both Ports during MIPI encoder enabling sequence. v2: Address review comments by Jani - Used a for loop instead of do-while loop. v3:

Re: [Intel-gfx] [PATCH 10/10] drm/i915: Make all plane disables use 'update_plane' (v5)

2014-12-05 Thread Daniel Vetter
On Fri, Dec 05, 2014 at 10:15:07AM +0200, Ander Conselvan de Oliveira wrote: Reviewed-by: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com On 12/04/2014 08:27 PM, Matt Roper wrote: If we extend the commit_plane handlers for each plane type to be able to handle fb=0, then

[Intel-gfx] [PATCH 10/10] drm/i915: Update the DSI enable path to support dual

2014-12-05 Thread Gaurav K Singh
We need to program both port registers during dual link enable path. v2: Address review comments by Jani - Used a for loop instead of do-while loop. v3: Used for_each_dsi_port macro instead of for loop v4: Renamed mode_hactive variable to mode_hdisplay Signed-off-by: Gaurav K Singh

Re: [Intel-gfx] [PATCH] drm/i915: Don't complain about stolen conflicts on gen3

2014-12-05 Thread Daniel Vetter
On Fri, Dec 05, 2014 at 10:30:47AM -0800, Jesse Barnes wrote: On Fri, 11 Apr 2014 15:55:17 +0200 Daniel Vetter daniel.vet...@ffwll.ch wrote: Apparently stuff works that way on those machines. I agree with Chris' concern that this is a bit risky but imo worth a shot in -next just for

Re: [Intel-gfx] [PATCH 02/10] drm/i915: Added port as parameter to the functions which does read/write of DSI Controller

2014-12-05 Thread Singh, Gaurav K
On 12/5/2014 8:08 PM, Daniel Vetter wrote: On Fri, Dec 05, 2014 at 06:20:43PM +0530, Singh, Gaurav K wrote: On 12/4/2014 4:52 PM, Daniel Vetter wrote: On Thu, Dec 04, 2014 at 11:14:01AM +0200, Jani Nikula wrote: On Thu, 04 Dec 2014, Gaurav K Singh gaurav.k.si...@intel.com wrote: This patch

Re: [Intel-gfx] [PATCH v4 1/4] drm/i915: Fix up seqno - request merge issues

2014-12-05 Thread Daniel Vetter
On Fri, Dec 05, 2014 at 01:49:33PM +, john.c.harri...@intel.com wrote: From: John Harrison john.c.harri...@intel.com The display related patches earlier in this series were edited during merge to improve the request unreferencing. Specifically, the need for de-referencing at interrupt

Re: [Intel-gfx] [PATCH 04/10] drm/i915: Pixel Clock changes for DSI dual link

2014-12-05 Thread Singh, Gaurav K
On 12/5/2014 11:18 PM, Siluvery, Arun wrote: On 05/12/2014 17:36, Jani Nikula wrote: On Fri, 05 Dec 2014, Siluvery, Arun arun.siluv...@linux.intel.com wrote: On 05/12/2014 16:33, Singh, Gaurav K wrote: On 12/4/2014 2:57 PM, Jani Nikula wrote: On Thu, 04 Dec 2014, Gaurav K Singh

Re: [Intel-gfx] [PATCH] drm/i915: Clean the request structure on alloc

2014-12-05 Thread Daniel Vetter
On Fri, Dec 05, 2014 at 06:02:35PM +, John Harrison wrote: But yes, the reasoning why it crashes without the zero fill is correct. Dodgy context pointers that used to be ignored now get processed. Doing the zero fill keeps it all sane. On 05/12/2014 17:54, John Harrison wrote: This is

Re: [Intel-gfx] [PATCH v4 4/4] drm/i915: Additional request structure tracing

2014-12-05 Thread Daniel Vetter
On Fri, Dec 05, 2014 at 01:49:36PM +, john.c.harri...@intel.com wrote: From: John Harrison john.c.harri...@intel.com Added the request structure's 'uniq' identifier to the trace information. Also renamed the '_complete' trace event to '_notify' as it actually happens in the IRQ

Re: [Intel-gfx] [PATCH v4 4/4] drm/i915: Additional request structure tracing

2014-12-05 Thread Daniel Vetter
On Fri, Dec 05, 2014 at 09:48:03PM +0100, Daniel Vetter wrote: On Fri, Dec 05, 2014 at 01:49:36PM +, john.c.harri...@intel.com wrote: From: John Harrison john.c.harri...@intel.com Added the request structure's 'uniq' identifier to the trace information. Also renamed the

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Dual link needs Shutdown and Turn on packet for both ports

2014-12-05 Thread Daniel Vetter
On Sat, Dec 06, 2014 at 12:40:39AM +0530, Gaurav K Singh wrote: For dual link MIPI panels, SHUTDOWN packet needs to send to both Ports A C during MIPI encoder disabling sequence. Similarly, TURN ON packet to be sent to both Ports during MIPI encoder enabling sequence. v2: Address review

Re: [Intel-gfx] [PATCH 2/3] tests/pm_rps: vlv: load gpu for idle min/max tests

2014-12-05 Thread Daniel Vetter
On Thu, Dec 04, 2014 at 06:09:39PM +0200, Imre Deak wrote: When changing the sysfs GT min/max frequencies, the kernel won't explicitly change the current frequency, unless it becomes out of bound based on the new min/max values. The test happens to work on non-VLV platforms because on those

Re: [Intel-gfx] [PATCH] drm/i915: vlv: clamp minimum RPS frequency to what Punit allows

2014-12-05 Thread Daniel Vetter
On Thu, Dec 04, 2014 at 06:39:35PM +0200, Imre Deak wrote: As described in the code comment, I couldn't set the minimum RPS frequency on my BYT-M B0 to the minimum allowed as reported by Punit. Fix this by clamping the minimum value to the first one that was accepted on my machine. This fixes

Re: [Intel-gfx] [PATCH] drm: Make drm_read() more robust against multithreaded races

2014-12-05 Thread Daniel Vetter
On Thu, Dec 04, 2014 at 06:19:54PM -0800, shuang...@intel.com wrote: Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly

Re: [Intel-gfx] [PATCH 2/3] tests/pm_rps: vlv: load gpu for idle min/max tests

2014-12-05 Thread Chris Wilson
On Fri, Dec 05, 2014 at 09:56:18PM +0100, Daniel Vetter wrote: On Thu, Dec 04, 2014 at 06:09:39PM +0200, Imre Deak wrote: When changing the sysfs GT min/max frequencies, the kernel won't explicitly change the current frequency, unless it becomes out of bound based on the new min/max values.

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Reorder hw init to avoid executing with invalid context/mm state

2014-12-05 Thread Daniel Vetter
On Fri, Dec 05, 2014 at 04:23:56PM +, Chris Wilson wrote: On Fri, Dec 05, 2014 at 03:58:40PM +0100, Daniel Vetter wrote: On Fri, Dec 05, 2014 at 02:38:46PM +, Chris Wilson wrote: On Fri, Dec 05, 2014 at 04:31:35PM +0200, Ville Syrjälä wrote: On Fri, Dec 05, 2014 at 02:15:22PM

Re: [Intel-gfx] [PATCH 2/3] tests/pm_rps: vlv: load gpu for idle min/max tests

2014-12-05 Thread Imre Deak
On Fri, 2014-12-05 at 21:56 +0100, Daniel Vetter wrote: On Thu, Dec 04, 2014 at 06:09:39PM +0200, Imre Deak wrote: When changing the sysfs GT min/max frequencies, the kernel won't explicitly change the current frequency, unless it becomes out of bound based on the new min/max values. The

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Detect page faults during hangcheck

2014-12-05 Thread Daniel Vetter
On Fri, Dec 05, 2014 at 02:15:21PM +, Chris Wilson wrote: On Sandybridge+, the GPU provides the ERROR register for detecting page faults. Hook this up to our hangcheck so that we can dump the error state soon after such an event occurs. This would be better inside an interrupt handler, but

  1   2   >