From: Ville Syrjälä
The logical render context population has a bunch of raw ring register
offsets. Use the names we have for them, and in cases where we we don't,
give them names.
Signed-off-by: Ville Syrjälä
---
From: Ville Syrjälä
We set up a load of LRIs in the logical ring context. Wrap that stuff
in a macro to avoid typos with position of each reg/value pair in the
context. This also makes it easier to make the register defines type
safe.
Signed-off-by: Ville Syrjälä
From: Ville Syrjälä
Add 'uint32_t offset' to the uncore register access functions. For now
it's the same as 'reg', but once type safety gets added 'reg' will be
the type safe register variable and 'offset' the raw offset.
Signed-off-by: Ville Syrjälä
From: Ville Syrjälä
Store the upper dword of the register offset in the whitelist as well.
This would allow it to read register where the two halves aren't sitting
right next to each other, and it'll make it easier to make register
access type safe.
While at it
From: Ville Syrjälä
We'll want to avoid performing arithmetic with register offsets, so
instead calculating the vgpu PDP as pdp0_lo+offset, make the PDPs
into an array. This way we can simply loop through them.
Cc: Eddie Dong
Cc: Jike Song
From: Ville Syrjälä
Cc: Francisco Jerez
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/i915_reg.h | 12 ++--
drivers/gpu/drm/i915/intel_mocs.c | 41 ---
2
From: Ville Syrjälä
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_lrc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
From: Ville Syrjälä
Add a helper for emitting register offsets (for LRI/SRM) into the w/a
batch buffer.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_lrc.c | 10 ++
1 file changed, 6 insertions(+), 4
From: Ville Syrjälä
Use the RING_PSMI_CTL define insted of hand rolling the register offset.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Ville Syrjälä
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/i915_reg.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index
On 11/04/2015 12:26 PM, Zanoni, Paulo R wrote:
> Em Qua, 2015-11-04 às 14:19 -0600, Jason Wessel escreveu:
>> On 11/04/2015 02:13 PM, Jesse Barnes wrote:
>>> On 11/04/2015 11:10 AM, Paulo Zanoni wrote:
From our maintainer Daniel Vetter a few days ago:
"Oh dear this is dead code. kdbg
On Wed, 4 Nov 2015 09:05:27 -0800
Matt Roper wrote:
> BXT CRTC scaling uses the same gen9 codepaths as SKL; these codepaths
> store panel fitter information in pipe_config->pch_pfit. However since
> HAS_PCH_SPLIT() is false for BXT we never actually wind up filling in
On Wed, Nov 04, 2015 at 09:25:32PM +0200, Imre Deak wrote:
> After Damien's D3 fix I started to get runtime suspend residency for the
> first time and that revealed a breakage on the set_caching IOCTL path
> that accesses the HW but doesn't take an RPM ref. Fix this up.
Why here (and in so many
Em Qua, 2015-11-04 às 14:19 -0600, Jason Wessel escreveu:
> On 11/04/2015 02:13 PM, Jesse Barnes wrote:
> > On 11/04/2015 11:10 AM, Paulo Zanoni wrote:
> > > From our maintainer Daniel Vetter a few days ago:
> > > "Oh dear this is dead code. kdbg uses the fbcon, which always
> > > uses
> > >
From: Ville Syrjälä
v2: Keep some MISSING_CASE() stuff (Jani)
s/-1/-PIPE_B/ in the register macro
Fix typo in patch subject
v3: Use PORT_B registers for invalid ports in g4x_aux_ctl_reg() (Jani)
Reviewed-by: Jani Nikula
From: Ville Syrjälä
Drop the EDP_PSR_BASE() thing, and just stick the PSR register offset
under dev_priv, like we for DSI and GPIO for example.
TODO: could probably move a bunch of this kind of stuff into the device
info instead...
v2: Drop the spurious
From: Ville Syrjälä
Currently we determine the location of the AUX registers in a confusing
way. First we assume the PCH registers are used always, but then we
override it for everything but HSW/BDW to use DP+0x10. Very confusing.
Let's just make it
From: Ville Syrjälä
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/i915_drv.h | 1 -
drivers/gpu/drm/i915/intel_display.c | 22 +++---
drivers/gpu/drm/i915/intel_dp.c | 19 ---
3
From: Ville Syrjälä
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_dp.c | 38 +-
1 file changed, 13 insertions(+), 25 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c
From: Ville Syrjälä
v2: Split up the ctl vs. data reg handling like in the normal AUX code
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_psr.c | 27 +--
1 file changed, 21 insertions(+), 6
From: Ville Syrjälä
i915 register defines are going to become type safe, so going forward
the register defines can't be used as straight numbers. Since quirks.c
needs just a few extra register defines from i915_reg.h, decouple the
two by defining the required
On Wed, Nov 4, 2015 at 6:17 PM, Daniel Stone wrote:
> Hi,
>
> On 3 November 2015 at 12:31, Patrik Jakobsson
> wrote:
>> These patches should sit on top of the DMC redesign patches from
>> Animesh/Imre [1] which in turn depends on Mika's FW
From: Ville Syrjälä
I need to add a new variable into GEN6_{READ,WRITE}_HEADER, but the vgpu
won't need it, so let's avoid an unused variable warning by splitting
the vgpu stuff to use its own macros.
Cc: Eddie Dong
Cc: Jike Song
From: Ville Syrjälä
Replace the is_sdvob bool and some sdvo_reg checks with enum port. This
makes the SDVO code look more modern, and gets rid of explicit register
offset checks in the code which will hamper register type checking.
Signed-off-by: Ville Syrjälä
From: Ville Syrjälä
Add defines for the upper halves of the registers used by the cmd
parser. Getting rid of the arithmetic with the register offset
will help in making registers type safe.
Signed-off-by: Ville Syrjälä
---
From: Ville Syrjälä
Most of our register defines follow the convention that if there's a
need for the raw register offset, that one has an underscore sa a
prefix. The define (possibly parametrized) without the underscore is
the one people should normally use, since
From: Ville Syrjälä
Another round of stuff for the type safe register access. Some of these
were already posted during the first round, but a lot of it is new
(LRI stuff, cmd parser, lrc setup etc., vgpu, etc.)
Available as a git branch too:
From: Ville Syrjälä
Rather than computing on demand, store also the aux data reg
offsets under intel_dp.
v2: Duplicate some code to make things less magic (Jani)
v3: Use PORT_B registers for invalid ports in g4x_aux_data_reg()
Signed-off-by: Ville Syrjälä
From: Ville Syrjälä
Instead of checking what aux_ch_ctl_reg is, we can simply check the port
when determining the right timeout value to program.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_dp.c | 3 +--
1 file
From: Ville Syrjälä
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/i915_gem.c | 7 +++
drivers/gpu/drm/i915/i915_irq.c | 2 +-
drivers/gpu/drm/i915/i915_reg.h | 6 ++
3 files changed, 6 insertions(+), 9 deletions(-)
From: Ville Syrjälä
If we ignore the BXT situation, we can observe that the only variables
affecting gpio_mmio_base is IS_VALLEVIEW and HAS_GMCH_DISPLAY. The BXT
situation we can fit into the same pattern if we change gmbus_pins_bxt[]
to house the GMCH GPIO
Hi Jani,
could you please consider to merge this already reviewed patch.
Thanks,
Rodrigo.
On Thu, Oct 29, 2015 at 10:22 AM Rodrigo Vivi
wrote:
> From: Deepak S
>
> Reviewed-by: Damien Lespiau
> Signed-off-by: Deepak S
In this subtest, as a first step, MAX_FENCES+1 number of framebuffers are
created backed up by objects that have multiple GGTT views (normal and
rotated). Next, we have the i915 driver instantiate a normal view followed
by a rotated view. We continue doing the above MAX_FENCES + 1 times.
v2:
-
On Wed, Nov 04, 2015 at 04:12:33PM +0200, Jani Nikula wrote:
> On Tue, 03 Nov 2015, Matt Roper wrote:
> > Although we can do a good job of reading out hardware state, the
> > graphics firmware may have programmed the watermarks in a creative way
> > that doesn't match
In some cases, we just need one valid (connected) output to perform
a test. This macro can help in these situations by not having to
put the test code inside a for loop that iterates over all the outputs.
v2: Added a brief documentation for this macro.
Suggested-by: Matt Roper
Cc: Thomas Wood
For certain platforms that support rotated scanout buffers, currently,
there is no way to create them with the GBM DRI interface. This flag
will instruct the DRI driver to create the buffer by setting
additional requirements such as tiling mode.
v2: Reserve a bit per angle. (Ville and Michel)
Looks good to me.
Reviewed-by: Sonika Jindal
Looks good to me.
Reviewed-by: Sonika Jindal
SWF18 is set if the display has been intialized by the pre-os. It also
gives what configuration is enabled on which pipe. In skl_sanitize_cdclk,
the DPLL sanity check can pass even if GOP/VBIOS is not loaded as BIOS
enables DPLL for integrated audio codec related programming.
So fisrt check if
On Wed, Nov 04, 2015 at 11:20:12PM +0200, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> We'll want to avoid performing arithmetic with register offsets, so
> instead calculating the vgpu PDP as pdp0_lo+offset, make the PDPs
> into an array. This
On Wed, Nov 04, 2015 at 11:20:13PM +0200, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> I need to add a new variable into GEN6_{READ,WRITE}_HEADER, but the vgpu
> won't need it, so let's avoid an unused variable warning by splitting
> the vgpu
On Wed, Nov 4, 2015 at 6:29 PM, Ville Syrjälä
wrote:
> On Tue, Nov 03, 2015 at 01:31:10PM +0100, Patrik Jakobsson wrote:
>> We need DC5/DC6 to be disabled around modesets to prevent confusing the
>> DMC. Also, we've run out of bits in the 32 bit power domain mask so
2015-11-02 9:48 GMT-02:00 Thomas Wood :
> Make subtest results easier to identify by making them bold when the output
> is a terminal.
Cool!
A long time ago I suggested using different colors when writing
SUCCESS/FAIL/SKIP/CRASH (green, red, yellow, orange) and I was told
On Wed, Nov 04, 2015 at 07:36:04PM +, Zanoni, Paulo R wrote:
> Em Seg, 2015-11-02 às 11:48 +, Thomas Wood escreveu:
> > Initialization was included in commit a976d7e (tests/kms_fbc_crc:
> > refactor context
> > handling code), but won't be executed since it is declared before the
> > first
On 11/04/2015 11:10 AM, Paulo Zanoni wrote:
> From our maintainer Daniel Vetter a few days ago:
> "Oh dear this is dead code. kdbg uses the fbcon, which always uses
> untiled, which means fbc will never be enabled. Also we have 0 users
> and 0 test coverage for kdbg on top of i915 (Jesse
Newlines are not needed and they're not used by the other messages. I
added the newline by mistake.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_fbc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_fbc.c
Don't try to list in comments the cases where we should enable or
disable FBC: it varies a lot with the hardware generations and the
code should be the documentation. Also notice that there's already a
huge gap between the comments and what's in the code.
Signed-off-by: Paulo Zanoni
After Damien's D3 fix I started to get runtime suspend residency for the
first time and that revealed a breakage on the set_caching IOCTL path
that accesses the HW but doesn't take an RPM ref. Fix this up.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/i915_gem.c | 8
On Wed, Nov 4, 2015 at 6:53 PM, Ville Syrjälä
wrote:
> On Tue, Nov 03, 2015 at 01:31:12PM +0100, Patrik Jakobsson wrote:
>> Handle DC off as a power well where enabling the power well will prevent
>> the DMC to enter selected DC states (required around modesets and
Em Seg, 2015-11-02 às 11:48 +, Thomas Wood escreveu:
> Initialization was included in commit a976d7e (tests/kms_fbc_crc:
> refactor context
> handling code), but won't be executed since it is declared before the
> first
> label within a switch statement.
>
> kms_fbc_crc.c:178:2: warning:
If we run igt/kms_frontbuffer_tracking, this message will appear
thousands of times, eating a significant part of our dmesg buffer.
It's part of the expected FBC behavior, so let's just silence it.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_fbc.c | 2 --
This change was part of the commit that makes intel_fbc_update()
receive an intel_crtc as argument instead of dev_priv, but since it
was polluting the diff with too many chunks I decided to move it to
its own commit.
It seems that our developers are favoring having this instead of the
old
Make sure we deactivate FBC at intel_fbc_init(), so we can remove the
call from intel_display.c. Currently we only have the "enabled"
software state, but later we'll have both "enabled" and "active", and
we'll add assertions to them, so just calling intel_fbc_disable() from
intel_modeset_init()
Hi
So Ville pointed a problem on patch 02/26 of the previous series, and the nice
fix for that would make me rebase most of the subsequent patches. In order to
avoid blocking the other patches on the review of patch 02 and in order to avoid
having to rebase everything again and again during this
We already check if the CRTC is visible, and it shouldn't be possible
to have a visible CRTC without an FB.
This was noticed by both Chris and Ville on different ocasions.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_fbc.c | 2 +-
1 file changed, 1
Daniel was looking at this code and asked about whether fb->pitches[0]
is correct, then he suggested we should a comment to make sure it is
actually intentional.
For more information on the CFB size calculation, please see the
commit message of:
commit c4ffd40908c30a33291227920e921f6b45b9e8f7
Make the code easier to read.
Suggested-by: Chris Wilson
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_fbc.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_fbc.c
We're going to kill intel_fbc_find_crtc(), that's why a big part of
the logic moved from intel_fbc_find_crtc() to crtc_is_valid().
v2:
- Rebase due to pipe_a_only change.
- Split the multiline conditional (Chris).
Signed-off-by: Paulo Zanoni
---
In function find_compression_threshold() we try to over-allocate CFB
space in order to reudce reallocations and fragmentation, and we're
not considering that at the CFB size check. Consider it.
There is also a longer-term plan to kill
dev_priv->fbc.uncompressed_size, but this will come later.
On ti, 2015-11-03 at 13:31 +0100, Patrik Jakobsson wrote:
> Handle DC off as a power well where enabling the power well will prevent
> the DMC to enter selected DC states (required around modesets and Aux
> A). Disabling the power well will allow DC states again. For now the
> highest DC state is
2015-11-04 17:25 GMT-02:00 Imre Deak :
> After Damien's D3 fix I started to get runtime suspend residency for the
> first time and that revealed a breakage on the set_caching IOCTL path
> that accesses the HW but doesn't take an RPM ref. Fix this up.
Oh, well, that's the the
On 04/11/15 14:24, Chris Wilson wrote:
On Wed, Nov 04, 2015 at 02:10:36PM +, Morton, Derek J wrote:
-Original Message-
From: Chris Wilson [mailto:ch...@chris-wilson.co.uk]
No, just android appears to be broken. I was actually complaining about the use
of 'S'.
What would you
On 04/11/15 14:46, Morton, Derek J wrote:
-Original Message-
From: Tvrtko Ursulin [mailto:tvrtko.ursu...@linux.intel.com]
Sent: Wednesday, November 4, 2015 2:34 PM
To: Chris Wilson; Morton, Derek J; intel-gfx@lists.freedesktop.org; Wood,
Thomas; Gore, Tim
Subject: Re: [Intel-gfx]
On Wed, Nov 04, 2015 at 02:10:36PM +, Morton, Derek J wrote:
> >
> >
> >-Original Message-
> >From: Chris Wilson [mailto:ch...@chris-wilson.co.uk]
> >No, just android appears to be broken. I was actually complaining about the
> >use of 'S'.
>
> What would you prefer to be printed?
>
>
>-Original Message-
>From: Tvrtko Ursulin [mailto:tvrtko.ursu...@linux.intel.com]
>Sent: Wednesday, November 4, 2015 2:34 PM
>To: Chris Wilson; Morton, Derek J; intel-gfx@lists.freedesktop.org; Wood,
>Thomas; Gore, Tim
>Subject: Re: [Intel-gfx] [PATCH i-g-t] tests/gem_exec_nop:
On Wed, Nov 04, 2015 at 01:20:33PM +, Gong, Zhipeng wrote:
>
>
> > -Original Message-
> > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk]
> > Sent: Wednesday, November 04, 2015 5:54 PM
> > On Wed, Nov 04, 2015 at 06:19:33AM +, Gong, Zhipeng wrote:
> > > > From: Chris Wilson
>
>
>-Original Message-
>From: Chris Wilson [mailto:ch...@chris-wilson.co.uk]
>Sent: Wednesday, November 4, 2015 1:55 PM
>To: Morton, Derek J
>Cc: intel-gfx@lists.freedesktop.org; Wood, Thomas; Gore, Tim
>Subject: Re: [PATCH i-g-t] tests/gem_exec_nop: Improved test run time
>
>On Wed, Nov
On Tue, 03 Nov 2015, Matt Roper wrote:
> Although we can do a good job of reading out hardware state, the
> graphics firmware may have programmed the watermarks in a creative way
> that doesn't match how i915 would have chosen to program them. We
> shouldn't trust the
When setcrtc is called and steals the last connector away from a crtc
it's turned off because it can't stay configured without connectors.
The framebuffer is still preserved however, and that causes troubles
in the IGT stress test kms_flip.flips-vs-fences which tries to use
as many pins as
I noticed that intel_fbdev->our_mode is unused. Introduced by
79e539453b34 ("DRM: i915: add mode setting support").
Then I noticed that intel_fbdev->fbdev_list is unused as well.
Introduced by 386516744ba4 ("drm/fb: fix fbdev object model +
cleanup properly.") in i915, nouveau and radeon.
>
>
>-Original Message-
>From: Chris Wilson [mailto:ch...@chris-wilson.co.uk]
>Sent: Tuesday, November 3, 2015 4:40 PM
>To: Morton, Derek J
>Cc: intel-gfx@lists.freedesktop.org; Wood, Thomas; Gore, Tim
>Subject: Re: [PATCH i-g-t] tests/gem_exec_nop: Improved test run time
>
>On Tue, Nov
On Wed, Nov 04, 2015 at 01:40:45PM +, Morton, Derek J wrote:
> >
> >
> >-Original Message-
> >From: Chris Wilson [mailto:ch...@chris-wilson.co.uk]
> >Sent: Tuesday, November 3, 2015 4:40 PM
> >To: Morton, Derek J
> >Cc: intel-gfx@lists.freedesktop.org; Wood, Thomas; Gore, Tim
>
Reviewed-by: Ander Conselvan de Oliveira
On Fri, 2015-10-30 at 23:39 +0200, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> Currently there's no trace in dmesg when the gen2/3 dotclock checks
> reject the modeset. Add some to
On 11/03/2015 07:22 PM, Dave Airlie wrote:
On 4 November 2015 at 07:42, Daniel Stone wrote:
> The GuC firmware load requires struct_mutex to create a GEM object,
> but this collides badly with request_firmware. Move struct_mutex
> locking down into the loader itself, so
BXT CRTC scaling uses the same gen9 codepaths as SKL; these codepaths
store panel fitter information in pipe_config->pch_pfit. However since
HAS_PCH_SPLIT() is false for BXT we never actually wind up filling in
this structure (we wind up filling in pipe_config->gmch_pfit instead,
which is ignored
On Tue, Nov 03, 2015 at 06:29:41PM -0800, Matt Roper wrote:
> BXT CRTC scaling uses the same gen9 codepaths as SKL; these codepaths
> store panel fitter information in pipe_config->pch_pfit. However since
> HAS_PCH_SPLIT() is false for BXT we never actually wind up filling in
> this structure (we
On Sun, Nov 01, 2015 at 04:33:57PM +0100, Lukas Wunner wrote:
> Hi Ville,
>
> On Fri, Sep 18, 2015 at 08:03:45PM +0300, ville.syrj...@linux.intel.com wrote:
> > From: Ville Syrjälä
> >
> > Keep single 'lvds_reg' and 'lvds' variable around in
> > intel_lvds_init(),
Hi,
On 27 October 2015 at 12:46, Mika Kuoppala
wrote:
> From: Damien Lespiau
>
> That can be handy later on to tell which DMC firmware version the user
> has, by just looking at the dmesg.
>
> v2: use DRM_DEBUG_DRIVER (Chris)
> v3: use
With the DMC firmware installed we don't need to handle HW resources
that are handled automatically by the firmware. Besides beeing redundant
this can also interfere with the firmware, possibly getting it into a
broken/blocked state. The on-demand handling of PW1 was already half-way
removed, MISC
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/i915_reg.h | 1 +
drivers/gpu/drm/i915/intel_runtime_pm.c | 66 ++---
2 files changed, 29 insertions(+), 38 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h
From: Damien Lespiau
Before this patch, we used the intel_display_power_{get,put} functions
to make sure the PW1 and Misc I/O power wells were enabled all the
time while LCPLL was enabled. We called a get() at
intel_ddi_pll_init() when we discovered that LCPLL was
We need to disable the DC states during display core init to sanitize
the HW state we inherit from the BIOS. We need to disable it during
display core uninit too, since the power well framework will leave it
enabled (since we get to the display core uninit step with all power
domains disabled
We need to initialize the display core part early, before initializing
the rest of the display power state. This is also described in the bspec
termed "Display initialization sequence". Atm we run this sequence
during driver loading after power domain HW state initialization which
is too late and
Hi,
On 28 October 2015 at 21:58, Imre Deak wrote:
> This is a rebased version of [1], addressing the review comments. It
> depends on Mika's FW version blacklisting/capture patchset [2].
>
> I have added my Reviewed-by to those patches that I only rebased or
> updated the
Suppressing LCPLL disabling was added to avoid interfering with the DMC
firmware. It is not needed any more since we uninit CDCLK now with the
DMC deactivated (DC states disabled). We also must disable it during system
suspend as part of the Bspec "Display uninit sequence".
Signed-off-by: Imre
Hi,
On 3 November 2015 at 22:08, Patrik Jakobsson
wrote:
> On Tue, Nov 3, 2015 at 10:47 PM, Daniel Stone wrote:
>> I tested this on top of the three series (Mika's, Imre's, and yours),
>> but hit some power domain warnings and I never come
Hi,
On 3 November 2015 at 12:31, Patrik Jakobsson
wrote:
> These patches should sit on top of the DMC redesign patches from
> Animesh/Imre [1] which in turn depends on Mika's FW debug patches [2].
>
> First two patches are from Ville and is included since they
The current lookup code wouldn't find a power well if it's not in any
power domain. There wasn't any power wells before but an upcoming patch
will detach the power domains from power well#1 and the MISC IO power
wells, so fix things up accordingly.
Signed-off-by: Imre Deak
Atm we toggle HW resources handled automatically by the DMC firmware.
This is redundant and also interferes with the firmware's functionality.
This patchset fixes this and also an old existing issue leaving RPM
disabled all the time (see Damien's patch).
The patchset depends on Mika's firmware
On Tue, Nov 03, 2015 at 01:31:10PM +0100, Patrik Jakobsson wrote:
> We need DC5/DC6 to be disabled around modesets to prevent confusing the
> DMC. Also, we've run out of bits in the 32 bit power domain mask so now
> it's a 64 bit mask.
We could get back 4 bits by squashing each 2 and 4 lane DDI
On Tue, Nov 03, 2015 at 01:31:11PM +0100, Patrik Jakobsson wrote:
> PG2 enabled is not a requirement for disabling DC5. It's just one
> of the reasons why we wouldn't enter DC5. During modeset we don't care
> about PG2 from a DC perspective, only the fact that DC5/DC6 is not
> allowed.
>
>
On Thursday 29 October 2015 07:25 PM, Imre Deak wrote:
On to, 2015-10-29 at 15:48 +0530, Sunil Kamath wrote:
On Thursday 29 October 2015 03:28 AM, Imre Deak wrote:
From: Animesh Manna
Skl is fully dependent on dmc for going to low power state (dc5/dc6).
This requires
We have a timed release of a forcewake when using
I915_READ/WRITE macros. wait_for() macro will go to quite
long sleep if the first read doesn't satisfy the condition for
successful exit. With these two interacting, it is possible that
we lose the forcewake during the wait_for() and the subsequent
The old value of 0x7FF will wrap the position at 2048 giving wrong
coordinate values on panels larger than 2048 pixels in any direction.
Used in i915_debugfs atm. Looking at all hw specs available at 01.org
shows that X position is bit 0:11, and even 0:12 on some hw where
remaining bits up to bit
On Wed, Nov 04, 2015 at 11:33:04AM +0200, Mika Kuoppala wrote:
> We have a timed release of a forcewake when using
> I915_READ/WRITE macros. wait_for() macro will go to quite
> long sleep if the first read doesn't satisfy the condition for
> successful exit. With these two interacting, it is
On Wed, Nov 04, 2015 at 06:19:33AM +, Gong, Zhipeng wrote:
> > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk]
> > On Tue, Nov 03, 2015 at 01:31:22PM +, Gong, Zhipeng wrote:
> > >
> > > > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk]
> > > >
> > > > Do you also have a relative
On Wed, Nov 04, 2015 at 10:35:19AM +0100, Robert Fekete wrote:
> The old value of 0x7FF will wrap the position at 2048 giving wrong
> coordinate values on panels larger than 2048 pixels in any direction.
> Used in i915_debugfs atm. Looking at all hw specs available at 01.org
> shows that X
RC6 setup is shared between BIOS and Driver. BIOS sets up subset of RC6
setup registers. If those are not setup Driver should not enable RC6.
For implementing this, driver can check RC_CTRL0 and RC_CTRL1 values
to know if BIOS has enabled HW/SW RC6.
This will also enable user to control RC6 using
Chris Wilson writes:
> On Wed, Nov 04, 2015 at 11:33:04AM +0200, Mika Kuoppala wrote:
>> We have a timed release of a forcewake when using
>> I915_READ/WRITE macros. wait_for() macro will go to quite
>> long sleep if the first read doesn't satisfy the condition for
>>
Enable CL_DEVICE_SVM_COARSE_GRAIN_BUFFER svm support, use userptr and softpin
to implement it. Use userptr to share the page between cpu and gpu, and softpin
to unify the cpu and gpu's address. Now it works on i386 system. x86_64 depends
on
backend support.
This patch base on DRM library and DRM
1 - 100 of 104 matches
Mail list logo