Re: [Intel-gfx] [PATCH] drm/i915: Don't ERROR for an expected intel_rcs_ctx_init() interruption

2016-01-25 Thread Chris Wilson
On Mon, Jan 25, 2016 at 06:25:33PM +, Dave Gordon wrote: > On 23/01/16 17:54, Chris Wilson wrote: > >intel_rcs_ctx_init() can be interrupted by a signal (if it has to wait > >upon a full ring to advance). Don't emit an error for this. > > > >Signed-off-by: Chris Wilson > >--- > > drivers/gpu/

Re: [Intel-gfx] [PATCH 01/15] drm/vblank: Use drm_event_reserve_init

2016-01-25 Thread Daniel Vetter
On Mon, Jan 25, 2016 at 10:16:42PM +0100, Daniel Vetter wrote: > Well we can't use that directly since that code must hold > dev->event_lock already. Extract an _unlocked version. > > Embarrassingly I've totally forgotten about this patch and any kind of > event-based vblank wait totally blew up,

Re: [Intel-gfx] [PATCH] drm/i915: Make wa_tail_dwords flexible for future platforms.

2016-01-25 Thread Chris Wilson
On Mon, Jan 25, 2016 at 11:29:19AM -0800, Rodrigo Vivi wrote: > +++ b/drivers/gpu/drm/i915/intel_lrc.c > @@ -764,18 +764,18 @@ intel_logical_ring_advance_and_submit(struct > drm_i915_gem_request *request) > { > struct intel_ringbuffer *ringbuf = request->ringbuf; > struct drm_i915_pri

[Intel-gfx] [PATCH 10/15] drm/rcar: Nuke preclose hook

2016-01-25 Thread Daniel Vetter
Again since the drm core takes care of event unlinking/disarming this is now just needless code. Cc: Laurent Pinchart Acked-by: Daniel Stone Reviewed-by: Alex Deucher Reviewed-by: Laurent Pinchart Link: http://patchwork.freedesktop.org/patch/msgid/1452548477-15905-18-git-send-email-daniel.vet

[Intel-gfx] [PATCH 12/15] drm/tegra: Stop cancelling page flip events

2016-01-25 Thread Daniel Vetter
The core takes care of that now. v2: Fixup misplaced hunk. Cc: Thierry Reding Cc: Terje Bergström Acked-by: Daniel Stone Reviewed-by: Alex Deucher Link: http://patchwork.freedesktop.org/patch/msgid/1452548477-15905-20-git-send-email-daniel.vet...@ffwll.ch Acked-by: Thierry Reding Signed-off

[Intel-gfx] [PATCH 03/15] drm: Nuke vblank event file cleanup code

2016-01-25 Thread Daniel Vetter
The core code now takes care of unlinking drm_events from the file in a generic way, so this code isn't needed any more. For those wondering where the drm_vblank_put went to: With the new logic events only get unlinked, but still exist. Hence any resources (like vblank counters) don't need to be r

[Intel-gfx] [PATCH 04/15] drm/i915: Nuke intel_modeset_preclose

2016-01-25 Thread Daniel Vetter
Now that the drm core unlinks/disarms events there's no need to do so ourselves anymore. Nuke the code. Acked-by: Daniel Stone Reviewed-by: Alex Deucher Link: http://patchwork.freedesktop.org/patch/msgid/1452548477-15905-12-git-send-email-daniel.vet...@ffwll.ch Signed-off-by: Daniel Vetter ---

[Intel-gfx] [PATCH 15/15] drm/vmwgfx: Nuke preclose hook

2016-01-25 Thread Daniel Vetter
Again since the drm core takes care of event unlinking/disarming this is now just needless code. v2: I've completely missed eaction->fpriv_head and all the related code. We need to nuke that too to avoid accidentally deferencing the freed-up vmwgfx-private fpriv. v3: Also remove vmw_fpriv->fence_

[Intel-gfx] [PATCH 11/15] drm/shmob: Nuke preclose hook

2016-01-25 Thread Daniel Vetter
Again since the drm core takes care of event unlinking/disarming this is now just needless code. v2: Fixup misplaced hunk. Cc: Laurent Pinchart Acked-by: Daniel Stone Reviewed-by: Alex Deucher (v1) Reviewed-by: Laurent Pinchart Link: http://patchwork.freedesktop.org/patch/msgid/1452548477-15

[Intel-gfx] [PATCH 14/15] drm/vc4: Nuke preclose hook

2016-01-25 Thread Daniel Vetter
Again since the drm core takes care of event unlinking/disarming this is now just needless code. v2: Fixup misplaced hunk. Cc: Eric Anholt Acked-by: Daniel Stone Reviewed-by: Alex Deucher (v1) Link: http://patchwork.freedesktop.org/patch/msgid/1452548477-15905-22-git-send-email-daniel.vet...@

[Intel-gfx] [PATCH 09/15] drm/omap: Nuke close hooks

2016-01-25 Thread Daniel Vetter
Again since the core takes care of this we can remove them. While at it also remove the postclose hook, it's empty. v2: Laurent pointed me at even more code to delete. v3: Remove unused flags (Tomi). Cc: Laurent Pinchart Cc: Tomi Valkeinen Acked-by: Daniel Stone Reviewed-by: Alex Deucher Lin

[Intel-gfx] [PATCH 01/15] drm/vblank: Use drm_event_reserve_init

2016-01-25 Thread Daniel Vetter
Well we can't use that directly since that code must hold dev->event_lock already. Extract an _unlocked version. Embarrassingly I've totally forgotten about this patch and any kind of event-based vblank wait totally blew up, killing the kernel. Cc: Alex Deucher Cc: Daniel Stone Cc: Laurent Pinc

[Intel-gfx] [PATCH 06/15] drm/exynos: Remove event cancelling from postclose

2016-01-25 Thread Daniel Vetter
The core takes care of this now. And since kfree(NULL) is ok we can simplify the function even further now. Note: There's another spin on this patch, but for different reasons, in-flight already: http://www.spinics.net/lists/dri-devel/msg97922.html Cc: Inki Dae Acked-by: Daniel Stone Reviewed-b

[Intel-gfx] [PATCH 08/15] drm/msm: Nuke preclose hooks

2016-01-25 Thread Daniel Vetter
They only complete the page flip events to avoid oops when the drm file closes. The core takes care of that now and we can remove this code. Cc: Rob Clark Acked-by: Daniel Stone Reviewed-by: Alex Deucher Link: http://patchwork.freedesktop.org/patch/msgid/1452548477-15905-16-git-send-email-dani

[Intel-gfx] [PATCH 02/15] drm: Clean up pending events in the core

2016-01-25 Thread Daniel Vetter
There's really no reason to not do so, instead of replicating this for every use-case and every driver. Now we can't just nuke the events, since that would still mean that all drm_event users would need to know when that has happened, since calling e.g. drm_send_event isn't allowed any more. Instea

[Intel-gfx] [PATCH 13/15] drm/tilcdc: Nuke preclose hook

2016-01-25 Thread Daniel Vetter
Again since the drm core takes care of event unlinking/disarming this is now just needless code. v2: Fixup misplaced hunks. Cc: Rob Clark Acked-by: Daniel Stone Reviewed-by: Alex Deucher (v1) Link: http://patchwork.freedesktop.org/patch/msgid/1452548477-15905-21-git-send-email-daniel.vet...@f

[Intel-gfx] [PATCH 05/15] drm/atmel: Nuke preclose

2016-01-25 Thread Daniel Vetter
The only thing this did was cancle pending flip events, and the core takes care of that now. Cc: Boris Brezillon Acked-by: Daniel Stone Reviewed-by: Alex Deucher Acked-by: Boris Brezillon Link: http://patchwork.freedesktop.org/patch/msgid/1452548477-15905-13-git-send-email-daniel.vet...@ffwll

[Intel-gfx] [PATCH 07/15] drm/imx: Unconfuse preclose logic

2016-01-25 Thread Daniel Vetter
So this one is special, since it tries to prevent races when userspace crashes simply by disabling the vblank machinery. Well except that imx always has vblanks enabled, and the disable_vblank hook actually just tries to cancel a pending pageflip. Without any locking whatsoever. Of course this is w

[Intel-gfx] [PATCH 07/10] drm/i915: Add support for stealing purgable stolen pages

2016-01-25 Thread ankitprasad . r . sharma
From: Chris Wilson If we run out of stolen memory when trying to allocate an object, see if we can reap enough purgeable objects to free up enough contiguous free space for the allocation. This is in principle very much like evicting objects to free up enough contiguous space in the vma when bind

[Intel-gfx] [PATCH 02/10] drm/i915: Introduce i915_gem_object_get_dma_address()

2016-01-25 Thread ankitprasad . r . sharma
From: Chris Wilson This utility function is a companion to i915_gem_object_get_page() that uses the same cached iterator for the scatterlist to perform fast sequential lookup of the dma address associated with any page within the object. Signed-off-by: Chris Wilson Signed-off-by: Ankitprasad Sh

[Intel-gfx] [PATCH 09/10] drm/i915: Migrate stolen objects before hibernation

2016-01-25 Thread ankitprasad . r . sharma
From: Chris Wilson Ville reminded us that stolen memory is not preserved across hibernation, and a result of this was that context objects now being allocated from stolen were being corrupted on S4 and promptly hanging the GPU on resume. We want to utilise stolen for as much as possible (nothing

[Intel-gfx] [PATCH 01/10] drm/i915: Add support for mapping an object page by page

2016-01-25 Thread ankitprasad . r . sharma
From: Chris Wilson Introduced a new vm specfic callback insert_page() to program a single pte in ggtt or ppgtt. This allows us to map a single page in to the mappable aperture space. This can be iterated over to access the whole object by using space as meagre as page size. Signed-off-by: Chris

[Intel-gfx] [PATCH 08/10] drm/i915: Support for pread/pwrite from/to non shmem backed objects

2016-01-25 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma This patch adds support for extending the pread/pwrite functionality for objects not backed by shmem. The access will be made through gtt interface. This will cover objects backed by stolen memory as well as other non-shmem backed objects. v2: Drop locks around slow_user

[Intel-gfx] [PATCH 10/10] drm/i915: Disable use of stolen area by User when Intel RST is present

2016-01-25 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma The BIOS RapidStartTechnology may corrupt the stolen memory across S3 suspend due to unalarmed hibernation, in which case we will not be able to preserve the User data stored in the stolen region. Hence this patch tries to identify presence of the RST device on the ACPI b

[Intel-gfx] [PATCH 06/10] drm/i915: Propagating correct error codes to the userspace

2016-01-25 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma Propagating correct error codes to userspace by using ERR_PTR and PTR_ERR macros for stolen memory based object allocation. We generally return -ENOMEM to the user whenever there is a failure in object allocation. This patch helps user to identify the correct reason for t

Re: [Intel-gfx] [PATCH igt] igt/gem_softpin: Remove false dependencies on esoteric features

2016-01-25 Thread Jesse Barnes
On 01/21/2016 12:08 AM, Daniel Vetter wrote: > On Wed, Jan 20, 2016 at 06:49:49PM +, Belgaumkar, Vinay wrote: >> Hi Chris, >> These tests were developed for testing buffered SVM(using userptr >> and soft pinning API). I think Dan wanted me to rename the tests to >> gem_softpin, sinc

[Intel-gfx] [PATCH v15 0/10] Support for creating/using Stolen memory backed objects

2016-01-25 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma This patch series adds support for creating/using Stolen memory backed objects. Despite being a unified memory architecture (UMA) some bits of memory are more equal than others. In particular we have the thorny issue of stolen memory, memory stolen from the system by the

[Intel-gfx] [PATCH 03/10] drm/i915: Use insert_page for pwrite_fast

2016-01-25 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma In pwrite_fast, map an object page by page if obj_ggtt_pin fails. First, we try a nonblocking pin for the whole object (since that is fastest if reused), then failing that we try to grab one page in the mappable aperture. It also allows us to handle objects larger than th

[Intel-gfx] [PATCH 04/10] drm/i915: Clearing buffer objects via CPU/GTT

2016-01-25 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma This patch adds support for clearing buffer objects via CPU/GTT. This is particularly useful for clearing out the non shmem backed objects. Currently intend to use this only for buffers allocated from stolen region. v2: Added kernel doc for i915_gem_clear_object(), corre

[Intel-gfx] [PATCH 05/10] drm/i915: Support for creating Stolen memory backed objects

2016-01-25 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma Extend the drm_i915_gem_create structure to add support for creating Stolen memory backed objects. Added a new flag through which user can specify the preference to allocate the object from stolen memory, which if set, an attempt will be made to allocate the object from s

Re: [Intel-gfx] [PATCH 2/2] configure.ac: Add a configure arg for the overlay.

2016-01-25 Thread Daniel Stone
Hi, On 25 January 2016 at 18:40, Eric Anholt wrote: > It's autodetected if its dependencies are present, but it doesn't > build for ARM, nor am I interested in it for now. The one I just sent auto-disables it when not building on x86. Cheers, Daniel _

[Intel-gfx] [PATCH] build: Disable x86-specific utilities on non-x86

2016-01-25 Thread Daniel Stone
Some bits can't be built on non-x86 architectures, mostly because they require x86-specific assembly primitives. Disable these by default on non-x86 architectures. Signed-off-by: Daniel Stone --- Makefile.am | 10 +++--- configure.ac | 37 - 2 files chang

Re: [Intel-gfx] [PATCH] drm/i915: Make wa_tail_dwords flexible for future platforms.

2016-01-25 Thread Ben Widawsky
On Mon, Jan 25, 2016 at 11:29:19AM -0800, Rodrigo Vivi wrote: > Commit 7c17d3773 (drm/i915: Use ordered seqno write interrupt generation > on gen8+ execlists) moved two MI_NOOPs to the advance_and_submit functions > and hardcoded the WA_TAIL_DWORDS. With this we don't have a clean way to > implemen

Re: [Intel-gfx] [PATCH 1/2] igt: Disable igt_clflush_range() implementation on ARM builds.

2016-01-25 Thread Daniel Stone
Wait, no, thought of a bikeshed: #if defined(__i386__) || defined(__x86_64__) On 25 January 2016 at 19:30, Daniel Stone wrote: > Hi, > > On 25 January 2016 at 18:40, Eric Anholt wrote: >> Daniel has suggested that I put vc4 testing into igt, since it's got >> the piglit integration and KMS cover

Re: [Intel-gfx] [PATCH 1/2] igt: Disable igt_clflush_range() implementation on ARM builds.

2016-01-25 Thread Daniel Stone
Hi, On 25 January 2016 at 18:40, Eric Anholt wrote: > Daniel has suggested that I put vc4 testing into igt, since it's got > the piglit integration and KMS coverage already. This gets the ccore > building so that I can start writing tests. Works for me. Reviewed-by: Daniel Stone Cheers, Dani

[Intel-gfx] [PATCH] drm/i915: Make wa_tail_dwords flexible for future platforms.

2016-01-25 Thread Rodrigo Vivi
Commit 7c17d3773 (drm/i915: Use ordered seqno write interrupt generation on gen8+ execlists) moved two MI_NOOPs to the advance_and_submit functions and hardcoded the WA_TAIL_DWORDS. With this we don't have a clean way to implement or remove WaIdleLiteRestore for different platforms. This patch aim

Re: [Intel-gfx] [RFC] drm/i915: Render decompression support for Gen9 and above

2016-01-25 Thread Daniel Stone
Hi, On 25 January 2016 at 19:04, Smith, Gary K wrote: > It’s a few hundred lines of extra code and additional complexity in > open-source userspace to track the additional fb's in flight in order to save > the i915 code from performing a couple of extra if's during a flip. It's not > a good tr

Re: [Intel-gfx] [RFC] drm/i915: Render decompression support for Gen9 and above

2016-01-25 Thread Smith, Gary K
Corrected the first line below. -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Smith, Gary K Sent: Monday, January 25, 2016 7:04 PM To: Daniel Stone Cc: intel-gfx@lists.freedesktop.org; Thierry Reding Subject: Re: [Intel-gfx] [RFC] drm/

Re: [Intel-gfx] [RFC] drm/i915: Render decompression support for Gen9 and above

2016-01-25 Thread Smith, Gary K
It’s a few hundred lines of extra code and additional complexity in open-source userspace to track the additional fb's in flight in order to save the i915 code from performing a couple of extra if's during a flip. It's not a good tradeoff at all. We already have the experience of requiring to ch

Re: [Intel-gfx] [PATCH] drm/i915: Introduce i915_dbg macro

2016-01-25 Thread Dave Gordon
On 25/01/16 18:17, Daniel Vetter wrote: On Fri, Jan 22, 2016 at 05:54:15PM +0530, akash.g...@intel.com wrote: From: Akash Goel Added a new macro i915_dbg, which is a wrapper over dev_dbg macro. dev_dbg allows use of dynamic debug framework, so offers a number of advantages over DRM_DEBUG to de

Re: [Intel-gfx] [PATCH] dim: Automatically sign-off patches from others

2016-01-25 Thread Daniel Vetter
On Mon, Jan 25, 2016 at 05:27:09PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > It is very easy to forget that commiters should sign-off > patches not authored by themselves. > > Signed-off-by: Tvrtko Ursulin > Cc: Daniel Vetter > --- > dim | 6 +- > 1 file changed, 5 insertion

Re: [Intel-gfx] Regression in v4.5-rc1, bisected to commit 39bfcd5235e0 ("drm/i915: more virtual south bridge detection")

2016-01-25 Thread Bruno Wolff III
On Mon, Jan 25, 2016 at 03:52:25 +0100, Bjørn Mork wrote: Hello, my oldish Thinkpad X301 only wanted to show a blank screen in v4.5-rc1. Bisecting resulted in: drm/i915: more virtual south bridge detection I am likely seeing the same problem on a Dell laptop. I haven't finished my bisec

[Intel-gfx] [PATCH] drm/i915: Remove select to deleted STOP_MACHINE from Kconfig

2016-01-25 Thread Andreas Ziegler
Commit 86fffe4a61dd ("kernel: remove stop_machine() Kconfig dependency") removed the option STOP_MACHINE from init/Kconfig, but missed a select to this option from the DRM_I915 option. Remove this now obsolete select statement. Signed-off-by: Andreas Ziegler --- drivers/gpu/drm/i915/Kconfig | 1

[Intel-gfx] Select on now-gone Kconfig option STOP_MACHINE

2016-01-25 Thread Andreas Ziegler
Hi Chris, your commit 5bab6f60cb4d ("drm/i915: Serialise updates to GGTT with access through GGTT on Braswell") added a select to STOP_MACHINE to the DRM_I915 Kconfig option. In 4.5-rc1, your commit 86fffe4a61dd ("kernel: remove stop_machine() Kconfig dependency") then removed STOP_MACHINE entire

[Intel-gfx] [PATCH v2] drm/i915: Remove select to deleted STOP_MACHINE from Kconfig

2016-01-25 Thread Andreas Ziegler
Commit 5bab6f60cb4d ("drm/i915: Serialise updates to GGTT with access through GGTT on Braswell") depended upon a working stop_machine() and so forced the selection of STOP_MACHINE. However, commit 86fffe4a61dd ("kernel: remove stop_machine() Kconfig dependency") removed the option STOP_MACHINE from

[Intel-gfx] regression bisected: display sync drops after 7221fc33

2016-01-25 Thread dann frazier
I've got a Lenovo T410 w/ an external display (DisplayPort<->HDMI). After upgrading from a 4.2 kernel to a 4.3, I started hitting an issue where the display thinks it has lost input for a few moments. Oddly, it usually happens when I start typing in a terminal after a short period of inactivity. I

[Intel-gfx] [PATCH 2/2] configure.ac: Add a configure arg for the overlay.

2016-01-25 Thread Eric Anholt
It's autodetected if its dependencies are present, but it doesn't build for ARM, nor am I interested in it for now. Signed-off-by: Eric Anholt --- configure.ac | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index ddfe696..41bf20d

[Intel-gfx] [PATCH 1/2] igt: Disable igt_clflush_range() implementation on ARM builds.

2016-01-25 Thread Eric Anholt
Daniel has suggested that I put vc4 testing into igt, since it's got the piglit integration and KMS coverage already. This gets the ccore building so that I can start writing tests. --- lib/igt_gt.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/igt_gt.c b/lib/igt_gt.c index 149435c.

[Intel-gfx] [PATCH i-g-t v3 1/2] lib/ioctl_wrappers: Add gem_gtt_type exposing raw HAS_ALIASING_PPGTT param

2016-01-25 Thread Michał Winiarski
No functional changes. While I'm here, let's also rename gem_uses_aliasing_ppgtt (since it's being used to indicate if we are using ANY kind of ppgtt) and introduce gem_uses_full_ppgtt to drop some unnecessary code from tests that were previously calling getparam directly instead of using ioctl wra

[Intel-gfx] [PATCH i-g-t v2 2/2] lib/ioctl_wrappers: Add gem_has_softpin

2016-01-25 Thread Michał Winiarski
We can move it from softpin test into lib, and since softpin support is highly unlikely to go away in-between getparam ioctl calls, let's just do a single call and store the value. v2: rebase Signed-off-by: Michał Winiarski Reviewed-by: Chris Wilson --- lib/ioctl_wrappers.c | 29 ++

Re: [Intel-gfx] [RFC] drm/i915: Render decompression support for Gen9 and above

2016-01-25 Thread Daniel Stone
Hi, On 25 January 2016 at 18:15, Smith, Gary K wrote: > I really do not understand what the issue is here. It’s a hint provided by > the user to indicate that the current fb (which was allocated with the > appropriate aux buffer/compression fb modifiers) has been entirely resolved > (uncompres

Re: [Intel-gfx] [PATCH] drm/i915: Don't ERROR for an expected intel_rcs_ctx_init() interruption

2016-01-25 Thread Dave Gordon
On 23/01/16 17:54, Chris Wilson wrote: intel_rcs_ctx_init() can be interrupted by a signal (if it has to wait upon a full ring to advance). Don't emit an error for this. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_ringbuffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 delet

Re: [Intel-gfx] [PATCH v2 0/8] Gen9 HW whitelist and Preemption WA patches

2016-01-25 Thread Arun Siluvery
On 25/01/2016 18:01, Daniel Vetter wrote: On Thu, Jan 21, 2016 at 04:07:22PM +, Arun Siluvery wrote: On 21/01/2016 15:17, Chris Wilson wrote: On Thu, Jan 21, 2016 at 02:00:39PM +, Arun Siluvery wrote: Resending all patches as told by Daniel because I didn't use correct message-id while

Re: [Intel-gfx] [PATCH v2 3/6] drm/i915: tidy up initialisation failure paths (legacy)

2016-01-25 Thread Daniel Vetter
On Mon, Jan 25, 2016 at 12:08:11PM +, Dave Gordon wrote: > On 25/01/16 10:52, Chris Wilson wrote: > >On Fri, Jan 22, 2016 at 11:10:08PM +, Dave Gordon wrote: > >>+ if (ringbuf) { > >>intel_stop_ring_buffer(ring); > >>- WARN_ON(!IS_GEN2(ring->dev) && (I915_READ_MODE(r

Re: [Intel-gfx] [PATCH v12] drm/i915: Extend LRC pinning to cover GPU context writeback

2016-01-25 Thread Daniel Vetter
On Fri, Jan 22, 2016 at 02:25:27PM +, Nick Hoath wrote: > Use the first retired request on a new context to unpin > the old context. This ensures that the hw context remains > bound until it has been written back to by the GPU. > Now that the context is pinned until later in the request/context

Re: [Intel-gfx] [PATCH] drm/i915: Introduce i915_dbg macro

2016-01-25 Thread Daniel Vetter
On Fri, Jan 22, 2016 at 05:54:15PM +0530, akash.g...@intel.com wrote: > From: Akash Goel > > Added a new macro i915_dbg, which is a wrapper over dev_dbg macro. > dev_dbg allows use of dynamic debug framework, so offers a number > of advantages over DRM_DEBUG to debug user space startup issues. >

Re: [Intel-gfx] [RFC] drm/i915: Render decompression support for Gen9 and above

2016-01-25 Thread Smith, Gary K
I really do not understand what the issue is here. It’s a hint provided by the user to indicate that the current fb (which was allocated with the appropriate aux buffer/compression fb modifiers) has been entirely resolved (uncompressed) and hence can be used anywhere an uncompressed fb would nor

Re: [Intel-gfx] [PATCH] drm/i915: Y/Yf Tiling Workaround for BXT/SKL

2016-01-25 Thread Daniel Vetter
On Fri, Jan 22, 2016 at 03:29:08PM +0530, Mayuresh Gharpure wrote: > BXT/SKL Bspec specifies a workaround of setting a bit of CHICKEN_DCPR_1 > register when one of the plane is enabled with a Y or Yf tiled buffer. > This patch implements this workaround > > Signed-off-by: Mayuresh Gharpure > ---

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Fix context/engine cleanup order

2016-01-25 Thread Daniel Vetter
On Thu, Jan 21, 2016 at 07:37:45PM +, Dave Gordon wrote: > From: Nick Hoath > > Swap the order of context & engine cleanup, so that contexts are cleaned > up first, and *then* engines. This is a more sensible order anyway, but > in particular has become necessary since the 'intel_ring_initial

Re: [Intel-gfx] [PATCH 1/4] drm/i915: handle teardown of HWSP when context is freed

2016-01-25 Thread Daniel Vetter
On Fri, Jan 22, 2016 at 02:51:50PM +, Dave Gordon wrote: > On 22/01/16 10:28, Mika Kuoppala wrote: > >Dave Gordon writes: > > > >>Existing code did a kunmap() on the wrong page, and didn't account for the > >>fact that the HWSP and the default context are different offsets within the > >>same

Re: [Intel-gfx] [PATCH 12/18] drm/i915: Reorganize intel_rotation_info

2016-01-25 Thread Ville Syrjälä
On Mon, Jan 25, 2016 at 06:38:57PM +0100, Daniel Vetter wrote: > On Wed, Jan 20, 2016 at 09:05:33PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Throw out a bunch of unnecessary stuff from struct intel_rotation_info, > > and pull most of the remaining stuff to live

Re: [Intel-gfx] [PATCH 1/3] drm/i915: add function for GT related workarounds

2016-01-25 Thread Arun Siluvery
On 25/01/2016 17:10, Chris Wilson wrote: On Mon, Jan 25, 2016 at 04:41:42PM +, Arun Siluvery wrote: On 25/01/2016 16:17, Chris Wilson wrote: On Mon, Jan 25, 2016 at 02:43:06PM +, Gore, Tim wrote: Tim Gore Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ

Re: [Intel-gfx] [PATCH] drm/i915: Improve handling of overlapping objects

2016-01-25 Thread Daniel Vetter
On Fri, Jan 22, 2016 at 04:47:28PM +0100, Michał Winiarski wrote: > On Thu, Jan 21, 2016 at 05:32:43PM +, Chris Wilson wrote: > > The generic interval tree we use to speed up range invalidation is an > > augmented rbtree that can report all overlapping intervals for a given > > range. Therefore

Re: [Intel-gfx] [PATCH v2 0/8] Gen9 HW whitelist and Preemption WA patches

2016-01-25 Thread Daniel Vetter
On Thu, Jan 21, 2016 at 04:07:22PM +, Arun Siluvery wrote: > On 21/01/2016 15:17, Chris Wilson wrote: > >On Thu, Jan 21, 2016 at 02:00:39PM +, Arun Siluvery wrote: > >>Resending all patches as told by Daniel because I didn't use correct > >>message-id while replying updated version of Patch

[Intel-gfx] [PATCH v2] Fix pointer tests in error-handling paths

2016-01-25 Thread Dave Gordon
In the error-handling paths of i915_gem_do_execbuffer() and intel_crtc_page_flip(), the local pointer-to-request variables were expected to be either valid pointers or NULL. Since 2682708 drm/i915: simplify allocation of driver-internal requests they could also be ERR_PTR() values, so the test

Re: [Intel-gfx] [PATCH v2 09/18] drm/i915: Support for extra alignment for tiled surfaces

2016-01-25 Thread Ville Syrjälä
On Mon, Jan 25, 2016 at 06:24:05PM +0100, Daniel Vetter wrote: > On Wed, Jan 20, 2016 at 09:05:30PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > SKL+ needs >4K alignment for tiled surfaces, so make > > intel_compute_page_offset() handle it. > > > > The way we do it

Re: [Intel-gfx] [PATCH 17/18] drm/i915: Pass around plane_state instead of fb+rotation

2016-01-25 Thread Daniel Vetter
On Wed, Jan 20, 2016 at 09:05:38PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > intel_compute_tile_offset() and intel_add_fb_offsets() get passed the fb > and the rotation. As both of those come from the plane state we can just > pass that in instead. > > For extra consi

Re: [Intel-gfx] [PATCH] Fix pointer tests in error-handling paths

2016-01-25 Thread Dave Gordon
On 22/01/16 13:34, Chris Wilson wrote: On Fri, Jan 22, 2016 at 01:17:44PM +, Tvrtko Ursulin wrote: On 22/01/16 13:01, Chris Wilson wrote: On Fri, Jan 22, 2016 at 12:19:32PM +, Dave Gordon wrote: In the error-handling paths of i915_gem_do_execbuffer() and intel_crtc_page_flip(), the lo

Re: [Intel-gfx] [PATCH v2 16/18] drm/i915: Don't pass pitch to intel_compute_page_offset()

2016-01-25 Thread Daniel Vetter
On Wed, Jan 20, 2016 at 09:05:37PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > intel_compute_page_offset() can dig up the correct pitch from the fb > itself, no need for the caller to pass it in. > > A bit of extra care is needed for the lower level > _intel_compute_pag

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Move load time stolen memory init earlier

2016-01-25 Thread Daniel Vetter
On Mon, Jan 25, 2016 at 07:34:08PM +0200, Imre Deak wrote: > On ma, 2016-01-25 at 17:21 +0100, Daniel Vetter wrote: > > On Tue, Jan 19, 2016 at 06:22:21PM +0200, Imre Deak wrote: > > > On ti, 2016-01-19 at 13:49 +, Patchwork wrote: > > > > == Summary == > > > > > > > > Built on 00a0c7d1ae09b12

Re: [Intel-gfx] [PATCH 14/18] drm/i915: Embed rotation_info under intel_framebuffer

2016-01-25 Thread Daniel Vetter
On Wed, Jan 20, 2016 at 09:05:35PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Instead of repopulatin the rotation_info struct for the fb every time > we try to use the fb, we can just populate it once when creating the fb, > and later we can just copy the pre-populate s

Re: [Intel-gfx] [PATCH 13/18] drm/i915: Move the NULL sg handling out from rotate_pages()

2016-01-25 Thread Daniel Vetter
On Wed, Jan 20, 2016 at 09:05:34PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > rotate_pages() checks to see if it got called with a NULL sg, and then > goes to extract it from sg->sgl. It always gets called with a NULL sg > for the first plane, so moving the initial 'sg=

Re: [Intel-gfx] [RFC] drm/i915: Render decompression support for Gen9 and above

2016-01-25 Thread Jesse Barnes
On 01/19/2016 02:28 AM, Daniel Stone wrote: >> > We aren't just talking about a few fbs here, we already see more than >> > 100 fbs active during complex situations. Potentially doubling this >> > number is surely a significant increase in memory usage, both from the >> > manage

Re: [Intel-gfx] [PATCH 12/18] drm/i915: Reorganize intel_rotation_info

2016-01-25 Thread Daniel Vetter
On Wed, Jan 20, 2016 at 09:05:33PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Throw out a bunch of unnecessary stuff from struct intel_rotation_info, > and pull most of the remaining stuff to live under an array of > per-color plane sub-structures. > > What still remai

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Move load time stolen memory init earlier

2016-01-25 Thread Imre Deak
On ma, 2016-01-25 at 17:21 +0100, Daniel Vetter wrote: > On Tue, Jan 19, 2016 at 06:22:21PM +0200, Imre Deak wrote: > > On ti, 2016-01-19 at 13:49 +, Patchwork wrote: > > > == Summary == > > > > > > Built on 00a0c7d1ae09b1259c7af8e5a088b0b225d805df drm-intel- > > > nightly: > > > 2016y-01m-18d

Re: [Intel-gfx] [PATCH v3 08/18] drm/i915: Pass 90/270 vs. 0/180 rotation info for intel_gen4_compute_page_offset()

2016-01-25 Thread Daniel Vetter
On Wed, Jan 20, 2016 at 09:05:29PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The page aligned surface address calculation needs to know which way > things are rotated. The contract now says that the caller must pass the > rotate x/y coordinates, as well as the tile_hei

[Intel-gfx] [PATCH] dim: Automatically sign-off patches from others

2016-01-25 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It is very easy to forget that commiters should sign-off patches not authored by themselves. Signed-off-by: Tvrtko Ursulin Cc: Daniel Vetter --- dim | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/dim b/dim index c749cebd1187..ff5d89ca5df8 100755

Re: [Intel-gfx] [PATCH v2 09/18] drm/i915: Support for extra alignment for tiled surfaces

2016-01-25 Thread Daniel Vetter
On Wed, Jan 20, 2016 at 09:05:30PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > SKL+ needs >4K alignment for tiled surfaces, so make > intel_compute_page_offset() handle it. > > The way we do it is first we compute the closest tile boundary > as before, and then figure o

Re: [Intel-gfx] [PATCH 05/18] drm/i915: Standardize on 'cpp' for bytes per pixel

2016-01-25 Thread Daniel Vetter
On Wed, Jan 20, 2016 at 09:05:26PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > We more or less randomly call the "bytes per pixel" value > 'cpp', 'bytes_per_pixel', 'pixel_size', or even 'bpp'. Let's just pick > one and stick to it. I've chosen 'cpp'. > > Signed-off-by:

Re: [Intel-gfx] [PATCH 07/18] drm/i915: Fix intel_tile_width() parameters

2016-01-25 Thread Daniel Vetter
On Wed, Jan 20, 2016 at 09:05:28PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The fb_modifiers and cpp arguments passed to intel_tile_width() in > intel_fill_fb_ggtt_view() got accidentally swapped around. I'm pretty > sure I fixed this already, but could be I lost the

Re: [Intel-gfx] [PATCH 1/3] drm/i915: add function for GT related workarounds

2016-01-25 Thread Chris Wilson
On Mon, Jan 25, 2016 at 04:41:42PM +, Arun Siluvery wrote: > On 25/01/2016 16:17, Chris Wilson wrote: > >On Mon, Jan 25, 2016 at 02:43:06PM +, Gore, Tim wrote: > >> > >> > >>Tim Gore > >>Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 > >>1RJ > >> > >> > >>>-O

Re: [Intel-gfx] [PATCH v2 06/18] drm: Add drm_format_plane_width() and drm_format_plane_height()

2016-01-25 Thread Daniel Vetter
On Wed, Jan 20, 2016 at 09:05:27PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Add a few helpers to get the dimensions of the chroma plane(s). > > v2: Add kernel-doc (Daniel) > > Cc: dri-de...@lists.freedesktop.org > Signed-off-by: Ville Syrjälä > Reviewed-by: Daniel

Re: [Intel-gfx] [PATCH] Fix pointer tests in error-handling paths

2016-01-25 Thread Tvrtko Ursulin
On 25/01/16 16:28, Daniel Vetter wrote: On Fri, Jan 22, 2016 at 01:07:48PM +, Tvrtko Ursulin wrote: On 22/01/16 12:19, Dave Gordon wrote: In the error-handling paths of i915_gem_do_execbuffer() and intel_crtc_page_flip(), the local pointer-to-request variables were expected to be either v

Re: [Intel-gfx] [PATCH 04/18] drm/i915: Make display gtt offsets u32

2016-01-25 Thread Daniel Vetter
On Wed, Jan 20, 2016 at 09:05:25PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Using 'unsigned long' for ggtt offsets doesn't make much sense. Use > 'u32' instead since we've not yet seen a >4GiB ggtt. > > Signed-off-by: Ville Syrjälä I hunted down every occurenve of

Re: [Intel-gfx] [PATCH 03/18] drm/i915: Pass rotation_info to intel_rotate_fb_obj_pages()

2016-01-25 Thread Daniel Vetter
On Wed, Jan 20, 2016 at 09:05:24PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > intel_rotate_fb_obj_pages() doens't need the entire gtt view, just the > rotation info suffices. > > Signed-off-by: Ville Syrjälä Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/i915/

Re: [Intel-gfx] [PATCH 02/18] drm/i915: Pass stride to rotate_pages()

2016-01-25 Thread Daniel Vetter
On Wed, Jan 20, 2016 at 09:05:23PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Pass stride in addition to width and height to rotate_pages(). For now > width and stride are the same, but once framebuffer offsets enter the > scene that may no longer be the case. > > Sign

Re: [Intel-gfx] [PATCH 01/18] drm/i915: Rename the rotated gtt view member to 'rotated'

2016-01-25 Thread Daniel Vetter
On Wed, Jan 20, 2016 at 09:05:22PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Also rename 'rotation_info' to 'rotated' to match the view type exactly, > this should avoid confusion which union members is valid for each view > type. > > Signed-off-by: Ville Syrjälä As

Re: [Intel-gfx] [PATCH 1/3] drm/i915: add function for GT related workarounds

2016-01-25 Thread Arun Siluvery
On 25/01/2016 16:17, Chris Wilson wrote: On Mon, Jan 25, 2016 at 02:43:06PM +, Gore, Tim wrote: Tim Gore Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ -Original Message- From: Mika Kuoppala [mailto:mika.kuopp...@linux.intel.com] Sent: Monday, Janu

Re: [Intel-gfx] [PATCH i-g-t 1/2 v2] lib/ioctl_wrappers: Add gem_gtt_type exposing raw HAS_ALIASING_PPGTT param

2016-01-25 Thread Daniel Vetter
On Thu, Jan 21, 2016 at 10:27:26AM +0100, Michał Winiarski wrote: > No functional changes. > While I'm here, let's also rename gem_uses_aliasing_ppgtt (since it's > being used to indicate if we are using ANY kind of ppgtt) and introduce > gem_uses_full_ppgtt to drop some unnecessary code from tests

Re: [Intel-gfx] [PATCH] Fix pointer tests in error-handling paths

2016-01-25 Thread Daniel Vetter
On Fri, Jan 22, 2016 at 01:07:48PM +, Tvrtko Ursulin wrote: > > On 22/01/16 12:19, Dave Gordon wrote: > >In the error-handling paths of i915_gem_do_execbuffer() and > >intel_crtc_page_flip(), the local pointer-to-request variables > >were expected to be either valid pointers or NULL. Since > >

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Move load time stolen memory init earlier

2016-01-25 Thread Daniel Vetter
On Tue, Jan 19, 2016 at 06:22:21PM +0200, Imre Deak wrote: > On ti, 2016-01-19 at 13:49 +, Patchwork wrote: > > == Summary == > > > > Built on 00a0c7d1ae09b1259c7af8e5a088b0b225d805df drm-intel-nightly: > > 2016y-01m-18d-16h-50m-37s UTC integration manifest > > > > Test gem_ctx_basic: > >    

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for FBC crtc/fb locking + smaller fixes

2016-01-25 Thread Daniel Vetter
On Fri, Jan 22, 2016 at 11:28:07AM +, Damien Lespiau wrote: > On Thu, Jan 21, 2016 at 08:14:34PM +, Zanoni, Paulo R wrote: > > Em Ter, 2016-01-19 às 14:50 +, Patchwork escreveu: > > > == Summary == > > > > > > Built on 20c388faff9d8c41ab27e825c685526561b892a2 drm-intel-nightly: > > > 2

Re: [Intel-gfx] [PATCH 0/9] Support blending modes of display planes

2016-01-25 Thread Daniel Vetter
On Thu, Jan 21, 2016 at 04:31:40PM -0800, Matt Roper wrote: > On Mon, Jan 18, 2016 at 08:45:34PM +0530, Vandita Kulkarni wrote: > > From: vandita kulkarni > > > > The below patches support plane and pixel blending > > by adding two properties blend_func and blend_color. > > As per Damien's initia

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_kms: Add COMIT_ATOMIC to igt_display_commit2()

2016-01-25 Thread Daniel Vetter
On Fri, Jan 22, 2016 at 08:00:10AM -0800, Matt Roper wrote: > On Thu, Jan 21, 2016 at 09:43:14PM -0800, Palleti, Avinash Reddy wrote: > > Thanks Matt for pointing me to this. > > > > Vlad, > > As Matt mentioned, we are also working on this to get atomic support in > > i-g-t. Last week we finalize

Re: [Intel-gfx] [PATCH 1/3] drm/i915: add function for GT related workarounds

2016-01-25 Thread Chris Wilson
On Mon, Jan 25, 2016 at 02:43:06PM +, Gore, Tim wrote: > > > Tim Gore  > Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ > > > > -Original Message- > > From: Mika Kuoppala [mailto:mika.kuopp...@linux.intel.com] > > Sent: Monday, January 25, 2016 2:39 PM

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Allow i915_gem_object_get_page() on userptr as well (rev2)

2016-01-25 Thread Daniel Vetter
On Sat, Jan 23, 2016 at 07:13:55AM -, Patchwork wrote: > == Summary == > > Built on 8fe9e785ae04fa7c37f7935cff12d62e38054b60 drm-intel-nightly: > 2016y-01m-21d-11h-02m-42s UTC integration manifest > > Test kms_flip: > Subgroup basic-flip-vs-dpms: > pass -> DMESG

Re: [Intel-gfx] [PATCH 10/20] drm/i915: Watchdog timeout: DRM kernel interface enablement

2016-01-25 Thread Daniel Vetter
On Fri, Jan 22, 2016 at 02:08:32PM +, Arun Siluvery wrote: > On 22/01/2016 13:59, Chris Wilson wrote: > >On Fri, Oct 23, 2015 at 02:32:32AM +0100, Tomas Elf wrote: > >>Final enablement patch for GPU hang recovery using watchdog timeout. > >>Added execbuf flag for watchdog timeout in DRM kernel

Re: [Intel-gfx] [PATCH v4] drm/i915/guc: Clean up locks in GuC

2016-01-25 Thread Daniel Vetter
On Fri, Jan 22, 2016 at 10:54:42AM +, Tvrtko Ursulin wrote: > > On 03/12/15 00:56, yu@intel.com wrote: > > From: Alex Dai > > > > For now, remove the spinlocks that protected the GuC's > > statistics block and work queue; they are only accessed > > by code that already holds the global s

Re: [Intel-gfx] [PATCH] drm/crtc-helper: Add caveat to disable_unused_functions doc

2016-01-25 Thread Daniel Vetter
On Wed, Jan 13, 2016 at 03:31:16PM +0100, Daniel Vetter wrote: > This shouldn't be used by atomic drivers any more, it confuses the > state tracking. > > Cc: Maxime Ripard > Cc: Laurent Pinchart > Acked-by: Laurent Pinchart > Signed-off-by: Daniel Vetter Applied this one to drm-misc. -Daniel

Re: [Intel-gfx] ✗ warning: Fi.CI.BAT

2016-01-25 Thread Daniel Vetter
On Wed, Jan 13, 2016 at 02:57:33PM -, Patchwork wrote: > == Summary == > > Built on 4d09810b01441f9124c072a866f608b748f92f6c drm-intel-nightly: > 2016y-01m-13d-12h-32m-08s UTC integration manifest > > Test gem_storedw_loop: > Subgroup basic-render: > pass -> DME

  1   2   >