[Intel-gfx] [PATCH] [v2] drm/i915: Check for get_pages instead of shmem (filp)

2016-02-09 Thread Ben Widawsky
This behavior of checking for a shmem backed GEM object was introduced here: commit 4c914c0c7c787b8f730128a8cdcca9c50b0784ab Author: Brad Volkin Date: Tue Feb 18 10:15:45 2014 -0800 drm/i915: Refactor shmem pread setup It is possible for an object to not be a

Re: [Intel-gfx] [PATCH v3 5/5] drm/atomic: Add encoder_mask to crtc_state, v3.

2016-02-09 Thread Daniel Vetter
On Wed, Feb 03, 2016 at 10:45:07AM -0200, Gustavo Padovan wrote: > Hi Maarten, > > 2016-01-28 Maarten Lankhorst : > > > This allows iteration over encoders without requiring connection_mutex. > > > > Changes since v1: > > - Add a set_best_encoder helper

Re: [Intel-gfx] [PATCH v3 06/18] drm: Add drm_format_plane_width() and drm_format_plane_height()

2016-02-09 Thread Daniel Vetter
On Fri, Jan 29, 2016 at 08:01:19PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Add a few helpers to get the dimensions of the chroma plane(s). > > v2: Add kernel-doc (Daniel) > v3: Fix kerneldoc "Returns:" style (Daniel) > Uninline

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/skl: Don't skip mst encoders in skl_ddi_pll_select()

2016-02-09 Thread Daniel Vetter
On Tue, Feb 02, 2016 at 10:49:43AM -0500, Lyude wrote: > We don't actually check for INTEL_OUTPUT_DP_MST at all in here, as a > result we skip assigning a DPLL to any DP MST ports, which makes link > training fail: > > [ 1442.933896] [drm:intel_power_well_enable] enabling DDI D power well > [

Re: [Intel-gfx] [PATCH] drm/i915: Skip DDI PLL selection for DSI

2016-02-09 Thread Ville Syrjälä
On Tue, Feb 09, 2016 at 01:16:18PM +0530, Thulasimani, Sivakumar wrote: > > > On 2/9/2016 12:02 PM, Jani Nikula wrote: > > On Tue, 09 Feb 2016, "Thulasimani, Sivakumar" > > wrote: > >> On 2/5/2016 4:59 PM, Mika Kahola wrote: > >>> Skip DDI PLL selection if

Re: [Intel-gfx] [REGRESSION] i915: No HDMI output with 4.4

2016-02-09 Thread Daniel Vetter
On Mon, Feb 08, 2016 at 12:17:07PM +0200, Oleksandr Natalenko wrote: > Hi. > > With Linux 4.4 external HDMI-attached monitor in not discovered by i915 > driver. Here is boot log related to drm and i915 for Linux 4.4/4.4.1 kernel: > > === > kernel: [drm] Initialized drm 1.1.0 20060810 > kernel:

Re: [Intel-gfx] [PATCH v2 2/9] drm/i915: Kill off intel_crtc->atomic.wait_vblank, v3.

2016-02-09 Thread Maarten Lankhorst
Hey, Op 13-01-16 om 13:58 schreef Ville Syrjälä: > On Mon, Jan 11, 2016 at 01:27:42PM +0100, Maarten Lankhorst wrote: >> Currently we perform our own wait in post_plane_update, >> but the atomic core performs another one in wait_for_vblanks. >> This means that 2 vblanks are done when a fb is

[Intel-gfx] [PATCH i-g-t] lib: Only compile igt_vc4 is we have it

2016-02-09 Thread Daniel Vetter
Unbreaks compilation fail. Also appease gcc in gem_exec_basic because. Cc: Eric Anholt Signed-off-by: Daniel Vetter --- lib/Makefile.am| 6 ++ lib/Makefile.sources | 2 -- tests/gem_exec_basic.c | 1 - 3 files changed, 6 insertions(+), 3

Re: [Intel-gfx] [PATCH] drm/i915: Pretend cursor is always on for ILK-style WM calculations (v2)

2016-02-09 Thread Jani Nikula
On Mon, 08 Feb 2016, Matt Roper wrote: > Due to our lack of two-step watermark programming, our driver has > historically pretended that the cursor plane is always on for the > purpose of watermark calculations; this helps avoid serious flickering > when the cursor

Re: [Intel-gfx] [PATCH v2 1/6] drm/i915: Use atomic state to obtain load detection crtc, v2.

2016-02-09 Thread Maarten Lankhorst
Op 03-02-16 om 17:34 schreef Ville Syrjälä: > On Wed, Feb 03, 2016 at 09:57:55AM +0100, Maarten Lankhorst wrote: >> Op 02-02-16 om 18:32 schreef Ville Syrjälä: >>> On Tue, Feb 02, 2016 at 01:48:17PM +0100, Maarten Lankhorst wrote: drm/i915: Use atomic state to obtain load detection crtc, v2.

Re: [Intel-gfx] [PATCH] drm/i915/skl: Fix typo in DPLL_CFGCR1 definition

2016-02-09 Thread Daniel Vetter
On Thu, Feb 04, 2016 at 06:11:28PM +0200, Ville Syrjälä wrote: > On Thu, Feb 04, 2016 at 10:43:21AM -0500, Lyude wrote: > > We accidentally point both cfgcr registers for the second shared DPLL to > > the same location in i915_reg.h. This results in a lot of hw pipe state > > mismatches whenever

Re: [Intel-gfx] [PATCH v5 00/12] Enable GPU switching on pre-retina MacBook Pro

2016-02-09 Thread Daniel Vetter
On Mon, Feb 08, 2016 at 10:10:00AM -0800, Darren Hart wrote: > On Mon, Jan 11, 2016 at 08:09:20PM +0100, Lukas Wunner wrote: > > Enable GPU switching on the pre-retina MacBook Pro (2008 - 2013), v5. > > > > The main obstacle on these machines is that the panel mode in VBIOS > > is bogus.

Re: [Intel-gfx] [PATCH v2 2/9] drm/i915: Kill off intel_crtc->atomic.wait_vblank, v3.

2016-02-09 Thread Ville Syrjälä
On Tue, Feb 09, 2016 at 11:27:44AM +0100, Maarten Lankhorst wrote: > Hey, > > Op 13-01-16 om 13:58 schreef Ville Syrjälä: > > On Mon, Jan 11, 2016 at 01:27:42PM +0100, Maarten Lankhorst wrote: > >> Currently we perform our own wait in post_plane_update, > >> but the atomic core performs another

Re: [Intel-gfx] [PATCH v2 2/9] drm/i915: Kill off intel_crtc->atomic.wait_vblank, v3.

2016-02-09 Thread Maarten Lankhorst
Op 09-02-16 om 11:42 schreef Ville Syrjälä: > On Tue, Feb 09, 2016 at 11:27:44AM +0100, Maarten Lankhorst wrote: >> Hey, >> >> Op 13-01-16 om 13:58 schreef Ville Syrjälä: >>> On Mon, Jan 11, 2016 at 01:27:42PM +0100, Maarten Lankhorst wrote: Currently we perform our own wait in

Re: [Intel-gfx] [PATCH v2 2/9] drm/i915: Kill off intel_crtc->atomic.wait_vblank, v3.

2016-02-09 Thread Ville Syrjälä
On Tue, Feb 09, 2016 at 12:07:01PM +0100, Maarten Lankhorst wrote: > Op 09-02-16 om 11:42 schreef Ville Syrjälä: > > On Tue, Feb 09, 2016 at 11:27:44AM +0100, Maarten Lankhorst wrote: > >> Hey, > >> > >> Op 13-01-16 om 13:58 schreef Ville Syrjälä: > >>> On Mon, Jan 11, 2016 at 01:27:42PM +0100,

Re: [Intel-gfx] [PATCH v5 10/12] drm/i915: Defer probe if gmux is present but its driver isn't

2016-02-09 Thread Daniel Vetter
On Mon, Jan 11, 2016 at 08:09:20PM +0100, Lukas Wunner wrote: > gmux is a microcontroller built into dual GPU MacBook Pros. > On pre-retina MBPs, if we're the inactive GPU, we need apple-gmux > to temporarily switch DDC so that we can probe the panel's EDID. > > The checks for CONFIG_VGA_ARB and

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Use atomic helpers for suspend.

2016-02-09 Thread Ville Syrjälä
On Tue, Feb 09, 2016 at 03:05:51PM +0100, Maarten Lankhorst wrote: > Op 09-02-16 om 14:37 schreef Ville Syrjälä: > > On Tue, Feb 09, 2016 at 01:52:22PM +0100, Maarten Lankhorst wrote: > >> Instead of duplicating the functionality now that we no longer need > >> to preserve dpll state we can move

Re: [Intel-gfx] [PATCH RESEND 1/5] drm/i915: move VBT based TV presence check to intel_bios.c

2016-02-09 Thread Jani Nikula
On Mon, 08 Feb 2016, "Thulasimani, Sivakumar" wrote: > On 2/5/2016 4:06 PM, Jani Nikula wrote: >> Hide knowledge about VBT child devices in intel_bios.c. >> >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/i915/i915_drv.h | 1 +

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Use atomic helpers for suspend.

2016-02-09 Thread Maarten Lankhorst
Op 09-02-16 om 14:37 schreef Ville Syrjälä: > On Tue, Feb 09, 2016 at 01:52:22PM +0100, Maarten Lankhorst wrote: >> Instead of duplicating the functionality now that we no longer need >> to preserve dpll state we can move to using the upstream suspend helper. >> >> Signed-off-by: Maarten Lankhorst

Re: [Intel-gfx] [PATCH RESEND 2/5] drm/i915: move VBT based LVDS presence check to intel_bios.c

2016-02-09 Thread Jani Nikula
On Mon, 08 Feb 2016, "Thulasimani, Sivakumar" wrote: > On 2/5/2016 4:06 PM, Jani Nikula wrote: >> Hide knowledge about VBT child devices in intel_bios.c. >> >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/i915/i915_drv.h | 1 +

Re: [Intel-gfx] [PATCH i-g-t] lib: Fix build when vc4 headers are present

2016-02-09 Thread Daniel Vetter
On Tue, Feb 09, 2016 at 03:45:37PM +0100, Tomeu Vizoso wrote: > Automake seems to not like variable assignments indented with tabs. > > Signed-off-by: Tomeu Vizoso > Fixes: 9e5478dc4345 ("lib: Only compile igt_vc4 is we have it") Yay, I'm incompetent. Thanks for

[Intel-gfx] [PATCH v2 4/6] drm/i915: move VBT based DSI presence check to intel_bios.c

2016-02-09 Thread Jani Nikula
Hide knowledge about VBT child devices in intel_bios.c. v2: Move port check to intel_bios.c (Sivakumar) Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/intel_bios.c | 39 ++-

[Intel-gfx] [PATCH v2 1/6] drm/i915: move VBT based TV presence check to intel_bios.c

2016-02-09 Thread Jani Nikula
Hide knowledge about VBT child devices in intel_bios.c. v2: also move int_tv_support check to intel_bios.c (Sivakumar) Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_bios.c | 41 ++

Re: [Intel-gfx] [PATCH RESEND 4/5] drm/i915: move VBT based DSI presence check to intel_bios.c

2016-02-09 Thread Jani Nikula
On Mon, 08 Feb 2016, "Thulasimani, Sivakumar" wrote: > On 2/5/2016 4:06 PM, Jani Nikula wrote: >> Hide knowledge about VBT child devices in intel_bios.c. >> >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/i915/i915_drv.h | 2

Re: [Intel-gfx] [PATCH i-g-t v3] lib/igt_core.c: Expand --run-subtest functionality.

2016-02-09 Thread Dave Gordon
On 04/02/16 12:06, Derek Morton wrote: Added extended wildcard support when specifying --run-subtest. Wildcard format is as specified in rfc3977 and the uwildmat() implementation is taken from libinn. See https://tools.ietf.org/html/rfc3977#section-4 for a description of allowed wildcard

[Intel-gfx] [PATCH i-g-t] lib: Fix build when vc4 headers are present

2016-02-09 Thread Tomeu Vizoso
Automake seems to not like variable assignments indented with tabs. Signed-off-by: Tomeu Vizoso Fixes: 9e5478dc4345 ("lib: Only compile igt_vc4 is we have it") --- lib/Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Intel-gfx] [PATCH v4] drm/i915/execlists: Move WA_TAIL_DWORDS to callee

2016-02-09 Thread Dave Gordon
From: Chris Wilson Currently emit-request starts writing to the ring and reserves space for a workaround to be emitted later whilst submitting the request. It is easier to read if the caller only allocates sufficient space for its access (then the reader can quickly

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/execlists: Move WA_TAIL_DWORDS to callee (rev2)

2016-02-09 Thread Patchwork
== Summary == Series 3133v2 drm/i915/execlists: Move WA_TAIL_DWORDS to callee http://patchwork.freedesktop.org/api/1.0/series/3133/revisions/2/mbox/ Test drv_module_reload_basic: pass -> DMESG-WARN (ilk-hp8440p) Test gem_mmap_gtt: Subgroup basic-small-bo:

[Intel-gfx] [PATCH v4 06/18] drm: Add drm_format_plane_width() and drm_format_plane_height()

2016-02-09 Thread ville . syrjala
From: Ville Syrjälä Add a few helpers to get the dimensions of the chroma plane(s). v2: Add kernel-doc (Daniel) v3: Fix kerneldoc "Returns:" style (Daniel) Uninline the functions and check for num_planes (Daniel) v4: Add the required EXPORT_SYMBOL()s Cc:

[Intel-gfx] [PATCH v2 2/6] drm/i915: move VBT based LVDS presence check to intel_bios.c

2016-02-09 Thread Jani Nikula
Hide knowledge about VBT child devices in intel_bios.c. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_bios.c | 50 drivers/gpu/drm/i915/intel_lvds.c | 53

[Intel-gfx] [PATCH v2 5/6] drm/i915/panel: setup pwm backlight based on connector type

2016-02-09 Thread Jani Nikula
Use the connector type instead of VBT directly to decide which backlight mechanism to use on VLV/CHV. (Indirectly, this is the same thing, but hides the VBT use.) Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_panel.c | 2 +- 1 file changed, 1 insertion(+), 1

[Intel-gfx] [PATCH v2 3/6] drm/i915: move VBT based eDP port check to intel_bios.c

2016-02-09 Thread Jani Nikula
Hide knowledge about VBT child devices in intel_bios.c. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_bios.c | 33 + drivers/gpu/drm/i915/intel_dp.c | 21 + 3 files

[Intel-gfx] [PATCH v2 6/6] drm/i915/bios: drop has_mipi in favor of intel_bios_is_dsi_present

2016-02-09 Thread Jani Nikula
Favor a single point of truth instead of duplicating the information. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 1 - drivers/gpu/drm/i915/intel_bios.c | 12 +++- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git

Re: [Intel-gfx] [PATCH] drm/i915: Check for get_pages instead of shmem (filp)

2016-02-09 Thread Dave Gordon
On 09/02/16 00:20, Kristian Høgsberg wrote: On Fri, Feb 5, 2016 at 5:48 PM, Ben Widawsky wrote: This behavior of checking for a shmem backed GEM object was introduced here: commit 4c914c0c7c787b8f730128a8cdcca9c50b0784ab Author: Brad Volkin

[Intel-gfx] ✗ Fi.CI.BAT: failure for Pipe level color management (rev4)

2016-02-09 Thread Patchwork
== Summary == Series 2720v4 Pipe level color management http://patchwork.freedesktop.org/api/1.0/series/2720/revisions/4/mbox/ Test kms_flip: Subgroup basic-flip-vs-dpms: pass -> DMESG-WARN (ilk-hp8440p) UNSTABLE Subgroup basic-flip-vs-wf_vblank:

[Intel-gfx] [PATCH 1/3] drm/i915: Clear shared dpll based on old state.

2016-02-09 Thread Maarten Lankhorst
Atomic resume was preserving the dpll state because it was required for clearing pll state correctly. If we look at the old_crtc_state for pll to clear this is not needed and the hack can be removed. Signed-off-by: Maarten Lankhorst ---

[Intel-gfx] [PATCH 3/3] drm/i915: Use atomic state to obtain load detection crtc, v3.

2016-02-09 Thread Maarten Lankhorst
Instead of restoring dpms and a flag for whether a temp fb is allocated duplicate an atomic state before the new state is committed, and commit it the old state in intel_release_load_detect_pipe. Changes since v1: - Use a real atomic state. (Ville) Changes since v2: - Do not preserve shared_dpll

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Clear shared dpll based on old state.

2016-02-09 Thread Ville Syrjälä
On Tue, Feb 09, 2016 at 01:52:21PM +0100, Maarten Lankhorst wrote: > Atomic resume was preserving the dpll state because it was required > for clearing pll state correctly. If we look at the old_crtc_state > for pll to clear this is not needed and the hack can be removed. > > Signed-off-by:

Re: [Intel-gfx] [RFC 00/22] Add support for GuC-based SLPC

2016-02-09 Thread Martin Peres
On 21/01/16 04:26, tom.orou...@intel.com wrote: From: Tom O'Rourke SLPC (Single Loop Power Controller) is a replacement for some host-based power management features. The SLPC implemenation runs in firmware on GuC. This series is a first request for comments. This

[Intel-gfx] [PATCH 2/3] drm/i915: Use atomic helpers for suspend.

2016-02-09 Thread Maarten Lankhorst
Instead of duplicating the functionality now that we no longer need to preserve dpll state we can move to using the upstream suspend helper. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_atomic_helper.c | 3 + drivers/gpu/drm/i915/i915_drv.c

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Use atomic helpers for suspend.

2016-02-09 Thread Ville Syrjälä
On Tue, Feb 09, 2016 at 01:52:22PM +0100, Maarten Lankhorst wrote: > Instead of duplicating the functionality now that we no longer need > to preserve dpll state we can move to using the upstream suspend helper. > > Signed-off-by: Maarten Lankhorst > --- >

Re: [Intel-gfx] [RFC 00/22] Add support for GuC-based SLPC

2016-02-09 Thread Martin Peres
On 26/01/16 19:00, Daniel Vetter wrote: On Tue, Jan 26, 2016 at 07:45:42AM -0800, Jesse Barnes wrote: On 01/22/2016 09:00 AM, Daniel Vetter wrote: On Wed, Jan 20, 2016 at 06:26:02PM -0800, tom.orou...@intel.com wrote: From: Tom O'Rourke I'd say we need to keep the

[Intel-gfx] [PATCH 0/6] Pipe level color management V4

2016-02-09 Thread Lionel Landwerlin
This series introduces pipe level color management through a set of properties attached to the CRTC. It also provides an implementation for some Intel platforms. This series is based of a previous set of patches by Shashank Sharma. Cheers, Lionel Lionel Landwerlin (6): drm/i915: Extract out

[Intel-gfx] [PATCH 5/6] drm/i915: Implement color management on bdw/skl/bxt/kbl

2016-02-09 Thread Lionel Landwerlin
Patch based on a previous series by Shashank Sharma. v2: Do not read GAMMA_MODE register to figure what mode we're in v3: Program PREC_PAL_GC_MAX to clamp pixel values > 1.0 Add documentation on how the Broadcast RGB property is affected by CTM_MATRIX v4: Update contributors

[Intel-gfx] [PATCH 2/6] drm: introduce color correction properties

2016-02-09 Thread Lionel Landwerlin
Patch based on a previous series by Shashank Sharma. v2: Register LUT size properties as range v3: Fix round in drm_color_lut_get_value() helper More docs on how degamma/gamma properties are used v4: Update contributors Signed-off-by: Shashank Sharma

[Intel-gfx] [PATCH 3/6] drm/i915: enable CSC for pipe C

2016-02-09 Thread Lionel Landwerlin
Patch based on a previous series by Shashank Sharma. v2: Update contributors Signed-off-by: Shashank Sharma Signed-off-by: Lionel Landwerlin Signed-off-by: Kumar, Kiran S Signed-off-by: Kausal Malladi

[Intel-gfx] [PATCH 1/6] drm/i915: Extract out gamma table and CSC to their own file

2016-02-09 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/intel_color.c | 174 +++ drivers/gpu/drm/i915/intel_display.c | 163 +++-

[Intel-gfx] [PATCH 4/6] drm/i915: enable legacy palette for pipe C

2016-02-09 Thread Lionel Landwerlin
Patch based on a previous series by Shashank Sharma. v2: Update contributors Signed-off-by: Shashank Sharma Signed-off-by: Lionel Landwerlin Signed-off-by: Kumar, Kiran S Signed-off-by: Kausal Malladi

[Intel-gfx] [PATCH 6/6] drm/i915: Implement color management on chv

2016-02-09 Thread Lionel Landwerlin
Patch based on a previous series by Shashank Sharma. v2: Update contributors Signed-off-by: Shashank Sharma Signed-off-by: Lionel Landwerlin Signed-off-by: Kumar, Kiran S Signed-off-by: Kausal Malladi

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add Backlight Control using DPCD for eDP connectors (v6)

2016-02-09 Thread Adebisi, YetundeX
> -Original Message- > From: Thulasimani, Sivakumar > Sent: Monday, February 08, 2016 8:57 AM > To: Adebisi, YetundeX; intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add Backlight Control using > DPCD for eDP connectors (v6) > > > >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add Backlight Control using DPCD for eDP connectors (v6)

2016-02-09 Thread Thulasimani, Sivakumar
On 2/9/2016 6:41 PM, Adebisi, YetundeX wrote: -Original Message- From: Thulasimani, Sivakumar Sent: Monday, February 08, 2016 8:57 AM To: Adebisi, YetundeX; intel-gfx@lists.freedesktop.org Cc: Nikula, Jani Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add Backlight Control using

Re: [Intel-gfx] [PATCH] drm/i915: Skip DDI PLL selection for DSI

2016-02-09 Thread Jani Nikula
On Tue, 09 Feb 2016, Ville Syrjälä wrote: > On Tue, Feb 09, 2016 at 01:16:18PM +0530, Thulasimani, Sivakumar wrote: >> >> >> On 2/9/2016 12:02 PM, Jani Nikula wrote: >> > On Tue, 09 Feb 2016, "Thulasimani, Sivakumar" >> > wrote:

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/6] drm/i915: move VBT based TV presence check to intel_bios.c

2016-02-09 Thread Patchwork
== Summary == Series 3202v1 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/3202/revisions/1/mbox/ Test core_prop_blob: Subgroup basic: pass -> INCOMPLETE (skl-i5k-2) Test drv_getparams_basic: Subgroup basic-eu-total:

Re: [Intel-gfx] [PATCH] lib/igt_kms: Add COMMIT_ATOMIC to igt_display_commit2()

2016-02-09 Thread Marius Vlad
Hi, When submiting the patch you should add i-g-t to your subject. See CONTRIBUTING file on how to set that. Also when submiting a new version you should add the version to the subject. [PATCH i-g-t vX] I've made some additional small nitpicks when these

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Handle fb->offsets[] and rewrite fb rotation handling to be more generic (v2) (rev3)

2016-02-09 Thread Patchwork
== Summary == Series 2679v3 drm/i915: Handle fb->offsets[] and rewrite fb rotation handling to be more generic (v2) 2016-02-09T15:30:40.543598 http://patchwork.freedesktop.org/api/1.0/series/2679/revisions/3/mbox/ Applying: drm/i915: Rename the rotated gtt view member to 'rotated' Using index

[Intel-gfx] [PATCH 0/5] pre-decrement in error paths considered harmful

2016-02-09 Thread Rasmus Villemoes
There are a few instances of for (i = 0; i < FOO; ++i) { ret = do_stuff(i) if (ret) goto err; } ... err: while (--i) undo_stuff(i); At best, this fails to undo_stuff for i==0, but if i==0 was the case that failed, we'll end up with an "infinite" loop in the error path

[Intel-gfx] [PATCH 2/5] drm/i915: fix error path in intel_setup_gmbus()

2016-02-09 Thread Rasmus Villemoes
This fails to undo the setup for pin==0; moreover, something interesting happens if the setup failed already at pin==0. Signed-off-by: Rasmus Villemoes --- drivers/gpu/drm/i915/intel_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Intel-gfx] [PATCH 2/5] drm/i915: fix error path in intel_setup_gmbus()

2016-02-09 Thread Jani Nikula
On Tue, 09 Feb 2016, Rasmus Villemoes wrote: > This fails to undo the setup for pin==0; moreover, something > interesting happens if the setup failed already at pin==0. > > Signed-off-by: Rasmus Villemoes > --- >

[Intel-gfx] [PATCH V3] drm/i915/skl: SKL CDCLK change on modeset tracking VCO

2016-02-09 Thread clinton . a . taylor
From: Clint Taylor Track VCO frequency of SKL instead of the boot CDCLK and allow modeset to set cdclk based on the max required pixel clock based on VCO selected. The vco should be tracked at the atomic level and all CRTCs updated if the required vco is changed. At

Re: [Intel-gfx] Intel graphics on Thinkpad T540p is most unsuable now :( (Intel(R) HD Graphics 4600)

2016-02-09 Thread Marc MERLIN
On Sat, Jan 09, 2016 at 04:07:05PM -0800, Marc MERLIN wrote: > On Fri, Jan 08, 2016 at 09:42:24AM -0800, Marc MERLIN wrote: > > On Sun, Jan 03, 2016 at 08:04:27AM -0800, Marc MERLIN wrote: > > > My hunch at this point is that google-chrome-beta is taxing the GPU and > > > causing the driver to

[Intel-gfx] [PATCH] drm/i915/guc: Set init value for cached work queue head

2016-02-09 Thread yu . dai
From: Alex Dai The cached work queue header pointer is set to last byte of work queue buffer. It will make sure the whole work queue buffer is available after coming back from reset or init. Do not hold kmap_atomic mapping before going to sleep when work queue is full.

[Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2016-02-09 Thread Stephen Rothwell
used the drm-misc tree from next-20160209 for today. -- Cheers, Stephen Rothwell ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH V3] drm/i915/skl: SKL CDCLK change on modeset tracking VCO

2016-02-09 Thread Thulasimani, Sivakumar
couple of questions since i am looking at SKL code for the first time > seems we are not reading max cd clock from VBIOS like BDW even though SKL has limit register to say max cd clock i dont think it is working, so VBIOS saves the value during boot just like in BDW and we are

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Check for get_pages instead of shmem (filp) (rev2)

2016-02-09 Thread Patchwork
== Summary == Series 3145v2 drm/i915: Check for get_pages instead of shmem (filp) http://patchwork.freedesktop.org/api/1.0/series/3145/revisions/2/mbox/ Test pm_rpm: Subgroup basic-pci-d3-state: fail -> PASS (hsw-gt2) pass -> DMESG-WARN

Re: [Intel-gfx] [PATCH v4] drm/i915: Handle PipeC fused off on IVB/HSW/BDW

2016-02-09 Thread Daniel Vetter
On Mon, Feb 01, 2016 at 03:20:19PM +0100, Patrik Jakobsson wrote: > On Fri, Jan 22, 2016 at 01:28:45PM +0200, Gabriel Feceoru wrote: > > Some Gen7/8 production parts may have the Display Pipe C fused off. > > In this case, the display hardware will prevent the enable bit in > > PIPE_CONF register

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2016-02-09 Thread Daniel Vetter
^ > > Caused by commit > > 2413306c2566 ("apple-gmux: Add helper for presence detect") > > I have used the drm-misc tree from next-20160209 for today. Can you pls attach your .config? The function is there, I suspect we're just missing some d

Re: [Intel-gfx] [RFC 00/22] Add support for GuC-based SLPC

2016-02-09 Thread Daniel Vetter
On Tue, Feb 09, 2016 at 02:08:23PM +0200, Martin Peres wrote: > On 26/01/16 19:00, Daniel Vetter wrote: > >On Tue, Jan 26, 2016 at 07:45:42AM -0800, Jesse Barnes wrote: > >>On 01/22/2016 09:00 AM, Daniel Vetter wrote: > >>>On Wed, Jan 20, 2016 at 06:26:02PM -0800, tom.orou...@intel.com wrote: >

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Capture revision id in error state (rev2)

2016-02-09 Thread Daniel Vetter
On Fri, Jan 29, 2016 at 11:08:53AM +, Arun Siluvery wrote: > On 29/01/2016 10:27, Patchwork wrote: > >== Summary == > > > >Series 2850v2 drm/i915: Capture revision id in error state > >http://patchwork.freedesktop.org/api/1.0/series/2850/revisions/2/mbox/ > > > >Test kms_flip: > >

Re: [Intel-gfx] [PATCH 3/4] agp/intel-gtt: Only register fake agp driver for gen1

2016-02-09 Thread Daniel Vetter
On Wed, Jan 27, 2016 at 02:38:00PM +0100, Daniel Vetter wrote: > The fake agp driver for the intel graphics gart is only needed for ums > support. And we ditched that a long time ago: > > commit 03dae59c72d8ef6e005f48ba356c863e0587 > Author: Daniel Vetter > Date:

Re: [Intel-gfx] [PATCH v3 08/18] drm/i915: Pass 90/270 vs. 0/180 rotation info for intel_gen4_compute_page_offset()

2016-02-09 Thread Daniel Vetter
On Thu, Jan 28, 2016 at 08:51:14PM +0200, Ville Syrjälä wrote: > On Mon, Jan 25, 2016 at 06:30:17PM +0100, Daniel Vetter wrote: > > On Wed, Jan 20, 2016 at 09:05:29PM +0200, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > The page

Re: [Intel-gfx] [PATCH v2 1/6] drm/i915: fix context/engine cleanup order

2016-02-09 Thread Daniel Vetter
On Fri, Jan 22, 2016 at 11:10:06PM +, Dave Gordon wrote: > From: Nick Hoath > > Swap the order of context & engine cleanup, so that contexts are cleaned > up first, and *then* engines. This is a more sensible order anyway, but > in particular has become necessary

Re: [Intel-gfx] [PATCH] drm/i915: Capture PCI revision and subsytem details in error state

2016-02-09 Thread Daniel Vetter
On Thu, Jan 28, 2016 at 05:18:41PM +, Arun Siluvery wrote: > Revision id along with device id is useful in better identification of the HW > and its limitations so include this detail in error state. > > v2: make it clear that it is PCI revision and We might as well dump PCI > subsystem

Re: [Intel-gfx] [PATCH v3] drm/i915: check that rpm ref is held when accessing ringbuf in stolen mem

2016-02-09 Thread Daniel Vetter
On Wed, Jan 27, 2016 at 04:44:37PM +, Chris Wilson wrote: > On Wed, Jan 27, 2016 at 03:43:49PM +, daniele.ceraolospu...@intel.com > wrote: > > From: Daniele Ceraolo Spurio > > > > While running some tests on the scheduler patches with rpm enabled I > >

Re: [Intel-gfx] [PATCH] drm/i915: Check for get_pages instead of shmem (filp)

2016-02-09 Thread Ben Widawsky
On Tue, Feb 09, 2016 at 11:30:34AM +, Dave Gordon wrote: > On 09/02/16 00:20, Kristian Høgsberg wrote: > >On Fri, Feb 5, 2016 at 5:48 PM, Ben Widawsky > > wrote: > >>This behavior of checking for a shmem backed GEM object was introduced here: > >>commit