Re: [Intel-gfx] Could you merge the tsc patches directly from Len Brown's public repo?

Hi Len, Daniel, Jani, Keqiao has validated the 8 patches can fix the pulseaudio issues on APL. As soon as the 9 patches have been in Ingo's repo, it may difficult to revert 540cc882de7d1da2e71591e215f0e04cb89883fa. So can we follow the process below: 1. Daniel and Jani help to cherry-pick other

Re: [Intel-gfx] [PATCH] drm/i915/gen9: Update the forcewake range

Reviewed-by: Sagar Arun Kamble On 4/29/2016 9:54 AM, akash.g...@intel.com wrote: From: Akash Goel Update made to the Gen9 forcewake range to cover the OA registers. MMIO locations 0x2700-0x2FFF belong to the same power domain as 0x2000-0x26FF.

[Intel-gfx] [PATCH] drm/i915/gen9: Update the forcewake range

From: Akash Goel Update made to the Gen9 forcewake range to cover the OA registers. MMIO locations 0x2700-0x2FFF belong to the same power domain as 0x2000-0x26FF. Signed-off-by: Akash Goel --- drivers/gpu/drm/i915/intel_uncore.c | 3 +-- 1 file

Re: [Intel-gfx] i915 ERRORs and WARN_ON()s

Hi, > The Bugzilla at https://bugs.freedesktop.org is our tool of choice for > tracking bugs in drm/i915. It's your choice to not create an account > there, but please, don't expect us to work as a proxy between you and > bugzilla either. It's a much bigger and unscalable inconvenience for us >

Re: [Intel-gfx] Could you merge the tsc patches directly from Len Brown's public repo?

Does this mean that Len's patches will be merged into upstream except this one? Regards, Libin > -Original Message- > From: Chen, Yu C > Sent: Friday, April 29, 2016 9:43 AM > To: Lu, Han; 'Ville Syrjälä'; Brown, Len > Cc: 'Daniel Vetter'; Nikula, Jani; Lin, Mengdong; Yang, Libin; Li,

Re: [Intel-gfx] Could you merge the tsc patches directly from Len Brown's public repo?

Please ignore my previous patch(it is incorrect), you can cherry pick Len's 8 patches except this one: 540cc882de7d1da2e71591e215f0e04cb89883fa x86 tsc_msr: Extend to include Intel Core Architecture thanks, Yu > -Original Message- > From: Lu, Han > Sent: Friday, April 29, 2016 9:38 AM >

Re: [Intel-gfx] Could you merge the tsc patches directly from Len Brown's public repo?

+Juan Hi Yu, Do you have any update on your patches? We need a solution to fix the SandyBridge hang asap, then Daniel and Jani can help to cherry-pick the tsc patches to drm-intel repo. BR, Han Lu > -Original Message- > From: Lu, Han > Sent: Wednesday, April 27, 2016 1:18 PM > To:

Re: [Intel-gfx] [PATCH v4 00/21] Add support for GuC-based SLPC

On Wed, Apr 27, 2016 at 06:10:44PM -0700, tom.orou...@intel.com wrote: > From: Tom O'Rourke > > SLPC (Single Loop Power Controller) is a replacement for > some host-based power management features. The SLPC > implemenation runs in firmware on GuC. > > This series has

Re: [Intel-gfx] [PATCH 02/10] drm/i915: Fix ordering of sanitize ppgtt and sanitize execlists

On 28/04/16 17:24, Chris Wilson wrote: The i915.enable_ppgtt option depends upon the state of i915.enable_execlists option - so we need to sanitize execlists first. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_dma.c | 13 +

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Fix comments about GMBUSFREQ register

On Wed, Apr 27, 2016 at 04:56:42PM +0300, Ville Syrjälä wrote: > On Wed, Apr 27, 2016 at 04:30:14PM +0300, Mika Kahola wrote: > > s/Programmng/Programming > > It's straight from the spec, hence the [sic] Didn't get any further objections, so pushed the series to dinq, with the typoes and [sic]s

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: introduce & use i915_gem_object_mark_dirty()

On 28/04/16 18:48, Patchwork wrote: == Series Details == Series: series starting with [1/2] drm/i915: introduce & use i915_gem_object_mark_dirty() URL : https://patchwork.freedesktop.org/series/6491/ State : warning == Summary == Series 6491v1 Series without cover letter

Re: [Intel-gfx] [CI 17/25] drm/i915: Assign every HW context a unique ID

On Thu, Apr 28, 2016 at 07:08:18PM +0100, Dave Gordon wrote: > On 28/04/16 16:32, Chris Wilson wrote: > >On Thu, Apr 28, 2016 at 03:55:44PM +0100, Dave Gordon wrote: > >>On 28/04/16 09:56, Chris Wilson wrote: > >>>The hardware tracks contexts and expects all live contexts (those active > >>>on the

Re: [Intel-gfx] [CI 22/25] drm/i915: Track the previous pinned context inside the request

On Thu, Apr 28, 2016 at 07:15:23PM +0100, Dave Gordon wrote: > On 28/04/16 09:56, Chris Wilson wrote: > >As the contexts are accessed by the hardware until the switch is completed > >to a new context, the hardware may still be writing to the context object > >after the breadcrumb is visible. We

Re: [Intel-gfx] [CI 22/25] drm/i915: Track the previous pinned context inside the request

On 28/04/16 09:56, Chris Wilson wrote: As the contexts are accessed by the hardware until the switch is completed to a new context, the hardware may still be writing to the context object after the breadcrumb is visible. We must not unpin/unbind/prune that object whilst still active and so we

Re: [Intel-gfx] [Mesa-dev] [PATCH v2 mesa] vk/intel: use negative VK_NO_PROTOTYPES scheme

On Mon, Apr 25, 2016 at 05:08:18PM +0100, Emil Velikov wrote: > On 21 April 2016 at 11:24, Eric Engestrom wrote: > > Commit 3d0fac7aca237bbe8ed8e2a362d3b42d0ef8c46c changed all the > > VK_PROTOTYPES to VK_NO_PROTOTYPES > > This brings the Intel header in line with the

Re: [Intel-gfx] [CI 17/25] drm/i915: Assign every HW context a unique ID

On 28/04/16 16:32, Chris Wilson wrote: On Thu, Apr 28, 2016 at 03:55:44PM +0100, Dave Gordon wrote: On 28/04/16 09:56, Chris Wilson wrote: The hardware tracks contexts and expects all live contexts (those active on the hardware) to have a unique identifier. This is used by the hardware to

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: introduce & use i915_gem_object_mark_dirty()

== Series Details == Series: series starting with [1/2] drm/i915: introduce & use i915_gem_object_mark_dirty() URL : https://patchwork.freedesktop.org/series/6491/ State : warning == Summary == Series 6491v1 Series without cover letter

[Intel-gfx] [PATCH v2] drm/i915/execlists: Refactor common engine setup

Move all of the constant assignments up front and into a common function. This is primarily to ensure the backpointers are set as early as possible for later use during initialisation. v2: Use a constant struct so that all the similar values are set together. Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH 1/2] drm/i915: introduce & use i915_gem_object_mark_dirty()

On 28/04/16 17:34, Chris Wilson wrote: On Thu, Apr 28, 2016 at 05:26:20PM +0100, Dave Gordon wrote: This just hides the existing obj->dirty flag inside a trivial inline setter, to discourage non-GEM code from looking too closely. Existing code that sets obj->dirty is then changed to use the

Re: [Intel-gfx] [PATCH 2/2] drm/i915: a couple more uses for i915_gem_object_mark_dirty()

On Thu, Apr 28, 2016 at 06:20:30PM +0100, Dave Gordon wrote: > On 28/04/16 17:36, Chris Wilson wrote: > >On Thu, Apr 28, 2016 at 05:26:21PM +0100, Dave Gordon wrote: > >>intel_pin_and_map_ringbuffer_obj() should have been setting the dirty > >>flag, but wasn't; and the LRC code in

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/bxt: Fix inadvertent CPU snooping due to incorrect MOCS config

On Thu, Apr 28, 2016 at 04:48:37PM +0200, Daniel Vetter wrote: > On Thu, Apr 28, 2016 at 11:38:55AM +0300, Imre Deak wrote: > > On to, 2016-04-28 at 10:17 +0200, Daniel Vetter wrote: > > > On Tue, Apr 26, 2016 at 07:01:06PM +0300, Imre Deak wrote: > > > > On ti, 2016-04-26 at 15:42 +0100, Chris

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/bxt: Fix inadvertent CPU snooping due to incorrect MOCS config

On Thu, Apr 28, 2016 at 04:44:00PM +0200, Daniel Vetter wrote: > On Thu, Apr 28, 2016 at 01:48:27PM +0300, Ville Syrjälä wrote: > > On Thu, Apr 28, 2016 at 10:13:37AM +0200, Daniel Vetter wrote: > > > On Tue, Apr 26, 2016 at 08:57:51PM +0300, Ville Syrjälä wrote: > > > > On Tue, Apr 26, 2016 at

Re: [Intel-gfx] [PATCH 2/2] drm/i915: a couple more uses for i915_gem_object_mark_dirty()

On 28/04/16 17:36, Chris Wilson wrote: On Thu, Apr 28, 2016 at 05:26:21PM +0100, Dave Gordon wrote: intel_pin_and_map_ringbuffer_obj() should have been setting the dirty flag, but wasn't; and the LRC code in intel_lr_context_do_pin() is also updated to use the new function. Technically it

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/bxt: Fix inadvertent CPU snooping due to incorrect MOCS config

On to, 2016-04-28 at 16:48 +0200, Daniel Vetter wrote: > On Thu, Apr 28, 2016 at 11:38:55AM +0300, Imre Deak wrote: > > On to, 2016-04-28 at 10:17 +0200, Daniel Vetter wrote: > > > On Tue, Apr 26, 2016 at 07:01:06PM +0300, Imre Deak wrote: > > > > On ti, 2016-04-26 at 15:42 +0100, Chris Wilson

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Refactor common engine setup

On Thu, Apr 28, 2016 at 05:12:28PM +0100, Dave Gordon wrote: > On 28/04/16 14:47, Chris Wilson wrote: > >-/* Intentionally left blank. */ > >-engine->buffer = NULL; > > > > engine->dev = dev; > > Eeep! Isn't this the "engine initialised and ready for use" flag? The same that we set

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/10] drm/i915: Apply strongly ordered RCS breadcrumb to gen8/legacy

== Series Details == Series: series starting with [01/10] drm/i915: Apply strongly ordered RCS breadcrumb to gen8/legacy URL : https://patchwork.freedesktop.org/series/6490/ State : failure == Summary == Series 6490v1 Series without cover letter

Re: [Intel-gfx] [PATCH 2/2] drm/i915: a couple more uses for i915_gem_object_mark_dirty()

On Thu, Apr 28, 2016 at 05:26:21PM +0100, Dave Gordon wrote: > intel_pin_and_map_ringbuffer_obj() should have been setting the dirty > flag, but wasn't; and the LRC code in intel_lr_context_do_pin() is also > updated to use the new function. Technically it doesn't need to. Whilst there is any

Re: [Intel-gfx] [PATCH 1/2] drm/i915: introduce & use i915_gem_object_mark_dirty()

On Thu, Apr 28, 2016 at 05:26:20PM +0100, Dave Gordon wrote: > This just hides the existing obj->dirty flag inside a trivial inline > setter, to discourage non-GEM code from looking too closely. > > Existing code that sets obj->dirty is then changed to use the function > instead. I prefer

[Intel-gfx] [PATCH 1/2] drm/i915: introduce & use i915_gem_object_mark_dirty()

This just hides the existing obj->dirty flag inside a trivial inline setter, to discourage non-GEM code from looking too closely. Existing code that sets obj->dirty is then changed to use the function instead. Inspired-by: http://www.spinics.net/lists/intel-gfx/msg92390.html Cc: Chris Wilson

[Intel-gfx] [PATCH 2/2] drm/i915: a couple more uses for i915_gem_object_mark_dirty()

intel_pin_and_map_ringbuffer_obj() should have been setting the dirty flag, but wasn't; and the LRC code in intel_lr_context_do_pin() is also updated to use the new function. Signed-off-by: Dave Gordon --- drivers/gpu/drm/i915/intel_lrc.c| 10 +-

[Intel-gfx] [PATCH 10/10] drm/i915: Enable legacy/semaphores for CI

--- drivers/gpu/drm/i915/intel_lrc.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c index 4735460be1a0..8d9849b9b6ed 100644 --- a/drivers/gpu/drm/i915/intel_lrc.c +++ b/drivers/gpu/drm/i915/intel_lrc.c @@ -260,10 +260,6

[Intel-gfx] [PATCH 05/10] drm/i915: Reload PD tables after semaphore wait on gen8

When the engine idles waiting upon a semaphore, it loses its pagetables and we must reload them before executing the batch. v2: Restrict w/a to non-RCS rings (RCS works correctly apparently). Signed-off-by: Chris Wilson Cc: Ville Syrjälä

[Intel-gfx] [PATCH 07/10] drm/i915: Trim the flush for the legacy request emission

At the start of request emission, we flush some space for the request, estimating the typical size for the request body. The tail is now much larger than the typical body, so we can shrink the flush slightly. Signed-off-by: Chris Wilson ---

[Intel-gfx] [PATCH 02/10] drm/i915: Fix ordering of sanitize ppgtt and sanitize execlists

The i915.enable_ppgtt option depends upon the state of i915.enable_execlists option - so we need to sanitize execlists first. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_dma.c | 13 + drivers/gpu/drm/i915/i915_drv.h | 2 ++

[Intel-gfx] [PATCH 08/10] drm/i915: Trim the flush for the execlists request emission

At the start of request emission, we flush some space for the request, estimating the typical size for the request body. The common tail is now much larger than the typical body, so we can shrink the flush substantially. Signed-off-by: Chris Wilson ---

[Intel-gfx] [PATCH 04/10] drm/i915: Fix serialisation of pipecontrol write vs semaphore signal

In order for the MI_SEMAPHORE_SIGNAL command to wait until after the pipecontrol writing the signal value is complete, we have to pause the CS inside the PIPE_CONTROL with the CS_STALL bit. Signed-off-by: Chris Wilson Reviewed-by: Ville Syrjälä

[Intel-gfx] [PATCH 06/10] drm/i915: Bump reserved size for legacy gen8 semaphore emission

With 5 rings and a flush, we need 192 bytes of space to emit the breadcrumb and semaphores. However, we need some spare room the size of the single largest packet (36 dwords, 144 bytes) to accommodate wraparound giving a grand total of 336 bytes Signed-off-by: Chris Wilson

[Intel-gfx] [PATCH 03/10] drm/i915: Fix gen8 semaphores id for legacy mode

With the introduction of a distinct engine->id vs the hardware id, we need to fix up the value we use for selecting the target engine when signaling a semaphore. Note that these values can be merged with engine->guc_id. Fixes: de1add360522c876c25ef2ab1c94bdb509ab Signed-off-by: Chris Wilson

[Intel-gfx] [PATCH 09/10] drm/i915: Enable semaphores for legacy submission on gen8

We have sufficient evidence from igt to support that semaphores are in a working state. Enabling semaphores now for legacy provides a better comparison of execlists against legacy ring submission. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.c | 4

[Intel-gfx] [PATCH 01/10] drm/i915: Apply strongly ordered RCS breadcrumb to gen8/legacy

For legacy ringbuffer mode, we need the new ordered breadcrumb emission tried and tested on execlists. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_ringbuffer.c | 37 +++-- 1 file changed, 35 insertions(+), 2 deletions(-) diff

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Refactor common engine setup

On 28/04/16 14:47, Chris Wilson wrote: Move all of the constant assignments up front and into a common function. This is primarily to ensure the backpointers are set as early as possible for later use during initialisation. Signed-off-by: Chris Wilson Cc: Tvrtko

Re: [Intel-gfx] [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors.

On 04/28/2016 10:41 AM, Daniel Vetter wrote: On Thu, Apr 28, 2016 at 10:07:41AM -0400, Robert Foss wrote: On 04/28/2016 04:02 AM, Daniel Vetter wrote: On Tue, Apr 26, 2016 at 01:08:35PM -0400, Robert Foss wrote: On 04/26/2016 01:00 PM, Ville Syrjälä wrote: On Tue, Apr 26, 2016 at

Re: [Intel-gfx] [CI 17/25] drm/i915: Assign every HW context a unique ID

On Thu, Apr 28, 2016 at 03:55:44PM +0100, Dave Gordon wrote: > On 28/04/16 09:56, Chris Wilson wrote: > >The hardware tracks contexts and expects all live contexts (those active > >on the hardware) to have a unique identifier. This is used by the > >hardware to assign pagefaults and the like to a

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Refactor common engine setup

On Thu, Apr 28, 2016 at 04:10:54PM +0100, Tvrtko Ursulin wrote: > >-/* Intentionally left blank. */ > >-engine->buffer = NULL; > > > > engine->dev = dev; > > Setting engine->dev was last in sequence before and now it is ahead > of lot of other things. I am not sure how important that

Re: [Intel-gfx] [CI 18/25] drm/i915: Replace the pinned context address with its unique ID

On 28/04/16 09:56, Chris Wilson wrote: Rather than reuse the current location of the context in the global GTT for its hardware identifier, use the context's unique ID assigned to it for its whole lifetime. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Refactor common engine setup

On 28/04/16 14:47, Chris Wilson wrote: Move all of the constant assignments up front and into a common function. This is primarily to ensure the backpointers are set as early as possible for later use during initialisation. Signed-off-by: Chris Wilson Cc: Tvrtko

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/bxt: Fix inadvertent CPU snooping due to incorrect MOCS config

On Thu, Apr 28, 2016 at 11:38:55AM +0300, Imre Deak wrote: > On to, 2016-04-28 at 10:17 +0200, Daniel Vetter wrote: > > On Tue, Apr 26, 2016 at 07:01:06PM +0300, Imre Deak wrote: > > > On ti, 2016-04-26 at 15:42 +0100, Chris Wilson wrote: > > > > On Tue, Apr 26, 2016 at 05:26:43PM +0300, Eero

Re: [Intel-gfx] [CI 17/25] drm/i915: Assign every HW context a unique ID

On 28/04/16 09:56, Chris Wilson wrote: The hardware tracks contexts and expects all live contexts (those active on the hardware) to have a unique identifier. This is used by the hardware to assign pagefaults and the like to a particular context. v2: Reorder to make sure ctx->link is not left

Re: [Intel-gfx] [CI 14/25] drm/i915: Manually unwind after a failed request allocation

On Thu, Apr 28, 2016 at 03:43:52PM +0100, Dave Gordon wrote: > On 28/04/16 09:56, Chris Wilson wrote: > >In the next patches, we want to move the work out of freeing the request > >and into its retirement (so that we can free the request without > >requiring the struct_mutex). This means that we

Re: [Intel-gfx] [CI 13/25] drm/i915: Remove the identical implementations of request space reservation

On Thu, Apr 28, 2016 at 03:31:00PM +0100, Chris Wilson wrote: > On Thu, Apr 28, 2016 at 03:02:18PM +0100, Dave Gordon wrote: > > On 28/04/16 09:56, Chris Wilson wrote: > > >Now that we share intel_ring_begin(), reserving space for the tail of > > >the request is identical between legacy/execlists

Re: [Intel-gfx] [CI 14/25] drm/i915: Manually unwind after a failed request allocation

On 28/04/16 09:56, Chris Wilson wrote: In the next patches, we want to move the work out of freeing the request and into its retirement (so that we can free the request without requiring the struct_mutex). This means that we cannot rely on unreferencing the request to completely teardown the

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/bxt: Fix inadvertent CPU snooping due to incorrect MOCS config

On Thu, Apr 28, 2016 at 01:48:27PM +0300, Ville Syrjälä wrote: > On Thu, Apr 28, 2016 at 10:13:37AM +0200, Daniel Vetter wrote: > > On Tue, Apr 26, 2016 at 08:57:51PM +0300, Ville Syrjälä wrote: > > > On Tue, Apr 26, 2016 at 04:30:05PM +0200, Daniel Vetter wrote: > > > > On Tue, Apr 26, 2016 at

Re: [Intel-gfx] [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors.

On Thu, Apr 28, 2016 at 10:07:41AM -0400, Robert Foss wrote: > > > On 04/28/2016 04:02 AM, Daniel Vetter wrote: > >On Tue, Apr 26, 2016 at 01:08:35PM -0400, Robert Foss wrote: > >> > >> > >>On 04/26/2016 01:00 PM, Ville Syrjälä wrote: > >>>On Tue, Apr 26, 2016 at 12:55:54PM -0400, Robert Foss

Re: [Intel-gfx] [CI 13/25] drm/i915: Remove the identical implementations of request space reservation

On Thu, Apr 28, 2016 at 03:02:18PM +0100, Dave Gordon wrote: > On 28/04/16 09:56, Chris Wilson wrote: > >Now that we share intel_ring_begin(), reserving space for the tail of > >the request is identical between legacy/execlists and so the tautology > >can be removed. In the process, we move the

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/execlists: Refactor common engine setup

== Series Details == Series: drm/i915/execlists: Refactor common engine setup URL : https://patchwork.freedesktop.org/series/6480/ State : warning == Summary == Series 6480v1 drm/i915/execlists: Refactor common engine setup

Re: [Intel-gfx] [RFC PATCH 2/2] drm/i915/bxt: Adjusting the error in horizontal timings retrieval

On Wed, 27 Apr 2016, Ville Syrjälä wrote: > On Tue, Apr 19, 2016 at 01:48:14PM +0530, Ramalingam C wrote: >> In BXT DSI there is no regs programmed with few horizontal timings >> in Pixels but txbyteclkhs.. So retrieval process adds some >> ROUND_UP ERRORS in the

Re: [Intel-gfx] [CI 13/25] drm/i915: Remove the identical implementations of request space reservation

On 28/04/16 09:56, Chris Wilson wrote: Now that we share intel_ring_begin(), reserving space for the tail of the request is identical between legacy/execlists and so the tautology can be removed. In the process, we move the reserved space tracking from the ringbuffer on to the request. This is

Re: [Intel-gfx] [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors.

On 04/28/2016 04:02 AM, Daniel Vetter wrote: On Tue, Apr 26, 2016 at 01:08:35PM -0400, Robert Foss wrote: On 04/26/2016 01:00 PM, Ville Syrjälä wrote: On Tue, Apr 26, 2016 at 12:55:54PM -0400, Robert Foss wrote: On 04/26/2016 10:11 AM, Daniel Vetter wrote: On Fri, Apr 22, 2016 at

Re: [Intel-gfx] [PATCH maintainer-tools 2/2] dim: Refuse to commit patches that modify files outside of i915

On Thu, Apr 28, 2016 at 02:32:20PM +0300, Joonas Lahtinen wrote: > Signed-off-by: Joonas Lahtinen > --- > dim | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/dim b/dim > index dbcb7d9..1c258be 100755 > --- a/dim > +++ b/dim > @@ -691,6 +691,11 @@

[Intel-gfx] [PATCH] drm/i915/execlists: Refactor common engine setup

Move all of the constant assignments up front and into a common function. This is primarily to ensure the backpointers are set as early as possible for later use during initialisation. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin ---

[Intel-gfx] [PATCH i-g-t v5 5/6] kms_panel_fitting: Enabled test on non-Intel hardware.

From: Robert Foss Switched from DRIVER_INTEL to DRIVER_ANY to enable test on all hardware. Signed-off-by: Robert Foss Reviewed-by: Tomeu Vizoso --- tests/kms_panel_fitting.c | 2 +- 1 file changed, 1

[Intel-gfx] [PATCH i-g-t v5 4/6] kms_panel_fitting: Switched DRM format to a hardware agnostic alternative.

From: Robert Foss Changed the DRM format to LOCAL_DRM_FORMAT_MOD_NONE since it is hardware agnostic. Also fixed formatting/tabs. Signed-off-by: Robert Foss Reviewed-by: Tomeu Vizoso ---

[Intel-gfx] [PATCH i-g-t v5 6/6] kms_panel_fitting: Enable connectors with "scaling mode" property set.

From: Robert Foss Enable testing on all connectors that have the "scaling mode" property set. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93012 Signed-off-by: Robert Foss Reviewed-by: Daniel Vetter ---

[Intel-gfx] [PATCH i-g-t v5 3/6] kms_panel_fitting: Remove un-used variable.

From: Robert Foss ref_crc is never assigned or read, and can be safely removed. Signed-off-by: Robert Foss Reviewed-by: Tomeu Vizoso --- tests/kms_panel_fitting.c | 1 - 1 file changed, 1 deletion(-) diff

[Intel-gfx] [PATCH i-g-t v5 2/6] kms_panel_fitting: Remove un-read variable pipe_crc.

From: Robert Foss pipe_crc in data_t is assigned an allocated memory space and then later free'd. But it is never used for any comparisons. It should therefore be safe to remove pipe_crc and the crc requirement. Signed-off-by: Robert Foss

[Intel-gfx] [PATCH i-g-t v5 0/6] Improve kms_panel_fitting.

From: Robert Foss Changes since v4: - Added reviewed-by danvet to patch 6, all patches are now reviewed. Changes since v3: - kms_panel_fitting.c: Pass NULL arguments instead - Added bugzilla link: https://bugs.freedesktop.org/show_bug.cgi?id=93012 Changes since v2: -

[Intel-gfx] [PATCH i-g-t v5 1/6] kms_panel_fitting: Remove un-read variable.

From: Robert Foss Remove devid from data_t since it is never read. Also remove one assignment to devid. Signed-off-by: Robert Foss Reviewed-by: Tomeu Vizoso --- tests/kms_panel_fitting.c | 2 -- 1 file changed,

Re: [Intel-gfx] [PATCH 16/35] drm/etnaviv: Use lockless gem BO free callback

On Tue, Apr 26, 2016 at 07:29:49PM +0200, Daniel Vetter wrote: > No dev->struct_mutex anywhere to be seen. > > Cc: Christian Gmeiner > Cc: Russell King Acked-by: Russell King Thanks Daniel. -- RMK's

Re: [Intel-gfx] [PATCH 11/35] drm/armada: Use lockless gem BO free callback

On Tue, Apr 26, 2016 at 07:29:44PM +0200, Daniel Vetter wrote: > No dev->struct_mutex anywhere to be seen. > > Cc: Russell King Acked-by: Russell King Thanks Daniel. -- RMK's Patch system:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Simplify intel_mark_busy/idle

== Series Details == Series: drm/i915: Simplify intel_mark_busy/idle URL : https://patchwork.freedesktop.org/series/6465/ State : failure == Summary == Series 6465v1 drm/i915: Simplify intel_mark_busy/idle http://patchwork.freedesktop.org/api/1.0/series/6465/revisions/1/mbox/ Test

Re: [Intel-gfx] [PATCH maintainer-tools 2/2] dim: Refuse to commit patches that modify files outside of i915

On Thu, 28 Apr 2016, Joonas Lahtinen wrote: > Signed-off-by: Joonas Lahtinen > --- > dim | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/dim b/dim > index dbcb7d9..1c258be 100755 > --- a/dim > +++ b/dim > @@ -691,6

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: remove i915_gem_object_ggtt_unbind

== Series Details == Series: drm/i915: remove i915_gem_object_ggtt_unbind URL : https://patchwork.freedesktop.org/series/6461/ State : failure == Summary == Series 6461v1 drm/i915: remove i915_gem_object_ggtt_unbind http://patchwork.freedesktop.org/api/1.0/series/6461/revisions/1/mbox/ Test

Re: [Intel-gfx] [PATCH] drm/i915: Fix enc_to_dig_port() for MST encoders

On Thu, 28 Apr 2016, Ville Syrjälä wrote: > On Thu, Apr 28, 2016 at 09:17:00AM +0300, Jani Nikula wrote: >> On Wed, 27 Apr 2016, Lyude wrote: >> > For MST encoders, the encoder struct is stored in the intel_dp_mst >> > struct, not a

Re: [Intel-gfx] [PATCH] drm/i915: Simplify intel_mark_busy/idle

On Thu, Apr 28, 2016 at 12:57:00PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > They use dev_priv exclusively so pass it in instead of dev > for smaller source and binary. True, but we have an outstanding bug report and patch here because we have current

[Intel-gfx] [PATCH] drm/i915: Simplify intel_mark_busy/idle

From: Tvrtko Ursulin They use dev_priv exclusively so pass it in instead of dev for smaller source and binary. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem.c | 4 ++-- drivers/gpu/drm/i915/intel_display.c | 14

Re: [Intel-gfx] Kernel Oops on 3.14.66

On 28/04/16 09:58, Andreas Lampersperger wrote: Hi Dave, thank you again. I searched, where the memory for the request came from, it is set in line 2158 of i915_gem.c

[Intel-gfx] [PATCH maintainer-tools 1/2] dim: Use -e on warn_or_fail to allow fo newlines

Signed-off-by: Joonas Lahtinen --- dim | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dim b/dim index d9c1be5..dbcb7d9 100755 --- a/dim +++ b/dim @@ -118,9 +118,9 @@ HELP= function warn_or_fail { if [[ $FORCE ]] ; then -

[Intel-gfx] [PATCH maintainer-tools 2/2] dim: Refuse to commit patches that modify files outside of i915

Signed-off-by: Joonas Lahtinen --- dim | 5 + 1 file changed, 5 insertions(+) diff --git a/dim b/dim index dbcb7d9..1c258be 100755 --- a/dim +++ b/dim @@ -691,6 +691,11 @@ function checkpatch_commit if test "$bug_lines" -eq 1; then

[Intel-gfx] [PATCH] drm/i915: remove i915_gem_object_ggtt_unbind

Only has one user and is nothing more than a shim on top of i915_vma_unbind, so let's just get rid of it. Cc: Joonas Lahtinen Suggested-by: Joonas Lahtinen Signed-off-by: Matthew Auld ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Tidy intel_dump_pipe_config a bit

== Series Details == Series: drm/i915: Tidy intel_dump_pipe_config a bit URL : https://patchwork.freedesktop.org/series/6457/ State : failure == Summary == Series 6457v1 drm/i915: Tidy intel_dump_pipe_config a bit http://patchwork.freedesktop.org/api/1.0/series/6457/revisions/1/mbox/ Test

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,01/25] drm/i915/fbdev: Call intel_unpin_fb_obj() on release

On Thu, Apr 28, 2016 at 10:58:29AM -, Patchwork wrote: > == Series Details == > > Series: series starting with [CI,01/25] drm/i915/fbdev: Call > intel_unpin_fb_obj() on release > URL : https://patchwork.freedesktop.org/series/6453/ > State : failure > > == Summary == > > Series 6453v1

Re: [Intel-gfx] [PATCH] drm/i915: Validate execbuffer start/length arguments against the target bo

On 28/04/16 10:02, Chris Wilson wrote: On Thu, Apr 28, 2016 at 11:54:04AM +0300, Jani Nikula wrote: On Thu, 28 Apr 2016, Jani Nikula wrote: On Fri, 20 Nov 2015, Ville Syrjälä wrote: On Fri, Nov 20, 2015 at 03:11:04PM +, Chris

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,01/25] drm/i915/fbdev: Call intel_unpin_fb_obj() on release

== Series Details == Series: series starting with [CI,01/25] drm/i915/fbdev: Call intel_unpin_fb_obj() on release URL : https://patchwork.freedesktop.org/series/6453/ State : failure == Summary == Series 6453v1 Series without cover letter

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/bxt: Fix inadvertent CPU snooping due to incorrect MOCS config

On Thu, Apr 28, 2016 at 10:13:37AM +0200, Daniel Vetter wrote: > On Tue, Apr 26, 2016 at 08:57:51PM +0300, Ville Syrjälä wrote: > > On Tue, Apr 26, 2016 at 04:30:05PM +0200, Daniel Vetter wrote: > > > On Tue, Apr 26, 2016 at 05:26:43PM +0300, Eero Tamminen wrote: > > > > Hi, > > > > > > > > On

Re: [Intel-gfx] [PATCH] drm/i915: Fix enc_to_dig_port() for MST encoders

On Thu, Apr 28, 2016 at 09:17:00AM +0300, Jani Nikula wrote: > On Wed, 27 Apr 2016, Lyude wrote: > > For MST encoders, the encoder struct is stored in the intel_dp_mst > > struct, not a intel_digital_port struct. > > > > This fixes issues with hotplugging MST displays that

Re: [Intel-gfx] [PATCH 11/12] drm/i915: Extend GET_APERTURE ioctl to report available map space

On Thu, Apr 28, 2016 at 10:30:32AM +0100, Tvrtko Ursulin wrote: > > On 26/04/16 10:44, Chris Wilson wrote: > >On Mon, Apr 25, 2016 at 03:51:09PM +0100, Tvrtko Ursulin wrote: > >> > >>On 25/04/16 11:35, Ankitprasad Sharma wrote: > >>>On Thu, 2016-04-21 at 15:59 +0100, Tvrtko Ursulin wrote: >

Re: [Intel-gfx] [PATCH 02/19] drm/i915: Remove stallcheck special handling, v2.

Op 28-04-16 om 11:54 schreef Patrik Jakobsson: > On Thu, Apr 28, 2016 at 10:48:55AM +0200, Maarten Lankhorst wrote: >> Op 27-04-16 om 15:24 schreef Patrik Jakobsson: >>> On Tue, Apr 19, 2016 at 09:52:22AM +0200, Maarten Lankhorst wrote: Both intel_unpin_work.pending and

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Support for creating/using Stolen memory backed objects (rev13)

Hi Ankit, On 20/04/16 17:28, Patchwork wrote: == Series Details == Series: Support for creating/using Stolen memory backed objects (rev13) URL : https://patchwork.freedesktop.org/series/659/ State : failure == Summary == Series 659v13 Support for creating/using Stolen memory backed

Re: [Intel-gfx] [PATCH 02/19] drm/i915: Remove stallcheck special handling, v2.

On Thu, Apr 28, 2016 at 10:48:55AM +0200, Maarten Lankhorst wrote: > Op 27-04-16 om 15:24 schreef Patrik Jakobsson: > > On Tue, Apr 19, 2016 at 09:52:22AM +0200, Maarten Lankhorst wrote: > >> Both intel_unpin_work.pending and intel_unpin_work.enable_stall_check > >> were used to see if work should

[Intel-gfx] [PATCH] drm/i915: Tidy intel_dump_pipe_config a bit

From: Tvrtko Ursulin A few tidies with the goal of making the output more compact and easier to read: 1. Group some data on single lines where it made sense. 2. Do not output scaler data on pre Gen9. 3. Fix plane dump so new log msg is not output in the midddle of

Re: [Intel-gfx] [PATCH 11/12] drm/i915: Extend GET_APERTURE ioctl to report available map space

On 26/04/16 10:44, Chris Wilson wrote: On Mon, Apr 25, 2016 at 03:51:09PM +0100, Tvrtko Ursulin wrote: On 25/04/16 11:35, Ankitprasad Sharma wrote: On Thu, 2016-04-21 at 15:59 +0100, Tvrtko Ursulin wrote: On 21/04/16 15:46, Chris Wilson wrote: On Thu, Apr 21, 2016 at 03:04:52PM +0100,

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Propagate error from drm_gem_object_init() (rev2)

On to, 2016-04-28 at 09:15 +0300, Joonas Lahtinen wrote: > On ke, 2016-04-27 at 14:44 +0100, Chris Wilson wrote: > > > > On Wed, Apr 27, 2016 at 04:35:33PM +0300, Joonas Lahtinen wrote: > > > > > > > > > On ma, 2016-04-25 at 13:24 +, Patchwork wrote: > > > > > > > > > > > > == Series

Re: [Intel-gfx] [PATCH 03/19] drm/i915: Remove intel_prepare_page_flip, v2.

Op 26-04-16 om 01:14 schreef Patrik Jakobsson: > On Tue, Apr 19, 2016 at 09:52:23AM +0200, Maarten Lankhorst wrote: >> Instead of calling prepare_flip right before calling finish_page_flip >> do everything from prepare_page_flip in finish_page_flip. >> >> Putting prepare and finish page_flip in a

Re: [Intel-gfx] [PATCH i-g-t 1/3] igt_kms: Fix use after free in kmstest_get_pipe_from_crtc_id

On 27/04/16 16:12, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- lib/igt_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index

Re: [Intel-gfx] [PATCH i-g-t 2/3] igt_kms: Allow kmstest_get_connector_config to take provided drmModeGetResources

On 28/04/16 09:28, Daniel Vetter wrote: On Wed, Apr 27, 2016 at 04:12:35PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin This will enable the following patch to generate less dmesg spam. Signed-off-by: Tvrtko Ursulin ---

Re: [Intel-gfx] [PATCH] drm/i915: Validate execbuffer start/length arguments against the target bo

On Thu, Apr 28, 2016 at 11:54:04AM +0300, Jani Nikula wrote: > On Thu, 28 Apr 2016, Jani Nikula wrote: > > On Fri, 20 Nov 2015, Ville Syrjälä wrote: > >> On Fri, Nov 20, 2015 at 03:11:04PM +, Chris Wilson wrote: > >>> The offset

Re: [Intel-gfx] Kernel Oops on 3.14.66

Hi Dave, thank you again. I searched, where the memory for the request came from, it is set in line 2158 of i915_gem.c and the kmalloc is in

[Intel-gfx] [CI 17/25] drm/i915: Assign every HW context a unique ID

The hardware tracks contexts and expects all live contexts (those active on the hardware) to have a unique identifier. This is used by the hardware to assign pagefaults and the like to a particular context. v2: Reorder to make sure ctx->link is not left dangling if the assignment of a hw_id fails

[Intel-gfx] [CI 13/25] drm/i915: Remove the identical implementations of request space reservation

Now that we share intel_ring_begin(), reserving space for the tail of the request is identical between legacy/execlists and so the tautology can be removed. In the process, we move the reserved space tracking from the ringbuffer on to the request. This is to enable us to reorder the reserved space

[Intel-gfx] [CI 11/25] drm/i915: Rearrange switch_context to load the aliasing ppgtt on first use

The code to switch_mm() is already handled by i915_switch_context(), the only difference required to setup the aliasing ppgtt is that we need to emit te switch_mm() on the first context, i.e. when transitioning from engine->last_context == NULL. This allows us to defer the initialisation of the

  1   2   >