Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/lspcon: Work around resume failure

> > == Summary == > > > > Series 14280v1 drm/i915/lspcon: Work around resume failure > > https://patchwork.freedesktop.org/api/1.0/series/14280/revisions/1/mb > > ox/ > > > > Test drv_module_reload_basic: > > pass   -> DMESG-WARN (fi-skl-6700hq) > > This one is a result of the

Re: [Intel-gfx] i915 4.8.3: cdclk < crtc_clock

On 24 October 2016 at 14:49, Tvrtko Ursulin wrote: > > Hi Daniel, > > On 24/10/2016 12:54, Daniel J Blueman wrote: >> >> Hi Tvrtko, >> >> I'm seeing this warning [1] on a Skylake Dell XPS 15 9550 with the >> internal 3840x2160 panel with 4.8.4. >> >> Let me know if

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/lspcon: Work around resume failure

> == Series Details == > > Series: drm/i915/lspcon: Work around resume failure > URL : https://patchwork.freedesktop.org/series/14280/ > State : warning > > == Summary == > > Series 14280v1 drm/i915/lspcon: Work around resume failure >

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Fix SKL+ 90/270 degree rotated plane coordinate computation

> == Series Details == > > Series: drm/i915: Fix SKL+ 90/270 degree rotated plane coordinate computation > URL : https://patchwork.freedesktop.org/series/14279/ > State : warning > > == Summary == > > Series 14279v1 drm/i915: Fix SKL+ 90/270 degree rotated plane coordinate > computation >

[Intel-gfx] ✗ Fi.CI.BAT: warning for DP audio fixes

== Series Details == Series: DP audio fixes URL : https://patchwork.freedesktop.org/series/14314/ State : warning == Summary == Series 14314v1 DP audio fixes https://patchwork.freedesktop.org/api/1.0/series/14314/revisions/1/mbox/ Test drv_module_reload_basic: skip ->

[Intel-gfx] [PATCH v2 1/2] drm/i915/dp: Enable DP audio stall fix for gen9 platforms

Enabling DP audio stall fix is necessary to play audio over DP HBR2. So, let's set this bit right before enabling the audio codec. Playing audio without setting this bit results in pipe FIFO underruns. Signed-off-by: Dhinakaran Pandiyan ---

[Intel-gfx] [PATCH v2 2/2] drm/i915/dp: BDW cdclk fix for DP audio

According to BSpec, cdclk has to be not less than 432 MHz with DP audio enabled, port width x4, and link rate HBR2 (5.4 GHz) Having a lower cdclk triggers pipe underruns, which then lead to displays continuously cycling off and on. This is essential for DP MST audio as the link is trained at HBR2

[Intel-gfx] [PATCH v2 0/2] DP audio fixes

Playing audio over DP MST or just enabling it during boot caused underruns on BDW and SKL. The underruns are followed by displays cycling on-off. Debugging the underruns led to the understanding this was not a MST specific issue but specific to the HBR2 configuration. There are two solutions

Re: [Intel-gfx] [PATCH 0/2] drm/i915/gvt: fix compilation errors in gtt.c

On 2016.10.24 15:33:34 -0400, Jérémy Lefaure wrote: > On Mon, 24 Oct 2016 10:36:58 +0800 > Zhenyu Wang wrote: > > > On 2016.10.20 18:05:56 -0400, Jérémy Lefaure wrote: > > > This series fixes 2 compilations errors in gvt/gtt.c on 32-bits platform: > > > [PATCH 1/2]

[Intel-gfx] [PATCH] drm/i915/DMC/KBL: Load DMC on KBL using the no_stepping_info array

Currently, for display there is only one DMC image for KBL. Remove the stepping_info table for KBL and use the no_stepping_info array for loading the firmware. v2: Removed the block of code as pointed out by Rodrigo to make the loads as generic as possible. Cc: Rodrigo Vivi

[Intel-gfx] linux-next: manual merge of the mali-dp tree with the drm-misc tree

Hi Liviu, Today's linux-next merge of the mali-dp tree got a conflict in: drivers/gpu/drm/arm/malidp_planes.c between commit: ea0e1ce20f73 ("drm/arm: Use per-plane rotation property") from the drm-misc tree and commit: 9ebb89762c30 ("drm: mali-dp: Refactor plane initialisation") from

[Intel-gfx] [PATCH v7 11/11] drm/i915: Add a kerneldoc summary for i915_perf.c

In particular this tries to capture for posterity some of the early challenges we had with using the core perf infrastructure in case we ever want to revisit adapting perf for device metrics. Cc: Chris Wilson Signed-off-by: Robert Bragg

[Intel-gfx] [PATCH v7 10/11] drm/i915: Add more Haswell OA metric sets

This adds 'compute', 'compute extended', 'memory reads', 'memory writes' and 'sampler balance' metric sets for Haswell. The code is auto generated from an XML description of metric sets, currently maintained in gputop, ref: https://github.com/rib/gputop > gputop-data/oa-*.xml >

[Intel-gfx] [PATCH v7 06/11] drm/i915: Enable i915 perf stream for Haswell OA unit

Gen graphics hardware can be set up to periodically write snapshots of performance counters into a circular buffer via its Observation Architecture and this patch exposes that capability to userspace via the i915 perf interface. v2: Make sure to initialize ->specific_ctx_id when opening,

[Intel-gfx] [PATCH v7 09/11] drm/i915: add oa_event_min_timer_exponent sysctl

The minimal sampling period is now configurable via a dev.i915.oa_min_timer_exponent sysctl parameter. Following the precedent set by perf, the default is the minimum that won't (on its own) exceed the default kernel.perf_event_max_sample_rate default of 10 samples/s. Signed-off-by: Robert

[Intel-gfx] [PATCH v7 08/11] drm/i915: Add dev.i915.perf_stream_paranoid sysctl option

Consistent with the kernel.perf_event_paranoid sysctl option that can allow non-root users to access system wide cpu metrics, this can optionally allow non-root users to access system wide OA counter metrics from Gen graphics hardware. Signed-off-by: Robert Bragg

[Intel-gfx] [PATCH v7 02/11] drm/i915: rename OACONTROL GEN7_OACONTROL

OACONTROL changes quite a bit for gen8, with some bits split out into a per-context OACTXCONTROL register. Rename now before adding more gen7 OA registers Signed-off-by: Robert Bragg Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/gvt/handlers.c

[Intel-gfx] [PATCH v7 01/11] drm/i915: Add i915 perf infrastructure

Adds base i915 perf infrastructure for Gen performance metrics. This adds a DRM_IOCTL_I915_PERF_OPEN ioctl that takes an array of uint64 properties to configure a stream of metrics and returns a new fd usable with standard VFS system calls including read() to read typed and sized records; ioctl()

[Intel-gfx] [PATCH v7 07/11] drm/i915: advertise available metrics via sysfs

Each metric set is given a sysfs entry like: /sys/class/drm/card0/metrics//id This allows userspace to enumerate the specific sets that are available for the current system. The 'id' file contains an unsigned integer that can be used to open the associated metric set via

[Intel-gfx] [PATCH v7 04/11] drm/i915: don't whitelist oacontrol in cmd parser

Being able to program OACONTROL from a non-privileged batch buffer is not sufficient to be able to configure the OA unit. This was originally allowed to help enable Mesa to expose OA counters via the INTEL_performance_query extension, but the current implementation based on programming OACONTROL

[Intel-gfx] [PATCH v7 03/11] drm/i915: return EACCES for check_cmd() failures

check_cmd() is checking whether a command adheres to certain restrictions that ensure it's safe to execute within a privileged batch buffer. Returning false implies a privilege problem, not that the command is invalid. The distinction makes the difference between allowing the buffer to be

Re: [Intel-gfx] [PATCH 2/8] drm/i915/huc: Unified css_header struct for GuC and HuC

On Mon, 2016-10-03 at 11:42 -0700, Anusha Srivatsa wrote: > From: Peter Antoine > > HuC firmware css header has almost exactly same definition as GuC > firmware except for the sw_version. Also, add a new member fw_type > into intel_uc_fw to indicate what kind of fw it

Re: [Intel-gfx] [PATCH 3/8] drm/i915/huc: Add HuC fw loading support

On Thu, 2016-10-13 at 13:54 -0700, Jeff McGee wrote: > On Thu, Oct 13, 2016 at 10:42:42AM -0700, Jeff McGee wrote: > > > > On Mon, Oct 03, 2016 at 11:42:57AM -0700, Anusha Srivatsa wrote: > > > > > > From: Peter Antoine > > > > > > The HuC loading process is similar to

Re: [Intel-gfx] drm/i915: WARN_ON_ONCE(!crtc_clock || cdclk < crtc_clock)

[Detailed post, but please give it a quick scan.] On Wed, 2016-10-12 at 14:06 +0200, Paul Bolle wrote: > On Wed, 2016-10-12 at 14:08 +0300, Joonas Lahtinen wrote: > > Bisecting the offending commit between v4.8 and v4.8.1 would be a good > > start. > > That would be between v4.7 and v4.8. (I

Re: [Intel-gfx] [PATCH i-g-t 2/3] tests/drv_module_reload_basic: Convert sh script to C version.

On Mon, Oct 24, 2016 at 09:05:28PM +0300, Marius Vlad wrote: > On Thu, Oct 20, 2016 at 08:52:23PM +0100, Chris Wilson wrote: > > On Thu, Oct 20, 2016 at 10:36:48PM +0300, Marius Vlad wrote: > > > +static const char *tests[] = { > > > + "gem_alive", "gem_exec_store" > > > +}; > > > > gem_alive is

Re: [Intel-gfx] [PATCH v2 4/8] drm/i915/dp: Print full branch/sink descriptor

On Mon, 2016-10-24 at 22:10 +0300, Jani Nikula wrote: > On Mon, 24 Oct 2016, Imre Deak wrote: > > On Mon, 2016-10-24 at 21:14 +0300, Jani Nikula wrote: > > > On Mon, 24 Oct 2016, Imre Deak wrote: > > > > Extend the branch/sink descriptor info with the

Re: [Intel-gfx] [PATCH 0/2] drm/i915/gvt: fix compilation errors in gtt.c

On Mon, 24 Oct 2016 10:36:58 +0800 Zhenyu Wang wrote: > On 2016.10.20 18:05:56 -0400, Jérémy Lefaure wrote: > > This series fixes 2 compilations errors in gvt/gtt.c on 32-bits platform: > > [PATCH 1/2] drm/i915/gvt: fix bad 32 bit shift in gtt > > [PATCH 2/2]

Re: [Intel-gfx] [PATCH v2 4/8] drm/i915/dp: Print full branch/sink descriptor

On Mon, 24 Oct 2016, Imre Deak wrote: > On Mon, 2016-10-24 at 21:14 +0300, Jani Nikula wrote: >> On Mon, 24 Oct 2016, Imre Deak wrote: >> > Extend the branch/sink descriptor info with the missing device ID >> > field. While at it also read out all the

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/lspcon: Work around resume failure

On Mon, 2016-10-24 at 21:58 +0300, Jani Nikula wrote: > On Mon, 24 Oct 2016, Imre Deak wrote: > > On ma, 2016-10-24 at 17:16 +, Patchwork wrote: > > > == Series Details == > > > > > > Series: drm/i915/lspcon: Work around resume failure > > > URL   :

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/lspcon: Work around resume failure

On Mon, 24 Oct 2016, Imre Deak wrote: > On ma, 2016-10-24 at 17:16 +, Patchwork wrote: >> == Series Details == >> >> Series: drm/i915/lspcon: Work around resume failure >> URL   : https://patchwork.freedesktop.org/series/14280/ >> State : warning >> >> == Summary == >>

Re: [Intel-gfx] [PATCH v2 4/8] drm/i915/dp: Print full branch/sink descriptor

On Mon, 2016-10-24 at 21:14 +0300, Jani Nikula wrote: > On Mon, 24 Oct 2016, Imre Deak wrote: > > Extend the branch/sink descriptor info with the missing device ID > > field. While at it also read out all the descriptor registers in one > > transfer and make the debug print

Re: [Intel-gfx] [PATCH v2 7/8] drm/i915/lspcon: Get DDC adapter via container_of() instead of cached ptr

On Mon, 24 Oct 2016, Imre Deak wrote: > We can use the container_of() magic to get to the DDC adapter, so no > need for caching a pointer to it. We'll also need to get at the intel_dp > ptr in the following patch, so add a helper that can be used for both > purposes. > > Cc:

Re: [Intel-gfx] [PATCH v2 5/8] drm/i915/lspcon: Fail LSPCON probe if the start of DPCD can't be read

On Mon, 24 Oct 2016, Imre Deak wrote: > All types of DP devices (eDP, DP sink, DP branch) will fail their probe > if the start of DPCD can't be read. The LSPCON PCON functionality also > depends on accessing this area, so fail the probe if the read fails. > > Cc: Shashank

Re: [Intel-gfx] [PATCH v2 6/8] drm/i915/dp: Read DP descriptor for eDP and LSPCON too

On Mon, 24 Oct 2016, Imre Deak wrote: > As for external DP sink and branch devices read and print the DP > descriptor for eDP and LSPCON devices as well to aid debugging. > > v2: > - Split out this change to a separate patch. (Jani) > > Cc: Jani Nikula

Re: [Intel-gfx] [PATCH v3] drm/edid: Only print the bad edid when aborting

On Mon, Oct 24, 2016 at 7:38 AM, Chris Wilson wrote: > Currently, if drm.debug is enabled, we get a DRM_ERROR message on the > intermediate edid reads. This causes transient failures in CI which > flags up the sporadic EDID read failures, which are recovered by >

Re: [Intel-gfx] [PATCH 1/5] drm: Add atomic helper to redo a modeset on current mode

On Mon, Oct 24, 2016 at 3:12 AM, Daniel Vetter wrote: > On Mon, Oct 24, 2016 at 9:00 AM, Manasi Navare > wrote: >>> I guess we just need to do some additional work on top to make sure the >>> vblank ioctl can't see invalid state. Which would then again

Re: [Intel-gfx] [PATCH v2 4/8] drm/i915/dp: Print full branch/sink descriptor

On Mon, 24 Oct 2016, Imre Deak wrote: > Extend the branch/sink descriptor info with the missing device ID > field. While at it also read out all the descriptor registers in one > transfer and make the debug print more compact. > > v2: (Jani) > - Cache the descriptor in

Re: [Intel-gfx] [PATCH i-g-t 2/3] tests/drv_module_reload_basic: Convert sh script to C version.

On Fri, Oct 21, 2016 at 12:39:22PM +0300, Petri Latvala wrote: > > > On 10/20/2016 10:36 PM, Marius Vlad wrote: > > Signed-off-by: Marius Vlad > > --- > > tests/Makefile.sources | 2 +- > > tests/drv_module_reload_basic | 97 --- > >

Re: [Intel-gfx] [PATCH i-g-t 2/3] tests/drv_module_reload_basic: Convert sh script to C version.

On Thu, Oct 20, 2016 at 08:52:23PM +0100, Chris Wilson wrote: > On Thu, Oct 20, 2016 at 10:36:48PM +0300, Marius Vlad wrote: > > +static const char *tests[] = { > > + "gem_alive", "gem_exec_store" > > +}; > > gem_alive is just a single ioctl query, simpler and move obvious to do > it inline.

Re: [Intel-gfx] [PATCH i-g-t 1/3] lib/{igt_sysfs, igt_aux}: Make available to other users kick_fbcon() (unbind_fbcon()), and added helpers to igt_aux.

On Thu, Oct 20, 2016 at 09:09:17PM +0100, Chris Wilson wrote: > On Thu, Oct 20, 2016 at 10:36:47PM +0300, Marius Vlad wrote: > > +int > > +igt_pkill(int sig, const char *comm) > > +{ > > + int err = 0, try = 5; > > + PROCTAB *proc; > > + proc_t *proc_info; > > + > > + proc =

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/lspcon: Work around resume failure

== Series Details == Series: drm/i915/lspcon: Work around resume failure URL : https://patchwork.freedesktop.org/series/14280/ State : warning == Summary == Series 14280v1 drm/i915/lspcon: Work around resume failure https://patchwork.freedesktop.org/api/1.0/series/14280/revisions/1/mbox/

Re: [Intel-gfx] [PATCH v2 1/8] drm/dp: Factor out helper to distinguish between branch and sink devices

On Mon, 24 Oct 2016, Imre Deak wrote: > This check is open-coded in a few places, so it makes sense to simplify > things by having a helper for it similar to the rest of DPCD feature > helpers. > > v2: (Jani) > - Move the helper to drm_dp_helper.h. > - Split out this change

[Intel-gfx] [PATCH 4/4] tests/kms_draw_crc: add support for Y tiling

From: Paulo Zanoni This is the program that's supposed to test lib/igt_draw. We just added Y tiling support for the library, so add the tests now. Change-Id: Id0a805aab2d804cf82c188326a8562f0ec75c874 Signed-off-by: Paulo Zanoni ---

[Intel-gfx] [PATCH 2/4] lib/igt_draw: Add Y-tiling support

This patch adds Y-tiling support for igt_draw_rect function. Change-Id: I139e9773b7df286febe9ffa3dce358df079dac14 Signed-off-by: Praveen Paneri --- lib/igt_draw.c | 148 ++--- 1 file changed, 110 insertions(+), 38

[Intel-gfx] [PATCH v2 6/8] drm/i915/dp: Read DP descriptor for eDP and LSPCON too

As for external DP sink and branch devices read and print the DP descriptor for eDP and LSPCON devices as well to aid debugging. v2: - Split out this change to a separate patch. (Jani) Cc: Jani Nikula Signed-off-by: Imre Deak ---

[Intel-gfx] [PATCH v2 8/8] drm/i915/lspcon: Add workaround for resuming in PCON mode

On my APL the LSPCON firmware resumes in PCON mode as opposed to the expected LS mode. It also appears to be in a state where AUX DPCD reads will succeed but return garbage recovering only after a few hundreds of milliseconds. After the recovery time DPCD reads will result in the correct values

[Intel-gfx] [PATCH v2 0/8] drm/i915/lspcon: Work around resume failure

This is v2 of [1] addressing the review comments from Jani and Shashank. Meanwhile I also checked that the SKL-6700 machine reported in bugzilla (see the last patch) had the same problem as the APL where I saw this first and the workaround seems to solve the problem there too. [1]

[Intel-gfx] [PATCH v2 1/8] drm/dp: Factor out helper to distinguish between branch and sink devices

This check is open-coded in a few places, so it makes sense to simplify things by having a helper for it similar to the rest of DPCD feature helpers. v2: (Jani) - Move the helper to drm_dp_helper.h. - Split out this change to a separate patch. Cc: Jani Nikula Cc:

[Intel-gfx] [PATCH v2 2/8] drm/i915/dp: Remove debug dependency of DPCD SW/HW revision read

Performing DPCD AUX reads based on debug settings may introduce obscure bugs in other places that depend on the read being done (or being not done). To reduce the uncertainty perform the reads unconditionally. Cc: Mika Kahola Suggested-by: Jani Nikula

[Intel-gfx] [PATCH] drm/i915: Fix SKL+ 90/270 degree rotated plane coordinate computation

From: Ville Syrjälä Pass the framebuffer size in .16 fixed point coordinates to drm_rect_rotate() since that's what the source coordinates are as well at this stage. We used to do this part of the computation in integer coordinates, but that got changed when moving

Re: [Intel-gfx] [PATCH] drm/i915/dp: add lane_count check in intel_dp_check_link_status

On Thu, 20 Oct 2016, Matthew Auld wrote: > Currently it's entirely possible to go through the link training step > without first determining the lane_count, which is silly since we end up > doing a bunch of aux transfers of size = 0, as highlighted by >

Re: [Intel-gfx] [PATCH] drm/i915: remove AGP dependency from DRM_I915 kconfig help text

On Mon, 24 Oct 2016, Ville Syrjälä wrote: > On Mon, Oct 24, 2016 at 10:52:59AM +0200, Daniel Vetter wrote: >> On Fri, Oct 21, 2016 at 12:14:17PM +0300, Jani Nikula wrote: >> > We haven't required AGP since 3e99a6b95614 ("drm/i915: Stop depending >> > upon

[Intel-gfx] [Regression report] Weekly regression report WW43

Total regressions: 46 This week regressions:4 +---+---+++ | BugId | Summary | Created on | Bisect | +---+---+++ | 98402

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/5] drm/i915: Move user fault tracking to a separate list

== Series Details == Series: series starting with [CI,1/5] drm/i915: Move user fault tracking to a separate list URL : https://patchwork.freedesktop.org/series/14261/ State : success == Summary == Series 14261v1 Series without cover letter

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/edid: Only print the bad edid when aborting (rev3)

> == Summary == > > Series 13747v3 drm/edid: Only print the bad edid when aborting > https://patchwork.freedesktop.org/api/1.0/series/13747/revisions/3/mbox/ > > Test drv_module_reload_basic: > dmesg-warn -> PASS (fi-skl-6700hq) > Test gem_exec_suspend: > Subgroup

Re: [Intel-gfx] i915 4.8.3: cdclk < crtc_clock

Hi Daniel, On 24/10/2016 12:54, Daniel J Blueman wrote: Hi Tvrtko, I'm seeing this warning [1] on a Skylake Dell XPS 15 9550 with the internal 3840x2160 panel with 4.8.4. Let me know if you're interested in any debug. I suggest best to add your logs to

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/edid: Only print the bad edid when aborting (rev3)

== Series Details == Series: drm/edid: Only print the bad edid when aborting (rev3) URL : https://patchwork.freedesktop.org/series/13747/ State : warning == Summary == Series 13747v3 drm/edid: Only print the bad edid when aborting

[Intel-gfx] [CI 4/5] drm/i915: Remove RPM sequence checking

We only used the RPM sequence checking inside the lowlevel GTT accessors, when we had to rely on callers taking the wakeref on our behalf. Now that we take the RPM wakeref inside the GTT management routines themselves, we can forgo the sanitycheck of the callers. Signed-off-by: Chris Wilson

[Intel-gfx] [CI 3/5] drm/i915: Remove superfluous locking around userfault_list

Now that we have reduced the access to the list to either (a) under the struct_mutex whilst holding the RPM wakeref (so that concurrent writers to the list are serialised by struct_mutex) and (b) under the atomic runtime suspend (which cannot run concurrently with any other accessor due to the

[Intel-gfx] [CI 1/5] drm/i915: Move user fault tracking to a separate list

We want to decouple RPM and struct_mutex, but currently RPM has to walk the list of bound objects and remove userspace mmapping before we suspend (otherwise userspace may continue to access the GTT whilst it is powered down). This currently requires the struct_mutex to walk the bound_list, but if

[Intel-gfx] [CI 5/5] drm/i915: Move fence cancellation to runtime suspend

At the moment, we have dependency on the RPM as a barrier itself in both i915_gem_release_all_mmaps() and i915_gem_restore_fences(). i915_gem_restore_fences() is also called along !runtime pm paths, but we can move the markup of lost fences alongside releasing the mmaps into a common

[Intel-gfx] [CI 2/5] drm/i915: Use RPM as the barrier for controlling user mmap access

We can remove the false coupling between RPM and struct mutex by the observation that we can use the RPM wakeref as the barrier around user mmap access. That is as we tear down the user's PTE atomically from within rpm suspend and then to fault in new PTE requires the rpm wakeref, means that no

[Intel-gfx] i915 4.8.3: cdclk < crtc_clock

Hi Tvrtko, I'm seeing this warning [1] on a Skylake Dell XPS 15 9550 with the internal 3840x2160 panel with 4.8.4. Let me know if you're interested in any debug. Many thanks! Daniel -- [1] [ 2236.760626] WARNING: CPU: 1 PID: 1150 at

Re: [Intel-gfx] [RESEND PATCH 2/6] drm/i915: Pass atomic state to intel_audio_codec_enable

On Mon, Oct 24, 2016 at 12:47:21PM +0200, Maarten Lankhorst wrote: > Op 24-10-16 om 12:17 schreef Ville Syrjälä: > > On Mon, Oct 24, 2016 at 12:12:59PM +0200, Maarten Lankhorst wrote: > >> Op 24-10-16 om 12:04 schreef Ville Syrjälä: > >>> On Mon, Oct 24, 2016 at 10:45:36AM +0200, Maarten Lankhorst

[Intel-gfx] [PATCH v3] drm/edid: Only print the bad edid when aborting

Currently, if drm.debug is enabled, we get a DRM_ERROR message on the intermediate edid reads. This causes transient failures in CI which flags up the sporadic EDID read failures, which are recovered by rereading the EDID automatically. This patch combines the reporting done by drm_do_get_edid()

Re: [Intel-gfx] [PATCH v2] drm/edid: Only print the bad edid when aborting

On Mon, Oct 24, 2016 at 12:33:41PM +0100, Chris Wilson wrote: > for (j = 1; j <= edid[0x7e]; j++) { > - u8 *block = edid + (valid_extensions + 1) * EDID_LENGTH; > + u8 *block = edid + j * EDID_LENGTH; > > for (i = 0; i < 4; i++) { >

[Intel-gfx] [PATCH v2] drm/edid: Only print the bad edid when aborting

Currently, if drm.debug is enabled, we get a DRM_ERROR message on the intermediate edid reads. This causes transient failures in CI which flags up the sporadic EDID read failures, which are recovered by rereading the EDID automatically. This patch combines the reporting done by drm_do_get_edid()

Re: [Intel-gfx] [PATCH] drm/i915: fix comment referencing imaginary functions

On Fri, Oct 21, 2016 at 02:57:28PM +0100, Chris Wilson wrote: > On Fri, Oct 21, 2016 at 04:00:10PM +0300, Mika Kuoppala wrote: > > Chris Wilson writes: > > > > > On Fri, Oct 21, 2016 at 02:16:46PM +0200, Arkadiusz Hiler wrote: > > >> On Wed, Aug 24, 2016 at 05:03:11PM

Re: [Intel-gfx] [RESEND PATCH 2/6] drm/i915: Pass atomic state to intel_audio_codec_enable

Op 24-10-16 om 12:17 schreef Ville Syrjälä: > On Mon, Oct 24, 2016 at 12:12:59PM +0200, Maarten Lankhorst wrote: >> Op 24-10-16 om 12:04 schreef Ville Syrjälä: >>> On Mon, Oct 24, 2016 at 10:45:36AM +0200, Maarten Lankhorst wrote: Op 21-10-16 om 16:16 schreef Ville Syrjälä: > On Fri, Oct

Re: [Intel-gfx] [RESEND PATCH 4/6] drm/i915: Update atomic modeset state synchronously

Op 24-10-16 om 12:19 schreef Ville Syrjälä: > On Mon, Oct 24, 2016 at 12:07:30PM +0200, Maarten Lankhorst wrote: >> Op 21-10-16 om 16:08 schreef Ville Syrjälä: >>> On Wed, Oct 19, 2016 at 03:55:37PM +0200, Maarten Lankhorst wrote: All of this state should be updated as soon as possible. It

Re: [Intel-gfx] [PATCH v2 1/6] drm/msm/mdp5: Use per-plane rotation property

On 10/24/2016 03:45 PM, Ville Syrjälä wrote: On Mon, Oct 24, 2016 at 03:33:18PM +0530, Archit Taneja wrote: Hi Ville, On 10/22/2016 12:52 AM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä The global mode_config.rotation_property is going away,

Re: [Intel-gfx] [RESEND PATCH 2/6] drm/i915: Pass atomic state to intel_audio_codec_enable

On Mon, Oct 24, 2016 at 12:12:59PM +0200, Maarten Lankhorst wrote: > Op 24-10-16 om 12:04 schreef Ville Syrjälä: > > On Mon, Oct 24, 2016 at 10:45:36AM +0200, Maarten Lankhorst wrote: > >> Op 21-10-16 om 16:16 schreef Ville Syrjälä: > >>> On Fri, Oct 21, 2016 at 05:04:46PM +0300, Ville Syrjälä

Re: [Intel-gfx] [PATCH v2 1/6] drm/msm/mdp5: Use per-plane rotation property

On Mon, Oct 24, 2016 at 03:33:18PM +0530, Archit Taneja wrote: > Hi Ville, > > On 10/22/2016 12:52 AM, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > The global mode_config.rotation_property is going away, switch over to > > per-plane

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Give write permission to gt_boost_freq_mhz

Hi Daniel, Chris, Sorry for not clarifying the purpose and if any misunderstanding. This was to allow running at fixed frequency. Kindly clarify if it is intentional to have _store routine without S_IWUSR. On 10/24/2016 2:42 PM, Chris Wilson wrote: On Mon, Oct 24, 2016 at 11:05:13AM +0200,

Re: [Intel-gfx] [PATCH igt] igt/kms_setmode: Clear all connectors before starting the test

On Mon, Oct 24, 2016 at 11:04:35AM +0200, Daniel Vetter wrote: > On Sat, Oct 22, 2016 at 09:32:41AM +0100, Chris Wilson wrote: > > Before we start trying random combinations of connectors and CRTCs, we > > should first ensure we have a blank slate so that if we only change a > > subset of the CRTC

Re: [Intel-gfx] [PATCH] drm/i915: remove AGP dependency from DRM_I915 kconfig help text

On Mon, Oct 24, 2016 at 10:52:59AM +0200, Daniel Vetter wrote: > On Fri, Oct 21, 2016 at 12:14:17PM +0300, Jani Nikula wrote: > > We haven't required AGP since 3e99a6b95614 ("drm/i915: Stop depending > > upon CONFIG_AGP_INTEL"). Split/rearrange the paragraphs a bit while at > > it. > > > >

[Intel-gfx] [PATCH igt] igt/kms_setmode: Test that the vblank interval matches the dotclock

As we allow userspace to set the dotclock, we should try to respect it! Userpsace will try to set its frametimings based upon the dotclock, so ideally it should match the measured vblank interval. Signed-off-by: Chris Wilson --- tests/kms_setmode.c | 75

Re: [Intel-gfx] [RESEND PATCH 4/6] drm/i915: Update atomic modeset state synchronously

Op 21-10-16 om 16:08 schreef Ville Syrjälä: > On Wed, Oct 19, 2016 at 03:55:37PM +0200, Maarten Lankhorst wrote: >> All of this state should be updated as soon as possible. It shouldn't be >> done later because then future updates may not depend on it. >> >> Signed-off-by: Maarten Lankhorst

Re: [Intel-gfx] [RESEND PATCH 2/6] drm/i915: Pass atomic state to intel_audio_codec_enable

On Mon, Oct 24, 2016 at 10:45:36AM +0200, Maarten Lankhorst wrote: > Op 21-10-16 om 16:16 schreef Ville Syrjälä: > > On Fri, Oct 21, 2016 at 05:04:46PM +0300, Ville Syrjälä wrote: > >> On Wed, Oct 19, 2016 at 03:55:35PM +0200, Maarten Lankhorst wrote: > >>> drm_select_eld requires

Re: [Intel-gfx] [PATCH v2 1/6] drm/msm/mdp5: Use per-plane rotation property

Hi Ville, On 10/22/2016 12:52 AM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä The global mode_config.rotation_property is going away, switch over to per-plane rotation_property. I was trying to test this on msm/drm using modetest. The 180

Re: [Intel-gfx] [PATCH v2] drm/i915: Move fence cancellation to runtime suspend

On pe, 2016-10-21 at 15:05 +0100, Chris Wilson wrote: > At the moment, we have dependency on the RPM as a barrier itself in both > i915_gem_release_all_mmaps() and i915_gem_restore_fences(). > i915_gem_restore_fences() is also called along !runtime pm paths, but we > can move the markup of lost

Re: [Intel-gfx] [PATCH igt] igt/kms_flip: Calibrate timestamp errors

On Mon, Oct 24, 2016 at 11:14:31AM +0200, Daniel Vetter wrote: > On Mon, Oct 24, 2016 at 09:54:52AM +0100, Chris Wilson wrote: > Also with this patch we should be able to throw out the hacks for tv-out. > I only added those because the reported mode-timings are massively off > (due to the magic tv

Re: [Intel-gfx] [PATCH 1/4] MAINTAINERS: Add "B:" for URI where to file bugs

On 20/10/16 23:22, Jani Nikula wrote: Different subsystems and drivers have different preferences for where to file bugs and what information to include. Add "B:" entry for specifying the URI for the bug tracker directly, a web page for detailed info on filing bugs, or a mailto: URI. Cc: Daniel

Re: [Intel-gfx] [PATCH igt] igt/kms_setmode: Clear all connectors before starting the test

On Mon, Oct 24, 2016 at 11:04:35AM +0200, Daniel Vetter wrote: > On Sat, Oct 22, 2016 at 09:32:41AM +0100, Chris Wilson wrote: > > Before we start trying random combinations of connectors and CRTCs, we > > should first ensure we have a blank slate so that if we only change a > > subset of the CRTC

Re: [Intel-gfx] [PATCH igt] igt/kms_flip: Calibrate timestamp errors

On Mon, Oct 24, 2016 at 09:54:52AM +0100, Chris Wilson wrote: > We assert that the interval between a vblank and a flip corresponds with > the computed frametime derived from the modeline. However, historically > the dotclock is unreliable (in error of about 1%) for VBT supplied data > about LVDS

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Give write permission to gt_boost_freq_mhz

On Mon, Oct 24, 2016 at 11:05:13AM +0200, Daniel Vetter wrote: > On Mon, Oct 24, 2016 at 10:00:49AM +0530, Sagar Arun Kamble wrote: > > And uabi change with 0 commit message. This needs to be _much_ better ;-) A case where the author cut'n'paste the wrong thing because he can't read

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Give write permission to gt_boost_freq_mhz

On Mon, Oct 24, 2016 at 11:05:13AM +0200, Daniel Vetter wrote: > On Mon, Oct 24, 2016 at 10:00:49AM +0530, Sagar Arun Kamble wrote: > > And uabi change with 0 commit message. This needs to be _much_ better ;-) Also the patch subject isn't really useful: It's a literal translation from the patch

Re: [Intel-gfx] [PATCH igt] igt/kms_setmode: Clear all connectors before starting the test

On Sat, Oct 22, 2016 at 09:32:41AM +0100, Chris Wilson wrote: > Before we start trying random combinations of connectors and CRTCs, we > should first ensure we have a blank slate so that if we only change a > subset of the CRTC we do not conflict with a residual setup on the other > CRTC. > >

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Give write permission to gt_boost_freq_mhz

On Mon, Oct 24, 2016 at 10:00:49AM +0530, Sagar Arun Kamble wrote: And uabi change with 0 commit message. This needs to be _much_ better ;-) -Daniel > Cc: Chris Wilson > Signed-off-by: Sagar Arun Kamble > --- >

Re: [Intel-gfx] [PATCH 7/8] drm/i915/gen9+: Program watermarks as a separate step during evasion

Op 20-10-16 om 20:35 schreef Matt Roper: > On Wed, Oct 12, 2016 at 03:28:20PM +0200, Maarten Lankhorst wrote: >> Instead of running the watermark updates from the callbacks run >> them from a separate hook atomic_evade_watermarks. >> >> This also gets rid of the global skl_results, which was

Re: [Intel-gfx] [PATCH] drm/i915: Always send a hotplug event after resume

On Fri, Oct 21, 2016 at 04:27:53PM +0100, Chris Wilson wrote: > On Fri, Oct 21, 2016 at 11:16:07AM +0100, Chris Wilson wrote: > > Curently after resume we reset all connector status to unknown and then > > try to tell userspace about the probable changes (e.g. a laptop being > > unplugged from one

[Intel-gfx] [PATCH igt] igt/kms_flip: Calibrate timestamp errors

We assert that the interval between a vblank and a flip corresponds with the computed frametime derived from the modeline. However, historically the dotclock is unreliable (in error of about 1%) for VBT supplied data about LVDS panels - the situation looks to be much improved with eDP at least.

Re: [Intel-gfx] [PATCH] drm/i915: remove AGP dependency from DRM_I915 kconfig help text

On Fri, Oct 21, 2016 at 12:14:17PM +0300, Jani Nikula wrote: > We haven't required AGP since 3e99a6b95614 ("drm/i915: Stop depending > upon CONFIG_AGP_INTEL"). Split/rearrange the paragraphs a bit while at > it. > > Signed-off-by: Jani Nikula Reviewed-by: Daniel Vetter

Re: [Intel-gfx] Redo a modeset on link training failure

On Fri, Oct 21, 2016 at 12:35:44PM +0300, Ville Syrjälä wrote: > On Thu, Oct 20, 2016 at 07:31:53PM -0700, Manasi Navare wrote: > > Hi Ville, > > > > I have implemented the code that we discussed where if the link training > > fails, it would validate the modes on the new constraints and call > >

Re: [Intel-gfx] [PATCH 8/8] drm/i915/gen9+: Preserve old allocation from crtc_state.

Op 21-10-16 om 00:09 schreef Matt Roper: > On Wed, Oct 12, 2016 at 03:28:21PM +0200, Maarten Lankhorst wrote: >> This is the last bit required for making nonblocking modesets work >> correctly. The state in intel_crtc->hw_ddb is not updated until >> somewhere in atomic commit, while the previous

Re: [Intel-gfx] [PATCH i-g-t 0/3] Convert sh scripts to C variants.

On Mon, Oct 24, 2016 at 10:46:14AM +0200, Daniel Vetter wrote: > On Fri, Oct 21, 2016 at 10:38:17AM +0300, Joonas Lahtinen wrote: > > On pe, 2016-10-21 at 00:00 +0300, Jani Nikula wrote: > > > > On Thu, 20 Oct 2016, Marius Vlad wrote: > > > > > > > > This series adds

Re: [Intel-gfx] [RESEND PATCH 4/6] drm/i915: Update atomic modeset state synchronously

Op 21-10-16 om 16:21 schreef Ville Syrjälä: > On Wed, Oct 19, 2016 at 03:55:37PM +0200, Maarten Lankhorst wrote: >> All of this state should be updated as soon as possible. It shouldn't be >> done later because then future updates may not depend on it. >> >> Signed-off-by: Maarten Lankhorst

Re: [Intel-gfx] [PATCH i-g-t 0/3] Convert sh scripts to C variants.

On Fri, Oct 21, 2016 at 10:38:17AM +0300, Joonas Lahtinen wrote: > On pe, 2016-10-21 at 00:00 +0300, Jani Nikula wrote: > > > On Thu, 20 Oct 2016, Marius Vlad wrote: > > > > > > This series adds some library support to help converting sh > > > scripts to C version.

Re: [Intel-gfx] [RESEND PATCH 2/6] drm/i915: Pass atomic state to intel_audio_codec_enable

Op 21-10-16 om 16:16 schreef Ville Syrjälä: > On Fri, Oct 21, 2016 at 05:04:46PM +0300, Ville Syrjälä wrote: >> On Wed, Oct 19, 2016 at 03:55:35PM +0200, Maarten Lankhorst wrote: >>> drm_select_eld requires mode_config.mutex and connection_mutex >>> because it looks at the connector list and at

Re: [Intel-gfx] [RESEND PATCH 3/6] drm/edid: Remove drm_select_eld

Op 21-10-16 om 16:17 schreef Ville Syrjälä: > On Fri, Oct 21, 2016 at 05:05:16PM +0300, Ville Syrjälä wrote: >> On Wed, Oct 19, 2016 at 03:55:36PM +0200, Maarten Lankhorst wrote: >>> The only user was i915, which is now gone. >>> >>> Signed-off-by: Maarten Lankhorst

  1   2   >