Re: [Intel-gfx] [PATCH v4 1/2] drm/i915/dp: Enable DP audio stall fix for gen9 platforms

On Sat, 2016-11-05 at 21:40 +0200, Jani Nikula wrote: > On Fri, 04 Nov 2016, "Pandiyan, Dhinakaran" > wrote: > > On Fri, 2016-11-04 at 17:48 +0200, Jani Nikula wrote: > >> On Wed, 26 Oct 2016, Dhinakaran Pandiyan > >> wrote: > >> >

Re: [Intel-gfx] [PATCH v4 1/2] drm/i915/dp: Enable DP audio stall fix for gen9 platforms

On Fri, 04 Nov 2016, "Pandiyan, Dhinakaran" wrote: > On Fri, 2016-11-04 at 17:48 +0200, Jani Nikula wrote: >> On Wed, 26 Oct 2016, Dhinakaran Pandiyan >> wrote: >> > Enabling DP audio stall fix is necessary to play audio over DP

Re: [Intel-gfx] [PATCH v4 2/3] drm/i915: Make sure engines are idle during GPU idling in LR mode

On Sat, Nov 05, 2016 at 10:36:00AM +0200, Imre Deak wrote: > We assume that the GPU is idle once receiving the seqno via the last > request's user interrupt. In execlist mode the corresponding context > completed interrupt can be delayed though and until this latter > interrupt arrives we consider

Re: [Intel-gfx] [PATCH v4 1/3] drm/i915: Avoid early GPU idling due to race with new request

On Sat, Nov 05, 2016 at 10:35:59AM +0200, Imre Deak wrote: > There is a small race where a new request can be submitted and retired > after the idle worker started to run which leads to idling the GPU too > early. Fix this by deferring the idling to the pending instance of the > worker. > > This

Re: [Intel-gfx] [PATCH] drm: move allocation out of drm_get_format_name()

On Sat, Nov 5, 2016 at 12:38 PM, Eric Engestrom wrote: > On Saturday, 2016-11-05 13:11:36 +0100, Christian König wrote: >> Am 05.11.2016 um 02:33 schrieb Eric Engestrom: >> > +typedef char drm_format_name_buf[32]; >> >> Please don't use a typedef for this, just define the

Re: [Intel-gfx] [PATCH] drm: move allocation out of drm_get_format_name()

On Saturday, 2016-11-05 13:11:36 +0100, Christian König wrote: > Am 05.11.2016 um 02:33 schrieb Eric Engestrom: > > +typedef char drm_format_name_buf[32]; > > Please don't use a typedef for this, just define the maximum size of > characters the function might write somewhere. > > See the kernel

Re: [Intel-gfx] [PATCH] drm: move allocation out of drm_get_format_name()

Am 05.11.2016 um 02:33 schrieb Eric Engestrom: +typedef char drm_format_name_buf[32]; Please don't use a typedef for this, just define the maximum size of characters the function might write somewhere. See the kernel coding style as well: In general, a pointer, or a struct that has

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v4,1/3] drm/i915: Avoid early GPU idling due to race with new request

== Series Details == Series: series starting with [v4,1/3] drm/i915: Avoid early GPU idling due to race with new request URL : https://patchwork.freedesktop.org/series/14877/ State : failure == Summary == Series 14877v1 Series without cover letter

[Intel-gfx] [PATCH v4 2/3] drm/i915: Make sure engines are idle during GPU idling in LR mode

We assume that the GPU is idle once receiving the seqno via the last request's user interrupt. In execlist mode the corresponding context completed interrupt can be delayed though and until this latter interrupt arrives we consider the request to be pending on the ELSP submit port. This can cause

[Intel-gfx] [PATCH v4 3/3] drm/i915: Add assert for no pending GPU requests during suspend/resume in LR mode

During resume we will reset the SW/HW tracking for each ring head/tail pointers and so are not prepared to replay any pending requests (as opposed to GPU reset time). Add an assert for this both to the suspend and the resume code. v2: - Check for ELSP port idle already during suspend and check

[Intel-gfx] [PATCH v4 1/3] drm/i915: Avoid early GPU idling due to race with new request

There is a small race where a new request can be submitted and retired after the idle worker started to run which leads to idling the GPU too early. Fix this by deferring the idling to the pending instance of the worker. This scenario was pointed out by Chris. Cc: Chris Wilson

Re: [Intel-gfx] [PATCH] drm: move allocation out of drm_get_format_name()

For the vmwgfx part: Acked-by: Thomas Hellstrom On 11/05/2016 08:33 AM, Eric Engestrom wrote: > Fixes: 90844f00049e9f42573fd31d7c32e8fd31d3fd07 > > drm: make drm_get_format_name thread-safe > > Signed-off-by: Eric Engestrom > [danvet: