[Intel-gfx] [PATCH 3/5] drm/i915/guc: Move guc_{send, recv}() to intel_uc.c

guc_send(), guc_recv() and related functions were introduced in the i915_guc_submission.c and their scope was limited only to that file. Those are not submission specific though. This patch moves moves them to intel_uc.c with intel_ prefix added. v2: rename intel_guc_log_* functions and clean up

[Intel-gfx] [PATCH 5/5] drm/i915/guc: Remove spurious include

Cc: Chris Wilson Cc: Michal Winiarski Signed-off-by: Arkadiusz Hiler Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_guc_submission.c | 1 - 1 file changed, 1 deletion(-) diff

[Intel-gfx] [PATCH 4/5] drm/i915/guc: Init send_mutex in intel_uc_init_early()

send_mutex is used to serialise communication with GuC via intel_guc_send(). Since functions that utilize it are no longer limited to submission, initialization should be handled as a part of general setup. v2: move initialization to *_early() Cc: Chris Wilson Cc:

[Intel-gfx] [PATCH 1/5] drm/i915: Rename intel_guc.h to intel_uc.h

GuC is not the only one micro controller we have. There are also HuC and DMC. Making the file more general will help with code organization. Cc: Chris Wilson Cc: Michal Winiarski Signed-off-by: Arkadiusz Hiler

[Intel-gfx] [PATCH 2/5] drm/i915/guc: Drop guc2host/host2guc from names

To facilitate code reorganization we are renaming everything that contains guc2host or host2guc. host2guc_action() and host2guc_action_response() become guc_send() and guc_recv() respectively. Other host2guc_*() functions become simply guc_*(). Other entities are renamed basing on context they

[Intel-gfx] [PATCH v3 0/5] GuC code reorganization

With HuC being imminent we could benefit from some code reorganization. There will be more uC than just GuC so we should name files accordingly. There is also need to use host2guc_*() family of functions, which are currently limited to submission only. In effect host2guc and guc2host entities

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Use helper for setting plane->state->fb

== Series Details == Series: series starting with [1/3] drm/i915: Use helper for setting plane->state->fb URL : https://patchwork.freedesktop.org/series/15972/ State : success == Summary == Series 15972v1 Series without cover letter

[Intel-gfx] [PATCH 3/3] drm: Track framebuffer references at the point of assignment

We can simplify the code greatly if both legacy and atomic paths updated the references as they assigned the framebuffer to the planes. Long before framebuffer reference counting was added, the code had to keep the old_fb around until after the operation was completed - but now we can simply leave

[Intel-gfx] [PATCH 2/3] drm: Introduce drm_framebuffer_assign()

In a couple of places currently, and with the intent to add more, we update a pointer to a framebuffer to hold a new fb reference (evicting the old). Signed-off-by: Chris Wilson --- drivers/gpu/drm/drm_atomic.c | 8 ++-- include/drm/drm_framebuffer.h | 18

[Intel-gfx] [PATCH 1/3] drm/i915: Use helper for setting plane->state->fb

We are told not to set plane_state->fb directly, but use drm_atomic_set_fb_for_plane() instead. Using the helper, means one less piece of code that needs fixing should the interface change... Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_display.c | 6

Re: [Intel-gfx] [i-g-t PATCH v14 3/6] lib: add igt_dummyload

On Fri, Nov 25, 2016 at 04:41:14PM +0200, Abdiel Janulgue wrote: > A lot of igt testcases need some GPU workload to make sure a race > window is big enough. Unfortunately having a fixed amount of > workload leads to spurious test failures or overly long runtimes > on some fast/slow platforms. This

[Intel-gfx] [PATCH] dim: Check for "Reviewed-by" on patches

--- dim | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dim b/dim index a1a821d..a9ba6b3 100755 --- a/dim +++ b/dim @@ -855,6 +855,9 @@ function checkpatch_commit git --no-pager log --oneline -1 $commit $cmd | scripts/checkpatch.pl -q --emacs --strict - || true + if

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Don't sanitize has_decoupled_mmio if platform is not broxton (rev2)

On Thu, 2016-11-24 at 17:31 +0200, Ville Syrjälä wrote: > On Thu, Nov 24, 2016 at 03:09:30PM +, Saarinen, Jani wrote: > > > > > > > > == Series Details == > > > > > > Series: drm/i915: Don't sanitize has_decoupled_mmio if platform is not > > > broxton (rev2) > > > URL   :

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Pass dev_priv to intel_setup_outputs() (rev2)

On Wed, 2016-11-23 at 16:46 +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Pass dev_priv to intel_setup_outputs() (rev2) > URL   : https://patchwork.freedesktop.org/series/15820/ > State : success Pushed. Thanks for the review. Ander

Re: [Intel-gfx] [PATCH 1/2] drm/i915/audio: extend get_saved_enc() to support more scenarios

On Tue, 15 Nov 2016, libin.y...@intel.com wrote: > From: Libin Yang > > When bootup, audio driver may not know it is MST or not. The audio > driver will poll all the port & pipe combinations in either MST or > Non-MST mode. get_saved_enc() should handle this situation.

[Intel-gfx] [i-g-t PATCH 2/6] igt_aux: Add some list helpers from wayland

From: Lyude Since we're going to be using lists for keeping track of EDIDs we've allocated on the chamelium, add some generic list helpers from the wayland project. Signed-off-by: Lyude Changes since v1: - Rename list helpers to be more like those from the

[Intel-gfx] [i-g-t PATCH v14 3/6] lib: add igt_dummyload

A lot of igt testcases need some GPU workload to make sure a race window is big enough. Unfortunately having a fixed amount of workload leads to spurious test failures or overly long runtimes on some fast/slow platforms. This library contains functionality to submit GPU workloads that should

Re: [Intel-gfx] [PATCH 0/8] HuC Loading Patches

On Wed, Nov 23, 2016 at 02:27:35PM -0800, Anusha Srivatsa wrote: > These patches add HuC loading support. The userspace > patches that check for a fully loaded HuC firmware and use > it can be found at: > https://lists.freedesktop.org/archives/libva/2016-September/004554.html >

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Move guc_{send, recv}() to intel_uc.c

On Fri, Nov 25, 2016 at 03:22:13PM +0100, Arkadiusz Hiler wrote: > guc_send(), guc_recv() and related functions were introduced in the > i915_guc_submission.c and their scope was limited only to that file. > > Those are not submission specific though. > This patch moves moves them to intel_uc.c

Re: [Intel-gfx] [PATCH v3] drm/i915: start adding dp mst audio

On Mon, 14 Nov 2016, libin.y...@intel.com wrote: > From: Libin Yang > > (This patch is developed by Dave Airlie originally) > > This patch adds support for DP MST audio in i915. > > Enable audio codec when DP MST is enabled if has_audio flag is

[Intel-gfx] [PATCH v2] drm/i915/guc: Move guc_{send, recv}() to intel_uc.c

guc_send(), guc_recv() and related functions were introduced in the i915_guc_submission.c and their scope was limited only to that file. Those are not submission specific though. This patch moves moves them to intel_uc.c with intel_ prefix added. v2: rename intel_guc_log_* functions and clean up

[Intel-gfx] [PATCH v3] drm/i915/guc: Drop guc2host/host2guc from names

To facilitate code reorganization we are renaming everything that contains guc2host or host2guc. host2guc_action() and host2guc_action_response() become guc_send() and guc_recv() respectively. Other host2guc_*() functions become simply guc_*(). Other entities are renamed basing on context they

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/4] drm/i915: Add is-completed assert to request retire entrypoint

== Series Details == Series: series starting with [CI,1/4] drm/i915: Add is-completed assert to request retire entrypoint URL : https://patchwork.freedesktop.org/series/15965/ State : success == Summary == Series 15965v1 Series without cover letter

[Intel-gfx] [CI 3/4] drm/i915: Hold a reference on the request for its fence chain

Currently, we have an active reference for the request until it is retired. Though it cannot be retired before it has been executed by hardware, the request may be completed before we have finished processing the execute fence, i.e. we may continue to process that fence as we free the request.

[Intel-gfx] [CI 4/4] drm/i915: Integrate i915_sw_fence with debugobjects

Add the tracking required to enable debugobjects for fences to improve error detection in BAT. The debugobject interface lets us track the lifetime and phases of the fences even while being embedded into larger structs, i.e. to check they are not used after they have been released. v2: Don't

[Intel-gfx] [CI 2/4] drm/i915: Assert no external observers when unwind a failed request alloc

Before we return the request back to the kmem_cache after a failed i915_gem_request_alloc(), we should assert that it has not been added to any global state tracking. Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen ---

[Intel-gfx] [CI 1/4] drm/i915: Add is-completed assert to request retire entrypoint

While we will check that the request is completed prior to being retired, by placing an assert that the request is complete at the entrypoint of the function we can more clearly document the function's preconditions. Signed-off-by: Chris Wilson Reviewed-by: Joonas

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Drop guc2host/host2guc from names

On Fri, Nov 25, 2016 at 01:29:21PM +0100, Arkadiusz Hiler wrote: > diff --git a/drivers/gpu/drm/i915/intel_guc_fwif.h > b/drivers/gpu/drm/i915/intel_guc_fwif.h > index 324ea90..9ccb8f8 100644 > --- a/drivers/gpu/drm/i915/intel_guc_fwif.h > +++ b/drivers/gpu/drm/i915/intel_guc_fwif.h > @@ -489,18

[Intel-gfx] [PATCH igt] igt/kms_setmode: Adjust timing assertion from percentage to scanline

The target is that we report the vblank time accurate to within a scanline (limit of the hw with which we can reliably compensate). Signed-off-by: Chris Wilson --- tests/kms_setmode.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff

[Intel-gfx] [PATCH v2] drm/i915/guc: Drop guc2host/host2guc from names

To facilitate code reorganization we are renaming everything that contains guc2host or host2guc. host2guc_action() and host2guc_action_response() become guc_send() and guc_recv() respectively. Other host2guc_*() functions become simply guc_*(). Other entities are renamed basing on context they

Re: [Intel-gfx] [PATCH 3/5] drm/i915/guc: Move guc_{send, recv}() to intel_uc.c

On Fri, Nov 25, 2016 at 11:23:19AM +, Chris Wilson wrote: > > +int intel_guc_logging_control(struct intel_guc *guc, u32 control_val) > > +{ > > + u32 data[2]; > > + > > + data[0] = INTEL_GUC_ACTION_UK_LOG_ENABLE_LOGGING; > > + data[1] = control_val; > > + > > + return

Re: [Intel-gfx] [PATCH igt 2/2] intel_ci: Add gem_exec_reloc/basic-softpin to BAT

On Fri, Nov 25, 2016 at 12:00:43PM +0200, Petri Latvala wrote: > On Thu, Nov 17, 2016 at 01:48:36PM +, Chris Wilson wrote: > > Signed-off-by: Chris Wilson > > Cc: Petri Latvala > > --- > > tests/intel-ci/fast-feedback.testlist | 1 + > > 1

Re: [Intel-gfx] v4.9-rc3: graphical artefacts in X

On Fri 2016-11-18 11:14:16, Chris Wilson wrote: > On Fri, Nov 18, 2016 at 12:02:56PM +0100, Pavel Machek wrote: > > Hi! > > > > With v4.9, if I maximize "nowcast -x" application, I get broken > > display (as if someone split the window into rectangles and shuffled > > them a bit). Switching

Re: [Intel-gfx] [i-g-t PATCH 2/6] igt_aux: Add some list helpers from the kernel

On Fri, Nov 25, 2016 at 01:40:31PM +0200, Abdiel Janulgue wrote: > Since we're going to be using lists for keeping track of spinners > add some generic list helpers from the kernel. I should also say look at the chamelium patches so that we only have to import a circular list once (i.e. make sure

Re: [Intel-gfx] [i-g-t PATCH 2/6] igt_aux: Add some list helpers from the kernel

On Fri, Nov 25, 2016 at 01:40:31PM +0200, Abdiel Janulgue wrote: > Since we're going to be using lists for keeping track of spinners > add some generic list helpers from the kernel. > > Signed-off-by: Abdiel Janulgue > --- > lib/igt_aux.c | 39

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/skl: Increase PCODE CDCLK change notify timeout

On Fri, Nov 25, 2016 at 01:30:38PM +0200, Ville Syrjälä wrote: > On Fri, Nov 25, 2016 at 12:57:01PM +0200, Imre Deak wrote: > > commit 848496e5902833600f7992f4faa82dc1546051ba > > Author: Ville Syrjälä > > Date: Wed Jul 13 16:32:03 2016 +0300 > > > >

[Intel-gfx] [i-g-t PATCH 2/6] igt_aux: Add some list helpers from the kernel

Since we're going to be using lists for keeping track of spinners add some generic list helpers from the kernel. Signed-off-by: Abdiel Janulgue --- lib/igt_aux.c | 39 +++ lib/igt_aux.h | 46

[Intel-gfx] [i-g-t PATCH v13 3/6] lib: add igt_dummyload

A lot of igt testcases need some GPU workload to make sure a race window is big enough. Unfortunately having a fixed amount of workload leads to spurious test failures or overly long runtimes on some fast/slow platforms. This library contains functionality to submit GPU workloads that should

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/skl: Increase PCODE CDCLK change notify timeout

On Fri, Nov 25, 2016 at 12:57:01PM +0200, Imre Deak wrote: > commit 848496e5902833600f7992f4faa82dc1546051ba > Author: Ville Syrjälä > Date: Wed Jul 13 16:32:03 2016 +0300 > > drm/i915: Wait up to 3ms for the pcu to ack the cdclk change request on > SKL > >

Re: [Intel-gfx] [PATCH 06/15] drm/i915: Assert no external observers when unwind a failed request alloc

On Fri, Nov 25, 2016 at 12:39:25PM +0200, Joonas Lahtinen wrote: > On pe, 2016-11-25 at 09:30 +, Chris Wilson wrote: > > Before we return the request back to the kmem_cache after a failed > > i915_gem_request_alloc(), we should assert that it has not been added to > > any global state

Re: [Intel-gfx] [PATCH 3/5] drm/i915/guc: Move guc_{send, recv}() to intel_uc.c

On Thu, Nov 24, 2016 at 05:13:21PM +0100, Arkadiusz Hiler wrote: > guc_send(), guc_recv() and related functions were introduced in the > i915_guc_submission.c and their scope was limited only to that file. > > Those are not submission specific though. > This patch moves moves them to intel_uc.c

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gen6+: Clear upper data byte during PCODE write (rev2)

== Series Details == Series: series starting with [1/2] drm/i915/gen6+: Clear upper data byte during PCODE write (rev2) URL : https://patchwork.freedesktop.org/series/15911/ State : success == Summary == Series 15911v2 Series without cover letter

[Intel-gfx] [PATCH v2] drm/i915/guc: Init send_mutex in intel_uc_init_early()

send_mutex is used to serialise communication with GuC via intel_guc_send(). Since functions that utilize it are no longer limited to submission, initialization should be handled as a part of general setup. v2: move initialization to *_early() Cc: Chris Wilson Cc:

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/skl: Increase PCODE CDCLK change notify timeout

On Fri, Nov 25, 2016 at 12:57:01PM +0200, Imre Deak wrote: > commit 848496e5902833600f7992f4faa82dc1546051ba > Author: Ville Syrjälä > Date: Wed Jul 13 16:32:03 2016 +0300 > > drm/i915: Wait up to 3ms for the pcu to ack the cdclk change request on > SKL > >

[Intel-gfx] [PATCH v2 2/2] drm/i915/skl: Increase PCODE CDCLK change notify timeout

commit 848496e5902833600f7992f4faa82dc1546051ba Author: Ville Syrjälä Date: Wed Jul 13 16:32:03 2016 +0300 drm/i915: Wait up to 3ms for the pcu to ack the cdclk change request on SKL increased the timeout to match the spec, but we still see a timeout on at

Re: [Intel-gfx] [RFC PATCH v3 1/7] drm/i915: setup bridge for HDMI LPE audio driver

Jerome - The same as last time, I didn't receive any of the patches, neither the intel-gfx nor alsa-devel list archives have them, patchwork doesn't have them, they're not in intel-gfx moderation queueu. I only have the replies. Please check your setup, and make sure your patches actually hit

Re: [Intel-gfx] [PATCH 07/15] drm/i915: Hold a reference on the request for its fence chain

On Fri, Nov 25, 2016 at 12:31:03PM +0200, Joonas Lahtinen wrote: > On pe, 2016-11-25 at 09:30 +, Chris Wilson wrote: > > Currently, we have an active reference for the request until it is > > retired. Though it cannot be retired before it has been executed by > > hardware, the request may be

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Moving scaler numbers to runtime init (rev4)

== Series Details == Series: drm/i915: Moving scaler numbers to runtime init (rev4) URL : https://patchwork.freedesktop.org/series/15726/ State : success == Summary == Series 15726v4 drm/i915: Moving scaler numbers to runtime init

Re: [Intel-gfx] [PATCH 06/15] drm/i915: Assert no external observers when unwind a failed request alloc

On pe, 2016-11-25 at 09:30 +, Chris Wilson wrote: > Before we return the request back to the kmem_cache after a failed > i915_gem_request_alloc(), we should assert that it has not been added to > any global state tracking. > > Signed-off-by: Chris Wilson > --- >  

Re: [Intel-gfx] [PATCH 05/15] drm/i915: Add is-completed assert to request retire entrypoint

On pe, 2016-11-25 at 09:30 +, Chris Wilson wrote: > While we will check that the request is completed prior to being > retired, by placing an assert that the request is complete at the > entrypoint of the function we can more clearly document the function's > preconditions. > > Signed-off-by:

Re: [Intel-gfx] [PATCH 09/15] drm/i915: Enable swfence debugobject support for i915.ko

On pe, 2016-11-25 at 09:30 +, Chris Wilson wrote: > Only once the debugobject symbols are exported can we enable support for > debugging swfences when i915 is built as a module. Requires commit > 2617fdca3f68 ("lib/debugobjects: export for use in modules") > > Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH] drm/i915: Move number of scalers initialization to runtime init

On 11/25/2016 3:14 PM, Chris Wilson wrote: On Fri, Nov 25, 2016 at 03:16:58PM +0530, Nabendu Maiti wrote: In future patches, we require greater flexibility in describing the number of scalers available on each CRTC. To ease that transition we move the current assignment to intel_device_info.

Re: [Intel-gfx] [PATCH 07/15] drm/i915: Hold a reference on the request for its fence chain

On pe, 2016-11-25 at 09:30 +, Chris Wilson wrote: > Currently, we have an active reference for the request until it is > retired. Though it cannot be retired before it has been executed by > hardware, the request may be completed before we have finished > processing the execute fence, i.e. we

Re: [Intel-gfx] [PATCH 08/15] drm/i915: Integrate i915_sw_fence with debugobjects

On pe, 2016-11-25 at 09:30 +, Chris Wilson wrote: > Add the tracking required to enable debugobjects to improve error > detection in BAT.  The debugobject interface lets us to track the > lifetime of the fences even while being embedded into larger structs, > i.e. to check they are not used

Re: [Intel-gfx] [RFC PATCH v3 1/7] drm/i915: setup bridge for HDMI LPE audio driver

On Fri, Nov 25, 2016 at 05:42:38AM +, Anand, Jerome wrote: > > > > -Original Message- > > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > > Sent: Thursday, November 24, 2016 7:02 PM > > To: Anand, Jerome > > Cc: intel-gfx@lists.freedesktop.org;

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [01/15] drm: Hold mode_config.lock to prevent hotplug whilst setting up crtcs

== Series Details == Series: series starting with [01/15] drm: Hold mode_config.lock to prevent hotplug whilst setting up crtcs URL : https://patchwork.freedesktop.org/series/15950/ State : warning == Summary == Series 15950v1 Series without cover letter

Re: [Intel-gfx] [PATCH igt 2/2] intel_ci: Add gem_exec_reloc/basic-softpin to BAT

On Thu, Nov 17, 2016 at 01:48:36PM +, Chris Wilson wrote: > Signed-off-by: Chris Wilson > Cc: Petri Latvala > --- > tests/intel-ci/fast-feedback.testlist | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [Intel-gfx] [PATCH] intel-ci: Add gem_exec_suspend/basic-S3/S4-devices to BAT

On Mon, Oct 17, 2016 at 03:39:04PM +0300, Imre Deak wrote: > Add gem_exec_suspend/basic-s3-devices and basic-s4-devices subtests to > BAT. At the same time remove basic-s4 from the list, which is atm > implicitly disabled via HIBERNATION=n in kconfig. We would need at least > basic S4 coverage

Re: [Intel-gfx] [PATCH] drm/i915: Move number of scalers initialization to runtime init

On Fri, Nov 25, 2016 at 03:16:58PM +0530, Nabendu Maiti wrote: > In future patches, we require greater flexibility in describing > the number of scalers available on each CRTC. To ease that transition > we move the current assignment to intel_device_info. > > Scaler structure initialisation is

[Intel-gfx] [PATCH] drm/i915: Move number of scalers initialization to runtime init

In future patches, we require greater flexibility in describing the number of scalers available on each CRTC. To ease that transition we move the current assignment to intel_device_info. Scaler structure initialisation is done if scaler is available on the CRTC. Gen9 check is not required as on

[Intel-gfx] [PATCH 06/15] drm/i915: Assert no external observers when unwind a failed request alloc

Before we return the request back to the kmem_cache after a failed i915_gem_request_alloc(), we should assert that it has not been added to any global state tracking. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_request.c | 5 + 1 file changed, 5

[Intel-gfx] [PATCH 07/15] drm/i915: Hold a reference on the request for its fence chain

Currently, we have an active reference for the request until it is retired. Though it cannot be retired before it has been executed by hardware, the request may be completed before we have finished processing the execute fence, i.e. we may continue to process that fence as we free the request.

[Intel-gfx] [PATCH 13/15] drm/i915/guc: Initialise doorbell cookie to matching value

Set the initial value of the doorbell cookie from the client. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_guc_submission.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Increase PCODE CDCLK change notify timeout

On Fri, Nov 25, 2016 at 09:23:01AM +, Chris Wilson wrote: > On Thu, Nov 24, 2016 at 05:32:59PM +0200, Imre Deak wrote: > > commit 848496e5902833600f7992f4faa82dc1546051ba > > Author: Ville Syrjälä > > Date: Wed Jul 13 16:32:03 2016 +0300 > > > > drm/i915:

[Intel-gfx] [PATCH 15/15] drm/i915/guc: Split hw submission for replay after GPU reset

Something I missed before sending off the partial series was that the non-scheduler guc reset path was broken (in the full series, this is pushed to the execlists reset handler). The issue is that after a reset, we have to refill the GuC workqueues, which we do by resubmitting the requests.

[Intel-gfx] [PATCH 10/15] HAX drm/i915: Enable guc submission

--- drivers/gpu/drm/i915/i915_params.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index 0e280fbd52f1..ef1e9921a2af 100644 --- a/drivers/gpu/drm/i915/i915_params.c +++

[Intel-gfx] [PATCH 12/15] drm/i915/guc: Rename client->cookie to match use

The client->cookie is a shadow of the doorbell->cookie value, so rename it to indicate its association with the doorbell, like the doorbell id and offset. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_debugfs.c| 2 +-

[Intel-gfx] [PATCH 09/15] drm/i915: Enable swfence debugobject support for i915.ko

Only once the debugobject symbols are exported can we enable support for debugging swfences when i915 is built as a module. Requires commit 2617fdca3f68 ("lib/debugobjects: export for use in modules") Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/Kconfig.debug |

[Intel-gfx] [PATCH 14/15] drm/i915/guc: Keep the execbuf client allocated across reset

In order to avoid some complexity in trying to reconstruct the workqueues across reset, remember them instead. The issue comes when we have to handle a reset between request allocation and submission, the request has reserved space in the wq, but is not in any list so we fail to restore the

[Intel-gfx] GuC vs multiple timelines

Switching the GuC on for BAT testing another patch revealed I had broken (made spammy at least) resets with requests in flight on the GuC. In the course of fixing that, I kept tripping over a nasty timing issue in the reuse of requests (with many threads running in parallel we would retire a

[Intel-gfx] [PATCH 04/15] drm/i915/perf: Wrap 64bit divides in do_div()

Just a couple of naked 64bit divides causing link errors on 32bit builds, with: ERROR: "__udivdi3" [drivers/gpu/drm/i915/i915.ko] undefined! v2: do_div() is only u64/u32, we need a u32/u64! v3: div_u64() == u64/u32, div64_u64() == u64/u64 Reported-by: kbuild test robot

[Intel-gfx] [PATCH 02/15] drm: Pull together probe + setup for drm_fb_helper

drm_fb_helper_probe_connector_modes() is always called before drm_setup_crtcs(), so just move the call into drm_setup_crtcs for a small bit of code compaction. Signed-off-by: Chris Wilson --- drivers/gpu/drm/drm_fb_helper.c | 37 +++-- 1

[Intel-gfx] [PATCH 01/15] drm: Hold mode_config.lock to prevent hotplug whilst setting up crtcs

The fb_helper->connector_count is modified when a new connector is constructed following a hotplug event (e.g. DP-MST). This causes trouble for drm_setup_crtcs() and friends that assume that fb_helper is constant: [ 1250.872997] BUG: KASAN: slab-out-of-bounds in drm_setup_crtcs+0x320/0xf80 at

[Intel-gfx] [PATCH 05/15] drm/i915: Add is-completed assert to request retire entrypoint

While we will check that the request is completed prior to being retired, by placing an assert that the request is complete at the entrypoint of the function we can more clearly document the function's preconditions. Signed-off-by: Chris Wilson ---

[Intel-gfx] [PATCH 03/15] drm: Protect fb_helper list manipulation with a mutex

Though we only walk the kernel_fb_helper_list inside a panic (or single thread debugging), we still need to protect the list manipulation on creating/removing a framebuffer device in order to prevent list corruption. Signed-off-by: Chris Wilson ---

[Intel-gfx] [PATCH 11/15] drm/i915: Trim i915_guc_info() stack usage

i915_guc_info() (part of debugfs output) tries to avoid holding struct_mutex for a long period by copying onto the stack. This causes a warning that the stack frame is massive, so stop doing that. We can even forgo holding the struct_mutex here as that doesn't serialise the values being read (and

[Intel-gfx] [PATCH 08/15] drm/i915: Integrate i915_sw_fence with debugobjects

Add the tracking required to enable debugobjects to improve error detection in BAT. The debugobject interface lets us to track the lifetime of the fences even while being embedded into larger structs, i.e. to check they are not used after they have been released. Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Increase PCODE CDCLK change notify timeout

On Thu, Nov 24, 2016 at 05:32:59PM +0200, Imre Deak wrote: > commit 848496e5902833600f7992f4faa82dc1546051ba > Author: Ville Syrjälä > Date: Wed Jul 13 16:32:03 2016 +0300 > > drm/i915: Wait up to 3ms for the pcu to ack the cdclk change request on > SKL > >

Re: [Intel-gfx] [i-g-t PATCH v12 2/5] lib: add igt_dummyload

On Thu, Nov 24, 2016 at 12:16:11PM +0200, Abdiel Janulgue wrote: > A lot of igt testcases need some GPU workload to make sure a race > window is big enough. Unfortunately having a fixed amount of > workload leads to spurious test failures or overly long runtimes > on some fast/slow platforms. This