Re: [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915/guc: Fix request re-submission after reset

2017-03-09 Thread Tvrtko Ursulin
On 09/03/2017 20:55, Chris Wilson wrote: On Thu, Mar 09, 2017 at 04:47:52PM -, Patchwork wrote: == Series Details == Series: series starting with [CI,1/2] drm/i915/guc: Fix request re-submission after reset URL : https://patchwork.freedesktop.org/series/20991/ State : success ==

[Intel-gfx] [PATCH v2] drm/i915: Fix forcewake active domain tracking

2017-03-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In commit 003342a50021 ("drm/i915: Keep track of active forcewake domains in a bitmask") I forgot to adjust the newly introduce fw_domains_active state across reset. This caused the assert_forcewakes_inactive to trigger during suspend and resume if

Re: [Intel-gfx] [PATCH v2] drm: Add DPCD definitions for DP 1.4 DSC feature

2017-03-09 Thread Manasi Navare
On Wed, Feb 22, 2017 at 10:23:18AM +0200, Jani Nikula wrote: > > [Your MUA messed up the quoting, FTFY below.] > > On Wed, 22 Feb 2017, "Navare, Manasi D" wrote: > > > On Fri, 17 Feb 2017, Manasi Navare wrote: > > >> Display stream

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix vGPU balloon for ggtt guard page (rev2)

2017-03-09 Thread Patchwork
== Series Details == Series: drm/i915: Fix vGPU balloon for ggtt guard page (rev2) URL : https://patchwork.freedesktop.org/series/20983/ State : success == Summary == Series 20983v2 drm/i915: Fix vGPU balloon for ggtt guard page

[Intel-gfx] [PATCH v2] drm/i915: Fix vGPU balloon for ggtt guard page

2017-03-09 Thread Zhenyu Wang
From commit a6508ded2a66 ("drm/i915: Use page coloring to provide the guard page at the end of the GTT"), we no longer explicitly subtract guard page at end for GGTT address space init, so shouldn't subtract that for vGPU balloon too, as that will leave that end page to be available for vGPU.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Wait for reset to complete before returning from debugfs/i915_wedged

2017-03-09 Thread Patchwork
== Series Details == Series: drm/i915: Wait for reset to complete before returning from debugfs/i915_wedged URL : https://patchwork.freedesktop.org/series/21030/ State : success == Summary == Series 21030v1 drm/i915: Wait for reset to complete before returning from debugfs/i915_wedged

[Intel-gfx] [PATCH] drm/i915: Wait for reset to complete before returning from debugfs/i915_wedged

2017-03-09 Thread Chris Wilson
Provide some serialisation between user operations by waiting for the reset initiated by setting i915_wedged to complete. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_debugfs.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [Intel-gfx] [PATCH] drm: Forward declare struct platform_device

2017-03-09 Thread Chris Wilson
On Fri, Mar 10, 2017 at 12:41:30AM +, Emil Velikov wrote: > On 9 March 2017 at 22:46, Chris Wilson wrote: > > ./include/drm/drm_pci.h:76:64: warning: ‘struct platform_device’ declared > > inside parameter list will not be visible outside of this definition or > >

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Move whole object to CPU domain for coherent shmem access

2017-03-09 Thread Patchwork
== Series Details == Series: drm/i915: Move whole object to CPU domain for coherent shmem access URL : https://patchwork.freedesktop.org/series/21020/ State : failure == Summary == Series 21020v1 drm/i915: Move whole object to CPU domain for coherent shmem access

Re: [Intel-gfx] [PATCH] drm: Forward declare struct platform_device

2017-03-09 Thread Emil Velikov
On 9 March 2017 at 22:46, Chris Wilson wrote: > ./include/drm/drm_pci.h:76:64: warning: ‘struct platform_device’ declared > inside parameter list will not be visible outside of this definition or > declaration > extern int drm_platform_init(struct drm_driver *driver,

[Intel-gfx] [PATCH] drm/i915: Move whole object to CPU domain for coherent shmem access

2017-03-09 Thread Chris Wilson
If the object is coherent, we can simply update the cache domain on the whole object rather than calculate the before/after clflushes. The advantage is that we then get correct tracking of ellided flushes when changing coherency later. Testcase: igt/gem_pwrite_snooped Signed-off-by: Chris Wilson

[Intel-gfx] linux-next: build warning after merge of the drm-misc tree

2017-03-09 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: In file included from drivers/gpu/drm/drm_pci.c:29:0: include/drm/drm_pci.h:76:64: warning: 'struct platform_device' declared inside parameter list extern int

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Forward declare struct platform_device

2017-03-09 Thread Patchwork
== Series Details == Series: drm: Forward declare struct platform_device URL : https://patchwork.freedesktop.org/series/21017/ State : success == Summary == Series 21017v1 drm: Forward declare struct platform_device https://patchwork.freedesktop.org/api/1.0/series/21017/revisions/1/mbox/

[Intel-gfx] [PATCH] drm: Forward declare struct platform_device

2017-03-09 Thread Chris Wilson
./include/drm/drm_pci.h:76:64: warning: ‘struct platform_device’ declared inside parameter list will not be visible outside of this definition or declaration extern int drm_platform_init(struct drm_driver *driver, struct platform_device *platform_device); Fixes: 23ef59ef6dcc ("drm: Extract

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v3] drm/i915: Stop using RP_DOWN_EI on Baytrail (rev2)

2017-03-09 Thread Patchwork
== Series Details == Series: series starting with [v3] drm/i915: Stop using RP_DOWN_EI on Baytrail (rev2) URL : https://patchwork.freedesktop.org/series/20314/ State : success == Summary == Series 20314v2 Series without cover letter

Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix request re-submission after reset

2017-03-09 Thread Oscar Mateo
On 03/09/2017 12:54 PM, Chris Wilson wrote: On Thu, Mar 09, 2017 at 05:02:16PM +, Tvrtko Ursulin wrote: On 09/03/2017 08:55, Oscar Mateo wrote: On 03/09/2017 08:50 AM, Tvrtko Ursulin wrote: On 09/03/2017 08:42, Oscar Mateo wrote: On 03/09/2017 02:05 AM, Tvrtko Ursulin wrote: From:

Re: [Intel-gfx] [PATCH] drm/i915: Ignore skl+ for debugfs/i915_sr_status

2017-03-09 Thread Chris Wilson
On Thu, Mar 09, 2017 at 04:27:29PM +0200, Ville Syrjälä wrote: > On Thu, Mar 09, 2017 at 02:20:49PM +, Chris Wilson wrote: > > There is no easily digestible single self-refresh status bit, so don't > > report one for debugfs/i915_sr_status. > > > > Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Optimize VLV/CHV display FIFO updates

2017-03-09 Thread Chris Wilson
On Thu, Mar 09, 2017 at 05:44:34PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Use I915_{READ,WRITE}_FW() for updating the DSPARB registers on > VLV/CHV. This is less expesive as we can grab the uncore.lock across > the entire sequence of

Re: [Intel-gfx] [PATCH i-g-t 2/2] kms_pipe_crc_basic: Skip sequence tests if the source doesn't provide frame numbers

2017-03-09 Thread Robert Foss
Reviewed-by: Robert Foss On 2017-03-08 08:30 AM, Tomeu Vizoso wrote: Some frame sources such as sinks aren't able to provide meaningful frame numbers, so in those cases just skip the TEST_SEQUENCE tests. Signed-off-by: Tomeu Vizoso ---

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Use highest frequency divider for PWM

2017-03-09 Thread Puthikorn Voravootivat
Agree that your suggestion is better. I will drop this patch in the next version of the set. Thanks On Thu, Mar 9, 2017 at 2:40 AM, Jani Nikula wrote: > On Wed, 08 Mar 2017, Puthikorn Voravootivat wrote: >> TCON tend to have better brightness

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Fix condition check for backlight control via DPCD

2017-03-09 Thread Puthikorn Voravootivat
I think that there won't be a good way to determine which way of adjusting backlight is preferred when the panel support both PWM pin and DPCD. How about extending the current i915_params.enable_dpcd_backlight to this. { 0:disable(default) 1: prefer PWM pin, 2: prefer DPCD } If it is 1), use the

[Intel-gfx] [PATCH v3 2/3] drm/i915: Use max(render, media) for Baytrail busyness calculation

2017-03-09 Thread Chris Wilson
Currently, we sum the render and media cycles (on different engines) to compute a percentage - but we fail to factor in the duplication into the threshold calculations. This makes us very eager to upclock! If we just consider the maximum busy cycles of either counter, we should have an accurate

[Intel-gfx] [PATCH v3 3/3] drm/i915: Defer unmasking RPS interrupts until after making adjustments

2017-03-09 Thread Chris Wilson
To make our adjustments to RPS requires taking a mutex and potentially sleeping for an unknown duration - until we have completed our adjustments further RPS interrupts are immaterial (they are based on stale thresholds) and we can safely ignore them. Signed-off-by: Chris Wilson

[Intel-gfx] [PATCH v3 1/3] drm/i915: Stop using RP_DOWN_EI on Baytrail

2017-03-09 Thread Chris Wilson
On Baytrail, we manually calculate busyness over the evaluation interval to avoid issues with miscaluations with RC6 enabled. However, it turns out that the DOWN_EI interrupt generator is completely bust - it operates in two modes, continuous or never. Neither of which are conducive to good

Re: [Intel-gfx] [PATCH] drm/i915: Fix forcewake active domain tracking

2017-03-09 Thread Chris Wilson
On Thu, Mar 09, 2017 at 03:52:50PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > In commit 003342a50021 ("drm/i915: Keep track of active > forcewake domains in a bitmask") I forgot to adjust the > newly introduce fw_domains_active state across reset. > > This

Re: [Intel-gfx] [PATCH v3] drm/i915: Stop using RP_DOWN_EI on Baytrail

2017-03-09 Thread Chris Wilson
On Thu, Mar 09, 2017 at 09:03:12PM +, Chris Wilson wrote: > On Baytrail, we manually calculate busyness over the evaluation interval > to avoid issues with miscaluations with RC6 enabled. However, it turns > out that the DOWN_EI interrupt generator is completely bust - it > operates in two

Re: [Intel-gfx] [PATCH i-g-t 1/2] lib: Open debugfs files for the given DRM device

2017-03-09 Thread Robert Foss
I've only found a very minor nitpick in intel_watermark.c, other than that this patch does not apply cleanly on upstream/master, so I've run no compilation or runtime tests. When it applies to trunk, feel free to add my r-b. On 2017-03-08 08:29 AM, Tomeu Vizoso wrote: > When opening a DRM

[Intel-gfx] [PATCH v3] drm/i915: Stop using RP_DOWN_EI on Baytrail

2017-03-09 Thread Chris Wilson
On Baytrail, we manually calculate busyness over the evaluation interval to avoid issues with miscaluations with RC6 enabled. However, it turns out that the DOWN_EI interrupt generator is completely bust - it operates in two modes, continuous or never. Neither of which are conducive to good

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915/guc: Fix request re-submission after reset

2017-03-09 Thread Chris Wilson
On Thu, Mar 09, 2017 at 04:47:52PM -, Patchwork wrote: > == Series Details == > > Series: series starting with [CI,1/2] drm/i915/guc: Fix request re-submission > after reset > URL : https://patchwork.freedesktop.org/series/20991/ > State : success > > == Summary == > > Series 20991v1

Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix request re-submission after reset

2017-03-09 Thread Chris Wilson
On Thu, Mar 09, 2017 at 05:02:16PM +, Tvrtko Ursulin wrote: > > On 09/03/2017 08:55, Oscar Mateo wrote: > >On 03/09/2017 08:50 AM, Tvrtko Ursulin wrote: > >> > >>On 09/03/2017 08:42, Oscar Mateo wrote: > >>>On 03/09/2017 02:05 AM, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix forcewake active domain tracking

2017-03-09 Thread Chris Wilson
On Thu, Mar 09, 2017 at 07:23:14PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Fix forcewake active domain tracking > URL : https://patchwork.freedesktop.org/series/21004/ > State : failure > > == Summary == > > Series 21004v1 drm/i915: Fix forcewake active domain

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Optimize plane updates a bit

2017-03-09 Thread Patchwork
== Series Details == Series: drm/i915: Optimize plane updates a bit URL : https://patchwork.freedesktop.org/series/21002/ State : failure == Summary == Series 21002v1 drm/i915: Optimize plane updates a bit https://patchwork.freedesktop.org/api/1.0/series/21002/revisions/1/mbox/ Test

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix forcewake active domain tracking

2017-03-09 Thread Patchwork
== Series Details == Series: drm/i915: Fix forcewake active domain tracking URL : https://patchwork.freedesktop.org/series/21004/ State : failure == Summary == Series 21004v1 drm/i915: Fix forcewake active domain tracking

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Optimize plane updates a bit

2017-03-09 Thread Patchwork
== Series Details == Series: drm/i915: Optimize plane updates a bit URL : https://patchwork.freedesktop.org/series/21002/ State : failure == Summary == Series 21002v1 drm/i915: Optimize plane updates a bit https://patchwork.freedesktop.org/api/1.0/series/21002/revisions/1/mbox/ Test

Re: [Intel-gfx] [PATCH 0/5] drm/i915: Use new atomic iterator macros.

2017-03-09 Thread Ville Syrjälä
On Thu, Mar 09, 2017 at 03:52:00PM +0100, Maarten Lankhorst wrote: > Some small patchset to deal with the atomic iterator changes. > > Maarten Lankhorst (5): > drm/i915: Use new atomic iterator macros in ddi > drm/i915: Use new atomic iterator macros in fbc > drm/i915: Use new atomic

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use new atomic iterator macros.

2017-03-09 Thread Patchwork
== Series Details == Series: drm/i915: Use new atomic iterator macros. URL : https://patchwork.freedesktop.org/series/20998/ State : success == Summary == Series 20998v1 drm/i915: Use new atomic iterator macros. https://patchwork.freedesktop.org/api/1.0/series/20998/revisions/1/mbox/ Test

[Intel-gfx] [drm-intel:drm-intel-nightly 777/788] include/drm/drm_pci.h:76:64: warning: 'struct platform_device' declared inside parameter list

2017-03-09 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel drm-intel-nightly head: 510c200742ced5a91d07e48220b669a3c9b30c0c commit: 23ef59ef6dcc9b62bf077490a74df93b3bb0d530 [777/788] drm: Extract drm_pci.h config: tile-tilegx_defconfig (attached as .config) compiler: tilegx-linux-gcc (GCC) 4.6.2

Re: [Intel-gfx] [PATCH] drm/i915: Clear the VBT defaults for unused ports

2017-03-09 Thread Manasi Navare
On Tue, Mar 07, 2017 at 07:36:45PM +0200, Jani Nikula wrote: > On Fri, 03 Mar 2017, Ville Syrjälä wrote: > > On Fri, Mar 03, 2017 at 05:01:42AM -0800, Manasi Navare wrote: > >> If during VBT parsing we find that the port is unused, > >> the driver code just bails

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Ignore skl+ for debugfs/i915_sr_status

2017-03-09 Thread Patchwork
== Series Details == Series: drm/i915: Ignore skl+ for debugfs/i915_sr_status URL : https://patchwork.freedesktop.org/series/20995/ State : success == Summary == Series 20995v1 drm/i915: Ignore skl+ for debugfs/i915_sr_status

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Convert intel_tv connector properties to atomic.

2017-03-09 Thread Ville Syrjälä
On Thu, Mar 09, 2017 at 02:06:15PM +0100, Maarten Lankhorst wrote: > As a proof of concept, first try to convert intel_tv, which is a rarely > used connector. It has 5 properties, tv format and 4 margins. Since it's so rare, if you want someone to actually test the code it'll probably make sense

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove intel_ prefix from encoder variables in intel_ddi.c

2017-03-09 Thread Patchwork
== Series Details == Series: drm/i915: Remove intel_ prefix from encoder variables in intel_ddi.c URL : https://patchwork.freedesktop.org/series/20992/ State : success == Summary == Series 20992v1 drm/i915: Remove intel_ prefix from encoder variables in intel_ddi.c

Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix request re-submission after reset

2017-03-09 Thread Tvrtko Ursulin
On 09/03/2017 08:55, Oscar Mateo wrote: On 03/09/2017 08:50 AM, Tvrtko Ursulin wrote: On 09/03/2017 08:42, Oscar Mateo wrote: On 03/09/2017 02:05 AM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In order to ensure no missed interrupts we must first re-direct the

Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix request re-submission after reset

2017-03-09 Thread Oscar Mateo
On 03/09/2017 08:50 AM, Tvrtko Ursulin wrote: On 09/03/2017 08:42, Oscar Mateo wrote: On 03/09/2017 02:05 AM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In order to ensure no missed interrupts we must first re-direct the interrupts to GuC, and only then re-submit

Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix request re-submission after reset

2017-03-09 Thread Tvrtko Ursulin
On 09/03/2017 08:42, Oscar Mateo wrote: On 03/09/2017 02:05 AM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In order to ensure no missed interrupts we must first re-direct the interrupts to GuC, and only then re-submit the requests to be replayed after a GPU reset.

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915/guc: Fix request re-submission after reset

2017-03-09 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/guc: Fix request re-submission after reset URL : https://patchwork.freedesktop.org/series/20991/ State : success == Summary == Series 20991v1 Series without cover letter

Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix request re-submission after reset

2017-03-09 Thread Oscar Mateo
On 03/09/2017 02:05 AM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In order to ensure no missed interrupts we must first re-direct the interrupts to GuC, and only then re-submit the requests to be replayed after a GPU reset. Otherwise context switch can fire before

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Convert tv/dp_mst and crt connector properties to atomic.

2017-03-09 Thread Patchwork
== Series Details == Series: drm/i915: Convert tv/dp_mst and crt connector properties to atomic. URL : https://patchwork.freedesktop.org/series/20990/ State : success == Summary == Series 20990v1 drm/i915: Convert tv/dp_mst and crt connector properties to atomic.

Re: [Intel-gfx] [PATCH 0/5] drm/i915: Optimize plane updates a bit

2017-03-09 Thread Ville Syrjälä
On Thu, Mar 09, 2017 at 04:56:23PM +0100, Maarten Lankhorst wrote: > Hey, > > Op 09-03-17 om 16:44 schreef ville.syrj...@linux.intel.com: > > From: Ville Syrjälä > > > > Now that commit e1edbd44e23b ("drm/i915: Complain if we take too > > long under vblank

[Intel-gfx] [drm-tip:drm-tip 777/788] include/drm/drm_pci.h:76:64: warning: 'struct platform_device' declared inside parameter list will not be visible outside of this definition or declaration

2017-03-09 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip head: 510c200742ced5a91d07e48220b669a3c9b30c0c commit: 23ef59ef6dcc9b62bf077490a74df93b3bb0d530 [777/788] drm: Extract drm_pci.h config: i386-randconfig-x070-201710 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901

Re: [Intel-gfx] [PATCH 0/5] drm/i915: Optimize plane updates a bit

2017-03-09 Thread Maarten Lankhorst
Hey, Op 09-03-17 om 16:44 schreef ville.syrj...@linux.intel.com: > From: Ville Syrjälä > > Now that commit e1edbd44e23b ("drm/i915: Complain if we take too > long under vblank evasion.") has expose just how badly we suck, > it seems like a good time to optimize

[Intel-gfx] [PATCH] drm/i915: Fix forcewake active domain tracking

2017-03-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In commit 003342a50021 ("drm/i915: Keep track of active forcewake domains in a bitmask") I forgot to adjust the newly introduce fw_domains_active state across reset. This caused the assert_forcewakes_inactive to trigger during suspend and resume if

Re: [Intel-gfx] [PATCH v9] drm/i915: enable scrambling

2017-03-09 Thread Sharma, Shashank
+ intel-gfx + dri-devl (missed in in-reply-to) Regards Shashank -Original Message- From: Sharma, Shashank Sent: Thursday, March 9, 2017 6:02 PM To: ville.syrj...@linux.intel.com; conselv...@gmail.com Cc: Sharma, Shashank Subject: [PATCH v9] drm/i915: enable

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Stop using RP_DOWN_EI on Baytrail

2017-03-09 Thread Chris Wilson
On Thu, Mar 09, 2017 at 05:24:14PM +0200, Mika Kuoppala wrote: > Chris Wilson writes: > > > On Baytrail, we manually calculate busyness over the evaluation interval > > to avoid issues with miscaluations with RC6 enabled. However, it turns > > out that the DOWN_EI

[Intel-gfx] [PATCH 5/5] drm/i915: Optimize VLV/CHV display FIFO updates

2017-03-09 Thread ville . syrjala
From: Ville Syrjälä Use I915_{READ,WRITE}_FW() for updating the DSPARB registers on VLV/CHV. This is less expesive as we can grab the uncore.lock across the entire sequence of reads and writes instead of each register access grabbing it. This also allows us to

[Intel-gfx] [PATCH 3/5] drm/i915: Organize plane register writes into tighter bunches

2017-03-09 Thread ville . syrjala
From: Ville Syrjälä Pull all the plane register writes closer together to avoid having a lot of unrelated stuff in between them. This will make things more clear once we'll grab the uncore lock around the entire bunch. Also in the future we might even consider

[Intel-gfx] [PATCH 4/5] drm/i915: Use I915_READ_FW for plane updates

2017-03-09 Thread ville . syrjala
From: Ville Syrjälä Optimize the plane register accesses a little bit by grabbing the uncore lock manually across the entire pile of accesses and using I915_READ_FW(). This helps keep the pipe update vblank evade critical section below our 100 usec deadline,

[Intel-gfx] [PATCH 2/5] drm/i915: s/__raw_i915_read32/I915_READ_FW/ in the SKL+ scanline read w/a

2017-03-09 Thread ville . syrjala
From: Ville Syrjälä Replace __raw_i915_read32() with I915_READ_FW() in the workaround for the SKL+ scanline counter hardware fail. The two are the same thing but everyone else uses I915_READ_FW() so let's follow suit. Signed-off-by: Ville Syrjälä

[Intel-gfx] [PATCH 1/5] drm/i915: Use I915_READ_FW in i915_get_vblank_counter()

2017-03-09 Thread ville . syrjala
From: Ville Syrjälä Optimize the multi-register read in i915_get_vblank_counter() a little bit by grabbing the uncore lock manually and using I915_READ_FW(). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_irq.c | 11

[Intel-gfx] [PATCH 0/5] drm/i915: Optimize plane updates a bit

2017-03-09 Thread ville . syrjala
From: Ville Syrjälä Now that commit e1edbd44e23b ("drm/i915: Complain if we take too long under vblank evasion.") has expose just how badly we suck, it seems like a good time to optimize things a little bit. Prior to this one of my VLV machines exceed the 100 usec

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Stop using RP_DOWN_EI on Baytrail

2017-03-09 Thread Mika Kuoppala
Chris Wilson writes: > On Baytrail, we manually calculate busyness over the evaluation interval > to avoid issues with miscaluations with RC6 enabled. However, it turns > out that the DOWN_EI interrupt generator is completely bust - it > operates in two modes,

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: make context status notifier head be per engine (rev2)

2017-03-09 Thread Patchwork
== Series Details == Series: drm/i915: make context status notifier head be per engine (rev2) URL : https://patchwork.freedesktop.org/series/20552/ State : success == Summary == Series 20552v2 drm/i915: make context status notifier head be per engine

Re: [Intel-gfx] [PATCH] drm/i915: cleanup patch for intel_ddi.c

2017-03-09 Thread Sharma, Shashank
Sure, Thanks for this information. Will give this a try. Regards Shashank -Original Message- From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] Sent: Thursday, March 9, 2017 5:04 PM To: Sharma, Shashank Cc: Conselvan De Oliveira, Ander

[Intel-gfx] [PATCH v2] drm/i915/gvt: add enable_execlists check before enable gvt

2017-03-09 Thread Chuanxiao Dong
The GVT-g needs execlists to be enabled otherwise gvt should be disabled. Add a check for enable_execlists before enabling gvt. v2: use DRM_INFO in response to the user action Signed-off-by: Chuanxiao Dong --- drivers/gpu/drm/i915/intel_gvt.c | 5 + 1 file

Re: [Intel-gfx] [PATCH] drm/i915: cleanup patch for intel_ddi.c

2017-03-09 Thread Ville Syrjälä
On Thu, Mar 09, 2017 at 04:28:20PM +0530, Shashank Sharma wrote: > In I915 driver, there are many places where variable name for > intel_encoder object is given as 'intel_encoder' whereas it would > make more sense in many places to call it just 'encoder'. > > This patch does a similar cleanup in

[Intel-gfx] [PATCH 1/5] drm/i915: Use new atomic iterator macros in ddi

2017-03-09 Thread Maarten Lankhorst
Use for_each_new_connector_in_state instead of for_each_connector_in_state. Also make the function static, it's only used inside intel_ddi.c Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_ddi.c | 4 ++-- drivers/gpu/drm/i915/intel_drv.h | 2 --

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: cleanup patch for intel_ddi.c

2017-03-09 Thread Patchwork
== Series Details == Series: drm/i915: cleanup patch for intel_ddi.c URL : https://patchwork.freedesktop.org/series/20984/ State : success == Summary == Series 20984v1 drm/i915: cleanup patch for intel_ddi.c https://patchwork.freedesktop.org/api/1.0/series/20984/revisions/1/mbox/ Test

[Intel-gfx] [PATCH 5/5] drm/i915: Use new atomic iterator macros in cdclk

2017-03-09 Thread Maarten Lankhorst
Calculating the max pixel rate requires the new state, so use it there. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_cdclk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_cdclk.c

[Intel-gfx] [PATCH 4/5] drm/i915: Use new atomic iterator macros in display code

2017-03-09 Thread Maarten Lankhorst
Add a big fat warning in __intel_display_resume that the old state is invalid, and use the correct state everywhere. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 161 ++- 1 file changed, 82

[Intel-gfx] [PATCH 3/5] drm/i915: Use new atomic iterator macros in wm code

2017-03-09 Thread Maarten Lankhorst
The watermark code needs to look at the new allocations, so use for_each_new_crtc_in_state everywhere. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_pm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[Intel-gfx] [PATCH 0/5] drm/i915: Use new atomic iterator macros.

2017-03-09 Thread Maarten Lankhorst
Some small patchset to deal with the atomic iterator changes. Maarten Lankhorst (5): drm/i915: Use new atomic iterator macros in ddi drm/i915: Use new atomic iterator macros in fbc drm/i915: Use new atomic iterator macros in wm code drm/i915: Use new atomic iterator macros in display code

[Intel-gfx] [PATCH 2/5] drm/i915: Use new atomic iterator macros in fbc

2017-03-09 Thread Maarten Lankhorst
Use for_each_new_plane_in_state, only the new state is needed. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_fbc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_fbc.c

Re: [Intel-gfx] [PATCH] drm/i915/gvt: add enable_execlists check before enable gvt

2017-03-09 Thread Dong, Chuanxiao
> -Original Message- > From: Jani Nikula [mailto:jani.nik...@linux.intel.com] > Sent: Thursday, March 9, 2017 9:48 PM > To: Chris Wilson; Dong, Chuanxiao > Cc: intel-gfx@lists.freedesktop.org; intel-gvt-...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/gvt: add

Re: [Intel-gfx] [PATCH] drm/i915: Ignore skl+ for debugfs/i915_sr_status

2017-03-09 Thread Ville Syrjälä
On Thu, Mar 09, 2017 at 02:20:49PM +, Chris Wilson wrote: > There is no easily digestible single self-refresh status bit, so don't > report one for debugfs/i915_sr_status. > > Signed-off-by: Chris Wilson > Cc: Ville Syrjälä

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix vGPU balloon for ggtt guard page

2017-03-09 Thread Patchwork
== Series Details == Series: drm/i915: Fix vGPU balloon for ggtt guard page URL : https://patchwork.freedesktop.org/series/20983/ State : failure == Summary == Series 20983v1 drm/i915: Fix vGPU balloon for ggtt guard page

[Intel-gfx] [PATCH] drm/i915: Ignore skl+ for debugfs/i915_sr_status

2017-03-09 Thread Chris Wilson
There is no easily digestible single self-refresh status bit, so don't report one for debugfs/i915_sr_status. Signed-off-by: Chris Wilson Cc: Ville Syrjälä --- drivers/gpu/drm/i915/i915_debugfs.c | 4 +++- 1 file changed, 3

Re: [Intel-gfx] [PATCH] drm/i915/gvt: add enable_execlists check before enable gvt

2017-03-09 Thread Jani Nikula
On Thu, 09 Mar 2017, Chris Wilson wrote: > On Thu, Mar 09, 2017 at 01:03:17PM +, Dong, Chuanxiao wrote: >> The message printed is longer than 80 characters, and checkpatch tool also >> complain with " quoted string split across lines" by splitting to multiple >>

[Intel-gfx] [PATCH v2] drm/i915: Remove intel_ prefix from encoder variables in intel_ddi.c

2017-03-09 Thread Shashank Sharma
In I915 driver, there are many places where variable name for intel_encoder object is given as 'intel_encoder' whereas it would make more sense to call it just 'encoder' when possible. This patch does this cleanup in file intel_ddi.c. PS: There are few functions where both drm_encoder and

Re: [Intel-gfx] [PATCH] drm/i915/gvt: add enable_execlists check before enable gvt

2017-03-09 Thread Chris Wilson
On Thu, Mar 09, 2017 at 01:03:17PM +, Dong, Chuanxiao wrote: > > > > -Original Message- > > From: intel-gvt-dev [mailto:intel-gvt-dev-boun...@lists.freedesktop.org] On > > Behalf Of Chris Wilson > > Sent: Thursday, March 9, 2017 8:45 PM > > To: Dong, Chuanxiao

[Intel-gfx] [CI 2/2] HAX enable guc submission for CI

2017-03-09 Thread Tvrtko Ursulin
From: Chris Wilson --- drivers/gpu/drm/i915/i915_params.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index 2e9645e6555a..8fa96edddf9f 100644 ---

[Intel-gfx] [CI 1/2] drm/i915/guc: Fix request re-submission after reset

2017-03-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In order to ensure no missed interrupts we must first re-direct the interrupts to GuC, and only then re-submit the requests to be replayed after a GPU reset. Otherwise context switch can fire before GuC has been set up to receive it triggering more

[Intel-gfx] [PATCH 2/3] drm/i915: Convert intel_dp_mst connector properties to atomic.

2017-03-09 Thread Maarten Lankhorst
MST doesn't support setting any properties, but it should still use the atomic helper for setting properties. Only path and tile properties are supported (read-only), so keep using the i915 helper for obtaining those properties. Signed-off-by: Maarten Lankhorst

[Intel-gfx] [PATCH 1/3] drm/i915: Convert intel_tv connector properties to atomic.

2017-03-09 Thread Maarten Lankhorst
As a proof of concept, first try to convert intel_tv, which is a rarely used connector. It has 5 properties, tv format and 4 margins. I'm less certain about the state behavior itself, should we pass a size parameter to intel_connector_alloc instead, so duplicate_state can be done globally if it

[Intel-gfx] [PATCH 3/3] drm/i915: Convert intel_crt connector properties to atomic.

2017-03-09 Thread Maarten Lankhorst
No properties are supported, so just use the helper and reject everything. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_crt.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_crt.c

[Intel-gfx] [PATCH 0/3] drm/i915: Convert tv/dp_mst and crt connector properties to atomic.

2017-03-09 Thread Maarten Lankhorst
intel_tv is a proof of concept conversion to discuss the API. The other 2 connectors are straightforward. Maarten Lankhorst (3): drm/i915: Convert intel_tv connector properties to atomic. drm/i915: Convert intel_dp_mst connector properties to atomic. drm/i915: Convert intel_crt connector

Re: [Intel-gfx] [PATCH] drm/i915/gvt: add enable_execlists check before enable gvt

2017-03-09 Thread Dong, Chuanxiao
> -Original Message- > From: intel-gvt-dev [mailto:intel-gvt-dev-boun...@lists.freedesktop.org] On > Behalf Of Chris Wilson > Sent: Thursday, March 9, 2017 8:45 PM > To: Dong, Chuanxiao > Cc: intel-gfx@lists.freedesktop.org; intel-gvt-...@lists.freedesktop.org

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Restore engine->submit_request before unwedging

2017-03-09 Thread Patchwork
== Series Details == Series: drm/i915: Restore engine->submit_request before unwedging URL : https://patchwork.freedesktop.org/series/20982/ State : failure == Summary == Series 20982v1 drm/i915: Restore engine->submit_request before unwedging

Re: [Intel-gfx] [PATCH] drm/i915/gvt: add enable_execlists check before enable gvt

2017-03-09 Thread Chris Wilson
On Thu, Mar 09, 2017 at 12:32:18PM +, Dong, Chuanxiao wrote: > Hi, > > Any comments to this patch? > > Thanks > Chuanxiao > > > -Original Message- > > From: intel-gvt-dev [mailto:intel-gvt-dev-boun...@lists.freedesktop.org] On > > Behalf Of Chuanxiao Dong > > Sent: Monday, March 6,

Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix request re-submission after reset

2017-03-09 Thread Chris Wilson
On Thu, Mar 09, 2017 at 12:06:37PM +, Chris Wilson wrote: > On Thu, Mar 09, 2017 at 10:19:10AM +, Chris Wilson wrote: > > On Thu, Mar 09, 2017 at 10:05:21AM +, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > In order to ensure no missed

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Initialize pm_intr_keep during intel_irq_init for GuC

2017-03-09 Thread Chris Wilson
On Tue, Mar 07, 2017 at 10:22:35AM +0530, Sagar Arun Kamble wrote: > Driver needs to ensure that it doesn't mask the PM interrupts, which are > unmasked/needed by GuC firmware. For that, Driver maintains a bitmask of > interrupts to be kept unmasked, pm_intr_keep. > > pm_intr_keep was determined

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for HAX enable guc submission for CI

2017-03-09 Thread Chris Wilson
On Thu, Mar 09, 2017 at 12:23:24PM -, Patchwork wrote: > == Series Details == > > Series: HAX enable guc submission for CI > URL : https://patchwork.freedesktop.org/series/20981/ > State : failure > > == Summary == > > Series 20981v1 HAX enable guc submission for CI >

Re: [Intel-gfx] [PATCH] drm/i915/gvt: add enable_execlists check before enable gvt

2017-03-09 Thread Dong, Chuanxiao
Hi, Any comments to this patch? Thanks Chuanxiao > -Original Message- > From: intel-gvt-dev [mailto:intel-gvt-dev-boun...@lists.freedesktop.org] On > Behalf Of Chuanxiao Dong > Sent: Monday, March 6, 2017 1:16 PM > To: intel-gfx@lists.freedesktop.org; intel-gvt-...@lists.freedesktop.org

[Intel-gfx] ✗ Fi.CI.BAT: failure for HAX enable guc submission for CI

2017-03-09 Thread Patchwork
== Series Details == Series: HAX enable guc submission for CI URL : https://patchwork.freedesktop.org/series/20981/ State : failure == Summary == Series 20981v1 HAX enable guc submission for CI https://patchwork.freedesktop.org/api/1.0/series/20981/revisions/1/mbox/ Test gem_ctx_create:

Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix request re-submission after reset

2017-03-09 Thread Chris Wilson
On Thu, Mar 09, 2017 at 10:19:10AM +, Chris Wilson wrote: > On Thu, Mar 09, 2017 at 10:05:21AM +, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > In order to ensure no missed interrupts we must first re-direct > > the interrupts to GuC, and only then

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] drm/i915: Initialize pm_intr_keep during intel_irq_init for GuC

2017-03-09 Thread Chris Wilson
On Thu, Mar 09, 2017 at 11:54:31AM -, Patchwork wrote: > == Series Details == > > Series: series starting with [CI,1/2] drm/i915: Initialize pm_intr_keep > during intel_irq_init for GuC > URL : https://patchwork.freedesktop.org/series/20980/ > State : failure > > == Summary == > > Series

Re: [Intel-gfx] [PATCH i-g-t 4/4] assembler/gen8_disasm.c: Remove unused m_mask_ctrl

2017-03-09 Thread Mika Kahola
On Wed, 2017-03-08 at 16:44 +0200, Petri Latvala wrote: > Signed-off-by: Petri Latvala Reviewed-by: Mika Kahola > --- >  assembler/gen8_disasm.c | 5 - >  1 file changed, 5 deletions(-) > > diff --git a/assembler/gen8_disasm.c

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] drm/i915: Initialize pm_intr_keep during intel_irq_init for GuC

2017-03-09 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Initialize pm_intr_keep during intel_irq_init for GuC URL : https://patchwork.freedesktop.org/series/20980/ State : failure == Summary == Series 20980v1 Series without cover letter

Re: [Intel-gfx] [PATCH i-g-t v3] Add the new tool for create GVT-g Linux guest based on KVMGT

2017-03-09 Thread Xu, Terrence
Thanks Petri, agree with all your comments! Thanks Terrence >-Original Message- >From: Latvala, Petri >Sent: Thursday, March 9, 2017 6:58 PM >To: Xu, Terrence >Cc: intel-gfx@lists.freedesktop.org; Jin, Gordon ; >Sarvela, >Tomi P

[Intel-gfx] [PATCH] drm/i915: make context status notifier head be per engine

2017-03-09 Thread changbin . du
From: Changbin Du GVTg has introduced the context status notifier to schedule the GVTg workload. At that time, the notifier is bound to GVTg context only, so GVTg is not aware of host workloads. Now we are going to improve GVTg's guest workload scheduler policy, and add

Re: [Intel-gfx] [PATCH] drm/i915: cleanup patch for intel_ddi.c

2017-03-09 Thread Ander Conselvan De Oliveira
The summary should say what the clean up is about. For example: drm/i915: Remove intel_ prefix from encoder variables in intel_ddi.c With that fixed, Reviewed-by: Ander Conselvan de Oliveira On Thu, 2017-03-09 at 16:28 +0530, Shashank Sharma wrote: > In I915 driver,

Re: [Intel-gfx] [PATCH i-g-t v3] Add the new tool for create GVT-g Linux guest based on KVMGT

2017-03-09 Thread Petri Latvala
On Fri, Mar 10, 2017 at 03:34:49AM +0800, Terrence Xu wrote: > GVT-g (Intel® Graphics Virtualization Technology) is a full GPU > virtualization solution with mediated pass-through support. > > This tool is for create basic Linux guest based on KVMGT with > VFIO framework, it including create

  1   2   >