Re: [Intel-gfx] [PATCH 18/18] drm/i915/cnl: Enable wrpll computation for CNL

Patches merged to dinq, thanks for the patches and reviews! On Fri, Jun 9, 2017 at 3:27 PM Rodrigo Vivi wrote: > From: "Kahola, Mika" > > Enable wrpll computation for Cannonlake platform to support > pll's required for HDMI output. The patch

Re: [Intel-gfx] [PATCH] drm/i915/cfl: Basic DDI plumbing for Coffee Lake. (fwd)

Patch Merges to dinq, thanks for the reviews. Julia, DK had also pointed that out and the issue was addressed on latest version that got reviewed and merged. I'm sorry but I only saw your comment after I had merged the patch, otherwise I'd have mentioned you also. On Sun, Jun 11, 2017 at

Re: [Intel-gfx] [PATCH v2] igt/gem_reset_stats: Fix pending batches status expectation

On 12/06/17 14:37, Antonio Argenziano wrote: Test expects pending batches to be discarded after a reset. After commit 821ed7df6e2a ("drm/i915: Update reset path to fix incomplete requests"), That is no longer the case. Fixed to expect a normal execution. V2: Updated commit message (Michel

[Intel-gfx] [PATCH v2] igt/gem_reset_stats: Fix pending batches status expectation

Test expects pending batches to be discarded after a reset. After commit 821ed7df6e2a ("drm/i915: Update reset path to fix incomplete requests"), That is no longer the case. Fixed to expect a normal execution. V2: Updated commit message (Michel Thierry) Cc: Michel Thierry

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Don't enable backlight at setup time.

== Series Details == Series: drm/i915: Don't enable backlight at setup time. URL : https://patchwork.freedesktop.org/series/25677/ State : success == Summary == Series 25677v1 drm/i915: Don't enable backlight at setup time.

[Intel-gfx] [PATCH] drm/i915: Don't enable backlight at setup time.

Maarten and Ville noticed that we are enabling backlight via DP aux very early in the modeset_init path via the intel_dp_aux_setup_backlight() function. Looks like all we need to do during _setup_backlight() is read the current brightness state instead of modifying it, so I don't why need to

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/dp: Generalize intel_dp_link_params function to accept arguments to be validated

Can this be merged? It has a r-b from Jani Nikula. On Thu, Jun 08, 2017 at 01:41:02PM -0700, Manasi Navare wrote: > This function now takes the link rate and lane ocunt to be validated > as an argument so that this can be used for validating even the > compliance test link parameters. > >

Re: [Intel-gfx] [PATCH v16 08/17] drm/i915/perf: Add OA unit support for Gen 8+

On 12/06/17 18:23, Matthew Auld wrote: On 5 June 2017 at 15:48, Lionel Landwerlin wrote: From: Robert Bragg Enables access to OA unit metrics for BDW, CHV, SKL and BXT which all share (more-or-less) the same OA unit design. Of particular

Re: [Intel-gfx] drm/i915: Make MMIO_PORT flexible.

On Mon, Jun 12, 2017 at 10:11 AM, Ville Syrjälä wrote: > On Mon, Jun 12, 2017 at 04:28:28PM +, Vivi, Rodrigo wrote: >> On Mon, 2017-06-12 at 17:56 +0300, Ville Syrjälä wrote: >> > On Fri, Jun 09, 2017 at 02:07:33PM -0700, Rodrigo Vivi wrote: >> > > In the past

Re: [Intel-gfx] [PATCH v16 08/17] drm/i915/perf: Add OA unit support for Gen 8+

On 5 June 2017 at 15:48, Lionel Landwerlin wrote: > From: Robert Bragg > > Enables access to OA unit metrics for BDW, CHV, SKL and BXT which all > share (more-or-less) the same OA unit design. > > Of particular note in comparison to Haswell:

Re: [Intel-gfx] drm/i915: Make MMIO_PORT flexible.

On Mon, Jun 12, 2017 at 04:28:28PM +, Vivi, Rodrigo wrote: > On Mon, 2017-06-12 at 17:56 +0300, Ville Syrjälä wrote: > > On Fri, Jun 09, 2017 at 02:07:33PM -0700, Rodrigo Vivi wrote: > > > In the past the magic reg_a + (reg_b - reg_a) * port > > > was enough because every new register that was

Re: [Intel-gfx] drm/i915: Make MMIO_PORT flexible.

On Mon, 2017-06-12 at 17:56 +0300, Ville Syrjälä wrote: > On Fri, Jun 09, 2017 at 02:07:33PM -0700, Rodrigo Vivi wrote: > > In the past the magic reg_a + (reg_b - reg_a) * port > > was enough because every new register that was appearing > > on new platforms was respecting the same gap. > > > >

[Intel-gfx] ✗ Fi.CI.BAT: failure for HPD support during suspend for BXT/APL. (rev3)

== Series Details == Series: HPD support during suspend for BXT/APL. (rev3) URL : https://patchwork.freedesktop.org/series/15833/ State : failure == Summary == Series 15833v3 HPD support during suspend for BXT/APL. https://patchwork.freedesktop.org/api/1.0/series/15833/revisions/3/mbox/ Test

[Intel-gfx] [PATCH v4 5/5] drm/i915: Enable HPD interrupts with master ctl interrupt

While suspending the device hpd related interrupts are enabled to get the interrupt when device is in suspend state. Though display is in DC9 but system can be in S0 or S0i3 state. Hot plug during S0 state will generate de_port_interrupt but if system is in S0i3 state then display driver will get

[Intel-gfx] [PATCH v4 4/5] drm/i915/bxt: Block D3 during suspend.

For BXT, display engine can not generate interrupt when in D3. On the othen hand S0ix can be achieved without display in D3. So, Display should not put into D3 for HPD to work and will not have any power impact. v1: Initial version as RFC. v2: Based on review comment from David, condition check

[Intel-gfx] [PATCH v4 2/5] drm/i915/bxt: VBT changes for hpd as wakeup feature

To support hpd during sleep a new feature flag is added in vbt and also in dev_priv for enabling/disabling inside driver. By default this feature will be disabled and based on oem request this feature can be enabled by changing vbt feature flag. v1: Initial version as RFC. v2: Based on review

[Intel-gfx] [PATCH v4 3/5] drm/i915/bxt: Added _DSM call to set HPD_CTL.

_DSM is added to program HPD_CTL(0x1094) register of PMC from i915 driver which will be called based on driver feature flag. During S0ix display engine is completely powered down. Hot plug will be missed by display HPD detection logic. GPIO unit detect any edge on HPD pin and then triggers

[Intel-gfx] [PATCH v4 1/5] drm/i915/bxt: Corrected the guid for bxt.

Guid is changed for bxt platform, so corrected the guid for bxt. v1: Initial version as RFC. v2: Based on review comment from Jani and David, have kept guid as binary format. v3: Based on review comment from Chris and Jani, - kept the const for guid. - corrected the file permission.

[Intel-gfx] [PATCH v4 0/5] HPD support during suspend for BXT/APL.

Along with below patches sharing some background details/design. - On BXT, Display cannot generate an interrupt when in D3. - Without display in D3, S0ix can be achieved, Power impact will be zero if d3 is blocked. PMCSR for Graphics/Display is irrelevant, as the power management for them is

Re: [Intel-gfx] [PATCH IGT] tests/chamelium: Close DRM file descriptor after tests

On Mon, 2017-06-12 at 17:39 +0300, Paul Kocialkowski wrote: > This adds a call to close the DRM file descriptor. It is reauired as IGT > will attempt to become DRM master after running the test, resulting in a > failure. This should fix (at least) 3 of the failures seen on the CI machine that

Re: [Intel-gfx] [PATCH v16 08/17] drm/i915/perf: Add OA unit support for Gen 8+

On 12/06/17 15:02, Matthew Auld wrote: On 5 June 2017 at 15:48, Lionel Landwerlin wrote: From: Robert Bragg Enables access to OA unit metrics for BDW, CHV, SKL and BXT which all share (more-or-less) the same OA unit design. Of particular

Re: [Intel-gfx] drm/i915: Make MMIO_PORT flexible.

On Fri, Jun 09, 2017 at 02:07:33PM -0700, Rodrigo Vivi wrote: > In the past the magic reg_a + (reg_b - reg_a) * port > was enough because every new register that was appearing > on new platforms was respecting the same gap. > > However on more recent platforms we start seeing many > registers

[Intel-gfx] [PATCH IGT] tests/chamelium: Close DRM file descriptor after tests

This adds a call to close the DRM file descriptor. It is reauired as IGT will attempt to become DRM master after running the test, resulting in a failure. Signed-off-by: Paul Kocialkowski --- tests/chamelium.c | 4 1 file changed, 4 insertions(+) diff

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Pass atomic state to backlight enable/disable/set callbacks.

On Mon, Jun 12, 2017 at 03:48:04PM +0300, Ville Syrjälä wrote: > On Mon, Jun 12, 2017 at 12:21:15PM +0200, Maarten Lankhorst wrote: > > Pass crtc_state to the enable callback, and connector_state to all > > callbacks. > > This will eliminate the need to guess for the correct pipe in these > >

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Pass atomic state to backlight enable/disable/set callbacks.

Op 12-06-17 om 14:48 schreef Ville Syrjälä: > On Mon, Jun 12, 2017 at 12:21:15PM +0200, Maarten Lankhorst wrote: >> Pass crtc_state to the enable callback, and connector_state to all callbacks. >> This will eliminate the need to guess for the correct pipe in these >> callbacks. >> >> The crtc

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Add NV12 support to intel_framebuffer_init

On Wed, Jun 07, 2017 at 04:11:48PM +0530, Vidya Srinivas wrote: > From: Chandra Konduru > > This patch adds NV12 as supported format > to intel_framebuffer_init and performs various checks. > > v2: > -Fix an issue in checks added (Chandra Konduru) > > v3: rebased

Re: [Intel-gfx] [PATCH 7/8] drm/i915: Add NV12 as supported format for sprite plane

On Wed, Jun 07, 2017 at 04:11:47PM +0530, Vidya Srinivas wrote: > From: Chandra Konduru > > This patch adds NV12 to list of supported formats for sprite plane. > > v2: Rebased (me) > > Link: https://patchwork.kernel.org/patch/6426211/ > Signed-off-by: Chandra Konduru

Re: [Intel-gfx] [PATCH] drm/core: Fail atomic IOCTL with no CRTC state but with signaling.

On 06/12/2017 07:08 AM, Maarten Lankhorst wrote: Op 09-06-17 om 23:30 schreef Andrey Grodzovsky: Problem: While running IGT kms_atomic_transition test suite i encountered a hang in drmHandleEvent immidietly follwoing an atomic_commit. After dumping the atomic state I relized that in this case

Re: [Intel-gfx] [PATCH 6/8] drm/i915: Add NV12 as supported format for primary plane

On Wed, Jun 07, 2017 at 04:11:46PM +0530, Vidya Srinivas wrote: > From: Chandra Konduru > > This patch adds NV12 to list of supported formats for > primary plane > > v2: Rebased (Chandra Konduru) > > v3: Rebased (me) > > Link:

Re: [Intel-gfx] [PATCH 5/8] drm/i915: Upscale scaler max scale for NV12

On Wed, Jun 07, 2017 at 04:11:45PM +0530, Vidya Srinivas wrote: > From: Chandra Konduru > > This patch updates scaler max limit support for NV12 > > Link: https://patchwork.kernel.org/patch/6426191/ > Signed-off-by: Chandra Konduru >

Re: [Intel-gfx] [PATCH v16 08/17] drm/i915/perf: Add OA unit support for Gen 8+

On 5 June 2017 at 15:48, Lionel Landwerlin wrote: > From: Robert Bragg > > Enables access to OA unit metrics for BDW, CHV, SKL and BXT which all > share (more-or-less) the same OA unit design. > > Of particular note in comparison to Haswell:

Re: [Intel-gfx] [PATCH 3/8] drm/i915: Set scaler mode for NV12

On Wed, Jun 07, 2017 at 04:11:43PM +0530, Vidya Srinivas wrote: > From: Chandra Konduru > > This patch sets appropriate scaler mode for NV12 format. > In this mode, skylake scaler does either chroma-upsampling or > chroma-upsampling and resolution scaling > > Link:

Re: [Intel-gfx] [PATCH] drm/i915: Make i915_gem_object_phys_attach() use obj->mm.lock more appropriately

On Thu, Jun 08, 2017 at 11:53:44AM +0100, Chris Wilson wrote: > Actually transferring from shmemfs to the physically contiguous set of > pages should be wholly guarded by its obj->mm.lock! > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/i915_gem.c | 43 >

Re: [Intel-gfx] [PATCH i-g-t] tests: Rename I915_MAX_PIPES to IGT_MAX_PIPES

On 2017-06-12 07:54 AM, Arkadiusz Hiler wrote: > On Fri, Jun 09, 2017 at 06:14:52PM -0400, Harry Wentland wrote: >> Reviewed-by: Harry Wentland >> >> Harry > > Hey, > > Was the mail sent here in the first place? I cannot find it. I would > like to apply it, but having no

[Intel-gfx] [PATCH IGT] tests/chamelium: Require HPD storm control for basic hotplug test

The basic hotplug test (test_basic_hotplug) makes calls to igt_hpd_storm_set_threshold, which requires HPD storm control. This adds a check for that control, since it was missing. Signed-off-by: Paul Kocialkowski --- tests/chamelium.c | 2 ++ 1 file changed,

Re: [Intel-gfx] v4.9+ stable backport request

On Fri, May 26, 2017 at 02:21:10PM +0300, Jani Nikula wrote: > > Stable team, please backport upstream commits > > 665788572c64 ("drm/i915/vbt: don't propagate errors from intel_bios_init()") > bb1d132935c2 ("drm/i915/vbt: split out defaults that are set when there is no > VBT") > > to stable

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Pass atomic state to backlight enable/disable/set callbacks.

On Mon, Jun 12, 2017 at 12:21:15PM +0200, Maarten Lankhorst wrote: > Pass crtc_state to the enable callback, and connector_state to all callbacks. > This will eliminate the need to guess for the correct pipe in these > callbacks. > > The crtc state is required for pch_enable_backlight to obtain

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix GVT-g PVINFO version compatibility check (rev3)

On pe, 2017-06-09 at 08:10 +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Fix GVT-g PVINFO version compatibility check (rev3) > URL   : https://patchwork.freedesktop.org/series/25275/ > State : success Applied. Thanks for the patch. Regards, Joonas -- Joonas Lahtinen Open

Re: [Intel-gfx] [PATCH i-g-t v2] tests: Increase value of I915_MAX_PIPES to 6

On Fri, Jun 09, 2017 at 08:43:18PM +, Deucher, Alexander wrote: > > -Original Message- > > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > > Of sunpeng...@amd.com > > Sent: Friday, June 09, 2017 4:18 PM > > To: intel-gfx@lists.freedesktop.org;

Re: [Intel-gfx] [i-g-t PATCH v3 1/3] lib/igt_core: Add igt_system helpers

On Tue, Jun 06, 2017 at 11:54:12AM +0300, Abdiel Janulgue wrote: > Support executing external processes with the goal of capturing its > standard streams to the igt logging infrastructure in addition to its > exit status. > > v3: Rename igt_exec -> igt_system (Chris). > > v2: Fix leaks on fd

Re: [Intel-gfx] [PATCH i-g-t] tests: Rename I915_MAX_PIPES to IGT_MAX_PIPES

On Fri, Jun 09, 2017 at 06:14:52PM -0400, Harry Wentland wrote: > Reviewed-by: Harry Wentland > > Harry Hey, Was the mail sent here in the first place? I cannot find it. I would like to apply it, but having no easily digestible form available makes it hard. Can you

Re: [Intel-gfx] [i-g-t PATCH 2/3] igt/igt_core: Provide an option to check for the log buffer contents

On Tue, Jun 06, 2017 at 11:54:13AM +0300, Abdiel Janulgue wrote: > Signed-off-by: Abdiel Janulgue > --- > lib/igt_core.c | 24 > lib/igt_core.h | 3 +++ > 2 files changed, 27 insertions(+) > > diff --git a/lib/igt_core.c

Re: [Intel-gfx] [PATCH IGT] Replace mentions of Intel GPU Tools by IGT GPU Tools

On Mon, 2017-06-12 at 14:32 +0300, Paul Kocialkowki wrote: > Since IGT supports much more that testing for the Intel DRM driver, it > was renamed to IGT GPU Tools instead of Intel GPU Tools. > > This replaces the remaining mentions of Intel GPU Tools in favor of > IGT GPU tools. > >

[Intel-gfx] [PATCH IGT v2] Replace mentions of Intel GPU Tools by IGT GPU Tools

Since IGT supports much more that testing for the Intel DRM driver, it was renamed to IGT GPU Tools instead of Intel GPU Tools. This replaces the remaining mentions of Intel GPU Tools in favor of IGT GPU tools. Signed-off-by: Paul Kocialkowski --- README

[Intel-gfx] [PATCH IGT] Replace mentions of Intel GPU Tools by IGT GPU Tools

Since IGT supports much more that testing for the Intel DRM driver, it was renamed to IGT GPU Tools instead of Intel GPU Tools. This replaces the remaining mentions of Intel GPU Tools in favor of IGT GPU tools. Signed-off-by: Paul Kocialkowki --- README

Re: [Intel-gfx] [i-g-t PATCH v3 3/3] Convert shell script tests to C version

On Tue, Jun 06, 2017 at 11:54:14AM +0300, Abdiel Janulgue wrote: > v3: Drop redundant test covered by drv_hangman/basic. Descend thru > debugfs path when reading sysfs entries (Chris). > > v2: Use internal igt_debugfs functions instead of cat and document > debugfs tests. > Convert

Re: [Intel-gfx] [PATCH] drm/core: Fail atomic IOCTL with no CRTC state but with signaling.

Op 09-06-17 om 23:30 schreef Andrey Grodzovsky: > Problem: > While running IGT kms_atomic_transition test suite i encountered > a hang in drmHandleEvent immidietly follwoing an atomic_commit. > After dumping the atomic state I relized that in this case there was > not even one CRTC attached to the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Pass atomic state to backlight.

== Series Details == Series: drm/i915: Pass atomic state to backlight. URL : https://patchwork.freedesktop.org/series/25643/ State : success == Summary == Series 25643v1 drm/i915: Pass atomic state to backlight. https://patchwork.freedesktop.org/api/1.0/series/25643/revisions/1/mbox/ Test

Re: [Intel-gfx] [PATCH 0/4] Cleanups and fixes

On Fri, Jun 09, 2017 at 03:37:54PM +0300, Arkadiusz Hiler wrote: > On Fri, Jun 09, 2017 at 03:34:42PM +0300, Arkadiusz Hiler wrote: > > On Mon, Jun 05, 2017 at 02:28:36PM +0100, Liviu Dudau wrote: > > > From: Liviu Dudau > > > > > > Hello, > > > > > > I believe Brian has

[Intel-gfx] [PATCH 2/3] drm/i915: Pass connector state to intel_panel_set_backlight_acpi

Passing the state is also needed to convert the backlight functions to use the correct state instead of looking it up. This is done as a separate commit to allow easier bisecting. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100022 Signed-off-by: Maarten Lankhorst

[Intel-gfx] [PATCH 0/3] drm/i915: Pass atomic state to backlight.

This fixes the following WARN_ON that may happen when running kms_cursor_legacy and kms_atomic_transitions on a system with backlight: [ 219.968428] [ cut here ] [ 219.968481] WARNING: CPU: 3 PID: 2457 at drivers/gpu/drm/i915/intel_display.c:13881

[Intel-gfx] [PATCH 3/3] drm/i915: Pass atomic state to backlight enable/disable/set callbacks.

Pass crtc_state to the enable callback, and connector_state to all callbacks. This will eliminate the need to guess for the correct pipe in these callbacks. The crtc state is required for pch_enable_backlight to obtain the correct cpu_transcoder. intel_dp_aux_backlight's setup function is called

[Intel-gfx] [PATCH 1/3] drm/i915: Pass crtc_state and connector state to backlight enable/disable functions

The backlight functions need to determine the pipe and the transcoder the backlight will be enabled on, so pass crtc_state instead of trying to dereference the state without holding locks. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100022 Signed-off-by: Maarten Lankhorst

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Make MMIO_PORT flexible.

== Series Details == Series: drm/i915: Make MMIO_PORT flexible. URL : https://patchwork.freedesktop.org/series/25491/ State : success == Summary == Series 25491v1 drm/i915: Make MMIO_PORT flexible. https://patchwork.freedesktop.org/api/1.0/series/25491/revisions/1/mbox/ Test