Re: [Intel-gfx] [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails

2017-06-27 Thread Daniel Vetter
On Tue, Jun 27, 2017 at 10:51 PM, Jeff Kirsher wrote: > This was submitted and accepted into David Miller's net-next tree. I can > see if Dave can pull it into his net tree. DOes stable need to pick this > up as well? Nah if it landed somewhere at least I'm happy, we can carry the fixup for a w

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/edp: Add a PPS T12 delay quirk to fix DP AUX CH timeouts

2017-06-27 Thread Patchwork
== Series Details == Series: drm/i915/edp: Add a PPS T12 delay quirk to fix DP AUX CH timeouts URL : https://patchwork.freedesktop.org/series/26463/ State : success == Summary == Series 26463v1 drm/i915/edp: Add a PPS T12 delay quirk to fix DP AUX CH timeouts https://patchwork.freedesktop.org/

[Intel-gfx] [PATCH] drm/i915/edp: Add a PPS T12 delay quirk to fix DP AUX CH timeouts

2017-06-27 Thread Manasi Navare
This patch fixes the DP AUX CH timeouts observed during CI IGT tests thus fixing the CI failures. This is done by adding a quirk for a particular PCI device that requires the PPS power cycle delay (T12) to be 300msecs more than the minimum value specified in the eDP spec. So a quirk is implemented

Re: [Intel-gfx] [PATCH 00/13] fbdev locking rework and deferred setup, take 2

2017-06-27 Thread John Stultz
On Tue, Jun 27, 2017 at 7:59 AM, Daniel Vetter wrote: > > Thanks to Liviu's help I realized that I fumbled the locking rework > completely. > This one here should be better, but somehow I'm having a real bad day today > and > I spent all day typing shit code, and then making it worse. > > This h

Re: [Intel-gfx] [PATCH v12 3/3] drm/i915: Add option to support dynamic backlight via DPCD

2017-06-27 Thread Pandiyan, Dhinakaran
On Tue, 2017-06-27 at 16:23 +0300, David Weinehall wrote: > On Mon, Jun 26, 2017 at 05:18:19PM +0300, David Weinehall wrote: > > On Thu, Jun 22, 2017 at 12:03:39PM -0700, Puthikorn Voravootivat wrote: > > > This patch adds option to enable dynamic backlight for eDP > > > panel that supports this

Re: [Intel-gfx] [PATCH i-g-t v2 5/7] tests/chamelium: Update connector state without reprobe when possible

2017-06-27 Thread Lyude Paul
I -think- this one might be okay but I just got reminded of a rather not-obvious part of the DRM spec for hotplugging, and I need to check that this doesn't actually break that. will get back to you in a bit with an actual review :) On Tue, 2017-06-27 at 13:53 +0300, Paul Kocialkowski wrote: > Thi

Re: [Intel-gfx] [PATCH i-g-t v2 1/7] lib/igt_aux: Use provided autoresume delay for rtc wake

2017-06-27 Thread Lyude Paul
FYI: I reviewed and pushed patches 1-4 of this series, thanks! On Tue, 2017-06-27 at 13:53 +0300, Paul Kocialkowski wrote: > This stores the autoresume delay provided via > igt_set_autoresume_delay > for use during suspend via rtc wake scheduling. This delay was > previously only used for pm_test

Re: [Intel-gfx] [RFC] drm/i915: Add GuC timeout config options to Kconfig.debug

2017-06-27 Thread Kelvin Gardiner
Hi, Any feedback on this? Thanks, Kelvin On 13/06/17 16:19, Kelvin Gardiner wrote: It is sometimes useful for debug purposes to be able to set GuC timeout lengths. This patch adds GuC load and request timeouts values to Kconfig.debug, which can then be optionally set as required for debug cas

Re: [Intel-gfx] [PATCH i-g-t v2 6/7] tests/chamelium: Disconnect connectors without extra reset

2017-06-27 Thread Lyude Paul
NAK, I'd rather just go with the idea you had with removing the connector reset in chamelium_init() On Tue, 2017-06-27 at 13:53 +0300, Paul Kocialkowski wrote: > This removes the reset call from the reset_state function and renames > it > to disconnect_connector. Since a call to reset is already d

Re: [Intel-gfx] [PATCH i-g-t v2 7/7] Make igtrc configuration common, with configurable suspend/resume delay

2017-06-27 Thread Lyude Paul
On Tue, 2017-06-27 at 13:53 +0300, Paul Kocialkowski wrote: > This adds support for configurable suspend/resume delay and takes the > occasion to move igtrc configuation from igt_chamelium to igt_core. > This way, suspend/resume delay configuration can be used for all > tests. > > Signed-off-by

[Intel-gfx] [PATCH i-g-t] intel-ci: Add fast-feedback-simulation.testlist

2017-06-27 Thread Kelvin Gardiner
Added an initial list of fast feedback tests for simulation environments. Cc: Petri Latvala Signed-off-by: Kelvin Gardiner --- tests/intel-ci/README| 8 +++ tests/intel-ci/fast-feedback-simulation.testlist | 91 2 files changed, 99 insertion

[Intel-gfx] [PULL] drm-misc-next-fixes

2017-06-27 Thread Sean Paul
Hi Dave, When I said I had ~6 changes yesterday, I was lying. 3 of those changes were included in the final misc-next pull and already exist in your tree. So then there were 3. All quite simple, nothing to write home about. You'll notice the unsightly backmerges below, this was due to the rockchip

Re: [Intel-gfx] [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails

2017-06-27 Thread Jeff Kirsher
On Wed, 2017-06-28 at 05:28 +1000, Dave Airlie wrote: > On 20 June 2017 at 18:49, Daniel Vetter wrote: > > On Wed, Jun 07, 2017 at 01:07:33AM +, Brown, Aaron F wrote: > > > > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] > > > > On Behalf > > > > Of Jeff Kirsher > > > > Sen

Re: [Intel-gfx] [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails

2017-06-27 Thread Dave Airlie
On 20 June 2017 at 18:49, Daniel Vetter wrote: > On Wed, Jun 07, 2017 at 01:07:33AM +, Brown, Aaron F wrote: >> > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf >> > Of Jeff Kirsher >> > Sent: Tuesday, June 6, 2017 1:46 PM >> > To: David Miller ; Nikula, Jani >> >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Drop flushing of the object free list/worker from i915_gem_suspend

2017-06-27 Thread Patchwork
== Series Details == Series: drm/i915: Drop flushing of the object free list/worker from i915_gem_suspend URL : https://patchwork.freedesktop.org/series/26449/ State : success == Summary == Series 26449v1 drm/i915: Drop flushing of the object free list/worker from i915_gem_suspend https://pa

Re: [Intel-gfx] [PATCH] drm/i915: Drop flushing of the object free list/worker from i915_gem_suspend

2017-06-27 Thread David Weinehall
On Tue, Jun 27, 2017 at 06:37:31PM +0100, Chris Wilson wrote: > i915_gem_suspend() is called from all of our finalization paths > (suspend, hibernate, unload). i915_gem_drain_freed_objects() adds an > arbitrary delay as it uses an rcu_barrier() to ensure that there are no > more freed objects in fl

[Intel-gfx] [PATCH] drm/i915: Drop flushing of the object free list/worker from i915_gem_suspend

2017-06-27 Thread Chris Wilson
i915_gem_suspend() is called from all of our finalization paths (suspend, hibernate, unload). i915_gem_drain_freed_objects() adds an arbitrary delay as it uses an rcu_barrier() to ensure that there are no more freed objects in flight, and this delay causes a large amount of variability in suspend t

[Intel-gfx] [PATCH 1/1] drm/i915: Hold RPM wakelock while initializing OA buffer

2017-06-27 Thread Sagar Arun Kamble
OA buffer initialization involves access to HW registers to set the OA base, head and tail. Ensure device is awake while setting these. With this, all oa.ops are covered under RPM and forcewake wakelock. Cc: Lionel Landwerlin Signed-off-by: Sagar Arun Kamble --- drivers/gpu/drm/i915/i915_perf.c

Re: [Intel-gfx] [PATCH 00/20] huge gtt pages

2017-06-27 Thread Chris Wilson
Quoting Matthew Auld (2017-06-27 15:54:24) > Next iteration based on feedback from Chris. > > Matthew Auld (20): > mm/shmem: introduce shmem_file_setup_with_mnt > drm/i915: introduce simple gemfs > drm/i915/gemfs: enable THP > drm/i915: introduce page_size_mask to dev_info > drm/i915: in

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Cancel pending execlists irq handler upon idling

2017-06-27 Thread Patchwork
== Series Details == Series: drm/i915: Cancel pending execlists irq handler upon idling URL : https://patchwork.freedesktop.org/series/26441/ State : success == Summary == Series 26441v1 drm/i915: Cancel pending execlists irq handler upon idling https://patchwork.freedesktop.org/api/1.0/series

Re: [Intel-gfx] [PATCH 13/13] drm/atomic-helper: Realign function parameters

2017-06-27 Thread Harry Wentland
On 2017-06-27 10:59 AM, Daniel Vetter wrote: > Too jarring. > > Fixes: f869a6ecf254 ("drm/atomic: Add target_vblank support in atomic helpers > (v2)") > Cc: Andrey Grodzovsky > Cc: Alex Deucher > Signed-off-by: Daniel Vetter Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/drm_at

[Intel-gfx] ✓ Fi.CI.BAT: success for fbdev locking rework and deferred setup, take 2

2017-06-27 Thread Patchwork
== Series Details == Series: fbdev locking rework and deferred setup, take 2 URL : https://patchwork.freedesktop.org/series/26437/ State : success == Summary == Series 26437v1 fbdev locking rework and deferred setup, take 2 https://patchwork.freedesktop.org/api/1.0/series/26437/revisions/1/mbo

[Intel-gfx] [PATCH] drm/i915: Cancel pending execlists irq handler upon idling

2017-06-27 Thread Chris Wilson
Due to the slight asynchronicity in handling the execlists interrupts (i.e. we defer the work to a handler that may consume more than one interrupt event), when the engine is idle we may still have an irq tasklet queued (especially when it has been deferred to a ksoftirqd). At the beginning of the

[Intel-gfx] ✓ Fi.CI.BAT: success for huge gtt pages (rev3)

2017-06-27 Thread Patchwork
== Series Details == Series: huge gtt pages (rev3) URL : https://patchwork.freedesktop.org/series/25118/ State : success == Summary == Series 25118v3 huge gtt pages https://patchwork.freedesktop.org/api/1.0/series/25118/revisions/3/mbox/ Test gem_exec_flush: Subgroup basic-batch-kerne

Re: [Intel-gfx] [PATCH 13/13] drm/atomic-helper: Realign function parameters

2017-06-27 Thread Deucher, Alexander
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] > Sent: Tuesday, June 27, 2017 11:00 AM > To: DRI Development > Cc: Intel Graphics Development; Daniel Vetter; Grodzovsky, Andrey; > Deucher, Alexander; Daniel Vetter > Subject: [PATCH 13/13] drm/atomic-helper: Reali

Re: [Intel-gfx] [PATCH v2] drm/core: Fail atomic IOCTL with no CRTC state but with signaling.

2017-06-27 Thread Daniel Vetter
On Tue, Jun 27, 2017 at 04:29:44PM +0200, Maarten Lankhorst wrote: > Op 27-06-17 om 09:37 schreef Daniel Vetter: > > On Mon, Jun 26, 2017 at 03:44:07PM -0400, Harry Wentland wrote: > >> On 2017-06-20 01:57 PM, Andrey Grodzovsky wrote: > >>> Problem : While running IGT kms_atomic_transition test sui

[Intel-gfx] [PATCH 12/13] drm/hisilicon: Remove custom FB helper deferred setup

2017-06-27 Thread Daniel Vetter
From: Thierry Reding The FB helper core now supports deferred setup, so the driver's custom implementation can be removed. Cc: Xinliang Liu Cc: Rongrong Zou Cc: Xinwei Kong Cc: Chen Feng Reviewed-by: Daniel Vetter Signed-off-by: Thierry Reding Signed-off-by: Daniel Vetter --- drivers/gpu

[Intel-gfx] [PATCH 08/13] drm/fb-helper: Stop using mode_config.mutex for internals

2017-06-27 Thread Daniel Vetter
Those are now all protected using fb_helper->lock. v2: We still need to hold mode_config.mutex right around calling connector->fill_modes. v3: I forgot to hold mode_config.mutex while looking at connector->status and the mode list. Also, we need to patch up the i915 ->initial_config callback to g

[Intel-gfx] [PATCH 13/13] drm/atomic-helper: Realign function parameters

2017-06-27 Thread Daniel Vetter
Too jarring. Fixes: f869a6ecf254 ("drm/atomic: Add target_vblank support in atomic helpers (v2)") Cc: Andrey Grodzovsky Cc: Alex Deucher Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_atomic_helper.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff

[Intel-gfx] [PATCH 11/13] drm/exynos: Remove custom FB helper deferred setup

2017-06-27 Thread Daniel Vetter
From: Thierry Reding The FB helper core now supports deferred setup, so the driver's custom implementation can be removed. v2: Drop NULL check, drm_fb_helper_hotplug_event handles that already. Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Signed-off-by: Thierry Reding

[Intel-gfx] [PATCH 09/13] drm/fb-helper: Split dpms handling into legacy and atomic paths

2017-06-27 Thread Daniel Vetter
Like with panning and modesetting, and like with those, stick with simple drm_modeset_locking_all for the legacy path, and the full atomic dance for atomic drivers. This means a bit more boilerplate since setting up the atomic state machinery is rather verbose, but then this is shared code for 30+

[Intel-gfx] [PATCH 07/13] drm/fb-helper: Push locking into restore_fbdev_mode_atomic|legacy

2017-06-27 Thread Daniel Vetter
Same game as with the panning function, use drm_modeset_lock_all for legacy paths, and a proper acquire ctx w/w mutex dance for atomic. Cc: John Stultz Cc: Thierry Reding Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_fb_helper.c | 48 + 1 file cha

[Intel-gfx] [PATCH 10/13] drm/fb-helper: Support deferred setup

2017-06-27 Thread Daniel Vetter
FB helper code falls back to a 1024x768 mode if no outputs are connected or don't report back any modes upon initialization. This can be annoying because outputs that are added to FB helper later on can't be used with FB helper if they don't support a matching mode. The fallback is in place becaus

[Intel-gfx] [PATCH 05/13] drm/fb-helper: Drop locking from the vsync wait ioctl code

2017-06-27 Thread Daniel Vetter
Like with the drm-native vblank wait ioctl we can entirely rely on the spinlocks in drm_vblank.c, no need at all to take expensive mutexes. The only reason we had to take mode_config.mutex was to protect the fbdev helper's data-structures, but that's now done by fb_helper->lock. Cc: John Stultz C

[Intel-gfx] [PATCH 06/13] drm/fb-helper: Push locking into pan_display_atomic|legacy

2017-06-27 Thread Daniel Vetter
For the legacy path we'll keep drm_modeset_lock_all, for the atomic one we drop the use of the magic implicit context and wire it up properly. Cc: John Stultz Cc: Thierry Reding Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_fb_helper.c | 28 ++-- 1 file changed,

[Intel-gfx] [PATCH 03/13] drm/fb-helper: Add top-level lock

2017-06-27 Thread Daniel Vetter
From: Thierry Reding Introduce a new top-level lock for the FB helper code. This will allow better locking granularity and avoid the need to abuse modeset locking for this purpose instead. This patch just adds the new lock everywhere we currently grab mode_config->mutex (explicitly, or through d

[Intel-gfx] [PATCH 02/13] drm/i915: Drop FBDEV #ifdev in mst code

2017-06-27 Thread Daniel Vetter
Since commit a03fdcb1863297481a4b817c2a759cafcbdfa0ae Author: Archit Taneja Date: Wed Aug 5 12:28:57 2015 +0530 drm: Add top level Kconfig option for DRM fbdev emulation this is properly handled using dummy functions. This essentially undoes commit 7296c849bf2eca2bd7d34a4686a53e3089150ac

[Intel-gfx] [PATCH 04/13] drm/fb-helper: Push locking in fb_is_bound

2017-06-27 Thread Daniel Vetter
That function only needs to take the individual crtc locks, not all the kms locks. Push down the locking and then minimize it. Cc: John Stultz Cc: Thierry Reding Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_fb_helper.c | 24 +--- 1 file changed, 9 insertions(+), 15

[Intel-gfx] [PATCH 01/13] drm/fb-helper: Push down modeset lock into FB helpers

2017-06-27 Thread Daniel Vetter
From: Thierry Reding Move the modeset locking from drivers into FB helpers. v2: Also handle intel_connector_add_to_fbdev. Tested-by: John Stultz Signed-off-by: Thierry Reding (v1) Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_fb_helper.c| 40 +-

[Intel-gfx] [PATCH 00/13] fbdev locking rework and deferred setup, take 2

2017-06-27 Thread Daniel Vetter
Hi all, Thanks to Liviu's help I realized that I fumbled the locking rework completely. This one here should be better, but somehow I'm having a real bad day today and I spent all day typing shit code, and then making it worse. This here seems to work at first glance, but please test and review c

[Intel-gfx] [PATCH 16/20] drm/i915/selftests: huge page tests

2017-06-27 Thread Matthew Auld
v2: mock test page support configurations and add MI_STORE_DWORD test Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c| 1 + drivers/gpu/drm/i915/selftests/huge_pages.c| 886 + .../gpu/drm/i91

[Intel-gfx] [PATCH 18/20] drm/i915: enable platform support for 64K pages

2017-06-27 Thread Matthew Auld
For gen9+ enable platform level support for 64K pages. Also enable for mock testing. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_pci.c | 3 ++- drivers/gpu/drm/i915/selftests/mock_gem_device.c | 3 ++- 2 files changed, 4 inser

[Intel-gfx] [PATCH 19/20] drm/i915: enable platform support for 2M pages

2017-06-27 Thread Matthew Auld
For gen8+ platforms which support the 48b PPGTT, enable platform level support for 2M pages. Also enable for mock testing. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_pci.c | 6 -- drivers/gpu/drm/i915/selftests/mock_gem_d

[Intel-gfx] [PATCH 15/20] drm/i915/debugfs: include some gtt page size metrics

2017-06-27 Thread Matthew Auld
Good to know, mostly for debugging purposes. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_debugfs.c | 42 + 1 file changed, 38 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c

[Intel-gfx] [PATCH 11/20] drm/i915: support 1G pages for the 48b PPGTT

2017-06-27 Thread Matthew Auld
Support inserting 1G gtt pages into the 48b PPGTT. v2: sanity check sg->length against page_size Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_gtt.c | 73 +++-- drivers/gpu/drm/i915/i915_gem_gtt.h | 2 + 2 f

[Intel-gfx] [PATCH 20/20] drm/i915: enable platform support for 1G pages

2017-06-27 Thread Matthew Auld
For gen8+ enable platforms which support the 48b PPGTT, enable support for 1G pages. Also enable for mock testing. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_pci.c | 6 -- drivers/gpu/drm/i915/selftests/mock_gem_device.c

[Intel-gfx] [PATCH 14/20] drm/i915: accurate page size tracking for the ppgtt

2017-06-27 Thread Matthew Auld
Now that we support multiple page sizes for the ppgtt, it would be useful to track the real usage for debugging purposes. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_gtt.c| 10 ++ drivers/gpu/drm/i915/i915_gem_object.h | 10 +++

[Intel-gfx] [PATCH 17/20] drm/i915/selftests: mix huge pages

2017-06-27 Thread Matthew Auld
Try to mix sg page sizes for 4K, 64K and 2M pages. v2: s/BIT(x) >> 12/BIT(x) >> PAGE_SHIFT/ Suggested-by: Chris Wilson Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/selftests/scatterlist.c | 15 +++ 1 file changed, 15 insertions(+) dif

[Intel-gfx] [PATCH 13/20] drm/i915: support 64K pages for the 48b PPGTT

2017-06-27 Thread Matthew Auld
Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_gtt.c | 26 ++ drivers/gpu/drm/i915/i915_gem_gtt.h | 1 + 2 files changed, 27 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_

[Intel-gfx] [PATCH 06/20] drm/i915: introduce vm set_pages/clear_pages

2017-06-27 Thread Matthew Auld
Move the setting/clearing of the vma->pages to a vm operation. Doing so neatens things up a little, but more importantly gives us a sane place to also set/clear the vma->pages_sizes, which we introduce later in preparation for supporting huge-pages. Suggested-by: Chris Wilson Signed-off-by: Matth

[Intel-gfx] [PATCH 02/20] drm/i915: introduce simple gemfs

2017-06-27 Thread Matthew Auld
Not a fully blown gemfs, just our very own tmpfs kernel mount. Doing so moves us away from the shmemfs shm_mnt, and gives us the much needed flexibility to do things like set our own mount options, namely huge= which should allow us to enable the use of transparent-huge-pages for our shmem backed o

[Intel-gfx] [PATCH 01/20] mm/shmem: introduce shmem_file_setup_with_mnt

2017-06-27 Thread Matthew Auld
We are planning to use our own tmpfs mnt in i915 in place of the shm_mnt, such that we can control the mount options, in particular huge=, which we require to support huge-gtt-pages. So rather than roll our own version of __shmem_file_setup, it would be preferred if we could just give shmem our mnt

[Intel-gfx] [PATCH 03/20] drm/i915/gemfs: enable THP

2017-06-27 Thread Matthew Auld
Enable transparent-huge-pages through gemfs by mounting with huge=within_size. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_gemfs.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gemfs.c b/driver

[Intel-gfx] [PATCH 05/20] drm/i915: introduce page_size members

2017-06-27 Thread Matthew Auld
In preparation for supporting huge gtt pages for the ppgtt, we introduce page size members for gem objects. We fill in the page sizes by scanning the sg table. v2: pass the sg_mask to set_pages v3: calculate the sg_mask inline with populating the sg_table where possible, and pass to set_pages al

[Intel-gfx] [PATCH 12/20] drm/i915: support 2M pages for the 48b PPGTT

2017-06-27 Thread Matthew Auld
Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_gtt.c | 8 drivers/gpu/drm/i915/i915_gem_gtt.h | 2 ++ 2 files changed, 10 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index 861

[Intel-gfx] [PATCH 10/20] drm/i915: disable GTT cache for 2M/1G pages

2017-06-27 Thread Matthew Auld
When SW enables the use of 2M/1G pages, it must disable the GTT cache. v2: don't disable for Cherryview which doesn't even support 48b PPGTT! v3: explicitly check that the system does support 2M/1G pages Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i91

[Intel-gfx] [PATCH 08/20] drm/i915: align 64K objects to 2M

2017-06-27 Thread Matthew Auld
We can't mix 64K and 4K pte's in the same page-table, so for now we align 64K objects to 2M to avoid any potential mixing. This is potentially wasteful but in reality shouldn't be too bad since this only applies to the virtual address space of a 48b PPGTT. v2: don't separate logically connected op

[Intel-gfx] [PATCH 07/20] drm/i915: align the vma start to the largest gtt page size

2017-06-27 Thread Matthew Auld
For the 48b PPGTT try to align the vma start address to the required page size boundary to guarantee we use said page size in the gtt. If we are dealing with multiple page sizes, we can't guarantee anything and just align to the largest. For soft pinning and objects which need to be tightly packed

[Intel-gfx] [PATCH 09/20] drm/i915: enable IPS bit for 64K pages

2017-06-27 Thread Matthew Auld
Before we can enable 64K pages through the IPS bit, we must first enable it through MMIO, otherwise the page-walker will simply ignore it. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 11 +++ drivers/gpu/drm/i915/i915_reg.h | 3

[Intel-gfx] [PATCH 04/20] drm/i915: introduce page_size_mask to dev_info

2017-06-27 Thread Matthew Auld
In preparation for huge gtt pages expose a page_size_mask as part of the device info, to indicate the page sizes supported by the HW. Currently only 4K is supported. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Mika Kuoppala Cc: Chris Wilson Reviewed-by: Joonas Lahtinen --- drivers/g

[Intel-gfx] [PATCH 00/20] huge gtt pages

2017-06-27 Thread Matthew Auld
Next iteration based on feedback from Chris. Matthew Auld (20): mm/shmem: introduce shmem_file_setup_with_mnt drm/i915: introduce simple gemfs drm/i915/gemfs: enable THP drm/i915: introduce page_size_mask to dev_info drm/i915: introduce page_size members drm/i915: introduce vm set_page

Re: [Intel-gfx] [PATCH v2] drm/core: Fail atomic IOCTL with no CRTC state but with signaling.

2017-06-27 Thread Maarten Lankhorst
Op 27-06-17 om 09:37 schreef Daniel Vetter: > On Mon, Jun 26, 2017 at 03:44:07PM -0400, Harry Wentland wrote: >> On 2017-06-20 01:57 PM, Andrey Grodzovsky wrote: >>> Problem : While running IGT kms_atomic_transition test suite i encountered >>> a hang in drmHandleEvent immediately following an ato

Re: [Intel-gfx] [RFC i-g-t] igt: Test tagging support

2017-06-27 Thread Tvrtko Ursulin
On 27/06/2017 14:18, Daniel Vetter wrote: On Tue, Jun 27, 2017 at 12:59:33PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Proposal to add test tags as a replacement for separate test list which can be difficult to maintain and get out of date. Putting this maintanenace inline with tests

Re: [Intel-gfx] [PATCH] drm/i915: Fix an error checking test

2017-06-27 Thread Chris Wilson
Quoting Christophe JAILLET (2017-06-27 06:38:54) > 'dma_buf_vmap' returns NULL on error, not an error pointer. > > Fixes: 6cca22ede8a4 ("drm/i915: Add some mock tests for dmabuf interop") > Signed-off-by: Christophe JAILLET Thanks for the fix, reviewed and pushed. -Chris

Re: [Intel-gfx] [PATCH] drm/i915: Print pwm device-name when using pwm for backlight control

2017-06-27 Thread Hans de Goede
Hi, On 06/27/2017 11:52 AM, Ville Syrjälä wrote: On Fri, Jun 23, 2017 at 09:42:44AM +0200, Hans de Goede wrote: On Bay Trail devices either the Crystal Cove PMIC's pwm or the LPSS' pwm is used to control the backlight. Other drivers take core of providing a backlight_pwm alias through pwm_add_t

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Fix mutex imbalance for igt_render_engine_reset_fallback

2017-06-27 Thread Chris Wilson
Quoting Patchwork (2017-06-23 14:39:08) > == Series Details == > > Series: drm/i915/selftests: Fix mutex imbalance for > igt_render_engine_reset_fallback > URL : https://patchwork.freedesktop.org/series/26288/ > State : success > > == Summary == > > Series 26288v1 drm/i915/selftests: Fix mute

Re: [Intel-gfx] [PATCH v12 3/3] drm/i915: Add option to support dynamic backlight via DPCD

2017-06-27 Thread David Weinehall
On Mon, Jun 26, 2017 at 05:18:19PM +0300, David Weinehall wrote: > On Thu, Jun 22, 2017 at 12:03:39PM -0700, Puthikorn Voravootivat wrote: > > This patch adds option to enable dynamic backlight for eDP > > panel that supports this feature via DPCD register and > > set minimum / maximum brightness t

Re: [Intel-gfx] [PATCH] drm/i915: Disable MSI for all pre-gen5

2017-06-27 Thread Chris Wilson
Quoting ville.syrj...@linux.intel.com (2017-06-26 21:30:51) > From: Ville Syrjälä > > We have pretty clear evidence that MSIs are getting lost on g4x and > somehow the interrupt logic doesn't seem to recover from that state > even if we try hard to clear the IIR. > > Disabling IER around the nor

Re: [Intel-gfx] [RFC i-g-t] igt: Test tagging support

2017-06-27 Thread Daniel Vetter
On Tue, Jun 27, 2017 at 12:59:33PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Proposal to add test tags as a replacement for separate test > list which can be difficult to maintain and get out of date. > > Putting this maintanenace inline with tests makes it easier > to remember to

Re: [Intel-gfx] [PATCH] drm/i915: Disable MSI for all pre-gen5

2017-06-27 Thread Ville Syrjälä
On Tue, Jun 27, 2017 at 11:18:33AM +0200, Daniel Vetter wrote: > On Mon, Jun 26, 2017 at 11:30:51PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > We have pretty clear evidence that MSIs are getting lost on g4x and > > somehow the interrupt logic doesn't seem to recov

Re: [Intel-gfx] [RFC i-g-t 0/4] Redundant test pruning

2017-06-27 Thread Daniel Vetter
On Tue, Jun 27, 2017 at 12:46:28PM +0100, Chris Wilson wrote: > Quoting Daniel Vetter (2017-06-27 10:14:40) > > On Tue, Jun 27, 2017 at 09:02:02AM +0100, Tvrtko Ursulin wrote: > > > > > > On 26/06/2017 17:09, Daniel Vetter wrote: > > > > On Fri, Jun 23, 2017 at 12:31:39PM +0100, Tvrtko Ursulin wro

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Disable MSI for all pre-gen5

2017-06-27 Thread Ville Syrjälä
On Mon, Jun 26, 2017 at 08:49:56PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Disable MSI for all pre-gen5 > URL : https://patchwork.freedesktop.org/series/26392/ > State : failure > > == Summary == > > Series 26392v1 drm/i915: Disable MSI for all pre-gen5 > https://p

Re: [Intel-gfx] [RESEND-CI v4 11/15] drm/i915: prepare scaler for YCBCR420 modeset

2017-06-27 Thread Ander Conselvan De Oliveira
On Wed, 2017-06-21 at 16:04 +0530, Shashank Sharma wrote: > To get a YCBCR420 output from intel platforms, we need one > scaler to scale down YCBCR444 samples to YCBCR420 samples. > > This patch: > - Does scaler allocation for HDMI ycbcr420 outputs. > - Programs PIPE_MISC register for ycbcr420 out

Re: [Intel-gfx] [PATCH v5 7/7] drm: create hdmi output property

2017-06-27 Thread Ville Syrjälä
On Wed, Jun 21, 2017 at 04:04:13PM +0530, Shashank Sharma wrote: > HDMI displays can support various output types, based on > the color space and subsampling type. The possible > outputs from a HDMI 2.0 monitor could be: > - RGB > - YCBCR 444 > - YCBCR 422 > - YCBCR 420 > > This patch adds a d

Re: [Intel-gfx] [PATCH] drm/atomic-helper: Simplify commit tracking locking

2017-06-27 Thread Daniel Vetter
On Wed, Jun 21, 2017 at 10:30:51AM -0400, Sean Paul wrote: > On Wed, Jun 21, 2017 at 11:16:27AM +0200, Daniel Vetter wrote: > > The crtc->commit_lock only protects commit_list and commit_entry. If > > we chase the pointer from the drm_atomic_state update structure, then > > we don't need any locks

Re: [Intel-gfx] [PATCH v4 0/5] HPD support during suspend for BXT/APL.

2017-06-27 Thread David Weinehall
On Mon, Jun 12, 2017 at 08:54:02PM +0530, Animesh Manna wrote: > Along with below patches sharing some background details/design. > - On BXT, Display cannot generate an interrupt when in D3. > - Without display in D3, S0ix can be achieved, Power impact will be zero if > d3 is blocked. PMCSR for Gr

[Intel-gfx] [RFC i-g-t] igt: Test tagging support

2017-06-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Proposal to add test tags as a replacement for separate test list which can be difficult to maintain and get out of date. Putting this maintanenace inline with tests makes it easier to remember to update the, now implicit, lists, and also enables richer test selection possib

Re: [Intel-gfx] [RESEND-CI v4 06/15] drm/edid: parse sink information before CEA blocks

2017-06-27 Thread Ville Syrjälä
On Wed, Jun 21, 2017 at 04:04:04PM +0530, Shashank Sharma wrote: > CEA-861-F adds ycbcr capability map block, for HDMI 2.0 sinks. > This block contains a map of indexes of CEA modes, which can > support YCBCR 420 output also. To avoid multiple parsing of same > CEA block, let's parse the sink infor

Re: [Intel-gfx] [RESEND-CI v4 05/15] drm/edid: parse ycbcr 420 deep color information

2017-06-27 Thread Ville Syrjälä
On Wed, Jun 21, 2017 at 04:04:03PM +0530, Shashank Sharma wrote: > CEA-861-F spec adds ycbcr420 deep color support information > in hf-vsdb block. This patch extends the existing hf-vsdb parsing > function by adding parsing of ycbcr420 deep color support from the > EDID and adding it into display i

Re: [Intel-gfx] [RESEND-CI v4 04/15] drm/edid: parse YCBCR 420 videomodes from EDID

2017-06-27 Thread Ville Syrjälä
On Wed, Jun 21, 2017 at 04:04:02PM +0530, Shashank Sharma wrote: > HDMI 2.0 spec adds support for YCBCR420 sub-sampled output. > CEA-861-F adds two new blocks in EDID's CEA extension blocks, > to provide information about sink's YCBCR420 output capabilities. > > These blocks are: > > - YCBCR420vd

Re: [Intel-gfx] [RFC i-g-t 0/4] Redundant test pruning

2017-06-27 Thread Chris Wilson
Quoting Daniel Vetter (2017-06-27 10:14:40) > On Tue, Jun 27, 2017 at 09:02:02AM +0100, Tvrtko Ursulin wrote: > > > > On 26/06/2017 17:09, Daniel Vetter wrote: > > > On Fri, Jun 23, 2017 at 12:31:39PM +0100, Tvrtko Ursulin wrote: > > > > From: Tvrtko Ursulin > > > > > > > > Small series which sa

Re: [Intel-gfx] [RESEND-CI v4 03/15] drm/edid: Complete CEA modedb(VIC 1-107)

2017-06-27 Thread Ville Syrjälä
On Wed, Jun 21, 2017 at 04:04:01PM +0530, Shashank Sharma wrote: > CEA-861-F specs defines new video modes to be used with > HDMI 2.0 EDIDs. The VIC range has been extended from 1-64 to > 1-107. > > Our existing CEA modedb contains only 64 modes (VIC=1 to VIC=64). Now > to be able to parse new CEA

[Intel-gfx] [PATCH i-g-t v2 5/7] tests/chamelium: Update connector state without reprobe when possible

2017-06-27 Thread Paul Kocialkowski
This renames the reprobe_connector function to update_connector and ensures that full reprobe of the connector is only done when really necessary (e.g. when changing the EDID). A full reprobe takes time and is not required for updating the connector state. Thus, this allows executing tests faster.

[Intel-gfx] [PATCH i-g-t v2 3/7] tests/chamelium: Add VGA HPD toggle tests after suspend and hibernate

2017-06-27 Thread Paul Kocialkowski
This adds HPD toggle after suspend and hibernate testing for VGA, in the same fashion as currently done for DP and HDMI and includes VGA in the common suspend and hibernate test. Signed-off-by: Paul Kocialkowski --- tests/chamelium.c | 22 +- 1 file changed, 9 insertions(+),

[Intel-gfx] [PATCH i-g-t v2 7/7] Make igtrc configuration common, with configurable suspend/resume delay

2017-06-27 Thread Paul Kocialkowski
This adds support for configurable suspend/resume delay and takes the occasion to move igtrc configuation from igt_chamelium to igt_core. This way, suspend/resume delay configuration can be used for all tests. Signed-off-by: Paul Kocialkowski --- lib/Makefile.am | 2 ++ lib/igt_aux.c

[Intel-gfx] [PATCH i-g-t v2 6/7] tests/chamelium: Disconnect connectors without extra reset

2017-06-27 Thread Paul Kocialkowski
This removes the reset call from the reset_state function and renames it to disconnect_connector. Since a call to reset is already done in chamelium_init, there is no need to do an extra reset in each test. This allows reducing the execution time a bit. Signed-off-by: Paul Kocialkowski --- test

[Intel-gfx] [PATCH i-g-t v2 4/7] tests/chamelium: Reduce the simple hotplug test toggle count for VGA

2017-06-27 Thread Paul Kocialkowski
Since VGA hpd detection is done through RGB lines load detection and nowadays often goes through a bridge to some digital interface, HPD detection usually takes a while (up to a couple seconds). Thus, it is not as relevant to stress it as many as 15 times. This brings the toggle count down to 5 ti

[Intel-gfx] [PATCH i-g-t v2 2/7] chamelium: Add support for HPD toggle scheduling instead of async pulses

2017-06-27 Thread Paul Kocialkowski
This adds support for the newly-introduced ScheduleHpdToggle XMLRPC method of the Chamelium's interface and makes use of it instead of starting pulses with an asynchronous call, suspending and dealing with the result at resume. The XMLRPC library does not guarantee that the call will be made befor

[Intel-gfx] [PATCH i-g-t v2 1/7] lib/igt_aux: Use provided autoresume delay for rtc wake

2017-06-27 Thread Paul Kocialkowski
This stores the autoresume delay provided via igt_set_autoresume_delay for use during suspend via rtc wake scheduling. This delay was previously only used for pm_test suspendm while the function suggests it should be applied to all autoresume cases. There is also definitely a use case for configur

Re: [Intel-gfx] [PATCH i-g-t 4/7] lib/igt_chamelium: Add support for configurable DUT suspend/resume delay

2017-06-27 Thread Paul Kocialkowski
On Tue, 2017-06-27 at 10:45 +0300, Paul Kocialkowski wrote: > On Tue, 2017-06-27 at 10:33 +0300, Paul Kocialkowski wrote: > > On Mon, 2017-06-26 at 18:15 +0300, Martin Peres wrote: > > > On 26/06/17 17:33, Paul Kocialkowski wrote: > > > > On Mon, 2017-06-26 at 17:25 +0300, Martin Peres wrote: > > >

Re: [Intel-gfx] [RESEND 1/2] drm/i915/dp: Fix the t11_t12 panel power cycle delay from VBT read

2017-06-27 Thread Ville Syrjälä
On Mon, Jun 26, 2017 at 12:21:44PM -0700, Manasi Navare wrote: > When we read the VBT t11_t12 value for panel power cycle delay, > it is a zero based value so we need to 100ms to that. And then it > needs to be multiplied by 10 to store it in 100usecs unit same as > SW VBT. > > v3: > * Add it as p

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix an error checking test

2017-06-27 Thread Patchwork
== Series Details == Series: drm/i915: Fix an error checking test URL : https://patchwork.freedesktop.org/series/26422/ State : success == Summary == Series 26422v1 drm/i915: Fix an error checking test https://patchwork.freedesktop.org/api/1.0/series/26422/revisions/1/mbox/ Test gem_exec_flus

Re: [Intel-gfx] [PATCH] drm/i915: Print pwm device-name when using pwm for backlight control

2017-06-27 Thread Ville Syrjälä
On Fri, Jun 23, 2017 at 09:42:44AM +0200, Hans de Goede wrote: > On Bay Trail devices either the Crystal Cove PMIC's pwm or the LPSS' > pwm is used to control the backlight. Other drivers take core of > providing a backlight_pwm alias through pwm_add_table, but it is > still useful to know which pw

Re: [Intel-gfx] [PATCH][drm-next] drm/i915: fix spelling mistake: "CouarPoint" -> "CougarPoint"

2017-06-27 Thread Daniel Vetter
On Tue, Jun 27, 2017 at 08:30:09AM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in DRM_DEBUG_KMS message > > Signed-off-by: Colin Ian King I have this already queued for 4.14, from Ville. I'll show up in linux-next after 4.13-rc1. Thanks anyway. -Daniel

[Intel-gfx] [PATCH] drm/i915: Fix an error checking test

2017-06-27 Thread Christophe JAILLET
'dma_buf_vmap' returns NULL on error, not an error pointer. Fixes: 6cca22ede8a4 ("drm/i915: Add some mock tests for dmabuf interop") Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/i915/selftests/i915_gem_dmabuf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dr

Re: [Intel-gfx] [PATCH] drm/i915: Disable MSI for all pre-gen5

2017-06-27 Thread Daniel Vetter
On Mon, Jun 26, 2017 at 11:30:51PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > We have pretty clear evidence that MSIs are getting lost on g4x and > somehow the interrupt logic doesn't seem to recover from that state > even if we try hard to clear the IIR. > > Disabling

Re: [Intel-gfx] [RFC i-g-t 0/4] Redundant test pruning

2017-06-27 Thread Daniel Vetter
On Tue, Jun 27, 2017 at 09:02:02AM +0100, Tvrtko Ursulin wrote: > > On 26/06/2017 17:09, Daniel Vetter wrote: > > On Fri, Jun 23, 2017 at 12:31:39PM +0100, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > Small series which saves test execution time by removing the redundant > > > t

[Intel-gfx] [PULL] drm-intel-next-fixes

2017-06-27 Thread Daniel Vetter
Hi Dave, drm-intel-next-fixes-2017-06-27: Just three minor fixups for stuff in -next. Aside: Backmerge of -rc7 or 4.12 final into drm-next might be good, the cherry-pick conflicts in i915 are getting a bit much fun. Cheers, Daniel The following changes since commit 047b8e21e3bfa9faa4ed9a0c337f

[Intel-gfx] [PULL] drm-intel-fixes

2017-06-27 Thread Daniel Vetter
Hi Dave, A bit earlier than usual since you're going on vacations. Nothing scary at all. drm-intel-fixes-2017-06-27: Just a few minor fixes. Important one is the execbuf async fix (aka ANDROID_native_sync). There was another patch for a display coherency corner case on APL, but we've random-walke

Re: [Intel-gfx] [RFC i-g-t 0/4] Redundant test pruning

2017-06-27 Thread Tvrtko Ursulin
On 26/06/2017 17:09, Daniel Vetter wrote: On Fri, Jun 23, 2017 at 12:31:39PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Small series which saves test execution time by removing the redundant tests. Tvrtko Ursulin (4): igt: Remove default from the engine list gem_exec_basic: Exer

  1   2   >