[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add HP Convertible 360 to OpRegion quirk list

== Series Details == Series: drm/i915: Add HP Convertible 360 to OpRegion quirk list URL : https://patchwork.freedesktop.org/series/28411/ State : success == Summary == Series 28411v1 drm/i915: Add HP Convertible 360 to OpRegion quirk list

[Intel-gfx] [PATCH] drm/i915: Add HP Convertible 360 to OpRegion quirk list

The quirklist for OpRegion panel type got introduced in commit c8ebfad7a063 ("drm/i915: Ignore OpRegion panel type except on select machines"). Adding the entry for HP Convertible 360 to the white list. Fixes: a05628195a0d ("drm/i915: Get panel_type from OpRegion panel details") Bugzilla:

Re: [Intel-gfx] [PATCH 07/15] drm/i915/guc: Create a GuC receive function

On 8/4/2017 9:27 AM, Michal Wajdeczko wrote: From: Oscar Mateo This function, symmetrical to the send(), will handle Guc2Host message interrupts (which at the moment still only covers requests to flush the GuC logs). Cc: Michal Wajdeczko Cc:

Re: [Intel-gfx] [PATCH 01/15] drm/i915/guc: Add support for data reporting in GuC responses

On Fri, Aug 04, 2017 at 02:29:33PM -0700, Daniele Ceraolo Spurio wrote: > > > On 04/08/17 13:40, Michel Thierry wrote: > > On 8/4/2017 9:26 AM, Michal Wajdeczko wrote: > > > GuC may return additional data in the command status response. > > > Format and meaning of this data is action specific. >

Re: [Intel-gfx] [PATCH 04/15] drm/i915/guc: Implement response handling in send_mmio()

On 8/4/2017 9:27 AM, Michal Wajdeczko wrote: In addition to already returned small data encoded in the status MMIO, GuC may write more additional data in remaining MMIO regs. Lets copy all that regs into optionally provided response buffer. Signed-off-by: Michal Wajdeczko

Re: [Intel-gfx] [PATCH 03/15] drm/i915/guc: Add send_and_receive() helper function

On 8/4/2017 9:27 AM, Michal Wajdeczko wrote: In the previous patch we have changed signature of the send function pointer but we didn't modify signature of the corresponding helper function to minimize number of required changes. Let's add separate helper to expose new functionality but still

Re: [Intel-gfx] [PATCH 01/15] drm/i915/guc: Add support for data reporting in GuC responses

On 04/08/17 13:40, Michel Thierry wrote: On 8/4/2017 9:26 AM, Michal Wajdeczko wrote: GuC may return additional data in the command status response. Format and meaning of this data is action specific. We will use this non-negative data as a new success return value. Signed-off-by: Michal

Re: [Intel-gfx] [PATCH 02/15] drm/i915/guc: Prepare send() function to accept bigger response

On 8/4/2017 9:26 AM, Michal Wajdeczko wrote: This is a preparation step for the upcoming patches. We already can return some small data decoded from the command status, but we will need more in the future. Signed-off-by: Michal Wajdeczko Cc: Oscar Mateo

Re: [Intel-gfx] [PATCH 01/15] drm/i915/guc: Add support for data reporting in GuC responses

On 8/4/2017 9:26 AM, Michal Wajdeczko wrote: GuC may return additional data in the command status response. Format and meaning of this data is action specific. We will use this non-negative data as a new success return value. Signed-off-by: Michal Wajdeczko Cc:

Re: [Intel-gfx] [PATCH 05/15] drm/i915/guc: Move Guc notification handling to separate function

On Fri, Aug 04, 2017 at 07:00:33PM +0100, Chris Wilson wrote: > Quoting Michal Wajdeczko (2017-08-04 17:27:02) > > To allow future code reuse. While here, fix comment style. > > Might as well fix the alignment as well then... > > > + /* Handle flush interrupt in bottom half */ > >

Re: [Intel-gfx] [PATCH 12/15] drm/i915/guc: Prepare to process incoming requests from CT

On Fri, Aug 04, 2017 at 06:13:42PM +0100, Chris Wilson wrote: > Quoting Michal Wajdeczko (2017-08-04 17:27:09) > > static inline const char *guc_ct_buffer_type_to_str(u32 type) > > @@ -600,13 +609,76 @@ static int guc_handle_response(struct intel_guc *guc, > > const u32 *data) > > static int

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s

Em Sex, 2017-08-04 às 09:47 +, Lofstedt, Marta escreveu: > +Paolo > > > -Original Message- > > From: Lofstedt, Marta > > Sent: Wednesday, June 28, 2017 2:17 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Latvala, Petri ; Lofstedt, Marta > >

Re: [Intel-gfx] [PATCH v4 2/4] drm/i915/psr: Account for sink CRC raciness on some panels

On Thu, 2017-08-03 at 11:07 -0700, Rodrigo Vivi wrote: > On Tue, Jul 18, 2017 at 2:34 PM, Jim Bride wrote: > > According to the eDP spec, when the count field in TEST_SINK_MISC > > increments then the six bytes of sink CRC information in the DPCD > > should be valid.

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: convert macros to functions

Em Sex, 2017-08-04 às 18:21 +0200, Daniel Vetter escreveu: > I guess this was done to have a better indication of which testcase > and function failed, but igt nowadays dumps an entire stacktrace. But we may have multiple do_assertions() calls in a single function. > And > macros of this

Re: [Intel-gfx] [PATCH 15/15] drm/i915/guc: Trace messages from CT while in debug

Quoting Michal Wajdeczko (2017-08-04 17:27:12) > During debug we may want to investigate all communication > from the Guc. Add proper tracing macros in debug config. > > Signed-off-by: Michal Wajdeczko > --- > drivers/gpu/drm/i915/intel_guc_ct.c | 19

[Intel-gfx] [PATCH i-g-t] tests/kms: increase max threshold time for edid read

From: Clint Taylor Current 50ms max threshold timing for an EDID read is very close to the actual time for a 2 block HDMI EDID read of 48ms. Any delay like a clock stretch by the EDID eeprom will cause this test to fail. A 4 block HDMI EDID read takes approximately

Re: [Intel-gfx] [PATCH 05/15] drm/i915/guc: Move Guc notification handling to separate function

Quoting Michal Wajdeczko (2017-08-04 17:27:02) > To allow future code reuse. While here, fix comment style. Might as well fix the alignment as well then... > + /* Handle flush interrupt in bottom half */ > + queue_work(dev_priv->guc.log.runtime.flush_wq, > +

Re: [Intel-gfx] [PATCH 12/15] drm/i915/guc: Prepare to process incoming requests from CT

Quoting Michal Wajdeczko (2017-08-04 17:27:09) > static inline const char *guc_ct_buffer_type_to_str(u32 type) > @@ -600,13 +609,76 @@ static int guc_handle_response(struct intel_guc *guc, > const u32 *data) > static int guc_handle_request(struct intel_guc *guc, const u32 *data) > { >

Re: [Intel-gfx] [PATCH i-g-t] lib: don't hang on blt on snb

Quoting Daniel Vetter (2017-08-04 17:07:22) > We now have full (or a lot at least) igt running in beta CI, and snb > blt hangs are really unhappy: > > - drv_hangman@error-state-capture-blt and gem_exec_capture@capture-blt > reliably result in insta-machine death when we try to reset the gpu, >

Re: [Intel-gfx] [PATCH igt] tests/kms_ccs: Don't overallocate CCS surface

Reviewed-by: Jason Ekstrand On Fri, Aug 4, 2017 at 9:37 AM, Daniel Stone wrote: > Due to a mix-up in kernel branches being used, I'd mangled Jason's > original CCS test to hopelessly overallocate the CCS surface size. > Restore it back to its

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/guc: Support for Guc responses and requests

== Series Details == Series: drm/i915/guc: Support for Guc responses and requests URL : https://patchwork.freedesktop.org/series/28393/ State : warning == Summary == Series 28393v1 drm/i915/guc: Support for Guc responses and requests

[Intel-gfx] [PATCH igt] tests/kms_ccs: Don't overallocate CCS surface

Due to a mix-up in kernel branches being used, I'd mangled Jason's original CCS test to hopelessly overallocate the CCS surface size. Restore it back to its original. Signed-off-by: Daniel Stone Cc: Jason Ekstrand --- tests/kms_ccs.c | 2 +- 1 file

Re: [Intel-gfx] [PATCH i-g-t] tests/perf: follow up build fix

On 4 August 2017 at 17:23, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin > Fixes: adcde8ac ("tests/perf: fix build where system headers don't have Gen8 > formats") Tested-by: Matthew Auld

[Intel-gfx] [PATCH 02/15] drm/i915/guc: Prepare send() function to accept bigger response

This is a preparation step for the upcoming patches. We already can return some small data decoded from the command status, but we will need more in the future. Signed-off-by: Michal Wajdeczko Cc: Oscar Mateo Cc: Michel Thierry

[Intel-gfx] [PATCH 15/15] drm/i915/guc: Trace messages from CT while in debug

During debug we may want to investigate all communication from the Guc. Add proper tracing macros in debug config. Signed-off-by: Michal Wajdeczko --- drivers/gpu/drm/i915/intel_guc_ct.c | 19 +++ 1 file changed, 19 insertions(+) diff --git

[Intel-gfx] [PATCH 12/15] drm/i915/guc: Prepare to process incoming requests from CT

Requests are read from CT in the irq handler, but actual processing will be done in the work thread. Processing of specific actions will be added in the upcoming patches. Signed-off-by: Michal Wajdeczko Cc: Oscar Mateo Cc: Michel Thierry

[Intel-gfx] [PATCH 13/15] drm/i915/guc: Handle default action received over CT

With enabled CT, instead of programming SCRATCH 15 register with the Guc to host message, Guc will send us CT request. Content of the data[1] of this message follows format of the data in scratch register. Signed-off-by: Michal Wajdeczko Cc: Oscar Mateo

[Intel-gfx] [PATCH 14/15] drm/i915/guc: Enable GuC interrupts when using CT

We will need them in G2H communication to properly handle responses and requests from the Guc. Signed-off-by: Michal Wajdeczko Cc: Oscar Mateo Cc: Daniele Ceraolo Spurio Cc: Michel Thierry

[Intel-gfx] [PATCH 06/15] drm/i915/guc: Move flushing the GuC logs outside notification handler

From: Oscar Mateo To allow future code reuse. Cc: Sagar Arun Kamble Cc: Daniele Ceraolo Spurio Signed-off-by: Oscar Mateo Signed-off-by: Michal Wajdeczko ---

[Intel-gfx] [PATCH 11/15] drm/i915/guc: Implement response handling in send_ct()

GuC may return not only small data encoded in the status dword, but can also append additional data into the response message. We will copy this extra data into provided buffer, and use number of received data dwords as new success return value. Signed-off-by: Michal Wajdeczko

[Intel-gfx] [PATCH 09/15] drm/i915/guc: Prepare to handle messages from CT RECV buffer

GuC can respond to our commands not only by updating SEND buffer descriptor, but can send us message over RECV buffer. Additionally Guc can also send us unsolicited requests over RECV buffer. Lets start reading those messages and make placeholders for actual response/request handlers.

[Intel-gfx] [PATCH 05/15] drm/i915/guc: Move Guc notification handling to separate function

To allow future code reuse. While here, fix comment style. Suggested-by: Oscar Mateo Signed-off-by: Michal Wajdeczko Cc: Oscar Mateo Cc: Sagar Arun Kamble Cc: Daniele Ceraolo Spurio

[Intel-gfx] [PATCH 04/15] drm/i915/guc: Implement response handling in send_mmio()

In addition to already returned small data encoded in the status MMIO, GuC may write more additional data in remaining MMIO regs. Lets copy all that regs into optionally provided response buffer. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio

[Intel-gfx] [PATCH 10/15] drm/i915/guc: Use better name for helper wait function

In next patch we will introduce another way of waiting for the response that will use RECV buffer. To avoid mismatched names, rename old wait function to reflect the fact that it is based on descriptor update. Signed-off-by: Michal Wajdeczko ---

[Intel-gfx] [PATCH 07/15] drm/i915/guc: Create a GuC receive function

From: Oscar Mateo This function, symmetrical to the send(), will handle Guc2Host message interrupts (which at the moment still only covers requests to flush the GuC logs). Cc: Michal Wajdeczko Cc: Daniele Ceraolo Spurio

[Intel-gfx] [PATCH 08/15] drm/i915/guc: Update CT message header definition

Flags bits are different in G2H message. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Oscar Mateo Cc: Kelvin Gardiner --- drivers/gpu/drm/i915/intel_guc_fwif.h |

[Intel-gfx] [PATCH 00/15] drm/i915/guc: Support for Guc responses and requests

With this series we will be able to receive more data from the Guc. New Guc firmware will be required to actually use that feature. Michal Wajdeczko (13): drm/i915/guc: Add support for data reporting in GuC responses drm/i915/guc: Prepare send() function to accept bigger response

[Intel-gfx] [PATCH 03/15] drm/i915/guc: Add send_and_receive() helper function

In the previous patch we have changed signature of the send function pointer but we didn't modify signature of the corresponding helper function to minimize number of required changes. Let's add separate helper to expose new functionality but still hide underlying details. Signed-off-by: Michal

[Intel-gfx] [PATCH 01/15] drm/i915/guc: Add support for data reporting in GuC responses

GuC may return additional data in the command status response. Format and meaning of this data is action specific. We will use this non-negative data as a new success return value. Signed-off-by: Michal Wajdeczko Cc: Oscar Mateo Cc: Michel

[Intel-gfx] [PATCH i-g-t] tests/perf: follow up build fix

Signed-off-by: Lionel Landwerlin Fixes: adcde8ac ("tests/perf: fix build where system headers don't have Gen8 formats") --- tests/perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/perf.c b/tests/perf.c index 9cfc4bb9..a7fa33a1 100644

[Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: convert macros to functions

I guess this was done to have a better indication of which testcase and function failed, but igt nowadays dumps an entire stacktrace. And macros of this magnitude mean the line number is entirely meaningless, since it doesn't point at a specific check. Reason I've started to looking into this is

[Intel-gfx] [PATCH i-g-t] lib: don't hang on blt on snb

We now have full (or a lot at least) igt running in beta CI, and snb blt hangs are really unhappy: - drv_hangman@error-state-capture-blt and gem_exec_capture@capture-blt reliably result in insta-machine death when we try to reset the gpu, both on the CI snb and the one I have here. - Other

Re: [Intel-gfx] [PATCH] tests/kms_ccs: Fix the color/ccs surface generation

On Fri, Aug 4, 2017 at 8:42 AM, Daniel Stone wrote: > On 4 August 2017 at 15:56, Jason Ekstrand wrote: > > On August 4, 2017 2:59:56 AM Daniel Stone wrote: > >>> + width = ALIGN(f.width * 4, 32) / 32; > >>> +

Re: [Intel-gfx] [PATCH 00/11] constify i915 attribute_group structures.

On 04/08/17 11:39, Arvind Yadav wrote: On Friday 04 August 2017 04:04 PM, Lionel Landwerlin wrote: On 04/08/17 11:22, Arvind Yadav wrote: Hi Lionel, On Friday 04 August 2017 02:33 PM, Lionel Landwerlin wrote: Hi Arwind, These files were generated by a script maintained in this

Re: [Intel-gfx] [PATCH] tests/kms_ccs: Fix the color/ccs surface generation

On 4 August 2017 at 15:56, Jason Ekstrand wrote: > On August 4, 2017 2:59:56 AM Daniel Stone wrote: >>> + width = ALIGN(f.width * 4, 32) / 32; >>> + height = ALIGN(f.height, 16) / 16; >>> + f.pitches[1] =

[Intel-gfx] [PATCH v4 i-g-t] tests/perf: fix build where system headers don't have Gen8 formats

v2: Use previous enum to define the new Gen8 enums (Petri) v3: Duh! (Lionel) v4: Redefine MAX oa formats value (Daniel) Signed-off-by: Lionel Landwerlin --- tests/perf.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git

[Intel-gfx] [PATCH v3 i-g-t] tests/perf: fix build where system headers don't have Gen8 formats

v2: Use previous enum to define the new Gen8 enums (Petri) v3: Duh! (Lionel) Signed-off-by: Lionel Landwerlin --- tests/perf.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index f0ec26dd..54eb3605

Re: [Intel-gfx] [PATCH] tests/kms_ccs: Fix the color/ccs surface generation

On August 4, 2017 2:59:56 AM Daniel Stone wrote: Hi Jason, On 4 August 2017 at 01:52, Jason Ekstrand wrote: Previously, the test used the old 64x64 convention that Ville introduced for CCS tiles and not the current 128x32 Y-tile convention. Also,

Re: [Intel-gfx] [PATCH v2 i-g-t] tests/perf: fix build where system headers don't have Gen8 formats

On 4 August 2017 at 15:00, Lionel Landwerlin wrote: > v2: Use previous enum to define the new Gen8 enums (Petri) > > Signed-off-by: Lionel Landwerlin Tested-by: Daniel Stone

[Intel-gfx] [PATCH i-g-t] tests/core_auth: set rlimit

Some distros have huge rlimits and then the test takes forever, or worse oom, or even worse, takse down the entire machine (which is shouldn't be able to, but oh well, oom handling in linux). Make sure we have a consistent rlimit by adjusting it manually. v2: Use the default of 1024 from

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: remove unused function declaration

== Series Details == Series: drm/i915: remove unused function declaration URL : https://patchwork.freedesktop.org/series/28381/ State : success == Summary == Series 28381v1 drm/i915: remove unused function declaration https://patchwork.freedesktop.org/api/1.0/series/28381/revisions/1/mbox/

[Intel-gfx] [PATCH i-g-t] lib/igt_chamelium: Remove any special handling for the connector FSM

No specific treatment should be required for handling the connector FSM, since the chamelium-side daemon will automatically send an HPD event to reset the source. The event is sufficient to make the receiver on the chamelium consider the input as stable after it. On the other hand, toggling DPMS

Re: [Intel-gfx] [PATCH igt] tests/kms_properties: Don't set immutable properties

On 4 August 2017 at 14:38, Daniel Stone wrote: > If the kernel tells us it's immutable, trying to set it probably isn't > going to succeed. > > Fixes a failure seen with the IN_FORMATS property. Pushed a v2 which removed most of the list with Daniel Vetter's R-b from IRC.

[Intel-gfx] [PATCH] drm/i915: remove unused function declaration

This function is not part of the driver anymore. Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/intel_lrc.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_lrc.h b/drivers/gpu/drm/i915/intel_lrc.h index

[Intel-gfx] [PATCH v2 i-g-t] tests/perf: fix build where system headers don't have Gen8 formats

v2: Use previous enum to define the new Gen8 enums (Petri) Signed-off-by: Lionel Landwerlin --- tests/perf.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index f0ec26dd..23f7f1af 100644 ---

[Intel-gfx] [PATCH igt] tests/kms_properties: Don't set immutable properties

If the kernel tells us it's immutable, trying to set it probably isn't going to succeed. Fixes a failure seen with the IN_FORMATS property. Signed-off-by: Daniel Stone Cc: Daniel Vetter Cc: Ben Widawsky ---

Re: [Intel-gfx] [PATCH i-g-t 03/11] tests/perf: update max buffer size for reading reports

On 04/08/17 12:41, Chris Wilson wrote: Quoting Lionel Landwerlin (2017-08-04 12:20:32) Signed-off-by: Lionel Landwerlin --- tests/perf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index

Re: [Intel-gfx] [PATCH i-g-t] tests/perf: fix build where system headers don't have Gen8 formats

On Fri, Aug 04, 2017 at 02:21:36PM +0100, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin > --- > tests/perf.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/tests/perf.c b/tests/perf.c > index

[Intel-gfx] [PATCH i-g-t] tests/perf: fix build where system headers don't have Gen8 formats

Signed-off-by: Lionel Landwerlin --- tests/perf.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index f0ec26dd..aa6358d3 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -143,6 +143,13 @@ enum

[Intel-gfx] [PATCH libdrm] headers: update drm_i915.h

Generated at the following commit from drm-next : commit dd24df657075fdf1e850612ea50634816f3c3581 Merge: 12f8030e05c6 799c7b20b260 Author: Dave Airlie Date: Wed Aug 2 12:43:12 2017 +1000 Merge branch 'drm-next-4.14' of git://people.freedesktop.org/~agd5f/linux into

Re: [Intel-gfx] [PATCH i-g-t 06/11] tests/perf: make enable-disable more reliable

On 04/08/17 12:44, Chris Wilson wrote: Quoting Lionel Landwerlin (2017-08-04 12:20:35) Estimation of the amount of reports can only refer to periodic ones, as context switch reports completely depend on what happens on the system. Also generate some load to prevent clock frequency changes to

Re: [Intel-gfx] [intel-gfx][i-g-t][help]can't read the backlight

On Wed, 26 Jul 2017, "Gu, HailinX" wrote: > Hi~ all, > I try to run the test pm_backlight. But there is an skip with the log as > following. > > > > > > IGT-Version: 1.19-g4258cc8e (x86_64) (Linux: 4.10.0 x86_64) Test > > requirement not met in function __real_main154,

Re: [Intel-gfx] [PATCH] drm/i915: fix backlight invert for non-zero minimum brightness

On Wed, 31 May 2017, Daniel Vetter wrote: > On Wed, May 31, 2017 at 11:33:55AM +0300, Jani Nikula wrote: >> When we started following the backlight minimum brightness in >> 6dda730e55f4 ("drm/i915: respect the VBT minimum backlight brightness") >> we overlooked the brightness

Re: [Intel-gfx] New " Unclaimed read from register 0x1f0034" in 4.12-rc1

On Thu, 18 May 2017, Hans de Goede wrote: > Ok, so after rebuilding everything I get more sensible results, > the "RPM wakelock ref not held during HW access" error now is > the same one as I reported before in the > "New "RPM wakelock ref not held during HW access" in

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/perf: Initialise the dynamic sysfs attr

Quoting Patchwork (2017-08-03 23:57:29) > == Series Details == > > Series: drm/i915/perf: Initialise the dynamic sysfs attr > URL : https://patchwork.freedesktop.org/series/28340/ > State : warning > > == Summary == > > Series 28340v1 drm/i915/perf: Initialise the dynamic sysfs attr >

Re: [Intel-gfx] [PATCH] drm/i915/shrinker: Wrap need_resched() inside preempt-disable

Quoting Joonas Lahtinen (2017-08-04 12:52:51) > On pe, 2017-08-04 at 11:41 +0100, Chris Wilson wrote: > > In order for us to successfully detect the end of a timeslice, > > preemption must be disabled. Otherwise, inside the loop we may be > > preempted many times without our noticing, and each

Re: [Intel-gfx] [PATCH i-g-t] kms_busy: Fix basic-modeset-* name format parameters

Reviewed-by: Marta Lofstedt > -Original Message- > From: Lofstedt, Marta > Sent: Friday, August 4, 2017 3:05 PM > To: 'Petri Latvala' ; intel-gfx@lists.freedesktop.org > Cc: Daniel Vetter > Subject: RE:

Re: [Intel-gfx] [PATCH i-g-t] kms_busy: Fix basic-modeset-* name format parameters

Thanks Petri, now I can run testlists again! > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > Of Petri Latvala > Sent: Friday, August 4, 2017 2:45 PM > To: intel-gfx@lists.freedesktop.org > Cc: Daniel Vetter >

Re: [Intel-gfx] [PATCH i-g-t 00/11] Improve robustness of the i915 perf tests

On Fri, Aug 04, 2017 at 12:20:29PM +0100, Lionel Landwerlin wrote: > Hi all, > > This is a resend of a series that was posted a few months ago. I've > pushed all the patches that has a Rb. This is a shorter list but > pretty important to make the tests more stable. perf.c:233:3: error:

Re: [Intel-gfx] [PATCH] drm/i915/shrinker: Wrap need_resched() inside preempt-disable

On pe, 2017-08-04 at 11:41 +0100, Chris Wilson wrote: > In order for us to successfully detect the end of a timeslice, > preemption must be disabled. Otherwise, inside the loop we may be > preempted many times without our noticing, and each time our timeslice > will be reset, invalidating

Re: [Intel-gfx] [PATCH i-g-t 09/11] tests/perf: remove unused frequency functions

Quoting Lionel Landwerlin (2017-08-04 12:20:38) > Now that we've found that frequency changes happen mostly outside of > our control and don't seem to be following our requests through sysfs, > let's drop a bunch code/variables. Pardon? -Chris ___

[Intel-gfx] [PATCH i-g-t] kms_busy: Fix basic-modeset-* name format parameters

Commit 37b06eb9b526df6c23ec75f7a9ecd9547fa76695 limited the used engines to only the default engine, dropping the engine name from subtest names, but left over the format parameter. Fixes: 37b06eb9b526 ("tests/kms_busy: Only test against one engine") Signed-off-by: Petri Latvala

Re: [Intel-gfx] [PATCH i-g-t 06/11] tests/perf: make enable-disable more reliable

Quoting Lionel Landwerlin (2017-08-04 12:20:35) > Estimation of the amount of reports can only refer to periodic ones, > as context switch reports completely depend on what happens on the > system. Also generate some load to prevent clock frequency changes to > impact our measurement. If clock

Re: [Intel-gfx] [PATCH i-g-t 03/11] tests/perf: update max buffer size for reading reports

Quoting Lionel Landwerlin (2017-08-04 12:20:32) > Signed-off-by: Lionel Landwerlin > --- > tests/perf.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tests/perf.c b/tests/perf.c > index 279ff0c6..65a1606d 100644 > ---

Re: [Intel-gfx] [PATCH i-g-t 01/11] tests/perf: make stream_fd a global variable

Quoting Lionel Landwerlin (2017-08-04 12:20:30) > When debugging unstable tests on new platforms we currently we don't > cleanup everything well in between different tests. Since only a > single OA stream fd can be opened at a time, having the stream_fd as a > global variable helps us cleanup the

[Intel-gfx] [PATCH i-g-t 06/11] tests/perf: make enable-disable more reliable

Estimation of the amount of reports can only refer to periodic ones, as context switch reports completely depend on what happens on the system. Also generate some load to prevent clock frequency changes to impact our measurement. Signed-off-by: Lionel Landwerlin

[Intel-gfx] [PATCH i-g-t 00/11] Improve robustness of the i915 perf tests

Hi all, This is a resend of a series that was posted a few months ago. I've pushed all the patches that has a Rb. This is a shorter list but pretty important to make the tests more stable. Cheers, Lionel Landwerlin (10): tests/perf: make stream_fd a global variable tests/perf: update max

[Intel-gfx] [PATCH i-g-t 10/11] tests/perf: add Kabylake support

Signed-off-by: Lionel Landwerlin --- tests/perf.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/tests/perf.c b/tests/perf.c index f5949590..1e5a5b88 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -1102,8 +1102,23 @@

[Intel-gfx] [PATCH i-g-t 11/11] tests/perf: add Geminilake support

Signed-off-by: Lionel Landwerlin --- tests/perf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/perf.c b/tests/perf.c index 1e5a5b88..5b27925b 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -1115,6 +1115,9 @@ init_sys_info(void)

[Intel-gfx] [PATCH i-g-t 07/11] tests/perf: make buffer-fill more reliable

Filling rate of the buffer must discard context switch reports as they do not depend upon the periodicity, instead they're a factor on the amount of different applications concurrently running on the system. Signed-off-by: Lionel Landwerlin --- tests/perf.c | 121

[Intel-gfx] [PATCH i-g-t 09/11] tests/perf: remove unused frequency functions

Now that we've found that frequency changes happen mostly outside of our control and don't seem to be following our requests through sysfs, let's drop a bunch code/variables. Signed-off-by: Lionel Landwerlin --- tests/perf.c | 83

[Intel-gfx] [PATCH i-g-t 08/11] tests/perf: load gt_boost_freq_mhz as max gt frequency

We want the absolute max the hardware can do, not the max value set by a previous application/user. Signed-off-by: Lionel Landwerlin --- tests/perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/perf.c b/tests/perf.c index

[Intel-gfx] [PATCH i-g-t 02/11] tests/perf: add per context filtering test for gen8+

From: Robert Bragg Signed-off-by: Robert Bragg Signed-off-by: Lionel Landwerlin --- tests/perf.c | 806 --- 1 file changed, 768 insertions(+), 38 deletions(-)

[Intel-gfx] [PATCH i-g-t 03/11] tests/perf: update max buffer size for reading reports

Signed-off-by: Lionel Landwerlin --- tests/perf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index 279ff0c6..65a1606d 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -1271,9 +1271,7 @@

[Intel-gfx] [PATCH i-g-t 05/11] tests/perf: rework oa-exponent test

New issues that were discovered while making the tests work on Gen8+ : - we need to measure timings between periodic reports and discard all other kind of reports - it seems periodicity of the reports can be affected outside of RC6 (frequency change), we can detect this by looking at the

[Intel-gfx] [PATCH i-g-t 01/11] tests/perf: make stream_fd a global variable

When debugging unstable tests on new platforms we currently we don't cleanup everything well in between different tests. Since only a single OA stream fd can be opened at a time, having the stream_fd as a global variable helps us cleanup the state between tests. Signed-off-by: Lionel Landwerlin

[Intel-gfx] [PATCH i-g-t 04/11] tests/perf: rc6: try to guess when rc6 is disabled

Signed-off-by: Lionel Landwerlin --- tests/perf.c | 13 + 1 file changed, 13 insertions(+) diff --git a/tests/perf.c b/tests/perf.c index 65a1606d..7f9bc66d 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -3453,6 +3453,17 @@

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/shrinker: Wrap need_resched() inside preempt-disable

== Series Details == Series: drm/i915/shrinker: Wrap need_resched() inside preempt-disable URL : https://patchwork.freedesktop.org/series/28371/ State : failure == Summary == Series 28371v1 drm/i915/shrinker: Wrap need_resched() inside preempt-disable

[Intel-gfx] [PATCH] drm/i915/shrinker: Wrap need_resched() inside preempt-disable

In order for us to successfully detect the end of a timeslice, preemption must be disabled. Otherwise, inside the loop we may be preempted many times without our noticing, and each time our timeslice will be reset, invalidating need_resched() Reported-by: Joonas Lahtinen

Re: [Intel-gfx] [PATCH 00/11] constify i915 attribute_group structures.

On Friday 04 August 2017 04:04 PM, Lionel Landwerlin wrote: On 04/08/17 11:22, Arvind Yadav wrote: Hi Lionel, On Friday 04 August 2017 02:33 PM, Lionel Landwerlin wrote: Hi Arwind, These files were generated by a script maintained in this repository :

Re: [Intel-gfx] [PATCH 00/11] constify i915 attribute_group structures.

On 04/08/17 11:22, Arvind Yadav wrote: Hi Lionel, On Friday 04 August 2017 02:33 PM, Lionel Landwerlin wrote: Hi Arwind, These files were generated by a script maintained in this repository : https://github.com/rib/gputop/blob/master/scripts/i915-perf-kernelgen.py It would best to update

[Intel-gfx] [PATCH] drm/i915: add register macro definition style guide

This is not to try to force a new style; this is my interpretation of what the most common existing style is. With hopes I don't need to answer so many questions about style going forward. Cc: Daniel Vetter Signed-off-by: Jani Nikula --- N.b.

Re: [Intel-gfx] [PATCH 00/11] constify i915 attribute_group structures.

Hi Lionel, On Friday 04 August 2017 02:33 PM, Lionel Landwerlin wrote: Hi Arwind, These files were generated by a script maintained in this repository : https://github.com/rib/gputop/blob/master/scripts/i915-perf-kernelgen.py It would best to update this script first to make sure future

Re: [Intel-gfx] [PATCH i-g-t] configure.ac: Try to find XMLRPC with xmlrpc-c-config if pkg-config fails

On Fri, Aug 04, 2017 at 12:15:18PM +0300, Arkadiusz Hiler wrote: > On Thu, Aug 03, 2017 at 07:35:33PM +0200, Daniel Vetter wrote: > > On Thu, Aug 03, 2017 at 04:34:45PM +0300, Petri Latvala wrote: > > > Debian and Ubuntu have XMLRPC packages without pkg-config files. Let's > > > do automatically

Re: [Intel-gfx] [PATCH] tests/kms_ccs: Fix the color/ccs surface generation

Hi Jason, On 4 August 2017 at 01:52, Jason Ekstrand wrote: > Previously, the test used the old 64x64 convention that Ville introduced > for CCS tiles and not the current 128x32 Y-tile convention. Also, the > original scheme for generating the CCS data was over-complicated

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s

+Paolo > -Original Message- > From: Lofstedt, Marta > Sent: Wednesday, June 28, 2017 2:17 PM > To: intel-gfx@lists.freedesktop.org > Cc: Latvala, Petri ; Lofstedt, Marta > > Subject: [PATCH i-g-t] tests/kms_frontbuffer_tracking: increase

[Intel-gfx] [PATCH i-g-t] intel-ci: Also remove extended.testlist from EXTRA_DIST

Fixes: 848fc49e22c6 ("tests: delete extended.testlist") Signed-off-by: Petri Latvala --- tests/intel-ci/Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/intel-ci/Makefile.am b/tests/intel-ci/Makefile.am index 9fb9744..d74e7ec 100644 ---

Re: [Intel-gfx] [PATCH 6/6] [v4] drm/i915: Add support for CCS modifiers

On 3 August 2017 at 18:21, Ben Widawsky wrote: > On 17-08-03 12:00:56, Daniel Stone wrote: >> if (pipe >= PIPE_C || plane >= PLANE_SPRITE1) >> >> cf. skl_check_ccs_aux_surface() which rejects CCS on anything other >> than PRIMARY/SPRITE0. >> >> I'll squash when pushing. > >

Re: [Intel-gfx] [PATCH 3/4] drm: Only lastclose on unload for legacy drivers

On Fri, Aug 4, 2017 at 6:12 AM, Michel Dänzer wrote: > On 03/08/17 10:54 PM, Daniel Vetter wrote: >> On Thu, Aug 3, 2017 at 1:17 AM, Daniel Vetter wrote: >>> On Wed, Aug 2, 2017 at 10:50 PM, Alex Deucher wrote: On Wed, Aug

Re: [Intel-gfx] [PATCH i-g-t] configure.ac: Try to find XMLRPC with xmlrpc-c-config if pkg-config fails

On Thu, Aug 03, 2017 at 07:35:33PM +0200, Daniel Vetter wrote: > On Thu, Aug 03, 2017 at 04:34:45PM +0300, Petri Latvala wrote: > > Debian and Ubuntu have XMLRPC packages without pkg-config files. Let's > > do automatically what the user would anyway do manually. > > > > Signed-off-by: Petri

  1   2   >