[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/cnl: Get RC6 working. (rev2)

2017-10-23 Thread Patchwork
== Series Details == Series: drm/i915/cnl: Get RC6 working. (rev2) URL : https://patchwork.freedesktop.org/series/32491/ State : success == Summary == Test drv_module_reload: Subgroup basic-reload-inject: dmesg-warn -> PASS (shard-hsw) fdo#102707 +1 Test perf:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/cnl: Get RC6 working. (rev2)

2017-10-23 Thread Patchwork
== Series Details == Series: drm/i915/cnl: Get RC6 working. (rev2) URL : https://patchwork.freedesktop.org/series/32491/ State : success == Summary == Series 32491v2 drm/i915/cnl: Get RC6 working. https://patchwork.freedesktop.org/api/1.0/series/32491/revisions/2/mbox/ fi-bdw-5557u

Re: [Intel-gfx] [Mesa-dev] [PATCH] i965: Revert absolute mode for constant buffer pointers.

2017-10-23 Thread Kenneth Graunke
On Monday, October 23, 2017 3:53:15 PM PDT Rodrigo Vivi wrote: > On Mon, Oct 23, 2017 at 10:32:43PM +, Jordan Justen wrote: > > On 2017-10-19 16:30:44, Kristian Høgsberg wrote: > > > On Thu, Oct 19, 2017 at 4:18 PM, Kenneth Graunke > > > wrote: > > > > The kernel

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915: Bump wait-times for the final CS interrupt before parking

2017-10-23 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Bump wait-times for the final CS interrupt before parking URL : https://patchwork.freedesktop.org/series/32493/ State : success == Summary == Test perf: Subgroup polling: fail -> PASS

Re: [Intel-gfx] [PATCH v3 12/14] drm/i915/guc: Preemption! With GuC

2017-10-23 Thread Daniele Ceraolo Spurio
+ +#define GUC_PREEMPT_FINISHED 0x1 +#define GUC_PREEMPT_BREADCRUMB_DWORDS 0x8 +static void inject_preempt_context(struct work_struct *work) +{ + struct guc_preempt_work *preempt_work = + container_of(work, typeof(*preempt_work), work); + struct intel_engine_cs

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/cnl: Get RC6 working. (rev2)

2017-10-23 Thread Patchwork
== Series Details == Series: drm/i915/cnl: Get RC6 working. (rev2) URL : https://patchwork.freedesktop.org/series/32491/ State : failure == Summary == Series 32491v2 drm/i915/cnl: Get RC6 working. https://patchwork.freedesktop.org/api/1.0/series/32491/revisions/2/mbox/ Test gem_exec_reloc:

Re: [Intel-gfx] [Mesa-dev] [PATCH] i965: Revert absolute mode for constant buffer pointers.

2017-10-23 Thread Rodrigo Vivi
On Mon, Oct 23, 2017 at 10:32:43PM +, Jordan Justen wrote: > On 2017-10-19 16:30:44, Kristian Høgsberg wrote: > > On Thu, Oct 19, 2017 at 4:18 PM, Kenneth Graunke > > wrote: > > > The kernel doesn't initialize the value of the INSTPM or CS_DEBUG_MODE2 > > > registers

[Intel-gfx] [PATCH] drm/i915/cnl: Get RC6 working.

2017-10-23 Thread Rodrigo Vivi
On CNL, individual wake rate limit was added to each engine. GT can only go to RC6 if both Render and Media engines are individually qualified. So we need to set their individual wake rate limit. +-+---+--+--+ | |GT RC6

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/cnl: Get RC6 working.

2017-10-23 Thread Patchwork
== Series Details == Series: drm/i915/cnl: Get RC6 working. URL : https://patchwork.freedesktop.org/series/32491/ State : success == Summary == Test drv_module_reload: Subgroup basic-no-display: pass -> DMESG-WARN (shard-hsw) fdo#102707 +1 Test perf:

Re: [Intel-gfx] [Mesa-dev] [PATCH] i965: Revert absolute mode for constant buffer pointers.

2017-10-23 Thread Jordan Justen
On 2017-10-19 16:30:44, Kristian Høgsberg wrote: > On Thu, Oct 19, 2017 at 4:18 PM, Kenneth Graunke > wrote: > > The kernel doesn't initialize the value of the INSTPM or CS_DEBUG_MODE2 > > registers at context initialization time. Instead, they're inherited > > from

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Get RC6 working.

2017-10-23 Thread James Ausmus
On Mon, Oct 23, 2017 at 02:20:01PM -0700, Rodrigo Vivi wrote: > On CNL, individual ware rate limit was added to each engine. s/ware/wake/ > > GT can only go to RC6 if both Render and Media engines are > idividually qualified. So we need to set their individual s/idividually/individually/ > wake

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Bump wait-times for the final CS interrupt before parking

2017-10-23 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Bump wait-times for the final CS interrupt before parking URL : https://patchwork.freedesktop.org/series/32493/ State : success == Summary == Series 32493v1 series starting with [1/4] drm/i915: Bump wait-times for the final

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/cnl: Get RC6 working.

2017-10-23 Thread Patchwork
== Series Details == Series: drm/i915/cnl: Get RC6 working. URL : https://patchwork.freedesktop.org/series/32491/ State : success == Summary == Series 32491v1 drm/i915/cnl: Get RC6 working. https://patchwork.freedesktop.org/api/1.0/series/32491/revisions/1/mbox/ Test chamelium:

[Intel-gfx] [PATCH 1/4] drm/i915: Bump wait-times for the final CS interrupt before parking

2017-10-23 Thread Chris Wilson
In the idle worker we drop the prolonged GT wakeref used to cover such essentials as interrupt delivery. (When a CS interrupt arrives, we also assert that the GT is awake.) However, it turns out that 10ms is not long enough to be assured that the last CS interrupt has been delivered, so bump that

[Intel-gfx] [PATCH 3/4] drm/i915: Filter out spurious execlists context-switch interrupts

2017-10-23 Thread Chris Wilson
Back in commit a4b2b01523a8 ("drm/i915: Don't mark an execlists context-switch when idle") we noticed the presence of late context-switch interrupts. We were able to filter those out by looking at whether the ELSP remained active, but in commit beecec901790 ("drm/i915/execlists: Preemption!") that

[Intel-gfx] [PATCH 2/4] drm/i915: Synchronize irq before parking each engine

2017-10-23 Thread Chris Wilson
When we park the engine (upon idling), we kill the irq tasklet. However, to be sure that it is not restarted by a final interrupt after doing so, flush the interrupt handler before parking. As we only park the engines when we believe the system is idle, there should not be any spurious interrupts

[Intel-gfx] [PATCH 4/4] warn

2017-10-23 Thread Chris Wilson
--- drivers/gpu/drm/i915/i915_irq.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index f8205841868b..e4bd20ce031d 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -1391,6 +1391,9 @@

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Synchronize irq before parking each engine

2017-10-23 Thread Patchwork
== Series Details == Series: drm/i915: Synchronize irq before parking each engine URL : https://patchwork.freedesktop.org/series/32490/ State : failure == Summary == Series 32490 revision 1 was fully merged or fully failed: no git log ___ Intel-gfx

[Intel-gfx] [PATCH] drm/i915/cnl: Get RC6 working.

2017-10-23 Thread Rodrigo Vivi
On CNL, individual ware rate limit was added to each engine. GT can only go to RC6 if both Render and Media engines are idividually qualified. So we need to set their individual wake rate limit. +-+---+--+--+ | |GT RC6 |

[Intel-gfx] [PATCH] drm/i915: Synchronize irq before parking each engine

2017-10-23 Thread Chris Wilson
When we park the engine (upon idling), we kill the irq tasklet. However, to be sure that it is not restarted by a final interrupt after doing so, flush the interrupt handler before parking. As we only park the engines when we believe the system is idle, there should not be any spurious interrupts

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Filter out spurious execlists context-switch interrupts

2017-10-23 Thread Chris Wilson
Quoting Chris Wilson (2017-10-23 21:06:16) > Back in commit a4b2b01523a8 ("drm/i915: Don't mark an execlists > context-switch when idle") we noticed the presence of late > context-switch interrupts. We were able to filter those out by looking > at whether the ELSP remained active, but in commit

Re: [Intel-gfx] [PATCH v7 3/4] drm/i915/guc : Updating GuC and HuC FW select function

2017-10-23 Thread Sujaritha
On 10/18/2017 02:17 PM, Michal Wajdeczko wrote: On Wed, 18 Oct 2017 12:29:13 +0200, Sagar Arun Kamble wrote: On 10/18/2017 4:20 AM, Sujaritha Sundaresan wrote: Updating GuC and HuC firmware select function to support removing i915_modparams.enable_guc_loading

Re: [Intel-gfx] [PATCH v7 3/4] drm/i915/guc : Updating GuC and HuC FW select function

2017-10-23 Thread Sujaritha
On 10/18/2017 03:29 AM, Sagar Arun Kamble wrote: On 10/18/2017 4:20 AM, Sujaritha Sundaresan wrote: Updating GuC and HuC firmware select function to support removing i915_modparams.enable_guc_loading module parameter. v2: Clarifying the commit message (Anusha) v3: Unify seq_puts messages,

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: Bump wait-times for the final CS interrupt before parking

2017-10-23 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Bump wait-times for the final CS interrupt before parking URL : https://patchwork.freedesktop.org/series/32486/ State : warning == Summary == Series 32486v1 series starting with [1/2] drm/i915: Bump wait-times for the final

[Intel-gfx] [PATCH 2/2] drm/i915: Filter out spurious execlists context-switch interrupts

2017-10-23 Thread Chris Wilson
Back in commit a4b2b01523a8 ("drm/i915: Don't mark an execlists context-switch when idle") we noticed the presence of late context-switch interrupts. We were able to filter those out by looking at whether the ELSP remained active, but in commit beecec901790 ("drm/i915/execlists: Preemption!") that

[Intel-gfx] [PATCH 1/2] drm/i915: Bump wait-times for the final CS interrupt before parking

2017-10-23 Thread Chris Wilson
In the idle worker we drop the prolonged GT wakeref used to cover such essentials as interrupt delivery. (When a CS interrupt arrives, we also assert that the GT is awake.) However, it turns out that 10ms is not long enough to be assured that the last CS interrupt has been delivered, so bump that

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/cnl: Force DDI_A_4_LANES when needed. (rev3)

2017-10-23 Thread Patchwork
== Series Details == Series: drm/i915/cnl: Force DDI_A_4_LANES when needed. (rev3) URL : https://patchwork.freedesktop.org/series/32398/ State : success == Summary == Test kms_plane: Subgroup plane-panning-bottom-right-suspend-pipe-B-planes: skip -> PASS

Re: [Intel-gfx] [PATCH v3 8/8] drm/i915: Adjust system agent voltage on CNL if required by DDI ports

2017-10-23 Thread Rodrigo Vivi
On Fri, Oct 20, 2017 at 05:05:40PM +, Ville Syrjala wrote: > From: Ville Syrjälä > > On CNL we may need to bump up the system agent voltage not only due > to CDCLK but also when driving DDI port with a sufficiently high clock. > To that end start tracking the

Re: [Intel-gfx] [PATCH 7/8] drm/i915: Use cdclk_state->voltage on CNL

2017-10-23 Thread Rodrigo Vivi
On Wed, Oct 18, 2017 at 08:48:24PM +, Ville Syrjala wrote: > From: Ville Syrjälä > > Track the system agent voltage we request from pcode in the cdclk state > on CNL. Annoyingly we can't actually read out the current value since > there's no pcode command to do

Re: [Intel-gfx] linux-firmware pull request (glk: DMC;cnl: DMC)

2017-10-23 Thread Anusha Srivatsa
On Mon, Oct 23, 2017 at 10:11:28AM -0700, Anusha Srivatsa wrote: +Kyle McMartin > Hi, > > Please consider pulling i915 updates to linux-firmware.git. > he following changes since commit bf04291309d3169c0ad3b8db52564235bbd08e30: > > WHENCE: Add new qed firmware (2017-10-09 18:03:26 +0100) >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/cnl: Force DDI_A_4_LANES when needed. (rev2)

2017-10-23 Thread Patchwork
== Series Details == Series: drm/i915/cnl: Force DDI_A_4_LANES when needed. (rev2) URL : https://patchwork.freedesktop.org/series/32398/ State : success == Summary == Test kms_flip: Subgroup flip-vs-wf_vblank-interruptible: pass -> FAIL (shard-hsw)

Re: [Intel-gfx] How To install?

2017-10-23 Thread Rodrigo Vivi
On Sat, Oct 21, 2017 at 02:27:11PM +, Rhyanz wrote: > How to install graphic card on kali linux with "00:02.0 VGA compatible > controller: Intel > Corporation 2nd Generation Core Processor Family Integrated Graphics > Controller (rev 09) > ". Could you please re-do it with nn to grab the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/cnl: Force DDI_A_4_LANES when needed. (rev3)

2017-10-23 Thread Patchwork
== Series Details == Series: drm/i915/cnl: Force DDI_A_4_LANES when needed. (rev3) URL : https://patchwork.freedesktop.org/series/32398/ State : success == Summary == Series 32398v3 drm/i915/cnl: Force DDI_A_4_LANES when needed.

Re: [Intel-gfx] [PATCH v7 2/4] drm/i915/guc : Removing i915_modparams.enable_guc_loading module parameter

2017-10-23 Thread Sujaritha
On 10/18/2017 04:53 AM, Michal Wajdeczko wrote: On Wed, 18 Oct 2017 00:50:47 +0200, Sujaritha Sundaresan wrote: We currently have two module parameters that control GuC: "enable_guc_loading" and "enable_guc_submission". Whenever we need

[Intel-gfx] [PATCH] drm/i915/cnl: Force DDI_A_4_LANES when needed.

2017-10-23 Thread Rodrigo Vivi
As we faced in BXT, on CNL DDI_A_4_LANES is not set as expected when system is boot with multiple monitors connected. This result in wrong lane setup impacting the max data rate available and consequently blocking modeset on eDP, resulting in a blank screen. Most of CNL SKUs don't support DDI-E.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/cnl: Force DDI_A_4_LANES when needed. (rev2)

2017-10-23 Thread Patchwork
== Series Details == Series: drm/i915/cnl: Force DDI_A_4_LANES when needed. (rev2) URL : https://patchwork.freedesktop.org/series/32398/ State : success == Summary == Series 32398v2 drm/i915/cnl: Force DDI_A_4_LANES when needed.

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Force DDI_A_4_LANES when needed.

2017-10-23 Thread Ville Syrjälä
On Mon, Oct 23, 2017 at 10:12:00AM -0700, Rodrigo Vivi wrote: > As we faced in BXT, on CNL DDI_A_4_LANES is not > set as expected when system is boot with multiple > monitors connected. This result in wrong lane > setup impacting the max data rate available and > consequently blocking modeset on

Re: [Intel-gfx] linux-firmware pull request (glk: DMC;cnl: DMC)

2017-10-23 Thread Rodrigo Vivi
On Mon, Oct 23, 2017 at 05:11:28PM +, Anusha Srivatsa wrote: > Hi, > > Please consider pulling i915 updates to linux-firmware.git. > he following changes since commit bf04291309d3169c0ad3b8db52564235bbd08e30: > > WHENCE: Add new qed firmware (2017-10-09 18:03:26 +0100) > > are available

Re: [Intel-gfx] [PATCH 2/8] drm/i915: Start tracking voltage level in the cdclk state

2017-10-23 Thread Rodrigo Vivi
On Mon, Oct 23, 2017 at 12:13:46PM +, Ville Syrjälä wrote: > On Fri, Oct 20, 2017 at 01:43:51PM -0700, Rodrigo Vivi wrote: > > On Fri, Oct 20, 2017 at 02:01:37PM +, Ville Syrjälä wrote: > > > On Wed, Oct 18, 2017 at 11:48:19PM +0300, Ville Syrjala wrote: > > > > From: Ville Syrjälä

[Intel-gfx] linux-firmware pull request (glk: DMC;cnl: DMC)

2017-10-23 Thread Anusha Srivatsa
Hi, Please consider pulling i915 updates to linux-firmware.git. he following changes since commit bf04291309d3169c0ad3b8db52564235bbd08e30: WHENCE: Add new qed firmware (2017-10-09 18:03:26 +0100) are available in the git repository at: https://github.com/anushasr/linux-firmware.git master

[Intel-gfx] [PATCH] drm/i915/cnl: Force DDI_A_4_LANES when needed.

2017-10-23 Thread Rodrigo Vivi
As we faced in BXT, on CNL DDI_A_4_LANES is not set as expected when system is boot with multiple monitors connected. This result in wrong lane setup impacting the max data rate available and consequently blocking modeset on eDP, resulting in a blank screen. Most of CNL SKUs don't support DDI-E.

Re: [Intel-gfx] [PATCH v7 2/4] drm/i915/guc : Removing i915_modparams.enable_guc_loading module parameter

2017-10-23 Thread Sujaritha
On 10/17/2017 03:57 PM, Chris Wilson wrote: Quoting Sujaritha Sundaresan (2017-10-17 23:50:47) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index dd141b2..5b9bdd0 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -3201,9

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Disable lazy PPGTT page table optimization for vGPU (rev2)

2017-10-23 Thread Patchwork
== Series Details == Series: drm/i915: Disable lazy PPGTT page table optimization for vGPU (rev2) URL : https://patchwork.freedesktop.org/series/32201/ State : success == Summary == Test kms_plane: Subgroup plane-panning-bottom-right-suspend-pipe-B-planes: skip

Re: [Intel-gfx] [PATCH] drm/i915/gvt: use ARRAY_SIZE

2017-10-23 Thread Zhi Wang
Thanks, applied! On 10/16/17 10:32, Jérémy Lefaure wrote: Using the ARRAY_SIZE macro improves the readability of the code. Also, it's useless to use a variable to store this constant calculated at compile time. Found with Coccinelle with the following semantic patch: @r depends on (org ||

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Clean up dead code in cmd_parser

2017-10-23 Thread Zhi Wang
Thanks, applied! :) On 10/16/17 06:32, Christos Gkekas wrote: Delete variables 'gma_bottom' that are set but never used. Signed-off-by: Christos Gkekas --- drivers/gpu/drm/i915/gvt/cmd_parser.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Plane assert/readout cleanups etc. (rev7)

2017-10-23 Thread Patchwork
== Series Details == Series: drm/i915: Plane assert/readout cleanups etc. (rev7) URL : https://patchwork.freedesktop.org/series/31758/ State : success == Summary == Test kms_flip: Subgroup flip-vs-absolute-wf_vblank: pass -> FAIL (shard-hsw) fdo#100368 Test

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Disable lazy PPGTT page table optimization for vGPU (rev2)

2017-10-23 Thread Patchwork
== Series Details == Series: drm/i915: Disable lazy PPGTT page table optimization for vGPU (rev2) URL : https://patchwork.freedesktop.org/series/32201/ State : success == Summary == Series 32201v2 drm/i915: Disable lazy PPGTT page table optimization for vGPU

Re: [Intel-gfx] [PATCH v3 1/7] fbcon: Add fbcon_rotate_hint to struct fb_info

2017-10-23 Thread Sebastian Reichel
Hi Hans, On Mon, Oct 23, 2017 at 09:14:19AM +0200, Hans de Goede wrote: > On some hardware the LCD panel is not mounted upright in the casing, > but upside-down or rotated 90 degrees. In this case we want the console > to automatically be rotated to compensate. > > The fbdev-driver may know

[Intel-gfx] [CI] drm/i915: Disable lazy PPGTT page table optimization for vGPU

2017-10-23 Thread Joonas Lahtinen
When running under virtualization (vGPU active), we must disable the lazy PPGTT page table initialization optimization introduced by: 14826673247e ("drm/i915: Only initialize partially filled pagetables") We must do this because GVT-g makes unduly assumptions about guest behaviour, which this

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Plane assert/readout cleanups etc. (rev7)

2017-10-23 Thread Patchwork
== Series Details == Series: drm/i915: Plane assert/readout cleanups etc. (rev7) URL : https://patchwork.freedesktop.org/series/31758/ State : success == Summary == Series 31758v7 drm/i915: Plane assert/readout cleanups etc.

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/fbdev: Panel orientation connector property support (rev2)

2017-10-23 Thread Hans de Goede
Hi, On 23-10-17 13:09, Saarinen, Jani wrote: Hi, -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Hans de Goede Sent: maanantai 23. lokakuuta 2017 13.32 To: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for

[Intel-gfx] [PATCH v3 08/10] drm/i915: Nuke crtc->plane

2017-10-23 Thread Ville Syrjala
From: Ville Syrjälä Eliminate crtc->plane since it's pretty much a layering violation. We can always get the plane via crtc->primary if we actually need it. The only ugly thing left is plane_to_crtc_mapping[], but that's still needed by the pre-g4x watermark code.

[Intel-gfx] [PATCH v4 01/10] drm/i915: Add .get_hw_state() method for planes

2017-10-23 Thread Ville Syrjala
From: Ville Syrjälä Add a .get_hw_state() method for planes, returning true or false depending on whether the plane is enabled. Use it to rewrite the plane enabled/disabled asserts in platform agnostic fashion. We do lose the pre-gen4 plane<->pipe mapping checks,

[Intel-gfx] [PATCH v5 03/10] drm/i915: s/enum plane/enum i9xx_plane_id/

2017-10-23 Thread Ville Syrjala
From: Ville Syrjälä Rename enum plane to enum i9xx_plane_id to make it clear that it only applies to pre-SKL platforms. enum i9xx_plane_id is a global identifier, whereas enum plane_id is per-pipe. We need the old global identifier to index the primary plane (and

Re: [Intel-gfx] [PATCH v3 1/7] fbcon: Add fbcon_rotate_hint to struct fb_info

2017-10-23 Thread Hans de Goede
Hi, On 23-10-17 14:43, Sebastian Reichel wrote: Hi Hans, On Mon, Oct 23, 2017 at 09:14:19AM +0200, Hans de Goede wrote: On some hardware the LCD panel is not mounted upright in the casing, but upside-down or rotated 90 degrees. In this case we want the console to automatically be rotated to

Re: [Intel-gfx] [PATCH] drm/i915: Apply Wa Display #1183 on skl, kbl, and cfl.

2017-10-23 Thread Ville Syrjälä
On Fri, Oct 20, 2017 at 03:15:49PM -0700, Rodrigo Vivi wrote: > Wa Display #1183 was recently added to workaround > "Failures when enabling DPLL0 with eDP link rate 2.16 > or 4.32 GHz and CD clock frequency 308.57 or 617.14 MHz > (CDCLK_CTL CD Frequency Select 10b or 11b) used in this > enabling

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Bump wait-times for the final CS interrupt before parking

2017-10-23 Thread Patchwork
== Series Details == Series: drm/i915: Bump wait-times for the final CS interrupt before parking URL : https://patchwork.freedesktop.org/series/32468/ State : failure == Summary == Series 32468v1 drm/i915: Bump wait-times for the final CS interrupt before parking

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Force DDI_A_4_LANES when needed.

2017-10-23 Thread Ville Syrjälä
On Fri, Oct 20, 2017 at 04:11:27PM -0700, Rodrigo Vivi wrote: > As we faced in BXT, on CNL DDI_A_4_LANES is not > set as expected when system is boot with multiple > monitors connected. This result in wrong lane > setup impacting the max data rate available and > consequently blocking modeset on

Re: [Intel-gfx] [PATCH] drm/i915: Show firmware URL once

2017-10-23 Thread Michal Wajdeczko
On Mon, 23 Oct 2017 14:15:06 +0200, Chris Wilson wrote: Quoting Michal Wajdeczko (2017-10-23 13:04:49) On Sun, 22 Oct 2017 12:15:50 +0200, Chris Wilson wrote: > Just show the firmware URL on the first failure, not every failure. > >

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add a hook for making the engines idle (parking) and unparking

2017-10-23 Thread Joonas Lahtinen
On Fri, 2017-10-20 at 22:06 +0100, Chris Wilson wrote: > In the next patch, we will want to install a callback when the engines > (GT as a whole) become idle and similarly when they first become busy. > To enable that callback, first rename intel_engines_mark_idle() to the > intel_engines_park()

[Intel-gfx] [CI] drm/i915: Bump wait-times for the final CS interrupt before parking

2017-10-23 Thread Chris Wilson
In the idle worker we drop the prolonged GT wakeref used to cover such essentials as interrupt delivery. (When a CS interrupt arrives, we also assert that the GT is awake.) However, it turns out that 10ms is not long enough to be assured that the last CS interrupt has been delivered, so bump that

Re: [Intel-gfx] [PATCH] drm/i915: Show firmware URL once

2017-10-23 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-10-23 13:04:49) > On Sun, 22 Oct 2017 12:15:50 +0200, Chris Wilson > wrote: > > > Just show the firmware URL on the first failure, not every failure. > > > > Signed-off-by: Chris Wilson > > Cc: Joonas Lahtinen

Re: [Intel-gfx] [PATCH 2/8] drm/i915: Start tracking voltage level in the cdclk state

2017-10-23 Thread Ville Syrjälä
On Fri, Oct 20, 2017 at 01:43:51PM -0700, Rodrigo Vivi wrote: > On Fri, Oct 20, 2017 at 02:01:37PM +, Ville Syrjälä wrote: > > On Wed, Oct 18, 2017 at 11:48:19PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > For CNL we'll need to start

Re: [Intel-gfx] [PATCH] drm/i915: Show firmware URL once

2017-10-23 Thread Michal Wajdeczko
On Sun, 22 Oct 2017 12:15:50 +0200, Chris Wilson wrote: Just show the firmware URL on the first failure, not every failure. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen Cc: Michal Wajdeczko

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Adjust system agent voltage on CNL if required by DDI ports

2017-10-23 Thread Ville Syrjälä
On Fri, Oct 20, 2017 at 09:44:53PM +, Runyan, Arthur J wrote: > If you know which direction voltage is moving, then you can optimize. Nobody > snooping PLL. Really only the DVFS post sequence is needed, placed either > before or after the clock programming, depending on whether voltage is

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Bump wait-times for the final CS interrupt before parking

2017-10-23 Thread Chris Wilson
Quoting Mika Kuoppala (2017-10-23 12:52:11) > Chris Wilson writes: > > > In the idle worker we drop the prolonged GT wakeref used to cover such > > essentials as interrupt delivery. (When a CS interrupt arrives, we also > > assert that the GT is awake.) However, it

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Bump wait-times for the final CS interrupt before parking

2017-10-23 Thread Mika Kuoppala
Chris Wilson writes: > In the idle worker we drop the prolonged GT wakeref used to cover such > essentials as interrupt delivery. (When a CS interrupt arrives, we also > assert that the GT is awake.) However, it turns out that 10ms is not > long enough to be assured

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Adjust system agent voltage on CNL if required by DDI ports

2017-10-23 Thread Ville Syrjälä
On Fri, Oct 20, 2017 at 01:36:42PM -0700, Rodrigo Vivi wrote: > On Fri, Oct 20, 2017 at 08:07:07PM +, Ville Syrjälä wrote: > > On Fri, Oct 20, 2017 at 05:48:54PM +, Runyan, Arthur J wrote: > > > Sorry about top reply from corporate email... > > > If you know in advance that you will just

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/fbdev: Panel orientation connector property support (rev2)

2017-10-23 Thread Saarinen, Jani
Hi, > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > Of Hans de Goede > Sent: maanantai 23. lokakuuta 2017 13.32 > To: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/fbdev: Panel orientation >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/fbdev: Panel orientation connector property support (rev2)

2017-10-23 Thread Patchwork
== Series Details == Series: drm/fbdev: Panel orientation connector property support (rev2) URL : https://patchwork.freedesktop.org/series/32447/ State : success == Summary == Test perf: Subgroup polling: pass -> FAIL (shard-hsw) fdo#102252 fdo#102252

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/fbdev: Panel orientation connector property support (rev2)

2017-10-23 Thread Hans de Goede
Hi, On 23-10-17 11:44, Patchwork wrote: == Series Details == Series: drm/fbdev: Panel orientation connector property support (rev2) URL : https://patchwork.freedesktop.org/series/32447/ State : failure == Summary == Series 32447v2 drm/fbdev: Panel orientation connector property support

Re: [Intel-gfx] [PATCH 05/15] drm/armada: Use drm_fb_helper_lastclose() and _poll_changed()

2017-10-23 Thread Russell King - ARM Linux
On Fri, Oct 20, 2017 at 01:02:03AM +0200, Noralf Trønnes wrote: > This driver can use drm_fb_helper_lastclose() as its .lastclose callback. > It can also use drm_fb_helper_output_poll_changed() as its > .output_poll_changed callback. > > Cc: Russell King Acked-by: Russell

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_atomic_transition: Make tests pass

2017-10-23 Thread Maarten Lankhorst
Op 23-10-17 om 11:35 schreef Petri Latvala: > > > On Fri, Oct 20, 2017 at 03:24:15PM +0200, Maarten Lankhorst wrote: > > Subject: [Intel-gfx] [PATCH i-g-t] tests/kms_atomic_transition: Make tests > pass > > > You have an excellent explanation of what this patch does in the long > description, and

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_lowres: Rework tests to work without fbcon.

2017-10-23 Thread Maarten Lankhorst
Op 23-10-17 om 12:05 schreef Mika Kahola: > Reviewed-by: Mika Kahola > > On Fri, 2017-10-13 at 16:58 +0200, Maarten Lankhorst wrote: >> kmstest_get_crtc was skipping because at that point the crtc was not >> active yet, instead we should only use igt_assert_plane_visible >>

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_lowres: Rework tests to work without fbcon.

2017-10-23 Thread Mika Kahola
Reviewed-by: Mika Kahola On Fri, 2017-10-13 at 16:58 +0200, Maarten Lankhorst wrote: > kmstest_get_crtc was skipping because at that point the crtc was not > active yet, instead we should only use igt_assert_plane_visible > directly. Unexport kmstest_get_crtc, since

[Intel-gfx] Updated drm-intel-testing

2017-10-23 Thread Jani Nikula
Hi all, The following changes tagged drm-intel-testing-2017-10-23: drm-intel-next-2017-10-23: This time really the last i915 batch for v4.15: - PSR state tracking in crtc state (Ville) - Fix eviction when the GGTT is idle but full (Chris) - BDW DP aux channel timeout fix (James) - LSPCON

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/fbdev: Panel orientation connector property support (rev2)

2017-10-23 Thread Patchwork
== Series Details == Series: drm/fbdev: Panel orientation connector property support (rev2) URL : https://patchwork.freedesktop.org/series/32447/ State : failure == Summary == Series 32447v2 drm/fbdev: Panel orientation connector property support

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_atomic_transition: Make tests pass

2017-10-23 Thread Petri Latvala
On Fri, Oct 20, 2017 at 03:24:15PM +0200, Maarten Lankhorst wrote: Subject: [Intel-gfx] [PATCH i-g-t] tests/kms_atomic_transition: Make tests pass You have an excellent explanation of what this patch does in the long description, and yet this short description says nothing of value. --

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_eio: Skip in-flight-suspend on snb

2017-10-23 Thread Martin Peres
On 20/10/17 12:26, Joonas Lahtinen wrote: > + Petri > > On Thu, 2017-10-19 at 16:29 +0300, Martin Peres wrote: >> On 19/10/17 12:51, Daniel Vetter wrote: >>> CI gets upset about it resulting in an incomplete, let's skip it until >>> that's fixed to avoid havoc in the CI farm. Of course this

[Intel-gfx] [PATCH v4 5/7] drm/i915: Add "panel orientation" property to the panel connector

2017-10-23 Thread Hans de Goede
Ideally we could use the VBT for this, that would be simple, in intel_dsi_init() check dev_priv->vbt.dsi.config->rotation, set connector->display_info.panel_orientation accordingly and call drm_connector_init_panel_orientation_property(), done. Unfortunately vbt.dsi.config->rotation is always 0

[Intel-gfx] [PATCH v4 4/7] drm/fb-helper: Apply panel orientation connector prop to the primary plane

2017-10-23 Thread Hans de Goede
Apply the "panel orientation" drm connector prop to the primary plane so that fbcon and fbdev using userspace programs display the right way up. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=94894 Signed-off-by: Hans de Goede --- Changes in v2: -New patch in v2 of this

[Intel-gfx] [PATCH v4 7/7] fbcon: Remove dmi quirk table

2017-10-23 Thread Hans de Goede
This is now all handled in the drivers and communicated through fb_info.fbcon_rotate_hint. Signed-off-by: Hans de Goede --- drivers/video/fbdev/core/Makefile | 3 - drivers/video/fbdev/core/fbcon.c| 4 +- drivers/video/fbdev/core/fbcon.h

[Intel-gfx] [PATCH v4 2/7] drm: Add panel orientation quirks

2017-10-23 Thread Hans de Goede
Some x86 clamshell design devices use portrait tablet screens and a display engine which cannot rotate in hardware, so the firmware just leaves things as is and we cannot figure out that the display is oriented non upright from the hardware. So at least on x86, we need a quirk table for this.

[Intel-gfx] [PATCH v4 3/7] drm: Add support for a panel-orientation connector property

2017-10-23 Thread Hans de Goede
On some devices the LCD panel is mounted in the casing in such a way that the up/top side of the panel does not match with the top side of the device (e.g. it is mounted upside-down). This commit adds the necessary infra for lcd-panel drm_connector-s to have a "panel orientation" property to

[Intel-gfx] [PATCH v4 0/7] drm/fbdev: Panel orientation connector property support

2017-10-23 Thread Hans de Goede
Hi All, Here is v4 of my series to add a "panel orientation" property to the drm-connector for the LCD panel to let userspace know about LCD panels which are not mounted upright, as well as detecting upside-down panels without needing quirks (like we do for 90 degree rotated screens). New in v3:

[Intel-gfx] [PATCH v4 6/7] efifb: Set info->fbcon_rotate_hint based on drm_get_panel_orientation_quirk

2017-10-23 Thread Hans de Goede
On some hardware the LCD panel is not mounted upright in the casing, but rotated by 90 degrees. In this case we want the console to automatically be rotated to compensate. The drm subsys has a quirk table for this, use the drm_get_panel_orientation_quirk function to get the panel orientation and

[Intel-gfx] [PATCH v4 1/7] fbcon: Add fbcon_rotate_hint to struct fb_info

2017-10-23 Thread Hans de Goede
On some hardware the LCD panel is not mounted upright in the casing, but upside-down or rotated 90 degrees. In this case we want the console to automatically be rotated to compensate. The fbdev-driver may know about the need to rotate. Add a new fbcon_rotate_hint field to struct fb_info, which

Re: [Intel-gfx] [PATCH] drm/i915: Increase the busyspin durations for i915_wait_request

2017-10-23 Thread Sagar Arun Kamble
On 9/15/2017 3:48 PM, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-09-15 11:01:02) On 14/09/2017 10:58, Chris Wilson wrote: An interesting discussion regarding "hybrid interrupt polling" for NVMe came to the conclusion that the ideal busyspin before sleeping was half of the expected

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/fbdev: Panel orientation connector property support

2017-10-23 Thread Patchwork
== Series Details == Series: drm/fbdev: Panel orientation connector property support URL : https://patchwork.freedesktop.org/series/32447/ State : failure == Summary == Test kms_properties: Subgroup plane-properties-atomic: pass -> FAIL (shard-hsw)

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/fbdev: Panel orientation connector property support

2017-10-23 Thread Hans de Goede
Hi, On 23-10-17 09:33, Patchwork wrote: == Series Details == Series: drm/fbdev: Panel orientation connector property support URL : https://patchwork.freedesktop.org/series/32447/ State : warning Ok, I think I know where the warnings are coming from, v4 coming up. Regards, Hans

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/fbdev: Panel orientation connector property support

2017-10-23 Thread Patchwork
== Series Details == Series: drm/fbdev: Panel orientation connector property support URL : https://patchwork.freedesktop.org/series/32447/ State : warning == Summary == Series 32447v1 drm/fbdev: Panel orientation connector property support

[Intel-gfx] [PATCH v3 3/7] drm: Add support for a panel-orientation connector property

2017-10-23 Thread Hans de Goede
On some devices the LCD panel is mounted in the casing in such a way that the up/top side of the panel does not match with the top side of the device (e.g. it is mounted upside-down). This commit adds the necessary infra for lcd-panel drm_connector-s to have a "panel orientation" property to

[Intel-gfx] [PATCH v3 4/7] drm/fb-helper: Apply panel orientation connector prop to the primary plane

2017-10-23 Thread Hans de Goede
Apply the "panel orientation" drm connector prop to the primary plane so that fbcon and fbdev using userspace programs display the right way up. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=94894 Signed-off-by: Hans de Goede --- Changes in v2: -New patch in v2 of this

[Intel-gfx] [PATCH v3 6/7] efifb: Set info->fbcon_rotate_hint based on drm_get_panel_orientation_quirk

2017-10-23 Thread Hans de Goede
On some hardware the LCD panel is not mounted upright in the casing, but rotated by 90 degrees. In this case we want the console to automatically be rotated to compensate. The drm subsys has a quirk table for this, use the drm_get_panel_orientation_quirk function to get the panel orientation and

[Intel-gfx] [PATCH v3 1/7] fbcon: Add fbcon_rotate_hint to struct fb_info

2017-10-23 Thread Hans de Goede
On some hardware the LCD panel is not mounted upright in the casing, but upside-down or rotated 90 degrees. In this case we want the console to automatically be rotated to compensate. The fbdev-driver may know about the need to rotate. Add a new fbcon_rotate_hint field to struct fb_info, which

[Intel-gfx] [PATCH v3 5/7] drm/i915: Add "panel orientation" property to the panel connector

2017-10-23 Thread Hans de Goede
Ideally we could use the VBT for this, that would be simple, in intel_dsi_init() check dev_priv->vbt.dsi.config->rotation, set connector->display_info.panel_orientation accordingly and call drm_connector_init_panel_orientation_property(), done. Unfortunately vbt.dsi.config->rotation is always 0

[Intel-gfx] [PATCH v3 0/7] drm/fbdev: Panel orientation connector property support

2017-10-23 Thread Hans de Goede
Hi All, Here is v3 of my series to add a "panel orientation" property to the drm-connector for the LCD panel to let userspace know about LCD panels which are not mounted upright, as well as detecting upside-down panels without needing quirks (like we do for 90 degree rotated screens). As

[Intel-gfx] [PATCH v3 2/7] drm: Add panel orientation quirks

2017-10-23 Thread Hans de Goede
Some x86 clamshell design devices use portrait tablet screens and a display engine which cannot rotate in hardware, so the firmware just leaves things as is and we cannot figure out that the display is oriented non upright from the hardware. So at least on x86, we need a quirk table for this.

[Intel-gfx] [PATCH v3 7/7] fbcon: Remove dmi quirk table

2017-10-23 Thread Hans de Goede
This is now all handled in the drivers and communicated through fb_info.fbcon_rotate_hint. Signed-off-by: Hans de Goede --- drivers/video/fbdev/core/Makefile | 3 - drivers/video/fbdev/core/fbcon.c| 4 +- drivers/video/fbdev/core/fbcon.h

Re: [Intel-gfx] [PATCH 15/15] staging: vboxvideo: Use drm_fb_helper_lastclose()

2017-10-23 Thread Hans de Goede
HI, On 20-10-17 01:02, Noralf Trønnes wrote: This driver can use drm_fb_helper_lastclose() as its .lastclose callback. Cc: Hans de Goede Signed-off-by: Noralf Trønnes Thank you for doing this, looks good to me: Reviewed-by: Hans de Goede

  1   2   >