[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Move hsw GT w/a to engine initialisation

2017-11-02 Thread Patchwork
== Series Details == Series: drm/i915: Move hsw GT w/a to engine initialisation URL : https://patchwork.freedesktop.org/series/33095/ State : failure == Summary == Series 33095v1 drm/i915: Move hsw GT w/a to engine initialisation

Re: [Intel-gfx] [PATCH] drm/i915: set minimum CD clock to twice the BCLK.

2017-11-02 Thread Prusty, Subhransu S
> > On 10/30/2017 5:21 PM, Pandiyan, Dhinakaran wrote: > > On Sun, 2017-10-29 at 03:04 +, Kumar, Abhay wrote: > >> + Subhransu > >> > >> -Original Message- > >> From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > >> Of > Kumar, Abhay > >> Sent: Thursday,

Re: [Intel-gfx] [PATCH] drm/i915: set minimum CD clock to twice the BCLK.

2017-11-02 Thread Prusty, Subhransu S
> >> b/drivers/gpu/drm/i915/intel_cdclk.c index > >> e8884c2ade98..185a70f0921c > >> 100644 > >> --- a/drivers/gpu/drm/i915/intel_cdclk.c > >> +++ b/drivers/gpu/drm/i915/intel_cdclk.c > >> @@ -1920,7 +1920,7 @@ int intel_crtc_compute_min_cdclk(const struct > >>

[Intel-gfx] [PATCH] drm/i915: Move hsw GT w/a to engine initialisation

2017-11-02 Thread Chris Wilson
In commit b7048ea12fbb ("drm/i915: Do .init_clock_gating() earlier to avoid it clobbering watermarks") init_clock_gating was called earlier in the module load sequence, moving it before we acquired the forcewake used to initialise the engines. This revealed that on Haswell, at least, some of those

Re: [Intel-gfx] [PATCH 05/20] drm/i915: Save all GT WAs and apply them at a later time

2017-11-02 Thread Chris Wilson
Quoting Joonas Lahtinen (2017-10-31 14:14:52) > On Mon, 2017-10-30 at 13:17 -0700, Oscar Mateo wrote: > > By doing this, we can dump these workarounds in debugfs for validation > > (which, > > at the moment, we are only able to do for the contexts WAs). > > > > v2: > > - Wrong macro used for

Re: [Intel-gfx] [PATCH v5 2/5] drm/i915/guc : Removing i915_modparams.enable_guc_loading module

2017-11-02 Thread Chris Wilson
Quoting Rodrigo Vivi (2017-11-02 23:52:45) > On Wed, Oct 4, 2017 at 6:07 AM, Joonas Lahtinen > wrote: > > On Tue, 2017-10-03 at 15:56 -0700, Sujaritha Sundaresan wrote: > >> We currently have two module parameters that control GuC: > >> "enable_guc_loading" and

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/glk: Refactor handling of PLANE_COLOR_CTL for GLK+

2017-11-02 Thread Patchwork
== Series Details == Series: drm/i915/glk: Refactor handling of PLANE_COLOR_CTL for GLK+ URL : https://patchwork.freedesktop.org/series/33087/ State : warning == Summary == Series 33087v1 drm/i915/glk: Refactor handling of PLANE_COLOR_CTL for GLK+

Re: [Intel-gfx] [PATCH v5 2/5] drm/i915/guc : Removing i915_modparams.enable_guc_loading module

2017-11-02 Thread Rodrigo Vivi
On Wed, Oct 4, 2017 at 6:07 AM, Joonas Lahtinen wrote: > On Tue, 2017-10-03 at 15:56 -0700, Sujaritha Sundaresan wrote: >> We currently have two module parameters that control GuC: >> "enable_guc_loading" and "enable_guc_submission". >> Whenever we need

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Stop caching the "golden" renderstate

2017-11-02 Thread Chris Wilson
Quoting Rodrigo Vivi (2017-11-02 23:34:52) > On Thu, Nov 02, 2017 at 10:36:26PM +, Oscar Mateo wrote: > > > > > > On 11/02/2017 07:56 AM, Joonas Lahtinen wrote: > > > On Thu, 2017-11-02 at 07:54 -0700, Rodrigo Vivi wrote: > > > > On Thu, Nov 02, 2017 at 02:43:16PM +, Joonas Lahtinen

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Stop caching the "golden" renderstate

2017-11-02 Thread Rodrigo Vivi
On Thu, Nov 02, 2017 at 10:36:26PM +, Oscar Mateo wrote: > > > On 11/02/2017 07:56 AM, Joonas Lahtinen wrote: > > On Thu, 2017-11-02 at 07:54 -0700, Rodrigo Vivi wrote: > > > On Thu, Nov 02, 2017 at 02:43:16PM +, Joonas Lahtinen wrote: > > > > On Thu, 2017-11-02 at 12:42 +, Chris

[Intel-gfx] [PATCH] drm/i915/glk: Refactor handling of PLANE_COLOR_CTL for GLK+

2017-11-02 Thread James Ausmus
Since GLK, some plane configuration settings have moved to the PLANE_COLOR_CTL register. Refactor handling of the register to work like PLANE_CTL. This also allows us to fix the set/read of the plane Alpha Mode for GLK+. Signed-off-by: James Ausmus Cc: Paulo Zanoni

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Stop caching the "golden" renderstate

2017-11-02 Thread Oscar Mateo
On 11/02/2017 07:56 AM, Joonas Lahtinen wrote: On Thu, 2017-11-02 at 07:54 -0700, Rodrigo Vivi wrote: On Thu, Nov 02, 2017 at 02:43:16PM +, Joonas Lahtinen wrote: On Thu, 2017-11-02 at 12:42 +, Chris Wilson wrote: As we now record the default HW state and so only emit the "golden"

[Intel-gfx] [i-g-t ] igt/kms_frontbuffer_tracking: Indefinite blocking with PSR HW tracking [Draft]

2017-11-02 Thread Vyas, Tarun
The patch https://patchwork.freedesktop.org/patch/166512/ which relies on HW tracking for frontbuffer flushes/invalidations leads to an indefinite block when running any of the *psr* subtests of the kms_frontbuffer_tracking test. ===Failure analysis=== Subtest: kms_frontbuffer_tracking

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Add GuC Load time to dmesg log.

2017-11-02 Thread Chris Wilson
Quoting Anusha Srivatsa (2017-11-02 20:28:10) > On Wed, Nov 01, 2017 at 01:24:15PM +, Chris Wilson wrote: > > Quoting Michal Wajdeczko (2017-11-01 13:14:33) > > > On Wed, 01 Nov 2017 01:11:20 +0100, Anusha Srivatsa > > > > @@ -172,13 +174,18 @@ static int guc_ucode_xfer_dma(struct > > > >

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Add GuC Load time to dmesg log.

2017-11-02 Thread Anusha Srivatsa
On Wed, Nov 01, 2017 at 01:24:15PM +, Chris Wilson wrote: > Quoting Michal Wajdeczko (2017-11-01 13:14:33) > > On Wed, 01 Nov 2017 01:11:20 +0100, Anusha Srivatsa > > > @@ -172,13 +174,18 @@ static int guc_ucode_xfer_dma(struct > > > drm_i915_private *dev_priv, > > >*/ > > >

[Intel-gfx] ✗ Fi.CI.IGT: warning for tests: add device information tests (rev2)

2017-11-02 Thread Patchwork
== Series Details == Series: tests: add device information tests (rev2) URL : https://patchwork.freedesktop.org/series/32764/ State : warning == Summary == Test kms_busy: Subgroup extended-modeset-hang-oldfb-with-reset-render-B: pass -> DMESG-WARN (shard-hsw)

Re: [Intel-gfx] [PATCH v8 4/6] drm/i915/guc : Updating GuC and HuC firmware select function

2017-11-02 Thread Sujaritha
On 10/25/2017 08:56 AM, Michal Wajdeczko wrote: On Tue, 24 Oct 2017 19:21:23 +0200, Sujaritha Sundaresan wrote: Updating GuC and HuC firmware select function to support removing i915_modparams.enable_guc_loading module parameter. Hmm, is it correct order

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Plane assert/readout cleanups etc. (rev8)

2017-11-02 Thread Patchwork
== Series Details == Series: drm/i915: Plane assert/readout cleanups etc. (rev8) URL : https://patchwork.freedesktop.org/series/31758/ State : success == Summary == Test kms_setmode: Subgroup basic: pass -> FAIL (shard-hsw) fdo#99912 Test kms_flip:

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Add GuC Load time to dmesg log.

2017-11-02 Thread Anusha Srivatsa
On Wed, Nov 01, 2017 at 02:14:33PM +0100, Michal Wajdeczko wrote: > On Wed, 01 Nov 2017 01:11:20 +0100, Anusha Srivatsa > wrote: > > >Calculate the time that GuC takes to load using > >jiffies. This information could be very useful in > ^^^ > This is no longer

Re: [Intel-gfx] [PATCH] drm/i915/dmc: DMC 1.04 for Kabylake

2017-11-02 Thread Pandiyan, Dhinakaran
On Thu, 2017-11-02 at 07:27 -0700, Rodrigo Vivi wrote: > On Thu, Nov 02, 2017 at 10:34:37AM +, Jani Nikula wrote: > > On Wed, 01 Nov 2017, Anusha Srivatsa wrote: > > > There is a new version of DMC available for KBL. > > > > Nobody's going to pull this to

[Intel-gfx] ✗ Fi.CI.IGT: failure for i915: Cannonlake perf support (rev2)

2017-11-02 Thread Patchwork
== Series Details == Series: i915: Cannonlake perf support (rev2) URL : https://patchwork.freedesktop.org/series/32762/ State : failure == Summary == Test kms_flip: Subgroup blocking-wf_vblank: pass -> FAIL (shard-hsw) Test kms_busy: Subgroup

Re: [Intel-gfx] [PATCH v2 8/9] drm/i915: expose eu topology to userspace

2017-11-02 Thread Lionel Landwerlin
On 02/11/17 16:35, Chris Wilson wrote: Quoting Lionel Landwerlin (2017-11-02 16:29:48) +/* Query various aspects of the topology of the GPU. Below is a list of the + * currently supported queries. The motivation of this more detailed query + * mechanism is to expose asynmetric properties of the

[Intel-gfx] ✓ Fi.CI.BAT: success for tests: add device information tests (rev2)

2017-11-02 Thread Patchwork
== Series Details == Series: tests: add device information tests (rev2) URL : https://patchwork.freedesktop.org/series/32764/ State : success == Summary == IGT patchset tested on top of latest successful build 6d16875736b9fb1ebf4bf3dc5a941f9e431d58e0 lib/igt_debugfs: Remove support for

Re: [Intel-gfx] [PATCH i-g-t] kms_atomic_transition: Split out modeset tests on internal panels

2017-11-02 Thread Chris Wilson
Quoting Imre Deak (2017-11-02 13:38:09) > Doing modeset on internal panels may have a considerable overhead due to > the panel specific power sequencing delays. To avoid long test runtimes > in the CI fast-feedback test split out the testing of internal panels > from the plane modeset subtests.

[Intel-gfx] ✗ Fi.CI.IGT: warning for kms_atomic_transition: Split out modeset tests on internal panels

2017-11-02 Thread Patchwork
== Series Details == Series: kms_atomic_transition: Split out modeset tests on internal panels URL : https://patchwork.freedesktop.org/series/33052/ State : warning == Summary == Test kms_setmode: Subgroup basic: pass -> FAIL (shard-hsw) fdo#99912 Test

Re: [Intel-gfx] ✗ Fi.CI.IGT: warning for series starting with [1/3] drm/i915: Check if the stolen memory "reserved" area is enabled or not

2017-11-02 Thread Ville Syrjälä
On Thu, Nov 02, 2017 at 04:34:26PM -, Patchwork wrote: > == Series Details == > > Series: series starting with [1/3] drm/i915: Check if the stolen memory > "reserved" area is enabled or not > URL : https://patchwork.freedesktop.org/series/33060/ > State : warning > > == Summary == > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Plane assert/readout cleanups etc. (rev8)

2017-11-02 Thread Patchwork
== Series Details == Series: drm/i915: Plane assert/readout cleanups etc. (rev8) URL : https://patchwork.freedesktop.org/series/31758/ State : success == Summary == Series 31758v8 drm/i915: Plane assert/readout cleanups etc.

Re: [Intel-gfx] [PATCH] drm/i915/dmc: DMC 1.04 for Kabylake

2017-11-02 Thread Srivatsa, Anusha
>-Original Message- >From: Jani Nikula [mailto:jani.nik...@linux.intel.com] >Sent: Thursday, November 2, 2017 3:35 AM >To: Srivatsa, Anusha ; intel- >g...@lists.freedesktop.org >Cc: Vivi, Rodrigo >Subject: Re: [Intel-gfx] [PATCH]

[Intel-gfx] ✓ Fi.CI.BAT: success for i915: Cannonlake perf support (rev2)

2017-11-02 Thread Patchwork
== Series Details == Series: i915: Cannonlake perf support (rev2) URL : https://patchwork.freedesktop.org/series/32762/ State : success == Summary == Series 32762v2 i915: Cannonlake perf support https://patchwork.freedesktop.org/api/1.0/series/32762/revisions/2/mbox/ Test chamelium:

[Intel-gfx] [PATCH v2 10/10] drm/i915: Add rudimentary plane state verification

2017-11-02 Thread Ville Syrjala
From: Ville Syrjälä Check that the planes are in the state we expect them to be. For now we can only check whether each plane is correctly enabled or disabled. In the future we may want to expand the plane state readout to support a more through verification. v2:

Re: [Intel-gfx] [PATCH v8 2/6] drm/i915/guc : Removing i915_modparams.enable_guc_loading module parameter

2017-11-02 Thread Sujaritha
On 10/25/2017 08:26 AM, Michal Wajdeczko wrote: On Tue, 24 Oct 2017 19:21:21 +0200, Sujaritha Sundaresan wrote: We currently have two module parameters that control GuC: "enable_guc_loading" and "enable_guc_submission". Whenever we need submission=1, we also

Re: [Intel-gfx] [PATCH v2 8/9] drm/i915: expose eu topology to userspace

2017-11-02 Thread Lionel Landwerlin
On 02/11/17 16:35, Chris Wilson wrote: Quoting Lionel Landwerlin (2017-11-02 16:29:48) +/* Query various aspects of the topology of the GPU. Below is a list of the + * currently supported queries. The motivation of this more detailed query + * mechanism is to expose asynmetric properties of the

Re: [Intel-gfx] [PATCH v2 8/9] drm/i915: expose eu topology to userspace

2017-11-02 Thread Chris Wilson
Quoting Lionel Landwerlin (2017-11-02 16:29:48) > +/* Query various aspects of the topology of the GPU. Below is a list of the > + * currently supported queries. The motivation of this more detailed query > + * mechanism is to expose asynmetric properties of the GPU. Starting with > CNL, > + *

[Intel-gfx] ✗ Fi.CI.IGT: warning for series starting with [1/3] drm/i915: Check if the stolen memory "reserved" area is enabled or not

2017-11-02 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Check if the stolen memory "reserved" area is enabled or not URL : https://patchwork.freedesktop.org/series/33060/ State : warning == Summary == Test kms_busy: Subgroup extended-modeset-hang-oldfb-with-reset-render-A:

[Intel-gfx] [PATCH i-g-t v2] tests: add device information tests

2017-11-02 Thread Lionel Landwerlin
We can verify that topology is consistent with previous getparam like EU_TOTAL. We also verify that CS timestamp frequency is always filled. v2: Use v2 of kernel uapi (Lionel) Fix Gen < 8 issue Signed-off-by: Lionel Landwerlin --- tests/Makefile.sources|

[Intel-gfx] [PATCH v2 1/9] drm/i915/perf: complete whitelisting for OA programming on HSW

2017-11-02 Thread Lionel Landwerlin
We were missing some registers and also can name one for which we only had the offset. Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/i915_perf.c | 3 ++- drivers/gpu/drm/i915/i915_reg.h | 14 ++ 2 files changed, 16 insertions(+), 1

[Intel-gfx] [PATCH v2 8/9] drm/i915: expose eu topology to userspace

2017-11-02 Thread Lionel Landwerlin
With the introduction of asymetric slices in CNL, we cannot rely on the previous SUBSLICE_MASK getparam. Here we introduce a more detailed way of querying the Gen's GPU topology that doesn't aggregate numbers. This is essential for monitoring parts of the GPU with the OA unit, because counters

[Intel-gfx] [PATCH v2 3/9] drm/i915/perf: refactor perf setup

2017-11-02 Thread Lionel Landwerlin
Gen8/9 aren't very different and we can merge some of this code. Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/i915_perf.c | 48 +--- 1 file changed, 25 insertions(+), 23 deletions(-) diff --git

[Intel-gfx] [PATCH v2 9/9] drm/i915/debugfs: reuse max slice/subslices already stored in sseu

2017-11-02 Thread Lionel Landwerlin
Now that we have that information in topology fields, let's just reused it. Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/i915_debugfs.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git

[Intel-gfx] [PATCH v2 4/9] drm/i915: fix register naming

2017-11-02 Thread Lionel Landwerlin
This name was added with the whitelisting of registers for building up OA configs. It is contained in a range gen8 whitelist : addr >= RPM_CONFIG0.reg && addr <= NOA_CONFIG(8).reg Hence why the name isn't used anywhere. Signed-off-by: Lionel Landwerlin ---

[Intel-gfx] [PATCH v2 0/9] i915: Cannonlake perf support

2017-11-02 Thread Lionel Landwerlin
Hi, This is a change only on patch 8 (topology) where it makes the uapi a bit simpler to use and also leaves some room for future queries (one of the case could be query on media capabilities, where different Gens/GT have different numbers of media rings). Cheers, Lionel Landwerlin (9):

[Intel-gfx] [PATCH v2 6/9] drm/i915: expose command stream timestamp frequency to userspace

2017-11-02 Thread Lionel Landwerlin
We use to have this fixed per generation, but starting with CNL userspace cannot tell just off the PCI ID. Let's make this information available. This is particularly useful for performance monitoring where much of the normalization work is done using those timestamps (this include pipeline

[Intel-gfx] [PATCH v2 7/9] drm/i915/perf: reuse timestamp frequency from device info

2017-11-02 Thread Lionel Landwerlin
Now that we have this stored in the device info, we can drop it from perf part of the driver. Note that this requires to init perf after we've computed the frequency, hence why we move i915_perf_init() from i915_driver_init_early() to after intel_device_info_runtime_init(). Signed-off-by: Lionel

[Intel-gfx] [PATCH v2 5/9] drm/i915/perf: enable perf support on CNL

2017-11-02 Thread Lionel Landwerlin
This adds new registers to the whitelist to configs emitted from userspace. Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/Makefile | 3 +- drivers/gpu/drm/i915/i915_oa_cnl.c | 121 +

[Intel-gfx] [PATCH v2 2/9] drm/i915/perf: add support for Coffeelake GT3

2017-11-02 Thread Lionel Landwerlin
We can enable GT3 as well as GT2. Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/Makefile | 3 +- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_oa_cflgt3.c | 109 ++

Re: [Intel-gfx] [PATCH] drm/i915: Remove support for legacy debugfs crc interface

2017-11-02 Thread Ville Syrjälä
On Thu, Nov 02, 2017 at 05:19:07PM +0200, Jani Nikula wrote: > On Thu, 02 Nov 2017, Ville Syrjälä wrote: > > On Thu, Nov 02, 2017 at 02:56:51PM +0100, Maarten Lankhorst wrote: > >> This interface is deprecated, and has been replaced by the upstream > >> drm crc

[Intel-gfx] ✗ Fi.CI.IGT: warning for tests/debugfs_test: Pretty print subdirectories

2017-11-02 Thread Patchwork
== Series Details == Series: tests/debugfs_test: Pretty print subdirectories URL : https://patchwork.freedesktop.org/series/33045/ State : warning == Summary == Test drv_module_reload: Subgroup basic-no-display: pass -> DMESG-WARN (shard-hsw) fdo#102707 +1 Test

Re: [Intel-gfx] [PATCH v8 6/6] drm/i915/guc : Decouple logs and ADS from submission

2017-11-02 Thread Sujaritha
On 11/02/2017 02:23 AM, Sagar Arun Kamble wrote: On 10/25/2017 9:49 PM, Michal Wajdeczko wrote: On Tue, 24 Oct 2017 19:21:25 +0200, Sujaritha Sundaresan wrote: The Additional Data Struct (ADS) contains objects that are required by guc post FW load and are

[Intel-gfx] ✓ Fi.CI.BAT: success for kms_atomic_transition: Split out modeset tests on internal panels

2017-11-02 Thread Patchwork
== Series Details == Series: kms_atomic_transition: Split out modeset tests on internal panels URL : https://patchwork.freedesktop.org/series/33052/ State : success == Summary == IGT patchset tested on top of latest successful build 6d16875736b9fb1ebf4bf3dc5a941f9e431d58e0 lib/igt_debugfs:

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Set up mocs tables before restarting the engines

2017-11-02 Thread Patchwork
== Series Details == Series: drm/i915: Set up mocs tables before restarting the engines URL : https://patchwork.freedesktop.org/series/33051/ State : warning == Summary == Test kms_busy: Subgroup extended-modeset-hang-newfb-with-reset-render-B: pass -> DMESG-WARN

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Force the switch to the i915->kernel_context

2017-11-02 Thread Chris Wilson
Quoting Mika Kuoppala (2017-11-02 15:40:50) > Chris Wilson writes: > > > In the next few patches, we will have a hard requirement that we emit a > > context-switch to the perma-pinned i915->kernel_context (so that we can > > save the HW state using that context-switch).

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Force the switch to the i915->kernel_context

2017-11-02 Thread Mika Kuoppala
Chris Wilson writes: > In the next few patches, we will have a hard requirement that we emit a > context-switch to the perma-pinned i915->kernel_context (so that we can > save the HW state using that context-switch). As the first context > itself may be classed as a

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Check if the stolen memory "reserved" area is enabled or not

2017-11-02 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Check if the stolen memory "reserved" area is enabled or not URL : https://patchwork.freedesktop.org/series/33060/ State : success == Summary == Series 33060v1 series starting with [1/3] drm/i915: Check if the stolen memory

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Move GT powersaving init to i915_gem_init()

2017-11-02 Thread Sagar Arun Kamble
On 11/2/2017 8:25 PM, Chris Wilson wrote: Quoting Sagar Arun Kamble (2017-11-02 14:35:17) On 11/2/2017 6:12 PM, Chris Wilson wrote: GT powersaving is tightly coupled to the request infrastructure. To avoid complications with the order of initialisation in the next patch (where we want to

[Intel-gfx] ✗ Fi.CI.BAT: failure for Lib: Move __gem_context_create to common ioctl wrapper library. (rev3)

2017-11-02 Thread Patchwork
== Series Details == Series: Lib: Move __gem_context_create to common ioctl wrapper library. (rev3) URL : https://patchwork.freedesktop.org/series/31775/ State : failure == Summary == IGT patchset tested on top of latest successful build 6d16875736b9fb1ebf4bf3dc5a941f9e431d58e0

[Intel-gfx] [PATCH 2/3] drm/i915: Make the report about a bogus stolen reserved area an error

2017-11-02 Thread Ville Syrjala
From: Ville Syrjälä Now that we should be properly filtering out the cases when the stolen reserved area is disabled, let's convert the debug message about a misplaced reserved area into an error. Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH 3/3] drm/i915: Use ELK stolen memory reserved detection for ILK

2017-11-02 Thread Ville Syrjala
From: Ville Syrjälä While I have no solid proof that ILK follows the ELK path when it comes to the stolen memory reserved area, there are some hints that it might be the case. Unfortunately my ILK doesn't have this enabled, and no way to enable it via the BIOS it

[Intel-gfx] [PATCH 1/3] drm/i915: Check if the stolen memory "reserved" area is enabled or not

2017-11-02 Thread Ville Syrjala
From: Ville Syrjälä Apparently there are some machines that put semi-sensible looking values into the stolen "reserved" base and size, except those values are actually outside the stolen memory. There is a bit in the register which supposedly could tell us whether

Re: [Intel-gfx] [PATCH] drm/i915: Remove support for legacy debugfs crc interface

2017-11-02 Thread Jani Nikula
On Thu, 02 Nov 2017, Ville Syrjälä wrote: > On Thu, Nov 02, 2017 at 02:56:51PM +0100, Maarten Lankhorst wrote: >> This interface is deprecated, and has been replaced by the upstream >> drm crc interface. > > Before we nuke this I would like to see an option in the

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915/dmc: DMC 1.04 for Kabylake

2017-11-02 Thread Patchwork
== Series Details == Series: drm/i915/dmc: DMC 1.04 for Kabylake URL : https://patchwork.freedesktop.org/series/33022/ State : warning == Summary == Test kms_busy: Subgroup extended-modeset-hang-newfb-with-reset-render-B: pass -> DMESG-WARN (shard-hsw)

Re: [Intel-gfx] [PATCH v3] drm/i915: Remove unsafe i915.enable_rc6

2017-11-02 Thread Jani Nikula
On Thu, 02 Nov 2017, Joonas Lahtinen wrote: > On Thu, 2017-11-02 at 07:47 -0700, Rodrigo Vivi wrote: >> On Thu, Nov 02, 2017 at 08:06:29AM +, Jani Nikula wrote: >> > On Wed, 01 Nov 2017, Rodrigo Vivi wrote: >> > > On Wed, Nov 01, 2017

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Move execlists port head instead of memmoving array

2017-11-02 Thread Chris Wilson
Quoting Mika Kuoppala (2017-10-31 15:27:34) > From: Mika Kuoppala > > As all our access to execlist ports are through head and tail > helpers, we can now move the head instead of memmoving the array. > > v2: use memset (Chris) > > Cc: Michał Winiarski

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/debugfs_test: Pretty print subdirectories

2017-11-02 Thread Patchwork
== Series Details == Series: tests/debugfs_test: Pretty print subdirectories URL : https://patchwork.freedesktop.org/series/33045/ State : success == Summary == IGT patchset tested on top of latest successful build 6d16875736b9fb1ebf4bf3dc5a941f9e431d58e0 lib/igt_debugfs: Remove support for

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Introduce execlist_port_* accessors

2017-11-02 Thread Chris Wilson
Quoting Mika Kuoppala (2017-11-02 14:32:38) > From: Mika Kuoppala > > Instead of trusting that first available port is at index 0, > use accessor to hide this. This is a preparation for a > following patches where head can be at arbitrary location > in the port array. >

Re: [Intel-gfx] [PATCH v3] drm/i915: Remove unsafe i915.enable_rc6

2017-11-02 Thread Joonas Lahtinen
On Thu, 2017-11-02 at 07:47 -0700, Rodrigo Vivi wrote: > On Thu, Nov 02, 2017 at 08:06:29AM +, Jani Nikula wrote: > > On Wed, 01 Nov 2017, Rodrigo Vivi wrote: > > > On Wed, Nov 01, 2017 at 04:21:08PM +, Ben Widawsky wrote: > > > > On 17-11-01 18:09:47, Joonas

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Stop caching the "golden" renderstate

2017-11-02 Thread Joonas Lahtinen
On Thu, 2017-11-02 at 07:54 -0700, Rodrigo Vivi wrote: > On Thu, Nov 02, 2017 at 02:43:16PM +, Joonas Lahtinen wrote: > > On Thu, 2017-11-02 at 12:42 +, Chris Wilson wrote: > > > As we now record the default HW state and so only emit the "golden" > > > renderstate once to prepare the HW,

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Move GT powersaving init to i915_gem_init()

2017-11-02 Thread Chris Wilson
Quoting Sagar Arun Kamble (2017-11-02 14:35:17) > > > On 11/2/2017 6:12 PM, Chris Wilson wrote: > > GT powersaving is tightly coupled to the request infrastructure. To > > avoid complications with the order of initialisation in the next patch > > (where we want to send requests to hw during GEM

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Stop caching the "golden" renderstate

2017-11-02 Thread Rodrigo Vivi
On Thu, Nov 02, 2017 at 02:43:16PM +, Joonas Lahtinen wrote: > On Thu, 2017-11-02 at 12:42 +, Chris Wilson wrote: > > As we now record the default HW state and so only emit the "golden" > > renderstate once to prepare the HW, there is no advantage in keeping the > > renderstate batch

Re: [Intel-gfx] [PATCH v3] drm/i915: Remove unsafe i915.enable_rc6

2017-11-02 Thread Rodrigo Vivi
On Thu, Nov 02, 2017 at 08:06:29AM +, Jani Nikula wrote: > On Wed, 01 Nov 2017, Rodrigo Vivi wrote: > > On Wed, Nov 01, 2017 at 04:21:08PM +, Ben Widawsky wrote: > >> On 17-11-01 18:09:47, Joonas Lahtinen wrote: > >> > + Kimmo and Paul > >> > > >> > On Wed,

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Remove support for legacy debugfs crc interface

2017-11-02 Thread Patchwork
== Series Details == Series: drm/i915: Remove support for legacy debugfs crc interface URL : https://patchwork.freedesktop.org/series/33053/ State : warning == Summary == Series 33053v1 drm/i915: Remove support for legacy debugfs crc interface

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Stop caching the "golden" renderstate

2017-11-02 Thread Joonas Lahtinen
On Thu, 2017-11-02 at 12:42 +, Chris Wilson wrote: > As we now record the default HW state and so only emit the "golden" > renderstate once to prepare the HW, there is no advantage in keeping the > renderstate batch around as it will never be used again. > > Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Record the default hw state after reset upon load

2017-11-02 Thread Chris Wilson
Quoting Ville Syrjälä (2017-11-02 14:23:00) > On Thu, Nov 02, 2017 at 12:42:24PM +, Chris Wilson wrote: > > Take a copy of the HW state after a reset upon module loading by > > executing a context switch from a blank context to the kernel context, > > thus saving the default hw state over the

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Move GT powersaving init to i915_gem_init()

2017-11-02 Thread Sagar Arun Kamble
On 11/2/2017 6:12 PM, Chris Wilson wrote: GT powersaving is tightly coupled to the request infrastructure. To avoid complications with the order of initialisation in the next patch (where we want to send requests to hw during GEM init) move the powersaving initialisation into the purview of

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Reject unknown syncobj flags (rev2)

2017-11-02 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Reject unknown syncobj flags (rev2) URL : https://patchwork.freedesktop.org/series/32893/ State : success == Summary == Test kms_flip: Subgroup plain-flip-ts-check-interruptible: pass -> FAIL

[Intel-gfx] [PATCH 1/2] drm/i915: Introduce execlist_port_* accessors

2017-11-02 Thread Mika Kuoppala
From: Mika Kuoppala Instead of trusting that first available port is at index 0, use accessor to hide this. This is a preparation for a following patches where head can be at arbitrary location in the port array. v2: improved commit message, elsp_ready readability

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Set up mocs tables before restarting the engines

2017-11-02 Thread Patchwork
== Series Details == Series: drm/i915: Set up mocs tables before restarting the engines URL : https://patchwork.freedesktop.org/series/33051/ State : success == Summary == Series 33051v1 drm/i915: Set up mocs tables before restarting the engines

Re: [Intel-gfx] [PATCH] drm/i915/dmc: DMC 1.04 for Kabylake

2017-11-02 Thread Rodrigo Vivi
On Thu, Nov 02, 2017 at 10:34:37AM +, Jani Nikula wrote: > On Wed, 01 Nov 2017, Anusha Srivatsa wrote: > > There is a new version of DMC available for KBL. > > Nobody's going to pull this to linux-firmware if you don't send it to > the linux-firmware folks...

Re: [Intel-gfx] [PATCH] drm/i915: Remove support for legacy debugfs crc interface

2017-11-02 Thread Ville Syrjälä
On Thu, Nov 02, 2017 at 02:56:51PM +0100, Maarten Lankhorst wrote: > This interface is deprecated, and has been replaced by the upstream > drm crc interface. Before we nuke this I would like to see an option in the new interface to not filter out the "bad" CRCs. When analyzing how the hardware

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Record the default hw state after reset upon load

2017-11-02 Thread Joonas Lahtinen
On Thu, 2017-11-02 at 12:42 +, Chris Wilson wrote: > Take a copy of the HW state after a reset upon module loading by > executing a context switch from a blank context to the kernel context, > thus saving the default hw state over the blank context image. > We can then use the default hw state

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Record the default hw state after reset upon load

2017-11-02 Thread Ville Syrjälä
On Thu, Nov 02, 2017 at 12:42:24PM +, Chris Wilson wrote: > Take a copy of the HW state after a reset upon module loading by > executing a context switch from a blank context to the kernel context, > thus saving the default hw state over the blank context image. > We can then use the default

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Introduce execlist_port_* accessors

2017-11-02 Thread Mika Kuoppala
Mika Kuoppala writes: > Chris Wilson writes: > >> Quoting Mika Kuoppala (2017-11-02 10:38:30) >>> Chris Wilson writes: >>> >>> > Quoting Mika Kuoppala (2017-10-31 15:27:33) >>> >> +static inline struct

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Introduce execlist_port_* accessors

2017-11-02 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2017-11-02 10:38:30) >> Chris Wilson writes: >> >> > Quoting Mika Kuoppala (2017-10-31 15:27:33) >> >> +static inline struct execlist_port * >> >> +execlists_port_next(struct

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: DMC 1.04 for Kabylake

2017-11-02 Thread Patchwork
== Series Details == Series: drm/i915/dmc: DMC 1.04 for Kabylake URL : https://patchwork.freedesktop.org/series/33022/ State : success == Summary == Series 33022v1 drm/i915/dmc: DMC 1.04 for Kabylake https://patchwork.freedesktop.org/api/1.0/series/33022/revisions/1/mbox/ Test

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Record the default hw state after reset upon load

2017-11-02 Thread Chris Wilson
Quoting Mika Kuoppala (2017-11-02 13:56:50) > Chris Wilson writes: > > - > > - execlists_init_reg_state(vaddr + LRC_STATE_PN * PAGE_SIZE, > > - ctx, engine, ring); > > + regs = vaddr + LRC_STATE_PN * PAGE_SIZE; > > +

[Intel-gfx] [PATCH] drm/i915: Remove support for legacy debugfs crc interface

2017-11-02 Thread Maarten Lankhorst
This interface is deprecated, and has been replaced by the upstream drm crc interface. Signed-off-by: Maarten Lankhorst Cc: Tomi Sarvela Cc: Petri Latvala Cc: Jani Nikula ---

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Record the default hw state after reset upon load

2017-11-02 Thread Mika Kuoppala
Chris Wilson writes: > Take a copy of the HW state after a reset upon module loading by > executing a context switch from a blank context to the kernel context, > thus saving the default hw state over the blank context image. > We can then use the default hw state to

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Inline intel_modeset_gem_init()

2017-11-02 Thread Joonas Lahtinen
On Thu, 2017-11-02 at 12:42 +, Chris Wilson wrote: > intel_modeset_gem_init() now only sets up the legacy overlay, so let's > remove the function and call the setup directly during driver load. This > should help us find a better point in the initialisation sequence for it > later. > >

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: silence coverity warning (rev2)

2017-11-02 Thread Patchwork
== Series Details == Series: drm/i915: silence coverity warning (rev2) URL : https://patchwork.freedesktop.org/series/33041/ State : warning == Summary == Test kms_busy: Subgroup extended-modeset-hang-oldfb-with-reset-render-A: pass -> DMESG-WARN (shard-hsw) Test

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Move GT powersaving init to i915_gem_init()

2017-11-02 Thread Joonas Lahtinen
On Thu, 2017-11-02 at 12:42 +, Chris Wilson wrote: > GT powersaving is tightly coupled to the request infrastructure. To > avoid complications with the order of initialisation in the next patch > (where we want to send requests to hw during GEM init) move the > powersaving initialisation into

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Force the switch to the i915->kernel_context

2017-11-02 Thread Joonas Lahtinen
On Thu, 2017-11-02 at 12:42 +, Chris Wilson wrote: > In the next few patches, we will have a hard requirement that we emit a > context-switch to the perma-pinned i915->kernel_context (so that we can > save the HW state using that context-switch). As the first context > itself may be classed as

Re: [Intel-gfx] [PATCH] drm/i915: silence coverity warning

2017-11-02 Thread Chris Wilson
Quoting Ville Syrjälä (2017-11-02 13:22:51) > On Thu, Nov 02, 2017 at 12:06:27PM +, Chris Wilson wrote: > > Quoting Lionel Landwerlin (2017-11-02 11:41:26) > > > Because dev_priv is 0-ed it's not currently an issue, but since we > > > have dev_priv->perf.oa.test_config.uuid size at uuid + 1,

[Intel-gfx] [PATCH i-g-t] kms_atomic_transition: Split out modeset tests on internal panels

2017-11-02 Thread Imre Deak
Doing modeset on internal panels may have a considerable overhead due to the panel specific power sequencing delays. To avoid long test runtimes in the CI fast-feedback test split out the testing of internal panels from the plane modeset subtests. Create fast and slow versions of these new

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Remove redundant intel_autoenable_gt_powersave()

2017-11-02 Thread Joonas Lahtinen
On Thu, 2017-11-02 at 12:42 +, Chris Wilson wrote: > Now that we always execute a context switch upon module load, there is > no need to queue a delayed task for doing so. The purpose of the delayed > task is to enable GT powersaving, for which we need the HW state to be > valid (i.e. having

Re: [Intel-gfx] [PATCH i-g-t] kms_atomic_transition: Add subtest time limit/randomize plane, pipe combinations

2017-11-02 Thread Imre Deak
On Wed, Nov 01, 2017 at 01:08:47PM +0200, Imre Deak wrote: > On Wed, Nov 01, 2017 at 10:48:50AM +, Chris Wilson wrote: > > Quoting Imre Deak (2017-11-01 09:56:22) > > > On Tue, Oct 31, 2017 at 10:23:25PM +, Chris Wilson wrote: > > > > Quoting Imre Deak (2017-10-31 13:44:47) > > > > > Doing

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for tests: add device information tests

2017-11-02 Thread Arkadiusz Hiler
On Tue, Oct 31, 2017 at 11:02:46AM +, Lionel Landwerlin wrote: > On 31/10/17 09:21, Petri Latvala wrote: > > On Mon, Oct 30, 2017 at 02:11:10PM +, Patchwork wrote: > > > == Series Details == > > > > > > Series: tests: add device information tests > > > URL :

Re: [Intel-gfx] [PATCH] drm/i915: silence coverity warning

2017-11-02 Thread Ville Syrjälä
On Thu, Nov 02, 2017 at 12:06:27PM +, Chris Wilson wrote: > Quoting Lionel Landwerlin (2017-11-02 11:41:26) > > Because dev_priv is 0-ed it's not currently an issue, but since we > > have dev_priv->perf.oa.test_config.uuid size at uuid + 1, we could > > just copy the null character and silence

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_debugfs: Remove support for legacy CRC api.

2017-11-02 Thread Maarten Lankhorst
Op 27-10-17 om 14:25 schreef Petri Latvala: > On Fri, Oct 27, 2017 at 10:05:39AM +0200, Maarten Lankhorst wrote: >> Op 27-10-17 om 09:39 schreef Jani Nikula: >>> On Thu, 26 Oct 2017, James Ausmus wrote: On Thu, Oct 26, 2017 at 01:38:51PM +0200, Maarten Lankhorst

Re: [Intel-gfx] [PATCH 3/5] drm/vmwgfx: Try to fix plane clipping

2017-11-02 Thread Ville Syrjälä
On Thu, Nov 02, 2017 at 11:12:09AM +0100, Daniel Vetter wrote: > On Wed, Nov 01, 2017 at 08:29:18PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Try to fix the code to actually clip the plane to the crtc bounds > > instead of the user provided crtc

[Intel-gfx] [PATCH] drm/i915: Set up mocs tables before restarting the engines

2017-11-02 Thread Chris Wilson
After a reset, we may immediately begin executing requests on restarting the engines. Ergo this has to be last step with all re-initialisation completed beforehand. The mocs setup was after we started executing the requests; do it earlier! Signed-off-by: Chris Wilson

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/6] drm/i915: Force the switch to the i915->kernel_context

2017-11-02 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: Force the switch to the i915->kernel_context URL : https://patchwork.freedesktop.org/series/33046/ State : failure == Summary == Series 33046v1 series starting with [1/6] drm/i915: Force the switch to the i915->kernel_context

  1   2   >