[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Wrap engine->schedule in RCU locks for set-wedge protection

2018-03-03 Thread Patchwork
== Series Details == Series: drm/i915: Wrap engine->schedule in RCU locks for set-wedge protection URL : https://patchwork.freedesktop.org/series/39324/ State : success == Summary == Known issues: Test gem_eio: Subgroup in-flight-external: incomplete -> PASS

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Stop engines around GPU reset preparations (rev2)

2018-03-03 Thread Patchwork
== Series Details == Series: drm/i915: Stop engines around GPU reset preparations (rev2) URL : https://patchwork.freedesktop.org/series/39261/ State : failure == Summary == Possible new issues: Test drv_selftest: Subgroup live_hangcheck: pass -> INCOMPLETE

Re: [Intel-gfx] [PATCH igt 2/5] igt/gem_spin_batch: Avoid waiting when running concurrently

2018-03-03 Thread Chris Wilson
Quoting Chris Wilson (2018-02-28 15:51:35) > If we do a global wait while trying to execute spinners in parallel, > it ends badly with a GPU hang. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104352 > Signed-off-by: Chris Wilson Pretty please? -Chris >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Wrap engine->schedule in RCU locks for set-wedge protection

2018-03-03 Thread Patchwork
== Series Details == Series: drm/i915: Wrap engine->schedule in RCU locks for set-wedge protection URL : https://patchwork.freedesktop.org/series/39324/ State : success == Summary == Series 39324v1 drm/i915: Wrap engine->schedule in RCU locks for set-wedge protection

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/uc: Introduce intel_uc_suspend|resume

2018-03-03 Thread Chris Wilson
Quoting Michal Wajdeczko (2018-03-02 11:15:49) > We want to use higher level 'uc' functions as the main entry points to > the GuC/HuC code to hide some details and keep code layered. > > While here, move call to disable_guc_interrupts after sending suspend > action to the GuC to allow it work

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/huc: Mark firmware as failed on auth failure

2018-03-03 Thread Chris Wilson
Quoting Michal Wajdeczko (2018-03-02 13:37:17) > If we fail to authenticate HuC firmware, we should change > its load status to FAIL. While around, print HUC_STATUS > on firmware verification failure. > > v2: keep the variables sorted by length (Chris) > > Signed-off-by: Michal Wajdeczko

Re: [Intel-gfx] [PATCH 2/3] drm/i915/error: standardize function style in error capture

2018-03-03 Thread Chris Wilson
Quoting Chris Wilson (2018-03-03 09:54:02) > Quoting Michal Wajdeczko (2018-03-02 20:07:54) > > On Fri, 02 Mar 2018 20:19:29 +0100, Daniele Ceraolo Spurio > > wrote: > > > > > some of the static functions used from capture() have the "i915_" > > > prefix while

Re: [Intel-gfx] [PATCH 3/3] drm/i915/error: capture uc_state after gen_state

2018-03-03 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2018-03-02 19:19:30) > error->device_info.has_guc, which we check in capture_uc_state, is set > in capture_gen_state, so the latter needs to be performed first. > > Reported-by: Vinay Belgaumkar > Cc: Vinay Belgaumkar

Re: [Intel-gfx] [PATCH 2/3] drm/i915/error: standardize function style in error capture

2018-03-03 Thread Chris Wilson
Quoting Michal Wajdeczko (2018-03-02 20:07:54) > On Fri, 02 Mar 2018 20:19:29 +0100, Daniele Ceraolo Spurio > wrote: > > > some of the static functions used from capture() have the "i915_" > > prefix while other don't; most of them take i915 as a parameter, but

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Stop engines around GPU reset preparations (rev2)

2018-03-03 Thread Patchwork
== Series Details == Series: drm/i915: Stop engines around GPU reset preparations (rev2) URL : https://patchwork.freedesktop.org/series/39261/ State : success == Summary == Series 39261v2 drm/i915: Stop engines around GPU reset preparations

Re: [Intel-gfx] [PATCH 1/3] drm/i915/error: remove unused gen8_engine_sync_index

2018-03-03 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2018-03-02 19:19:28) > Leftover from Gen8 ringbuffer support removal > > Cc: Chris Wilson > Signed-off-by: Daniele Ceraolo Spurio Reviewed-by: Chris Wilson -Chris

Re: [Intel-gfx] [PATCH 1/1] intel: align reuse buffer's size on page size instead

2018-03-03 Thread Chris Wilson
Quoting James Xiong (2018-03-02 17:53:04) > From: "Xiong, James" > > With gem_reuse enabled, when a buffer size is different than > the sizes of buckets, it is aligned to the next bucket's size, > which means about 25% more memory than the requested is allocated > in the

[Intel-gfx] [PATCH] drm/i915: Wrap engine->schedule in RCU locks for set-wedge protection

2018-03-03 Thread Chris Wilson
Similar to the staging around handling of engine->submit_request, we need to stop adding to the execlists->queue prior to calling engine->cancel_requests. cancel_requests will move requests from the queue onto the timeline, so if we add a request onto the queue after that point, it will be lost.

[Intel-gfx] [PATCH] drm/i915: Stop engines around GPU reset preparations

2018-03-03 Thread Chris Wilson
As we make preparations to reset the GPU state, we assume that the GPU is hung and will not advance. Make this assumption more explicit by setting the STOP_RING bit on the engines as part of our early reset preparations. v2: Move intel_gpu_reset_(prepare|finish) to

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Stop engines around GPU reset preparations

2018-03-03 Thread Chris Wilson
Quoting Chris Wilson (2018-03-02 14:32:42) > As we make preparations to reset the GPU state, we assume that the GPU > is hung and will not advance. Make this assumption more explicit by > setting the STOP_RING bit on the engines as part of our early reset > preparations. I had to drop this one as