[Intel-gfx] Warning for driver i915 for 4.17.0-rcX

2018-04-30 Thread Larry Finger
With kernel 4.17.0-rc3, I noted the following warning from driver i915. kernel: [ cut here ] kernel: Could not determine valid watermarks for inherited state kernel: WARNING: CPU: 3 PID: 224 at drivers/gpu/drm/i915/intel_display.c:14584 intel_modeset_init+0x3be/0x1060

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/edp: Only use alternate fixed mode when requested (rev3)

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915/edp: Only use alternate fixed mode when requested (rev3) URL : https://patchwork.freedesktop.org/series/41492/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4116_full -> Patchwork_8850_full = == Summary - WARNING == Minor unknown

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/firmware: Correct URL for firmware

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915/firmware: Correct URL for firmware URL : https://patchwork.freedesktop.org/series/42497/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4115_full -> Patchwork_8849_full = == Summary - FAILURE == Serious unknown changes coming with

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Unconditionally disable/enable dpll0 and apply WA1183 when changing cdclk.

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915: Unconditionally disable/enable dpll0 and apply WA1183 when changing cdclk. URL : https://patchwork.freedesktop.org/series/42500/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4116 -> Patchwork_8851 = == Summary - FAILURE ==

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Unconditionally disable/enable dpll0 and apply WA1183 when changing cdclk.

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915: Unconditionally disable/enable dpll0 and apply WA1183 when changing cdclk. URL : https://patchwork.freedesktop.org/series/42500/ State : warning == Summary == $ dim checkpatch origin/drm-tip f1546a78be1b drm/i915: Unconditionally disable/enable dpll0

[Intel-gfx] [PATCH] drm/i915: Unconditionally disable/enable dpll0 and apply WA1183 when changing cdclk.

2018-04-30 Thread Rodrigo Vivi
I believe I finally got the platform/panel that WA1183 was targeting. WA 1183 aims to fix the cdclk change for "CD clock frequency 308.57 or 617.14 MHz" I faced one case here where the desired CDCLK to 308571 kHz, VCO 864 kHz doesn't stick, unless that we unconditionally disables and

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: remove check for aux irq (rev2)

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915: remove check for aux irq (rev2) URL : https://patchwork.freedesktop.org/series/42305/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4115_full -> Patchwork_8848_full = == Summary - WARNING == Minor unknown changes coming with

Re: [Intel-gfx] [PATCH] drm/i915/firmware: Correct URL for firmware

2018-04-30 Thread Rodrigo Vivi
On Mon, Apr 30, 2018 at 03:59:28PM -0700, Anusha Srivatsa wrote: > Replace 01.org URL with upstream linux-firmware repo URL. > We no longer release firmware to 01.org. > linux-firmware.git is the ultimate place to find > the i915 firmwares. > > Cc: Rodrigo Vivi >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/edp: Only use alternate fixed mode when requested (rev3)

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915/edp: Only use alternate fixed mode when requested (rev3) URL : https://patchwork.freedesktop.org/series/41492/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4116 -> Patchwork_8850 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/edp: Only use alternate fixed mode when requested (rev3)

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915/edp: Only use alternate fixed mode when requested (rev3) URL : https://patchwork.freedesktop.org/series/41492/ State : warning == Summary == $ dim checkpatch origin/drm-tip 467a1ee16409 drn/i915/edp: Only use alternate fixed mode when requested -:30:

[Intel-gfx] [PATCH V3] drn/i915/edp: Only use alternate fixed mode when requested

2018-04-30 Thread clinton . a . taylor
From: Clint Taylor In commit dc911f5bd8aa ("drm/i915/edp: Allow alternate fixed mode for eDP if available."), the patch was always selecting the alternate refresh rate even though user space was asking for the higher rate. This patch confirms the alt mode setup time

Re: [Intel-gfx] [PATCH v2 7/9] drm/i915/dp: Move code to check if aux ch is busy to a function

2018-04-30 Thread Souza, Jose
On Thu, 2018-04-26 at 15:51 -0700, Dhinakaran Pandiyan wrote: > > > On Wed, 2018-04-18 at 15:43 -0700, José Roberto de Souza wrote: > > This reduces the spaghetti that intel_dp_aux_xfer(). > > > > Moved doing less changes possible here, improvements to the new > > function in further patch. > >

Re: [Intel-gfx] [PATCH 3/5] drm/i915/icl/guc: Define the GuC firmware version for Icelake

2018-04-30 Thread John Spotswood
On Fri, 2018-04-27 at 14:31 -0700, Oscar Mateo wrote: > A GuC firmware for Icelake is now available. Let's use it. > > v2: Split out the Cannonlake stuff in a separate patch (Michal) > > v3: Rebased > > v4: >   - Rebased >   - Split out MODULE_FIRMWARE so we don't accidentally push it >

Re: [Intel-gfx] [PATCH 2/5] drm/i915/icl/guc: Pass the bare minimum GuC init parameters for Icelake

2018-04-30 Thread John Spotswood
On Fri, 2018-04-27 at 14:31 -0700, Oscar Mateo wrote: > Only enough to achieve HuC authentication. No GuC submission > or any other feature for the time being. > > Signed-off-by: Oscar Mateo > Cc: Joonas Lahtinen > Cc: Michal Wajdeczko

Re: [Intel-gfx] [PATCH v2 5/9] drm/i915/psr: Handle PSR RFB storage error

2018-04-30 Thread Souza, Jose
On Thu, 2018-04-26 at 15:37 -0700, Dhinakaran Pandiyan wrote: > > > On Wed, 2018-04-18 at 15:43 -0700, José Roberto de Souza wrote: > > Sink will interrupt source when it have any problem saving or > > reading > > the remote frame buffer. > > > > Signed-off-by: José Roberto de Souza

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/firmware: Correct URL for firmware

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915/firmware: Correct URL for firmware URL : https://patchwork.freedesktop.org/series/42497/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4115 -> Patchwork_8849 = == Summary - SUCCESS == No regressions found. External URL:

Re: [Intel-gfx] [PATCH v2 4/9] drm/i915/psr: Begin to handle PSR/PSR2 errors set by sink

2018-04-30 Thread Souza, Jose
On Thu, 2018-04-26 at 15:29 -0700, Dhinakaran Pandiyan wrote: > > > On Wed, 2018-04-18 at 15:43 -0700, José Roberto de Souza wrote: > > eDP spec states that sink device will do a short pulse in HPD > > line when there is a PSR/PSR2 error that needs to be handled by > > source, this is handling

[Intel-gfx] [PATCH] drm/i915/firmware: Correct URL for firmware

2018-04-30 Thread Anusha Srivatsa
Replace 01.org URL with upstream linux-firmware repo URL. We no longer release firmware to 01.org. linux-firmware.git is the ultimate place to find the i915 firmwares. Cc: Rodrigo Vivi Signed-off-by: Anusha Srivatsa ---

Re: [Intel-gfx] [PATCH v2 1/9] drm/i915/psr: Move specific HSW+ WARN_ON to HSW+ function

2018-04-30 Thread Souza, Jose
On Wed, 2018-04-25 at 17:41 -0700, Dhinakaran Pandiyan wrote: > On Wednesday, April 18, 2018 3:43:03 PM PDT José Roberto de Souza > wrote: > > It was reading some random register in VLV and CHV. > > > > Signed-off-by: José Roberto de Souza > > Cc: Dhinakaran Pandiyan

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: remove check for aux irq (rev2)

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915: remove check for aux irq (rev2) URL : https://patchwork.freedesktop.org/series/42305/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4115 -> Patchwork_8848 = == Summary - WARNING == Minor unknown changes coming with Patchwork_8848

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: remove check for aux irq (rev2)

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915: remove check for aux irq (rev2) URL : https://patchwork.freedesktop.org/series/42305/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: remove check for aux irq -drivers/gpu/drm/i915/selftests/../i915_drv.h:3663:16: warning:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: remove check for aux irq (rev2)

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915: remove check for aux irq (rev2) URL : https://patchwork.freedesktop.org/series/42305/ State : warning == Summary == $ dim checkpatch origin/drm-tip 83b37e765db4 drm/i915: remove check for aux irq -:15: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped

Re: [Intel-gfx] [PATCH v2] drm/i915: Disable some extra clang warnings

2018-04-30 Thread Matthias Kaehlcke
On Mon, Apr 30, 2018 at 10:01:50PM +0100, Chris Wilson wrote: > Quoting Matthias Kaehlcke (2018-04-30 21:51:45) > > On Mon, Apr 30, 2018 at 09:01:49PM +0100, Chris Wilson wrote: > > > Quoting Matthias Kaehlcke (2018-04-30 20:31:19) > > > > On Mon, Mar 19, 2018 at 12:14:51PM -0700, Matthias

[Intel-gfx] ✓ Fi.CI.IGT: success for input/psmouse: Don't hold the mutex while calling ->disconnect (rev2)

2018-04-30 Thread Patchwork
== Series Details == Series: input/psmouse: Don't hold the mutex while calling ->disconnect (rev2) URL : https://patchwork.freedesktop.org/series/40259/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4113_full -> Patchwork_8846_full = == Summary - WARNING == Minor

Re: [Intel-gfx] [PATCH] drm/i915: remove check for aux irq

2018-04-30 Thread Lucas De Marchi
On Thu, Apr 26, 2018 at 06:50:05PM +0300, Ville Syrjälä wrote: > On Thu, Apr 26, 2018 at 08:42:54AM -0700, Lucas De Marchi wrote: > > On Thu, Apr 26, 2018 at 06:27:26PM +0300, Ville Syrjälä wrote: > > > On Thu, Apr 26, 2018 at 08:22:12AM -0700, Lucas De Marchi wrote: > > > > On Thu, Apr 26, 2018

Re: [Intel-gfx] [PATCH] drm/i915/edp: Only use alternate fixed mode when requested

2018-04-30 Thread Clint Taylor
On 04/30/2018 12:49 AM, Jani Nikula wrote: On Sat, 14 Apr 2018, "Vivi, Rodrigo" wrote: On Apr 12, 2018, at 2:21 PM, Taylor, Clinton A wrote: On 04/11/2018 04:11 PM, Chris Wilson wrote: Quoting clinton.a.tay...@intel.com (2018-04-12

Re: [Intel-gfx] [PATCH] input/psmouse: Don't hold the mutex while calling ->disconnect

2018-04-30 Thread Dmitry Torokhov
Hi Daniel, On Mon, Apr 30, 2018 at 09:56:49PM +0200, Daniel Vetter wrote: > At least trackpoint_disconnect wants to remove some sysfs files, and > we can't remove sysfs files while holding psmouse_mutex: > > == > WARNING: possible circular

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] drm/i915: Move timeline from GTT to ring

2018-04-30 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Move timeline from GTT to ring URL : https://patchwork.freedesktop.org/series/42491/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4114 -> Patchwork_8847 = == Summary - FAILURE == Serious unknown

Re: [Intel-gfx] [PATCH v2] drm/i915: Disable some extra clang warnings

2018-04-30 Thread Chris Wilson
Quoting Matthias Kaehlcke (2018-04-30 21:51:45) > On Mon, Apr 30, 2018 at 09:01:49PM +0100, Chris Wilson wrote: > > Quoting Matthias Kaehlcke (2018-04-30 20:31:19) > > > On Mon, Mar 19, 2018 at 12:14:51PM -0700, Matthias Kaehlcke wrote: > > > > Commit 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/2] drm/i915: Move timeline from GTT to ring

2018-04-30 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Move timeline from GTT to ring URL : https://patchwork.freedesktop.org/series/42491/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Move timeline from GTT to ring

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915: Move timeline from GTT to ring

2018-04-30 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Move timeline from GTT to ring URL : https://patchwork.freedesktop.org/series/42491/ State : warning == Summary == $ dim checkpatch origin/drm-tip f70295e570a3 drm/i915: Move timeline from GTT to ring c1e97fa27868 drm/i915:

Re: [Intel-gfx] [PATCH v2] drm/i915: Disable some extra clang warnings

2018-04-30 Thread Matthias Kaehlcke
On Mon, Apr 30, 2018 at 09:01:49PM +0100, Chris Wilson wrote: > Quoting Matthias Kaehlcke (2018-04-30 20:31:19) > > On Mon, Mar 19, 2018 at 12:14:51PM -0700, Matthias Kaehlcke wrote: > > > Commit 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set > > > warnings to full") enabled extra

[Intel-gfx] ✓ Fi.CI.BAT: success for input/psmouse: Don't hold the mutex while calling ->disconnect (rev2)

2018-04-30 Thread Patchwork
== Series Details == Series: input/psmouse: Don't hold the mutex while calling ->disconnect (rev2) URL : https://patchwork.freedesktop.org/series/40259/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4113 -> Patchwork_8846 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] [CI 2/2] drm/i915: Split i915_gem_timeline into individual timelines

2018-04-30 Thread Chris Wilson
We need to move to a more flexible timeline that doesn't assume one fence context per engine, and so allow for a single timeline to be used across a combination of engines. This means that preallocating a fence context per engine is now a hindrance, and so we want to introduce the singular

[Intel-gfx] [CI 1/2] drm/i915: Move timeline from GTT to ring

2018-04-30 Thread Chris Wilson
In the future, we want to move a request between engines. To achieve this, we first realise that we have two timelines in effect here. The first runs through the GTT is required for ordering vma access, which is tracked currently by engine. The second is implied by sequential execution of commands

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for input/psmouse: Don't hold the mutex while calling ->disconnect (rev2)

2018-04-30 Thread Patchwork
== Series Details == Series: input/psmouse: Don't hold the mutex while calling ->disconnect (rev2) URL : https://patchwork.freedesktop.org/series/40259/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8a1511bf4ec1 input/psmouse: Don't hold the mutex while calling ->disconnect

Re: [Intel-gfx] [PATCH v2] drm/i915: Disable some extra clang warnings

2018-04-30 Thread Chris Wilson
Quoting Matthias Kaehlcke (2018-04-30 20:31:19) > On Mon, Mar 19, 2018 at 12:14:51PM -0700, Matthias Kaehlcke wrote: > > Commit 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set > > warnings to full") enabled extra warnings for i915 to spot possible > > bugs in new code, and then

[Intel-gfx] [PATCH] input/psmouse: Don't hold the mutex while calling ->disconnect

2018-04-30 Thread Daniel Vetter
At least trackpoint_disconnect wants to remove some sysfs files, and we can't remove sysfs files while holding psmouse_mutex: == WARNING: possible circular locking dependency detected 4.16.0-rc5-g613eb885b69e-drmtip_1+ #1 Tainted: G U

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Fix rounding errors and use scaling in i915.

2018-04-30 Thread Patchwork
== Series Details == Series: drm: Fix rounding errors and use scaling in i915. URL : https://patchwork.freedesktop.org/series/42476/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4113_full -> Patchwork_8845_full = == Summary - WARNING == Minor unknown changes coming

Re: [Intel-gfx] [PATCH 13/17] drm/radeon: Remove custom dma_fence_ops->wait implementation

2018-04-30 Thread Daniel Vetter
On Mon, Apr 30, 2018 at 8:26 PM, Christian König wrote: > Am 30.04.2018 um 17:38 schrieb Daniel Vetter: >> >> On Sun, Apr 29, 2018 at 09:08:31AM +0200, Christian König wrote: >>> >>> NAK, there is a subtitle but major difference: >>> - if

Re: [Intel-gfx] [PATCH v2] drm/i915: Disable some extra clang warnings

2018-04-30 Thread Matthias Kaehlcke
On Mon, Mar 19, 2018 at 12:14:51PM -0700, Matthias Kaehlcke wrote: > Commit 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set > warnings to full") enabled extra warnings for i915 to spot possible > bugs in new code, and then disabled a subset of these warnings to keep > the current code

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/4] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-30 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915: Stop tracking timeline->inflight_seqnos URL : https://patchwork.freedesktop.org/series/42474/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4113_full -> Patchwork_8844_full = == Summary - WARNING ==

Re: [Intel-gfx] [PATCH v5 0/6] Enable NV12 support

2018-04-30 Thread Kristian Høgsberg
On Thu, Apr 19, 2018 at 3:34 AM Vidya Srinivas wrote: > Enabling NV12 support: > - Framebuffer creation > - Primary and Sprite plane support > Patch series depend on Enable display workaround 827 patch > mentioned below submitted by Maarten How are we looking on being

Re: [Intel-gfx] [PATCH 13/17] drm/radeon: Remove custom dma_fence_ops->wait implementation

2018-04-30 Thread Christian König
Am 30.04.2018 um 17:38 schrieb Daniel Vetter: On Sun, Apr 29, 2018 at 09:08:31AM +0200, Christian König wrote: NAK, there is a subtitle but major difference: - if (rdev->needs_reset) { - t = -EDEADLK; - break; - }

Re: [Intel-gfx] [PATCH] drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled

2018-04-30 Thread Du,Wenkai
On 4/29/2018 1:39 PM, Abhay Kumar wrote: CDCLK has to be at least twice the BLCK regardless of audio. Audio driver has to probe using this hook and increase the clock even in absence of any display. Signed-off-by: Ville Syrjälä Signed-off-by: Abhay Kumar

Re: [Intel-gfx] [PATCH v2 RESEND] drm/i915: add support for specifying DMC firmware override by module param

2018-04-30 Thread Srivatsa, Anusha
>-Original Message- >From: Nikula, Jani >Sent: Monday, April 30, 2018 3:47 AM >To: intel-gfx@lists.freedesktop.org >Cc: Srivatsa, Anusha ; David Weinehall > >Subject: Re: [PATCH v2 RESEND] drm/i915: add support for specifying

Re: [Intel-gfx] [PATCH] drm/i915: configure the transcoder clocks before touching pipeconf on HSW+

2018-04-30 Thread Ville Syrjälä
On Fri, Apr 27, 2018 at 04:12:08PM -0700, Paulo Zanoni wrote: > For all platforms that run haswell_crtc_enable, our spec tells us to > configure the transcoder clocks before it tells us to set pipeconf and > the other pipe/transcoder/plane registers. > > For some reason we've been able to get

Re: [Intel-gfx] [PATCH v2 RESEND] drm/i915: add support for specifying DMC firmware override by module param

2018-04-30 Thread Srivatsa, Anusha
>-Original Message- >From: Nikula, Jani >Sent: Monday, April 30, 2018 3:47 AM >To: intel-gfx@lists.freedesktop.org >Cc: Srivatsa, Anusha ; David Weinehall > >Subject: Re: [PATCH v2 RESEND] drm/i915: add support for specifying

Re: [Intel-gfx] [PATCH 16/17] drm/virtio: Remove unecessary dma_fence_ops

2018-04-30 Thread Eric Anholt
Daniel Vetter writes: > dma_fence_default_wait is the default now, same for the trivial > enable_signaling implementation. Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ Intel-gfx

Re: [Intel-gfx] [PATCH 12/17] drm/qxl: Remove unecessary dma_fence_ops

2018-04-30 Thread Eric Anholt
Daniel Vetter writes: > dma_fence_default_wait is the default now, same for the trivial > enable_signaling implementation. Drop the mention of dma_fence_default_wait, since this one doesn't use that? Other than that, Reviewed-by: Eric Anholt

Re: [Intel-gfx] [PATCH 07/17] drm: Remove unecessary dma_fence_ops

2018-04-30 Thread Eric Anholt
Daniel Vetter writes: > dma_fence_default_wait is the default now, same for the trivial > enable_signaling implementation. > > Signed-off-by: Daniel Vetter Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [Intel-gfx] [PATCH 14/17] drm/vc4: Remove unecessary dma_fence_ops

2018-04-30 Thread Eric Anholt
Daniel Vetter writes: > dma_fence_default_wait is the default now, same for the trivial > enable_signaling implementation. > > Signed-off-by: Daniel Vetter Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [Intel-gfx] [PATCH 02/17] dma-fence: remove fill_driver_data callback

2018-04-30 Thread Eric Anholt
Daniel Vetter writes: > Noticed while I was typing docs. Entirely unused. > > Signed-off-by: Daniel Vetter > --- > include/linux/dma-fence.h | 10 -- > 1 file changed, 10 deletions(-) > > diff --git a/include/linux/dma-fence.h

Re: [Intel-gfx] [PATCH 01/17] dma-fence: Some kerneldoc polish for dma-fence.h

2018-04-30 Thread Eric Anholt
Daniel Vetter writes: > + /** > + * @fill_driver_data: > + * > + * Callback to fill in free-form debug info Returns amount of bytes > + * filled, or negative error on failure. Maybe this "Returns" should be on a new line? Or at least a '.' in

Re: [Intel-gfx] [PATCH] drm/i915: Wait for PSR exit before checking for vblank evasion for an atomic update

2018-04-30 Thread Rodrigo Vivi
On Sun, Apr 29, 2018 at 09:00:18PM -0700, Tarun Vyas wrote: > From: Tarun > > The PIPEDSL freezes on PSR entry and if PSR hasn't fully exited, then > the pipe_update_start call schedules itself out to check back later. > > On ChromeOS-4.4 kernel, which is fairly up-to-date

Re: [Intel-gfx] [PATCH 01/22] drm/i915/icl: Introduce initial Icelake Workarounds

2018-04-30 Thread Oscar Mateo
On 04/26/2018 08:01 AM, Mika Kuoppala wrote: Oscar Mateo writes: Inherit workarounds from previous platforms that are still valid for Icelake. v2: GEN7_ROW_CHICKEN2 is masked v3: - Since it has been fixed already in upstream, removed the TODO comment about

Re: [Intel-gfx] [PATCH 03/22] drm/i915/icl: WaGAPZPriorityScheme

2018-04-30 Thread Oscar Mateo
On 04/26/2018 08:27 AM, Mika Kuoppala wrote: Oscar Mateo writes: The default GAPZ arbitrer priority value at power-on has been found to be incorrect. v2: Now renamed to Wa_1405543622 v3: Rebased on top of the WA refactoring I have suggested that when implementing

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: configure the transcoder clocks before touching pipeconf on HSW+

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915: configure the transcoder clocks before touching pipeconf on HSW+ URL : https://patchwork.freedesktop.org/series/42436/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4112_full -> Patchwork_8843_full = == Summary - SUCCESS == No

Re: [Intel-gfx] [PATCH v4] drm/i915/lrc: Scrub the GPU state of the guilty hanging request

2018-04-30 Thread Chris Wilson
Quoting Michel Thierry (2018-04-30 16:49:53) > On 04/28/2018 04:15 AM, Chris Wilson wrote: > > Previously, we just reset the ring register in the context image such > > that we could skip over the broken batch and emit the closing > > breadcrumb. However, on resume the context image and GPU state

Re: [Intel-gfx] [PATCH v4] drm/i915/lrc: Scrub the GPU state of the guilty hanging request

2018-04-30 Thread Michel Thierry
On 04/28/2018 04:15 AM, Chris Wilson wrote: Previously, we just reset the ring register in the context image such that we could skip over the broken batch and emit the closing breadcrumb. However, on resume the context image and GPU state would be reloaded, which may have been left in an

Re: [Intel-gfx] [PATCH 13/17] drm/radeon: Remove custom dma_fence_ops->wait implementation

2018-04-30 Thread Daniel Vetter
On Sun, Apr 29, 2018 at 09:08:31AM +0200, Christian König wrote: > NAK, there is a subtitle but major difference: > > > - if (rdev->needs_reset) { > > - t = -EDEADLK; > > - break; > > - } > > Without that the whole radeon GPU reset code

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: configure the transcoder clocks before touching pipeconf on HSW+

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915: configure the transcoder clocks before touching pipeconf on HSW+ URL : https://patchwork.freedesktop.org/series/42436/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4112_full -> Patchwork_8842_full = == Summary - SUCCESS == No

Re: [Intel-gfx] [PATCH 04/17] dma-fence: Allow wait_any_timeout for all fences

2018-04-30 Thread Daniel Vetter
On Sun, Apr 29, 2018 at 09:11:31AM +0200, Christian König wrote: > Am 27.04.2018 um 08:17 schrieb Daniel Vetter: > > When this was introduced in > > > > commit a519435a96597d8cd96123246fea4ae5a6c90b02 > > Author: Christian König > > Date: Tue Oct 20 16:34:16 2015

Re: [Intel-gfx] [PATCH v7 1/2] drm: content-type property for HDMI connector

2018-04-30 Thread Daniel Vetter
On Fri, Apr 27, 2018 at 10:40:00PM +0300, Ville Syrjälä wrote: > On Mon, Apr 23, 2018 at 10:34:41AM +0300, StanLis wrote: > > From: Stanislav Lisovskiy > > > > Added content_type property to drm_connector_state > > in order to properly handle external HDMI TV

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Print error state times relative to capture (rev3)

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915: Print error state times relative to capture (rev3) URL : https://patchwork.freedesktop.org/series/41749/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4112_full -> Patchwork_8841_full = == Summary - WARNING == Minor unknown changes

Re: [Intel-gfx] [PATCH 1/8] drm/i915: expose helper mapping exec flag engine to intel_engine_cs

2018-04-30 Thread Lionel Landwerlin
On 25/04/18 12:50, Chris Wilson wrote: Quoting Lionel Landwerlin (2018-04-25 12:45:14) This function will be used later by the per (context,engine) power programming interface. No. This is not the appropriate uABI, please see intel_engine_lookup_user(). -Chris uAPI wise, does this sound

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] igt: Exercise creating context with shared GTT

2018-04-30 Thread Patchwork
== Series Details == Series: series starting with [1/4] igt: Exercise creating context with shared GTT URL : https://patchwork.freedesktop.org/series/42442/ State : failure == Summary == Applying: igt: Exercise creating context with shared GTT Using index info to reconstruct a base tree... M

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Fix rounding errors and use scaling in i915.

2018-04-30 Thread Patchwork
== Series Details == Series: drm: Fix rounding errors and use scaling in i915. URL : https://patchwork.freedesktop.org/series/42476/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4113 -> Patchwork_8845 = == Summary - WARNING == Minor unknown changes coming with

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: configure the transcoder clocks before touching pipeconf on HSW+

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915: configure the transcoder clocks before touching pipeconf on HSW+ URL : https://patchwork.freedesktop.org/series/42436/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4112_full -> Patchwork_8840_full = == Summary - SUCCESS == No

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: Fix rounding errors and use scaling in i915.

2018-04-30 Thread Patchwork
== Series Details == Series: drm: Fix rounding errors and use scaling in i915. URL : https://patchwork.freedesktop.org/series/42476/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/rect: Round above 1 << 16 upwards to correct scale calculation functions. Okay! Commit:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Fix rounding errors and use scaling in i915.

2018-04-30 Thread Patchwork
== Series Details == Series: drm: Fix rounding errors and use scaling in i915. URL : https://patchwork.freedesktop.org/series/42476/ State : warning == Summary == $ dim checkpatch origin/drm-tip febeff5693c0 drm/rect: Round above 1 << 16 upwards to correct scale calculation functions. -:25:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/4] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-30 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915: Stop tracking timeline->inflight_seqnos URL : https://patchwork.freedesktop.org/series/42474/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4113 -> Patchwork_8844 = == Summary - WARNING == Minor

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/4] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-30 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915: Stop tracking timeline->inflight_seqnos URL : https://patchwork.freedesktop.org/series/42474/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Stop tracking timeline->inflight_seqnos

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/4] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-30 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915: Stop tracking timeline->inflight_seqnos URL : https://patchwork.freedesktop.org/series/42474/ State : warning == Summary == $ dim checkpatch origin/drm-tip c6ae757146c5 drm/i915: Stop tracking timeline->inflight_seqnos

[Intel-gfx] [PATCH 1/5] drm/rect: Round above 1 << 16 upwards to correct scale calculation functions.

2018-04-30 Thread Maarten Lankhorst
When calculating limits we want to be as pessimistic as possible, so we have to explicitly say whether we want to round up or down to accurately calculate whether we are below min_scale or above max_scale. Signed-off-by: Maarten Lankhorst ---

[Intel-gfx] [PATCH 3/5] drm/i915: Do not adjust scale when out of bounds, v2.

2018-04-30 Thread Maarten Lankhorst
With the previous patch drm_atomic_helper_check_plane_state correctly calculates clipping and the xf86-video-intel ddx is fixed to fall back to GPU correctly when SetPlane fails, we can remove the hack where we try to pan/zoom when out of min/max scaling range. This was already poor behavior where

[Intel-gfx] [PATCH 4/5] drm/selftests: Rename the Kconfig option to CONFIG_DRM_DEBUG_SELFTEST

2018-04-30 Thread Maarten Lankhorst
We want to add more DRM selftests, and there's not much point in having a Kconfig option for every single one of them, so make a generic one. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/Kconfig| 8 drivers/gpu/drm/Makefile

[Intel-gfx] [PATCH 2/5] drm/rect: Handle rounding errors in drm_rect_clip_scaled, v2.

2018-04-30 Thread Maarten Lankhorst
No matter how you perform the clip adjustments, a small error may push the scaling factor to the other side of 0x1. Solve this with a macro that will fixup the scale to 0x1 if we accidentally wrap to the other side. Changes since v1: - Adjust dst immediately, else drm_rect_width/height on

[Intel-gfx] [PATCH 5/5] drm/selftests: Add drm helper selftest

2018-04-30 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/Kconfig | 1 + drivers/gpu/drm/selftests/Makefile| 2 +- .../gpu/drm/selftests/drm_helper_selftests.h | 9 + drivers/gpu/drm/selftests/test-drm-helper.c | 247

[Intel-gfx] [PATCH 0/5] drm: Fix rounding errors and use scaling in i915.

2018-04-30 Thread Maarten Lankhorst
There were some small rounding errors in when clamping with 1.0001 and 0. scaling, solve these and add a testcase for drm helpers, which can be used to prevent more of these errors in the future. The testcases helped me find an error in v1, which wouldn't have been found in another way.

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Wait for PSR exit before checking for vblank evasion for an atomic update

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915: Wait for PSR exit before checking for vblank evasion for an atomic update URL : https://patchwork.freedesktop.org/series/42461/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4112_full -> Patchwork_8839_full = == Summary - WARNING ==

[Intel-gfx] [CI 1/4] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-30 Thread Chris Wilson
In commit 9b6586ae9f6b ("drm/i915: Keep a global seqno per-engine"), we moved from a global inflight counter to per-engine counters in the hope that will be easy to run concurrently in future. However, with the advent of the desire to move requests between engines, we do need a global counter to

[Intel-gfx] [CI 3/4] drm/i915: Retire requests along rings

2018-04-30 Thread Chris Wilson
In the next patch, rings are the central timeline as requests may jump between engines. Therefore in the future as we retire in order along the engine timeline, we may retire out-of-order within a ring (as the ring now occurs along multiple engines), leading to much hilarity in miscomputing the

[Intel-gfx] [CI 4/4] drm/i915: Only track live rings for retiring

2018-04-30 Thread Chris Wilson
We don't need to track every ring for its lifetime as they are managed by the contexts/engines. What we do want to track are the live rings so that we can sporadically clean up requests if userspace falls behind. We can simply restrict the gt->rings list to being only gt->live_rings. v2:

[Intel-gfx] [CI 2/4] drm/i915: Wrap engine->context_pin() and engine->context_unpin()

2018-04-30 Thread Chris Wilson
Make life easier in upcoming patches by moving the context_pin and context_unpin vfuncs into inline helpers. v2: Fixup mock_engine to mark the context as pinned on use. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin ---

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/lrc: Scrub the GPU state of the guilty hanging request (rev4)

2018-04-30 Thread Chris Wilson
Quoting Patchwork (2018-04-30 13:38:55) > == Series Details == > > Series: drm/i915/lrc: Scrub the GPU state of the guilty hanging request (rev4) > URL : https://patchwork.freedesktop.org/series/42425/ > State : success > > == Summary == > > = CI Bug Log - changes from CI_DRM_4112_full ->

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled URL : https://patchwork.freedesktop.org/series/42459/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4112_full -> Patchwork_8838_full = == Summary - FAILURE == Serious

Re: [Intel-gfx] [PATCH v2 RESEND] drm/i915: add support for specifying DMC firmware override by module param

2018-04-30 Thread David Weinehall
On Mon, Apr 30, 2018 at 01:47:15PM +0300, Jani Nikula wrote: > On Tue, 24 Apr 2018, Jani Nikula wrote: > > Use i915.dmc_firmware_path to override default firmware for the platform > > and bypassing version checks. > > > > v2: add missing param struct member declaration

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: configure the transcoder clocks before touching pipeconf on HSW+

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915: configure the transcoder clocks before touching pipeconf on HSW+ URL : https://patchwork.freedesktop.org/series/42436/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4112 -> Patchwork_8843 = == Summary - WARNING == Minor unknown

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/lrc: Scrub the GPU state of the guilty hanging request (rev4)

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915/lrc: Scrub the GPU state of the guilty hanging request (rev4) URL : https://patchwork.freedesktop.org/series/42425/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4112_full -> Patchwork_8835_full = == Summary - WARNING == Minor

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: configure the transcoder clocks before touching pipeconf on HSW+

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915: configure the transcoder clocks before touching pipeconf on HSW+ URL : https://patchwork.freedesktop.org/series/42436/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4112 -> Patchwork_8842 = == Summary - SUCCESS == No regressions

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Print error state times relative to capture (rev3)

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915: Print error state times relative to capture (rev3) URL : https://patchwork.freedesktop.org/series/41749/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4112 -> Patchwork_8841 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: configure the transcoder clocks before touching pipeconf on HSW+

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915: configure the transcoder clocks before touching pipeconf on HSW+ URL : https://patchwork.freedesktop.org/series/42436/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4112 -> Patchwork_8840 = == Summary - SUCCESS == No regressions

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Wait for PSR exit before checking for vblank evasion for an atomic update

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915: Wait for PSR exit before checking for vblank evasion for an atomic update URL : https://patchwork.freedesktop.org/series/42461/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4112 -> Patchwork_8839 = == Summary - WARNING == Minor

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Wait for PSR exit before checking for vblank evasion for an atomic update

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915: Wait for PSR exit before checking for vblank evasion for an atomic update URL : https://patchwork.freedesktop.org/series/42461/ State : warning == Summary == $ dim checkpatch origin/drm-tip 136000f52a51 drm/i915: Wait for PSR exit before checking for

Re: [Intel-gfx] [PATCH v2 RESEND] drm/i915: add support for specifying DMC firmware override by module param

2018-04-30 Thread Jani Nikula
On Tue, 24 Apr 2018, Jani Nikula wrote: > Use i915.dmc_firmware_path to override default firmware for the platform > and bypassing version checks. > > v2: add missing param struct member declaration (David) > > Tested-by: David Weinehall >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled URL : https://patchwork.freedesktop.org/series/42459/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4112 -> Patchwork_8838 = == Summary - WARNING == Minor unknown changes

Re: [Intel-gfx] UHD 620: How to debug a screen resolution that does not work reliably

2018-04-30 Thread Jani Nikula
On Mon, 23 Apr 2018, Ricardo Ribalda Delgado wrote: > Hi > > I have a secondary monitor connected via USB-C adapter to HDMI. It > can manage resolutions up to 2560x1440. > > Most of the time, when the system is booted the resolution is detected > ok, but If I suspend

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled URL : https://patchwork.freedesktop.org/series/42459/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled

2018-04-30 Thread Patchwork
== Series Details == Series: drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled URL : https://patchwork.freedesktop.org/series/42459/ State : warning == Summary == $ dim checkpatch origin/drm-tip b8c009b51c95 drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is

  1   2   >