[Intel-gfx] ✗ Fi.CI.BAT: failure for Improve crc-core driver interface (rev12)

2018-08-13 Thread Patchwork
== Series Details == Series: Improve crc-core driver interface (rev12) URL : https://patchwork.freedesktop.org/series/45246/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4664 -> Patchwork_9932 = == Summary - FAILURE == Serious unknown changes coming with Patchwork_9932

[Intel-gfx] [PATCH V2 1/3] drm/vkms/crc: Implement verify_crc_source callback

2018-08-13 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for Virtual KMS drm driver. Changes Since V1: - update values_cnt in verify_crc_source Cc: Haneen Mohammed Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/vkms/vkms_crc.c | 38 ++

[Intel-gfx] [PATCH xserver] randr: fix RRCrtcDetachScanoutPixmap crash on server exit

2018-08-13 Thread Peter Wu
The following crash was observed with xserver 1.20.1 on exiting xserver after enabling a PRIME output source with the Intel driver: Old value = (WindowPtr) 0x612000159dc0 New value = (WindowPtr) 0x0 // pWin->drawable.pScreen->root = NULL; DeleteWindow (value=0x612000159dc0, wid=) at

[Intel-gfx] [PATCH xf86-video-intel] SNA: fix PRIME output support since xserver 1.20

2018-08-13 Thread Peter Wu
Since xorg-server 1.20, an external monitor would remain blank when used in a PRIME output slave setup. Only a cursor was visible. The cause is "Make PixmapDirtyUpdateRec::src a DrawablePtr" in xserver, the "src" pointer might point to the root window (created by the server) instead of a pixmap

Re: [Intel-gfx] [PATCH 2/2] drm/i915/icl: Get DDI clock for ICL for MG PLL and TBT PLL

2018-08-13 Thread Souza, Jose
On Fri, 2018-07-27 at 13:04 -0700, Paulo Zanoni wrote: > From: Manasi Navare > > PLLs are the source clocks for the DDIs so in order to determine the > ddi clock we need to check the PLL configuration. > > For MG PHy Ports (C - F), depending on whether it is a TBT PLL or MG > PLL the link lock

Re: [Intel-gfx] [PATCH 1/2] drm/i915/icl: Implement HSDIV_RATIO of MG_CLKTOP2_HSCLKCTL_PORT reg as separate divider value defines

2018-08-13 Thread Souza, Jose
On Fri, 2018-07-27 at 13:04 -0700, Paulo Zanoni wrote: > From: Manasi Navare > > The register value of Divider Ratio for high speed divider > (hsdiv_ratio) in MG_CLKTOP2_HSCLKCTL_PORT register is not same as the > actual numerical value of the divider. So this patch implements > separate divider

Re: [Intel-gfx] [PATCH] drm/i915/icl: Add pre_pll_enable hook for ICL and set DFLEXDPMLE in this hook

2018-08-13 Thread Manasi Navare
On Mon, Aug 13, 2018 at 12:38:00PM -0700, Souza, Jose wrote: > On Tue, 2018-07-31 at 17:30 -0700, Manasi Navare wrote: > > In case of Legacy DP connector on TypeC port (C, D, E or F), the > > Legacy DP connector(DisplayPort Alternative Mode) Ok will reword this as DisplayPort Alternative Mode >

Re: [Intel-gfx] [PATCH] drm/i915/icl: Add pre_pll_enable hook for ICL and set DFLEXDPMLE in this hook

2018-08-13 Thread Souza, Jose
On Tue, 2018-07-31 at 17:30 -0700, Manasi Navare wrote: > In case of Legacy DP connector on TypeC port (C, D, E or F), the Legacy DP connector(DisplayPort Alternative Mode) > flex IO DPMLE register is set to maximum number of lanes since > there is no muxing with other controllers in this case.

Re: [Intel-gfx] [PATCH 2/2] drm/i915/psr: Remove wait_for_idle() for PSR2

2018-08-13 Thread Pandiyan, Dhinakaran
On Mon, 2018-08-13 at 11:17 -0700, Tarun Vyas wrote: > On Mon, Aug 13, 2018 at 11:10:00AM -0700, Pandiyan, Dhinakaran wrote: > > On Mon, 2018-08-13 at 09:57 -0700, Rodrigo Vivi wrote: > > > On Thu, Aug 09, 2018 at 05:41:35PM -0700, Dhinakaran Pandiyan > > > wrote: > > > > CI runs show PSR2 does

Re: [Intel-gfx] [PATCH 2/2] drm/i915/psr: Remove wait_for_idle() for PSR2

2018-08-13 Thread Tarun Vyas
On Mon, Aug 13, 2018 at 11:10:00AM -0700, Pandiyan, Dhinakaran wrote: > On Mon, 2018-08-13 at 09:57 -0700, Rodrigo Vivi wrote: > > On Thu, Aug 09, 2018 at 05:41:35PM -0700, Dhinakaran Pandiyan wrote: > > > CI runs show PSR2 does not go to IDLE with selective update enabled > > > on > > > all PSR

Re: [Intel-gfx] [PATCH] drm/i915/psr: Add missing check for I915_PSR_DEBUG_IRQ bit

2018-08-13 Thread Pandiyan, Dhinakaran
On Mon, 2018-08-13 at 09:47 -0700, Rodrigo Vivi wrote: > On Mon, Aug 13, 2018 at 03:47:20PM +0200, Maarten Lankhorst wrote: > > Op 11-08-18 om 02:50 schreef Dhinakaran Pandiyan: > > > We print the last attempted entry and last exit timestamps only > > > when > > > IRQ debug is requested. This

Re: [Intel-gfx] [PATCH 2/2] drm/i915/psr: Remove wait_for_idle() for PSR2

2018-08-13 Thread Pandiyan, Dhinakaran
On Mon, 2018-08-13 at 09:57 -0700, Rodrigo Vivi wrote: > On Thu, Aug 09, 2018 at 05:41:35PM -0700, Dhinakaran Pandiyan wrote: > > CI runs show PSR2 does not go to IDLE with selective update enabled > > on > > all PSR exit triggers. Specifically, logs indicate the hardware > > enters > > "SLEEP

Re: [Intel-gfx] [PATCH 2/2] drm/i915/psr: Remove wait_for_idle() for PSR2

2018-08-13 Thread Rodrigo Vivi
On Thu, Aug 09, 2018 at 05:41:35PM -0700, Dhinakaran Pandiyan wrote: > CI runs show PSR2 does not go to IDLE with selective update enabled on > all PSR exit triggers. Specifically, logs indicate the hardware enters > "SLEEP Selective Update" and not "IDLE Reset state' like the kernel > expects.

Re: [Intel-gfx] [PATCH] drm/i915/psr: Add missing check for I915_PSR_DEBUG_IRQ bit

2018-08-13 Thread Rodrigo Vivi
On Mon, Aug 13, 2018 at 03:47:20PM +0200, Maarten Lankhorst wrote: > Op 11-08-18 om 02:50 schreef Dhinakaran Pandiyan: > > We print the last attempted entry and last exit timestamps only when > > IRQ debug is requested. This check was missed when new debug flags were > > added in 'commit

Re: [Intel-gfx] [PATCH] v3 drm/i915: Re-apply "Perform link quality check, unconditionally during long pulse"

2018-08-13 Thread Lyude Paul
On Wed, 2018-08-08 at 10:53 +0200, Jan-Marek Glogowski wrote: > This re-applies the workaround for "some DP sinks, [which] are a > little nuts" from commit 1a36147bb939 ("drm/i915: Perform link > quality check unconditionally during long pulse"). > It makes the secondary AOC E2460P monitor

[Intel-gfx] [PATCH i-g-t] tests/kms_cursor_crc: Open DRM device with DRIVER_ANY

2018-08-13 Thread Haneen Mohammed
So that this test can be run in drivers other than i915. Remove devid and only check it if the driver is i915. Signed-off-by: Haneen Mohammed --- tests/kms_cursor_crc.c | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/tests/kms_cursor_crc.c

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Wait for vblank between disabling planes and disabling crtc

2018-08-13 Thread Patchwork
== Series Details == Series: drm/i915: Wait for vblank between disabling planes and disabling crtc URL : https://patchwork.freedesktop.org/series/48113/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4662_full -> Patchwork_9930_full = == Summary - WARNING == Minor

Re: [Intel-gfx] [PATCH 02/14] drm/i915: Restrict gen6_reset_rps_interrupts to gen6+

2018-08-13 Thread Mika Kuoppala
Chris Wilson writes: > Do not call gen6_reset_rps_interrupts() when we know the registers do not > exist. > > Signed-off-by: Chris Wilson This makes me wonder about adding some known gen6+ debug register range assertions to I915_WRITE when gen < 6. i915.mmio_debug for all (gens) :)

Re: [Intel-gfx] [PATCH 01/14] drm/i915: Cleanup gt powerstate from gem

2018-08-13 Thread Mika Kuoppala
Chris Wilson writes: > Since the gt powerstate is allocated by i915_gem_init, clean it from > i915_gem_fini for symmetry and to correct the imbalance on error. > Was first confused about the allocation as it is embedded. But vlv really does allocate an underlying power context object. And the

[Intel-gfx] ✗ Fi.CI.BAT: failure for Improve crc-core driver interface (rev11)

2018-08-13 Thread Patchwork
== Series Details == Series: Improve crc-core driver interface (rev11) URL : https://patchwork.freedesktop.org/series/45246/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4663 -> Patchwork_9931 = == Summary - FAILURE == Serious unknown changes coming with Patchwork_9931

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Expose retry count to per gen reset logic (rev4)

2018-08-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Expose retry count to per gen reset logic (rev4) URL : https://patchwork.freedesktop.org/series/48019/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4662_full -> Patchwork_9929_full = == Summary - SUCCESS

[Intel-gfx] [PATCH v4 3/3] Revert "drm: crc: Wait for a frame before returning from open()"

2018-08-13 Thread Mahesh Kumar
This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680. Don't wait for first CRC during crtc_crc_open. It avoids one frame wait during open. If application want to wait after read call, it can use poll/read blocking read() call. Suggested-by: Ville Syrjälä Signed-off-by: Mahesh Kumar Cc:

[Intel-gfx] [PATCH v1 1/3] drm/vkms/crc: Implement verify_crc_source callback

2018-08-13 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for Virtual KMS drm driver. Cc: dri-de...@lists.freedesktop.org Cc: Haneen Mohammed Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/vkms/vkms_crc.c | 36 drivers/gpu/drm/vkms/vkms_crtc.c | 1 +

[Intel-gfx] [PATCH v5 2/3] drm/crc: Cleanup crtc_crc_open function

2018-08-13 Thread Mahesh Kumar
This patch make changes to allocate crc-entries buffer before enabling CRC generation. It moves all the failure check early in the function before setting the source or memory allocation. Now set_crc_source takes only two variable inputs, values_cnt we already gets as part of verify_crc_source.

[Intel-gfx] [PATCH v5 0/3] Improve crc-core driver interface

2018-08-13 Thread Mahesh Kumar
This series improves crc-core <-> driver interface. This series adds following functionality in the crc-core - Now control node will print all the available sources if implemented by driver along with current source. - Setting of sorce will fail if provided source is not supported - cleanup

Re: [Intel-gfx] [PATCH v5 2/2] drm/i915: Adding YUV444 packed format(DRM_FORMAT_XYUV) support.

2018-08-13 Thread Sharma, Swati2
On 13-Aug-18 7:46 PM, Sharma, Swati2 wrote: Hi Stanlis, Won't we defining XYUV PF in skl_update_scaler_plane? Else scaler won't be updated for XYUV PF. On 10-Aug-18 6:50 PM, StanLis wrote: From: Stanislav Lisovskiy PLANE_CTL_FORMAT_AYUV is already supported, according to hardware

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Wait for vblank between disabling planes and disabling crtc

2018-08-13 Thread Patchwork
== Series Details == Series: drm/i915: Wait for vblank between disabling planes and disabling crtc URL : https://patchwork.freedesktop.org/series/48113/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4662 -> Patchwork_9930 = == Summary - SUCCESS == No regressions found.

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Expose retry count to per gen reset logic

2018-08-13 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2018-08-10 15:00:35) >> There is a possibility for per gen reset logic to >> be more nasty if the softer approach on resetting does >> not bear fruit. >> >> Expose retry count to per gen reset logic if it >> wants to take such tough measures. >> >>

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Wait for vblank between disabling planes and disabling crtc

2018-08-13 Thread Patchwork
== Series Details == Series: drm/i915: Wait for vblank between disabling planes and disabling crtc URL : https://patchwork.freedesktop.org/series/48113/ State : warning == Summary == $ dim checkpatch origin/drm-tip a46c5d644c7f drm/i915: Wait for vblank between disabling planes and disabling

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Expose retry count to per gen reset logic (rev4)

2018-08-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Expose retry count to per gen reset logic (rev4) URL : https://patchwork.freedesktop.org/series/48019/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4662 -> Patchwork_9929 = == Summary - SUCCESS == No

Re: [Intel-gfx] [PATCH] drm/i915/psr: Add missing check for I915_PSR_DEBUG_IRQ bit

2018-08-13 Thread Maarten Lankhorst
Op 11-08-18 om 02:50 schreef Dhinakaran Pandiyan: > We print the last attempted entry and last exit timestamps only when > IRQ debug is requested. This check was missed when new debug flags were > added in 'commit c44301fce614 ("drm/i915: Allow control of PSR at > runtime through debugfs, v6") > >

[Intel-gfx] [PATCH] drm/i915: Wait for vblank between disabling planes and disabling crtc

2018-08-13 Thread Maarten Lankhorst
Disabling cursor does not take effect until the next vblank, but if the pipe is shut down too quickly after a cursor disable, we will see random corruption from where the mouse cursor used to be when the pipe is enabled again. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106478

Re: [Intel-gfx] [PATCH 2/2] drm/i915/tracepoints: Remove DRM_I915_LOW_LEVEL_TRACEPOINTS Kconfig option

2018-08-13 Thread Kukanova, Svetlana
Joonas, sorry for interfering; could you please explain more regarding the options for tracing scheduling events better than tracepoints? After scheduling moves to GuC tools will have to switch to something like GuC-logging; but while kmd does scheduling isn't kernel-tracing the best solution?

[Intel-gfx] [PATCH 2/2] drm/i915: Force reset on unready engine

2018-08-13 Thread Mika Kuoppala
If engine reports that it is not ready for reset, we give up. Evidence shows that forcing a per engine reset on an engine which is not reporting to be ready for reset, can bring it back into a working order. There is risk that we corrupt the context image currently executing on that engine. But

Re: [Intel-gfx] [PATCH] drm/i915: Bump priority of clean up work

2018-08-13 Thread Chris Wilson
Quoting Mika Kuoppala (2018-08-13 13:49:43) > Chris Wilson writes: > > > Quoting Chris Wilson (2018-07-12 12:57:29) > >> We require that we keep the list of outstanding work short so that we do > >> not "leak" memory while pageflipping under stress. However that system > >> stress may delay

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Expose retry count to per gen reset logic (rev3)

2018-08-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Expose retry count to per gen reset logic (rev3) URL : https://patchwork.freedesktop.org/series/48019/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4660_full -> Patchwork_9928_full = == Summary - SUCCESS

Re: [Intel-gfx] [PATCH] drm/i915: Bump priority of clean up work

2018-08-13 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Chris Wilson (2018-07-12 12:57:29) >> We require that we keep the list of outstanding work short so that we do >> not "leak" memory while pageflipping under stress. However that system >> stress may delay kernel workers virtually indefinitely, which incurs the >>

Re: [Intel-gfx] [PATCH V6 10/10] drm/rcar-du/crc: Implement get_crc_sources callback

2018-08-13 Thread Maarten Lankhorst
Hey, Op 08-08-18 om 17:26 schreef Mahesh Kumar: > This patch implements get_crc_sources callback, which returns list of > all the crc sources supported by driver in current platform. > > Changes Since V1: > - move sources list per-crtc > - init sources-list only for gen3 > Changes Since V2: >

Re: [Intel-gfx] [PATCH v5 1/2] drm: Introduce new DRM_FORMAT_XYUV

2018-08-13 Thread Lisovskiy, Stanislav
On Fri, 2018-08-10 at 19:01 +0100, Alexandru-Cosmin Gheorghe wrote: > Hi Stanislav, > > FYI, we are trying to add same format under a slightly different > name. > See https://lists.freedesktop.org/archives/dri-devel/2018- > July/184598.html So we probably just need to decide, if this should be

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Expose retry count to per gen reset logic (rev3)

2018-08-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Expose retry count to per gen reset logic (rev3) URL : https://patchwork.freedesktop.org/series/48019/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4660 -> Patchwork_9928 = == Summary - SUCCESS == No

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Force reset on unready engine

2018-08-13 Thread Chris Wilson
Quoting Mika Kuoppala (2018-08-13 12:02:51) > Chris Wilson writes: > > > Quoting Mika Kuoppala (2018-08-13 11:42:42) > >> If engine reports that it is not ready for reset, we > >> give up. Evidence shows that forcing a per engine reset > >> on an engine which is not reporting to be ready for

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Force reset on unready engine

2018-08-13 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2018-08-13 11:42:42) >> If engine reports that it is not ready for reset, we >> give up. Evidence shows that forcing a per engine reset >> on an engine which is not reporting to be ready for reset, >> can bring it back into a working order. There is

Re: [Intel-gfx] [v3] drm/i915: Add detection of changing of edid on between suspend and resume

2018-08-13 Thread Mika Kahola
On Fri, 2018-08-10 at 13:02 +, Lisovskiy, Stanislav wrote: > On Thu, 2018-08-09 at 14:13 +0300, Gwan-gyeong Mun wrote: > > > > The hotplug detection routine of i915 uses > > drm_helper_hpd_irq_event(). This > > helper can detect changing of status of connector, but it can not > > detect > >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Force reset on unready engine

2018-08-13 Thread Chris Wilson
Quoting Mika Kuoppala (2018-08-13 11:42:42) > If engine reports that it is not ready for reset, we > give up. Evidence shows that forcing a per engine reset > on an engine which is not reporting to be ready for reset, > can bring it back into a working order. There is risk that > we corrupt the

Re: [Intel-gfx] [PATCH] drm/i915: Bump priority of clean up work

2018-08-13 Thread Chris Wilson
Quoting Chris Wilson (2018-07-12 12:57:29) > We require that we keep the list of outstanding work short so that we do > not "leak" memory while pageflipping under stress. However that system > stress may delay kernel workers virtually indefinitely, which incurs the > pageflips stall and eventually

[Intel-gfx] [PATCH 2/2] drm/i915: Force reset on unready engine

2018-08-13 Thread Mika Kuoppala
If engine reports that it is not ready for reset, we give up. Evidence shows that forcing a per engine reset on an engine which is not reporting to be ready for reset, can bring it back into a working order. There is risk that we corrupt the context image currently executing on that engine. But

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Bump priority of clean up work

2018-08-13 Thread Patchwork
== Series Details == Series: drm/i915: Bump priority of clean up work URL : https://patchwork.freedesktop.org/series/46390/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4660_full -> Patchwork_9927_full = == Summary - SUCCESS == No regressions found. == Known

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Force reset on unready engine

2018-08-13 Thread Chris Wilson
Quoting Mika Kuoppala (2018-08-13 10:58:10) > Chris Wilson writes: > > > Quoting Mika Kuoppala (2018-08-13 09:18:07) > >> Chris Wilson writes: > >> > >> > Quoting Mika Kuoppala (2018-08-10 15:00:36) > >> >> If engine reports that it is not ready for reset, we > >> >> give up. Evidence shows

[Intel-gfx] ✓ Fi.CI.IGT: success for Reviewed perf cleanups

2018-08-13 Thread Patchwork
== Series Details == Series: Reviewed perf cleanups URL : https://patchwork.freedesktop.org/series/48100/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4660_full -> Patchwork_9926_full = == Summary - SUCCESS == No regressions found. == Known issues == Here are

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Force reset on unready engine

2018-08-13 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2018-08-13 09:18:07) >> Chris Wilson writes: >> >> > Quoting Mika Kuoppala (2018-08-10 15:00:36) >> >> If engine reports that it is not ready for reset, we >> >> give up. Evidence shows that forcing a per engine reset >> >> on an engine which is

Re: [Intel-gfx] [PATCH 2/2] drm/i915/tracepoints: Remove DRM_I915_LOW_LEVEL_TRACEPOINTS Kconfig option

2018-08-13 Thread Joonas Lahtinen
Quoting Tvrtko Ursulin (2018-08-08 15:56:01) > On 08/08/2018 13:42, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-08-08 13:13:08) > This is true, no disagreement. My point simply was that we can provide > this info easily to anyone. There is a little bit of analogy with perf > scheduler

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/2] igt/perf_pmu: Aim for a fixed number of iterations for calibrating accuracy

2018-08-13 Thread Tvrtko Ursulin
On 10/08/2018 14:25, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-08-09 12:54:41) On 08/08/2018 15:59, Chris Wilson wrote: Our observation is that the systematic error is proportional to the number of iterations we perform; the suspicion is that it directly correlates with the number of

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Bump priority of clean up work

2018-08-13 Thread Patchwork
== Series Details == Series: drm/i915: Bump priority of clean up work URL : https://patchwork.freedesktop.org/series/46390/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4660 -> Patchwork_9927 = == Summary - SUCCESS == No regressions found. External URL:

Re: [Intel-gfx] [CI 2/2] drm/i915/perf: reuse intel_lrc ctx regs macro

2018-08-13 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-08-13 10:11:44) > > On 13/08/2018 09:16, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-08-13 09:02:18) > >> From: Lionel Landwerlin > >> > >> Abstract the context image access a bit. > >> > >> Signed-off-by: Lionel Landwerlin > >> Reviewed-by: Tvrtko Ursulin

Re: [Intel-gfx] [CI 2/2] drm/i915/perf: reuse intel_lrc ctx regs macro

2018-08-13 Thread Tvrtko Ursulin
On 13/08/2018 09:16, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-08-13 09:02:18) From: Lionel Landwerlin Abstract the context image access a bit. Signed-off-by: Lionel Landwerlin Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_perf.c | 34 +++-

[Intel-gfx] ✓ Fi.CI.BAT: success for Reviewed perf cleanups

2018-08-13 Thread Patchwork
== Series Details == Series: Reviewed perf cleanups URL : https://patchwork.freedesktop.org/series/48100/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4660 -> Patchwork_9926 = == Summary - SUCCESS == No regressions found. External URL:

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Force reset on unready engine

2018-08-13 Thread Chris Wilson
Quoting Mika Kuoppala (2018-08-13 09:18:07) > Chris Wilson writes: > > > Quoting Mika Kuoppala (2018-08-10 15:00:36) > >> If engine reports that it is not ready for reset, we > >> give up. Evidence shows that forcing a per engine reset > >> on an engine which is not reporting to be ready for

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Force reset on unready engine

2018-08-13 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2018-08-10 15:00:36) >> If engine reports that it is not ready for reset, we >> give up. Evidence shows that forcing a per engine reset >> on an engine which is not reporting to be ready for reset, >> can bring it back into a working order. There is

Re: [Intel-gfx] [CI 2/2] drm/i915/perf: reuse intel_lrc ctx regs macro

2018-08-13 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-08-13 09:02:18) > From: Lionel Landwerlin > > Abstract the context image access a bit. > > Signed-off-by: Lionel Landwerlin > Reviewed-by: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/i915_perf.c | 34 +++- > 1 file changed, 16

[Intel-gfx] [CI 1/2] drm/i915/perf: simplify configure all context function

2018-08-13 Thread Tvrtko Ursulin
From: Lionel Landwerlin We don't need any special treatment on error so just return as soon as possible. Signed-off-by: Lionel Landwerlin Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_perf.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git

[Intel-gfx] [CI 0/2] Reviewed perf cleanups

2018-08-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Two reviewed simple cleanup patches, extracted from dynamic SSEU series. Lionel Landwerlin (2): drm/i915/perf: simplify configure all context function drm/i915/perf: reuse intel_lrc ctx regs macro drivers/gpu/drm/i915/i915_perf.c | 45 ++--

[Intel-gfx] [CI 2/2] drm/i915/perf: reuse intel_lrc ctx regs macro

2018-08-13 Thread Tvrtko Ursulin
From: Lionel Landwerlin Abstract the context image access a bit. Signed-off-by: Lionel Landwerlin Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_perf.c | 34 +++- 1 file changed, 16 insertions(+), 18 deletions(-) diff --git