[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: implement EXTENDED_RECEIVER_CAPABILITY_FIELD_PRESENT

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: implement EXTENDED_RECEIVER_CAPABILITY_FIELD_PRESENT URL : https://patchwork.freedesktop.org/series/49669/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4820_full -> Patchwork_10179_full = == Summary - WARNING == Minor unknown

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr: Enable AUX-A IO power well on ICL for PSR

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915/psr: Enable AUX-A IO power well on ICL for PSR URL : https://patchwork.freedesktop.org/series/49682/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4822 -> Patchwork_10184 = == Summary - SUCCESS == No regressions found. External

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Unset reset pch handshake when PCH is not present in one place

2018-09-13 Thread Souza, Jose
On Thu, 2018-09-13 at 14:51 -0700, Rodrigo Vivi wrote: > On Thu, Sep 13, 2018 at 02:22:49PM -0700, José Roberto de Souza > wrote: > > Right now RESET_PCH_HANDSHAKE_ENABLE is enabled all the times > > inside > > of intel_power_domains_init_hw() and if PCH is NOP it is unsed in > >

[Intel-gfx] [PATCH] drm/i915/psr: Enable AUX-A IO power well on ICL for PSR

2018-09-13 Thread Dhinakaran Pandiyan
PSR requires AUX IO power well to be enabled. This was already in place for CNL, extend this for ICL too. Not enabling the power well results in the aux error interrupts when the hardware exits PSR. Reported-by: Casey G Bowman Reported-by: Jyoti R Yadav Cc: Matt Atwood Cc: Jyoti R Yadav Cc:

[Intel-gfx] ✗ Fi.CI.BAT: failure for firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.

2018-09-13 Thread Patchwork
== Series Details == Series: firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. URL : https://patchwork.freedesktop.org/series/49678/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4820 -> Patchwork_10183 = == Summary - FAILURE == Serious unknown changes coming

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/icl: Enable DC9 as lowest possible state during screen-off (rev2)

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915/icl: Enable DC9 as lowest possible state during screen-off (rev2) URL : https://patchwork.freedesktop.org/series/49447/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4819_full -> Patchwork_10177_full = == Summary - SUCCESS == No

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tbt: Add CFGCR0/1 registers for TBT

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915/tbt: Add CFGCR0/1 registers for TBT URL : https://patchwork.freedesktop.org/series/49677/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4820 -> Patchwork_10182 = == Summary - SUCCESS == No regressions found. External URL:

[Intel-gfx] [PATCH] firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.

2018-09-13 Thread Anusha Srivatsa
Add missing MODULE_FIRMWARE while loading DMC ICL. v2: Add Fixes tag. (Rodrigo) Fixes: 4445930f1c4a ("firmware/dmc/icl: load v1.07 on icelake.") Cc: Rodrigo Vivi Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/intel_csr.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/execlists: Delay updating ring register state after resume (rev2)

2018-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/execlists: Delay updating ring register state after resume (rev2) URL : https://patchwork.freedesktop.org/series/49654/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4819_full -> Patchwork_10176_full = ==

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Return -ENOTSUPP in drm_setclientcap() when driver do not support KMS

2018-09-13 Thread Patchwork
== Series Details == Series: drm: Return -ENOTSUPP in drm_setclientcap() when driver do not support KMS URL : https://patchwork.freedesktop.org/series/49675/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4820 -> Patchwork_10181 = == Summary - SUCCESS == No regressions

Re: [Intel-gfx] [PATCH] drm/i915/tbt: Add CFGCR0/1 registers for TBT

2018-09-13 Thread Paulo Zanoni
Em Qui, 2018-09-13 às 15:15 -0700, Anusha Srivatsa escreveu: > We were using the default CFGCR0/1 instead of using > TBT specific CFGCR0 and CFGCR1 registers during > PLL sequence. > > Add missing TBTPLL_CFGCR0/1 registers and plumb > them in the existing PLL sequence. > > Cc: Paulo Zanoni >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: implement EXTENDED_RECEIVER_CAPABILITY_FIELD_PRESENT

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: implement EXTENDED_RECEIVER_CAPABILITY_FIELD_PRESENT URL : https://patchwork.freedesktop.org/series/49669/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4820 -> Patchwork_10179 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915/runtime_pm: Share code to enable/disable PCH reset handshake

2018-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/runtime_pm: Share code to enable/disable PCH reset handshake URL : https://patchwork.freedesktop.org/series/49671/ State : failure == Summary == Applying: drm/i915/runtime_pm: Share code to enable/disable PCH reset handshake

[Intel-gfx] [PATCH] drm/i915/tbt: Add CFGCR0/1 registers for TBT

2018-09-13 Thread Anusha Srivatsa
We were using the default CFGCR0/1 instead of using TBT specific CFGCR0 and CFGCR1 registers during PLL sequence. Add missing TBTPLL_CFGCR0/1 registers and plumb them in the existing PLL sequence. Cc: Paulo Zanoni Cc: Jose Souza Signed-off-by: Anusha Srivatsa ---

[Intel-gfx] [PATCH] drm: Return -ENOTSUPP in drm_setclientcap() when driver do not support KMS

2018-09-13 Thread José Roberto de Souza
All DRM_CLIENT capabilities are tied to KMS support, so returning -ENOTSUPP when KMS is not supported. Cc: Chris Wilson Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/drm_ioctl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_ioctl.c

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: implement EXTENDED_RECEIVER_CAPABILITY_FIELD_PRESENT

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: implement EXTENDED_RECEIVER_CAPABILITY_FIELD_PRESENT URL : https://patchwork.freedesktop.org/series/49669/ State : warning == Summary == $ dim checkpatch origin/drm-tip dd7da1191c62 drm/i915: implement EXTENDED_RECEIVER_CAPABILITY_FIELD_PRESENT -:98:

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Unset reset pch handshake when PCH is not present in one place

2018-09-13 Thread Rodrigo Vivi
On Thu, Sep 13, 2018 at 02:22:49PM -0700, José Roberto de Souza wrote: > Right now RESET_PCH_HANDSHAKE_ENABLE is enabled all the times inside > of intel_power_domains_init_hw() and if PCH is NOP it is unsed in > i915_gem_init_hw(). > So making skl_pch_reset_handshake() handle both cases and

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Remove duplicated definition of intel_update_rawclk

2018-09-13 Thread Rodrigo Vivi
On Thu, Sep 13, 2018 at 02:22:51PM -0700, José Roberto de Souza wrote: > A few line above we have another definition of intel_update_rawclk() > keeping that one as the function is implemented in intel_cdclk.c. > > Signed-off-by: José Roberto de Souza Reviewed-by: Rodrigo Vivi > --- >

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Do not modifiy reserved bit in gens that do not have IPC

2018-09-13 Thread Rodrigo Vivi
On Thu, Sep 13, 2018 at 02:22:50PM -0700, José Roberto de Souza wrote: > IPC was only added in SKL+(actually we don't even enable for SKL due > WA) so without this change, driver was writing to a reserved bit. > > Also check for the WA in intel_init_ipc() to avoid further writes to > ipc_enabled.

Re: [Intel-gfx] [PATCH 1/4] drm/i915/runtime_pm: Share code to enable/disable PCH reset handshake

2018-09-13 Thread Rodrigo Vivi
On Thu, Sep 13, 2018 at 02:22:48PM -0700, José Roberto de Souza wrote: > Instead of have the same code spread into 4 platforms lets share it. > BXT do not have a PCH so here also handling this case by unseting > RESET_PCH_HANDSHAKE_ENABLE. > > Signed-off-by: José Roberto de Souza > --- >

Re: [Intel-gfx] [PATCH 2/4] drm/i915/fbdev: Use i915/drm_i915_private consistently

2018-09-13 Thread Rodrigo Vivi
On Thu, Sep 13, 2018 at 10:31:18PM +0100, Chris Wilson wrote: > Quoting Rodrigo Vivi (2018-09-13 22:11:11) > > On Thu, Sep 13, 2018 at 02:16:27PM +0100, Chris Wilson wrote: > > > Convert the interface (except for the drm core callback) to accept > > > drm_i915_private as that is our native type of

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Differentiate the lack of an interface from invalid parameter (rev4)

2018-09-13 Thread Patchwork
== Series Details == Series: drm: Differentiate the lack of an interface from invalid parameter (rev4) URL : https://patchwork.freedesktop.org/series/49536/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4818_full -> Patchwork_10175_full = == Summary - SUCCESS == No

Re: [Intel-gfx] [PATCH V2 5/5] drm/i915/kbl+: Enable IPC only for symmetric memory configurations

2018-09-13 Thread Rodrigo Vivi
On Fri, Aug 31, 2018 at 12:25:31PM +0200, Maarten Lankhorst wrote: > Op 24-08-18 om 11:32 schreef Mahesh Kumar: > > IPC may cause underflows if not used with dual channel symmetric > > memory configuration. Disable IPC for non symmetric configurations in > > affected platforms. > > Display WA

Re: [Intel-gfx] [PATCH 2/4] drm/i915/fbdev: Use i915/drm_i915_private consistently

2018-09-13 Thread Chris Wilson
Quoting Rodrigo Vivi (2018-09-13 22:11:11) > On Thu, Sep 13, 2018 at 02:16:27PM +0100, Chris Wilson wrote: > > Convert the interface (except for the drm core callback) to accept > > drm_i915_private as that is our native type of the majority of > > operations. > > this message just tells about

[Intel-gfx] [PATCH 2/4] drm/i915: Unset reset pch handshake when PCH is not present in one place

2018-09-13 Thread José Roberto de Souza
Right now RESET_PCH_HANDSHAKE_ENABLE is enabled all the times inside of intel_power_domains_init_hw() and if PCH is NOP it is unsed in i915_gem_init_hw(). So making skl_pch_reset_handshake() handle both cases and calling it for the missing gens in intel_power_domains_init_hw(). Ivybridge have a

[Intel-gfx] [PATCH 4/4] drm/i915: Remove duplicated definition of intel_update_rawclk

2018-09-13 Thread José Roberto de Souza
A few line above we have another definition of intel_update_rawclk() keeping that one as the function is implemented in intel_cdclk.c. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/intel_drv.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_drv.h

[Intel-gfx] [PATCH 1/4] drm/i915/runtime_pm: Share code to enable/disable PCH reset handshake

2018-09-13 Thread José Roberto de Souza
Instead of have the same code spread into 4 platforms lets share it. BXT do not have a PCH so here also handling this case by unseting RESET_PCH_HANDSHAKE_ENABLE. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/intel_runtime_pm.c | 29 ++--- 1 file changed, 16

[Intel-gfx] [PATCH 3/4] drm/i915: Do not modifiy reserved bit in gens that do not have IPC

2018-09-13 Thread José Roberto de Souza
IPC was only added in SKL+(actually we don't even enable for SKL due WA) so without this change, driver was writing to a reserved bit. Also check for the WA in intel_init_ipc() to avoid further writes to ipc_enabled. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/intel_pm.c | 8

Re: [Intel-gfx] [PATCH 1/1] firmware/dmc/icl: load v1.07 on icelake.

2018-09-13 Thread Rodrigo Vivi
On Fri, Sep 07, 2018 at 06:26:32PM +, Srivatsa, Anusha wrote: > > > >-Original Message- > >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > >Joonas Lahtinen > >Sent: Friday, September 7, 2018 12:47 AM > >To: Nikula, Jani ; Vivi, Rodrigo > > > >Cc:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: drm/i915: GTT remapping for display

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: drm/i915: GTT remapping for display URL : https://patchwork.freedesktop.org/series/49663/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4819 -> Patchwork_10178 = == Summary - FAILURE == Serious unknown changes coming with

[Intel-gfx] [PATCH] drm/i915: implement EXTENDED_RECEIVER_CAPABILITY_FIELD_PRESENT

2018-09-13 Thread matthew . s . atwood
From: Matt Atwood According to DP spec (2.9.3.1 of DP 1.4) if EXTENDED_RECEIVER_CAPABILITY_FIELD_PRESENT is set the addresses in DPCD 02200h through 0220Fh shall contain the DPRX's true capability. These values will match 0h through Fh, except for DPCD_REV, MAX_LINK_RATE,

Re: [Intel-gfx] [PATCH 2/4] drm/i915/fbdev: Use i915/drm_i915_private consistently

2018-09-13 Thread Rodrigo Vivi
On Thu, Sep 13, 2018 at 02:16:27PM +0100, Chris Wilson wrote: > Convert the interface (except for the drm core callback) to accept > drm_i915_private as that is our native type of the majority of > operations. this message just tells about s/dev/dev_priv... > > Signed-off-by: Chris Wilson >

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Mark up a couple of KMS debug messages as such

2018-09-13 Thread Rodrigo Vivi
On Thu, Sep 13, 2018 at 02:16:26PM +0100, Chris Wilson wrote: > For finding the panel fitter and PLL for a particular modeset is a part > of that modeset and should be included with the reset of the > DRM_DEBUG_KMS. > > Signed-off-by: Chris Wilson Reviewed-by: Rodrigo Vivi > --- >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: drm/i915: GTT remapping for display

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: drm/i915: GTT remapping for display URL : https://patchwork.freedesktop.org/series/49663/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Decouple SKL stride units from intel_fb_stride_alignment() Okay! Commit: drm/i915: Add

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: drm/i915: GTT remapping for display

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: drm/i915: GTT remapping for display URL : https://patchwork.freedesktop.org/series/49663/ State : warning == Summary == $ dim checkpatch origin/drm-tip b24877977210 drm/i915: Decouple SKL stride units from intel_fb_stride_alignment() 7a895a3a3d0d

Re: [Intel-gfx] [PATCH 1/2] drm/nouveau: Disable atomic support on a per-device basis

2018-09-13 Thread Lyude Paul
Hm, one nitpick here. Since /sys/kernel/debug/dri/*/state creation depends on the driver supporting atomic, maybe it would be good to make it so that we set DRIVER_ATOMIC in the driver_stub structure, then disable it per-device depending on the nouveau_atomic setting + hw support. That way we can

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl: Enable DC9 as lowest possible state during screen-off (rev2)

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915/icl: Enable DC9 as lowest possible state during screen-off (rev2) URL : https://patchwork.freedesktop.org/series/49447/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4819 -> Patchwork_10177 = == Summary - SUCCESS == No regressions

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/2] lib: Require drmModeResources()

2018-09-13 Thread Souza, Jose
On Thu, 2018-09-13 at 14:24 +0100, Chris Wilson wrote: > If modesetting is not supported, the drmModeGetResources() call will > fail with -EINVAL (or -ENOTSUPP). As no displays are connected, skip. This one sounds better than the second patch to me. I just sent this patch together with other

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915: Add a new "remapped" gtt_view

2018-09-13 Thread Chris Wilson
Quoting Ville Syrjala (2018-09-13 21:01:37) > diff --git a/drivers/gpu/drm/i915/selftests/i915_vma.c > b/drivers/gpu/drm/i915/selftests/i915_vma.c > index ffa74290e054..4fc49c27f13c 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_vma.c > +++ b/drivers/gpu/drm/i915/selftests/i915_vma.c > @@

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/execlists: Delay updating ring register state after resume (rev2)

2018-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/execlists: Delay updating ring register state after resume (rev2) URL : https://patchwork.freedesktop.org/series/49654/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4819 -> Patchwork_10176 = == Summary -

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915: Bump gen4+ fb stride limit to 256KiB

2018-09-13 Thread Chris Wilson
Quoting Ville Syrjala (2018-09-13 21:01:39) > From: Ville Syrjälä > > With gtt remapping plugged in we can simply raise the stride > limit on gen4+. Let's just arbitraily pick 256 KiB as the limit. > > No remapping CCS because the virtual address of each page actually > matters due to the new

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/execlists: Delay updating ring register state after resume (rev2)

2018-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/execlists: Delay updating ring register state after resume (rev2) URL : https://patchwork.freedesktop.org/series/49654/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915/execlists: Delay updating ring

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Overcome display engine stride limits via GTT remapping

2018-09-13 Thread Chris Wilson
Quoting Ville Syrjala (2018-09-13 21:01:38) > +static void > +intel_plane_remap_gtt(struct intel_plane_state *plane_state) > +{ > + struct drm_i915_private *dev_priv = > + to_i915(plane_state->base.plane->dev); > + struct drm_framebuffer *fb = plane_state->base.fb; > +

Re: [Intel-gfx] [PATCH] drm/i915/icl: Enable DC9 as lowest possible state during screen-off

2018-09-13 Thread Rodrigo Vivi
On Thu, Sep 13, 2018 at 12:31:09PM -0700, Anusha Srivatsa wrote: > From: Animesh Manna > > ICL supports DC5, DC6, and DC9. Enable DC9 during screen-off, and enable > DC5/6 when appropriate. > > v2: (James Ausmus) > - Also handle ICL as GEN9_LP in i915_drm_suspend_late and >

[Intel-gfx] [PATCH v2 3/5] drm/i915: Overcome display engine stride limits via GTT remapping

2018-09-13 Thread Ville Syrjala
From: Ville Syrjälä The display engine stride limits are getting in our way. On SKL+ we are limited to 8k pixels, which is easily exceeded with three 4k displays. To overcome this limitation we can remap the pages in the GTT to provide the display engine with a view of memory with a smaller

[Intel-gfx] [PATCH v2 4/5] drm/i915: Bump gen4+ fb stride limit to 256KiB

2018-09-13 Thread Ville Syrjala
From: Ville Syrjälä With gtt remapping plugged in we can simply raise the stride limit on gen4+. Let's just arbitraily pick 256 KiB as the limit. No remapping CCS because the virtual address of each page actually matters due to the new hash mode (WaCompressedResourceDisplayNewHashMode:skl,kbl

[Intel-gfx] [PATCH v2 0/5] drm/i915: drm/i915: GTT remapping for display

2018-09-13 Thread Ville Syrjala
From: Ville Syrjälä Lots of prep stuff for the GTT remapping already landed, so now we're left with just the real meat: the remapped vma and actually constructing it. I spotted that I kinda busted up the skl+ stride_mult stuff for linear buffers in the BIOS fb takeover path so I included a fix

[Intel-gfx] [PATCH v2 2/5] drm/i915: Add a new "remapped" gtt_view

2018-09-13 Thread Ville Syrjala
From: Ville Syrjälä To overcome display engine stride limits we'll want to remap the pages in the GTT. To that end we need a new gtt_view type which is just like the "rotated" type except not rotated. v2: Use intel_remapped_plane_info base type s/unused/unused_mbz/ (Chris) Separate

[Intel-gfx] [PATCH v2 1/5] drm/i915: Decouple SKL stride units from intel_fb_stride_alignment()

2018-09-13 Thread Ville Syrjala
From: Ville Syrjälä In the future framebuffer stride alignment requirements won't exactly match the units in which skl+ plane stride is specified. So extract the code for the skl+ stuff into a separate helper. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 28

[Intel-gfx] [PATCH v2 5/5] drm/i915: Bump gen4+ fb size limits to 32kx32k

2018-09-13 Thread Ville Syrjala
From: Ville Syrjälä With gtt remapping in place we can use arbitraily large framebuffers. Let's bump the limits as high as we can (32k-1). Going beyond that would require switching our s16.16 src coordinate representation to something with more spare bits. Signed-off-by: Ville Syrjälä ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Differentiate the lack of an interface from invalid parameter (rev4)

2018-09-13 Thread Patchwork
== Series Details == Series: drm: Differentiate the lack of an interface from invalid parameter (rev4) URL : https://patchwork.freedesktop.org/series/49536/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4818 -> Patchwork_10175 = == Summary - SUCCESS == No regressions

[Intel-gfx] [PATCH] drm/i915/icl: Enable DC9 as lowest possible state during screen-off

2018-09-13 Thread Anusha Srivatsa
From: Animesh Manna ICL supports DC5, DC6, and DC9. Enable DC9 during screen-off, and enable DC5/6 when appropriate. v2: (James Ausmus) - Also handle ICL as GEN9_LP in i915_drm_suspend_late and i915_drm_suspend_early - Add DC9 to gen9_dc_mask for ICL - Re-order GEN checks for newest

[Intel-gfx] [PATCH v3] drm/i915/execlists: Use coherent writes into the context image

2018-09-13 Thread Chris Wilson
That we use a WB mapping for updating the RING_TAIL register inside the context image even on !llc machines has been a source of consternation for every reader. It appears to work on bsw+, but it may just have been that we have been incredibly bad at detecting the errors. v2: With extra

[Intel-gfx] [PATCH v3] drm: Differentiate the lack of an interface from invalid parameter

2018-09-13 Thread Chris Wilson
If the ioctl is not supported on a particular piece of HW/driver combination, report ENOTSUP (aka EOPNOTSUPP) so that it can be easily distinguished from both the lack of the ioctl and from a regular invalid parameter. v2: Across all the kms ioctls we had a mixture of reporting EINVAL, ENODEV and

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Replace some PAGE_SIZE with I915_GTT_PAGE_SIZE

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: Replace some PAGE_SIZE with I915_GTT_PAGE_SIZE URL : https://patchwork.freedesktop.org/series/49645/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4817_full -> Patchwork_10173_full = == Summary - SUCCESS == No regressions found.

Re: [Intel-gfx] [PATCH 2/2] drm/amdgpu: Use per-device driver_features to disable atomic

2018-09-13 Thread Ville Syrjälä
On Thu, Sep 13, 2018 at 12:40:20PM -0400, Alex Deucher wrote: > On Thu, Sep 13, 2018 at 12:39 PM Michel Dänzer wrote: > > > > On 2018-09-13 6:31 p.m., Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Disable atomic on a per-device basis instead of for all devices. > > > Made possible

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/execlists: Delay updating ring register state after resume

2018-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/execlists: Delay updating ring register state after resume URL : https://patchwork.freedesktop.org/series/49654/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4817 -> Patchwork_10174 = == Summary - FAILURE

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/execlists: Delay updating ring register state after resume

2018-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/execlists: Delay updating ring register state after resume URL : https://patchwork.freedesktop.org/series/49654/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915/execlists: Delay updating ring register

Re: [Intel-gfx] [PATCH 1/2] drm/i915/execlists: Delay updating ring register state after resume

2018-09-13 Thread Tvrtko Ursulin
On 13/09/2018 18:32, Chris Wilson wrote: Now that we reload both RING_HEAD and RING_TAIL when rebinding the context, we do not need to scrub those registers immediately on resume. v2: Handle the perma-pinned contexts. v3: Set RING_TAIL on context-pin so that we always have known state in the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Replace some PAGE_SIZE with I915_GTT_PAGE_SIZE

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: Replace some PAGE_SIZE with I915_GTT_PAGE_SIZE URL : https://patchwork.freedesktop.org/series/49645/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4817 -> Patchwork_10173 = == Summary - WARNING == Minor unknown changes coming with

[Intel-gfx] [PATCH 1/2] drm/i915/execlists: Delay updating ring register state after resume

2018-09-13 Thread Chris Wilson
Now that we reload both RING_HEAD and RING_TAIL when rebinding the context, we do not need to scrub those registers immediately on resume. v2: Handle the perma-pinned contexts. v3: Set RING_TAIL on context-pin so that we always have known state in the context image for the ring registers and all

[Intel-gfx] [PATCH 2/2] drm/i915/execlists: Use coherent writes into the context image

2018-09-13 Thread Chris Wilson
That we use a WB mapping for updating the RING_TAIL register inside the context image even on !llc machines has been a source of consternation for every reader. It appears to work on bsw+, but it may just have been that we have been incredibly bad at detecting the errors. v2: With extra

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/nouveau: Disable atomic support on a per-device basis

2018-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/nouveau: Disable atomic support on a per-device basis URL : https://patchwork.freedesktop.org/series/49650/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4817 -> Patchwork_10172 = == Summary - FAILURE ==

Re: [Intel-gfx] [PATCH] drm/i915: Make 48bit full ppgtt configuration generic (v4)

2018-09-13 Thread Ville Syrjälä
On Thu, Sep 13, 2018 at 10:12:06AM -0700, Bob Paauwe wrote: > On Thu, 13 Sep 2018 20:05:54 +0300 > Ville Syrjälä wrote: > > > On Thu, Sep 13, 2018 at 10:02:57AM -0700, Bob Paauwe wrote: > > > On Wed, 12 Sep 2018 17:10:58 +0100 > > > Chris Wilson wrote: > > > > > > > Quoting Bob Paauwe

Re: [Intel-gfx] [PATCH] drm/i915: Make 48bit full ppgtt configuration generic (v4)

2018-09-13 Thread Bob Paauwe
On Thu, 13 Sep 2018 20:05:54 +0300 Ville Syrjälä wrote: > On Thu, Sep 13, 2018 at 10:02:57AM -0700, Bob Paauwe wrote: > > On Wed, 12 Sep 2018 17:10:58 +0100 > > Chris Wilson wrote: > > > > > Quoting Bob Paauwe (2018-09-12 17:04:30) > > > > diff --git

Re: [Intel-gfx] [PATCH] drm/i915: Make 48bit full ppgtt configuration generic (v4)

2018-09-13 Thread Ville Syrjälä
On Thu, Sep 13, 2018 at 10:02:57AM -0700, Bob Paauwe wrote: > On Wed, 12 Sep 2018 17:10:58 +0100 > Chris Wilson wrote: > > > Quoting Bob Paauwe (2018-09-12 17:04:30) > > > diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c > > > b/drivers/gpu/drm/i915/selftests/mock_gem_device.c > >

Re: [Intel-gfx] [PATCH] drm/i915: Make 48bit full ppgtt configuration generic (v4)

2018-09-13 Thread Bob Paauwe
On Wed, 12 Sep 2018 17:10:58 +0100 Chris Wilson wrote: > Quoting Bob Paauwe (2018-09-12 17:04:30) > > diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c > > b/drivers/gpu/drm/i915/selftests/mock_gem_device.c > > index 43ed8b28aeaa..33d7225edbbb 100644 > > ---

Re: [Intel-gfx] [PATCH 2/2] drm/amdgpu: Use per-device driver_features to disable atomic

2018-09-13 Thread Alex Deucher
On Thu, Sep 13, 2018 at 12:39 PM Michel Dänzer wrote: > > On 2018-09-13 6:31 p.m., Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Disable atomic on a per-device basis instead of for all devices. > > Made possible by the new device.driver_features thing. > > > > Cc: Alex Deucher > > Cc:

Re: [Intel-gfx] [PATCH 2/2] drm/amdgpu: Use per-device driver_features to disable atomic

2018-09-13 Thread Michel Dänzer
On 2018-09-13 6:31 p.m., Ville Syrjala wrote: > From: Ville Syrjälä > > Disable atomic on a per-device basis instead of for all devices. > Made possible by the new device.driver_features thing. > > Cc: Alex Deucher > Cc: "Christian König" > Cc: "David (ChunMing) Zhou" > Cc: Harry Wentland >

[Intel-gfx] ✗ Fi.CI.BAT: failure for i915, HDMI/DP audio with multiple monitors

2018-09-13 Thread Patchwork
== Series Details == Series: i915, HDMI/DP audio with multiple monitors URL : https://patchwork.freedesktop.org/series/49647/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4816 -> Patchwork_10171 = == Summary - FAILURE == Serious unknown changes coming with

[Intel-gfx] [PATCH 2/2] drm/amdgpu: Use per-device driver_features to disable atomic

2018-09-13 Thread Ville Syrjala
From: Ville Syrjälä Disable atomic on a per-device basis instead of for all devices. Made possible by the new device.driver_features thing. Cc: Alex Deucher Cc: "Christian König" Cc: "David (ChunMing) Zhou" Cc: Harry Wentland Cc: Michel Dänzer Suggested-by: Michel Dänzer Signed-off-by:

[Intel-gfx] [PATCH 1/2] drm/nouveau: Disable atomic support on a per-device basis

2018-09-13 Thread Ville Syrjala
From: Ville Syrjälä We now have per-device driver_features, so let's use that to disable atomic only for pre-nv50. Cc: Ben Skeggs Cc: Lyude Paul Cc: nouv...@lists.freedesktop.org Cc: Daniel Vetter Reviewed-by: Daniel Vetter Suggested-by: Daniel Vetter Signed-off-by: Ville Syrjälä ---

Re: [Intel-gfx] [PATCH 1/2] drm: Introduce per-device driver_features

2018-09-13 Thread Ville Syrjälä
On Thu, Sep 13, 2018 at 06:06:01PM +0300, Ville Syrjälä wrote: > On Thu, Sep 13, 2018 at 04:52:34PM +0200, Michel Dänzer wrote: > > On 2018-09-13 4:29 p.m., Ville Syrjälä wrote: > > > On Thu, Sep 13, 2018 at 03:50:01PM +0200, Daniel Vetter wrote: > > >> On Thu, Sep 13, 2018 at 04:16:21PM +0300,

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915, HDMI/DP audio with multiple monitors

2018-09-13 Thread Patchwork
== Series Details == Series: i915, HDMI/DP audio with multiple monitors URL : https://patchwork.freedesktop.org/series/49647/ State : warning == Summary == $ dim checkpatch origin/drm-tip a3ce8c6aec87 i915, HDMI/DP audio with multiple monitors -:25: WARNING:COMMIT_LOG_LONG_LINE: Possible

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled (rev8)

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled (rev8) URL : https://patchwork.freedesktop.org/series/42459/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4816_full -> Patchwork_10169_full = == Summary - SUCCESS == No

Re: [Intel-gfx] i915, HDMI/DP audio with multiple monitors

2018-09-13 Thread Takashi Iwai
On Thu, 13 Sep 2018 09:25:37 +0200, Bruno Prémont wrote: > > On Wed, 12 Sep 2018 20:06:43 +0200 Takashi Iwai wrote: > > On Wed, 12 Sep 2018 19:46:58 +0200, > > Ville Syrjälä wrote: > > > > > > On Tue, Sep 11, 2018 at 03:50:13PM +0200, Bruno Prémont wrote: > > > > Hi, > > > > > > > > I have a

Re: [Intel-gfx] [REGRESSION 4.19-rc2] sometimes hangs with black screen when resuming from suspend or hibernation (was: Re: Linux 4.19-rc2)

2018-09-13 Thread Martin Steigerwald
Ville Syrjälä - 12.09.18, 19:10: > On Tue, Sep 11, 2018 at 12:17:05PM +0200, Martin Steigerwald wrote: > > Cc´d Intel Gfx mailing list, in case somebody there knows something: > > > > Cc´d Thorsten for regression tracking… forgot initially. Can also > > open bug report at a later time but so far

Re: [Intel-gfx] i915, HDMI/DP audio with multiple monitors

2018-09-13 Thread Bruno Prémont
On Wed, 12 Sep 2018 20:06:43 +0200 Takashi Iwai wrote: > On Wed, 12 Sep 2018 19:46:58 +0200, > Ville Syrjälä wrote: > > > > On Tue, Sep 11, 2018 at 03:50:13PM +0200, Bruno Prémont wrote: > > > Hi, > > > > > > I have a system with multiple monitors and would like to send > > > notification

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Replace some PAGE_SIZE with I915_GTT_PAGE_SIZE

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: Replace some PAGE_SIZE with I915_GTT_PAGE_SIZE URL : https://patchwork.freedesktop.org/series/49645/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4816 -> Patchwork_10170 = == Summary - FAILURE == Serious unknown changes coming

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm: Introduce per-device driver_features

2018-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm: Introduce per-device driver_features URL : https://patchwork.freedesktop.org/series/49639/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4816_full -> Patchwork_10168_full = == Summary - SUCCESS == No

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Replace some PAGE_SIZE with I915_GTT_PAGE_SIZE

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: Replace some PAGE_SIZE with I915_GTT_PAGE_SIZE URL : https://patchwork.freedesktop.org/series/49645/ State : warning == Summary == $ dim checkpatch origin/drm-tip f7ce7c3fcf8c drm/i915: Replace some PAGE_SIZE with I915_GTT_PAGE_SIZE -:16:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled (rev8)

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled (rev8) URL : https://patchwork.freedesktop.org/series/42459/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4816 -> Patchwork_10169 = == Summary - SUCCESS == No

Re: [Intel-gfx] [PATCH] drm/i915: Replace some PAGE_SIZE with I915_GTT_PAGE_SIZE

2018-09-13 Thread Chris Wilson
Quoting Ville Syrjala (2018-09-13 16:04:05) > From: Ville Syrjälä > > Use I915_GTT_PAGE_SIZE when talking about GTT pages rather than > physical pages. Yup, these are all concerned with GTT units so we prefer I915_GTT_PAGE_SIZE. > There are some PAGE_SHIFTs left though. Not sure if we want to

Re: [Intel-gfx] [igt-dev] [PATH i-g-t] igt_sysfs: Avoid double closing the fd in igt_sysfs_scanf

2018-09-13 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-09-13 16:06:13) > From: Tvrtko Ursulin > > fdopen takes ownership of the fd so only one flavour of closing it is > needed. Indeed, I always seem to get burned by this. One day I might remember... Who am I kidding? :) > Signed-off-by: Tvrtko Ursulin Reviewed-by:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled (rev8)

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled (rev8) URL : https://patchwork.freedesktop.org/series/42459/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8d4f7a2b425b drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio

[Intel-gfx] [PATH i-g-t] igt_sysfs: Avoid double closing the fd in igt_sysfs_scanf

2018-09-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin fdopen takes ownership of the fd so only one flavour of closing it is needed. Signed-off-by: Tvrtko Ursulin --- lib/igt_sysfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/igt_sysfs.c b/lib/igt_sysfs.c index 9012cc73f6e3..d323b81dd986 100644

Re: [Intel-gfx] [PATCH 1/2] drm: Introduce per-device driver_features

2018-09-13 Thread Ville Syrjälä
On Thu, Sep 13, 2018 at 04:52:34PM +0200, Michel Dänzer wrote: > On 2018-09-13 4:29 p.m., Ville Syrjälä wrote: > > On Thu, Sep 13, 2018 at 03:50:01PM +0200, Daniel Vetter wrote: > >> On Thu, Sep 13, 2018 at 04:16:21PM +0300, Ville Syrjala wrote: > >>> From: Ville Syrjälä > >>> > >>> We wish to

[Intel-gfx] [PATCH] drm/i915: Replace some PAGE_SIZE with I915_GTT_PAGE_SIZE

2018-09-13 Thread Ville Syrjala
From: Ville Syrjälä Use I915_GTT_PAGE_SIZE when talking about GTT pages rather than physical pages. There are some PAGE_SHIFTs left though. Not sure if we want to introduce I915_GTT_PAGE_SHIFT or what? Cc: Chris Wilson Suggested-by: Chris Wilson # at least some of it :) Signed-off-by: Ville

Re: [Intel-gfx] [PATCH 1/2] drm: Introduce per-device driver_features

2018-09-13 Thread Michel Dänzer
On 2018-09-13 4:29 p.m., Ville Syrjälä wrote: > On Thu, Sep 13, 2018 at 03:50:01PM +0200, Daniel Vetter wrote: >> On Thu, Sep 13, 2018 at 04:16:21PM +0300, Ville Syrjala wrote: >>> From: Ville Syrjälä >>> >>> We wish to control certain driver_features flags on a per-device basis >>> while still

Re: [Intel-gfx] [PATCH v5] drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled

2018-09-13 Thread Takashi Iwai
On Thu, 13 Sep 2018 15:54:37 +0200, Imre Deak wrote: > > On Wed, Sep 12, 2018 at 08:18:37PM +0200, Takashi Iwai wrote: > > On Wed, 12 Sep 2018 15:18:47 +0200, > > Imre Deak wrote: > > > > > > +Takashi > > > > > > On Wed, Sep 12, 2018 at 04:18:12PM +0300, Imre Deak wrote: > > > > Hi Kumar,

Re: [Intel-gfx] [PATCH 1/2] drm: Introduce per-device driver_features

2018-09-13 Thread Ville Syrjälä
On Thu, Sep 13, 2018 at 03:50:01PM +0200, Daniel Vetter wrote: > On Thu, Sep 13, 2018 at 04:16:21PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We wish to control certain driver_features flags on a per-device basis > > while still sharing a single drm_driver instance across all

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm: Introduce per-device driver_features

2018-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm: Introduce per-device driver_features URL : https://patchwork.freedesktop.org/series/49639/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4816 -> Patchwork_10168 = == Summary - SUCCESS == No regressions found.

Re: [Intel-gfx] [PATCH v5] drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled

2018-09-13 Thread Imre Deak
On Wed, Sep 12, 2018 at 08:18:37PM +0200, Takashi Iwai wrote: > On Wed, 12 Sep 2018 15:18:47 +0200, > Imre Deak wrote: > > > > +Takashi > > > > On Wed, Sep 12, 2018 at 04:18:12PM +0300, Imre Deak wrote: > > > Hi Kumar, Takashi, > > > > > > On Tue, Jun 19, 2018 at 03:01:11PM -0700, Abhay Kumar

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Mark up a couple of KMS debug messages as such

2018-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Mark up a couple of KMS debug messages as such URL : https://patchwork.freedesktop.org/series/49641/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4816 -> Patchwork_10167 = == Summary - FAILURE ==

Re: [Intel-gfx] [PATCH 1/2] drm: Introduce per-device driver_features

2018-09-13 Thread Daniel Vetter
On Thu, Sep 13, 2018 at 04:16:21PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > We wish to control certain driver_features flags on a per-device basis > while still sharing a single drm_driver instance across all the > devices. To that end introduce device.driver_features. By default >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915: Mark up a couple of KMS debug messages as such

2018-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Mark up a couple of KMS debug messages as such URL : https://patchwork.freedesktop.org/series/49641/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Mark up a couple of KMS debug messages as such

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: Mark up a couple of KMS debug messages as such

2018-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Mark up a couple of KMS debug messages as such URL : https://patchwork.freedesktop.org/series/49641/ State : warning == Summary == $ dim checkpatch origin/drm-tip b7501effb8ce drm/i915: Mark up a couple of KMS debug messages

Re: [Intel-gfx] [PATCH v3] drm: Differentiate the lack of an interface from invalid parameter

2018-09-13 Thread Daniel Vetter
On Wed, Sep 12, 2018 at 10:29:42AM +0100, Chris Wilson wrote: > If the ioctl is not supported on a particular piece of HW/driver > combination, report ENOTSUPP so that it can be easily distinguished from > both the lack of the ioctl and from a regular invalid parameter. > > v2: Across all the kms

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Clear DRIVER_ATOMIC on a per-device basis

2018-09-13 Thread Chris Wilson
Quoting Ville Syrjala (2018-09-13 14:16:22) > From: Ville Syrjälä > > Currently we're clearing DRIVER_ATOMIC in driver.driver_features > for older platforms. This will not work correctly should we ever > have a system with and old and new GPU in it. While that is not > possible currently let's

Re: [Intel-gfx] [PATCH 1/2] drm: Introduce per-device driver_features

2018-09-13 Thread Chris Wilson
Quoting Ville Syrjala (2018-09-13 14:16:21) > From: Ville Syrjälä > > We wish to control certain driver_features flags on a per-device basis > while still sharing a single drm_driver instance across all the > devices. To that end introduce device.driver_features. By default > it will be set to

  1   2   >