> -Original Message-
> From: Nikula, Jani
> Sent: Wednesday, October 3, 2018 5:11 PM
> To: Ville Syrjälä ; Kulkarni, Vandita
>
> Cc: intel-gfx@lists.freedesktop.org; Zanoni, Paulo R
>
> Subject: Re: [Intel-gfx] [RFC 1/3] drm/i915/icl: Restructure ICL DPLL enable
> functionality
>
> On
On Wed, Oct 03, 2018 at 04:43:53PM -0700, Lucas De Marchi wrote:
> On Wed, Oct 03, 2018 at 04:30:36PM -0700, Rodrigo Vivi wrote:
> > On Mon, Sep 24, 2018 at 09:54:35AM -0700, Lucas De Marchi wrote:
> > > Display WA #1178 is meant to fix Aux channel voltage swing too low with
> > > some type C
== Series Details ==
Series: drm/i915/icl: apply Display WA #1178 to fix type C dongles
URL : https://patchwork.freedesktop.org/series/50102/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4925 -> Patchwork_10352 =
== Summary - SUCCESS ==
No regressions found.
On Wed, Oct 03, 2018 at 04:30:36PM -0700, Rodrigo Vivi wrote:
> On Mon, Sep 24, 2018 at 09:54:35AM -0700, Lucas De Marchi wrote:
> > Display WA #1178 is meant to fix Aux channel voltage swing too low with
> > some type C dongles. Although it is for type C, of ICL it only applies
> > to combo phy
On Mon, Sep 24, 2018 at 09:54:35AM -0700, Lucas De Marchi wrote:
> Display WA #1178 is meant to fix Aux channel voltage swing too low with
> some type C dongles. Although it is for type C, of ICL it only applies
> to combo phy and not to eDP. This means we need to apply the WA only on
> Aux B.
>
== Series Details ==
Series: Refactor and Add helper function for combophy/tc ports
URL : https://patchwork.freedesktop.org/series/50484/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4919_full -> Patchwork_10341_full =
== Summary - SUCCESS ==
No regressions found.
On 03/10/18 08:24, Chris Wilson wrote:
Quoting Daniele Ceraolo Spurio (2018-10-03 01:12:57)
On 02/10/18 15:39, Patchwork wrote:
== Series Details ==
Series: series starting with [v2,1/3] drm/i915/guc: init GuC descriptors after
GuC load
URL :
On Mon, Oct 01, 2018 at 09:23:38AM +0200, Daniel Vetter wrote:
> On Mon, Sep 24, 2018 at 02:08:14PM -0700, Radhakrishna Sripada wrote:
> > At times 12bpc HDMI cannot be driven due to faulty cables, dongles
> > level shifters etc. To workaround them we may need to drive the output
> > at a lower
== Series Details ==
Series: drm/i915/execlists: Flush the CS events before unpinning
URL : https://patchwork.freedesktop.org/series/50494/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4919_full -> Patchwork_10340_full =
== Summary - SUCCESS ==
No regressions found.
== Series Details ==
Series: series starting with [v4,1/7] drm/i915/psr: Share PSR and PSR2 exit mask
URL : https://patchwork.freedesktop.org/series/50526/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4925 -> Patchwork_10351 =
== Summary - SUCCESS ==
No regressions
On Wednesday, October 3, 2018 1:50:30 PM PDT José Roberto de Souza wrote:
> For PSR2 there is no register to tell HW to keep main link enabled
> while PSR2 is active, so don't configure sink DPCD with a
> wrong value.
>
> v4: rebased on top of the patch removing link standby from debugfs
On Wednesday, October 3, 2018 1:50:29 PM PDT José Roberto de Souza wrote:
> Main link stand by is only valid for PSR1 as it is not possible to
> enable PSR2 and keep main link on but even for PSR1 it is not useful
> information and it can be removed without any drawbacks.
> But if someone still
== Series Details ==
Series: series starting with [v4,1/7] drm/i915/psr: Share PSR and PSR2 exit mask
URL : https://patchwork.freedesktop.org/series/50526/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Commit: drm/i915/psr: Share PSR and PSR2 exit mask
Okay!
Commit: drm/i915/psr:
== Series Details ==
Series: drm/i915: Optionally disable automatic recovery after a GPU reset (rev2)
URL : https://patchwork.freedesktop.org/series/50458/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4919_full -> Patchwork_10339_full =
== Summary - FAILURE ==
Serious
Main link stand by is only valid for PSR1 as it is not possible to
enable PSR2 and keep main link on but even for PSR1 it is not useful
information and it can be removed without any drawbacks.
But if someone still wants to check that this patch is providing the
full PSR_CTL register value so user
Now both PSR and PSR2 have the same exit mask, so let's share then
instead of have the same code 2 times.
Reviewed-by: Dhinakaran Pandiyan
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/intel_psr.c | 34
1 file changed, 13 insertions(+), 21
ICL spec states that this bit is now reserved.
Bspec: 7722
v2(Dhinakaran and Jani):
- instead of remove bit in gen11 now only setting if if gen < 11
- changed commit title
Cc: Jani Nikula
Reviewed-by: Dhinakaran Pandiyan
Signed-off-by: José Roberto de Souza
---
For PSR2 there is no register to tell HW to keep main link enabled
while PSR2 is active, so don't configure sink DPCD with a
wrong value.
v4: rebased on top of the patch removing link standby from debugfs
Cc: Dhinakaran Pandiyan
Signed-off-by: José Roberto de Souza
---
This WA also works fine for PSR2, triggering a selective update when
possible.
Acked-by: Dhinakaran Pandiyan
Reviewed-by: Rodrigo Vivi
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/intel_psr.c | 24 ++--
1 file changed, 10 insertions(+), 14 deletions(-)
ALPM is a requirement and we don't need to keep it's cached, what
were done in commit 97c9de66ca80
("drm/i915/psr: Fix ALPM cap check for PSR2") but the alpm was not
removed from i915_psr.
Reviewed-by: Dhinakaran Pandiyan
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/i915_drv.h
We are already handling all PSR2 errors, so we can drop this TODO.
Reviewed-by: Dhinakaran Pandiyan
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/intel_psr.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
Daniel Vetter writes:
> drm_plane_helper_disable is a non-atomic drivers only function, and
> will blow up (since no one passes the locking context it needs).
>
> Atomic drivers which want to quiescent their hw on unload should
> use drm_atomic_helper_shutdown() instead.
>
> v2: Rebase.
I've
On Wed, Oct 03, 2018 at 12:36:01PM -0700, Dhinakaran Pandiyan wrote:
> MST is enabled by default on all platforms that support it. I don't think
> we should be providing a switch to work around MST issues as the feature
> has been supported for a while now. Let's kill this module parameter
> that
Hi Dave,
Here goes drm-intel-fixes-2018-10-03:
There's one fix for our zlib incomlete Z_FINISH on our error state handling,
plus a compilation warning fix and a tiny code clean up.
Thanks,
Rodrigo.
The following changes since commit 17b57b1883c1285f3d0dc2266e8f79286a7bef38:
Linux 4.19-rc6
== Series Details ==
Series: drm/i915: Always try to reset the GPU on takeover (rev2)
URL : https://patchwork.freedesktop.org/series/50497/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4924 -> Patchwork_10350 =
== Summary - SUCCESS ==
No regressions found.
External
On Thu, Sep 27, 2018 at 10:10:07AM +0800, Bin Meng wrote:
> On Thu, Sep 27, 2018 at 12:57 AM Bjorn Helgaas wrote:
> > On Wed, Sep 26, 2018 at 08:14:01AM -0700, Bin Meng wrote:
> > > Add more PCI IDs to the Intel GPU "spurious interrupt" quirk table,
> > > which are known to break.
> >
> > Do you
== Series Details ==
Series: drm/i915/dp: Remove i915.enable_dp_mst module parameter
URL : https://patchwork.freedesktop.org/series/50520/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4924 -> Patchwork_10349 =
== Summary - SUCCESS ==
No regressions found.
External
Hi Dave,
We've cut over to misc-next-fixes for 4.20, so just one patch this week. It's
Neil's fix for mali binary driver.
drm-misc-next-fixes-2018-10-03:
- Add EXPERT config option to allow phys mem leak from fbdev for blob drivers
(Neil)
Cc: Neil Armstrong
Cheers, Sean
The following
When we first introduced the reset to sanitize the GPU on taking over
from the BIOS and before returning control to third parties (the BIOS!),
we restricted it to only systems utilizing HW contexts as we were
uncertain of how stable our reset mechanism truly was. We now have
reasonable coverage
MST is enabled by default on all platforms that support it. I don't think
we should be providing a switch to work around MST issues as the feature
has been supported for a while now. Let's kill this module parameter
that we also do not test in CI.
Cc: Rodrigo Vivi
Cc: Ville Syrjälä
Cc: Jani
On Tue, Oct 02, 2018 at 02:50:55PM -0700, Manasi Navare wrote:
> This patch explains the DRM_MODE_PROP_IMMUTABLE flag a bit better
> by telling which function to call if kernel wants to update
> drm object's immutable properties.
>
> Suggested-by: Daniel Vetter
> Cc: Daniel Vetter
>
== Series Details ==
Series: drm/i915: Provide more clues as to why MST is/is not used
URL : https://patchwork.freedesktop.org/series/50518/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4923 -> Patchwork_10348 =
== Summary - WARNING ==
Minor unknown changes coming with
On Wednesday, October 3, 2018 11:42:10 AM PDT Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Always print out the information whether the port and sink can each
> do MST. And let's include the modparam in the debug output as well.
> Makes life a little less confusing when you don't have to
Alexandru-Cosmin Gheorghe kirjoitti 3.10.2018 klo 20.18:
On Wed, Oct 03, 2018 at 02:31:08PM +0300, Juha-Pekka Heikkila wrote:
Hi Alex,
For my patches there seems limited interest to get them merged before IGT
support these modes..I'm not holding my breath for this.
I'm interested if that
On Wed, Oct 03, 2018 at 11:42:14AM -0700, Radhakrishna Sripada wrote:
> On Mon, Oct 01, 2018 at 04:48:01PM +0300, Ville Syrjälä wrote:
> > On Mon, Sep 24, 2018 at 02:08:15PM -0700, Radhakrishna Sripada wrote:
> > > Use the newly added "max bpc" connector property to limit pipe bpp.
> > >
> > >
From: Ville Syrjälä
Always print out the information whether the port and sink can each
do MST. And let's include the modparam in the debug output as well.
Makes life a little less confusing when you don't have to wonder
why MST isn't kicking in.
This does cause a slight change in our behaviour
== Series Details ==
Series: drm/i915: Fix the HDMI hot plug disconnection failure (rev2)
URL : https://patchwork.freedesktop.org/series/50477/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4923 -> Patchwork_10347 =
== Summary - FAILURE ==
Serious unknown changes coming
On Mon, Oct 01, 2018 at 04:48:01PM +0300, Ville Syrjälä wrote:
> On Mon, Sep 24, 2018 at 02:08:15PM -0700, Radhakrishna Sripada wrote:
> > Use the newly added "max bpc" connector property to limit pipe bpp.
> >
> > V3: Use drm_connector_state to access the "max bpc" property
> > V4: Initialize
== Series Details ==
Series: drm/i915: Cache the error string (rev5)
URL : https://patchwork.freedesktop.org/series/46777/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4919_full -> Patchwork_10338_full =
== Summary - SUCCESS ==
No regressions found.
== Known
This seems really useful for the DSC PPS bitfields in i915_reg.h
since its a lot of bitfileds mapped from the spec to the macros for
for MASKS and SHIFTS for 128 bytes of PPS data.
This patch set only updates them in case of few registers.
All the other MASKS and SHIFTS clean up for all i915
On some platforms, slowly unplugging (wiggling) the HDMI cable makes
the kernel to believe the HDMI display still connected. This is because
the HDMI DDC lines are disconnected sometimes later after the hot-plug
interrupt triggered. Use the hot plug live states to honor HDMI hot plug
status in
On Wed, Oct 03, 2018 at 12:51:56PM +0530, Mahesh Kumar wrote:
> This patch creates a function/wrapper to check if port is combophy port
> instead of explicitly comparing ports.
>
> Signed-off-by: Mahesh Kumar
> Cc: Madhav Chauhan
> Cc: Manasi Navare
> ---
> drivers/gpu/drm/i915/intel_ddi.c
On Wed, Oct 03, 2018 at 12:51:57PM +0530, Mahesh Kumar wrote:
> Instead of directly comparing HPD pins use intel_port_is_combophy/tc
> helper functions to distinguish between combophy/TC ports.
>
> Signed-off-by: Mahesh Kumar
> Cc: Manasi Navare
Reviewed-by: Rodrigo Vivi
> ---
>
On Wed, Oct 03, 2018 at 12:51:56PM +0530, Mahesh Kumar wrote:
> This patch creates a function/wrapper to check if port is combophy port
> instead of explicitly comparing ports.
>
> Signed-off-by: Mahesh Kumar
> Cc: Madhav Chauhan
> Cc: Manasi Navare
Reviewed-by: Rodrigo Vivi
> ---
>
On Wed, Oct 03, 2018 at 12:51:59PM +0530, Mahesh Kumar wrote:
> From: Vandita Kulkarni
>
> Use intel_port_is_tc and intel_port_is_combophy
> functions to replace the individual port checks
> from port C to F and port A to B respectively.
>
> Signed-off-by: Vandita Kulkarni
> Signed-off-by:
On Wed, Oct 03, 2018 at 02:31:08PM +0300, Juha-Pekka Heikkila wrote:
> Hi Alex,
>
> For my patches there seems limited interest to get them merged before IGT
> support these modes..I'm not holding my breath for this.
I'm interested if that counts.
I asked the same question on the
On Wed, Oct 03, 2018 at 07:05:21PM +0300, Jani Nikula wrote:
> Introduce REG_BIT(n) to define register bits and REG_FIELD_MASK(h, l) to
> define register field masks.
>
> We define the above as wrappers to BIT() and GENMASK() respectively to
> force u32 type to go with our register size.
== Series Details ==
Series: drm/i915: introduce macros to define register contents
URL : https://patchwork.freedesktop.org/series/50513/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4922 -> Patchwork_10346 =
== Summary - SUCCESS ==
No regressions found.
External
== Series Details ==
Series: series starting with [v2,1/3] drm/i915: Restore vblank interrupts
earlier (rev4)
URL : https://patchwork.freedesktop.org/series/50393/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4922 -> Patchwork_10345 =
== Summary - SUCCESS ==
No
== Series Details ==
Series: drm/i915: introduce macros to define register contents
URL : https://patchwork.freedesktop.org/series/50513/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Commit: drm/i915: introduce REG_BIT() and REG_FIELD_MASK() to define register
contents
Okay!
== Series Details ==
Series: drm/i915: introduce macros to define register contents
URL : https://patchwork.freedesktop.org/series/50513/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
fa2aca822675 drm/i915: introduce REG_BIT() and REG_FIELD_MASK() to define
register contents
On Wed, Oct 03, 2018 at 05:50:52PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Print the plane hw state readout results in the common format
> we already use for pipes and encoders. Also print some clearer
> debug messages when we disable planes during the early phases
> of state
On Wed, Oct 03, 2018 at 05:50:17PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> When we decide that a plane is attached to the wrong pipe we try
> to turn off said plane. However we are passing around the crtc we
> think that the plane is supposed to be using rather than the crtc
> it
Slightly verbose, but does away with hand rolled shifts. Ties the field
values with the mask defining the field.
Unfortunately we don't get the build-time checks of FIELD_PREP() due to
it not evaluating to a constant expression.
Cc: Chris Wilson
Cc: Joonas Lahtinen
Cc: Michal Wajdeczko
Cc:
Introduce REG_BIT(n) to define register bits and REG_FIELD_MASK(h, l) to
define register field masks.
We define the above as wrappers to BIT() and GENMASK() respectively to
force u32 type to go with our register size. Additionally, the specified
type will be helpful with follow-up to define and
bitfield.h defines FIELD_GET() and FIELD_PREP() macros to access
bitfields using the mask alone, with no need for separate shift. Indeed,
the shift is redundant.
For the most part, FIELD_GET() is shorter than masking followed by
shift, and arguably has more clarity.
FIELD_PREP() can get more
Actual serious v1 after the RFC [1].
The major change is to add local wrappers or versions of the BIT(),
GENMASK(), and FIELD_PREP() macros for i915_reg.h to ensure u32 type and
integer constant expressions.
It's a bit of a meh but does provide an opportunity for unified local
naming of the
== Series Details ==
Series: series starting with [v2,1/3] drm/i915: Restore vblank interrupts
earlier (rev4)
URL : https://patchwork.freedesktop.org/series/50393/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
c6a938a3e0a7 drm/i915: Restore vblank interrupts earlier
Quoting Daniele Ceraolo Spurio (2018-10-03 01:12:57)
>
>
> On 02/10/18 15:39, Patchwork wrote:
> > == Series Details ==
> >
> > Series: series starting with [v2,1/3] drm/i915/guc: init GuC descriptors
> > after GuC load
> > URL : https://patchwork.freedesktop.org/series/50464/
> > State :
On Tue, 02 Oct 2018 23:54:28 +0200, Daniele Ceraolo Spurio
wrote:
GuC stores some data in there, which might be stale after a reset.
We already reset the WQ head and tail, but more things are being moved
to the descriptor with the interface updates. Instead of trying to track
them one by
On Wed, Oct 03, 2018 at 07:51:24AM -0700, Rodrigo Vivi wrote:
> On Wed, Oct 03, 2018 at 11:27:42AM +0530, Yadav, Jyoti R wrote:
> >
> >
> > On 10/3/2018 10:36 AM, Vivi, Rodrigo wrote:
> > >
> > > > On Oct 2, 2018, at 9:20 PM, Yadav, Jyoti R
> > > > wrote:
> > > >
> > > > DC5 and DC6 counter
On Wed, Oct 03, 2018 at 11:27:42AM +0530, Yadav, Jyoti R wrote:
>
>
> On 10/3/2018 10:36 AM, Vivi, Rodrigo wrote:
> >
> > > On Oct 2, 2018, at 9:20 PM, Yadav, Jyoti R
> > > wrote:
> > >
> > > DC5 and DC6 counter register tells about residency of DC5 and DC6.
> > > These registers are same
From: Ville Syrjälä
Print the plane hw state readout results in the common format
we already use for pipes and encoders. Also print some clearer
debug messages when we disable planes during the early phases
of state readout/sanitization.
v2: Rebase
Signed-off-by: Ville Syrjälä
---
From: Ville Syrjälä
When we decide that a plane is attached to the wrong pipe we try
to turn off said plane. However we are passing around the crtc we
think that the plane is supposed to be using rather than the crtc
it is currently using. That doesn't work all that well because
we may have to
From: Ville Syrjälä
Plane sanitation needs vblank interrupts (on account of CxSR disable).
So let's restore vblank interrupts earlier.
v2: Make it actually build
v3: Add comment to explain why we need this (Daniel)
Cc: sta...@vger.kernel.org
Cc: Dennis
Tested-by: Dennis
Bugzilla:
== Series Details ==
Series: drm/i915: First cleanup pass to get rid of more crtc->config users.
URL : https://patchwork.freedesktop.org/series/50506/
State : failure
== Summary ==
CALLscripts/checksyscalls.sh
DESCEND objtool
CHK include/generated/compile.h
CC [M]
== Series Details ==
Series: drm/i915: Always try to reset the GPU on takeover
URL : https://patchwork.freedesktop.org/series/50497/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4920 -> Patchwork_10342 =
== Summary - FAILURE ==
Serious unknown changes coming with
== Series Details ==
Series: 21st century intel_gpu_top
URL : https://patchwork.freedesktop.org/series/50498/
State : failure
== Summary ==
Applying: drm/i915/pmu: Fix enable count array size and bounds checking
Applying: drm/i915: Keep a count of requests waiting for a slot on GPU
Applying:
On Wed, Oct 03, 2018 at 10:53:11AM +0200, Daniel Vetter wrote:
> On Tue, Oct 02, 2018 at 05:21:36PM +0300, Ville Syrjälä wrote:
> > On Tue, Oct 02, 2018 at 02:11:34PM +0200, Daniel Vetter wrote:
> > > On Mon, Oct 01, 2018 at 05:31:20PM +0300, Ville Syrjala wrote:
> > > > From: Ville Syrjälä
> > >
On Wed, Oct 03, 2018 at 03:37:15PM +0200, Maarten Lankhorst wrote:
> These functions already have a pointer to the correct state,
> so use it instead of crtc->config.
>
> Signed-off-by: Maarten Lankhorst
> ---
> drivers/gpu/drm/i915/intel_display.c | 60 ++--
> 1 file
On Wed, Oct 03, 2018 at 03:37:14PM +0200, Maarten Lankhorst wrote:
> Fixing chv_set_phy_signal_level() still requires too many levels of
> indirection to pass crtc_state along.
>
> Signed-off-by: Maarten Lankhorst
> ---
> drivers/gpu/drm/i915/intel_dpio_phy.c | 4 ++--
> 1 file changed, 2
On Wed, Oct 03, 2018 at 03:37:13PM +0200, Maarten Lankhorst wrote:
> Signed-off-by: Maarten Lankhorst
> ---
> drivers/gpu/drm/i915/intel_dp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index
On Wed, Oct 03, 2018 at 03:37:12PM +0200, Maarten Lankhorst wrote:
> fbdev init shouldn't race with userspace since it's called from
> intel_modeset_init, so it's safe to dereference crtc->state and
> assume nothing changed yet.
>
> At least not more harmful than crtc->config.
>
> Signed-off-by:
On Wed, Oct 03, 2018 at 03:37:11PM +0200, Maarten Lankhorst wrote:
> Signed-off-by: Maarten Lankhorst
With a bit if commit msg added
Reviewed-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 15 ---
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git
On Wed, Oct 03, 2018 at 03:37:10PM +0200, Maarten Lankhorst wrote:
> Do not rely on crtc->config any more. Remove the assertion from
> ibx_pch_dpll_disable, because we the dpll state tracking should
> already handle this case correctly.
>
> Signed-off-by: Maarten Lankhorst
> ---
>
On Wed, Oct 03, 2018 at 03:37:09PM +0200, Maarten Lankhorst wrote:
> Signed-off-by: Maarten Lankhorst
commit msg
Otherwise
Reviewed-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/intel_display.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git
On Wed, Oct 03, 2018 at 03:37:08PM +0200, Maarten Lankhorst wrote:
> Signed-off-by: Maarten Lankhorst
> ---
> drivers/gpu/drm/i915/intel_display.c | 17 +
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c
>
On Wed, Oct 03, 2018 at 03:37:07PM +0200, Maarten Lankhorst wrote:
> Signed-off-by: Maarten Lankhorst
> ---
> drivers/gpu/drm/i915/intel_display.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c
>
On Wed, Oct 03, 2018 at 03:37:06PM +0200, Maarten Lankhorst wrote:
> Signed-off-by: Maarten Lankhorst
> ---
> drivers/gpu/drm/i915/intel_display.c | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c
>
On Wed, Oct 03, 2018 at 03:37:05PM +0200, Maarten Lankhorst wrote:
> Signed-off-by: Maarten Lankhorst
> ---
> drivers/gpu/drm/i915/intel_display.c | 41 ++--
> 1 file changed, 20 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c
>
On Wed, Oct 03, 2018 at 03:37:04PM +0200, Maarten Lankhorst wrote:
> Signed-off-by: Maarten Lankhorst
> ---
> drivers/gpu/drm/i915/intel_display.c | 91 ++--
> 1 file changed, 45 insertions(+), 46 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c
>
On Wed, Oct 03, 2018 at 03:37:03PM +0200, Maarten Lankhorst wrote:
> One more user of crtc->config down. :)
>
> Signed-off-by: Maarten Lankhorst
> ---
> drivers/gpu/drm/i915/intel_display.c | 72 ++--
> 1 file changed, 36 insertions(+), 36 deletions(-)
>
> diff --git
== Series Details ==
Series: Refactor and Add helper function for combophy/tc ports
URL : https://patchwork.freedesktop.org/series/50484/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4919 -> Patchwork_10341 =
== Summary - WARNING ==
Minor unknown changes coming with
On Wed, Oct 03, 2018 at 01:34:47PM +0100, Chris Wilson wrote:
> Quoting Ville Syrjälä (2018-10-03 13:28:30)
> > On Wed, Oct 03, 2018 at 12:29:53PM +0100, Chris Wilson wrote:
> > > Quoting Stanislav Lisovskiy (2018-10-02 10:38:53)
> > > > diff --git a/src/sna/sna_render.h b/src/sna/sna_render.h
> >
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 36a8d5fb8881..57c81e8e44be 100644
---
Fixing chv_set_phy_signal_level() still requires too many levels of
indirection to pass crtc_state along.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_dpio_phy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dpio_phy.c
fbdev init shouldn't race with userspace since it's called from
intel_modeset_init, so it's safe to dereference crtc->state and
assume nothing changed yet.
At least not more harmful than crtc->config.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_fbdev.c | 8
1 file
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_dp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 15a981ef5966..d9cc52b2ba79 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 56784ae26369..36a8d5fb8881 100644
---
These functions already have a pointer to the correct state,
so use it instead of crtc->config.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 60 ++--
1 file changed, 30 insertions(+), 30 deletions(-)
diff --git
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 91574abafb65..56784ae26369 100644
---
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 91 ++--
1 file changed, 45 insertions(+), 46 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 264feed76c08..701caab4e382 100644
---
One more user of crtc->config down. :)
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 72 ++--
1 file changed, 36 insertions(+), 36 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_ddi.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index b6594948b617..9e82281b4fdf 100644
---
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index ca5e4d72d476..91574abafb65 100644
---
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 41 ++--
1 file changed, 20 insertions(+), 21 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 701caab4e382..ca5e4d72d476 100644
---
Do not rely on crtc->config any more. Remove the assertion from
ibx_pch_dpll_disable, because we the dpll state tracking should
already handle this case correctly.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 14 ++--
drivers/gpu/drm/i915/intel_dpll_mgr.c
There are a lot of places where we use crtc->config, but shouldn't and easy
ways around it are available. In many cases, either the function itself, or
the calling function has a pointer to the correct state, so use it when
available.
This is not a full cleanup yet, want to send it in parts. :)
== Series Details ==
Series: drm/i915/execlists: Flush the CS events before unpinning
URL : https://patchwork.freedesktop.org/series/50494/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4919 -> Patchwork_10340 =
== Summary - SUCCESS ==
No regressions found.
External
On Wed, 2018-10-03 at 12:29 +0100, Chris Wilson wrote:
> Quoting Stanislav Lisovskiy (2018-10-02 10:38:53)
> > diff --git a/src/sna/sna_render.h b/src/sna/sna_render.h
> > index 6669af9d..ef88d1f9 100644
> > --- a/src/sna/sna_render.h
> > +++ b/src/sna/sna_render.h
> > @@ -139,20 +139,25 @@ struct
1 - 100 of 204 matches
Mail list logo
