[Intel-gfx] ✓ Fi.CI.IGT: success for firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev3)

2018-10-04 Thread Patchwork
== Series Details == Series: firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev3) URL : https://patchwork.freedesktop.org/series/49678/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4932_full -> Patchwork_10367_full = == Summary - WARNING == Minor unknown

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/csr Added DC5 and DC6 counter register for ICL in debugfs entry. (rev4)

2018-10-04 Thread Patchwork
== Series Details == Series: drm/i915/csr Added DC5 and DC6 counter register for ICL in debugfs entry. (rev4) URL : https://patchwork.freedesktop.org/series/49800/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4933 -> Patchwork_10372 = == Summary - SUCCESS == No

[Intel-gfx] [PATCH] [intel-gfx] drm/i915/csr Added DC5 and DC6 counter register for ICL in debugfs entry.

2018-10-04 Thread Jyoti Yadav
DC5 and DC6 counter register tells about residency of DC5 and DC6. These registers are same for SKL and ICL. v2 : Remove csr_version check. Added generic check regarding DC counters for Gen9 onwards. (Rodrigo) v3 : Simplified gen checks. (Chris) v4 : Simplified "if" ladder for multiple

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix VIDEO_DIP_CTL bit shifts

2018-10-04 Thread Patchwork
== Series Details == Series: drm/i915: Fix VIDEO_DIP_CTL bit shifts URL : https://patchwork.freedesktop.org/series/50573/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4932_full -> Patchwork_10365_full = == Summary - WARNING == Minor unknown changes coming with

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/psr: Reduce PSR2 "frames before selective update entry"

2018-10-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/psr: Reduce PSR2 "frames before selective update entry" URL : https://patchwork.freedesktop.org/series/50593/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4933 -> Patchwork_10371 = == Summary - SUCCESS ==

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/psr: Reduce PSR2 "frames before selective update entry"

2018-10-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/psr: Reduce PSR2 "frames before selective update entry" URL : https://patchwork.freedesktop.org/series/50593/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915/psr: Reduce PSR2 "frames before selective

[Intel-gfx] [PATCH 1/2] drm/i915/psr: Reduce PSR2 "frames before selective update entry"

2018-10-04 Thread Dhinakaran Pandiyan
The hardware can start selective update following capture of a full frame in the remote frame buffer, there is no need to wait any longer. Set "Frames Before SU Entry" bitfield to the default value of 1. Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_psr.c | 3 +-- 1 file

[Intel-gfx] [PATCH 2/2] drm/i915/psr: Set Y coordinate valid for Gen10+ display

2018-10-04 Thread Dhinakaran Pandiyan
PSR2 sinks that require Y coordinates for selective update also need the Y coordinate Valid bit in VSC SDP. Spec: eDP 1.4b VSC payload extension for PSR2 operation (Table 6-12) Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_psr.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Intel-gfx] [PATCH] drm/i915: Fix VIDEO_DIP_CTL bit shifts

2018-10-04 Thread Dhinakaran Pandiyan
On Thu, 2018-10-04 at 17:27 -0700, Manasi Navare wrote: > On Thu, Oct 04, 2018 at 05:00:06PM -0700, Dhinakaran Pandiyan wrote: > > On Thu, 2018-10-04 at 16:28 -0700, Manasi Navare wrote: > > > On Thu, Oct 04, 2018 at 04:13:26PM -0700, Dhinakaran Pandiyan > > > wrote: > > > > On Thu, 2018-10-04 at

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/6] drm/i915/icl: Add WaEnable32PlaneMode

2018-10-04 Thread Patchwork
== Series Details == Series: series starting with [v2,1/6] drm/i915/icl: Add WaEnable32PlaneMode URL : https://patchwork.freedesktop.org/series/50569/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4932_full -> Patchwork_10364_full = == Summary - SUCCESS == No

[Intel-gfx] ✗ Fi.CI.BAT: failure for Fix legacy DPMS changes with MST (rev4)

2018-10-04 Thread Patchwork
== Series Details == Series: Fix legacy DPMS changes with MST (rev4) URL : https://patchwork.freedesktop.org/series/49878/ State : failure == Summary == Applying: drm/atomic_helper: Disallow new modesets on unregistered connectors Applying: drm/nouveau: Fix nv50_mstc->best_encoder() Applying:

Re: [Intel-gfx] [PATCH] drm/i915: Fix VIDEO_DIP_CTL bit shifts

2018-10-04 Thread Manasi Navare
On Thu, Oct 04, 2018 at 05:00:06PM -0700, Dhinakaran Pandiyan wrote: > On Thu, 2018-10-04 at 16:28 -0700, Manasi Navare wrote: > > On Thu, Oct 04, 2018 at 04:13:26PM -0700, Dhinakaran Pandiyan wrote: > > > On Thu, 2018-10-04 at 16:03 -0700, Lucas De Marchi wrote: > > > > On Thu, Oct 04, 2018 at

[Intel-gfx] [PATCH v4 3/5] drm/i915: Leave intel_conn->mst_port set, use mst_port_gone instead

2018-10-04 Thread Lyude Paul
Currently we set intel_connector->mst_port to NULL to signify that the MST port has been removed from the system so that we can prevent further action on the port such as connector probes, mode probing, etc. However, we're going to need access to intel_connector->mst_port in order to fixup

[Intel-gfx] [PATCH v4 4/5] drm/i915: Skip vcpi allocation for MSTB ports that are gone

2018-10-04 Thread Lyude Paul
Since we need to be able to allow DPMS on->off prop changes after an MST port has disappeared from the system, we need to be able to make sure we can compute a config for the resulting atomic commit. Currently this is impossible when the port has disappeared, since the VCPI slot searching we try

[Intel-gfx] [PATCH v4 5/5] drm/i915: Fix intel_dp_mst_best_encoder()

2018-10-04 Thread Lyude Paul
Currently, i915 appears to rely on blocking modesets on no-longer-present MSTB ports by simply returning NULL for ->best_encoder(), which in turn causes any new atomic commits that don't disable the CRTC to fail. This is wrong however, since we still want to allow userspace to disable CRTCs on

[Intel-gfx] [PATCH v4 2/5] drm/nouveau: Fix nv50_mstc->best_encoder()

2018-10-04 Thread Lyude Paul
As mentioned in the previous commit, we currently prevent new modesets on recently-removed MST connectors by returning no encoder from our ->best_encoder() callback once the MST port has disappeared. This is wrong however, because it prevents legacy modesetting users from being able to disable

[Intel-gfx] [PATCH v4 0/5] Fix legacy DPMS changes with MST

2018-10-04 Thread Lyude Paul
Next version of https://patchwork.freedesktop.org/series/49878/ . No changes, except that these patches are against master so hopefully intel's CI doesn't get confused this time. Lyude Paul (5): drm/atomic_helper: Disallow new modesets on unregistered connectors drm/nouveau: Fix

[Intel-gfx] [PATCH v4 1/5] drm/atomic_helper: Disallow new modesets on unregistered connectors

2018-10-04 Thread Lyude Paul
With the exception of modesets which would switch the DPMS state of a connector from on to off, we want to make sure that we disallow all modesets which would result in enabling a new monitor or a new mode configuration on a monitor if the connector for the display in question is no longer

Re: [Intel-gfx] [PATCH] drm/i915: Fix VIDEO_DIP_CTL bit shifts

2018-10-04 Thread Dhinakaran Pandiyan
On Thu, 2018-10-04 at 16:28 -0700, Manasi Navare wrote: > On Thu, Oct 04, 2018 at 04:13:26PM -0700, Dhinakaran Pandiyan wrote: > > On Thu, 2018-10-04 at 16:03 -0700, Lucas De Marchi wrote: > > > On Thu, Oct 04, 2018 at 01:51:49PM -0700, Dhinakaran Pandiyan > > > wrote: > > > > The shifts for

[Intel-gfx] ✓ Fi.CI.IGT: success for igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE

2018-10-04 Thread Patchwork
== Series Details == Series: igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE URL : https://patchwork.freedesktop.org/series/50561/ State : success == Summary == = CI Bug Log - changes from IGT_4667_full -> IGTPW_1909_full = == Summary - WARNING == Minor unknown changes coming

[Intel-gfx] ✓ Fi.CI.BAT: success for Watermarks small fixes/improvements

2018-10-04 Thread Patchwork
== Series Details == Series: Watermarks small fixes/improvements URL : https://patchwork.freedesktop.org/series/50579/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4933 -> Patchwork_10368 = == Summary - SUCCESS == No regressions found. External URL:

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/icl: MBUS B credit change

2018-10-04 Thread Patchwork
== Series Details == Series: drm/i915/icl: MBUS B credit change URL : https://patchwork.freedesktop.org/series/50560/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4931_full -> Patchwork_10363_full = == Summary - SUCCESS == No regressions found. == Known issues ==

[Intel-gfx] ✗ Fi.CI.BAT: failure for Fix legacy DPMS changes with MST (rev3)

2018-10-04 Thread Patchwork
== Series Details == Series: Fix legacy DPMS changes with MST (rev3) URL : https://patchwork.freedesktop.org/series/49878/ State : failure == Summary == Applying: drm/atomic_helper: Disallow new modesets on unregistered connectors Applying: drm/nouveau: Fix nv50_mstc->best_encoder() Applying:

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] sysfs: constify sysfs create/remove files harder

2018-10-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] sysfs: constify sysfs create/remove files harder URL : https://patchwork.freedesktop.org/series/50558/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4931_full -> Patchwork_10362_full = == Summary - FAILURE ==

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Watermarks small fixes/improvements

2018-10-04 Thread Patchwork
== Series Details == Series: Watermarks small fixes/improvements URL : https://patchwork.freedesktop.org/series/50579/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: don't apply Display WAs 1125 and 1126 to GLK/CNL+ Okay! Commit: drm/i915: fix the transition

[Intel-gfx] [PATCH v3 5/5] drm/i915: Fix intel_dp_mst_best_encoder()

2018-10-04 Thread Lyude Paul
Currently, i915 appears to rely on blocking modesets on no-longer-present MSTB ports by simply returning NULL for ->best_encoder(), which in turn causes any new atomic commits that don't disable the CRTC to fail. This is wrong however, since we still want to allow userspace to disable CRTCs on

[Intel-gfx] [PATCH v3 4/5] drm/i915: Skip vcpi allocation for MSTB ports that are gone

2018-10-04 Thread Lyude Paul
Since we need to be able to allow DPMS on->off prop changes after an MST port has disappeared from the system, we need to be able to make sure we can compute a config for the resulting atomic commit. Currently this is impossible when the port has disappeared, since the VCPI slot searching we try

[Intel-gfx] [PATCH v3 3/5] drm/i915: Leave intel_conn->mst_port set, use mst_port_gone instead

2018-10-04 Thread Lyude Paul
Currently we set intel_connector->mst_port to NULL to signify that the MST port has been removed from the system so that we can prevent further action on the port such as connector probes, mode probing, etc. However, we're going to need access to intel_connector->mst_port in order to fixup

Re: [Intel-gfx] [PATCH] drm/i915: Fix VIDEO_DIP_CTL bit shifts

2018-10-04 Thread Manasi Navare
On Thu, Oct 04, 2018 at 04:13:26PM -0700, Dhinakaran Pandiyan wrote: > On Thu, 2018-10-04 at 16:03 -0700, Lucas De Marchi wrote: > > On Thu, Oct 04, 2018 at 01:51:49PM -0700, Dhinakaran Pandiyan wrote: > > > The shifts for VSC_SELECT bits are wrong, fix it. Good thing is the > > > definitions are

[Intel-gfx] [PATCH v3 2/5] drm/nouveau: Fix nv50_mstc->best_encoder()

2018-10-04 Thread Lyude Paul
As mentioned in the previous commit, we currently prevent new modesets on recently-removed MST connectors by returning no encoder from our ->best_encoder() callback once the MST port has disappeared. This is wrong however, because it prevents legacy modesetting users from being able to disable

[Intel-gfx] [PATCH v3 0/5] Fix legacy DPMS changes with MST

2018-10-04 Thread Lyude Paul
Next version of https://patchwork.freedesktop.org/series/49877/ This fixes some rather silly bugs regarding DPMS On->Off changes failing for connectors which were just recently destroyed. Lyude Paul (5): drm/atomic_helper: Disallow new modesets on unregistered connectors drm/nouveau: Fix

[Intel-gfx] [PATCH v3 1/5] drm/atomic_helper: Disallow new modesets on unregistered connectors

2018-10-04 Thread Lyude Paul
With the exception of modesets which would switch the DPMS state of a connector from on to off, we want to make sure that we disallow all modesets which would result in enabling a new monitor or a new mode configuration on a monitor if the connector for the display in question is no longer

Re: [Intel-gfx] [PATCH] firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.

2018-10-04 Thread Paulo Zanoni
Em Qui, 2018-10-04 às 15:36 -0700, Rodrigo Vivi escreveu: > From: Anusha Srivatsa > > Add missing MODULE_FIRMWARE while loading DMC ICL. > > v2: Add Fixes tag. (Rodrigo) > v3: Rebase by Rodrigo after commit 7fe78985cd08 ("drm/i915/csr: > restructure CSR firmware definition macros") > v4:

Re: [Intel-gfx] [PATCH] drm/i915: Fix VIDEO_DIP_CTL bit shifts

2018-10-04 Thread Rodrigo Vivi
On Thu, Oct 04, 2018 at 04:03:05PM -0700, Lucas De Marchi wrote: > On Thu, Oct 04, 2018 at 01:51:49PM -0700, Dhinakaran Pandiyan wrote: > > The shifts for VSC_SELECT bits are wrong, fix it. Good thing is the > > definitions are unused. > > If they are unused why are we fixing them instead of

[Intel-gfx] [PATCH 5/6] drm/i915: don't write PLANE_BUF_CFG twice every time

2018-10-04 Thread Paulo Zanoni
We were writing to PLANE_BUF_CFG(pipe, plane_id) twice for every platform, and we were even using different values on the gen10- planar case. The first write is useless since it just gets replaced with the next one, so kill it. There's a lot to improve in the DDB code, but let's start by avoiding

[Intel-gfx] [PATCH 4/6] drm/i915: transition WMs ask for Selected Result Blocks

2018-10-04 Thread Paulo Zanoni
The transition watermarks ask for Selected Result Blocks (the real value), not Result Blocks (the integer value). Given how ceilings are applied in both the non-transition and the transition watermarks calculations, we can get away with assuming that Selected Result Blocks is actually Result

[Intel-gfx] [PATCH 0/6] Watermarks small fixes/improvements

2018-10-04 Thread Paulo Zanoni
I'm investigating ICL watermarks failures and these are some of the immediate problems I was able to find in the watermarks code. I don't think they're enough to fix the problems our CI is able to reproduce, but I do think these changes are worth having. Paulo Zanoni (6): drm/i915: don't apply

[Intel-gfx] [PATCH 3/6] drm/i915: fix the watermark result selection on glk/gen10+

2018-10-04 Thread Paulo Zanoni
On these platforms we're supposed to unconditonally pick the method 2 result instead of the minimum. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_pm.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c

[Intel-gfx] [PATCH 2/6] drm/i915: fix the transition minimums for gen9+ watermarks

2018-10-04 Thread Paulo Zanoni
The transition minimum is 14 blocks for gens 9 and 10, and 4 blocks for gen 11. This minimum value is supposed to be added to the configurable trans_amount. This matches both BSpec and additional information provided by our HW engineers. Signed-off-by: Paulo Zanoni ---

[Intel-gfx] [PATCH 1/6] drm/i915: don't apply Display WAs 1125 and 1126 to GLK/CNL+

2018-10-04 Thread Paulo Zanoni
BSpec does not show these WAs as applicable to GLK, and for CNL it only shows them applicable for a super early pre-production stepping we shouldn't be caring about anymore. Remove these so we can avoid them on ICL too. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_pm.c | 43

[Intel-gfx] [PATCH 6/6] drm/i915: promote ddb update message to DRM_DEBUG_KMS

2018-10-04 Thread Paulo Zanoni
This message is currently marked as DRM_DEBUG_ATOMIC. I would like it to be DRM_DEBUG_KMS since it is more KMS than atomic, and this will also make the message appear in the CI logs, which may or may not help us with some FIFO underrun bugs. Signed-off-by: Paulo Zanoni ---

Re: [Intel-gfx] [PATCH] drm/i915: Fix VIDEO_DIP_CTL bit shifts

2018-10-04 Thread Dhinakaran Pandiyan
On Thu, 2018-10-04 at 16:03 -0700, Lucas De Marchi wrote: > On Thu, Oct 04, 2018 at 01:51:49PM -0700, Dhinakaran Pandiyan wrote: > > The shifts for VSC_SELECT bits are wrong, fix it. Good thing is the > > definitions are unused. > > If they are unused why are we fixing them instead of removing?

[Intel-gfx] ✓ Fi.CI.BAT: success for firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev3)

2018-10-04 Thread Patchwork
== Series Details == Series: firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev3) URL : https://patchwork.freedesktop.org/series/49678/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4932 -> Patchwork_10367 = == Summary - SUCCESS == No regressions found.

Re: [Intel-gfx] [PATCH] drm/i915: Fix VIDEO_DIP_CTL bit shifts

2018-10-04 Thread Lucas De Marchi
On Thu, Oct 04, 2018 at 01:51:49PM -0700, Dhinakaran Pandiyan wrote: > The shifts for VSC_SELECT bits are wrong, fix it. Good thing is the > definitions are unused. If they are unused why are we fixing them instead of removing? Or better, why did we add them? Lucas De Marchi > > Cc: Manasi

[Intel-gfx] [PATCH] firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.

2018-10-04 Thread Rodrigo Vivi
From: Anusha Srivatsa Add missing MODULE_FIRMWARE while loading DMC ICL. v2: Add Fixes tag. (Rodrigo) v3: Rebase by Rodrigo after commit 7fe78985cd08 ("drm/i915/csr: restructure CSR firmware definition macros") v4: Rodrigo fixing his own mess on commit mentioning on v3 comment above.

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev2)

2018-10-04 Thread Rodrigo Vivi
On Thu, Oct 04, 2018 at 10:14:17PM -, Patchwork wrote: > == Series Details == > > Series: firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev2) > URL : https://patchwork.freedesktop.org/series/49678/ > State : warning > > == Summary == > > $ dim checkpatch origin/drm-tip >

[Intel-gfx] ✓ Fi.CI.BAT: success for firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev2)

2018-10-04 Thread Patchwork
== Series Details == Series: firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev2) URL : https://patchwork.freedesktop.org/series/49678/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4932 -> Patchwork_10366 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev2)

2018-10-04 Thread Patchwork
== Series Details == Series: firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev2) URL : https://patchwork.freedesktop.org/series/49678/ State : warning == Summary == $ dim checkpatch origin/drm-tip 751aeeb3a90f firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. -:9:

[Intel-gfx] [PATCH] firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.

2018-10-04 Thread Rodrigo Vivi
From: Anusha Srivatsa Add missing MODULE_FIRMWARE while loading DMC ICL. v2: Add Fixes tag. (Rodrigo) v3: Rebase by Rodrigo after 7fe78985cd08 ("drm/i915/csr: restructure CSR firmware definition macros") Fixes: 4445930f1c4a ("firmware/dmc/icl: load v1.07 on icelake.") Cc: Rodrigo Vivi Cc:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix VIDEO_DIP_CTL bit shifts

2018-10-04 Thread Patchwork
== Series Details == Series: drm/i915: Fix VIDEO_DIP_CTL bit shifts URL : https://patchwork.freedesktop.org/series/50573/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4932 -> Patchwork_10365 = == Summary - SUCCESS == No regressions found. External URL:

Re: [Intel-gfx] [PATCH 8/8] drm/i915/icl: Fix DDI/TC port clk_off bits

2018-10-04 Thread Lucas De Marchi
On Wed, Oct 03, 2018 at 12:52:03PM +0530, Mahesh Kumar wrote: > DDI/TC clock-off bits are not equally distanced. TC1-3 bits are > from offset 12 & TC4 is at offset 21. > Create a function to choose correct clk-off bit. > > Signed-off-by: Mahesh Kumar > Signed-off-by: Vandita Kulkarni > Cc:

Re: [Intel-gfx] [PATCH 5/8] drm/i915/icl: Refactor icl pll functions

2018-10-04 Thread Lucas De Marchi
On Wed, Oct 03, 2018 at 12:52:00PM +0530, Mahesh Kumar wrote: > From: Vandita Kulkarni > > This patch adds helper function for identifying > whether the given PLL is combo PHY PLL or not. > This helper function is used inside various ICL > functions to make them scalable. > > Signed-off-by:

Re: [Intel-gfx] [PATCH 4/8] drm/i915/icl: Use helper functions to classify the ports

2018-10-04 Thread Lucas De Marchi
On Wed, Oct 03, 2018 at 12:51:59PM +0530, Mahesh Kumar wrote: > From: Vandita Kulkarni > > Use intel_port_is_tc and intel_port_is_combophy > functions to replace the individual port checks > from port C to F and port A to B respectively. > > Signed-off-by: Vandita Kulkarni > Signed-off-by:

Re: [Intel-gfx] [PATCH 3/8] drm/i915/icl: Refactor get_ddi_pll using helper func

2018-10-04 Thread Lucas De Marchi
On Wed, Oct 03, 2018 at 12:51:58PM +0530, Mahesh Kumar wrote: > From: Vandita Kulkarni > > Use the existing port-to-id helper function, to refactor > hence making it scalable. > > Signed-off-by: Vandita Kulkarni > Signed-off-by: Mahesh Kumar > Cc: Lucas De Marchi > Cc: Madhav Chauhan

Re: [Intel-gfx] [PATCH 2/8] drm/i915/icl: use combophy/TC helper functions during display detection

2018-10-04 Thread Lucas De Marchi
On Wed, Oct 03, 2018 at 12:51:57PM +0530, Mahesh Kumar wrote: > Instead of directly comparing HPD pins use intel_port_is_combophy/tc > helper functions to distinguish between combophy/TC ports. > > Signed-off-by: Mahesh Kumar > Cc: Manasi Navare > --- Reviewed-by: Lucas De Marchi >

[Intel-gfx] [PATCH] drm/i915: Fix VIDEO_DIP_CTL bit shifts

2018-10-04 Thread Dhinakaran Pandiyan
The shifts for VSC_SELECT bits are wrong, fix it. Good thing is the definitions are unused. Cc: Manasi Navare Cc: Anusha Srivatsa Cc: Rodrigo Vivi Fixes: 7af2be6d54d4 ("drm/i915/icl: Add VIDEO_DIP registers") Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/i915_reg.h | 18

Re: [Intel-gfx] [PATCH 17/18] drm: Unexport drm_plane_helper_check_update

2018-10-04 Thread Ville Syrjälä
On Wed, Oct 03, 2018 at 11:18:26AM +0200, Daniel Vetter wrote: > It's for legacy drivers only (atomic ones should use > drm_atomic_helper_check_plane_state() instead), and there's no users > left except the one in the primary plane helpers. > > Signed-off-by: Daniel Vetter Reviewed-by: Ville

Re: [Intel-gfx] [PATCH 04/18] drm/vmwgfx: Remove confused comment from vmw_du_connector_atomic_set_property

2018-10-04 Thread Daniel Vetter
On Tue, Oct 02, 2018 at 04:36:31PM +, Thomas Hellstrom wrote: > On 10/02/2018 05:15 PM, Ville Syrjälä wrote: > > On Tue, Oct 02, 2018 at 03:35:12PM +0200, Daniel Vetter wrote: > >> The core _does_ the call to drm_atomic_commit for you. That's pretty > >> much the entire point of having the

Re: [Intel-gfx] [PATCH v2 1/8] drm/i915/icl: create function to identify combophy port

2018-10-04 Thread Lucas De Marchi
On Thu, Oct 04, 2018 at 02:20:43PM +0530, Mahesh Kumar wrote: > This patch creates a function/wrapper to check if port is combophy port > instead of explicitly comparing ports. > > Changes since V1: > - keep all intel_port_is_* helper together (Lucas) > > Signed-off-by: Mahesh Kumar > Cc:

Re: [Intel-gfx] [PATCH 02/18] drm/atomic-helper: Unexport drm_atomic_helper_best_encoder

2018-10-04 Thread Daniel Vetter
On Thu, Oct 04, 2018 at 02:33:24PM -0400, Sean Paul wrote: > On Tue, Oct 02, 2018 at 03:35:10PM +0200, Daniel Vetter wrote: > > It's the default. The exported version was kinda a transition state, > > before we made this the default. > > > > To stop new atomic drivers from using it (instead of

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/6] drm/i915/icl: Add WaEnable32PlaneMode

2018-10-04 Thread Patchwork
== Series Details == Series: series starting with [v2,1/6] drm/i915/icl: Add WaEnable32PlaneMode URL : https://patchwork.freedesktop.org/series/50569/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4932 -> Patchwork_10364 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Engine discovery query (rev6)

2018-10-04 Thread Patchwork
== Series Details == Series: drm/i915: Engine discovery query (rev6) URL : https://patchwork.freedesktop.org/series/39958/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4931_full -> Patchwork_10358_full = == Summary - FAILURE == Serious unknown changes coming with

Re: [Intel-gfx] [PATCH 02/18] drm/atomic-helper: Unexport drm_atomic_helper_best_encoder

2018-10-04 Thread Sean Paul
On Tue, Oct 02, 2018 at 03:35:10PM +0200, Daniel Vetter wrote: > It's the default. The exported version was kinda a transition state, > before we made this the default. > > To stop new atomic drivers from using it (instead of just relying on > the default) let's unexport it. > > Signed-off-by:

[Intel-gfx] [PATCH v2 5/6] drm/i915/icl: Add Wa_1406609255

2018-10-04 Thread Radhakrishna Sripada
Shader feature to prefetch binding tables does not support 16:6 18:8 BTP formats. Enabling fault handling could result in hangs with faults. Disabling demand prefetch would disable binding table prefetch. V2: Fix the stepping rivision to B0(Mika) References: HSDES#1406609255, HSDES#1406573985

[Intel-gfx] [PATCH v2 6/6] drm/i915/icl:Add Wa_1606682166

2018-10-04 Thread Radhakrishna Sripada
From: Anuj Phogat Incorrect TDL's SSP address shift in SARB for 16:6 & 18:8 modes. Disable the Sampler state prefetch functionality in the SARB by programming 0xB000[30] to '1'. This is to be done at boot time and the feature must remain disabled permanently. Fixes flaky

[Intel-gfx] [PATCH v2 2/6] drm/i915/icl: Implement Display WA_1405510057

2018-10-04 Thread Radhakrishna Sripada
Display WA_1405510057 asks to not enable YUV 420 HDMI 10bpc when horizontal blank size mod 8 reminder is 2. Cc: James Ausmus Cc: Paulo Zanoni Cc: Rodrigo Vivi Cc: Ville Syrjälä Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/intel_hdmi.c | 10 +- 1 file changed, 9

[Intel-gfx] [PATCH v2 4/6] drm/i915/icl: WaAllowUMDToModifySamplerMode

2018-10-04 Thread Radhakrishna Sripada
From: Oscar Mateo Required for Bindless samplers. Cc: Mika Kuoppala Signed-off-by: Oscar Mateo Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/i915_reg.h | 2 ++ drivers/gpu/drm/i915/intel_workarounds.c | 3 +++ 2 files changed, 5 insertions(+) diff --git

[Intel-gfx] [PATCH v2 3/6] drm/i915/icl: WaAllowUMDToModifyHalfSliceChicken7

2018-10-04 Thread Radhakrishna Sripada
From: Oscar Mateo Required to dinamically set 'Trilinear Filter Quality Mode' Cc: Mika Kuoppala Signed-off-by: Oscar Mateo Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/intel_workarounds.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Intel-gfx] [PATCH v2 1/6] drm/i915/icl: Add WaEnable32PlaneMode

2018-10-04 Thread Radhakrishna Sripada
Gen11 Display suports 32 planes in total. Enable the new format in context status to be used and expanded to 32 planes. V2: Move the WA to display WA's(Chris) Cc: Chris Wilson Cc: Michel Thierry Cc: James Ausmus Cc: Anusha Srivatsa Signed-off-by: Radhakrishna Sripada ---

Re: [Intel-gfx] [RFC] drm/i915/dp: Remove i915.enable_dp_mst module parameter

2018-10-04 Thread Dhinakaran Pandiyan
On Thu, 2018-10-04 at 08:54 -0700, Rodrigo Vivi wrote: > On Thu, Oct 04, 2018 at 01:59:52PM +0300, Ville Syrjälä wrote: > > On Thu, Oct 04, 2018 at 10:03:39AM +0300, Jani Nikula wrote: > > > On Wed, 03 Oct 2018, Dhinakaran Pandiyan < > > > dhinakaran.pandi...@intel.com> wrote: > > > > MST is

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Use the correct crtc when sanitizing plane mapping

2018-10-04 Thread Ville Syrjälä
On Wed, Oct 03, 2018 at 06:12:42PM +0200, Daniel Vetter wrote: > On Wed, Oct 03, 2018 at 05:50:17PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > When we decide that a plane is attached to the wrong pipe we try > > to turn off said plane. However we are passing around the crtc we >

Re: [Intel-gfx] [PATCH 02/18] drm/atomic-helper: Unexport drm_atomic_helper_best_encoder

2018-10-04 Thread Laurent Pinchart
Hi Daniel, On Wednesday, 3 October 2018 12:08:38 EEST Daniel Vetter wrote: > On Tue, Oct 02, 2018 at 04:53:12PM +0300, Laurent Pinchart wrote: > > On Tuesday, 2 October 2018 16:35:10 EEST Daniel Vetter wrote: > > > It's the default. The exported version was kinda a transition state, > > > before

[Intel-gfx] ✓ Fi.CI.IGT: success for Refactor and Add helper function for combophy/tc ports (rev2)

2018-10-04 Thread Patchwork
== Series Details == Series: Refactor and Add helper function for combophy/tc ports (rev2) URL : https://patchwork.freedesktop.org/series/50484/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4930_full -> Patchwork_10356_full = == Summary - SUCCESS == No regressions

[Intel-gfx] ✓ Fi.CI.IGT: success for Refactor and Add helper function for combophy/tc ports (rev2)

2018-10-04 Thread Patchwork
== Series Details == Series: Refactor and Add helper function for combophy/tc ports (rev2) URL : https://patchwork.freedesktop.org/series/50484/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4930_full -> Patchwork_10355_full = == Summary - SUCCESS == No regressions

Re: [Intel-gfx] [PATCH v6] drm/i915: Engine discovery query

2018-10-04 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-10-04 11:51:18) > From: Tvrtko Ursulin > > Engine discovery query allows userspace to enumerate engines, probe their > configuration features, all without needing to maintain the internal PCI > ID based database. > > A new query for the generic i915 query ioctl is

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE

2018-10-04 Thread Patchwork
== Series Details == Series: igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE URL : https://patchwork.freedesktop.org/series/50561/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4931 -> IGTPW_1909 = == Summary - SUCCESS == No regressions found. External URL:

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/3] drm/i915/guc: init GuC descriptors after GuC load

2018-10-04 Thread Daniele Ceraolo Spurio
On 03/10/18 23:29, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2018-10-03 23:45:02) On 03/10/18 08:24, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2018-10-03 01:12:57) On 02/10/18 15:39, Patchwork wrote: == Series Details == Series: series starting with [v2,1/3]

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl: MBUS B credit change

2018-10-04 Thread Patchwork
== Series Details == Series: drm/i915/icl: MBUS B credit change URL : https://patchwork.freedesktop.org/series/50560/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4931 -> Patchwork_10363 = == Summary - SUCCESS == No regressions found. External URL:

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Only reset seqno if actually idle

2018-10-04 Thread Patchwork
== Series Details == Series: drm/i915: Only reset seqno if actually idle URL : https://patchwork.freedesktop.org/series/50537/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4930_full -> Patchwork_10354_full = == Summary - WARNING == Minor unknown changes coming with

Re: [Intel-gfx] [RFC] drm/i915/dp: Remove i915.enable_dp_mst module parameter

2018-10-04 Thread Rodrigo Vivi
On Thu, Oct 04, 2018 at 01:59:52PM +0300, Ville Syrjälä wrote: > On Thu, Oct 04, 2018 at 10:03:39AM +0300, Jani Nikula wrote: > > On Wed, 03 Oct 2018, Dhinakaran Pandiyan > > wrote: > > > MST is enabled by default on all platforms that support it. I don't think > > > we should be providing a

Re: [Intel-gfx] [PATCH xf86-video-intel v2] sna: Added AYUV format support for textured and sprite video adapters.

2018-10-04 Thread Chris Wilson
Quoting Stanislav Lisovskiy (2018-10-04 13:49:41) > diff --git a/src/sna/sna_render.h b/src/sna/sna_render.h > index 6669af9d..ef88d1f9 100644 > --- a/src/sna/sna_render.h > +++ b/src/sna/sna_render.h > @@ -139,20 +139,25 @@ struct sna_composite_op { > > struct { >

[Intel-gfx] [PATCH i-g-t v2] igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE

2018-10-04 Thread Chris Wilson
When RECOVERABLE is set, the kernel will attempt to automatically recover a context after a hang. But if it is unset, the kernel will ban the guilty context on a hang, preventing subsequent execution. v2: Create a has_recoverable_param() Signed-off-by: Chris Wilson Cc: Mika Kuoppala ---

Re: [Intel-gfx] [PATCH v2 08/13] drm/i915: Make shared dpll functions take crtc_state

2018-10-04 Thread Ville Syrjälä
On Thu, Oct 04, 2018 at 03:25:42PM +0200, Maarten Lankhorst wrote: > Op 04-10-18 om 14:57 schreef Ville Syrjälä: > > On Thu, Oct 04, 2018 at 11:45:59AM +0200, Maarten Lankhorst wrote: > >> Do not rely on crtc->config any more. Remove the assertion from > >> ibx_pch_dpll_disable, because we the

Re: [Intel-gfx] [PATCH i-g-t] igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE

2018-10-04 Thread Chris Wilson
Quoting Mika Kuoppala (2018-10-04 14:26:16) > Chris Wilson writes: > > > When RECOVERABLE is set, the kernel will attempt to automatically recover > > a context after a hang. But if it is unset, the kernel will ban the > > guilty context on a hang, preventing subsequent execution. > > > >

[Intel-gfx] [PATCH] drm/i915/icl: MBUS B credit change

2018-10-04 Thread Rodrigo Vivi
No functional change. But just a minor change to keep up with Spec, since it has changed since commit c3cc39c539d4 ("drm/i915/icl: program mbus during pipe enable") The instructions previously said to program pipe's B credit = 24 / number of pipes, which is 8 for ICL. Now the spec gives us direct

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] sysfs: constify sysfs create/remove files harder

2018-10-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] sysfs: constify sysfs create/remove files harder URL : https://patchwork.freedesktop.org/series/50558/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4931 -> Patchwork_10362 = == Summary - SUCCESS == No regressions

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] sysfs: constify sysfs create/remove files harder

2018-10-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] sysfs: constify sysfs create/remove files harder URL : https://patchwork.freedesktop.org/series/50558/ State : warning == Summary == $ dim checkpatch origin/drm-tip fd1ccbdbc465 sysfs: constify sysfs create/remove files harder -:53:

[Intel-gfx] [PATCH 2/2] drm/i915/sysfs: make attrs arrays const

2018-10-04 Thread Jani Nikula
They don't need to be modified. Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c index

[Intel-gfx] [PATCH 1/2] sysfs: constify sysfs create/remove files harder

2018-10-04 Thread Jani Nikula
Let the passed in array be const (and thus placed in rodata) instead of a mutable array of const pointers. Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Signed-off-by: Jani Nikula --- fs/sysfs/file.c | 4 ++-- include/linux/sysfs.h | 8 2 files changed, 6 insertions(+), 6

Re: [Intel-gfx] [PATCH v7] drm/i915: Engine discovery query

2018-10-04 Thread Joonas Lahtinen
Some comments below, mostly related to trying to keep the uapi header nice and tidy. Quoting Tvrtko Ursulin (2018-10-04 14:32:48) > @@ -1747,6 +1748,52 @@ struct drm_i915_query_topology_info { > __u8 data[]; > }; > > +/** > + * struct drm_i915_engine_info > + * > + * Describes one

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: First cleanup pass to get rid of more crtc->config users. (rev3)

2018-10-04 Thread Patchwork
== Series Details == Series: drm/i915: First cleanup pass to get rid of more crtc->config users. (rev3) URL : https://patchwork.freedesktop.org/series/50506/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4931 -> Patchwork_10361 = == Summary - FAILURE == Serious unknown

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Report the number of closed vma held by each context in debugfs

2018-10-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Report the number of closed vma held by each context in debugfs URL : https://patchwork.freedesktop.org/series/50536/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4929_full -> Patchwork_10353_full = ==

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: First cleanup pass to get rid of more crtc->config users. (rev3)

2018-10-04 Thread Patchwork
== Series Details == Series: drm/i915: First cleanup pass to get rid of more crtc->config users. (rev3) URL : https://patchwork.freedesktop.org/series/50506/ State : warning == Summary == $ dim checkpatch origin/drm-tip 743f67a7f663 drm/i915: Remove dereferences of crtc->config in

[Intel-gfx] ✗ Fi.CI.BAT: failure for Add XYUV format support (rev8)

2018-10-04 Thread Patchwork
== Series Details == Series: Add XYUV format support (rev8) URL : https://patchwork.freedesktop.org/series/48007/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4931 -> Patchwork_10360 = == Summary - FAILURE == Serious unknown changes coming with Patchwork_10360

[Intel-gfx] [PULL] drm-intel-next-fixes

2018-10-04 Thread Joonas Lahtinen
Hi Dave, Here comes -fixes for drm-next. One compiler warning fix and adding back a removed max stride check, nothing end user visible. Regards, Joonas PS. Travelling next week, so I'll skip PR unless there's something big. --- drm-intel-next-fixes-2018-10-04: Compiler warning fix and

[Intel-gfx] [PATCH] drm/i915: Make shared dpll functions take crtc_state, v2.

2018-10-04 Thread Maarten Lankhorst
Do not rely on crtc->config any more. Remove the assertion from ibx_pch_dpll_disable, because we the dpll state tracking should already handle this case correctly. Changes since v1: - Fixup accidental early return in intel_prepare_shared_dpll, oops! Signed-off-by: Maarten Lankhorst Reviewed-by:

Re: [Intel-gfx] [PATCH i-g-t] igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE

2018-10-04 Thread Mika Kuoppala
Chris Wilson writes: > When RECOVERABLE is set, the kernel will attempt to automatically recover > a context after a hang. But if it is unset, the kernel will ban the > guilty context on a hang, preventing subsequent execution. > > Signed-off-by: Chris Wilson > --- > tests/gem_ctx_exec.c | 38

Re: [Intel-gfx] [PATCH v2 08/13] drm/i915: Make shared dpll functions take crtc_state

2018-10-04 Thread Maarten Lankhorst
Op 04-10-18 om 14:57 schreef Ville Syrjälä: > On Thu, Oct 04, 2018 at 11:45:59AM +0200, Maarten Lankhorst wrote: >> Do not rely on crtc->config any more. Remove the assertion from >> ibx_pch_dpll_disable, because we the dpll state tracking should >> already handle this case correctly. >> >>

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add XYUV format support (rev8)

2018-10-04 Thread Patchwork
== Series Details == Series: Add XYUV format support (rev8) URL : https://patchwork.freedesktop.org/series/48007/ State : warning == Summary == $ dim checkpatch origin/drm-tip f58818541bcb drm: Introduce new DRM_FORMAT_XYUV -:32: WARNING:LONG_LINE: line over 100 characters #32: FILE:

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/5] igt/kms_getfb: Check the iface exists before use

2018-10-04 Thread Daniel Vetter
On Wed, Oct 03, 2018 at 04:04:20PM +0300, Joonas Lahtinen wrote: > Quoting Antonio Argenziano (2018-10-02 23:27:46) > > > > > > On 02/10/18 01:30, Joonas Lahtinen wrote: > > > Quoting Antonio Argenziano (2018-10-01 22:53:46) > > >> Fair enough. > > >> > > >> Acked-by: Antonio Argenziano > > >>

  1   2   >