== Series Details ==
Series: drm/i915/icl: enable SAGV for ICL platform
URL : https://patchwork.freedesktop.org/series/50888/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4975_full -> Patchwork_10431_full =
== Summary - WARNING ==
Minor unknown changes coming with
Hi Chris,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v4.19-rc7 next-20181011]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com
== Series Details ==
Series: drm/i915/cnp+: update to the new RAWCLK_FREQ recommendations
URL : https://patchwork.freedesktop.org/series/50893/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4975 -> Patchwork_10432 =
== Summary - FAILURE ==
Serious unknown changes coming
These are the new recommended values provided by our spec (18 -> 19
and 23 -> 24). It seems this should help fixing GMBUS issues. Since
we're doing pretty much the same thing for both CNP and ICP now, unify
the functions using the ICP version since it's more straightforward by
just matching the
== Series Details ==
Series: drm/i915/icl: enable SAGV for ICL platform
URL : https://patchwork.freedesktop.org/series/50888/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4975 -> Patchwork_10431 =
== Summary - SUCCESS ==
No regressions found.
External URL:
From: Mahesh Kumar
Enable SAGV for ICL platform.
Cc: Gwan-gyeong Mun
Reviewed-by: James Ausmus
Reviewed-by: Paulo Zanoni
Signed-off-by: Mahesh Kumar
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
I had previously
Hi Chris,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v4.19-rc7 next-20181011]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com
== Series Details ==
Series: drm/i915/perf: Add OA buffer size uAPI parameter (rev2)
URL : https://patchwork.freedesktop.org/series/50810/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4969_full -> Patchwork_10429_full =
== Summary - SUCCESS ==
No regressions found.
On Wed, Oct 10, 2018 at 11:21 PM Jani Nikula
wrote:
>
> On Wed, 10 Oct 2018, Nick Desaulniers wrote:
> > On Wed, Oct 10, 2018 at 1:30 PM Michal Wajdeczko
> > wrote:
> >>
> >> On Wed, 10 Oct 2018 14:01:40 +0200, Jani Nikula
> >> wrote:
> >>
> >> > On Tue, 09 Oct 2018, Nick Desaulniers wrote:
>
Hi Lionel,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v4.19-rc7 next-20181011]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https
Quoting Michal Wajdeczko (2018-10-11 14:00:08)
> We need extra load failure point to better test error path in
> i915_driver_init_mmio.
>
> Suggested-by: Chris Wilson
> Signed-off-by: Michal Wajdeczko
> Cc: Chris Wilson
Reviewed-by: Chris Wilson
And pushed, thanks for the bug fix and
On Thu, Oct 11, 2018 at 12:55:15AM -0700, Lisovskiy, Stanislav wrote:
> On Wed, 2018-10-10 at 17:12 -0700, Radhakrishna Sripada wrote:
> > Use the newly added "max bpc" connector property to limit pipe bpp.
> >
> > V3: Use drm_connector_state to access the "max bpc" property
> > V4: Initialize
On Thu, Oct 11, 2018 at 09:17:52AM +1000, David Airlie wrote:
> On Thu, Oct 11, 2018 at 8:53 AM Rodrigo Vivi wrote:
> >
> > Hi all,
> >
> > I need your help to decide what to do with this round of fixes.
> >
> > I have collected these patches this week:
> >
> > commit b43e8916172a ("drm/i915/dp:
On Thu, Oct 11, 2018 at 08:17:49PM +0200, Maarten Lankhorst wrote:
> Op 11-10-18 om 13:56 schreef Ville Syrjälä:
> > On Thu, Oct 11, 2018 at 12:04:51PM +0200, Maarten Lankhorst wrote:
> >> has_drrs is a flag we can't read out. We set it when seamless DRRS is
> >> enabled in pipe_config, so
Op 11-10-18 om 13:56 schreef Ville Syrjälä:
> On Thu, Oct 11, 2018 at 12:04:51PM +0200, Maarten Lankhorst wrote:
>> has_drrs is a flag we can't read out. We set it when seamless DRRS is
>> enabled in pipe_config, so intel_dump_pipe_config() and
>> intel_pipe_config_compare() will continue to do
On Wed, Sep 26, 2018 at 06:06:50PM -0700, José Roberto de Souza wrote:
> This new AML PCI ID uses the same gen graphics as Coffe Lake not a
> Kaby Lake one like the other AMLs.
>
> So to make it more explicit renaming INTEL_AML_GT2_IDS to
> INTEL_AML_KBL_GT2_IDS and naming this id as
Em Qua, 2018-09-05 às 16:41 -0700, Rodrigo Vivi escreveu:
> On Wed, Sep 05, 2018 at 02:32:38PM +0530, Karthik B S wrote:
> > Display Workarounds #1125 and #1126 are intended for Gen10 and
> > below platforms. These workarounds can be avoided in Gen11.
> >
> > The result blocks for WM1-WM7 should
So I understand we agree on the change, just waiting for non-RFC version?
-Tomasz
On 2018-09-24 11:34, Jani Nikula wrote:
On Thu, 20 Sep 2018, Tvrtko Ursulin wrote:
Ping!
Any comments here?
Main goal was to allow GEM_WARN_ON as a statement, plus also protect
uses in if statements, which
Hi Bjorn,
On Wed, Oct 10, 2018 at 1:02 AM Bjorn Helgaas wrote:
>
> On Mon, Oct 08, 2018 at 05:44:08PM +0800, Bin Meng wrote:
> > On Thu, Oct 4, 2018 at 4:12 AM Bjorn Helgaas wrote:
> > > On Thu, Sep 27, 2018 at 10:10:07AM +0800, Bin Meng wrote:
> > > > On Thu, Sep 27, 2018 at 12:57 AM Bjorn
Em Ter, 2018-10-09 às 16:55 -0700, Matt Roper escreveu:
> On Thu, Oct 04, 2018 at 04:15:55PM -0700, Paulo Zanoni wrote:
> > BSpec does not show these WAs as applicable to GLK, and for CNL it
> > only shows them applicable for a super early pre-production
> > stepping
> > we shouldn't be caring
== Series Details ==
Series: drm/i915: Prevent machine hang from Broxton's vtd w/a and error capture
(rev4)
URL : https://patchwork.freedesktop.org/series/34969/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4969_full -> Patchwork_10427_full =
== Summary - WARNING ==
On Wed, Oct 10, 2018 at 05:16:43PM -0700, Deepak Rawat wrote:
> Selftest for drm damage helper iterator functions.
>
> Cc: ville.syrj...@linux.intel.com
> Cc: Daniel Vetter
> Cc: Pekka Paalanen
> Cc: Daniel Stone
> Cc: intel-gfx@lists.freedesktop.org
> Cc: igt-...@lists.freedesktop.org
> Cc:
On Thu, Oct 11, 2018 at 03:11:01PM +0800, Bin Meng wrote:
> On Wed, Oct 10, 2018 at 1:02 AM Bjorn Helgaas wrote:
> > On Mon, Oct 08, 2018 at 05:44:08PM +0800, Bin Meng wrote:
> > > On Thu, Oct 4, 2018 at 4:12 AM Bjorn Helgaas wrote:
> > > > On Thu, Sep 27, 2018 at 10:10:07AM +0800, Bin Meng
On Thu, 11 Oct 2018, Ville Syrjälä wrote:
> On Thu, Oct 11, 2018 at 03:14:41PM +0300, Jani Nikula wrote:
>> On Wed, 10 Oct 2018, Ville Syrjala wrote:
>> > From: Ville Syrjälä
>> >
>> > Templatize snprintf_int_array() to allow us to print
>> > different kinds of arrays without having to type all
On Thu, Oct 11, 2018 at 02:30:41AM +0530, Mahesh Kumar wrote:
> On Thu, Oct 11, 2018 at 2:19 AM Mahesh Kumar
> wrote:
> >
> > Hi,
> >
> > On Wed, Oct 10, 2018 at 11:25 PM Ville Syrjala
> > wrote:
> > >
> > > From: Ville Syrjälä
> > >
> > > The 16Gb DIMM w/a is not applicable to BXT or GLK.
== Series Details ==
Series: drm/i915/selftests: Disable shrinker across mmap-exhaustion
URL : https://patchwork.freedesktop.org/series/50857/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4969_full -> Patchwork_10424_full =
== Summary - SUCCESS ==
No regressions found.
>
> On Wed, Oct 10, 2018 at 05:21:01PM -0700, Deepak Rawat wrote:
> > For vmwgfx cairo surface creation fails due to stride mismatch, add a
> > igt_require_f() for surface.
>
> Hmm. What kind of pixel format are you using?
>
> It seems to me cairo should be happy with just a 4 byte aligned
>
On Thu, Oct 11, 2018 at 03:38:11PM +, Deepak Singh Rawat wrote:
>
> > On Wed, Oct 10, 2018 at 05:21:02PM -0700, Deepak Rawat wrote:
> > > vmwgfx doesn't support fb modifier so skip igt_require_fb_modifiers()
> > > when modifier are not passed.
> > >
> > > Signed-off-by: Deepak Rawat
> > >
> On Wed, Oct 10, 2018 at 05:21:02PM -0700, Deepak Rawat wrote:
> > vmwgfx doesn't support fb modifier so skip igt_require_fb_modifiers()
> > when modifier are not passed.
> >
> > Signed-off-by: Deepak Rawat
> > ---
> > lib/ioctl_wrappers.c | 5 -
> > 1 file changed, 4 insertions(+), 1
> > > This seems not needed? For pure generic kms tests I think it'd be great if
> > > we don't have to sprinkle driver-specific checks all over. Which you seem
> > > to achive in your series here.
> > >
> > > So not clear why this here is needed?
> > > -Daniel
> >
> > Hi Daniel,
> >
> > Thanks
On Thu, Oct 11, 2018 at 03:17:01PM +, Deepak Singh Rawat wrote:
> >
> > On Wed, Oct 10, 2018 at 05:20:59PM -0700, Deepak Rawat wrote:
> > > Add DRIVER_VMWGFX to represent vmwgfx device for running igt tests.
> > >
> > > v2: Don't remove second virtio_gpu
> > >
> > > Signed-off-by: Deepak
On Thu, Oct 11, 2018 at 03:23:58PM +, Deepak Singh Rawat wrote:
> > > diff --git a/tests/meson.build b/tests/meson.build
> > > index 697ff515..5acd7aa2 100644
> > > --- a/tests/meson.build
> > > +++ b/tests/meson.build
> > > @@ -9,6 +9,7 @@ test_progs = [
> > > 'debugfs_test',
> > >
> > diff --git a/tests/meson.build b/tests/meson.build
> > index 697ff515..5acd7aa2 100644
> > --- a/tests/meson.build
> > +++ b/tests/meson.build
> > @@ -9,6 +9,7 @@ test_progs = [
> > 'debugfs_test',
> > 'drm_import_export',
> > 'drm_mm',
> > + 'drm_plane_damage',
>
> For future
>
> On Wed, Oct 10, 2018 at 05:20:59PM -0700, Deepak Rawat wrote:
> > Add DRIVER_VMWGFX to represent vmwgfx device for running igt tests.
> >
> > v2: Don't remove second virtio_gpu
> >
> > Signed-off-by: Deepak Rawat
> > ---
> > lib/drmtest.c | 8
> > lib/drmtest.h | 3 +++
> > 2 files
On Wed, Oct 10, 2018 at 05:21:01PM -0700, Deepak Rawat wrote:
> For vmwgfx cairo surface creation fails due to stride mismatch, add a
> igt_require_f() for surface.
Hmm. What kind of pixel format are you using?
It seems to me cairo should be happy with just a 4 byte aligned
stride. How bad would
Quoting Mika Kuoppala (2018-10-11 15:19:24)
> Chris Wilson writes:
>
> > Quoting Mika Kuoppala (2018-10-02 15:05:52)
> >> Don't keep master disabled while we handle the current
> >> interrupts. This should help a little on latency of
> >> generating the next interrupt.
> >>
> >> Suggested-by:
On Wed, Oct 10, 2018 at 05:21:02PM -0700, Deepak Rawat wrote:
> vmwgfx doesn't support fb modifier so skip igt_require_fb_modifiers()
> when modifier are not passed.
>
> Signed-off-by: Deepak Rawat
> ---
> lib/ioctl_wrappers.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>
Chris Wilson writes:
> Quoting Mika Kuoppala (2018-10-11 14:56:42)
>> Chris Wilson writes:
>>
>> > For mmap-exhaustion, we deliberately put the system under a large amount
>> > of pressure to ensure that we are able to reap mmap-offsets from dead
>> > objects. If background activity does that
On 11/10/2018 15:30, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2018-10-11 14:38:41)
On 23/07/2018 10:02, Chris Wilson wrote:
Our attempt to account for bit17 swizzling of pread/pwrite onto tiled
objects was flawed due to the simple fact that we do not always know the
swizzling for a
Quoting Mika Kuoppala (2018-10-11 14:56:42)
> Chris Wilson writes:
>
> > For mmap-exhaustion, we deliberately put the system under a large amount
> > of pressure to ensure that we are able to reap mmap-offsets from dead
> > objects. If background activity does that reaping for us, that defeats
>
Chris Wilson writes:
> Quoting Mika Kuoppala (2018-10-02 15:05:52)
>> Don't keep master disabled while we handle the current
>> interrupts. This should help a little on latency of
>> generating the next interrupt.
>>
>> Suggested-by: Chris Wilson
>> Cc: Chris Wilson
>> Signed-off-by: Mika
Quoting Tvrtko Ursulin (2018-10-11 14:38:41)
>
> On 23/07/2018 10:02, Chris Wilson wrote:
> > Our attempt to account for bit17 swizzling of pread/pwrite onto tiled
> > objects was flawed due to the simple fact that we do not always know the
> > swizzling for a particular page (due to the
Chris Wilson writes:
> For mmap-exhaustion, we deliberately put the system under a large amount
> of pressure to ensure that we are able to reap mmap-offsets from dead
> objects. If background activity does that reaping for us, that defeats
> the purpose of the test and in some cases will fail
== Series Details ==
Series: drm/i915: Convert _print_param to a macro (rev2)
URL : https://patchwork.freedesktop.org/series/50789/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4968_full -> Patchwork_10422_full =
== Summary - SUCCESS ==
No regressions found.
==
On 23/07/2018 10:02, Chris Wilson wrote:
Our attempt to account for bit17 swizzling of pread/pwrite onto tiled
objects was flawed due to the simple fact that we do not always know the
swizzling for a particular page (due to the swizzling varying based on
location in certain unbalanced
== Series Details ==
Series: series starting with [1/2] drm/i915: Fix i915_driver_init_mmio error
path
URL : https://patchwork.freedesktop.org/series/50868/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4969 -> Patchwork_10430 =
== Summary - FAILURE ==
Serious unknown
On Wed, Oct 10, 2018 at 05:41:23PM -0700, José Roberto de Souza wrote:
> Some eDP panels do not set a valid sink count value and even for the
> ones that sets is should always be one for eDP, that is why it is not
> cached in intel_edp_init_dpcd().
>
> But intel_dp_short_pulse() compares the old
== Series Details ==
Series: drm/i915/perf: Add OA buffer size uAPI parameter (rev2)
URL : https://patchwork.freedesktop.org/series/50810/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4969 -> Patchwork_10429 =
== Summary - SUCCESS ==
No regressions found.
External
On 11/10/2018 13:49, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2018-10-11 13:42:31)
On 11/10/2018 13:34, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2018-10-11 13:30:27)
From: Tvrtko Ursulin
Same as in commit 78071c2fa53d ("igt/gem_tiled_partial_pwrite_pread: Check
for known
== Series Details ==
Series: series starting with [v1,01/10] drm/i915: introduced pv capability for
vgpu
URL : https://patchwork.freedesktop.org/series/50851/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4968_full -> Patchwork_10421_full =
== Summary - SUCCESS ==
No
== Series Details ==
Series: drm/i915/perf: Add OA buffer size uAPI parameter (rev2)
URL : https://patchwork.freedesktop.org/series/50810/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915/perf: remove redundant oa buffer initialization
== Series Details ==
Series: drm/i915/perf: Add OA buffer size uAPI parameter (rev2)
URL : https://patchwork.freedesktop.org/series/50810/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
c4fba7f16af5 drm/i915/perf: remove redundant oa buffer initialization
-:7:
We need extra load failure point to better test error path in
i915_driver_init_mmio.
Suggested-by: Chris Wilson
Signed-off-by: Michal Wajdeczko
Cc: Chris Wilson
---
drivers/gpu/drm/i915/intel_engine_cs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
In case of the error we missed to call i915_mmio_cleanup
that matches earlier call to i915_mmio_setup.
Signed-off-by: Michal Wajdeczko
Cc: Joonas Lahtinen
Cc: Chris Wilson
Reviewed-by: Mika Kuoppala
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_drv.c | 1 +
1 file changed, 1
== Series Details ==
Series: drm/i915: Fix i915_driver_init_mmio error path
URL : https://patchwork.freedesktop.org/series/50864/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4969 -> Patchwork_10428 =
== Summary - SUCCESS ==
No regressions found.
External URL:
We initialize the OA buffer everytime we enable the OA unit (first call in
gen[78]_oa_enable), so we don't need to initialize when preparing the metric
set.
Signed-off-by: Lionel Landwerlin
Reviewed-by: Matthew Auld
---
drivers/gpu/drm/i915/i915_drv.h | 17 -
We want to use some of the properties of the perf stream to program
the hardware in a later commit.
v2: Pass only perf stream as argument (Matthew)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Matthew Auld
---
drivers/gpu/drm/i915/i915_drv.h | 7 +++---
drivers/gpu/drm/i915/i915_perf.c |
The way our hardware is designed doesn't seem to let us use the
MI_RECORD_PERF_COUNT command without setting up a circular buffer.
In the case where the user didn't request OA reports to be available
through the i915 perf stream, we can set the OA buffer to the minimum
size to avoid consuming
Hi all,
This version drops a patch that wasn't necessary and simplify the OA
buffer size exponent as recommended by Chris (Thanks!).
Cheers,
Lionel Landwerlin (3):
drm/i915/perf: remove redundant oa buffer initialization
drm/i915/perf: pass stream to vfuncs when possible
drm/i915/perf:
Quoting Tvrtko Ursulin (2018-10-11 13:42:31)
>
> On 11/10/2018 13:34, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2018-10-11 13:30:27)
> >> From: Tvrtko Ursulin
> >>
> >> Same as in commit 78071c2fa53d ("igt/gem_tiled_partial_pwrite_pread: Check
> >> for known swizzling"), to be able to
On Thu, Oct 11, 2018 at 03:14:41PM +0300, Jani Nikula wrote:
> On Wed, 10 Oct 2018, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > Templatize snprintf_int_array() to allow us to print
> > different kinds of arrays without having to type all
> > the boilerplate for the snprintf() loop.
>
>
On 11/10/2018 13:34, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2018-10-11 13:30:27)
From: Tvrtko Ursulin
Same as in commit 78071c2fa53d ("igt/gem_tiled_partial_pwrite_pread: Check
for known swizzling"), to be able to compare the bo against the test
pattern we need to skip the test if the
Quoting Tvrtko Ursulin (2018-10-11 13:30:27)
> From: Tvrtko Ursulin
>
> Same as in commit 78071c2fa53d ("igt/gem_tiled_partial_pwrite_pread: Check
> for known swizzling"), to be able to compare the bo against the test
> pattern we need to skip the test if the swizzling is not compatible.
>
>
From: Tvrtko Ursulin
Same as in commit 78071c2fa53d ("igt/gem_tiled_partial_pwrite_pread: Check
for known swizzling"), to be able to compare the bo against the test
pattern we need to skip the test if the swizzling is not compatible.
Signed-off-by: Tvrtko Ursulin
Bugzilla:
== Series Details ==
Series: drm/i915: Prevent machine hang from Broxton's vtd w/a and error capture
(rev4)
URL : https://patchwork.freedesktop.org/series/34969/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4969 -> Patchwork_10427 =
== Summary - SUCCESS ==
No
Michal Wajdeczko writes:
> In case of the error we missed to call i915_mmio_cleanup
> that matches earlier call to i915_mmio_setup.
>
> Signed-off-by: Michal Wajdeczko
> Cc: Joonas Lahtinen
> Cc: Chris Wilson
Reviewed-by: Mika Kuoppala
> ---
> drivers/gpu/drm/i915/i915_drv.c | 1 +
> 1
Quoting Michal Wajdeczko (2018-10-11 13:19:51)
> In case of the error we missed to call i915_mmio_cleanup
> that matches earlier call to i915_mmio_setup.
True, doesn't look fatal atm; worst being we left the register bar mmapped
(which would be ok as we map it again using the same constraints on
In case of the error we missed to call i915_mmio_cleanup
that matches earlier call to i915_mmio_setup.
Signed-off-by: Michal Wajdeczko
Cc: Joonas Lahtinen
Cc: Chris Wilson
---
drivers/gpu/drm/i915/i915_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.c
On Wed, 10 Oct 2018, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Templatize snprintf_int_array() to allow us to print
> different kinds of arrays without having to type all
> the boilerplate for the snprintf() loop.
I might just feel happier about duplicating the boilerplate...
BR,
Jani.
On Thu, Oct 11, 2018 at 12:04:54PM +0200, Maarten Lankhorst wrote:
> The CRTC is idle at this point, so we can dereference crtc->state safely.
>
> Signed-off-by: Maarten Lankhorst
> ---
> drivers/gpu/drm/i915/intel_display.c | 11 +++
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
On Thu, Oct 11, 2018 at 12:04:57PM +0200, Maarten Lankhorst wrote:
> Now that most of the driver is atomic, we no longer need to worry
> about setting crtc->active right before actually enabling the pipe.
Hmm. I think we need at least that wait_for_vblank_if_active() change
we discussed. And
On Thu, Oct 11, 2018 at 12:04:55PM +0200, Maarten Lankhorst wrote:
> Instead of derferencing crtc->config, look at crtc_state.
>
> Signed-off-by: Maarten Lankhorst
Reviewed-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/intel_display.c | 7 ---
> 1 file changed, 4 insertions(+), 3
On Thu, Oct 11, 2018 at 12:04:56PM +0200, Maarten Lankhorst wrote:
> We have to look at crtc_state, so pass that instead.
> Also cleanup the use of dev vs dev_priv, we really want to pass along
> dev_priv.
>
> Signed-off-by: Maarten Lankhorst
Reviewed-by: Ville Syrjälä
> ---
>
On Thu, Oct 11, 2018 at 12:04:53PM +0200, Maarten Lankhorst wrote:
> We know the crtc is idle because we're at the beginning of sanitization,
> so just dereference crtc->state instead.
>
> Signed-off-by: Maarten Lankhorst
Reviewed-by: Ville Syrjälä
> ---
>
On Thu, Oct 11, 2018 at 12:04:52PM +0200, Maarten Lankhorst wrote:
> No need to look at crtc->config when we have crtc_state in the caller.
>
> Signed-off-by: Maarten Lankhorst
Reviewed-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/intel_display.c | 11 ++-
> 1 file changed, 6
On Thu, Oct 11, 2018 at 12:04:51PM +0200, Maarten Lankhorst wrote:
> has_drrs is a flag we can't read out. We set it when seamless DRRS is
> enabled in pipe_config, so intel_dump_pipe_config() and
> intel_pipe_config_compare() will continue to do the right thing when
> has_drrs is set on the real
Since capturing the error state requires fiddling around with the GGTT
to read arbitrary buffers and is itself run under stop_machine(), it
deadlocks the machine (effectively a hard hang) when run in conjunction
with Broxton's VTd workaround to serialize GGTT access.
v2: Store the ERR_PTR in
On Thu, Oct 11, 2018 at 12:04:49PM +0200, Maarten Lankhorst wrote:
> Another user of crtc->config gone. The functions it calls also
> needed crtc->config, so convert those as well.
>
> Signed-off-by: Maarten Lankhorst
> ---
> drivers/gpu/drm/i915/intel_display.c | 61
== Series Details ==
Series: drm/i915: Prevent machine hang from Broxton's vtd w/a and error capture
(rev3)
URL : https://patchwork.freedesktop.org/series/34969/
State : failure
== Summary ==
CALLscripts/checksyscalls.sh
DESCEND objtool
CHK include/generated/compile.h
CC [M]
On Thu, Oct 11, 2018 at 12:04:50PM +0200, Maarten Lankhorst wrote:
> We already have a perfectly nice pipe_config, use that instead.
>
> Signed-off-by: Maarten Lankhorst
Reviewed-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/intel_display.c | 6 +++---
> 1 file changed, 3 insertions(+), 3
Since capturing the error state requires fiddling around with the GGTT
to read arbitrary buffers and is itself run under stop_machine(), it
deadlocks the machine (effectively a hard hang) when run in conjunction
with Broxton's VTd workaround to serialize GGTT access.
v2: Store the ERR_PTR in
On Wed, Oct 10, 2018 at 04:50:51PM -0700, Matt Roper wrote:
> Gen9+ platforms allow CRTC's to be programmed with a background/canvas
> color below the programmable planes. Let's expose this for use by
> compositors.
>
> Cc: dri-de...@lists.freedesktop.org
> Cc: wei.c...@intel.com
> Cc:
On Wed, Oct 10, 2018 at 04:50:50PM -0700, Matt Roper wrote:
> Some display controllers can be programmed to present non-black colors
> for pixels not covered by any plane (or pixels covered by the
> transparent regions of higher planes). Compositors that want a UI with
> a solid color background
== Series Details ==
Series: drm/i915/selftests: Disable shrinker across mmap-exhaustion
URL : https://patchwork.freedesktop.org/series/50857/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4969 -> Patchwork_10424 =
== Summary - SUCCESS ==
No regressions found.
== Series Details ==
Series: drm/i915: Prevent machine hang from Broxton's vtd w/a and error capture
(rev2)
URL : https://patchwork.freedesktop.org/series/34969/
State : failure
== Summary ==
Applying: drm/i915: Prevent machine hang from Broxton's vtd w/a and error
capture
Using index info
== Series Details ==
Series: drm/i915: Remove low hanging crtc->config fruit, part 2.
URL : https://patchwork.freedesktop.org/series/50856/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4969 -> Patchwork_10423 =
== Summary - FAILURE ==
Serious unknown changes coming
For mmap-exhaustion, we deliberately put the system under a large amount
of pressure to ensure that we are able to reap mmap-offsets from dead
objects. If background activity does that reaping for us, that defeats
the purpose of the test and in some cases will fail our sanity checks
(because of
== Series Details ==
Series: series starting with [v2,1/6] drm/i915/psr: Use intel_psr_exit() in
intel_psr_disable_source()
URL : https://patchwork.freedesktop.org/series/50843/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4967_full -> Patchwork_10420_full =
== Summary -
On 10/10/2018 20:24, Matthew Auld wrote:
On Wed, 10 Oct 2018 at 19:55, Lionel Landwerlin
wrote:
If 2 processes race to open the perf stream, it's possible that one of them
will see that OA buffer has already been allocated, while a previous process
is still finishing to reprogram the hardware
The CRTC is idle at this point, so we can dereference crtc->state safely.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
Wait for idle, and iterate over connectors instead of encoders.
With this information we know crtc->state is the actual state,
and we can enable/disable drrs safely.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/i915_debugfs.c | 54 ++---
1 file changed, 42
Another user of crtc->config gone. The functions it calls also
needed crtc->config, so convert those as well.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 61 ++--
drivers/gpu/drm/i915/intel_dp.c | 4 +-
No need to look at crtc->config when we have crtc_state in the caller.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
Now that most of the driver is atomic, we no longer need to worry
about setting crtc->active right before actually enabling the pipe.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 21 +
1 file changed, 1 insertion(+), 20 deletions(-)
diff --git
Instead of derferencing crtc->config, look at crtc_state.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index
We know the crtc is idle because we're at the beginning of sanitization,
so just dereference crtc->state instead.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git
We have to look at crtc_state, so pass that instead.
Also cleanup the use of dev vs dev_priv, we really want to pass along
dev_priv.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git
We already have a perfectly nice pipe_config, use that instead.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index
has_drrs is a flag we can't read out. We set it when seamless DRRS is
enabled in pipe_config, so intel_dump_pipe_config() and
intel_pipe_config_compare() will continue to do the right thing when
has_drrs is set on the real state.
This removes one more dereference of crtc->config.
While at it,
More users of crtc->config are converted to using the correct crtc_state.
Maarten Lankhorst (10):
drm/i915: Remove crtc->config dereference from drrs_ctl
drm/i915: Make intel_dp_set_m_n take crtc_state
drm/i915: Remove crtc->config references in vlv_prepare_pll
drm/i915: Always read out
1 - 100 of 136 matches
Mail list logo
