Re: [Intel-gfx] [PATCH v8 05/35] drm/i915: MEI interface definition

2018-12-07 Thread C, Ramalingam
On 12/7/2018 11:22 AM, C, Ramalingam wrote: On 12/6/2018 3:53 PM, Daniel Vetter wrote: On Tue, Nov 27, 2018 at 04:13:03PM +0530, Ramalingam C wrote: Defining the mei-i915 interface functions and initialization of the interface. Signed-off-by: Ramalingam C Signed-off-by: Tomas Winkler ---

Re: [Intel-gfx] [PATCH v8 05/35] drm/i915: MEI interface definition

2018-12-07 Thread C, Ramalingam
On 12/7/2018 11:22 AM, C, Ramalingam wrote: On 12/6/2018 3:53 PM, Daniel Vetter wrote: On Tue, Nov 27, 2018 at 04:13:03PM +0530, Ramalingam C wrote: Defining the mei-i915 interface functions and initialization of the interface. Signed-off-by: Ramalingam C Signed-off-by: Tomas Winkler ---

Re: [Intel-gfx] [PATCH] drm/i915: Skip the ERR_PTR error state

2018-12-07 Thread Tvrtko Ursulin
On 07/12/2018 09:16, Chris Wilson wrote: Although commit fb6f0b64e455 ("drm/i915: Prevent machine hang from Broxton's vtd w/a and error capture") applied cleanly after a 24 month hiatus, the code had moved on with new methods for peeking and fetching the captured gpu info. Make sure we catch

[Intel-gfx] [PULL] drm-intel-fixes

2018-12-07 Thread Joonas Lahtinen
Hi Dave, Of course one severe fix appeared on Wednesday, so here it is (with the GVT fix). Fix for system crash after GPU hang (Bugzilla #107945) and GVT fix for guest graphics corruption (https://github.com/intel/gvt-linux/issues/61) Regards, Joonas *** drm-intel-fixes-2018-12-07: - Fix for

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for igt: add timeline test cases (rev2)

2018-12-07 Thread Chris Wilson
Quoting zhoucm1 (2018-12-07 10:36:37) > > > On 2018年12月07日 18:29, Chris Wilson wrote: > > Quoting Patchwork (2018-12-07 10:27:46) > >> == Series Details == > >> > >> Series: igt: add timeline test cases (rev2) > >> URL : https://patchwork.freedesktop.org/series/53743/ > >> State : failure > >>

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Pipeline PDP updates for Braswell

2018-12-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-12-07 10:30:53) > Is BSW fixed now? Or just a tiny bit better? For some value of a lot better. gem_concurrent_blit is still getting the odd false-positive missed-breadcrumb report, the occasional incoherency (I think is insufficient mb around fence register changes)

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Pipeline PDP updates for Braswell

2018-12-07 Thread Tvrtko Ursulin
On 07/12/2018 09:02, Chris Wilson wrote: Currently we face a severe problem on Braswell that manifests as invalid ppGTT accesses. The code tries to maintain the PDP (page directory pointers) inside the context in two ways, direct write into the context and a pipelined LRI update. The direct

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for igt: add timeline test cases (rev2)

2018-12-07 Thread Chris Wilson
Quoting Patchwork (2018-12-07 10:27:46) > == Series Details == > > Series: igt: add timeline test cases (rev2) > URL : https://patchwork.freedesktop.org/series/53743/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_5281 -> IGTPW_2133 >

Re: [Intel-gfx] [RFT i-g-t 1/2] tests/gem_shrink: Background, direct and OOM shrinker plus userptr tests

2018-12-07 Thread Tvrtko Ursulin
On 07/12/2018 10:17, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-12-07 10:14:53) +static void trigger_oom(void) +{ + const char *cmd = "f"; +int fd; + +fd = open("/proc/sysrq-trigger", O_WRONLY); +igt_assert_fd(fd); /proc/sysrq-trigger may not exist.

[Intel-gfx] ✗ Fi.CI.BAT: failure for igt: add timeline test cases (rev2)

2018-12-07 Thread Patchwork
== Series Details == Series: igt: add timeline test cases (rev2) URL : https://patchwork.freedesktop.org/series/53743/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5281 -> IGTPW_2133 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH 2/3] drm/i915/ringbuffer: EMIT_INVALIDATE after switch context

2018-12-07 Thread Tvrtko Ursulin
On 07/12/2018 09:02, Chris Wilson wrote: The recommend procedure was to switch contexts (and mm) then invalidate the TLBs. Make it so. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_ringbuffer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Push EMIT_INVALIDATE at request start to backends

2018-12-07 Thread Tvrtko Ursulin
On 07/12/2018 09:02, Chris Wilson wrote: Move the common engine->emit_flush(EMIT_INVALIDATE) back to the backends (where it was once previously) as we seek to specialise it in future patches. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_request.c | 5 -

Re: [Intel-gfx] [RFT i-g-t 1/2] tests/gem_shrink: Background, direct and OOM shrinker plus userptr tests

2018-12-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-12-07 10:14:53) > +static void trigger_oom(void) > +{ > + const char *cmd = "f"; > +int fd; > + > +fd = open("/proc/sysrq-trigger", O_WRONLY); > +igt_assert_fd(fd); /proc/sysrq-trigger may not exist. subgroup fixture igt_require? -Chris

[Intel-gfx] [RFT i-g-t 1/2] tests/gem_shrink: Background, direct and OOM shrinker plus userptr tests

2018-12-07 Thread Tvrtko Ursulin
From: Tvrtko Ursulin ... Signed-off-by: Tvrtko Ursulin --- lib/igt_core.c | 18 lib/igt_core.h | 1 + tests/i915/gem_shrink.c | 213 3 files changed, 232 insertions(+) diff --git a/lib/igt_core.c b/lib/igt_core.c index

[Intel-gfx] [PATCH i-g-t] igt: add timeline test cases

2018-12-07 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- include/drm-uapi/drm.h | 33 ++ lib/igt_syncobj.c| 204 +++ lib/igt_syncobj.h| 19 + tests/meson.build|1 + tests/syncobj_timeline.c | 1100 ++ 5 files changed, 1357 insertions(+) create

Re: [Intel-gfx] [PATCH] drivers/base: use a worker for sysfs unbind

2018-12-07 Thread Chris Wilson
Quoting Daniel Vetter (2018-12-07 09:31:33) > +void unbind_work_fn(struct work_struct *work) > +{ > + struct unbind_work *unbind_work = > + container_of(work, struct unbind_work, work); > + > + device_release_driver(unbind_work->dev); > +

[Intel-gfx] [PATCH] drivers/base: use a worker for sysfs unbind

2018-12-07 Thread Daniel Vetter
Drivers might want to remove some sysfs files, which needs the same locks and ends up angering lockdep. Relevant snippet of the stack trace: kernfs_remove_by_name_ns+0x3b/0x80 bus_remove_driver+0x92/0xa0 acpi_video_unregister+0x24/0x40 i915_driver_unload+0x42/0x130 [i915]

[Intel-gfx] ✓ Fi.CI.BAT: success for Change KVMGT into self loadable module (rev4)

2018-12-07 Thread Patchwork
== Series Details == Series: Change KVMGT into self loadable module (rev4) URL : https://patchwork.freedesktop.org/series/53379/ State : success == Summary == CI Bug Log - changes from CI_DRM_5280 -> Patchwork_11043 Summary ---

[Intel-gfx] [PATCH] drm/i915: Skip the ERR_PTR error state

2018-12-07 Thread Chris Wilson
Although commit fb6f0b64e455 ("drm/i915: Prevent machine hang from Broxton's vtd w/a and error capture") applied cleanly after a 24 month hiatus, the code had moved on with new methods for peeking and fetching the captured gpu info. Make sure we catch all uses of the stashed error state and avoid

[Intel-gfx] [PATCH v2] drm/i915/icl: Fix pipe config mismatch warnings

2018-12-07 Thread Stanislav Lisovskiy
Fixes hblank, vblank, vsync_start/vsync_end, hsync_start//hsync_end, pipe_bpp, port clock, pixel rate mismatches for dsi which happen during pipe_config comparation in intel_atomic_check. v2: Removed duplicate code, unused variables and unneeded const modifier for pipe_config. Signed-off-by:

Re: [Intel-gfx] [PATCH v11 00/23] drm/i915/icl: dsi enabling

2018-12-07 Thread Lisovskiy, Stanislav
Hi, I decided to create a simple patch, which fixes those warns: [ 12.773332] [drm:pipe_config_err [i915]] *ERROR* mismatch in base.adjusted_mode.crtc_hdisplay (expected 1440, found 720) [ 12.773425] [drm:pipe_config_err [i915]] *ERROR* mismatch in base.adjusted_mode.crtc_htotal (expected

[Intel-gfx] [PATCH 3/3] drm/i915: Pipeline PDP updates for Braswell

2018-12-07 Thread Chris Wilson
Currently we face a severe problem on Braswell that manifests as invalid ppGTT accesses. The code tries to maintain the PDP (page directory pointers) inside the context in two ways, direct write into the context and a pipelined LRI update. The direct write into the context is fundamentally racy as

[Intel-gfx] [PATCH 2/3] drm/i915/ringbuffer: EMIT_INVALIDATE after switch context

2018-12-07 Thread Chris Wilson
The recommend procedure was to switch contexts (and mm) then invalidate the TLBs. Make it so. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_ringbuffer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c

[Intel-gfx] [PATCH 1/3] drm/i915: Push EMIT_INVALIDATE at request start to backends

2018-12-07 Thread Chris Wilson
Move the common engine->emit_flush(EMIT_INVALIDATE) back to the backends (where it was once previously) as we seek to specialise it in future patches. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_request.c | 5 - drivers/gpu/drm/i915/intel_lrc.c| 9 ++---

[Intel-gfx] [PATCH] drm/i915/icl: Fix pipe config mismatch warnings

2018-12-07 Thread Stanislav Lisovskiy
Fixes hblank, vblank, vsync_start/vsync_end, hsync_start//hsync_end, pipe_bpp, port clock, pixel rate mismatches for dsi which happen during pipe_config comparation in intel_atomic_check. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/icl_dsi.c | 93

[Intel-gfx] [RFT i-g-t 1/2] tests/gem_shrink: Background, direct and OOM shrinker plus userptr tests

2018-12-07 Thread Tvrtko Ursulin
From: Tvrtko Ursulin ... Signed-off-by: Tvrtko Ursulin --- tests/i915/gem_shrink.c | 213 1 file changed, 213 insertions(+) diff --git a/tests/i915/gem_shrink.c b/tests/i915/gem_shrink.c index c8e05814ee70..acc12efed15e 100644 ---

[Intel-gfx] [RFT i-g-t 2/2] intel-ci: Unblack list the new tests??

2018-12-07 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- tests/intel-ci/blacklist.txt | 1 + tests/intel-ci/fast-feedback.testlist | 2 ++ 2 files changed, 3 insertions(+) diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt index 73d127603d28..8083efc407d4 100644

Re: [Intel-gfx] drm tip conflict in intel_workarounds.c

2018-12-07 Thread Tvrtko Ursulin
On 06/12/2018 19:36, Rodrigo Vivi wrote: On Thu, Dec 06, 2018 at 12:25:48PM +1000, Dave Airlie wrote: I merged the i915 tree into drm-next this morning, but got a major conflict on the drm-tip rebuild in intel_workarounds.c. I'm not sure if I did wrong thing, but there were a couple of places

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Return immediately if trylock fails for direct-reclaim

2018-12-07 Thread Chris Wilson
Quoting Chris Wilson (2018-12-06 21:30:25) > Quoting Tvrtko Ursulin (2018-12-06 15:18:13) > > > > On 04/12/2018 14:15, Chris Wilson wrote: > > > Ignore trying to shrink from i915 if we fail to acquire the struct_mutex > > > in the shrinker while performing direct-reclaim. The trade-off being > >

[Intel-gfx] [PATCH v6 2/3] drm/i915/gvt: remove unused parameter for hypervisor's host_exit call

2018-12-07 Thread Zhenyu Wang
The parameter 'void *gvt' is not used and required for hypervisor's exit call. Even for non-merged Xen hypervisor support. So just remove it. Signed-off-by: Zhenyu Wang --- drivers/gpu/drm/i915/gvt/gvt.c | 2 +- drivers/gpu/drm/i915/gvt/hypercall.h | 2 +- drivers/gpu/drm/i915/gvt/kvmgt.c

[Intel-gfx] [PATCH v6 1/3] drm/i915/gvt: mandatory require hypervisor's host_init

2018-12-07 Thread Zhenyu Wang
Don't mark hypervisor module's host_init as optional, but mandatory required. Signed-off-by: Zhenyu Wang --- drivers/gpu/drm/i915/gvt/mpt.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/mpt.h b/drivers/gpu/drm/i915/gvt/mpt.h index

[Intel-gfx] [PATCH v6 3/3] drm/i915/gvt: Change KVMGT as self load module

2018-12-07 Thread Zhenyu Wang
This trys to make 'kvmgt' module as self loadable instead of loading by i915/gvt device model. So hypervisor specific module could be stand-alone, e.g only after loading hypervisor specific module, GVT feature could be enabled via specific hypervisor interface, e.g VFIO/mdev. So this trys to use

[Intel-gfx] [PATCH v6 0/3] Change KVMGT into self loadable module

2018-12-07 Thread Zhenyu Wang
This series try to change 'kvmgt' as self loadable module to enable GVT feature for VFIO/mdev interface when user loads 'kvmgt' module, instead of current method to load hypervisor module when i915/gvt device model initializes. Resend whole series for QA's jekins job. v6: - remove unused

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/3] ACPI / PMIC: Add support for executing PMIC MIPI sequence elements

2018-12-07 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] ACPI / PMIC: Add support for executing PMIC MIPI sequence elements URL : https://patchwork.freedesktop.org/series/53662/ State : success == Summary == CI Bug Log - changes from CI_DRM_5275_full -> Patchwork_11035_full

Re: [Intel-gfx] [PATCH v4] drm/i915/gvt: Change KVMGT as self load module

2018-12-07 Thread Zhenyu Wang
On 2018.12.07 07:47:59 +, He, Min wrote: > Zhenyu, > Overall I think the impact to AcrnGT is not big, we can modify our code to > adapt > to the new interfaces. > But I have some comments embedded. > Good! > > > @@ -467,6 +408,44 @@ int intel_gvt_init_device(struct drm_i915_private > >

<    1   2