On Mon, 17 Dec 2018 18:26:03 -0700
Michael Sartain wrote:
> Ftrace and perf are fantastic, stable, very well known, and documented with
> ecosystems built around them. AMD already is doing exactly what we are asking
> for with tracepoints, and Intel has tracepoints that work right now. Please,
>
== Series Details ==
Series: series starting with [v4,1/2] drm: Add color management LUT validation
helper (v4)
URL : https://patchwork.freedesktop.org/series/54170/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5325_full -> Patchwork_1_full
On Thu, 2018-12-13 at 15:09 -0800, Dhinakaran Pandiyan wrote:
> On Thu, 2018-12-13 at 07:18 +0200, Ville Syrjälä wrote:
> > On Wed, Dec 12, 2018 at 04:32:02PM -0800, Dhinakaran Pandiyan
> > wrote:
> > > On Tue, 2018-11-20 at 18:13 +0200, Ville Syrjala wrote:
> > > > From: Ville Syrjälä
> > > >
>
I'm writing to try and make a case for Tvrtko's "Remove
DRM_I915_LOW_LEVEL_TRACEPOINTS Kconfig" patch:
https://lists.freedesktop.org/archives/intel-gfx/2018-June/169052.html
Including the tracing team maintainers because this conversation intersects
with their area. Also Pierre-Loup from Valve
== Series Details ==
Series: drm/i915/icl: combo port vswing programming changes per BSPEC (rev5)
URL : https://patchwork.freedesktop.org/series/53340/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5325_full -> Patchwork_0_full
== Series Details ==
Series: series starting with [v4,1/2] drm: Add color management LUT validation
helper (v4)
URL : https://patchwork.freedesktop.org/series/54170/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5325 -> Patchwork_1
== Series Details ==
Series: drm/i915/icl: combo port vswing programming changes per BSPEC (rev5)
URL : https://patchwork.freedesktop.org/series/53340/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5325 -> Patchwork_0
We currently program userspace-provided gamma and degamma LUT's into our
hardware without really checking to see whether they satisfy our
hardware's rules. We should try to catch tables that are invalid for
our hardware early and reject the atomic transaction.
All of our platforms that accept a
Some hardware may place additional restrictions on the gamma/degamma
curves described by our LUT properties. E.g., that a gamma curve never
decreases or that the red/green/blue channels of a LUT's entries must be
equal. Let's add a helper function that drivers can use to test that a
From: Clint Taylor
In August 2018 the BSPEC changed the ICL port programming sequence to
closely resemble earlier gen programming sequence. Restrict combo phy to
HBR max rate unless eDP panel is connected to port.
v2: remove debug code that Imre found
v3: simplify translation table if-else
v4:
On Fri, Dec 14, 2018 at 08:27:01PM +0200, Imre Deak wrote:
> This is needed by the next patch to determine if a DDI TypeC port is
> physically wired to a legacy DP or legacy HDMI connector or if the port
> is wired to a USB-C/Thunderbolt connector.
>
> Cc: Jani Nikula
> Cc: Paulo Zanoni
> Cc:
On Mon, Dec 17, 2018 at 09:35:05PM +0200, Imre Deak wrote:
> On Mon, Dec 17, 2018 at 10:05:40AM -0800, Rodrigo Vivi wrote:
> > On Fri, Dec 14, 2018 at 08:27:02PM +0200, Imre Deak wrote:
> > > Atm HPD disconnect events on TypeC ports will break things, since we'll
> > > switch the TypeC mode
On 2018-12-14 3:47 a.m., Daniel Vetter wrote:
> On Thu, Dec 13, 2018 at 08:25:31PM -0500, Lyude Paul wrote:
>> There should be no functional changes here
>
> Would be good to explain what you did refactor here, instead of me trying
> to reconstruct it from the patch. Especially pre-coffee that
On 2018-12-14 3:42 a.m., Daniel Vetter wrote:
> On Thu, Dec 13, 2018 at 08:25:30PM -0500, Lyude Paul wrote:
>> There's no reason we need this, it's just confusing looking.
>>
>> Signed-off-by: Lyude Paul
>> Cc: Juston Li
>> ---
>> drivers/gpu/drm/drm_dp_mst_topology.c | 4 +---
>> 1 file
On Mon, Dec 17, 2018 at 10:05:40AM -0800, Rodrigo Vivi wrote:
> On Fri, Dec 14, 2018 at 08:27:02PM +0200, Imre Deak wrote:
> > Atm HPD disconnect events on TypeC ports will break things, since we'll
> > switch the TypeC mode (between legacy and disconnected modes as well as
> > among USB DP
On Mon, Dec 17, 2018 at 03:23:14PM +0100, Hans de Goede wrote:
> Hi All,
>
> As discussed a while ago, I would like to see us enable fastboot by
> default, starting with Skylake / GEN9 and newer hardware, so that we can
> avoid an unnecessary modeset at boot and move to a truely flickerfree boot.
== Series Details ==
Series: drm/i915: Apply missed interrupt after reset w/a to all ringbuffer gen
(rev7)
URL : https://patchwork.freedesktop.org/series/53979/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5324_full -> Patchwork_11108_full
On Mon, Dec 17, 2018 at 06:07:45PM +, Chris Wilson wrote:
> Quoting Ville Syrjälä (2018-12-17 18:02:25)
> > On Mon, Dec 17, 2018 at 03:20:55PM +, Chris Wilson wrote:
> > > Having completed a test run of gem_eio across all machines in CI we also
> > > observe the phenomenon (of lost
Quoting Ville Syrjälä (2018-12-17 18:02:25)
> On Mon, Dec 17, 2018 at 03:20:55PM +, Chris Wilson wrote:
> > Having completed a test run of gem_eio across all machines in CI we also
> > observe the phenomenon (of lost interrupts after resetting the GPU) on
> > gen3 machines as well as the
On Fri, Dec 14, 2018 at 08:27:02PM +0200, Imre Deak wrote:
> Atm HPD disconnect events on TypeC ports will break things, since we'll
> switch the TypeC mode (between legacy and disconnected modes as well as
> among USB DP alternate, Thunderbolt alternate and disconnected modes) on
> the fly from
Op 17-12-2018 om 15:19 schreef Hans de Goede:
> When the pipe_config's update_pipe flag is set we may need to update the
> panel fitting settings. On GEN9+ this means we need to update the crtc's
> scaler settings.
>
> This fixes the following WARN_ON, during i915 loading on an Asrock
> B150M
On Mon, Dec 17, 2018 at 03:20:55PM +, Chris Wilson wrote:
> Having completed a test run of gem_eio across all machines in CI we also
> observe the phenomenon (of lost interrupts after resetting the GPU) on
> gen3 machines as well as the previously sighted gen6/gen7. Let's apply
> the same
>-Original Message-
>From: Josh Boyer [mailto:jwbo...@kernel.org]
>Sent: Monday, December 17, 2018 4:38 AM
>To: Srivatsa, Anusha
>Cc: Kyle McMartin ; Ben Hutchings ;
>Intel Graphics Development ; Vivi, Rodrigo
>
>Subject: Re: linux-firmware PR for BXT HUC
>
>On Fri, Dec 7, 2018 at 5:14
On Thu, Oct 25, 2018 at 12:36:01PM -0700, Nathan Chancellor wrote:
> This warning is disabled by default in scripts/Makefile.extrawarn when
> W= is not provided but this Makefile adds -Wall after this warning is
> disabled so it shows up in the build when it shouldn't:
>
> In file included from
On Sun, Dec 16, 2018 at 11:05:27PM -0800, Rodrigo Vivi wrote:
> On Sat, Dec 15, 2018 at 01:25:45AM +0200, Imre Deak wrote:
> > On Fri, Dec 14, 2018 at 02:22:09PM -0800, Rodrigo Vivi wrote:
> > > On Fri, Dec 14, 2018 at 01:25:07AM +0200, Imre Deak wrote:
> > > > On Thu, Dec 13, 2018 at 01:06:51PM
== Series Details ==
Series: drm/i915: Enable fastset by default, except on initial modeset (rev2)
URL : https://patchwork.freedesktop.org/series/43248/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5324_full -> Patchwork_11106_full
On Mon, Dec 17, 2018 at 7:49 AM Daniel Vetter wrote:
>
> On Wed, Sep 05, 2018 at 05:38:27PM -0300, Rodrigo Siqueira wrote:
> > This commit adds a new option for forcing the use of a specific driver
> > indicated via an environment variable.
> >
> > Changes since V1:
> > Petri:
> > - Use an
Hi,
On 17-12-18 16:54, Ville Syrjala wrote:
From: Ville Syrjälä
Remainder of the infoframe precompute/check work. Review comments
addressesed, and I added a bunch of FIXMEs for lspcon. Note that
the lack of proper implementation for lspcon shouldn't matter since
we don't do the
On 12/17, Daniel Vetter wrote:
> On Wed, Sep 05, 2018 at 05:38:27PM -0300, Rodrigo Siqueira wrote:
> > This commit adds a new option for forcing the use of a specific driver
> > indicated via an environment variable.
> >
> > Changes since V1:
> > Petri:
> > - Use an environment variable instead
== Series Details ==
Series: drm/i915: Infoframe precompute/check (rev5)
URL : https://patchwork.freedesktop.org/series/49983/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5324 -> Patchwork_11109
Summary
---
== Series Details ==
Series: drm/i915: Infoframe precompute/check (rev5)
URL : https://patchwork.freedesktop.org/series/49983/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: video/hdmi: Add an enum for HDMI packet types
Okay!
Commit: drm/i915: Add
== Series Details ==
Series: drm/i915: Infoframe precompute/check (rev5)
URL : https://patchwork.freedesktop.org/series/49983/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
cfd286f0f4dd video/hdmi: Add an enum for HDMI packet types
b564529095d2 drm/i915: Add the missing HDMI
== Series Details ==
Series: drm/i915: Update crtc scaler settings when update_pipe is set
URL : https://patchwork.freedesktop.org/series/54138/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5324_full -> Patchwork_11105_full
From: Ville Syrjälä
Check the infoframes and infoframe enable state when comparing two
crtc states.
We'll use the infoframe logging functions from video/hdmi.c to
show the infoframes as part of the state dump.
TODO: Try to better integrate the infoframe dumps with
drm state dumps
v2:
From: Ville Syrjälä
Dump out the infoframes in the normal crtc state dump.
TODO: Try to better integrate the infoframe dumps with
drm state dumps
Signed-off-by: Ville Syrjälä
Reviewed-by: Daniel Vetter
---
drivers/gpu/drm/i915/intel_display.c | 26 ++
1 file
From: Ville Syrjälä
Read the HDMI infoframes from the hbuf and unpack them into
the crtc state.
Well, actually just AVI infoframe for now but let's write the
infoframe readout code in a more generic fashion in case we
expand this later.
Note that Daniel was sceptical about the benefit if this
From: Ville Syrjälä
As with regular HDMI encoders, let's precompute the infoframes
(actually just AVI infoframe for the time being) with SDVO HDMI
encoders.
v2: Drop the WARN_ON() from drm_hdmi_avi_infoframe_from_display_mode()
return since that could genuinely fail due to user asking
From: Ville Syrjälä
Store the mask of enabled infoframes in the crtc state. We'll start
with just the readout for HDMI encoder, and we'll expand this
to compute the bitmask in .compute_config() later. SDVO will also
follow later.
Signed-off-by: Ville Syrjälä
Reviewed-by: Daniel Vetter
---
From: Ville Syrjälä
Add code to read the infoframes from the video DIP and unpack them into
the crtc state.
v2: Make the read funcs return void (Daniel)
Drop the duplicate infoframe enabled checks (Daniel)
Add a FIXME for lspcon infoframe readout
Signed-off-by: Ville Syrjälä
From: Ville Syrjälä
Store the infoframes in the crtc state and precompute them in
.compute_config(). While precomputing we'll also fill out the
inforames.enable bitmask appropriately.
v2: Drop the null packet stuff (Daniel)
Add a FIXME for lspcon
Signed-off-by: Ville Syrjälä
Reviewed-by:
From: Ville Syrjälä
Remainder of the infoframe precompute/check work. Review comments
addressesed, and I added a bunch of FIXMEs for lspcon. Note that
the lack of proper implementation for lspcon shouldn't matter since
we don't do the precompute/readout/check for DP encoders atm.
Entire series
From: Ville Syrjälä
We want to start tracking which infoframes are enabled, so let's replace
the boolean flag with a bitmask.
We'll abstract the bitmask so that it's not platform dependent. That
will allow us to examine the bitmask later in platform independent code.
v2: Don't map
From: Ville Syrjälä
We'll be wanting to send more than just infoframes over HDMI. So add an
enum for other packet types.
TODO: Maybe just include the infoframe types in the packet type enum
and get rid of the infoframe type enum?
Cc: Thierry Reding
Cc: Hans Verkuil
Cc:
From: Ville Syrjälä
We have definitions and low level code for everything except the gamut
metadata HDMI packet. Add the missing bits.
Signed-off-by: Ville Syrjälä
Reviewed-by: Daniel Vetter
---
drivers/gpu/drm/i915/i915_reg.h | 8 +---
drivers/gpu/drm/i915/intel_hdmi.c | 12
Talha writes:
> From: talha nassar
>
> Enables blend optimization for floating point RTs
>
> This restores the workaround that was reverted in c358514ba8da
> ("Revert "drm/i915/icl: WaEnableFloatBlendOptimization"").
>
> The revert was due to the register write seemingly not sticking,
> but the
On Wed, Sep 05, 2018 at 05:38:27PM -0300, Rodrigo Siqueira wrote:
> This commit adds a new option for forcing the use of a specific driver
> indicated via an environment variable.
>
> Changes since V1:
> Petri:
> - Use an environment variable instead of command line
> - Refactor the loop in
On Wed, Aug 22, 2018 at 01:20:38PM +0300, Petri Latvala wrote:
> This commit adds a new option for forcing the use of a specific driver
> indicated via an environment variable.
>
> v2 (Petri):
> - Use an environment variable instead of command line
> - Refactor the loop in __open_device
> -
== Series Details ==
Series: drm/i915: Apply missed interrupt after reset w/a to all ringbuffer gen
(rev7)
URL : https://patchwork.freedesktop.org/series/53979/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5324 -> Patchwork_11108
On Tue, Dec 11, 2018 at 01:31:12PM -0800, clinton.a.tay...@intel.com wrote:
> From: Clint Taylor
>
> In August 2018 the BSPEC changed the ICL port programming sequence to
> closely resemble earlier gen programming sequence. Restrict combo phy to
> HBR max rate unless eDP panel is connected to
== Series Details ==
Series: drm/i915: Enable fastset by default, except on initial modeset (rev2)
URL : https://patchwork.freedesktop.org/series/43248/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5324 -> Patchwork_11106
On 2018-12-14 12:10, Joonas Lahtinen wrote:
Quoting Tvrtko Ursulin (2018-12-10 17:40:34)
On 09/11/2018 17:18, Tomasz Lis wrote:
The patch adds support of preempt-to-idle requesting by setting a proper
bit within Execlist Control Register, and receiving preemption result from
Context Status
Having completed a test run of gem_eio across all machines in CI we also
observe the phenomenon (of lost interrupts after resetting the GPU) on
gen3 machines as well as the previously sighted gen6/gen7. Let's apply
the same HWSTAM workaround that was effective for gen6+ for all, as
although we
== Series Details ==
Series: drm/i915: Enable fastboot by default on Skylake and newer
URL : https://patchwork.freedesktop.org/series/54143/
State : failure
== Summary ==
Applying: drm/i915: Enable fastboot by default on Skylake and newer
error: sha1 information is lacking or useless
On Mon, 17 Dec 2018 at 15:22, Vincent Guittot
wrote:
>
> On Fri, 14 Dec 2018 at 15:36, Ulf Hansson wrote:
> >
> > On Fri, 14 Dec 2018 at 15:22, Vincent Guittot
> > wrote:
> > >
> > > With jiffies been replaced by raw ns in PM core accounting, 915 driver is
> > > updated to use this new time
Hi,
On 17-12-18 15:38, Ville Syrjälä wrote:
On Mon, Dec 17, 2018 at 03:23:14PM +0100, Hans de Goede wrote:
Hi All,
As discussed a while ago, I would like to see us enable fastboot by
default, starting with Skylake / GEN9 and newer hardware, so that we can
avoid an unnecessary modeset at boot
== Series Details ==
Series: dim: Remove git commit --amend from dim_apply
URL : https://patchwork.freedesktop.org/series/738/
State : failure
== Summary ==
Patch is empty.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip"
== Series Details ==
Series: drm/i915: Update crtc scaler settings when update_pipe is set
URL : https://patchwork.freedesktop.org/series/54138/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5324 -> Patchwork_11105
Summary
Quoting talhanassartalha.nas...@intel.com (2018-12-15 00:29:19)
> From: talha nassar
>
> Enables blend optimization for floating point RTs
>
> This restores the workaround that was reverted in c358514ba8da
> ("Revert "drm/i915/icl: WaEnableFloatBlendOptimization"").
>
> The revert was due to
On Mon, Dec 17, 2018 at 03:23:14PM +0100, Hans de Goede wrote:
> Hi All,
>
> As discussed a while ago, I would like to see us enable fastboot by
> default, starting with Skylake / GEN9 and newer hardware, so that we can
> avoid an unnecessary modeset at boot and move to a truely flickerfree boot.
Hi,
On 17-12-18 15:29, Daniel Vetter wrote:
On Mon, Dec 17, 2018 at 3:23 PM Hans de Goede wrote:
From: Maarten Lankhorst
We may not be perfect at reading out the initial mode, but when the mode
is sanitized by our first modeset we know for sure the state is compatible,
so we can compare
On Mon, Dec 17, 2018 at 3:23 PM Hans de Goede wrote:
>
> From: Maarten Lankhorst
>
> We may not be perfect at reading out the initial mode, but when the mode
> is sanitized by our first modeset we know for sure the state is compatible,
> so we can compare with intel_pipe_config_compare.
>
>
We really want to have fastboot enabled by default to avoid an ugly
modeset during boot.
Rather then enabling it everywhere, lets start with enabling it on
Skylake and newer.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/i915_params.c | 6 --
drivers/gpu/drm/i915/i915_params.h
Hi All,
As discussed a while ago, I would like to see us enable fastboot by
default, starting with Skylake / GEN9 and newer hardware, so that we can
avoid an unnecessary modeset at boot and move to a truely flickerfree boot.
During our previous discussion about this Maarten mentioned that a
From: Maarten Lankhorst
We may not be perfect at reading out the initial mode, but when the mode
is sanitized by our first modeset we know for sure the state is compatible,
so we can compare with intel_pipe_config_compare.
Changes in v2 (Hans de Goede):
-When checking if we need to reset the
On Fri, 14 Dec 2018 at 15:36, Ulf Hansson wrote:
>
> On Fri, 14 Dec 2018 at 15:22, Vincent Guittot
> wrote:
> >
> > With jiffies been replaced by raw ns in PM core accounting, 915 driver is
> > updated to use this new time infrastructure.
> >
> > Signed-off-by: Vincent Guittot
> > ---
> >
When the pipe_config's update_pipe flag is set we may need to update the
panel fitting settings. On GEN9+ this means we need to update the crtc's
scaler settings.
This fixes the following WARN_ON, during i915 loading on an Asrock
B150M Pro4S/D3 board with an i5-6500 CPU / graphics:
On Mon, Dec 17, 2018 at 2:42 PM Winkler, Tomas wrote:
>
> >
> > On Mon, Dec 17, 2018 at 12:28 PM Winkler, Tomas
> > wrote:
> > >
> > > >
> > > > Header defines the interface for the I915 and MEI_HDCP drivers.
> > > >
> > > > Signed-off-by: Ramalingam C
> > > > ---
> > > >
On Thu, Dec 13, 2018 at 01:55:25PM -0800, Matt Roper wrote:
> Some hardware may place additional restrictions on the gamma/degamma
> curves described by our LUT properties. E.g., that a gamma curve never
> decreases or that the red/green/blue channels of a LUT's entries must be
> equal. Let's
On Mon, Dec 17, 2018 at 11:57 AM Winkler, Tomas wrote:
>
>
> > On Sat, Dec 15, 2018 at 09:20:38PM +, Winkler, Tomas wrote:
> > > >
> > > > On Thu, Dec 13, 2018 at 5:27 PM Winkler, Tomas
> > > >
> > > > wrote:
> > > > >
> > > > > > On Thu, Dec 13, 2018 at 1:36 PM C, Ramalingam
> > > > > >
>
>
> On Mon, Dec 17, 2018 at 12:28 PM Winkler, Tomas
> wrote:
> >
> > >
> > > Header defines the interface for the I915 and MEI_HDCP drivers.
> > >
> > > Signed-off-by: Ramalingam C
> > > ---
> > > include/drm/i915_mei_hdcp_interface.h | 132
> > > ++
> > > 1
On Mon, Dec 17, 2018 at 12:28 PM Winkler, Tomas wrote:
>
> >
> > Header defines the interface for the I915 and MEI_HDCP drivers.
> >
> > Signed-off-by: Ramalingam C
> > ---
> > include/drm/i915_mei_hdcp_interface.h | 132
> > ++
> > 1 file changed, 132
== Series Details ==
Series: series starting with [RESEND,1/5] drm/i915/backlight: Restore backlight
on resume, v2.
URL : https://patchwork.freedesktop.org/series/54127/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5323_full -> Patchwork_11104_full
On Fri, Dec 7, 2018 at 5:14 PM Srivatsa, Anusha
wrote:
>
> Hi Josh, Kyle, Ben,
>
> Kindly add the below i915 changes to linux-firmware.git-
>
> The following changes since commit 1baa34868b2c0a004dc595b20678145e3fff83e7:
>
> Merge branch 'nxp_mc' of https://github.com/NXP/linux-firmware
>
> Header defines the interface for the I915 and MEI_HDCP drivers.
>
> Signed-off-by: Ramalingam C
> ---
> include/drm/i915_mei_hdcp_interface.h | 132
> ++
> 1 file changed, 132 insertions(+)
> create mode 100644 include/drm/i915_mei_hdcp_interface.h
>
>
Op 11-12-2018 om 19:16 schreef Souza, Jose:
> On Tue, 2018-12-04 at 13:23 -0800, Dhinakaran Pandiyan wrote:
>> On Tue, 2018-12-04 at 10:52 -0800, Souza, Jose wrote:
>>> On Mon, 2018-12-03 at 18:58 -0800, Dhinakaran Pandiyan wrote:
On Mon, 2018-12-03 at 17:54 -0800, Souza, Jose wrote:
> On
> On Sat, Dec 15, 2018 at 09:20:38PM +, Winkler, Tomas wrote:
> > >
> > > On Thu, Dec 13, 2018 at 5:27 PM Winkler, Tomas
> > >
> > > wrote:
> > > >
> > > > > On Thu, Dec 13, 2018 at 1:36 PM C, Ramalingam
> > > > >
> > > > > wrote:
> > > > > >
> > > > > > Tomas and Daniel,
> > > > > >
> > >
== Series Details ==
Series: series starting with [RESEND,1/5] drm/i915/backlight: Restore backlight
on resume, v2.
URL : https://patchwork.freedesktop.org/series/54127/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5323 -> Patchwork_11104
== Series Details ==
Series: series starting with [RESEND,1/5] drm/i915/backlight: Restore backlight
on resume, v2.
URL : https://patchwork.freedesktop.org/series/54127/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915/backlight: Restore
== Series Details ==
Series: series starting with [RESEND,1/5] drm/i915/backlight: Restore backlight
on resume, v2.
URL : https://patchwork.freedesktop.org/series/54127/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
0a0c31336671 drm/i915/backlight: Restore backlight on
On Mon, Dec 17, 2018 at 10:39:07AM +0100, Daniel Vetter wrote:
> On Sat, Dec 15, 2018 at 09:20:38PM +, Winkler, Tomas wrote:
> > >
> > > On Thu, Dec 13, 2018 at 5:27 PM Winkler, Tomas
> > > wrote:
> > > >
> > > > > On Thu, Dec 13, 2018 at 1:36 PM C, Ramalingam
> > > > >
> > > > > wrote:
> >
Restore our saved values for backlight. This way even with fastset on
S4 resume we will correctly restore the backlight to the active values.
Changes since v1:
- Call enable_backlight() when backlight.level is set. On suspend
backlight.enabled is always cleared, this makes it not a good
Now that we've solved the backlight issue, I think it's time to enable
this again by default. We've enabled it in the past, but backlight
issues prevented us from enabling it by default.
Our hardware readout is pretty complete, and with all of the connector
state moved to atomic I'm hoping we
Now that our state comparison functions are pretty complete, we should
enable fastset by default when a modeset can be avoided. Even if we're
not completely certain about the inherited state, we can be certain
after the first modeset that our sw state matches the hw state.
Signed-off-by: Maarten
This way we don't accidentally double allocate it and hopefully disable
it during fastset. I noticed this when I wrote a patch to sanity check
all of the scaler state.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 1 +
1 file changed, 1 insertion(+)
diff --git
On lynxpoint the bios sometimes sets up the backlight using the CPU
display, but the driver expects using the PWM PCH override register.
Read the value from the CPU register, then convert it to the other
units by converting from the old duty cycle, to freq, to the new units.
This value is then
On Thu, Dec 13, 2018 at 01:55:25PM -0800, Matt Roper wrote:
> Some hardware may place additional restrictions on the gamma/degamma
> curves described by our LUT properties. E.g., that a gamma curve never
> decreases or that the red/green/blue channels of a LUT's entries must be
> equal. Let's
On Sat, Dec 15, 2018 at 09:20:38PM +, Winkler, Tomas wrote:
> >
> > On Thu, Dec 13, 2018 at 5:27 PM Winkler, Tomas
> > wrote:
> > >
> > > > On Thu, Dec 13, 2018 at 1:36 PM C, Ramalingam
> > > >
> > > > wrote:
> > > > >
> > > > > Tomas and Daniel,
> > > > >
> > > > > We got an issue here.
>
87 matches
Mail list logo
