Re: [Intel-gfx] [v4 07/12] drm: Enable HDR infoframe support

2019-01-08 Thread kbuild test robot
Hi Uma, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.0-rc1 next-20190108] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

[Intel-gfx] [PULL] gvt-fixes for 5.0-rc2

2019-01-08 Thread Zhenyu Wang
Hi, Here's one race fix for gvt to handle request properly between pre-scan of workload and submission. Thanks. -- The following changes since commit bfeffd155283772bbe78c6a05dec7c0128ee500c: Linux 5.0-rc1 (2019-01-06 17:08:20 -0800) are available in the Git repository at:

Re: [Intel-gfx] [v4 05/12] drm: Add HDR capability field to plane structure

2019-01-08 Thread kbuild test robot
Hi Uma, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.0-rc1 next-20190108] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/5] drm/i915/backlight: Restore backlight on resume, v3.

2019-01-08 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/backlight: Restore backlight on resume, v3. URL : https://patchwork.freedesktop.org/series/54896/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5378_full -> Patchwork_11255_full

Re: [Intel-gfx] [v4 03/12] drm: Parse Colorimetry data block from EDID

2019-01-08 Thread kbuild test robot
Hi Uma, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.0-rc1 next-20190108] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [Intel-gfx] [v4 07/12] drm: Enable HDR infoframe support

2019-01-08 Thread kbuild test robot
Hi Uma, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.0-rc1 next-20190108] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

[Intel-gfx] ✓ Fi.CI.BAT: success for MST refcounting/atomic helpers cleanup (rev5)

2019-01-08 Thread Patchwork
== Series Details == Series: MST refcounting/atomic helpers cleanup (rev5) URL : https://patchwork.freedesktop.org/series/54030/ State : success == Summary == CI Bug Log - changes from CI_DRM_5380 -> Patchwork_11258 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Enable render context support for Ironlake (gen5) (rev2)

2019-01-08 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Enable render context support for Ironlake (gen5) (rev2) URL : https://patchwork.freedesktop.org/series/54876/ State : failure == Summary == Applying: drm/i915: Enable render context support for Ironlake (gen5) Applying:

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Enable render context support for gen4 (Broadwater to Cantiga)

2019-01-08 Thread Chris Wilson
Quoting Chris Wilson (2019-01-08 12:28:18) > Broadwater and the rest of gen4 do support being able to saving and > reloading context specific registers between contexts, providing isolation > of the basic GPU state (as programmable by userspace). This allows > userspace to assume that the GPU

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for MST refcounting/atomic helpers cleanup (rev5)

2019-01-08 Thread Patchwork
== Series Details == Series: MST refcounting/atomic helpers cleanup (rev5) URL : https://patchwork.freedesktop.org/series/54030/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5778d100cac7 drm/dp_mst: Fix some formatting in drm_dp_add_port() 2fd355b3a9aa drm/dp_mst: Fix some

Re: [Intel-gfx] [v4 01/12] drm: Add HDR source metadata property

2019-01-08 Thread kbuild test robot
Hi Uma, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.0-rc1 next-20190108] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

[Intel-gfx] [PATCH v5 18/20] drm/dp_mst: Start tracking per-port VCPI allocations

2019-01-08 Thread Lyude Paul
There has been a TODO waiting for quite a long time in drm_dp_mst_topology.c: /* We cannot rely on port->vcpi.num_slots to update * topology_state->avail_slots as the port may not exist if the parent * branch device was unplugged. This should be fixed by tracking

[Intel-gfx] [PATCH v5 09/20] drm/dp_mst: Fix payload deallocation on hotplugs using malloc refs

2019-01-08 Thread Lyude Paul
Up until now, freeing payloads on remote MST hubs that just had ports removed has almost never worked because we've been relying on port validation in order to stop us from accessing ports that have already been freed from memory, but ports which need their payloads released due to being removed

[Intel-gfx] [PATCH v5 17/20] drm/dp_mst: Add some atomic state iterator macros

2019-01-08 Thread Lyude Paul
Changes since v6: - Move EXPORT_SYMBOL() for drm_dp_mst_topology_state_funcs to this commit - Document __drm_dp_mst_state_iter_get() and note that it shouldn't be called directly Signed-off-by: Lyude Paul Reviewed-by: Daniel Vetter Cc: David Airlie Cc: Jerry Zuo Cc: Harry Wentland

[Intel-gfx] [PATCH v5 11/20] drm/amdgpu/display: Keep malloc ref to MST port

2019-01-08 Thread Lyude Paul
Just like i915 and nouveau, it's a good idea for us to hold a malloc reference to the port here so that we never pass a freed pointer to any of the DP MST helper functions. Also, we stop unsetting aconnector->port in dm_dp_destroy_mst_connector(). There's literally no point to that assignment

[Intel-gfx] [PATCH v5 14/20] drm/nouveau: Keep malloc references to MST ports

2019-01-08 Thread Lyude Paul
Now that we finally have a sane way to keep port allocations around, use it to fix the potential unchecked ->port accesses that nouveau makes by making sure we keep the mst port allocated for as long as it's drm_connector is accessible. Additionally, now that we've guaranteed that mstc->port is

[Intel-gfx] [PATCH v5 08/20] drm/dp_mst: Stop releasing VCPI when removing ports from topology

2019-01-08 Thread Lyude Paul
This has never actually worked, and isn't needed anyway: the driver's always going to try to deallocate VCPI when it tears down the display that the VCPI belongs to. Signed-off-by: Lyude Paul Reviewed-by: Harry Wentland Cc: Daniel Vetter Cc: David Airlie Cc: Jerry Zuo Cc: Juston Li ---

[Intel-gfx] [PATCH v5 20/20] drm/nouveau: Use atomic VCPI helpers for MST

2019-01-08 Thread Lyude Paul
Currently, nouveau uses the yolo method of setting up MST displays: it uses the old VCPI helpers (drm_dp_find_vcpi_slots()) for computing the display configuration. These helpers don't take care to make sure they take a reference to the mstb port that they're checking, and additionally don't

[Intel-gfx] [PATCH v5 15/20] drm/nouveau: Stop unsetting mstc->port, use malloc refs

2019-01-08 Thread Lyude Paul
Same as we did for i915, but for nouveau this time. Additionally, we grab a malloc reference to the port that lasts for the entire lifetime of nv50_mstc, which gives us the guarantee that mstc->port will always point to valid memory for as long as the mstc stays around. Signed-off-by: Lyude Paul

[Intel-gfx] [PATCH v5 03/20] drm/dp_mst: Fix some formatting in drm_dp_mst_allocate_vcpi()

2019-01-08 Thread Lyude Paul
Fix some indenting, split some stuff across multiple lines. Signed-off-by: Lyude Paul Reviewed-by: Harry Wentland Cc: Daniel Vetter Cc: David Airlie Cc: Jerry Zuo Cc: Juston Li --- drivers/gpu/drm/drm_dp_mst_topology.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff

[Intel-gfx] [PATCH v5 19/20] drm/dp_mst: Check payload count in drm_dp_mst_atomic_check()

2019-01-08 Thread Lyude Paul
It occurred to me that we never actually check this! So let's start doing that. Signed-off-by: Lyude Paul Reviewed-by: Daniel Vetter Cc: David Airlie Cc: Jerry Zuo Cc: Harry Wentland Cc: Juston Li --- drivers/gpu/drm/drm_dp_mst_topology.c | 8 +++- 1 file changed, 7 insertions(+), 1

[Intel-gfx] [PATCH v5 04/20] drm/dp_mst: Fix some formatting in drm_dp_mst_deallocate_vcpi()

2019-01-08 Thread Lyude Paul
Split some stuff across multiple lines Signed-off-by: Lyude Paul Reviewed-by: Harry Wentland Cc: Daniel Vetter Cc: David Airlie Cc: Jerry Zuo Cc: Juston Li --- drivers/gpu/drm/drm_dp_mst_topology.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH v5 05/20] drm/dp_mst: Rename drm_dp_mst_get_validated_(port|mstb)_ref and friends

2019-01-08 Thread Lyude Paul
s/drm_dp_get_validated_port_ref/drm_dp_mst_topology_get_port_validated/ s/drm_dp_put_port/drm_dp_mst_topology_put_port/ s/drm_dp_get_validated_mstb_ref/drm_dp_mst_topology_get_mstb_validated/ s/drm_dp_put_mst_branch_device/drm_dp_mst_topology_put_mstb/ This is a much more consistent naming

[Intel-gfx] [PATCH v5 16/20] drm/nouveau: Grab payload lock in nv50_msto_payload()

2019-01-08 Thread Lyude Paul
Going through the currently programmed payloads isn't safe without holding mgr->payload_lock, so actually do that and warn if anyone tries calling nv50_msto_payload() in the future without grabbing the right locks. Signed-off-by: Lyude Paul Cc: Daniel Vetter Cc: David Airlie Cc: Jerry Zuo Cc:

[Intel-gfx] [PATCH v5 13/20] drm/nouveau: Remove unnecessary VCPI checks in nv50_msto_cleanup()

2019-01-08 Thread Lyude Paul
There is no need to look at the port's VCPI allocation before calling drm_dp_mst_deallocate_vcpi(), as we already have msto->disabled to let us avoid cleaning up an msto more then once. The DP MST core will never call drm_dp_mst_deallocate_vcpi() on it's own, which is presumably what these checks

[Intel-gfx] [PATCH v5 12/20] drm/nouveau: Remove bogus cleanup in nv50_mstm_add_connector()

2019-01-08 Thread Lyude Paul
Trying to destroy the connector using mstc->connector.funcs->destroy() if connector initialization fails is wrong: there is no possible codepath in nv50_mstc_new where nv50_mstm_add_connector() would return <0 and mstc would be non-NULL. Signed-off-by: Lyude Paul Cc: Daniel Vetter Cc: David

[Intel-gfx] [PATCH v5 10/20] drm/i915: Keep malloc references to MST ports

2019-01-08 Thread Lyude Paul
So that the ports stay around until we've destroyed the connectors, in order to ensure that we don't pass an invalid pointer to any MST helpers once we introduce the new MST VCPI helpers. Changes since v1: * Move drm_dp_mst_get_port_malloc() to where we assign intel_connector->port - danvet

[Intel-gfx] [PATCH v5 06/20] drm/dp_mst: Introduce new refcounting scheme for mstbs and ports

2019-01-08 Thread Lyude Paul
The current way of handling refcounting in the DP MST helpers is really confusing and probably just plain wrong because it's been hacked up many times over the years without anyone actually going over the code and seeing if things could be simplified. To the best of my understanding, the current

[Intel-gfx] [PATCH v5 07/20] drm/dp_mst: Restart last_connected_port_and_mstb() if topology ref fails

2019-01-08 Thread Lyude Paul
While this isn't a complete fix, this will improve the reliability of drm_dp_get_last_connected_port_and_mstb() pretty significantly during hotplug events, since there's a chance that the in-memory topology tree may not be fully updated when drm_dp_get_last_connected_port_and_mstb() is called and

[Intel-gfx] [PATCH v5 01/20] drm/dp_mst: Fix some formatting in drm_dp_add_port()

2019-01-08 Thread Lyude Paul
Reindent some stuff, and split some stuff across multiple lines so we aren't going over the text width limit. Signed-off-by: Lyude Paul Reviewed-by: Harry Wentland Cc: Daniel Vetter Cc: David Airlie Cc: Jerry Zuo Cc: Juston Li --- drivers/gpu/drm/drm_dp_mst_topology.c | 18

[Intel-gfx] [PATCH v5 02/20] drm/dp_mst: Fix some formatting in drm_dp_payload_send_msg()

2019-01-08 Thread Lyude Paul
Split some stuff across multiple lines, remove some unnecessary braces Signed-off-by: Lyude Paul Reviewed-by: Harry Wentland Cc: Daniel Vetter Cc: David Airlie Cc: Jerry Zuo Cc: Juston Li --- drivers/gpu/drm/drm_dp_mst_topology.c | 14 -- 1 file changed, 8 insertions(+), 6

[Intel-gfx] [PATCH v5 00/20] MST refcounting/atomic helpers cleanup

2019-01-08 Thread Lyude Paul
This is the series I've been working on for a while now to get all of the atomic DRM drivers in the tree to use the atomic MST helpers, and to make the atomic MST helpers actually idempotent. Turns out it's a lot more difficult to do that without also fixing how port and branch device refcounting

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2019-01-08 Thread Stephen Rothwell
Hi Daniel, On Tue, 8 Jan 2019 09:37:22 +0100 Daniel Vetter wrote: > > > https://cgit.freedesktop.org/drm-tip/tree/fixups/drm-misc-next.patch?h=rerere-cache > > is the fixup you want. Should get baked into drm-next any moment, since > the first drm-misc-next pull is already out. I added that

Re: [Intel-gfx] [PATCH v4] drm/i915: Downgrade scare message for unknown HuC firmware

2019-01-08 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-01-08 22:33:18) > On Tue, 08 Jan 2019 16:02:46 +0100, Chris Wilson > wrote: > > > If we haven't shipped and enabled firmware for a particular platform, > > there is nothing the user can do about it. Don't scare the user with an > > unactionable, unidentifiable

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Downgrade scare message for unknwown HuC firmware (rev4)

2019-01-08 Thread Patchwork
== Series Details == Series: drm/i915: Downgrade scare message for unknwown HuC firmware (rev4) URL : https://patchwork.freedesktop.org/series/54868/ State : success == Summary == CI Bug Log - changes from CI_DRM_5378_full -> Patchwork_11253_full

Re: [Intel-gfx] [PATCH v4] drm/i915: Downgrade scare message for unknown HuC firmware

2019-01-08 Thread Michal Wajdeczko
On Tue, 08 Jan 2019 16:02:46 +0100, Chris Wilson wrote: If we haven't shipped and enabled firmware for a particular platform, there is nothing the user can do about it. Don't scare the user with an unactionable, unidentifiable warning! <6> [310.769452] i915 :00:02.0: GuC: No firmware

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/gvt: give the cmd parser decode_info a const treatment

2019-01-08 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gvt: give the cmd parser decode_info a const treatment URL : https://patchwork.freedesktop.org/series/54884/ State : success == Summary == CI Bug Log - changes from CI_DRM_5378_full -> Patchwork_11252_full

Re: [Intel-gfx] [PATCH v4 00/16] MST refcounting/atomic helpers cleanup

2019-01-08 Thread Lyude Paul
On Tue, 2019-01-08 at 19:57 +, Wentland, Harry wrote: > On 2019-01-04 7:14 p.m., Lyude Paul wrote: > > This is the series I've been working on for a while now to get all of > > the atomic DRM drivers in the tree to use the atomic MST helpers, and to > > make the atomic MST helpers actually

Re: [Intel-gfx] [PATCH] drm/i915/icl: Apply WaEnablePreemptionGranularityControlByUMD

2019-01-08 Thread Kenneth Graunke
On Tuesday, January 8, 2019 7:53:05 AM PST Joonas Lahtinen wrote: > + Ken/Jason for Mesa > Quoting Matt Roper (2019-01-07 21:19:31) > > On Mon, Jan 07, 2019 at 01:23:50PM +0100, Michał Winiarski wrote: > > > On Mon, Jan 07, 2019 at 01:01:16PM +0200, Joonas Lahtinen wrote: > > > > Quoting José

Re: [Intel-gfx] [PATCH v3] drm/i915: Track all held rpm wakerefs

2019-01-08 Thread kbuild test robot
Hi Chris, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v5.0-rc1 next-20190108] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/userptr: Avoid struct_mutex recursion for mmu_invalidate_range_start (rev2)

2019-01-08 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/userptr: Avoid struct_mutex recursion for mmu_invalidate_range_start (rev2) URL : https://patchwork.freedesktop.org/series/54869/ State : success == Summary == CI Bug Log - changes from CI_DRM_5378_full -> Patchwork_11251_full

Re: [Intel-gfx] [PATCH v3] drm/i915: Downgrade scare message for unknown HuC firmware

2019-01-08 Thread kbuild test robot
Hi Chris, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v5.0-rc1 next-20190108] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

Re: [Intel-gfx] [PATCH v4 00/16] MST refcounting/atomic helpers cleanup

2019-01-08 Thread Wentland, Harry
On 2019-01-04 7:14 p.m., Lyude Paul wrote: > This is the series I've been working on for a while now to get all of > the atomic DRM drivers in the tree to use the atomic MST helpers, and to > make the atomic MST helpers actually idempotent. Turns out it's a lot > more difficult to do that without

Re: [Intel-gfx] [v4 10/12] drm/i915: Add HLG EOTF

2019-01-08 Thread Matt Roper
On Tue, Jan 08, 2019 at 02:41:25PM +0530, Uma Shankar wrote: > From: Ville Syrjälä > > ADD HLG EOTF to the list of EOTF transfer functions supported. > Hybrid Log-Gamma (HLG) is a high dynamic range (HDR) standard. > HLG defines a nonlinear transfer function in which the lower > half of the

Re: [Intel-gfx] [PATCH v2 07/16] drm/amdgpu/display: Keep malloc ref to MST port

2019-01-08 Thread Wentland, Harry
On 2018-12-19 7:19 p.m., Lyude Paul wrote: > Just like i915 and nouveau, it's a good idea for us to hold a malloc > reference to the port here so that we never pass a freed pointer to any > of the DP MST helper functions. > > Also, we stop unsetting aconnector->port in >

Re: [Intel-gfx] [PATCH v2 04/16] drm/dp_mst: Stop releasing VCPI when removing ports from topology

2019-01-08 Thread Wentland, Harry
On 2018-12-19 7:19 p.m., Lyude Paul wrote: > This has never actually worked, and isn't needed anyway: the driver's > always going to try to deallocate VCPI when it tears down the display > that the VCPI belongs to. > > Signed-off-by: Lyude Paul > Reviewed-by: Daniel Vetter > Cc: David Airlie >

Re: [Intel-gfx] [PATCH v2 05/16] drm/dp_mst: Fix payload deallocation on hotplugs using malloc refs

2019-01-08 Thread Wentland, Harry
On 2018-12-19 7:19 p.m., Lyude Paul wrote: > Up until now, freeing payloads on remote MST hubs that just had ports > removed has almost never worked because we've been relying on port > validation in order to stop us from accessing ports that have already > been freed from memory, but ports which

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/edid: Pass connector to AVI infoframe functions

2019-01-08 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/edid: Pass connector to AVI infoframe functions URL : https://patchwork.freedesktop.org/series/54903/ State : success == Summary == CI Bug Log - changes from CI_DRM_5379 -> Patchwork_11257

Re: [Intel-gfx] [PATCH v2 03/16] drm/dp_mst: Restart last_connected_port_and_mstb() if topology ref fails

2019-01-08 Thread Wentland, Harry
On 2018-12-19 7:19 p.m., Lyude Paul wrote: > While this isn't a complete fix, this will improve the reliability of > drm_dp_get_last_connected_port_and_mstb() pretty significantly during > hotplug events, since there's a chance that the in-memory topology tree > may not be fully updated when

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Enable render context support for Ironlake (gen5)

2019-01-08 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Enable render context support for Ironlake (gen5) URL : https://patchwork.freedesktop.org/series/54876/ State : success == Summary == CI Bug Log - changes from CI_DRM_5378_full -> Patchwork_11249_full

[Intel-gfx] Clang warning in drivers/gpu/drm/i915/i915_debugfs.c

2019-01-08 Thread Nathan Chancellor
Hi all, Commit e845f099f1c6 ("drm/i915/dsc: Add Per connector debugfs node for DSC support/enable") causes a Clang warning: drivers/gpu/drm/i915/i915_debugfs.c:4961:17: warning: address of array 'intel_dp->dsc_dpcd' will always evaluate to 'true' [-Wpointer-bool-conversion] if

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/edid: Pass connector to AVI infoframe functions

2019-01-08 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/edid: Pass connector to AVI infoframe functions URL : https://patchwork.freedesktop.org/series/54903/ State : warning == Summary == $ dim checkpatch origin/drm-tip fc4e6824a03c drm/edid: Pass connector to AVI infoframe functions

Re: [Intel-gfx] [PATCH v4 02/16] drm/dp_mst: Introduce new refcounting scheme for mstbs and ports

2019-01-08 Thread Wentland, Harry
On 2019-01-04 7:14 p.m., Lyude Paul wrote: > The current way of handling refcounting in the DP MST helpers is really > confusing and probably just plain wrong because it's been hacked up many > times over the years without anyone actually going over the code and > seeing if things could be

[Intel-gfx] ✓ Fi.CI.BAT: success for Per context dynamic (sub)slice power-gating (rev12)

2019-01-08 Thread Patchwork
== Series Details == Series: Per context dynamic (sub)slice power-gating (rev12) URL : https://patchwork.freedesktop.org/series/48194/ State : success == Summary == CI Bug Log - changes from CI_DRM_5379 -> Patchwork_11256 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Per context dynamic (sub)slice power-gating (rev12)

2019-01-08 Thread Patchwork
== Series Details == Series: Per context dynamic (sub)slice power-gating (rev12) URL : https://patchwork.freedesktop.org/series/48194/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/execlists: Move RPCS setup to context pin Okay! Commit:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Per context dynamic (sub)slice power-gating (rev12)

2019-01-08 Thread Patchwork
== Series Details == Series: Per context dynamic (sub)slice power-gating (rev12) URL : https://patchwork.freedesktop.org/series/48194/ State : warning == Summary == $ dim checkpatch origin/drm-tip c919f2ba4d24 drm/i915/execlists: Move RPCS setup to context pin 65954284c0af drm/i915: Record

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915/backlight: Restore backlight on resume, v3.

2019-01-08 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/backlight: Restore backlight on resume, v3. URL : https://patchwork.freedesktop.org/series/54896/ State : success == Summary == CI Bug Log - changes from CI_DRM_5378 -> Patchwork_11255

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/5] drm/i915/backlight: Restore backlight on resume, v3.

2019-01-08 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/backlight: Restore backlight on resume, v3. URL : https://patchwork.freedesktop.org/series/54896/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/backlight: Restore backlight on

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915/backlight: Restore backlight on resume, v3.

2019-01-08 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/backlight: Restore backlight on resume, v3. URL : https://patchwork.freedesktop.org/series/54896/ State : warning == Summary == $ dim checkpatch origin/drm-tip 166eabf8e961 drm/i915/backlight: Restore backlight on resume, v3.

Re: [Intel-gfx] [PATCH v6 3/4] ACPI / PMIC: Add generic intel_soc_pmic_exec_mipi_pmic_seq_element handling

2019-01-08 Thread Andy Shevchenko
On Tue, Jan 08, 2019 at 04:35:45PM +0100, Hans de Goede wrote: > Hi, > > On 08-01-19 15:51, Andy Shevchenko wrote: > > On Tue, Jan 08, 2019 at 02:45:39PM +0100, Hans de Goede wrote: > > > On 07-01-19 16:46, Andy Shevchenko wrote: > > > > On Mon, Jan 07, 2019 at 12:15:55PM +0100, Hans de Goede

Re: [Intel-gfx] [PATCH v2] drm/i915: Downgrade scare message for unknown HuC firmware

2019-01-08 Thread kbuild test robot
Hi Chris, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v5.0-rc1 next-20190108] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

[Intel-gfx] [PATCH 3/4] drm/radeon: Use drm_hdmi_avi_infoframe_quant_range()

2019-01-08 Thread Ville Syrjala
From: Ville Syrjälä Fill out the AVI infoframe quantization range bits using drm_hdmi_avi_infoframe_quant_range() instead of hand rolling it. This changes the behaviour slightly as drm_hdmi_avi_infoframe_quant_range() will set a non-zero Q bit even when QS==0 iff the Q bit matched the default

[Intel-gfx] [PATCH 4/4] drm/edid: Add display_info.rgb_quant_range_selectable

2019-01-08 Thread Ville Syrjala
From: Ville Syrjälä Move the CEA-861 QS bit handling entirely into the edid code. No need to bother the drivers with this. Cc: Alex Deucher Cc: "Christian König" Cc: "David (ChunMing) Zhou" Cc: amd-...@lists.freedesktop.org Cc: Eric Anholt (supporter:DRM DRIVERS FOR VC4) Signed-off-by:

[Intel-gfx] [PATCH 2/4] drm/i915: Use drm_hdmi_avi_infoframe_quant_range() for SDVO HDMI as well

2019-01-08 Thread Ville Syrjala
From: Ville Syrjälä Fill out the AVI infoframe quantization range bits using drm_hdmi_avi_infoframe_quant_range() for SDVO HDMI encoder as well. This changes the behaviour slightly as drm_hdmi_avi_infoframe_quant_range() will set a non-zero Q bit even when QS==0 iff the Q bit matched the

[Intel-gfx] [PATCH 1/4] drm/edid: Pass connector to AVI infoframe functions

2019-01-08 Thread Ville Syrjala
From: Ville Syrjälä Make life easier for drivers by simply passing the connector to drm_hdmi_avi_infoframe_from_display_mode() and drm_hdmi_avi_infoframe_quant_range(). That way drivers don't need to worry about is_hdmi2_sink mess. v2: Make is_hdmi2_sink() return true for sil-sii8620 Adapt

Re: [Intel-gfx] [PATCH] drm/i915: drop all drmP.h includes

2019-01-08 Thread Sam Ravnborg
Hi Jani. Nice cleanup. On Tue, Jan 08, 2019 at 10:27:09AM +0200, Jani Nikula wrote: > Needs just a few additional includes here and there. > > Cc: Sam Ravnborg > Cc: Daniel Vetter > Cc: Laurent Pinchart > Acked-by: Daniel Vetter > Signed-off-by: Jani Nikula Acked-by: Sam Ravnborg

Re: [Intel-gfx] [PATCH 04/46] drm/i915: Markup paired operations on wakerefs

2019-01-08 Thread Chris Wilson
Quoting Mika Kuoppala (2019-01-08 16:23:18) > > @@ -3965,7 +4014,7 @@ void intel_power_domains_init_hw(struct > > drm_i915_private *dev_priv, bool resume) > > void intel_power_domains_fini_hw(struct drm_i915_private *dev_priv) > > { > > /* Keep the power well enabled, but cancel its rpm

[Intel-gfx] [PATCH v24 5/6] drm/i915: Expose RPCS (SSEU) configuration to userspace (Gen11 only)

2019-01-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We want to allow userspace to reconfigure the subslice configuration on a per context basis. This is required for the functional requirement of shutting down non-VME enabled sub-slices on Gen11 parts. To do so, we expose a context parameter to allow adjustment of the RPCS

Re: [Intel-gfx] [PATCH 04/46] drm/i915: Markup paired operations on wakerefs

2019-01-08 Thread Mika Kuoppala
Chris Wilson writes: > The majority of runtime-pm operations are bounded and scoped within a > function; these are easy to verify that the wakeref are handled > correctly. We can employ the compiler to help us, and reduce the number > of wakerefs tracked when debugging, by passing around cookies

Re: [Intel-gfx] [PATCH v2] drm/i915: Downgrade scare message for unknown HuC firmware

2019-01-08 Thread kbuild test robot
Hi Chris, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v5.0-rc1 next-20190108] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

[Intel-gfx] ✓ Fi.CI.BAT: success for Per context dynamic (sub)slice power-gating (rev11)

2019-01-08 Thread Patchwork
== Series Details == Series: Per context dynamic (sub)slice power-gating (rev11) URL : https://patchwork.freedesktop.org/series/48194/ State : success == Summary == CI Bug Log - changes from CI_DRM_5378 -> Patchwork_11254 Summary ---

[Intel-gfx] [PATCH 5/5] drm/i915: Re-enable fastset by default

2019-01-08 Thread Maarten Lankhorst
Now that we've solved the backlight issue, I think it's time to enable this again by default. We've enabled it in the past, but backlight issues prevented us from enabling it by default. Our hardware readout is pretty complete, and with all of the connector state moved to atomic I'm hoping we

[Intel-gfx] [PATCH 2/5] drm/i915/backlight: Fix backlight takeover on LPT, v3.

2019-01-08 Thread Maarten Lankhorst
On lynxpoint the bios sometimes sets up the backlight using the CPU display, but the driver expects using the PWM PCH override register. Read the value from the CPU register, then convert it to the other units by converting from the old duty cycle, to freq, to the new units. This value is then

[Intel-gfx] [PATCH 3/5] drm/i915: Enable fastset for non-boot modesets.

2019-01-08 Thread Maarten Lankhorst
Now that our state comparison functions are pretty complete, we should enable fastset by default when a modeset can be avoided. Even if we're not completely certain about the inherited state, we can be certain after the first modeset that our sw state matches the hw state. There is one testcase

[Intel-gfx] [PATCH 4/5] drm/i915: Make HW readout mark CRTC scaler as in use.

2019-01-08 Thread Maarten Lankhorst
This way we don't accidentally double allocate it. Noticed this when I wrote a patch to sanity check all of the scaler state. Signed-off-by: Maarten Lankhorst Reviewed-by: Hans de Goede --- drivers/gpu/drm/i915/intel_display.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Intel-gfx] [PATCH 1/5] drm/i915/backlight: Restore backlight on resume, v3.

2019-01-08 Thread Maarten Lankhorst
Restore our saved values for backlight. This way even with fastset on S4 resume we will correctly restore the backlight to the active values. Changes since v1: - Call enable_backlight() when backlight.level is set. On suspend backlight.enabled is always cleared, this makes it not a good

Re: [Intel-gfx] [PATCH] drm/i915/icl: Apply WaEnablePreemptionGranularityControlByUMD

2019-01-08 Thread Joonas Lahtinen
+ Ken/Jason for Mesa Quoting Matt Roper (2019-01-07 21:19:31) > On Mon, Jan 07, 2019 at 01:23:50PM +0100, Michał Winiarski wrote: > > On Mon, Jan 07, 2019 at 01:01:16PM +0200, Joonas Lahtinen wrote: > > > Quoting José Roberto de Souza (2019-01-04 19:37:00) > > > > According to Workaround database

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Per context dynamic (sub)slice power-gating (rev11)

2019-01-08 Thread Patchwork
== Series Details == Series: Per context dynamic (sub)slice power-gating (rev11) URL : https://patchwork.freedesktop.org/series/48194/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/execlists: Move RPCS setup to context pin Okay! Commit:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Per context dynamic (sub)slice power-gating (rev11)

2019-01-08 Thread Patchwork
== Series Details == Series: Per context dynamic (sub)slice power-gating (rev11) URL : https://patchwork.freedesktop.org/series/48194/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3350b5e6ed18 drm/i915/execlists: Move RPCS setup to context pin 961bc57575da drm/i915: Record

Re: [Intel-gfx] [PATCH v6 3/4] ACPI / PMIC: Add generic intel_soc_pmic_exec_mipi_pmic_seq_element handling

2019-01-08 Thread Hans de Goede
Hi, On 08-01-19 15:51, Andy Shevchenko wrote: On Tue, Jan 08, 2019 at 02:45:39PM +0100, Hans de Goede wrote: On 07-01-19 16:46, Andy Shevchenko wrote: On Mon, Jan 07, 2019 at 12:15:55PM +0100, Hans de Goede wrote: + } else if (d->pmic_i2c_address) { + if (i2c_address ==

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Downgrade scare message for unknwown HuC firmware (rev4)

2019-01-08 Thread Patchwork
== Series Details == Series: drm/i915: Downgrade scare message for unknwown HuC firmware (rev4) URL : https://patchwork.freedesktop.org/series/54868/ State : success == Summary == CI Bug Log - changes from CI_DRM_5378 -> Patchwork_11253

[Intel-gfx] [PATCH 5/6] drm/i915: Expose RPCS (SSEU) configuration to userspace (Gen11 only)

2019-01-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We want to allow userspace to reconfigure the subslice configuration on a per context basis. This is required for the functional requirement of shutting down non-VME enabled sub-slices on Gen11 parts. To do so, we expose a context parameter to allow adjustment of the RPCS

[Intel-gfx] [PATCH i-g-t 4/4] tests/gem_media_vme: Shut down half of subslices to avoid gpu hang on ICL

2019-01-08 Thread Tvrtko Ursulin
From: Tony Ye On Icelake we need to turn off subslices not containing the VME block or the VME kernel will hang. v2: (Tvrtko Ursulin) * Remove libdrm usage for setting context param. * Cleanup bitmask operation. * Only apply the workaround for ICL. v3: (Tvrtko Ursulin) * Added hang

[Intel-gfx] [PATCH 2/6] drm/i915: Record the sseu configuration per-context & engine

2019-01-08 Thread Tvrtko Ursulin
From: Lionel Landwerlin We want to expose the ability to reconfigure the slices, subslice and eu per context and per engine. To facilitate that, store the current configuration on the context for each engine, which is initially set to the device default upon creation. v2: record sseu

[Intel-gfx] [PATCH 4/6] drm/i915: Add timeline barrier support

2019-01-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Timeline barrier allows serialization between different timelines. After calling i915_timeline_set_barrier with a request, all following submissions on this timeline will be set up as depending on this request, or barrier. Once the barrier has been completed it

[Intel-gfx] [PATCH i-g-t 2/4] tests/gem_ctx_sseu: Dynamic (sub)slice programming tests

2019-01-08 Thread Tvrtko Ursulin
From: Lionel Landwerlin Verify that the per-context dynamic SSEU uAPI works as expected. v2: Add subslice tests (Lionel) Use MI_SET_PREDICATE for further verification when available (Lionel) v3: Rename to gem_ctx_rpcs (Lionel) v4: Update kernel API (Lionel) Add 0 value test (Lionel)

[Intel-gfx] [PATCH i-g-t 1/4] headers: bump

2019-01-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Sync with latest drm headers from drm-tip. Acked-by: Chris Wilson --- include/drm-uapi/drm_fourcc.h | 2 +- include/drm-uapi/drm_mode.h | 19 include/drm-uapi/i915_drm.h | 43 +++ include/drm-uapi/msm_drm.h| 25

[Intel-gfx] [PATCH 6/6] drm/i915/selftests: Context SSEU reconfiguration tests

2019-01-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Exercise the context image reconfiguration logic for idle and busy contexts, with the resets thrown into the mix as well. Free from the uAPI restrictions this test runs on all Gen9+ platforms with slice power gating. v2: * Rename some helpers for clarity. * Include

[Intel-gfx] [PATCH i-g-t 0/4] Per context dynamic (sub)slice power-gating

2019-01-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin New in this version: * Final tweaks based on review feedback. Lionel Landwerlin (1): tests/gem_ctx_sseu: Dynamic (sub)slice programming tests Tony Ye (2): tests/gem_media_vme: Simple test to exercise the VME block tests/gem_media_vme: Shut down half of subslices to

[Intel-gfx] [PATCH i-g-t 3/4] tests/gem_media_vme: Simple test to exercise the VME block

2019-01-08 Thread Tvrtko Ursulin
From: Tony Ye Simple test which exercises the VME fixed function block. v2: (Tvrtko Ursulin) * Small cleanups like copyright date, tabs, remove unused bits. v3: (Tony Ye) * Added curbe data entry for dst surface. * Read the dst surface after the VME kernel being executed. v4: (Tony Ye) *

[Intel-gfx] [PATCH 1/6] drm/i915/execlists: Move RPCS setup to context pin

2019-01-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Configuring RPCS in context image just before pin is sufficient and will come extra handy in one of the following patches. v2: * Split image setup a bit differently. (Chris Wilson) v3: * Update context image after reset as well - otherwise the application of pinned

[Intel-gfx] [PATCH 0/6] Per context dynamic (sub)slice power-gating

2019-01-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Changes since last version: * Squashed OA interaction patches into a single patch. * Small tidy in selftest. Lionel Landwerlin (2): drm/i915: Record the sseu configuration per-context & engine drm/i915/perf: lock powergating configuration to default when active

[Intel-gfx] [PATCH 3/6] drm/i915/perf: lock powergating configuration to default when active

2019-01-08 Thread Tvrtko Ursulin
From: Lionel Landwerlin If some of the contexts submitting workloads to the GPU have been configured to shutdown slices/subslices, we might loose the NOA configurations written in the NOA muxes. One possible solution to this problem is to reprogram the NOA muxes when we switch to a new context.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Downgrade scare message for unknwown HuC firmware (rev4)

2019-01-08 Thread Patchwork
== Series Details == Series: drm/i915: Downgrade scare message for unknwown HuC firmware (rev4) URL : https://patchwork.freedesktop.org/series/54868/ State : warning == Summary == $ dim checkpatch origin/drm-tip 010a74bc116c drm/i915: Downgrade scare message for unknown HuC firmware -:10:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gvt: give the cmd parser decode_info a const treatment

2019-01-08 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gvt: give the cmd parser decode_info a const treatment URL : https://patchwork.freedesktop.org/series/54884/ State : success == Summary == CI Bug Log - changes from CI_DRM_5378 -> Patchwork_11252

[Intel-gfx] [PATCH v4] drm/i915: Downgrade scare message for unknown HuC firmware

2019-01-08 Thread Chris Wilson
If we haven't shipped and enabled firmware for a particular platform, there is nothing the user can do about it. Don't scare the user with an unactionable, unidentifiable warning! <6> [310.769452] i915 :00:02.0: GuC: No firmware known for this platform! <4> [310.769458] [drm] HuC: No firmware

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Downgrade scare message for unknwown HuC firmware

2019-01-08 Thread Patchwork
== Series Details == Series: drm/i915: Downgrade scare message for unknwown HuC firmware URL : https://patchwork.freedesktop.org/series/54868/ State : success == Summary == CI Bug Log - changes from CI_DRM_5374_full -> Patchwork_11209_full

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Expose RPCS (SSEU) configuration to userspace (Gen11 only)

2019-01-08 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-01-08 14:35:45) > > On 08/01/2019 14:22, Joonas Lahtinen wrote: > > Quoting Tvrtko Ursulin (2019-01-08 13:22:50) > >> +++ b/include/uapi/drm/i915_drm.h > >> @@ -1486,9 +1486,52 @@ struct drm_i915_gem_context_param { > >> #define I915_CONTEXT_MAX_USER_PRIORITY

Re: [Intel-gfx] [PATCH i-g-t 3/4] tests/gem_media_vme: Simple test to exercise the VME block

2019-01-08 Thread Joonas Lahtinen
Quoting Tvrtko Ursulin (2019-01-08 13:24:49) > From: Tony Ye > > Simple test which exercises the VME fixed function block. > > v2: (Tvrtko Ursulin) > * Small cleanups like copyright date, tabs, remove unused bits. > > v3: (Tony Ye) > * Added curbe data entry for dst surface. > * Read the

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 4/4] tests/gem_media_vme: Shut down half of subslices to avoid gpu hang on ICL

2019-01-08 Thread Joonas Lahtinen
Quoting Tvrtko Ursulin (2019-01-08 13:24:50) > From: Tony Ye > > On Icelake we need to turn off subslices not containing the VME block or > the VME kernel will hang. > > v2: (Tvrtko Ursulin) > * Remove libdrm usage for setting context param. > * Cleanup bitmask operation. > * Only apply the

  1   2   >