Re: [Intel-gfx] [PATCH v2] drm/i915: Bump ready tasks ahead of busywaits

On 09/04/2019 16:29, Chris Wilson wrote: Consider two tasks that are running in parallel on a pair of engines (vcs0, vcs1), but then must complete on a shared engine (rcs0). To maximise throughput, we want to run the first ready task on rcs0 (i.e. the first task that completes on either of vcs0

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Update HDMI max TMDS data rate definition for VBT

== Series Details == Series: drm/i915: Update HDMI max TMDS data rate definition for VBT URL : https://patchwork.freedesktop.org/series/59220/ State : success == Summary == CI Bug Log - changes from CI_DRM_5895_full -> Patchwork_12736_full

[Intel-gfx] [PATCH v2] drm/i915: Bump ready tasks ahead of busywaits

Consider two tasks that are running in parallel on a pair of engines (vcs0, vcs1), but then must complete on a shared engine (rcs0). To maximise throughput, we want to run the first ready task on rcs0 (i.e. the first task that completes on either of vcs0 or vcs1). When using semaphores, however, we

Re: [Intel-gfx] colorkey support for intel i915 gpu driver

On Tue, Apr 09, 2019 at 02:24:03PM +, Jim Zhang wrote: > What about if I disable interrupt when changing the colorkey? This will > solve the atomic issue. I think we only change colorkey or enable/disable > colorkey once a while. If disabling interrupt work, I will disable interrupt > and

[Intel-gfx] [PATCH 1/7] drm/i915/sdvo: Fix AVI infoframe TX rate readout

From: Ville Syrjälä The AVI infoframe readout code currently issues a SDVO_CMD_GET_HBUF_TXRATE before SDVO_CMD_SET_HBUF_INDEX, which is not the correct order for these two operations. So far this wasn't a problem since we left the index pointing at the AVI infoframe buffer at the end of the modes

[Intel-gfx] [PATCH 6/7] drm/i915/sdvo: Don't write stack garbage into the hbuf

From: Ville Syrjälä Pass the length returned by hdmi_infoframe_pack_only() to intel_sdvo_write_infoframe() so that we don't end up writing stack garbage into the hbuf. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_sdvo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Intel-gfx] [PATCH 3/7] drm/i915: Rename SDVO_AUDIO_ENABLE to HDMI_AUDIO_ENABLE

From: Ville Syrjälä The "audio enable" bit on the SDVO/HDMI control register is only meant for HDMI. Audio is never delivered over the SDVO bus. Rename the define to reflect this fact. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_reg.h | 2 +- drivers/gpu/drm/i915/intel_hdmi.c

[Intel-gfx] [PATCH 0/7] drm/i915: Fix SDVO HDMI audio

From: Ville Syrjälä Here's a series to fix SDVO HDMI audio handling which got broken quite a while ago. I also tossed in a few extra cleanups. Ville Syrjälä (7): drm/i915/sdvo: Fix AVI infoframe TX rate readout drm/i915/sdvo: Implement proper HDMI audio support for SDVO drm/i915: Rename SD

[Intel-gfx] [PATCH 5/7] drm/i915/sdvo: Don't unpack stack garbage

From: Ville Syrjälä Pass the length returned by intel_sdvo_read_infoframe() to hdmi_infoframe_unpack() so that we don't try to unpack any leftover stack garbage. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_sdvo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH 4/7] drm/i915/sdvo: Check that we have space for the infoframe

From: Ville Syrjälä Before we go writing the infoframe let's make sure we have the space for it. Not that it really matters since the write loop would just terminate early in that case. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_sdvo.c | 3 +++ 1 file changed, 3 insertions(+)

[Intel-gfx] [PATCH 2/7] drm/i915/sdvo: Implement proper HDMI audio support for SDVO

From: Ville Syrjälä Our SDVO audio support is pretty bogus. We can't push audio over the SDVO bus, so trying to enable audio in the SDVO control register doesn't do anything. In fact it looks like the SDVO encoder will always mix in the audio coming over HDA, and there's no (at least documented)

[Intel-gfx] [PATCH 7/7] drm/i915/sdvo: Actually print the reason why the SDVO command failed

From: Ville Syrjälä It's much easier to figure out why the SDVO encoder refuses to cooperate if we can see what status we got back. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_sdvo.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i

[Intel-gfx] [PATCH] drm/i915: Bump ready tasks ahead of busywaits

Consider two tasks that are running in parallel on a pair of engines (vcs0, vcs1), but then must complete on a shared engine (rcs0). To maximise throughput, we want to run the first ready task on rcs0 (i.e. the first task that completes on either of vcs0 or vcs1). When using semaphores, however, we

Re: [Intel-gfx] colorkey support for intel i915 gpu driver

On Tue, Apr 09, 2019 at 02:14:49PM +, Jim Zhang wrote: > Once I pre-configure the colorkey, am I able to enable and disable it? If > colorkey can be enabled/disabled after that might meet my requirement Not atomically with other updates. > > Thanks, > > Jim > > > Caterpillar: Confidentia

Re: [Intel-gfx] colorkey support for intel i915 gpu driver

On Tue, Apr 09, 2019 at 01:59:21PM +, Jim Zhang wrote: > Nice, do you have any sample code for it? https://cgit.freedesktop.org/xorg/driver/xf86-video-intel/tree/src/sna/sna_video_sprite.c is the only userspace code we have that uses the colorkey. > > Thanks, > > Jim > > > Caterpillar: Co

Re: [Intel-gfx] colorkey support for intel i915 gpu driver

On Tue, Apr 09, 2019 at 04:46:24PM +0300, Ville Syrjälä wrote: > On Tue, Apr 09, 2019 at 01:29:41PM +, Jim Zhang wrote: > > Villie: > > > > What is Intel's plan for the colorkey patch? Does Intel have any plan to > > review and release? > > There is no real plan at this time. But if you ha

[Intel-gfx] [PATCH i-g-t] i915/gem_exec_schedule: Trick semaphores into a GPU hang

If we have two tasks running on xcs0 and xcs1 independently, but who queue subsequent work onto rcs, we may insert semaphores before the rcs work and pick unwisely which task to run first. To maximise throughput, we want to run on rcs whichever task is ready first. Conversely, if we pick wrongly th

Re: [Intel-gfx] colorkey support for intel i915 gpu driver

On Tue, Apr 09, 2019 at 01:29:41PM +, Jim Zhang wrote: > Villie: > > What is Intel's plan for the colorkey patch? Does Intel have any plan to > review and release? There is no real plan at this time. But if you have a use case for it I can try to harass people until someone reviews it :)

[Intel-gfx] [PATCH 10/11] [v2] drm/i915: Enable intel_get_color_config()

Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/intel_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 7ecfb7d..3282bc7 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i

[Intel-gfx] [PATCH 08/11] [v2] drm/i915: Extract ivb_get_color_config()

Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/intel_color.c | 50 -- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c index e18388e..0352ca5 100644 --- a/drivers/gpu/d

[Intel-gfx] [PATCH 04/11] [v2] drm/i915: Extract i965_get_color_config()

Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/i915_reg.h| 3 +++ drivers/gpu/drm/i915/intel_color.c | 39 ++ 2 files changed, 42 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 6e1fe5e..415b90d 100

[Intel-gfx] [PATCH 11/11] [v2] drm/i915: Add intel_compare_color_lut() to compare hw and sw gamma lut values

Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/intel_color.c | 49 drivers/gpu/drm/i915/intel_display.c | 10 drivers/gpu/drm/i915/intel_drv.h | 3 +++ 3 files changed, 62 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_color.c b/

[Intel-gfx] [PATCH 07/11] [v2] drm/i915: Extract bdw_get_color_config()

Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/intel_color.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c index e398a60..e18388e 100644 --- a/drivers/gpu/drm/i915/intel_color.c

[Intel-gfx] [PATCH 09/11] [v2] drm/i915: Extract ilk_get_color_config()

Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/i915_reg.h| 3 +++ drivers/gpu/drm/i915/intel_color.c | 42 -- 2 files changed, 43 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index c424

[Intel-gfx] [PATCH 02/11] [v2] drm/i915: Extract i9xx_get_color_config()

Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/i915_reg.h| 3 +++ drivers/gpu/drm/i915/intel_color.c | 51 ++ 2 files changed, 54 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 00e0356..c86cbc1 100

[Intel-gfx] [PATCH 01/11] [v2] drm/i915: Introduce vfunc intel_get_color_config to create hw lut

Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/i915_drv.h| 1 + drivers/gpu/drm/i915/intel_color.c | 7 +++ drivers/gpu/drm/i915/intel_drv.h | 1 + 3 files changed, 9 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 4af815c..861db

[Intel-gfx] [PATCH 03/11] [v2] drm/i915: Extract cherryview_get_color_config()

Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/i915_reg.h| 3 +++ drivers/gpu/drm/i915/intel_color.c | 39 ++ 2 files changed, 42 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index c86cbc1..6e1fe5e 100

[Intel-gfx] [PATCH 05/11] [v2] drm/i915: Extract icl_get_color_config()

Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/i915_reg.h| 3 +++ drivers/gpu/drm/i915/intel_color.c | 49 +- 2 files changed, 51 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 415b9

[Intel-gfx] [PATCH 06/11] [v2] drm/i915: Extract glk_get_color_config()

Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/intel_color.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c index 0fdbae3..e398a60 100644 --- a/drivers/gpu/drm/i915/intel_color.c +++

[Intel-gfx] [PATCH 00/11] drm/i915: adding state checker for gamma lut values

Thanks to Jani N, Matt and Ville for the review comments. Hopefully I have addressed all the current review comments and ready to receive more :) In this patch series, added state checker to validate gamma_lut values. This reads hardware state, and compares the originally requested state to the st

[Intel-gfx] [PATCH 09/11] [v2] drm/i915: Extract ilk_get_color_config()

Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/i915_reg.h| 3 +++ drivers/gpu/drm/i915/intel_color.c | 42 -- 2 files changed, 43 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index c424

[Intel-gfx] [PATCH 08/11] [v2] drm/i915: Extract ivb_get_color_config()

Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/intel_color.c | 50 -- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c index e18388e..0352ca5 100644 --- a/drivers/gpu/d

[Intel-gfx] [PATCH 06/11] [v2] drm/i915: Extract glk_get_color_config()

Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/intel_color.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c index 0fdbae3..e398a60 100644 --- a/drivers/gpu/drm/i915/intel_color.c +++

[Intel-gfx] [PATCH 10/11] [v2] drm/i915: Enable intel_get_color_config()

Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/intel_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 7ecfb7d..3282bc7 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i

[Intel-gfx] [PATCH 11/11] [v2] drm/i915: Add intel_compare_color_lut() to compare hw and sw gamma lut values

Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/intel_color.c | 49 drivers/gpu/drm/i915/intel_display.c | 10 drivers/gpu/drm/i915/intel_drv.h | 3 +++ 3 files changed, 62 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_color.c b/

[Intel-gfx] [PATCH 07/11] [v2] drm/i915: Extract bdw_get_color_config()

Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/intel_color.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c index e398a60..e18388e 100644 --- a/drivers/gpu/drm/i915/intel_color.c

[Intel-gfx] [PATCH 02/11] [v2] drm/i915: Extract i9xx_get_color_config()

Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/i915_reg.h| 3 +++ drivers/gpu/drm/i915/intel_color.c | 51 ++ 2 files changed, 54 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 00e0356..c86cbc1 100

[Intel-gfx] [PATCH 03/11] [v2] drm/i915: Extract cherryview_get_color_config()

Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/i915_reg.h| 3 +++ drivers/gpu/drm/i915/intel_color.c | 39 ++ 2 files changed, 42 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index c86cbc1..6e1fe5e 100

[Intel-gfx] [PATCH 04/11] [v2] drm/i915: Extract i965_get_color_config()

Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/i915_reg.h| 3 +++ drivers/gpu/drm/i915/intel_color.c | 39 ++ 2 files changed, 42 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 6e1fe5e..415b90d 100

[Intel-gfx] [PATCH 05/11] [v2] drm/i915: Extract icl_get_color_config()

Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/i915_reg.h| 3 +++ drivers/gpu/drm/i915/intel_color.c | 49 +- 2 files changed, 51 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 415b9

[Intel-gfx] [PATCH 01/11] [v2] drm/i915: Introduce vfunc intel_get_color_config to create hw lut

Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/i915_drv.h| 1 + drivers/gpu/drm/i915/intel_color.c | 7 +++ drivers/gpu/drm/i915/intel_drv.h | 1 + 3 files changed, 9 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 4af815c..861db

[Intel-gfx] [PATCH 00/11] adding state checker for gamma lut values

Thanks to Jani N, Matt and Ville for the review comments. Hopefully I have addressed all the current review comments and ready to receive more :) In this patch series, added state checker to validate gamma_lut values. This reads hardware state, and compares the originally requested state to the st

Re: [Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT

On Tue, Apr 09, 2019 at 06:07:08PM +0800, Chiou, Cooper wrote: > VBT version 212 defined HDMI max. bit-rate 2.97Gbps is 0x02 and 1.65Gbps > is 0x04, so changed HDMI_MAX_DATA_RATE_297/HDMI_MAX_DATA_RATE_165 to map > correct values Eh what? Did someone just change the interpretation of these bits?

Re: [Intel-gfx] [PATCH libdrm] headers: Sync with drm-next

On Tuesday, 2019-04-09 12:59:13 +0100, Eric Engestrom wrote: > On Tuesday, 2019-04-09 11:35:14 +, Ayan Halder wrote: > > Generated using make headers_install from the drm-next > > tree - git://anongit.freedesktop.org/drm/drm > > branch - drm-next > > commit - 14d2bd53a47a7e1cb3e03d00a6b952734cf

Re: [Intel-gfx] [PATCH libdrm] headers: Sync with drm-next

On Tuesday, 2019-04-09 11:35:14 +, Ayan Halder wrote: > Generated using make headers_install from the drm-next > tree - git://anongit.freedesktop.org/drm/drm > branch - drm-next > commit - 14d2bd53a47a7e1cb3e03d00a6b952734cf90f3f > > The changes were as follows :- > > core: (drm.h, drm_fourcc

[Intel-gfx] [PATCH libdrm] headers: Sync with drm-next

Generated using make headers_install from the drm-next tree - git://anongit.freedesktop.org/drm/drm branch - drm-next commit - 14d2bd53a47a7e1cb3e03d00a6b952734cf90f3f The changes were as follows :- core: (drm.h, drm_fourcc.h, drm_mode.h) - Added 'struct drm_syncobj_transfer', 'struct drm_syncobj

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Update HDMI max TMDS data rate definition for VBT

== Series Details == Series: drm/i915: Update HDMI max TMDS data rate definition for VBT URL : https://patchwork.freedesktop.org/series/59220/ State : success == Summary == CI Bug Log - changes from CI_DRM_5895 -> Patchwork_12736 Summary --

[Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT

VBT version 212 defined HDMI max. bit-rate 2.97Gbps is 0x02 and 1.65Gbps is 0x04, so changed HDMI_MAX_DATA_RATE_297/HDMI_MAX_DATA_RATE_165 to map correct values Per VBT BSpec definition in HDMI max. data rate, Bits7-5 is HDMI max. data rate 000=Default, 001=2.97Gbps, 010=1.65Gbps, so HDMI_MAX_DA

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

On Tue, Apr 09, 2019 at 06:08:55PM +1000, Stephen Rothwell wrote: > Hi Gerd, > > > >drm_fb_memcpy_dstclip(__io_virt(cirrus->vram), > > > ^ > > > __do_irq > > > > Probably just a missing arm/io.h include. > > I assume you meant asm/i

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

Hi Gerd, On Tue, 9 Apr 2019 09:22:18 +0200 Gerd Hoffmann wrote: > > On Tue, Apr 09, 2019 at 04:08:49PM +1000, Stephen Rothwell wrote: > > Hi all, > > > > After merging the drm-misc tree, today's linux-next build (powerpc > > allyesconfig) failed like this: > > > > drivers/gpu/drm/cirrus/cirrus.

[Intel-gfx] ✗ Fi.CI.BAT: failure for Core-for-CI:ICL_only Disable ACPI idle driver (rev2)

== Series Details == Series: Core-for-CI:ICL_only Disable ACPI idle driver (rev2) URL : https://patchwork.freedesktop.org/series/59170/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5892 -> Patchwork_12735 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for IRQ initialization debloat and conversion to uncore

== Series Details == Series: IRQ initialization debloat and conversion to uncore URL : https://patchwork.freedesktop.org/series/59202/ State : success == Summary == CI Bug Log - changes from CI_DRM_5891_full -> Patchwork_12734_full Summary

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with the drm tree

On Tue, Apr 09, 2019 at 11:34:10AM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the drm-misc tree got conflicts in: > > drivers/gpu/drm/cirrus/cirrus_drv.h > drivers/gpu/drm/cirrus/cirrus_ttm.c > > between commits: > > aa8e2435b3d4 ("drm/ttm: Define a single DR

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

On Tue, Apr 09, 2019 at 04:08:49PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the drm-misc tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/gpu/drm/cirrus/cirrus.c: In function 'cirrus_fb_blit_rect': > drivers/gpu/drm/cirrus/cirrus.c:310:25: er

<    1   2