[Intel-gfx] ✓ Fi.CI.BAT: success for GuC 32.0.3 (rev5)

2019-05-23 Thread Patchwork
== Series Details == Series: GuC 32.0.3 (rev5) URL : https://patchwork.freedesktop.org/series/58760/ State : success == Summary == CI Bug Log - changes from CI_DRM_6137 -> Patchwork_13086 Summary --- **SUCCESS** No regressions

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: We don't need display's suspend/resume operations when !HAS_DISPLAY (rev3)

2019-05-23 Thread Patchwork
== Series Details == Series: drm/i915: We don't need display's suspend/resume operations when !HAS_DISPLAY (rev3) URL : https://patchwork.freedesktop.org/series/60839/ State : success == Summary == CI Bug Log - changes from CI_DRM_6137 -> Patchwork_13085

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GuC 32.0.3 (rev5)

2019-05-23 Thread Patchwork
== Series Details == Series: GuC 32.0.3 (rev5) URL : https://patchwork.freedesktop.org/series/58760/ State : warning == Summary == $ dim checkpatch origin/drm-tip 492a32a18ce1 drm/i915/guc: Change platform default GuC mode e563e9032b70 drm/i915/guc: Don't allow GuC submission dab8c578708e

[Intel-gfx] [PATCH v4 21/22] drm/i915/huc: Define HuC firmware version for Icelake

2019-05-23 Thread Michal Wajdeczko
Define HuC firmware version for Icelake. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Joonas Lahtinen Cc: Anusha Srivatsa Cc: Tony Ye v2: 8.4.3238 is now available --- drivers/gpu/drm/i915/intel_huc_fw.c | 12 1 file changed, 12 insertions(+) diff --git

[Intel-gfx] [PATCH v4 09/22] drm/i915/guc: Reset GuC ADS during sanitize

2019-05-23 Thread Michal Wajdeczko
GuC stores some data in there, which might be stale after a reset. Reinitialize whole ADS in case any part of it was corrupted during previous GuC run. v2: s/reinit/init, update functions descriptions (Tomek/Michal) v3: reset ADS right before fw upload Signed-off-by: Michal Wajdeczko Cc:

[Intel-gfx] [PATCH v4 12/22] drm/i915/huc: Define HuC firmware version for Geminilake

2019-05-23 Thread Michal Wajdeczko
Define HuC firmware version for Geminilake. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Joonas Lahtinen Cc: Anusha Srivatsa Cc: Tony Ye --- drivers/gpu/drm/i915/intel_huc_fw.c | 12 1 file changed, 12 insertions(+) diff --git

[Intel-gfx] [PATCH v4 02/22] drm/i915/guc: Don't allow GuC submission

2019-05-23 Thread Michal Wajdeczko
Due to the upcoming changes to the GuC ABI interface, we must disable GuC submission mode until final ABI will be available on all GuC firmwares. To avoid regressions on systems configured to run with no longer supported configuration "enable_guc=3" or "enable_guc=1" clear GuC submission bit.

[Intel-gfx] [PATCH v4 17/22] drm/i915/guc: Correctly handle GuC interrupts on Gen11

2019-05-23 Thread Michal Wajdeczko
From: Oscar Mateo The GuC interrupts now get their own interrupt vector (instead of sharing a register with the PM interrupts) so handle appropriately. v2: (Chris) v3: rebased (Michal) Bspec: 19820 Signed-off-by: Oscar Mateo Signed-off-by: Michal Wajdeczko Cc: Tvrtko Ursulin Cc: Daniele

[Intel-gfx] [PATCH v4 18/22] drm/i915/guc: Update GuC CTB response definition

2019-05-23 Thread Michal Wajdeczko
Current GuC firmwares identify response message in a different way. v2: update comments for other H2G bits (Daniele) Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Kelvin Gardiner Cc: John Spotswood Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/intel_guc_ct.c

[Intel-gfx] [PATCH v4 10/22] drm/i915/guc: Always ask GuC to update power domain states

2019-05-23 Thread Michal Wajdeczko
With newer GuC firmware it is always ok to ask GuC to update power domain states. Make it an unconditional initialization step. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: John Spotswood Reviewed-by: Daniele Ceraolo Spurio Reviewed-by: John Spotswood ---

[Intel-gfx] [PATCH v4 06/22] drm/i915/guc: Update suspend/resume protocol

2019-05-23 Thread Michal Wajdeczko
New GuC firmwares use updated sleep status definitions. The polling on scratch register 14 is also now required only on suspend and there is no need to provide the shared page. v2: include changes for polling and shared page Signed-off-by: Michal Wajdeczko Signed-off-by: Daniele Ceraolo Spurio

[Intel-gfx] [PATCH v4 16/22] drm/i915/guc: Create vfuncs for the GuC interrupts control functions

2019-05-23 Thread Michal Wajdeczko
From: Oscar Mateo Controlling and handling of the GuC interrupts is Gen specific. Create virtual functions to avoid redundant runtime Gen checks. Gen-specific versions of these functions will follow. v2: move vfuncs to struct guc (Daniele) v3: rebased Signed-off-by: Oscar Mateo Signed-off-by:

[Intel-gfx] [PATCH v4 20/22] drm/i915/guc: Define GuC firmware version for Icelake

2019-05-23 Thread Michal Wajdeczko
Define GuC firmware version for Icelake. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Anusha Srivatsa Reviewed-by: Anusha Srivatsa --- drivers/gpu/drm/i915/intel_guc_fw.c | 11 +++ 1 file changed, 11 insertions(+) diff --git

[Intel-gfx] [PATCH v4 22/22] HAX: turn on GuC/HuC auto mode

2019-05-23 Thread Michal Wajdeczko
Signed-off-by: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_params.h | 2 +- drivers/gpu/drm/i915/intel_huc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index 3f14e9881a0d..e28ae23de516

[Intel-gfx] [PATCH v4 08/22] drm/i915/guc: Update GuC ADS object definition

2019-05-23 Thread Michal Wajdeczko
New GuC firmwares use updated definitions for the Additional Data Structures (ADS). v2: add note about Gen9 definition mismatch (Daniele) rename __intel_engine_context_size (Daniele) Signed-off-by: Michal Wajdeczko Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Fernando Pacheco Cc:

[Intel-gfx] [PATCH v4 15/22] drm/i915/huc: New HuC status register for Gen11

2019-05-23 Thread Michal Wajdeczko
Gen11 defines new register for checking HuC authentication status. Look into the right register and bit. v2: use reg/mask/value instead of dedicated functions (Daniele) BSpec: 19686 Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tony Ye Cc: Vinay Belgaumkar Cc:

[Intel-gfx] [PATCH v4 19/22] drm/i915/guc: Enable GuC CTB communication on Gen11

2019-05-23 Thread Michal Wajdeczko
Gen11 GuC firmware expects H2G command messages to be sent over CTB (command transport buffers). Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Joonas Lahtinen Cc: John Spotswood Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/i915_pci.c | 1 + 1 file changed, 1

[Intel-gfx] [PATCH v4 05/22] drm/i915/guc: Update GuC boot parameters

2019-05-23 Thread Michal Wajdeczko
New GuC firmwares require updated boot parameters. v2: rebased Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Tvrtko Ursulin Cc: Daniele Ceraolo Spurio Cc: John Spotswood Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/intel_guc.c | 38 +-

[Intel-gfx] [PATCH v4 13/22] drm/i915/guc: New GuC interrupt register for Gen11

2019-05-23 Thread Michal Wajdeczko
Gen11 defines new more flexible Host-to-GuC interrupt register. Now the host can write any 32-bit payload to trigger an interrupt and GuC can additionally read this payload from the register. Current GuC firmware ignores the payload so we just write 0. Bspec: 21043 Signed-off-by: Michal

[Intel-gfx] [PATCH v4 14/22] drm/i915/guc: New GuC scratch registers for Gen11

2019-05-23 Thread Michal Wajdeczko
Gen11 adds new set of scratch registers that can be used for MMIO based Host-to-Guc communication. Due to limited number of these registers it is expected that host will use them only for command transport buffers (CTB) communication setup if one is available. Bspec: 21044 Signed-off-by: Michal

[Intel-gfx] [PATCH v4 07/22] drm/i915/guc: Update GuC sample-forcewake command

2019-05-23 Thread Michal Wajdeczko
New GuC firmwares use different action code value for this command. Signed-off-by: Michal Wajdeczko Cc: John Spotswood Cc: Daniele Ceraolo Spurio Reviewed-by: Daniele Ceraolo Spurio Reviewed-by: John Spotswood --- drivers/gpu/drm/i915/intel_guc_fwif.h | 2 +- 1 file changed, 1 insertion(+),

[Intel-gfx] [PATCH v4 11/22] drm/i915/guc: Define GuC firmware version for Geminilake

2019-05-23 Thread Michal Wajdeczko
Define GuC firmware version for Geminilake. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Anusha Srivatsa --- drivers/gpu/drm/i915/intel_guc_fw.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_guc_fw.c

[Intel-gfx] [PATCH v4 04/22] drm/i915/guc: Update GuC firmware CSS header

2019-05-23 Thread Michal Wajdeczko
There are few minor changes in the CSS header related to the version numbering in new GuC firmwares. Update our definition and start using common tools for extracting bitfields. v2: drop deprecated prod_preprod_fw field, replace unions with bit defs Signed-off-by: Michal Wajdeczko Cc: Daniele

[Intel-gfx] [PATCH v4 03/22] drm/i915/guc: Update GuC firmware versions and names

2019-05-23 Thread Michal Wajdeczko
GuC firmware changed its release version numbering schema and now it also includes patch version. Update our GuC firmware path definitions to match new pattern: _guc_...bin While here, reorder platform checks and start from the latest. v2: keep single platform defs in one block (Daniele)

[Intel-gfx] [PATCH v4 00/22] GuC 32.0.3

2019-05-23 Thread Michal Wajdeczko
New GuC firmwares (for SKL, BXT, KBL, GLK, ICL) with updated ABI interface. Note: For correct bisecting, patches 3-8 can be squashed, as Gen9 GuC support will be broken during update of GuC firmware definitions. v2: only HuC authentication is supported v3: never allow to turn on GuC submission

[Intel-gfx] [PATCH v4 01/22] drm/i915/guc: Change platform default GuC mode

2019-05-23 Thread Michal Wajdeczko
Today our most desired GuC configuration is to only enable HuC if it is available and we really don't care about GuC submission. Change platform default GuC mode to match our desire. Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Rodrigo Vivi Cc: Daniele Ceraolo

Re: [Intel-gfx] [PATCH 07/10] drm/i915/dmc: add support to load dmc_header version 3

2019-05-23 Thread Rodrigo Vivi
On Thu, May 23, 2019 at 12:25:34PM -0700, Lucas De Marchi wrote: > On Thu, May 23, 2019 at 11:57:19AM -0700, Rodrigo Vivi wrote: > > On Thu, May 23, 2019 at 01:24:17AM -0700, Lucas De Marchi wrote: > > > Main difference is that now there are up to 20 MMIOs that can be set and > > > a lot of noise

[Intel-gfx] [PATCH] drm/i915: We don't need display's suspend/resume operations when !HAS_DISPLAY

2019-05-23 Thread Rodrigo Vivi
Suspend resume is broken if we try to enable/disable dc9 on cases with disabled displays. v2: Make checkpatch happy: - braces {} are not necessary for single statement blocks v3: Also move hsw/bdw PC8 sequences since they are related to display PM anyways. (Ville) Cc: Ville Syrjälä Cc:

Re: [Intel-gfx] [CI] drm/i915: We don't need display's suspend/resume operations when !HAS_DISPLAY

2019-05-23 Thread Rodrigo Vivi
On Thu, May 23, 2019 at 10:26:37PM +0300, Ville Syrjälä wrote: > On Thu, May 23, 2019 at 12:19:35PM -0700, Rodrigo Vivi wrote: > > Suspend resume is broken if we try to enable/disable dc9 on > > cases with disabled displays. > > > > v2: Make checkpatch happy: > > -:78: WARNING:BRACES: braces {}

Re: [Intel-gfx] [PATCH 1/1] drm/i915: remove unused IO_TLB_SEGPAGES which should be defined by swiotlb

2019-05-23 Thread Chris Wilson
Quoting Dongli Zhang (2019-05-21 05:40:39) > This patch removes IO_TLB_SEGPAGES which is no longer used since > commit 5584f1b1d73e ("drm/i915: fix i915 running as dom0 under Xen"). > > As the define of both IO_TLB_SEGSIZE and IO_TLB_SHIFT are from swiotlb, > IO_TLB_SEGPAGES should be defined on

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gen11: enable support for headerless msgs (rev4)

2019-05-23 Thread Dongwon Kim
Chris, This patch apparently passed the regression test. Can you please help this move forward to the merging process? On Tue, May 07, 2019 at 11:41:10PM -0700, Peres, Martin wrote: > On 06/05/2019 23:30, Kim, Dongwon wrote: > > This doesn't seem to be a valid failure. I just reran the test

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for GuC fixes (rev2)

2019-05-23 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-05-23 15:46:58) > On Wed, 22 May 2019 22:53:11 +0200, Patchwork > wrote: > > > == Series Details == > > > > Series: GuC fixes (rev2) > > URL : https://patchwork.freedesktop.org/series/60795/ > > State : failure > > > > == Summary == > > > > CI Bug Log - changes

Re: [Intel-gfx] [PATCH v2 8/9] drm/i915/uc: Stop talking with GuC when resetting

2019-05-23 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-05-23 18:25:55) > Knowing that GuC will be reset soon, we may stop all communication > immediately without doing graceful cleanup as it is not needed. > > This patch will also help us capture any unwanted/unexpected attempts > to talk with GuC after we decided to

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: We don't need display's suspend/resume operations when !HAS_DISPLAY (rev2)

2019-05-23 Thread Patchwork
== Series Details == Series: drm/i915: We don't need display's suspend/resume operations when !HAS_DISPLAY (rev2) URL : https://patchwork.freedesktop.org/series/60839/ State : success == Summary == CI Bug Log - changes from CI_DRM_6134 -> Patchwork_13084

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: We don't need display's suspend/resume operations when !HAS_DISPLAY (rev2)

2019-05-23 Thread Patchwork
== Series Details == Series: drm/i915: We don't need display's suspend/resume operations when !HAS_DISPLAY (rev2) URL : https://patchwork.freedesktop.org/series/60839/ State : warning == Summary == $ dim checkpatch origin/drm-tip b106ab9f272e drm/i915: We don't need display's suspend/resume

Re: [Intel-gfx] [PATCH 09/10] drm/i915/dmc: protect against reading random memory

2019-05-23 Thread Lucas De Marchi
On Thu, May 23, 2019 at 11:58:46AM -0700, Rodrigo Vivi wrote: On Thu, May 23, 2019 at 01:24:19AM -0700, Lucas De Marchi wrote: While loading the DMC firmware we were double checking the headers made sense, but in no place we checked that we were actually reading memory we were supposed to. This

Re: [Intel-gfx] [CI] drm/i915: We don't need display's suspend/resume operations when !HAS_DISPLAY

2019-05-23 Thread Ville Syrjälä
On Thu, May 23, 2019 at 12:19:35PM -0700, Rodrigo Vivi wrote: > Suspend resume is broken if we try to enable/disable dc9 on > cases with disabled displays. > > v2: Make checkpatch happy: > -:78: WARNING:BRACES: braces {} are not necessary for single statement blocks > > Cc: José Roberto de Souza

Re: [Intel-gfx] [PATCH 07/10] drm/i915/dmc: add support to load dmc_header version 3

2019-05-23 Thread Lucas De Marchi
On Thu, May 23, 2019 at 11:57:19AM -0700, Rodrigo Vivi wrote: On Thu, May 23, 2019 at 01:24:17AM -0700, Lucas De Marchi wrote: Main difference is that now there are up to 20 MMIOs that can be set and a lot of noise due to the struct changing the fields in the middle. Signed-off-by: Lucas De

[Intel-gfx] [CI] drm/i915: We don't need display's suspend/resume operations when !HAS_DISPLAY

2019-05-23 Thread Rodrigo Vivi
Suspend resume is broken if we try to enable/disable dc9 on cases with disabled displays. v2: Make checkpatch happy: -:78: WARNING:BRACES: braces {} are not necessary for single statement blocks Cc: José Roberto de Souza Signed-off-by: Rodrigo Vivi Reviewed-by: José Roberto de Souza ---

Re: [Intel-gfx] [PATCH 10/10] drm/i915/dmc: protect against loading wrong firmware

2019-05-23 Thread Rodrigo Vivi
On Thu, May 23, 2019 at 01:24:20AM -0700, Lucas De Marchi wrote: > In intel_package_header version 2 there's a new field in the > fw_info table that must be 0, otherwise it's not the correct DMC > firmware. Add a check for version 2 or later. > > Signed-off-by: Lucas De Marchi > --- >

Re: [Intel-gfx] [PATCH v6 2/8] drm/fb-helper: Remove drm_fb_helper_crtc

2019-05-23 Thread Noralf Trønnes
Den 23.05.2019 15.44, skrev Noralf Trønnes: > struct drm_fb_helper_crtc is now just a wrapper around drm_mode_set so > use that directly instead and attach it as a modeset array onto > drm_client_dev. drm_fb_helper will use this array to store its modesets > which means it will always initialize

Re: [Intel-gfx] [PATCH 09/10] drm/i915/dmc: protect against reading random memory

2019-05-23 Thread Rodrigo Vivi
On Thu, May 23, 2019 at 01:24:19AM -0700, Lucas De Marchi wrote: > While loading the DMC firmware we were double checking the headers made > sense, but in no place we checked that we were actually reading memory > we were supposed to. This could be wrong in case the firmware file is > truncated. >

Re: [Intel-gfx] [PATCH 07/10] drm/i915/dmc: add support to load dmc_header version 3

2019-05-23 Thread Rodrigo Vivi
On Thu, May 23, 2019 at 01:24:17AM -0700, Lucas De Marchi wrote: > Main difference is that now there are up to 20 MMIOs that can be set and > a lot of noise due to the struct changing the fields in the middle. > > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i915/i915_drv.h | 4 +-

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4,1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range

2019-05-23 Thread Patchwork
== Series Details == Series: series starting with [v4,1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range URL : https://patchwork.freedesktop.org/series/61055/ State : success == Summary == CI Bug Log - changes from CI_DRM_6133 -> Patchwork_13083

[Intel-gfx] ✗ Fi.CI.BAT: failure for GuC fixes (rev3)

2019-05-23 Thread Patchwork
== Series Details == Series: GuC fixes (rev3) URL : https://patchwork.freedesktop.org/series/60795/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6133 -> Patchwork_13082 Summary --- **FAILURE** Serious unknown

Re: [Intel-gfx] [PATCH 08/10] drm/i915/dmc: remove redundant return in parse_csr_fw()

2019-05-23 Thread Srivatsa, Anusha
>-Original Message- >From: De Marchi, Lucas >Sent: Thursday, May 23, 2019 1:24 AM >To: intel-gfx@lists.freedesktop.org >Cc: Jani Nikula ; Srivatsa, Anusha >; Vivi, Rodrigo ; De >Marchi, Lucas >Subject: [PATCH 08/10] drm/i915/dmc: remove redundant return in >parse_csr_fw() >

Re: [Intel-gfx] [PATCH 07/10] drm/i915/dmc: add support to load dmc_header version 3

2019-05-23 Thread Srivatsa, Anusha
>-Original Message- >From: De Marchi, Lucas >Sent: Thursday, May 23, 2019 1:24 AM >To: intel-gfx@lists.freedesktop.org >Cc: Jani Nikula ; Srivatsa, Anusha >; Vivi, Rodrigo ; De >Marchi, Lucas >Subject: [PATCH 07/10] drm/i915/dmc: add support to load dmc_header version 3 > >Main

Re: [Intel-gfx] [PATCH 06/10] drm/i915/dmc: extract function to parse dmc_header

2019-05-23 Thread Srivatsa, Anusha
>-Original Message- >From: De Marchi, Lucas >Sent: Thursday, May 23, 2019 1:24 AM >To: intel-gfx@lists.freedesktop.org >Cc: Jani Nikula ; Srivatsa, Anusha >; Vivi, Rodrigo ; De >Marchi, Lucas >Subject: [PATCH 06/10] drm/i915/dmc: extract function to parse dmc_header > >Complete the

Re: [Intel-gfx] [PATCH 05/10] drm/i915/dmc: extract function to parse package_header

2019-05-23 Thread Srivatsa, Anusha
>-Original Message- >From: De Marchi, Lucas >Sent: Thursday, May 23, 2019 1:24 AM >To: intel-gfx@lists.freedesktop.org >Cc: Jani Nikula ; Srivatsa, Anusha >; Vivi, Rodrigo ; De >Marchi, Lucas >Subject: [PATCH 05/10] drm/i915/dmc: extract function to parse package_header > >Like

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v4,1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range

2019-05-23 Thread Patchwork
== Series Details == Series: series starting with [v4,1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range URL : https://patchwork.freedesktop.org/series/61055/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/gtt: grab wakeref in

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v4,1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range

2019-05-23 Thread Patchwork
== Series Details == Series: series starting with [v4,1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range URL : https://patchwork.freedesktop.org/series/61055/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4508a23d94a4 drm/i915/gtt: grab wakeref in gen6_alloc_va_range

Re: [Intel-gfx] [PATCH 03/10] drm/i915/dmc: add support for package_header with version 2

2019-05-23 Thread Lucas De Marchi
On Thu, May 23, 2019 at 10:43:39AM -0700, Rodrigo Vivi wrote: On Thu, May 23, 2019 at 01:24:13AM -0700, Lucas De Marchi wrote: The only meaninful change is that it supports up to 32 fw_info entries rather than the previous max=20. Signed-off-by: Lucas De Marchi ---

Re: [Intel-gfx] [PATCH 04/10] drm/i915/dmc: extract function to parse css header

2019-05-23 Thread Srivatsa, Anusha
>-Original Message- >From: De Marchi, Lucas >Sent: Thursday, May 23, 2019 1:24 AM >To: intel-gfx@lists.freedesktop.org >Cc: Jani Nikula ; Srivatsa, Anusha >; Vivi, Rodrigo ; De >Marchi, Lucas >Subject: [PATCH 04/10] drm/i915/dmc: extract function to parse css header > >Let's start

Re: [Intel-gfx] [PATCH 03/10] drm/i915/dmc: add support for package_header with version 2

2019-05-23 Thread Srivatsa, Anusha
>-Original Message- >From: De Marchi, Lucas >Sent: Thursday, May 23, 2019 1:24 AM >To: intel-gfx@lists.freedesktop.org >Cc: Jani Nikula ; Srivatsa, Anusha >; Vivi, Rodrigo ; De >Marchi, Lucas >Subject: [PATCH 03/10] drm/i915/dmc: add support for package_header with >version 2 > >The

Re: [Intel-gfx] [PATCH 02/10] drm/i915/dmc: extract fw_info and table walk from intel_package_header

2019-05-23 Thread Srivatsa, Anusha
>-Original Message- >From: De Marchi, Lucas >Sent: Thursday, May 23, 2019 1:24 AM >To: intel-gfx@lists.freedesktop.org >Cc: Jani Nikula ; Srivatsa, Anusha >; Vivi, Rodrigo ; De >Marchi, Lucas >Subject: [PATCH 02/10] drm/i915/dmc: extract fw_info and table walk from >intel_package_header

Re: [Intel-gfx] [PATCH 04/10] drm/i915/dmc: extract function to parse css header

2019-05-23 Thread Rodrigo Vivi
On Thu, May 23, 2019 at 01:24:14AM -0700, Lucas De Marchi wrote: > Let's start splitting the parse function, making all of them return the > number of bytes parsed - different versions of the firmware header may > require different sizes for the structures. > > Signed-off-by: Lucas De Marchi >

Re: [Intel-gfx] [PATCH 03/10] drm/i915/dmc: add support for package_header with version 2

2019-05-23 Thread Rodrigo Vivi
On Thu, May 23, 2019 at 01:24:13AM -0700, Lucas De Marchi wrote: > The only meaninful change is that it supports up to 32 fw_info entries > rather than the previous max=20. > > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i915/intel_csr.c | 35 ++-- > 1

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GuC fixes (rev3)

2019-05-23 Thread Patchwork
== Series Details == Series: GuC fixes (rev3) URL : https://patchwork.freedesktop.org/series/60795/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9a0b5c696229 drm/i915/selftests: Move some reset testcases to separate file -:95: WARNING:FILE_PATH_CHANGES: added, moved or

Re: [Intel-gfx] [PATCH 02/10] drm/i915/dmc: extract fw_info and table walk from intel_package_header

2019-05-23 Thread Rodrigo Vivi
On Thu, May 23, 2019 at 01:24:12AM -0700, Lucas De Marchi wrote: > Move fw_info out of struct intel_package_header to allow it to grow more > easily in future. To make a cleaner move, let's also extract a function to > search the header for the dmc_offset. > > While reviewing this code I wondered

Re: [Intel-gfx] [PATCH 01/10] drm/i915/dmc: use kernel types

2019-05-23 Thread Rodrigo Vivi
On Thu, May 23, 2019 at 01:24:11AM -0700, Lucas De Marchi wrote: > Change all fields in intel_package_header and intel_dmc_header whose > meaning are 1-byte numbers to use u8. > > Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/intel_csr.c | 10

Re: [Intel-gfx] [PATCH 01/10] drm/i915/dmc: use kernel types

2019-05-23 Thread Srivatsa, Anusha
>-Original Message- >From: De Marchi, Lucas >Sent: Thursday, May 23, 2019 1:24 AM >To: intel-gfx@lists.freedesktop.org >Cc: Jani Nikula ; Srivatsa, Anusha >; Vivi, Rodrigo ; De >Marchi, Lucas >Subject: [PATCH 01/10] drm/i915/dmc: use kernel types > >Change all fields in

[Intel-gfx] [PATCH v4 1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range

2019-05-23 Thread Matthew Auld
Some steps in gen6_alloc_va_range require the HW to be awake, so ideally we should be grabbing the wakeref ourselves and not relying on the caller already holding it for us. Suggested-by: Chris Wilson Signed-off-by: Matthew Auld Reviewed-by: Chris Wilson ---

[Intel-gfx] [PATCH v4 2/2] drm/i915: add in-kernel blitter client

2019-05-23 Thread Matthew Auld
The plan is to use the blitter engine for async object clearing when using local memory, but before we can move the worker to get_pages() we have to first tame some more of our struct_mutex usage. With this in mind we should be able to upstream the object clearing as some selftests, which should

[Intel-gfx] [PATCH v2 8/9] drm/i915/uc: Stop talking with GuC when resetting

2019-05-23 Thread Michal Wajdeczko
Knowing that GuC will be reset soon, we may stop all communication immediately without doing graceful cleanup as it is not needed. This patch will also help us capture any unwanted/unexpected attempts to talk with GuC after we decided to reset it. And we need to keep 'disable' part as current and

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Keep user GGTT alive for a minimum of 250ms (rev2)

2019-05-23 Thread Patchwork
== Series Details == Series: drm/i915: Keep user GGTT alive for a minimum of 250ms (rev2) URL : https://patchwork.freedesktop.org/series/61047/ State : success == Summary == CI Bug Log - changes from CI_DRM_6132 -> Patchwork_13081 Summary

Re: [Intel-gfx] [PATCH v6 0/8] drm/fb-helper: Move modesetting code to drm_client

2019-05-23 Thread Sam Ravnborg
Hi Linus, Gerd. > This moves the modesetting code from drm_fb_helper to drm_client so it > can be shared by all internal clients. Could one of you take a look at this series. Daniel already ack'ed the series on irc, but an extra pair of eyes is never bad. For my part I have been through them

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Tune down link train error messages due to IO failure

2019-05-23 Thread Patchwork
== Series Details == Series: drm/i915: Tune down link train error messages due to IO failure URL : https://patchwork.freedesktop.org/series/61039/ State : success == Summary == CI Bug Log - changes from CI_DRM_6132 -> Patchwork_13079

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Keep user GGTT alive for a minimum of 250ms (rev2)

2019-05-23 Thread Patchwork
== Series Details == Series: drm/i915: Keep user GGTT alive for a minimum of 250ms (rev2) URL : https://patchwork.freedesktop.org/series/61047/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Keep user GGTT alive for a minimum of 250ms

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/fb-helper: Move modesetting code to drm_client (rev7)

2019-05-23 Thread Patchwork
== Series Details == Series: drm/fb-helper: Move modesetting code to drm_client (rev7) URL : https://patchwork.freedesktop.org/series/58597/ State : failure == Summary == Applying: drm/atomic: Move __drm_atomic_helper_disable_plane/set_config() Applying: drm/fb-helper: Remove

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: timeline semaphore support

2019-05-23 Thread Patchwork
== Series Details == Series: drm/i915: timeline semaphore support URL : https://patchwork.freedesktop.org/series/61032/ State : success == Summary == CI Bug Log - changes from CI_DRM_6132 -> Patchwork_13078 Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/10] drm/i915/dmc: use kernel types

2019-05-23 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915/dmc: use kernel types URL : https://patchwork.freedesktop.org/series/61016/ State : success == Summary == CI Bug Log - changes from CI_DRM_6132 -> Patchwork_13077 Summary

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with Linus' tree

2019-05-23 Thread Rob Herring
On Thu, May 23, 2019 at 6:54 AM Maxime Ripard wrote: > > On Tue, May 21, 2019 at 10:51:51AM +1000, Stephen Rothwell wrote: > > Hi all, > > > > Today's linux-next merge of the drm-misc tree got a conflict in: > > > > Documentation/devicetree/bindings/vendor-prefixes.txt > > > > between commit: >

Re: [Intel-gfx] [PATCH v2 8/9] drm/i915/uc: Stop talking with GuC when resetting

2019-05-23 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-05-23 16:53:27) > On Wed, 22 May 2019 22:06:53 +0200, Chris Wilson > wrote: > > > Quoting Michal Wajdeczko (2019-05-22 20:32:02) > >> Knowing that GuC will be reset soon, we may stop all communication > >> immediately without doing graceful cleanup as it is not

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: HuC updates

2019-05-23 Thread Patchwork
== Series Details == Series: drm/i915: HuC updates URL : https://patchwork.freedesktop.org/series/61001/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6122_full -> Patchwork_13074_full Summary --- **FAILURE**

Re: [Intel-gfx] [PULL] drm-misc-next

2019-05-23 Thread Daniel Vetter
On Thu, May 23, 2019 at 5:55 PM Daniel Vetter wrote: > > On Thu, May 23, 2019 at 5:53 PM Sean Paul wrote: > > > > On Thu, May 23, 2019 at 05:47:04PM +0200, Maarten Lankhorst wrote: > > > Hi Daniel and Dave, > > > > > > We keep adding support for panels at a high rate, is it still worth > > >

Re: [Intel-gfx] [PULL] drm-misc-next

2019-05-23 Thread Daniel Vetter
On Thu, May 23, 2019 at 5:53 PM Sean Paul wrote: > > On Thu, May 23, 2019 at 05:47:04PM +0200, Maarten Lankhorst wrote: > > Hi Daniel and Dave, > > > > We keep adding support for panels at a high rate, is it still worth listing > > them individually under cross subsystem changes? > > > > First

Re: [Intel-gfx] [PULL] drm-misc-next

2019-05-23 Thread Sean Paul
On Thu, May 23, 2019 at 05:47:04PM +0200, Maarten Lankhorst wrote: > Hi Daniel and Dave, > > We keep adding support for panels at a high rate, is it still worth listing > them individually under cross subsystem changes? > > First pull req for v5.3 here, enjoy! > As I was writing this mail, I

Re: [Intel-gfx] [PATCH v2 8/9] drm/i915/uc: Stop talking with GuC when resetting

2019-05-23 Thread Michal Wajdeczko
On Wed, 22 May 2019 22:06:53 +0200, Chris Wilson wrote: Quoting Michal Wajdeczko (2019-05-22 20:32:02) Knowing that GuC will be reset soon, we may stop all communication immediately without doing graceful cleanup as it is not needed. The difference between stop and disable is that it

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/1] drm/i915: remove unused IO_TLB_SEGPAGES which should be defined by swiotlb

2019-05-23 Thread Patchwork
== Series Details == Series: series starting with [1/1] drm/i915: remove unused IO_TLB_SEGPAGES which should be defined by swiotlb URL : https://patchwork.freedesktop.org/series/60998/ State : success == Summary == CI Bug Log - changes from CI_DRM_6122_full -> Patchwork_13073_full

[Intel-gfx] [PULL] drm-misc-next

2019-05-23 Thread Maarten Lankhorst
Hi Daniel and Dave, We keep adding support for panels at a high rate, is it still worth listing them individually under cross subsystem changes? First pull req for v5.3 here, enjoy! As I was writing this mail, I missed a fix in mtk_hdmi_hw_send_info_frame for the unhandled HDR case in switch,

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: timeline semaphore support

2019-05-23 Thread Patchwork
== Series Details == Series: drm/i915: timeline semaphore support URL : https://patchwork.freedesktop.org/series/61032/ State : warning == Summary == $ dim checkpatch origin/drm-tip 72fcbc639236 drm/syncobj: add an output syncobj parameter to find_fence a888c5f147aa drm/i915: add syncobj

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,01/15] drm/i915: Split GEM object type definition to its own header

2019-05-23 Thread Patchwork
== Series Details == Series: series starting with [CI,01/15] drm/i915: Split GEM object type definition to its own header URL : https://patchwork.freedesktop.org/series/60990/ State : success == Summary == CI Bug Log - changes from CI_DRM_6121_full -> Patchwork_13072_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gtt: Always acquire struct_mutex for gen6_ppgtt_cleanup

2019-05-23 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Always acquire struct_mutex for gen6_ppgtt_cleanup URL : https://patchwork.freedesktop.org/series/61012/ State : success == Summary == CI Bug Log - changes from CI_DRM_6132 -> Patchwork_13076

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for GuC fixes (rev2)

2019-05-23 Thread Michal Wajdeczko
On Wed, 22 May 2019 22:53:11 +0200, Patchwork wrote: == Series Details == Series: GuC fixes (rev2) URL : https://patchwork.freedesktop.org/series/60795/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6123 -> Patchwork_13075

Re: [Intel-gfx] [PATCH] drm/i915: Keep user GGTT alive for a minimum of 250ms

2019-05-23 Thread Chris Wilson
Quoting Chris Wilson (2019-05-23 15:33:54) > +static void __userfault_timeout(struct timer_list *t) > +{ > + struct drm_i915_private *i915 = > + from_timer(i915, t, mm.userfault_timer); > + > + intel_runtime_pm_put(i915, xchg(>mm.userfault_wakeref, 0)); > +} > + > +static

[Intel-gfx] [PATCH] drm/i915: Keep user GGTT alive for a minimum of 250ms

2019-05-23 Thread Chris Wilson
Do not allow runtime pm autosuspend to remove userspace GGTT mmaps too quickly. For example, igt sets the autosuspend delay to 0, and so we immediately attempt to perform runtime suspend upon releasing the wakeref. Unfortunately, that involves tearing down GGTT mmaps as they require an active

[Intel-gfx] [PATCH] drm/i915: Keep user GGTT alive for a minimum of 250ms

2019-05-23 Thread Chris Wilson
Do not allow runtime pm autosuspend to remove userspace GGTT mmaps too quickly. For example, igt sets the autosuspend delay to 0, and so we immediately attempt to perform runtime suspend upon releasing the wakeref. Unfortunately, that involves tearing down GGTT mmaps as they require an active

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gtt: Always acquire struct_mutex for gen6_ppgtt_cleanup

2019-05-23 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Always acquire struct_mutex for gen6_ppgtt_cleanup URL : https://patchwork.freedesktop.org/series/61012/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6c62c85d4558 drm/i915/gtt: Always acquire struct_mutex for gen6_ppgtt_cleanup -:13:

Re: [Intel-gfx] [PATCH i-g-t 07/15] gem_wsim: Infinite batch support

2019-05-23 Thread Tvrtko Ursulin
On 23/05/2019 15:09, Chris Wilson wrote: Quoting Chris Wilson (2019-05-23 15:05:05) Quoting Tvrtko Ursulin (2019-05-22 16:57:12) -static void +static unsigned int terminate_bb(struct w_step *w, unsigned int flags) { const uint32_t bbe = 0xa << 23; unsigned long

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with Linus' tree

2019-05-23 Thread Stephen Rothwell
Hi Daniel, On Thu, 23 May 2019 15:11:15 +0200 Daniel Vetter wrote: > > That commit is on top of drm-misc, and somehow the .txt version has > been resurrect in drm-misc-next (so needs to be re-deleted too). My mistake, the conflict went away (due to the back merge) so my scripts assumed the file

Re: [Intel-gfx] [PATCH 2/2] drm/i915: add syncobj timeline support

2019-05-23 Thread Lionel Landwerlin
On 23/05/2019 14:59, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-05-23 14:46:42) On 23/05/2019 12:52, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-05-23 12:46:20) - syncobj = drm_syncobj_find(file, fence.handle); - if (!syncobj) { -

Re: [Intel-gfx] [PATCH i-g-t 07/15] gem_wsim: Infinite batch support

2019-05-23 Thread Chris Wilson
Quoting Chris Wilson (2019-05-23 15:05:05) > Quoting Tvrtko Ursulin (2019-05-22 16:57:12) > > -static void > > +static unsigned int > > terminate_bb(struct w_step *w, unsigned int flags) > > { > > const uint32_t bbe = 0xa << 23; > > unsigned long mmap_start, mmap_len; > >

Re: [Intel-gfx] [PATCH i-g-t 07/15] gem_wsim: Infinite batch support

2019-05-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-05-22 16:57:12) > -static void > +static unsigned int > terminate_bb(struct w_step *w, unsigned int flags) > { > const uint32_t bbe = 0xa << 23; > unsigned long mmap_start, mmap_len; > unsigned long batch_start = w->bb_sz; > + unsigned

Re: [Intel-gfx] [PATCH 2/2] drm/i915: add syncobj timeline support

2019-05-23 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-05-23 14:46:42) > On 23/05/2019 12:52, Chris Wilson wrote: > > Quoting Lionel Landwerlin (2019-05-23 12:46:20) > >> - syncobj = drm_syncobj_find(file, fence.handle); > >> - if (!syncobj) { > >> - DRM_DEBUG("Invalid

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 04/15] gem_wsim: Engine map load balance command

2019-05-23 Thread Tvrtko Ursulin
On 23/05/2019 14:25, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-05-22 16:57:09) From: Tvrtko Ursulin A new workload command for enabling a load balanced context map (aka Virtual Engine). Example usage: B.1 This turns on load balancing for context one, assuming it has already been

Re: [Intel-gfx] [PATCH 2/2] drm/i915: add syncobj timeline support

2019-05-23 Thread Lionel Landwerlin
On 23/05/2019 12:52, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-05-23 12:46:20) - syncobj = drm_syncobj_find(file, fence.handle); - if (!syncobj) { - DRM_DEBUG("Invalid syncobj handle provided\n"); - err = -ENOENT;

[Intel-gfx] [PATCH v6 7/8] drm/fb-helper: Move out modeset config code

2019-05-23 Thread Noralf Trønnes
No functional changes, just moving code as-is and fixing includes. Signed-off-by: Noralf Trønnes Reviewed-by: Maxime Ripard Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/drm_client_modeset.c | 707 ++- drivers/gpu/drm/drm_fb_helper.c | 692

[Intel-gfx] [PATCH v6 3/8] drm/fb-helper: Prepare to move out commit code

2019-05-23 Thread Noralf Trønnes
This makes the necessary changes so the commit code can be moved out to drm_client as-is in the next patch. It's split up to ease review. Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/drm_fb_helper.c | 122 +--- 1 file changed, 81

[Intel-gfx] [PATCH v6 6/8] drm/fb-helper: Prepare to move out modeset config code

2019-05-23 Thread Noralf Trønnes
This prepares the modeset code so it can be moved out as-is in the next patch. v3: Remove stray newline Signed-off-by: Noralf Trønnes Reviewed-by: Maxime Ripard Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/drm_fb_helper.c | 62 +++-- include/drm/drm_fb_helper.h

[Intel-gfx] [PATCH v6 2/8] drm/fb-helper: Remove drm_fb_helper_crtc

2019-05-23 Thread Noralf Trønnes
struct drm_fb_helper_crtc is now just a wrapper around drm_mode_set so use that directly instead and attach it as a modeset array onto drm_client_dev. drm_fb_helper will use this array to store its modesets which means it will always initialize a drm_client, but it will not register the client

  1   2   >