== Series Details ==
Series: drm/i915: adding state checker for gamma lut values (rev10)
URL : https://patchwork.freedesktop.org/series/58039/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6148_full -> Patchwork_13107_full
== Series Details ==
Series: drm/i915: Keep user GGTT alive for a minimum of 250ms (rev6)
URL : https://patchwork.freedesktop.org/series/61047/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6148_full -> Patchwork_13106_full
On 24/05/2019 11:07, Chris Wilson wrote:
Quoting Lionel Landwerlin (2019-05-24 10:51:49)
On 24/05/2019 10:42, Chris Wilson wrote:
Quoting Lionel Landwerlin (2019-05-24 10:28:16)
On 21/05/2019 17:36, Chris Wilson wrote:
Quoting Lionel Landwerlin (2019-05-21 15:08:52)
diff --git
== Series Details ==
Series: GuC 32.0.3 (rev6)
URL : https://patchwork.freedesktop.org/series/58760/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6150 -> Patchwork_13108
Summary
---
**FAILURE**
Serious unknown
Define HuC firmware version for Icelake.
v2: 8.4.3238 is now available
Signed-off-by: Michal Wajdeczko
Cc: Daniele Ceraolo Spurio
Cc: Joonas Lahtinen
Cc: Anusha Srivatsa
Cc: Tony Ye
Reviewed-by: Tony Ye
---
drivers/gpu/drm/i915/intel_huc_fw.c | 12
1 file changed, 12
Gen11 defines new more flexible Host-to-GuC interrupt register.
Now the host can write any 32-bit payload to trigger an interrupt
and GuC can additionally read this payload from the register.
Current GuC firmware ignores the payload so we just write 0.
Bspec: 21043
Signed-off-by: Michal
Gen11 defines new register for checking HuC authentication status.
Look into the right register and bit.
v2: use reg/mask/value instead of dedicated functions (Daniele)
BSpec: 19686
Signed-off-by: Michal Wajdeczko
Cc: Joonas Lahtinen
Cc: Rodrigo Vivi
Cc: Tony Ye
Cc: Vinay Belgaumkar
Cc:
Due to the upcoming changes to the GuC ABI interface, we must
disable GuC submission mode until final ABI will be available
on all GuC firmwares.
To avoid regressions on systems configured to run with no longer
supported configuration "enable_guc=3" or "enable_guc=1" clear
GuC submission bit.
Gen11 adds new set of scratch registers that can be used for MMIO
based Host-to-Guc communication. Due to limited number of these
registers it is expected that host will use them only for command
transport buffers (CTB) communication setup if one is available.
Bspec: 21044
Signed-off-by: Michal
New GuC 32.0.3 firmware made many changes around its ABI that
require driver updates:
* FW release version numbering schema now includes patch number
* FW release version encoding in CSS header
* Boot parameters
* Suspend/resume protocol
* Sample-forcewake command
* Additional Data Structures
Today our most desired GuC configuration is to only enable HuC
if it is available (as we need authenticated HuC firmware to enable
all media codecs on the hardware) and we really don't care about
having GuC submission enabled.
Change platform default GuC mode to match our goal, but note that
we
Current GuC firmwares identify response message in a different way.
v2: update comments for other H2G bits (Daniele)
Signed-off-by: Michal Wajdeczko
Cc: Daniele Ceraolo Spurio
Cc: Kelvin Gardiner
Cc: John Spotswood
Reviewed-by: Daniele Ceraolo Spurio
---
drivers/gpu/drm/i915/intel_guc_ct.c
Run GuC, run!
Signed-off-by: Michal Wajdeczko
---
drivers/gpu/drm/i915/i915_params.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_params.h
b/drivers/gpu/drm/i915/i915_params.h
index 3f14e9881a0d..e28ae23de516 100644
---
GuC stores some data in there, which might be stale after a reset.
Reinitialize whole ADS in case any part of it was corrupted during
previous GuC run.
v2: s/reinit/init, update functions descriptions (Tomek/Michal)
v3: reset ADS right before fw upload
Signed-off-by: Michal Wajdeczko
Cc:
With newer GuC firmware it is always ok to ask GuC to update power
domain states. Make it an unconditional initialization step.
Signed-off-by: Michal Wajdeczko
Cc: Daniele Ceraolo Spurio
Cc: John Spotswood
Reviewed-by: Daniele Ceraolo Spurio
Reviewed-by: John Spotswood
---
From: Oscar Mateo
Controlling and handling of the GuC interrupts is Gen specific.
Create virtual functions to avoid redundant runtime Gen checks.
Gen-specific versions of these functions will follow.
v2: move vfuncs to struct guc (Daniele)
v3: rebased
Signed-off-by: Oscar Mateo
Signed-off-by:
From: Oscar Mateo
Starting Gen11 GuC shares interrupt registers with SG unit
instead of PM. But for now we don't care about SG interrupts.
v2: (Chris)
v3: rebased (Michal)
v4: more bspec pages, use macros, update commit msg (Michal Wi)
Bspec: 19820, 19840, 19841, 20176
Signed-off-by: Oscar
Define GuC firmware version for Icelake.
Signed-off-by: Michal Wajdeczko
Cc: Daniele Ceraolo Spurio
Cc: Joonas Lahtinen
Cc: Rodrigo Vivi
Cc: Anusha Srivatsa
Reviewed-by: Anusha Srivatsa
---
drivers/gpu/drm/i915/intel_guc_fw.c | 11 +++
1 file changed, 11 insertions(+)
diff --git
Gen11 GuC firmware expects H2G command messages to be sent over CTB
(command transport buffers).
Signed-off-by: Michal Wajdeczko
Cc: Daniele Ceraolo Spurio
Cc: Joonas Lahtinen
Cc: John Spotswood
Reviewed-by: Daniele Ceraolo Spurio
---
drivers/gpu/drm/i915/i915_pci.c | 1 +
1 file changed, 1
New GuC firmwares (for SKL, BXT, KBL, GLK, ICL) with updated ABI interface.
v2: only HuC authentication is supported
v3: never allow to turn on GuC submission mode
v4: rebased + newer HuC + GLK
v5: squashed + last minutes small fixups
Cc: Daniele Ceraolo Spurio
Cc: Joonas Lahtinen
Cc: Martin
Define HuC firmware version for Geminilake.
Signed-off-by: Michal Wajdeczko
Cc: Daniele Ceraolo Spurio
Cc: Joonas Lahtinen
Cc: Anusha Srivatsa
Cc: Tony Ye
Reviewed-by: Anusha Srivatsa
---
drivers/gpu/drm/i915/intel_huc_fw.c | 12
1 file changed, 12 insertions(+)
diff --git
Define GuC firmware version for Geminilake.
Signed-off-by: Michal Wajdeczko
Cc: Daniele Ceraolo Spurio
Cc: Anusha Srivatsa
Reviewed-by: Anusha Srivatsa
---
drivers/gpu/drm/i915/intel_guc_fw.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_guc_fw.c
On Mon, May 27, 2019 at 08:18:35AM +0200, Daniel Vetter wrote:
> On Sun, May 26, 2019 at 07:35:28PM +0200, Sam Ravnborg wrote:
> > While removing use of drmP.h from files in drm/* I
> > noticed that I had to add the same include files due to
> > dependencies in the header files.
> >
> > It is
On Fri, May 24, 2019 at 06:36:14PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> ICL has so many planes that it can easily exceed the maximum
> effective memory bandwidth of the system. We must therefore check
> that we don't exceed that limit.
>
> The algorithm is very magic number
Fixes: 14dcd98a43c8 ("drm/i915: Extract i9xx_read_luts()")
Signed-off-by: kbuild test robot
---
intel_color.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_color.c
b/drivers/gpu/drm/i915/intel_color.c
index e8d8167..bf92365 100644
---
://github.com/0day-ci/linux/commits/Swati-Sharma/drm-i915-adding-state-checker-for-gamma-lut-values/20190527-214948
base: git://anongit.freedesktop.org/drm-intel for-linux-next
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-rc1-7-g2b96cd8-dirty
make ARCH=x86_64
On Mon, May 27, 2019 at 4:01 PM Thomas Hellstrom wrote:
>
> On 5/27/19 3:16 PM, Daniel Vetter wrote:
> > On Mon, May 27, 2019 at 02:39:18PM +0200, Thomas Hellstrom wrote:
> >> On 5/27/19 10:17 AM, Emil Velikov wrote:
> >>> From: Emil Velikov
> >>>
> >>> There are cases (in mesa and applications)
== Series Details ==
Series: drm/i915: adding state checker for gamma lut values (rev10)
URL : https://patchwork.freedesktop.org/series/58039/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6148 -> Patchwork_13107
Summary
On Mon, May 27, 2019 at 06:50:14AM +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/icl: Fix AUX-B HW not done issue w/o AUX-A
> URL : https://patchwork.freedesktop.org/series/61123/
> State : failure
Thanks for the review pushed to -dinq.
>
> == Summary ==
>
> CI Bug Log
On Thu, May 23, 2019 at 11:30:44PM +, Michal Wajdeczko wrote:
> From: Oscar Mateo
>
> The GuC interrupts now get their own interrupt vector (instead of
> sharing a register with the PM interrupts) so handle appropriately.
>
> v2: (Chris)
> v3: rebased (Michal)
> Bspec: 19820
Bspec: 19820,
== Series Details ==
Series: drm/i915: adding state checker for gamma lut values (rev10)
URL : https://patchwork.freedesktop.org/series/58039/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915: Introduce vfunc read_luts() to create hw lut
Okay!
On 5/27/19 3:16 PM, Daniel Vetter wrote:
On Mon, May 27, 2019 at 02:39:18PM +0200, Thomas Hellstrom wrote:
On 5/27/19 10:17 AM, Emil Velikov wrote:
From: Emil Velikov
There are cases (in mesa and applications) where one would open the
primary node without properly authenticating the client.
== Series Details ==
Series: drm/i915: adding state checker for gamma lut values (rev10)
URL : https://patchwork.freedesktop.org/series/58039/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
d7ec7acfa25a drm/i915: Introduce vfunc read_luts() to create hw lut
729d4500e37f
== Series Details ==
Series: drm/i915: Keep user GGTT alive for a minimum of 250ms (rev6)
URL : https://patchwork.freedesktop.org/series/61047/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6148 -> Patchwork_13106
Summary
In this patch, intel_color_get_config() is enabled and support
for read_luts() will be added platform by platform incrementally
in the follow-up patches.
v4: -Renamed intel_get_color_config to intel_color_get_config [Jani]
-Added the user early on such that support for get_color_config()
In this patch, hw gamma and degamma blob is created for
cherryview.
v4: -No need to initialize *blob [Jani]
-Removed right shifts [Jani]
-Dropped dev local var [Jani]
v5: -Returned blob instead of assigning it internally within the
function [Ville]
-Renamed function
In this patch, gamma and degamma hw blobs are created for IVB.
v4: -No need to initialize *blob [Jani]
-Removed right shifts [Jani]
-Dropped dev local var [Jani]
v5: -Returned blob instead of assigning it internally within the
function [Ville]
-Renamed ivb_get_color_config() to
In this patch series, added state checker to validate gamma
and will be extended to validate degamma lut values aswell.
This reads hardware state, and compares the originally
requested state to the state read from hardware.
v1: -Implementation done for legacy platforms
(removed all the
In this patch, hw gamma blob is created for i965.
v4: -No need to initialize *blob [Jani]
-Removed right shifts [Jani]
-Dropped dev local var [Jani]
v5: -Returned blob instead of assigning it internally
within the function [Ville]
-Renamed i965_get_color_config() to
Signed-off-by: Swati Sharma
---
drivers/gpu/drm/i915/intel_color.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_color.c
b/drivers/gpu/drm/i915/intel_color.c
index 061bdbf..31e5a44 100644
--- a/drivers/gpu/drm/i915/intel_color.c
+++
In this patch, gamma and degamma hw blobs are created for GLK.
v4: -No need to initialize *blob [Jani]
-Removed right shifts [Jani]
-Dropped dev local var [Jani]
v5: -Returned blob instead of assigning it internally within the
function [Ville]
-Renamed glk_get_color_config() to
In this patch, gamma and degamma hw blobs are created for BDW.
v4: -No need to initialize *blob [Jani]
-Removed right shifts [Jani]
-Dropped dev local var [Jani]
v5: -Returned blob instead of assigning it internally within the
function [Ville]
-Renamed bdw_get_color_config() to
In this patch, hw gamma blob is created for ILK.
v4: -No need to initialize *blob [Jani]
-Removed right shifts [Jani]
-Dropped dev local var [Jani]
v5: -Returned blob instead of assigning it internally within the
function [Ville]
-Renamed ilk_get_color_config() to ilk_read_luts()
In this patch, gamma hw blobs are created for ICL.
v4: -No need to initialize *blob [Jani]
-Removed right shifts [Jani]
-Dropped dev local var [Jani]
v5: -Returned blob instead of assigning it internally within the
function [Ville]
-Renamed icl_get_color_config() to
In this patch, hw gamma blob is created for the legacy
gamma. Also, function intel_color_lut_pack is added to
convert hw value with given bit_precision to lut property val.
v4: -No need to initialize *blob [Jani]
-Removed right shifts [Jani]
-Dropped dev local var [Jani]
v5: -Returned
v3: -Rebase
v4: -Renamed intel_compare_color_lut() to intel_color_lut_equal() [Jani]
-Added the default label above the correct label [Jani]
-Corrected smatch warn "variable dereferenced before check" [Dan Carpenter]
v5: -Added condition (!blob1 && !blob2) return true [Jani]
-Called
In this patch, a vfunc read_luts() is introduced to create a hw lut
i.e. lut having values read from gamma/degamma registers which will
later be used to compare with sw lut to validate gamma/degamma lut values.
v3: -Rebase
v4: -Renamed intel_get_color_config to intel_color_get_config [Jani]
On Mon, May 27, 2019 at 02:39:18PM +0200, Thomas Hellstrom wrote:
> On 5/27/19 10:17 AM, Emil Velikov wrote:
> > From: Emil Velikov
> >
> > There are cases (in mesa and applications) where one would open the
> > primary node without properly authenticating the client.
> >
> > Sometimes we don't
== Series Details ==
Series: drm/i915: Keep user GGTT alive for a minimum of 250ms (rev6)
URL : https://patchwork.freedesktop.org/series/61047/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915: Keep user GGTT alive for a minimum of 250ms
+
On Fri, May 24, 2019 at 08:35:32PM +0300, Imre Deak wrote:
> Atm AUX-B transfers can fail with the following error if AUX-A is not
> enabled:
>
> [ 594.594108] [drm:intel_dp_aux_xfer [i915]] dp_aux_ch timeout status
> 0x7c2003ff
> [ 594.615854] [drm:intel_dp_aux_xfer [i915]] *ERROR* dp aux hw
== Series Details ==
Series: drm/i915: Keep user GGTT alive for a minimum of 250ms (rev6)
URL : https://patchwork.freedesktop.org/series/61047/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
fbf134649c9d drm/i915: Keep user GGTT alive for a minimum of 250ms
-:196:
On 2019/05/27, Thomas Hellstrom wrote:
> On 5/27/19 10:17 AM, Emil Velikov wrote:
> > From: Emil Velikov
> >
> > There are cases (in mesa and applications) where one would open the
> > primary node without properly authenticating the client.
> >
> > Sometimes we don't check if the
== Series Details ==
Series: drm/panel: drmP.h removal + small fix
URL : https://patchwork.freedesktop.org/series/61157/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6142_full -> Patchwork_13104_full
Summary
---
On 5/27/19 10:17 AM, Emil Velikov wrote:
From: Emil Velikov
There are cases (in mesa and applications) where one would open the
primary node without properly authenticating the client.
Sometimes we don't check if the authentication succeeds, but there's
also cases we simply forget to do it.
Am 27.05.19 um 14:10 schrieb Emil Velikov:
> On 2019/05/27, Christian König wrote:
>> Am 27.05.19 um 10:17 schrieb Emil Velikov:
>>> From: Emil Velikov
>>>
>>> There are cases (in mesa and applications) where one would open the
>>> primary node without properly authenticating the client.
>>>
>>>
On 2019/05/27, Christian König wrote:
> Am 27.05.19 um 10:17 schrieb Emil Velikov:
> > From: Emil Velikov
> >
> > There are cases (in mesa and applications) where one would open the
> > primary node without properly authenticating the client.
> >
> > Sometimes we don't check if the
== Series Details ==
Series: drm: make headers self-contained and drop drmP.h
URL : https://patchwork.freedesktop.org/series/61156/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6142_full -> Patchwork_13103_full
Summary
On 2019/05/27, Jani Nikula wrote:
> On Mon, 27 May 2019, Emil Velikov wrote:
> > From: Emil Velikov
> >
> > The authentication can be circumvented, by design, by using the render
> > node.
> >
> > From the driver POV there is no distinction between primary and render
> > nodes, thus we can drop
On Mon, 27 May 2019 13:40:25 +0200, Joonas Lahtinen
wrote:
Quoting Michal Wajdeczko (2019-05-24 02:30:29)
Due to the upcoming changes to the GuC ABI interface, we must
disable GuC submission mode until final ABI will be available
on all GuC firmwares.
To avoid regressions on systems
Am 27.05.19 um 10:17 schrieb Emil Velikov:
From: Emil Velikov
There are cases (in mesa and applications) where one would open the
primary node without properly authenticating the client.
Sometimes we don't check if the authentication succeeds, but there's
also cases we simply forget to do it.
On Mon, May 27, 2019 at 9:17 AM Daniel Vetter wrote:
>
> On Sat, May 25, 2019 at 07:19:28PM +0200, Sam Ravnborg wrote:
> > Hi Daniel.
> >
> > Good work, nice cleanup all over.
> >
> > A few comments to a few patches - not something that warrant a
> > new series to be posted as long as it is fixed
Do not allow runtime pm autosuspend to remove userspace GGTT mmaps too
quickly. For example, igt sets the autosuspend delay to 0, and so we
immediately attempt to perform runtime suspend upon releasing the
wakeref. Unfortunately, that involves tearing down GGTT mmaps as they
require an active
== Series Details ==
Series: drm/i915: Keep user GGTT alive for a minimum of 250ms (rev5)
URL : https://patchwork.freedesktop.org/series/61047/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6147 -> Patchwork_13105
Summary
Quoting Michal Wajdeczko (2019-05-24 02:30:29)
> Due to the upcoming changes to the GuC ABI interface, we must
> disable GuC submission mode until final ABI will be available
> on all GuC firmwares.
>
> To avoid regressions on systems configured to run with no longer
> supported configuration
Quoting Michal Wajdeczko (2019-05-24 02:30:28)
> Today our most desired GuC configuration is to only enable HuC
> if it is available and we really don't care about GuC submission.
> Change platform default GuC mode to match our desire.
You should amend here that the HuC authentication is needed
== Series Details ==
Series: drm/i915: Keep user GGTT alive for a minimum of 250ms (rev5)
URL : https://patchwork.freedesktop.org/series/61047/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915: Keep user GGTT alive for a minimum of 250ms
+
On Fri, 24 May 2019 15:29:22 +0200, Michal Wajdeczko
wrote:
On Fri, 24 May 2019 15:10:58 +0200, Joonas Lahtinen
wrote:
Quoting Ye, Tony (2019-05-22 14:32:41)
From UMD perspective, when HuC is not working as expected, usually we
look into the kernel log and i915_huc_load_status debugfs
== Series Details ==
Series: drm/i915: Keep user GGTT alive for a minimum of 250ms (rev5)
URL : https://patchwork.freedesktop.org/series/61047/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
6e1b0f65e952 drm/i915: Keep user GGTT alive for a minimum of 250ms
-:195:
Do not allow runtime pm autosuspend to remove userspace GGTT mmaps too
quickly. For example, igt sets the autosuspend delay to 0, and so we
immediately attempt to perform runtime suspend upon releasing the
wakeref. Unfortunately, that involves tearing down GGTT mmaps as they
require an active
== Series Details ==
Series: fbcon notifier begone! (rev4)
URL : https://patchwork.freedesktop.org/series/60843/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6142_full -> Patchwork_13102_full
Summary
---
On 5/24/19 5:28 PM, Daniel Vetter wrote:
> Hi Daniel,
>
> On Fri, May 24, 2019 at 3:14 PM Daniel Thompson
> wrote:
>>
>> On Fri, May 24, 2019 at 10:53:45AM +0200, Daniel Vetter wrote:
>>> This reverts commit 994efacdf9a087b52f71e620b58dfa526b0cf928.
>>>
>>> The justification is that if hw
On Mon, May 27, 2019 at 11:11:18AM +0200, Linus Walleij wrote:
> On Sun, May 26, 2019 at 8:05 PM Sam Ravnborg wrote:
>
> > Drop use of the deprecated drmP.h header file.
> >
> > While touching the list of include files:
> > - Divide include files in blocks of linux/* video/* drm/* etc.
> > Be
== Series Details ==
Series: series starting with [1/2] drm/i915: Make intel_fuzzy_clock_check
available outside of intel_display.c
URL : https://patchwork.freedesktop.org/series/61127/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6142_full -> Patchwork_13098_full
== Series Details ==
Series: drm/i915/ehl: Introduce Mule Creek Canyon PCH
URL : https://patchwork.freedesktop.org/series/61137/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6142_full -> Patchwork_13101_full
Summary
Quoting Rodrigo Siqueira (2019-05-27 02:19:51)
> The function __kms_addfb() and drmModeAddFB2WithModifiers() have a
> similar code. Due to this similarity, this commit replaces all the
> occurrences of __kms_addfb() by drmModeAddFB2WithModifiers() and adds
> the required adaptations.
No. There
On Fri, 24 May 2019, Chris Wilson wrote:
> Quoting Jani Nikula (2019-05-24 19:52:53)
>> REG_BIT() and REG_GENMASK() were intended to work with both constant
>> expressions and otherwise, with the former having extra compile time
>> checks for the bit ranges. Incredibly, the result of
>>
== Series Details ==
Series: drm/i915/gtt: set err to -ENOMEM on memory allocation failure
URL : https://patchwork.freedesktop.org/series/61134/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6142_full -> Patchwork_13100_full
We can use offsetof for the same effect, much tidier with no dummy
locals.
Signed-off-by: Chris Wilson
Cc: Tvrtko Ursulin
---
benchmarks/gem_wsim.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c
index
On Sun, May 26, 2019 at 8:05 PM Sam Ravnborg wrote:
> Drop use of the deprecated drmP.h header file.
>
> While touching the list of include files:
> - Divide include files in blocks of linux/* video/* drm/* etc.
> Be consistent in the order of the blocks
> - Sort individual blocks of include
== Series Details ==
Series: drm/i915: make REG_BIT() and REG_GENMASK() work with variables
URL : https://patchwork.freedesktop.org/series/61129/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6142_full -> Patchwork_13099_full
On Mon, 27 May 2019, Emil Velikov wrote:
> From: Emil Velikov
>
> The authentication can be circumvented, by design, by using the render
> node.
>
> From the driver POV there is no distinction between primary and render
> nodes, thus we can drop the token.
>
> Note: the outstanding DRM_AUTH
Move the stray ')' from
gem_can_store_dword(exec_id) | exec_flags
to
gem_can_store_dword(exec_id | exec_flags)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110764
Signed-off-by: Chris Wilson
---
tests/prime_vgem.c | 8
1 file changed, 4 insertions(+), 4
== Series Details ==
Series: series starting with [1/2] drm/i915: Make intel_fuzzy_clock_check
available outside of intel_display.c
URL : https://patchwork.freedesktop.org/series/61127/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6142_full -> Patchwork_13098_full
From: Emil Velikov
The authentication can be circumvented, by design, by using the render
node.
From the driver POV there is no distinction between primary and render
nodes, thus we can drop the token.
Note: the outstanding DRM_AUTH instances are:
- legacy DRI1 ioctls, which are already
From: Emil Velikov
There are cases (in mesa and applications) where one would open the
primary node without properly authenticating the client.
Sometimes we don't check if the authentication succeeds, but there's
also cases we simply forget to do it.
The former was a case for Mesa where it did
== Series Details ==
Series: drm/i915/kvmgt: Use struct_size() helper
URL : https://patchwork.freedesktop.org/series/61124/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6142_full -> Patchwork_13096_full
Summary
---
On Mon, May 27, 2019 at 09:11:26AM +0200, Daniel Vetter wrote:
> On Fri, May 24, 2019 at 10:53:53AM +0200, Daniel Vetter wrote:
> > this driver is pretty horrible from a design pov, and needs a complete
> > overhaul. Concrete thing that annoys me is that it looks at
> > registered_fb, which is an
On Mon, May 27, 2019 at 09:10:10AM +0200, Daniel Vetter wrote:
> On Fri, May 24, 2019 at 10:53:35AM +0200, Daniel Vetter wrote:
> > Simply because olpc never unregisters the damn thing. It also
> > registers the framebuffer directly by poking around in fbdev
> > core internals, so it's all around
On Mon, May 27, 2019 at 09:08:58AM +0200, Daniel Vetter wrote:
> On Fri, May 24, 2019 at 10:53:25AM +0200, Daniel Vetter wrote:
> > I honestly have no idea what the subtle differences between
> > con_is_visible, con_is_fg (internal to vt.c) and con_is_bound are. But
> > it looks like both
On Sat, May 25, 2019 at 07:19:28PM +0200, Sam Ravnborg wrote:
> Hi Daniel.
>
> Good work, nice cleanup all over.
>
> A few comments to a few patches - not something that warrant a
> new series to be posted as long as it is fixed before the patches are
> applied.
Hm yeah good idea, I'll add that
On Fri, May 24, 2019 at 10:53:53AM +0200, Daniel Vetter wrote:
> this driver is pretty horrible from a design pov, and needs a complete
> overhaul. Concrete thing that annoys me is that it looks at
> registered_fb, which is an internal thing to fbmem.c and fbcon.c. And
> ofc it gets the lifetime
On Fri, May 24, 2019 at 10:53:35AM +0200, Daniel Vetter wrote:
> Simply because olpc never unregisters the damn thing. It also
> registers the framebuffer directly by poking around in fbdev
> core internals, so it's all around rather broken.
>
> Signed-off-by: Daniel Vetter
> Cc: Jens Frederich
On Fri, May 24, 2019 at 10:53:25AM +0200, Daniel Vetter wrote:
> I honestly have no idea what the subtle differences between
> con_is_visible, con_is_fg (internal to vt.c) and con_is_bound are. But
> it looks like both vc->vc_display_fg and con_driver_map are protected
> by the console_lock, so
Hi Daniel.
On Mon, May 27, 2019 at 08:18:35AM +0200, Daniel Vetter wrote:
> On Sun, May 26, 2019 at 07:35:28PM +0200, Sam Ravnborg wrote:
> > While removing use of drmP.h from files in drm/* I
> > noticed that I had to add the same include files due to
> > dependencies in the header files.
> >
>
On Mon, May 27, 2019 at 08:13:06AM +0200, Daniel Vetter wrote:
> On Sat, May 25, 2019 at 05:01:59PM +0200, Sam Ravnborg wrote:
> > Hi Daniel
> >
> > > It's dead code, and removing it avoids me having to understand
> > > what it's doing with lock_fb_info.
> >
> > I pushed the series through my
Hi Daniel.
> But I indeed forgot
> to delete the initial assignment of info at the function start. Is that
> what you mean here?
Yes.
Sam
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
== Series Details ==
Series: drm/i915/icl: Fix AUX-B HW not done issue w/o AUX-A
URL : https://patchwork.freedesktop.org/series/61123/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6142_full -> Patchwork_13095_full
Summary
On Sun, May 26, 2019 at 07:35:28PM +0200, Sam Ravnborg wrote:
> While removing use of drmP.h from files in drm/* I
> noticed that I had to add the same include files due to
> dependencies in the header files.
>
> It is better to let the header files be self-contained and
> let the users pull in
On Sat, May 25, 2019 at 05:01:59PM +0200, Sam Ravnborg wrote:
> Hi Daniel
>
> > It's dead code, and removing it avoids me having to understand
> > what it's doing with lock_fb_info.
>
> I pushed the series through my build tests which include the sh
> architecture.
>
> One error and one warning
On Sat, May 25, 2019 at 05:38:26PM +0200, Sam Ravnborg wrote:
> Hi Daniel.
>
> One detail I noticed while brosing the changes.
>
> >
> > @@ -1064,9 +1062,13 @@ static void fbcon_init(struct vc_data *vc, int init)
> > int logo = 1, new_rows, new_cols, rows, cols, charcnt = 256;
> > int
100 matches
Mail list logo
