[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/9] drm/i915: Move object close under its own lock

2019-05-28 Thread Patchwork
== Series Details == Series: series starting with [1/9] drm/i915: Move object close under its own lock URL : https://patchwork.freedesktop.org/series/61243/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6156_full -> Patchwork_13114_full

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3,V2] lib: fix match_string() helper on -1 array size

2019-05-28 Thread Patchwork
== Series Details == Series: series starting with [1/3,V2] lib: fix match_string() helper on -1 array size URL : https://patchwork.freedesktop.org/series/61280/ State : success == Summary == CI Bug Log - changes from CI_DRM_6159 -> Patchwork_13120

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gvt: remove duplicate entry of trace

2019-05-28 Thread Patchwork
== Series Details == Series: drm/i915/gvt: remove duplicate entry of trace URL : https://patchwork.freedesktop.org/series/61281/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/compile.h

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3,V2] lib: fix match_string() helper on -1 array size

2019-05-28 Thread Patchwork
== Series Details == Series: series starting with [1/3,V2] lib: fix match_string() helper on -1 array size URL : https://patchwork.freedesktop.org/series/61280/ State : warning == Summary == $ dim checkpatch origin/drm-tip 890a21a6b6b3 lib: fix match_string() helper on -1 array size

[Intel-gfx] [PATCH] drm/i915/gvt: remove duplicate entry of trace

2019-05-28 Thread Hariprasad Kelam
Remove duplicate include of trace.h Issue identified by includecheck Signed-off-by: Hariprasad Kelam --- drivers/gpu/drm/i915/gvt/trace_points.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/trace_points.c b/drivers/gpu/drm/i915/gvt/trace_points.c index

[Intel-gfx] [PATCH 1/3][V2] lib: fix match_string() helper on -1 array size

2019-05-28 Thread Alexandru Ardelean
The documentation the `_match_string()` helper mentions that `n` should be: * @n: number of strings in the array or -1 for NULL terminated arrays The behavior of the function is different, in the sense that it exits on the first NULL element in the array, regardless of whether `n` is -1 or a

[Intel-gfx] [PATCH 3/3][V2] lib: re-introduce new match_string() helper/macro

2019-05-28 Thread Alexandru Ardelean
This change re-introduces `match_string()` as a macro that uses ARRAY_SIZE() to compute the size of the array. After this change, work can start on migrating subsystems to use this new helper. Since the original helper is pretty used, migrating to this new one will take a while, and will be

[Intel-gfx] [PATCH 2/3][V2] treewide: rename match_string() -> __match_string()

2019-05-28 Thread Alexandru Ardelean
This change does a rename of match_string() -> __match_string(). There are a few parts to the intention here (with this change): 1. Align with sysfs_match_string()/__sysfs_match_string() 2. This helps to group users of `match_string()`: a. those that use ARRAY_SIZE(_a) to specify the number of

Re: [Intel-gfx] [PATCH v5 2/2] drm/i915: add in-kernel blitter client

2019-05-28 Thread Chris Wilson
Quoting Chris Wilson (2019-05-28 21:52:04) > Quoting Matthew Auld (2019-05-28 20:57:24) > Tons of XXX to be worked on, but that is the point of the patch: to > start spelling out the work that needs to be done for this approach to > even work. And there's plenty more layers we need to add tests as

Re: [Intel-gfx] [PATCH] drm/i915: Fix off-by-one in looking up icl sseu slice

2019-05-28 Thread Summers, Stuart
On Tue, 2019-05-28 at 23:05 +0100, Chris Wilson wrote: > Quoting Chris Wilson (2019-05-28 23:03:16) > > Quoting Summers, Stuart (2019-05-28 21:45:05) > > > On Tue, 2019-05-28 at 21:06 +0100, Chris Wilson wrote: > > > > We want the index corresponding to the set bit but fls() > > > > returns the >

Re: [Intel-gfx] [PATCH] drm/i915: Fix off-by-one in looking up icl sseu slice

2019-05-28 Thread Chris Wilson
Quoting Chris Wilson (2019-05-28 23:03:16) > Quoting Summers, Stuart (2019-05-28 21:45:05) > > On Tue, 2019-05-28 at 21:06 +0100, Chris Wilson wrote: > > > We want the index corresponding to the set bit but fls() returns the > > > 1-index value. > > > > > > Otherwise, we trigger the sanitycheck >

Re: [Intel-gfx] [PATCH] drm/i915: Fix off-by-one in looking up icl sseu slice

2019-05-28 Thread Chris Wilson
Quoting Summers, Stuart (2019-05-28 21:45:05) > On Tue, 2019-05-28 at 21:06 +0100, Chris Wilson wrote: > > We want the index corresponding to the set bit but fls() returns the > > 1-index value. > > > > Otherwise, we trigger the sanitycheck > > intel_sseu_get_subslices:46 GEM_BUG_ON(slice

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix off-by-one in looking up icl sseu slice

2019-05-28 Thread Patchwork
== Series Details == Series: drm/i915: Fix off-by-one in looking up icl sseu slice URL : https://patchwork.freedesktop.org/series/61276/ State : success == Summary == CI Bug Log - changes from CI_DRM_6159 -> Patchwork_13119 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v5,1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range

2019-05-28 Thread Patchwork
== Series Details == Series: series starting with [v5,1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range URL : https://patchwork.freedesktop.org/series/61275/ State : success == Summary == CI Bug Log - changes from CI_DRM_6159 -> Patchwork_13118

Re: [Intel-gfx] [PATCH v5 2/2] drm/i915: add in-kernel blitter client

2019-05-28 Thread Chris Wilson
Quoting Matthew Auld (2019-05-28 20:57:24) > The plan is to use the blitter engine for async object clearing when > using local memory, but before we can move the worker to get_pages() we > have to first tame some more of our struct_mutex usage. With this in > mind we should be able to upstream

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v5,1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range

2019-05-28 Thread Patchwork
== Series Details == Series: series starting with [v5,1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range URL : https://patchwork.freedesktop.org/series/61275/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/gtt: grab wakeref in

Re: [Intel-gfx] [PATCH] drm/i915: Fix off-by-one in looking up icl sseu slice

2019-05-28 Thread Summers, Stuart
On Tue, 2019-05-28 at 21:06 +0100, Chris Wilson wrote: > We want the index corresponding to the set bit but fls() returns the > 1-index value. > > Otherwise, we trigger the sanitycheck > intel_sseu_get_subslices:46 GEM_BUG_ON(slice >= sseu- > >max_slices) > when we look up the invalid

Re: [Intel-gfx] [PATCH v5 2/2] drm/i915: add in-kernel blitter client

2019-05-28 Thread Changqing Tang
On Tue, 2019-05-28 at 20:57 +0100, Matthew Auld wrote: > The plan is to use the blitter engine for async object clearing when > using local memory, but before we can move the worker to get_pages() > we > have to first tame some more of our struct_mutex usage. With this in > mind we should be able

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v5,1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range

2019-05-28 Thread Patchwork
== Series Details == Series: series starting with [v5,1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range URL : https://patchwork.freedesktop.org/series/61275/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1cddd0a982f8 drm/i915/gtt: grab wakeref in gen6_alloc_va_range

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Track the purgeable objects on a separate eviction list

2019-05-28 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Track the purgeable objects on a separate eviction list URL : https://patchwork.freedesktop.org/series/61273/ State : success == Summary == CI Bug Log - changes from CI_DRM_6159 -> Patchwork_13117

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Track the purgeable objects on a separate eviction list

2019-05-28 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Track the purgeable objects on a separate eviction list URL : https://patchwork.freedesktop.org/series/61273/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Track the

[Intel-gfx] [PATCH] drm/i915: Fix off-by-one in looking up icl sseu slice

2019-05-28 Thread Chris Wilson
We want the index corresponding to the set bit but fls() returns the 1-index value. Otherwise, we trigger the sanitycheck intel_sseu_get_subslices:46 GEM_BUG_ON(slice >= sseu->max_slices) when we look up the invalid slice. The only remaining question then is just how reliable the rest of

[Intel-gfx] [PATCH v5 2/2] drm/i915: add in-kernel blitter client

2019-05-28 Thread Matthew Auld
The plan is to use the blitter engine for async object clearing when using local memory, but before we can move the worker to get_pages() we have to first tame some more of our struct_mutex usage. With this in mind we should be able to upstream the object clearing as some selftests, which should

[Intel-gfx] [PATCH v5 1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range

2019-05-28 Thread Matthew Auld
Some steps in gen6_alloc_va_range require the HW to be awake, so ideally we should be grabbing the wakeref ourselves and not relying on the caller already holding it for us. Suggested-by: Chris Wilson Signed-off-by: Matthew Auld Reviewed-by: Chris Wilson ---

[Intel-gfx] [PATCH 2/2] drm/i915: Report all objects with allocated pages to the shrinker

2019-05-28 Thread Chris Wilson
Currently, we try to report to the shrinker the precise number of objects (pages) that are available to be reaped at this moment. This requires searching all objects with allocated pages to see if they fulfill the search criteria, and this count is performed quite frequently. (The shrinker tries

[Intel-gfx] [PATCH 1/2] drm/i915: Track the purgeable objects on a separate eviction list

2019-05-28 Thread Chris Wilson
Currently the purgeable objects, I915_MADV_DONTNEED, as mixed in the normal bound/unbound lists. Every shrinker pass starts with an attempt to purge from this set of unneeded objects, which entails us doing a walk over both lists looking for any candidates. If there are none, and since we are

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,01/15] drm/i915: Split GEM object type definition to its own header

2019-05-28 Thread Patchwork
== Series Details == Series: series starting with [CI,01/15] drm/i915: Split GEM object type definition to its own header URL : https://patchwork.freedesktop.org/series/61238/ State : success == Summary == CI Bug Log - changes from CI_DRM_6155_full -> Patchwork_13113_full

Re: [Intel-gfx] [CI 0/5] Refactor to expand subslice mask

2019-05-28 Thread Summers, Stuart
On Tue, 2019-05-28 at 11:32 -0700, Manasi Navare wrote: > Pushed to dinq, thanks for the patches and the reviews! Thanks for the push Manasi and the reviews Daniele and others! -Stuart > > Regards > Manasi > > On Fri, May 24, 2019 at 08:40:17AM -0700, Stuart Summers wrote: > > This patch

Re: [Intel-gfx] [CI 0/5] Refactor to expand subslice mask

2019-05-28 Thread Manasi Navare
Pushed to dinq, thanks for the patches and the reviews! Regards Manasi On Fri, May 24, 2019 at 08:40:17AM -0700, Stuart Summers wrote: > This patch series contains a few code clean-up patches, followed > by a patch which changes the storage of the subslice mask to better > match the userspace

[Intel-gfx] ✓ Fi.CI.IGT: success for fbcon notifier begone v3!

2019-05-28 Thread Patchwork
== Series Details == Series: fbcon notifier begone v3! URL : https://patchwork.freedesktop.org/series/61236/ State : success == Summary == CI Bug Log - changes from CI_DRM_6155_full -> Patchwork_13112_full Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add debugs for the C8 vs. legacy LUT case

2019-05-28 Thread Ville Syrjälä
On Tue, May 28, 2019 at 12:51:04PM +0200, Maarten Lankhorst wrote: > Op 13-05-2019 om 15:39 schreef Ville Syrjala: > > From: Ville Syrjälä > > > > Leave a hint in dmesg when we reject a configuration attempting > > to use C8 planes without the legacy LUT loaded. > > > > Signed-off-by: Ville

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Kill the undead intel_context.c zombie

2019-05-28 Thread Patchwork
== Series Details == Series: drm/i915: Kill the undead intel_context.c zombie URL : https://patchwork.freedesktop.org/series/61233/ State : success == Summary == CI Bug Log - changes from CI_DRM_6155_full -> Patchwork_13111_full Summary

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Avoid refcount_inc on known zero count

2019-05-28 Thread Patchwork
== Series Details == Series: drm/i915: Avoid refcount_inc on known zero count URL : https://patchwork.freedesktop.org/series/61255/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6157 -> Patchwork_13116 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/dp: Add DP_DPCD_QUIRK_NO_SINK_COUNT

2019-05-28 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/dp: Add DP_DPCD_QUIRK_NO_SINK_COUNT URL : https://patchwork.freedesktop.org/series/61248/ State : success == Summary == CI Bug Log - changes from CI_DRM_6156 -> Patchwork_13115

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Take a runtime pm wakeref for atomic commits

2019-05-28 Thread Patchwork
== Series Details == Series: drm/i915: Take a runtime pm wakeref for atomic commits URL : https://patchwork.freedesktop.org/series/61229/ State : success == Summary == CI Bug Log - changes from CI_DRM_6155_full -> Patchwork_13110_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/dp: Add DP_DPCD_QUIRK_NO_SINK_COUNT

2019-05-28 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/dp: Add DP_DPCD_QUIRK_NO_SINK_COUNT URL : https://patchwork.freedesktop.org/series/61248/ State : warning == Summary == $ dim checkpatch origin/drm-tip 87fb0e570f06 drm/dp: Add DP_DPCD_QUIRK_NO_SINK_COUNT -:30: WARNING:LONG_LINE:

[Intel-gfx] [PATCH] drm/i915: Avoid refcount_inc on known zero count

2019-05-28 Thread Chris Wilson
In intel_wakeref_auto, we use refcount_inc_not_zero to detect the first use and initialise the timer. On doing so, we have to avoid using refcount_inc on that zero count as the debug code flags that as an error: refcount_t: increment on 0; use-after-free. Rearrange the code so that if we

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/9] drm/i915: Move object close under its own lock

2019-05-28 Thread Patchwork
== Series Details == Series: series starting with [1/9] drm/i915: Move object close under its own lock URL : https://patchwork.freedesktop.org/series/61243/ State : success == Summary == CI Bug Log - changes from CI_DRM_6156 -> Patchwork_13114

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Move intel_add_dsi_properties to intel_dsi

2019-05-28 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Move intel_add_dsi_properties to intel_dsi URL : https://patchwork.freedesktop.org/series/61228/ State : success == Summary == CI Bug Log - changes from CI_DRM_6155_full -> Patchwork_13109_full

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/9] drm/i915: Move object close under its own lock

2019-05-28 Thread Patchwork
== Series Details == Series: series starting with [1/9] drm/i915: Move object close under its own lock URL : https://patchwork.freedesktop.org/series/61243/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Move object close under its own lock

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/9] drm/i915: Move object close under its own lock

2019-05-28 Thread Patchwork
== Series Details == Series: series starting with [1/9] drm/i915: Move object close under its own lock URL : https://patchwork.freedesktop.org/series/61243/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6a2a276d9e22 drm/i915: Move object close under its own lock 729976726d60

Re: [Intel-gfx] [PATCH] drm/i915: Take a runtime pm wakeref for atomic commits

2019-05-28 Thread Ville Syrjälä
On Tue, May 28, 2019 at 08:53:54AM +0100, Chris Wilson wrote: > Before we start prepping the system for an atomic modeset, wake the > device up. We then keep track of this wakeref until we complete the > atomic commit, so we hold keep the device awake for all potential HW > access, and do not

[Intel-gfx] [PATCH 1/2] drm/dp: Add DP_DPCD_QUIRK_NO_SINK_COUNT

2019-05-28 Thread Ville Syrjala
From: Ville Syrjälä CH7511 eDP->LVDS bridge doesn't seem to set SINK_COUNT properly causing i915 to detect it as disconnected. Add a quirk to ignore SINK_COUNT on these devices. Cc: David S. Cc: Peteris Rudzusiks Tested-by: Peteris Rudzusiks Bugzilla:

[Intel-gfx] [PATCH 2/2] drm/i915: Skip SINK_COUNT read on CH7511

2019-05-28 Thread Ville Syrjala
From: Ville Syrjälä CH7511 doesn't update SINK_COUNT properly so in order to detect the device as connected we have to ignore SINK_COUNT. In order to have access to the quirk list early enough we must move the drm_dp_read_desc() call to happen earlier. We can also skip re-reading this on eDP

[Intel-gfx] [PATCH 3/9] drm/i915: Stop retiring along engine

2019-05-28 Thread Chris Wilson
We no longer track the execution order along the engine and so no longer need to enforce ordering of retire along the engine. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_request.c | 128 +++- 1 file changed, 52 insertions(+), 76 deletions(-) diff --git

[Intel-gfx] [PATCH 6/9] drm/i915/execlists: Preempt-to-busy

2019-05-28 Thread Chris Wilson
When using a global seqno, we required a precise stop-the-workd event to handle preemption and unwind the global seqno counter. To accomplish this, we would preempt to a special out-of-band context and wait for the machine to report that it was idle. Given an idle machine, we could very precisely

[Intel-gfx] [PATCH 5/9] drm/i915: Flush the execution-callbacks on retiring

2019-05-28 Thread Chris Wilson
In the unlikely case the request completes while we regard it as not even executing on the GPU (see the next patch!), we have to flush any pending execution callbacks at retirement and ensure that we do not add any more. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_request.c | 93

[Intel-gfx] [PATCH 9/9] drm/i915: Add a label for config DRM_I915_SPIN_REQUEST

2019-05-28 Thread Chris Wilson
If we don't give it a label, it does not appear as a configuration option. Signed-off-by: Chris Wilson Cc: Mika Kuoppala --- drivers/gpu/drm/i915/Kconfig.profile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/Kconfig.profile

[Intel-gfx] [PATCH 1/9] drm/i915: Move object close under its own lock

2019-05-28 Thread Chris Wilson
Use i915_gem_object_lock() to guard the LUT and active reference to allow us to break free of struct_mutex for handling GEM_CLOSE. Testcase: igt/gem_close_race Testcase: igt/gem_exec_parallel Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 75 ++-

[Intel-gfx] [PATCH 4/9] drm/i915: Replace engine->timeline with a plain list

2019-05-28 Thread Chris Wilson
To continue the onslaught of removing the assumption of a global execution ordering, another casualty is the engine->timeline. Without an actual timeline to track, it is overkill and we can replace it with a much less grand plain list. We still need a list of requests inflight, for the simple

[Intel-gfx] [PATCH 8/9] drm/i915/execlists: Force preemption

2019-05-28 Thread Chris Wilson
If the preempted context takes too long to relinquish control, e.g. it is stuck inside a shader with arbitration disabled, evict that context with an engine reset. This ensures that preemptions are reasonably responsive, providing a tighter QoS for the more important context at the cost of

[Intel-gfx] [PATCH 2/9] drm/i915: Keep contexts pinned until after the next kernel context switch

2019-05-28 Thread Chris Wilson
We need to keep the context image pinned in memory until after the GPU has finished writing into it. Since it continues to write as we signal the final breadcrumb, we need to keep it pinned until the request after it is complete. Currently we know the order in which requests execute on each

[Intel-gfx] [PATCH 7/9] drm/i915/execlists: Minimalistic timeslicing

2019-05-28 Thread Chris Wilson
If we have multiple contexts of equal priority pending execution, activate a timer to demote the currently executing context in favour of the next in the queue when that timeslice expires. This enforces fairness between contexts (so long as they allow preemption -- forced preemption, in the

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,01/15] drm/i915: Split GEM object type definition to its own header

2019-05-28 Thread Patchwork
== Series Details == Series: series starting with [CI,01/15] drm/i915: Split GEM object type definition to its own header URL : https://patchwork.freedesktop.org/series/61238/ State : success == Summary == CI Bug Log - changes from CI_DRM_6155 -> Patchwork_13113

Re: [Intel-gfx] [PATCH v2 1/7] drm: make drm/drm_auth.h self contained

2019-05-28 Thread Sam Ravnborg
Hi Jani. On Tue, May 28, 2019 at 03:54:48PM +0300, Jani Nikula wrote: > On Sun, 26 May 2019, Sam Ravnborg wrote: > > Do not require users of include/drm/drm_auth.h to include > > other files just to let it build. > > > > Signed-off-by: Sam Ravnborg > > Cc: Maarten Lankhorst > > Cc: Maxime

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: C8 fix

2019-05-28 Thread Ville Syrjälä
On Mon, May 13, 2019 at 09:40:47PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: C8 fix > URL : https://patchwork.freedesktop.org/series/60583/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_6077_full -> Patchwork_13008_full >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,01/15] drm/i915: Split GEM object type definition to its own header

2019-05-28 Thread Patchwork
== Series Details == Series: series starting with [CI,01/15] drm/i915: Split GEM object type definition to its own header URL : https://patchwork.freedesktop.org/series/61238/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Split GEM object

Re: [Intel-gfx] [PATCH v2 1/7] drm: make drm/drm_auth.h self contained

2019-05-28 Thread Jani Nikula
On Sun, 26 May 2019, Sam Ravnborg wrote: > Do not require users of include/drm/drm_auth.h to include > other files just to let it build. > > Signed-off-by: Sam Ravnborg > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > --- >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,01/15] drm/i915: Split GEM object type definition to its own header

2019-05-28 Thread Patchwork
== Series Details == Series: series starting with [CI,01/15] drm/i915: Split GEM object type definition to its own header URL : https://patchwork.freedesktop.org/series/61238/ State : warning == Summary == $ dim checkpatch origin/drm-tip 754614561b92 drm/i915: Split GEM object type

Re: [Intel-gfx] [PATCH] drm/i915: We don't need display's suspend/resume operations when !HAS_DISPLAY

2019-05-28 Thread Jani Nikula
On Thu, 23 May 2019, Rodrigo Vivi wrote: > Suspend resume is broken if we try to enable/disable dc9 on > cases with disabled displays. > > v2: Make checkpatch happy: > - braces {} are not necessary for single statement blocks > > v3: Also move hsw/bdw PC8 sequences since they are related to >

[Intel-gfx] ✓ Fi.CI.BAT: success for fbcon notifier begone v3!

2019-05-28 Thread Patchwork
== Series Details == Series: fbcon notifier begone v3! URL : https://patchwork.freedesktop.org/series/61236/ State : success == Summary == CI Bug Log - changes from CI_DRM_6155 -> Patchwork_13112 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for fbcon notifier begone v3!

2019-05-28 Thread Patchwork
== Series Details == Series: fbcon notifier begone v3! URL : https://patchwork.freedesktop.org/series/61236/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: dummycon: Sprinkle locking checks Okay! Commit: fbdev: locking check for fb_set_suspend Okay!

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Kill the undead intel_context.c zombie

2019-05-28 Thread Patchwork
== Series Details == Series: drm/i915: Kill the undead intel_context.c zombie URL : https://patchwork.freedesktop.org/series/61233/ State : success == Summary == CI Bug Log - changes from CI_DRM_6155 -> Patchwork_13111 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Take a runtime pm wakeref for atomic commits

2019-05-28 Thread Patchwork
== Series Details == Series: drm/i915: Take a runtime pm wakeref for atomic commits URL : https://patchwork.freedesktop.org/series/61229/ State : success == Summary == CI Bug Log - changes from CI_DRM_6155 -> Patchwork_13110 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for fbcon notifier begone v3!

2019-05-28 Thread Patchwork
== Series Details == Series: fbcon notifier begone v3! URL : https://patchwork.freedesktop.org/series/61236/ State : warning == Summary == $ dim checkpatch origin/drm-tip cebafaf0747f dummycon: Sprinkle locking checks -:47: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Kill the undead intel_context.c zombie

2019-05-28 Thread Patchwork
== Series Details == Series: drm/i915: Kill the undead intel_context.c zombie URL : https://patchwork.freedesktop.org/series/61233/ State : warning == Summary == $ dim checkpatch origin/drm-tip eec739775d20 drm/i915: Kill the undead intel_context.c zombie -:13: WARNING:FILE_PATH_CHANGES:

Re: [Intel-gfx] [v11 00/12] Add HDR Metadata Parsing and handling in DRM layer

2019-05-28 Thread Shankar, Uma
>-Original Message- >From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] >Sent: Tuesday, May 28, 2019 5:06 PM >To: Ville Syrjälä ; Shankar, Uma > >Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Sharma, >Shashank ; emil.l.veli...@gmail.com;

Re: [Intel-gfx] [v11 00/12] Add HDR Metadata Parsing and handling in DRM layer

2019-05-28 Thread Maarten Lankhorst
Op 22-05-2019 om 22:45 schreef Ville Syrjälä: > On Thu, May 16, 2019 at 07:40:05PM +0530, Uma Shankar wrote: >> This patch series enables HDR support in drm. It basically defines >> HDR metadata structures, property to pass content (after blending) >> metadata from user space compositors to

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Move intel_add_dsi_properties to intel_dsi

2019-05-28 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Move intel_add_dsi_properties to intel_dsi URL : https://patchwork.freedesktop.org/series/61228/ State : success == Summary == CI Bug Log - changes from CI_DRM_6155 -> Patchwork_13109

Re: [Intel-gfx] [PATCH] drm/i915: Kill the undead intel_context.c zombie

2019-05-28 Thread Jani Nikula
On Tue, 28 May 2019, Chris Wilson wrote: > It was moved over to gt/ but the backmerge brought it back from the dead. Whoops, mea culpa. Reviewed-by: Jani Nikula > > Signed-off-by: Chris Wilson > Cc: Jani Nikula > --- > drivers/gpu/drm/i915/intel_context.c | 270 ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Move intel_add_dsi_properties to intel_dsi

2019-05-28 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Move intel_add_dsi_properties to intel_dsi URL : https://patchwork.freedesktop.org/series/61228/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5341f16a84b3 drm/i915: Move intel_add_dsi_properties to intel_dsi

Re: [Intel-gfx] [PATCH 4/5] drm/i915: add a new perf configuration execbuf parameter

2019-05-28 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-05-21 15:08:54) > @@ -2048,6 +2081,42 @@ static int eb_submit(struct i915_execbuffer *eb) > return err; > } if (eb->oa_config) { err = i915_active_request_set(>i915->perf.oa.oa_config_active,

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add debugs for the C8 vs. legacy LUT case

2019-05-28 Thread Maarten Lankhorst
Op 13-05-2019 om 15:39 schreef Ville Syrjala: > From: Ville Syrjälä > > Leave a hint in dmesg when we reject a configuration attempting > to use C8 planes without the legacy LUT loaded. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/intel_color.c | 4 +++- > 1 file changed, 3

Re: [Intel-gfx] [PATCH v5 00/17] GuC 32.0.3

2019-05-28 Thread Saarinen, Jani
Hi, > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Chris > Wilson > Sent: tiistai 28. toukokuuta 2019 12.46 > To: Latvala, Petri > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v5 00/17] GuC 32.0.3 > >

Re: [Intel-gfx] [CI] drm/i915: Keep user GGTT alive for a minimum of 250ms

2019-05-28 Thread Maarten Lankhorst
Op 28-05-2019 om 11:27 schreef Chris Wilson: > Quoting Maarten Lankhorst (2019-05-28 10:24:40) >> Op 27-05-2019 om 13:51 schreef Chris Wilson: >>> Do not allow runtime pm autosuspend to remove userspace GGTT mmaps too >>> quickly. For example, igt sets the autosuspend delay to 0, and so we >>>

Re: [Intel-gfx] [PATCH v5 00/17] GuC 32.0.3

2019-05-28 Thread Martin Peres
On 28/05/2019 12:45, Chris Wilson wrote: > Quoting Petri Latvala (2019-05-28 10:40:31) >> On Tue, May 28, 2019 at 10:23:24AM +0100, Chris Wilson wrote: >>> Quoting Michal Wajdeczko (2019-05-27 19:35:56) New GuC firmwares (for SKL, BXT, KBL, GLK, ICL) with updated ABI interface. >>> >>> All

Re: [Intel-gfx] [PATCH v5 00/17] GuC 32.0.3

2019-05-28 Thread Chris Wilson
Quoting Petri Latvala (2019-05-28 10:40:31) > On Tue, May 28, 2019 at 10:23:24AM +0100, Chris Wilson wrote: > > Quoting Michal Wajdeczko (2019-05-27 19:35:56) > > > New GuC firmwares (for SKL, BXT, KBL, GLK, ICL) with updated ABI > > > interface. > > > > All reviewed/acked, and I trust the

Re: [Intel-gfx] [PATCH v5 00/17] GuC 32.0.3

2019-05-28 Thread Petri Latvala
On Tue, May 28, 2019 at 10:23:24AM +0100, Chris Wilson wrote: > Quoting Michal Wajdeczko (2019-05-27 19:35:56) > > New GuC firmwares (for SKL, BXT, KBL, GLK, ICL) with updated ABI interface. > > All reviewed/acked, and I trust the failures will be fixed in time, so > pushed. Thanks. > -Chris

[Intel-gfx] [CI 05/15] drm/i915: Move phys objects to its own file

2019-05-28 Thread Chris Wilson
Continuing the decluttering of i915_gem.c, this time the legacy physical object. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/Makefile | 2 + drivers/gpu/drm/i915/gem/i915_gem_object.h| 11 +- .../gpu/drm/i915/gem/i915_gem_object_types.h

[Intel-gfx] [CI 11/15] drm/i915: Move GEM object waiting to its own file

2019-05-28 Thread Chris Wilson
Continuing the decluttering of i915_gem.c by moving the object wait decomposition into its own file. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/gem/i915_gem_object.h | 8 +

[Intel-gfx] [CI 10/15] drm/i915: Move GEM object domain management from struct_mutex to local

2019-05-28 Thread Chris Wilson
Use the per-object local lock to control the cache domain of the individual GEM objects, not struct_mutex. This is a huge leap forward for us in terms of object-level synchronisation; execbuffers are coordinated using the ww_mutex and pread/pwrite is finally fully serialised again. Signed-off-by:

[Intel-gfx] [CI 04/15] drm/i915: Move shmem object setup to its own file

2019-05-28 Thread Chris Wilson
Split the plain old shmem object into its own file to start decluttering i915_gem.c v2: Lose the confusing, hysterical raisins, suffix of _gtt. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/Makefile | 3 +-

[Intel-gfx] [CI 01/15] drm/i915: Split GEM object type definition to its own header

2019-05-28 Thread Chris Wilson
For convenience in avoiding inline spaghetti, keep the type definition as a separate header. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld Acked-by: Rodrigo Vivi Acked-by: Jani Nikula Acked-by: Joonas Lahtinen --- drivers/gpu/drm/i915/Makefile | 1 +

[Intel-gfx] [CI 14/15] drm/i915: Rename intel_context.active to .inflight

2019-05-28 Thread Chris Wilson
Rename the engine this HW context is currently active upon (that we are flying upon) to disambiguate between the mixture of different active terms (and prevent conflict in future patches). Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_context_types.h

[Intel-gfx] [CI 15/15] drm/i915: Drop the deferred active reference

2019-05-28 Thread Chris Wilson
An old optimisation to reduce the number of atomics per batch sadly relies on struct_mutex for coordination. In order to remove struct_mutex from serialising object/context closing, always taking and releasing an active reference on first use / last use greatly simplifies the locking.

[Intel-gfx] [CI 12/15] drm/i915: Move GEM object busy checking to its own file

2019-05-28 Thread Chris Wilson
Continuing the decluttering of i915_gem.c by moving the object busy checking into its own file. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/gem/i915_gem_busy.c | 138 +++

[Intel-gfx] [CI 09/15] drm/i915: Pull scatterlist utils out of i915_gem.h

2019-05-28 Thread Chris Wilson
Out scatterlist utility routines can be pulled out of i915_gem.h for a bit more decluttering. v2: Push I915_GTT_PAGE_SIZE out of i915_scatterlist itself and into the caller. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/Makefile | 1 +

[Intel-gfx] [CI 06/15] drm/i915: Move mmap and friends to its own file

2019-05-28 Thread Chris Wilson
Continuing the decluttering of i915_gem.c, now the turn of do_mmap and the faulthandlers Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/gem/i915_gem_mman.c | 507

[Intel-gfx] [CI 02/15] drm/i915: Pull GEM ioctls interface to its own file

2019-05-28 Thread Chris Wilson
Declutter i915_drv/gem.h by moving the ioctl API into its own header. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_ioctls.h | 52 ++ drivers/gpu/drm/i915/i915_drv.c| 1 + drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [CI 07/15] drm/i915: Move GEM domain management to its own file

2019-05-28 Thread Chris Wilson
Continuing the decluttering of i915_gem.c, that of the read/write domains, perhaps the biggest of GEM's follies? Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/gem/i915_gem_domain.c| 782

[Intel-gfx] [CI 03/15] drm/i915: Move object->pages API to i915_gem_object.[ch]

2019-05-28 Thread Chris Wilson
Currently the code for manipulating the pages on an object is still residing in i915_gem.c, move it to i915_gem_object.c Signed-off-by: Chris Wilson Cc: Joonas Lahtinen Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/Makefile | 4 +- .../gpu/drm/i915/{ =>

[Intel-gfx] [CI 08/15] drm/i915: Move more GEM objects under gem/

2019-05-28 Thread Chris Wilson
Continuing the theme of separating out the GEM clutter. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/Makefile | 26 +-- drivers/gpu/drm/i915/Makefile.header-test | 2 - .../gpu/drm/i915/{ => gem}/i915_gem_clflush.c | 24 ++

[Intel-gfx] [CI 13/15] drm/i915: Move GEM client throttling to its own file

2019-05-28 Thread Chris Wilson
Continuing the decluttering of i915_gem.c by moving the client self throttling into its own file. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/gem/i915_gem_throttle.c | 73

Re: [Intel-gfx] [CI] drm/i915: Keep user GGTT alive for a minimum of 250ms

2019-05-28 Thread Chris Wilson
Quoting Maarten Lankhorst (2019-05-28 10:24:40) > Op 27-05-2019 om 13:51 schreef Chris Wilson: > > Do not allow runtime pm autosuspend to remove userspace GGTT mmaps too > > quickly. For example, igt sets the autosuspend delay to 0, and so we > > immediately attempt to perform runtime suspend upon

Re: [Intel-gfx] [CI] drm/i915: Keep user GGTT alive for a minimum of 250ms

2019-05-28 Thread Maarten Lankhorst
Op 27-05-2019 om 13:51 schreef Chris Wilson: > Do not allow runtime pm autosuspend to remove userspace GGTT mmaps too > quickly. For example, igt sets the autosuspend delay to 0, and so we > immediately attempt to perform runtime suspend upon releasing the > wakeref. Unfortunately, that involves

Re: [Intel-gfx] [PATCH v5 00/17] GuC 32.0.3

2019-05-28 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-05-27 19:35:56) > New GuC firmwares (for SKL, BXT, KBL, GLK, ICL) with updated ABI interface. All reviewed/acked, and I trust the failures will be fixed in time, so pushed. Thanks. -Chris ___ Intel-gfx mailing list

[Intel-gfx] [PATCH 31/33] fbcon: Document what I learned about fbcon locking

2019-05-28 Thread Daniel Vetter
It's not pretty. Signed-off-by: Daniel Vetter Reviewed-by: Sam Ravnborg Reviewed-by: Maarten Lankhorst Cc: Daniel Vetter Cc: Bartlomiej Zolnierkiewicz Cc: Hans de Goede Cc: Yisheng Xie --- drivers/video/fbdev/core/fbcon.c | 19 +++ 1 file changed, 19 insertions(+) diff

[Intel-gfx] [PATCH 33/33] backlight: simplify lcd notifier

2019-05-28 Thread Daniel Vetter
With all the work I've done on replacing fb notifier calls with direct calls into fbcon the backlight/lcd notifier is the only user left. It will only receive events now that it cares about, hence we can remove this check. Signed-off-by: Daniel Vetter Reviewed-by: Sam Ravnborg Reviewed-by:

[Intel-gfx] [PATCH 30/33] fbcon: Call con2fb_map functions directly

2019-05-28 Thread Daniel Vetter
These are actually fbcon ioctls which just happen to be exposed through /dev/fb*. They completely ignore which fb_info they're called on, and I think the userspace tool even hardcodes to /dev/fb0. Hence just forward the entire thing to fbcon.c wholesale. Note that this patch drops the

[Intel-gfx] [PATCH 32/33] staging/olpc_dcon: Add drm conversion to TODO

2019-05-28 Thread Daniel Vetter
this driver is pretty horrible from a design pov, and needs a complete overhaul. Concrete thing that annoys me is that it looks at registered_fb, which is an internal thing to fbmem.c and fbcon.c. And ofc it gets the lifetime rules all wrong (it should at least use get/put_fb_info). Looking at

  1   2   >