Re: [Intel-gfx] [PATCH 1/6] drm/i915: Fix GEN8_MCR_SELECTOR programming

2019-07-17 Thread Tvrtko Ursulin
On 17/07/2019 22:25, Summers, Stuart wrote: On Wed, 2019-07-17 at 19:06 +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Not opposed to this exactly, but do we really need this patch if we're just getting rid of this routine later in the series? It just happens this fix alone is enough

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/vbt: Fix VBT parsing for the PSR section (rev3)

2019-07-17 Thread Patchwork
== Series Details == Series: drm/i915/vbt: Fix VBT parsing for the PSR section (rev3) URL : https://patchwork.freedesktop.org/series/63774/ State : success == Summary == CI Bug Log - changes from CI_DRM_6502_full -> Patchwork_13678_full

Re: [Intel-gfx] [PATCH 21/22] drm/i915/tgl: Add and use new DC5 and DC6 residency counter registers

2019-07-17 Thread Anshuman Gupta
On 2019-07-12 at 18:09:39 -0700, Lucas De Marchi wrote: > From: José Roberto de Souza > > Tiger Lask has a new register offset for DC5 and DC6 residency counters. > > Signed-off-by: José Roberto de Souza > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i915/i915_debugfs.c | 21

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v10,1/2] drm/i915: Introduce async plane update to i915

2019-07-17 Thread Patchwork
== Series Details == Series: series starting with [v10,1/2] drm/i915: Introduce async plane update to i915 URL : https://patchwork.freedesktop.org/series/63835/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6502_full -> Patchwork_13677_full

Re: [Intel-gfx] [PATCH] drm/i915: Add HDCP capability info to i915_display_info.

2019-07-17 Thread Ramalingam C
On 2019-07-17 at 19:50:18 +0530, Anshuman Gupta wrote: > To identify the HDCP capability of the display connected to CI > systems, we need to add the hdcp capability probing in i915_display_info. > > This will also help to populate the HDCP capability of the CI systems > to CI H/W logs maintained

[Intel-gfx] ✓ Fi.CI.IGT: success for MCR fixes and more

2019-07-17 Thread Patchwork
== Series Details == Series: MCR fixes and more URL : https://patchwork.freedesktop.org/series/63831/ State : success == Summary == CI Bug Log - changes from CI_DRM_6502_full -> Patchwork_13676_full Summary --- **SUCCESS** No

[Intel-gfx] [PATCH 24/26] drm/dp_mst: Add basic topology reprobing when resuming

2019-07-17 Thread Lyude Paul
Finally! For a very long time, our MST helpers have had one very annoying issue: They don't know how to reprobe the topology state when coming out of suspend. This means that if a user has a machine connected to an MST topology and decides to suspend their machine, we lose all topology changes

[Intel-gfx] [PATCH 00/26] DP MST Refactors + debugging tools + suspend/resume reprobing

2019-07-17 Thread Lyude Paul
This is the large series for adding MST suspend/resume reprobing that I've been working on for quite a while now. In addition, I: - Refactored and cleaned up any code I ended up digging through in the process of understanding how some parts of these helpers worked. - Added some debugging tools

Re: [Intel-gfx] [PATCH] drm/i915/vbt: Fix VBT parsing for the PSR section

2019-07-17 Thread Pandiyan, Dhinakaran
On Wed, 2019-07-17 at 14:35 +0300, Ville Syrjälä wrote: > On Tue, Jul 16, 2019 at 03:03:21PM -0700, Dhinakaran Pandiyan wrote: > > A single 32-bit PSR2 training pattern field follows the sixteen element > > array of PSR table entries in the VBT spec. But, we incorrectly define > > this PSR2 field

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/vbt: Fix VBT parsing for the PSR section (rev3)

2019-07-17 Thread Patchwork
== Series Details == Series: drm/i915/vbt: Fix VBT parsing for the PSR section (rev3) URL : https://patchwork.freedesktop.org/series/63774/ State : success == Summary == CI Bug Log - changes from CI_DRM_6502 -> Patchwork_13678 Summary

[Intel-gfx] [PATCH] drm/i915/vbt: Fix VBT parsing for the PSR section

2019-07-17 Thread Dhinakaran Pandiyan
A single 32-bit PSR2 training pattern field follows the sixteen element array of PSR table entries in the VBT spec. But, we incorrectly define this PSR2 field for each of the PSR table entries. As a result, the PSR1 training pattern duration for any panel_type != 0 will be parsed incorrectly.

Re: [Intel-gfx] screen freeze with 5.2-rc6 Dell XPS-13 skylake i915

2019-07-17 Thread James Bottomley
On Wed, 2019-07-17 at 23:27 +0200, Paul Bolle wrote: > Hi Jose, > > Souza, Jose schreef op di 16-07-2019 om 16:32 [+]: > > Paul and James could you test this final solution(at least for > > 5.2)? Please revert the hack patch and apply this one. > > I've just reached a day of uptime with your

Re: [Intel-gfx] screen freeze with 5.2-rc6 Dell XPS-13 skylake i915

2019-07-17 Thread Paul Bolle
Hi Jose, Souza, Jose schreef op di 16-07-2019 om 16:32 [+]: > Paul and James could you test this final solution(at least for 5.2)? > Please revert the hack patch and apply this one. I've just reached a day of uptime with your revert. (The proper uptime is just a fraction of a day, this being

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Fix GEN8_MCR_SELECTOR programming

2019-07-17 Thread Summers, Stuart
On Wed, 2019-07-17 at 19:06 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin Not opposed to this exactly, but do we really need this patch if we're just getting rid of this routine later in the series? Thanks, Stuart > > fls returns bit positions starting from one for the lsb and the MCR >

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Fix and improve MCR selection logic

2019-07-17 Thread Summers, Stuart
On Wed, 2019-07-17 at 19:06 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > A couple issues were present in this code: > > 1. > fls() usage was incorrect causing off by one in subslice mask lookup, > which in other words means subslice mask of all zeroes is always used > (subslice mask

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Trust programmed MCR in read_subslice_reg

2019-07-17 Thread Summers, Stuart
On Wed, 2019-07-17 at 20:47 +, Summers, Stuart wrote: > On Wed, 2019-07-17 at 19:06 +0100, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > Instead of re-calculating the MCR selector in read_subslice_reg do > > the > > rwm on its existing value and restore it when done. > > > > This

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Trust programmed MCR in read_subslice_reg

2019-07-17 Thread Summers, Stuart
On Wed, 2019-07-17 at 19:06 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Instead of re-calculating the MCR selector in read_subslice_reg do > the > rwm on its existing value and restore it when done. > > This consolidates MCR programming to one place for cnl+, and avoids >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add HDCP capability info to i915_display_info.

2019-07-17 Thread Patchwork
== Series Details == Series: drm/i915: Add HDCP capability info to i915_display_info. URL : https://patchwork.freedesktop.org/series/63819/ State : success == Summary == CI Bug Log - changes from CI_DRM_6498_full -> Patchwork_13675_full

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v10,1/2] drm/i915: Introduce async plane update to i915

2019-07-17 Thread Patchwork
== Series Details == Series: series starting with [v10,1/2] drm/i915: Introduce async plane update to i915 URL : https://patchwork.freedesktop.org/series/63835/ State : success == Summary == CI Bug Log - changes from CI_DRM_6502 -> Patchwork_13677

Re: [Intel-gfx] drm/i915/vbt: Fix VBT parsing for the PSR section

2019-07-17 Thread François Guerraz
Tested-by: François Guerraz On Dell XPS 9350 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 6/6] drm/i915/icl: Add Wa_1409178092

2019-07-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-17 19:06:24) > From: Tvrtko Ursulin > > We were missing this workaround which can cause hangs if fine grained > coherency was used. > > Signed-off-by: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 ++ >

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Skip CS verification of L3 bank registers

2019-07-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-17 19:06:22) > From: Tvrtko Ursulin > > Access to 0xb100 - 0xb3ff mmio range is controlled by the MCR selector > which only affects CPU MMIO. Therefore these registers cannot be realiably > read with MI_SRM from the command streamer so skip their verification. >

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Fix and improve MCR selection logic

2019-07-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-17 19:06:21) > From: Tvrtko Ursulin > > A couple issues were present in this code: > > 1. > fls() usage was incorrect causing off by one in subslice mask lookup, > which in other words means subslice mask of all zeroes is always used > (subslice mask of a slice

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Trust programmed MCR in read_subslice_reg

2019-07-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-17 19:06:20) > From: Tvrtko Ursulin > > Instead of re-calculating the MCR selector in read_subslice_reg do the > rwm on its existing value and restore it when done. I successfully worked back from implementation to changelog. > > This consolidates MCR

[Intel-gfx] [PATCH v10 2/2] drm/i915: update cursors asynchronously through atomic

2019-07-17 Thread Helen Koike
From: Gustavo Padovan Replace the legacy cursor implementation by the async callbacks Signed-off-by: Gustavo Padovan Signed-off-by: Enric Balletbo i Serra Signed-off-by: Helen Koike --- Changes in v10: None Changes in v9: - v8: https://patchwork.kernel.org/patch/10843397/ - rebased and

[Intel-gfx] [PATCH v10 1/2] drm/i915: Introduce async plane update to i915

2019-07-17 Thread Helen Koike
From: Gustavo Padovan Add implementation for async plane update callbacks Signed-off-by: Gustavo Padovan Signed-off-by: Enric Balletbo i Serra Signed-off-by: Tina Zhang Signed-off-by: Helen Koike Tested-by: Tina Zhang --- Hi, This is v10, I just fixed the order in how the commit_ready

[Intel-gfx] ✓ Fi.CI.BAT: success for MCR fixes and more

2019-07-17 Thread Patchwork
== Series Details == Series: MCR fixes and more URL : https://patchwork.freedesktop.org/series/63831/ State : success == Summary == CI Bug Log - changes from CI_DRM_6502 -> Patchwork_13676 Summary --- **SUCCESS** No regressions

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for MCR fixes and more

2019-07-17 Thread Patchwork
== Series Details == Series: MCR fixes and more URL : https://patchwork.freedesktop.org/series/63831/ State : warning == Summary == $ dim checkpatch origin/drm-tip 53048f39ddd0 drm/i915: Fix GEN8_MCR_SELECTOR programming 9874e34931ae drm/i915: Trust programmed MCR in read_subslice_reg -:59:

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove obsolete engine clenaup (rev2)

2019-07-17 Thread Patchwork
== Series Details == Series: drm/i915: Remove obsolete engine clenaup (rev2) URL : https://patchwork.freedesktop.org/series/63791/ State : success == Summary == CI Bug Log - changes from CI_DRM_6498_full -> Patchwork_13673_full Summary

Re: [Intel-gfx] [PATCH 1/5] drm/i915/userptr: Beware recursive lock_page()

2019-07-17 Thread Tvrtko Ursulin
On 17/07/2019 15:06, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-17 14:46:15) On 17/07/2019 14:35, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-17 14:23:55) On 17/07/2019 14:17, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-17 14:09:00) On 16/07/2019 16:37, Chris

[Intel-gfx] [PATCH 6/6] drm/i915/icl: Add Wa_1409178092

2019-07-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We were missing this workaround which can cause hangs if fine grained coherency was used. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 ++ drivers/gpu/drm/i915/i915_reg.h | 3 +++ 2 files changed, 9 insertions(+) diff

[Intel-gfx] [PATCH 4/6] drm/i915: Skip CS verification of L3 bank registers

2019-07-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Access to 0xb100 - 0xb3ff mmio range is controlled by the MCR selector which only affects CPU MMIO. Therefore these registers cannot be realiably read with MI_SRM from the command streamer so skip their verification. Signed-off-by: Tvrtko Ursulin ---

[Intel-gfx] [PATCH 5/6] drm/i915/icl: Verify engine workarounds in GEN8_L3SQCREG4

2019-07-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Having fixed the incorect MCR programming in an earlier patch, we can now stop ignoring read back of GEN8_L3SQCREG4 during engine workaround verification. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 27

[Intel-gfx] [PATCH 3/6] drm/i915: Fix and improve MCR selection logic

2019-07-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A couple issues were present in this code: 1. fls() usage was incorrect causing off by one in subslice mask lookup, which in other words means subslice mask of all zeroes is always used (subslice mask of a slice which is not present, or even out of bounds array access),

[Intel-gfx] [PATCH 2/6] drm/i915: Trust programmed MCR in read_subslice_reg

2019-07-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Instead of re-calculating the MCR selector in read_subslice_reg do the rwm on its existing value and restore it when done. This consolidates MCR programming to one place for cnl+, and avoids re-calculating its default value on older platforms during hangcheck.

[Intel-gfx] [PATCH v2 0/6] MCR fixes and more

2019-07-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A few bugs in programming the MCR register sneaked in past code review. First of all fls() usage is wrong and suffers from off-by-one problem. Secondly the assert in WaProgramMgsrForL3BankSpecificMmioReads is also wrong due inverted logic. With MCR programming fixed we

[Intel-gfx] [PATCH 1/6] drm/i915: Fix GEN8_MCR_SELECTOR programming

2019-07-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin fls returns bit positions starting from one for the lsb and the MCR register expects zero based (sub)slice addressing. Incorrent MCR programming can have the effect of directing MMIO reads of registers in the 0xb100-0xb3ff range to invalid subslice returning zeroes instead

Re: [Intel-gfx] [PATCH 2/5] drm/i915/gt: Push engine stopping into reset-prepare

2019-07-17 Thread Tvrtko Ursulin
On 17/07/2019 14:56, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-17 14:42:15) On 17/07/2019 14:30, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-17 14:21:50) On 17/07/2019 14:08, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-17 14:04:34) On 16/07/2019 13:49, Chris

Re: [Intel-gfx] [PATCH] drm/i915/vbt: Fix VBT parsing for the PSR section

2019-07-17 Thread Rodrigo Vivi
On Wed, Jul 17, 2019 at 09:41:13AM -0700, Souza, Jose wrote: > On Tue, 2019-07-16 at 15:10 -0700, Pandiyan, Dhinakaran wrote: > > On Tue, 2019-07-16 at 15:03 -0700, Dhinakaran Pandiyan wrote: > > > A single 32-bit PSR2 training pattern field follows the sixteen > > > element > > > array of PSR

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt (rev2)

2019-07-17 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt (rev2) URL : https://patchwork.freedesktop.org/series/63809/ State : success == Summary == CI Bug Log - changes from CI_DRM_6498_full -> Patchwork_13672_full

Re: [Intel-gfx] [PATCH] drm/i915/vbt: Fix VBT parsing for the PSR section

2019-07-17 Thread Souza, Jose
On Tue, 2019-07-16 at 15:10 -0700, Pandiyan, Dhinakaran wrote: > On Tue, 2019-07-16 at 15:03 -0700, Dhinakaran Pandiyan wrote: > > A single 32-bit PSR2 training pattern field follows the sixteen > > element > > array of PSR table entries in the VBT spec. But, we incorrectly > > define > > this

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Make sure cdclk is high enough for DP audio on VLV/CHV

2019-07-17 Thread Patchwork
== Series Details == Series: drm/i915: Make sure cdclk is high enough for DP audio on VLV/CHV URL : https://patchwork.freedesktop.org/series/63808/ State : success == Summary == CI Bug Log - changes from CI_DRM_6498_full -> Patchwork_13671_full

Re: [Intel-gfx] [PATCH] drm/i915: Make sure cdclk is high enough for DP audio on VLV/CHV

2019-07-17 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v5.2.1, v5.1.18, v4.19.59, v4.14.133, v4.9.185, v4.4.185. v5.2.1: Failed to

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Move aliasing_ppgtt underneath its i915_ggtt

2019-07-17 Thread Patchwork
== Series Details == Series: drm/i915: Move aliasing_ppgtt underneath its i915_ggtt URL : https://patchwork.freedesktop.org/series/63806/ State : success == Summary == CI Bug Log - changes from CI_DRM_6498_full -> Patchwork_13670_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add HDCP capability info to i915_display_info.

2019-07-17 Thread Patchwork
== Series Details == Series: drm/i915: Add HDCP capability info to i915_display_info. URL : https://patchwork.freedesktop.org/series/63819/ State : success == Summary == CI Bug Log - changes from CI_DRM_6498 -> Patchwork_13675 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add HDCP capability info to i915_display_info.

2019-07-17 Thread Patchwork
== Series Details == Series: drm/i915: Add HDCP capability info to i915_display_info. URL : https://patchwork.freedesktop.org/series/63819/ State : warning == Summary == $ dim checkpatch origin/drm-tip 84154a9a0135 drm/i915: Add HDCP capability info to i915_display_info. -:35:

[Intel-gfx] ✗ Fi.CI.BAT: failure for DC3CO Support for TGL.

2019-07-17 Thread Patchwork
== Series Details == Series: DC3CO Support for TGL. URL : https://patchwork.freedesktop.org/series/63817/ State : failure == Summary == Applying: drm/i915/tgl:Added DC3CO required register and bits. Applying: i915:Added DC3CO mask to allowed_dc_mask and gen9_dc_mask. Applying: i915:Added

[Intel-gfx] [PATCH] drm/i915: Add HDCP capability info to i915_display_info.

2019-07-17 Thread Anshuman Gupta
To identify the HDCP capability of the display connected to CI systems, we need to add the hdcp capability probing in i915_display_info. This will also help to populate the HDCP capability of the CI systems to CI H/W logs maintained at https://intel-gfx-ci.01.org/hardware/. It will facilitate to

[Intel-gfx] [PATCH v2 10/10] drm/i915/tgl:Added new DC5/DC6 counter.

2019-07-17 Thread Anshuman Gupta
TGL onwards we have new DC5 and DC6 counter DMC_DEBUG1 and DMC_DEBUG2, these counter will retain there values upon DMC reset. Cc: jani.nik...@intel.com Cc: imre.d...@intel.com Cc: animesh.ma...@intel.com Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/i915_debugfs.c | 8 +---

[Intel-gfx] [PATCH v2 07/10] drm/i915/tgl:DC3CO PSR2 helper.

2019-07-17 Thread Anshuman Gupta
This patch adds dc3co helper function to enable/disable psr2 deep sleep. This patch make sure DC3CO disallowed before PSR2 exit, it does that essentially by putting a reference to POWER_DOMAIN_VIDEO before PSR2 exit. Cc: jani.nik...@intel.com Cc: imre.d...@intel.com Cc: jose.so...@intel.com Cc:

[Intel-gfx] [PATCH v2 09/10] drm/i915/tgl:Added DC3CO counter in i915_dmc_info.

2019-07-17 Thread Anshuman Gupta
This patch exposes DC3CO counter in i915_dmc_info debugfs. Which will be useful for DC3CO validation. DMC firmware is using DMC_DEBUG3 register as DC3CO counter register on TGL, but as per B.Specs DMC_DEBUG3 is general purpose register. Cc: jani.nik...@intel.com Cc: imre.d...@intel.com Cc:

[Intel-gfx] [PATCH v2 08/10] drm/i915/tgl:switch between dc3co and dc5 based on display idleness.

2019-07-17 Thread Anshuman Gupta
DC5 and DC6 not allowed when DC3CO feature is enabled. DC5 and DC6 saves more power, but cannot be entered during video playback because there are not enough idle frames in a row to meet. Most PSR2 panel deep sleep entry requirements typically 4 frames. This patch switch to DC3CO when there is

[Intel-gfx] [PATCH v2 06/10] drm/i915/tgl:Added VIDEO power domain.

2019-07-17 Thread Anshuman Gupta
Added POWER_DOMAIN_VIDEO power domain and added its helper stuff. POWER_DOMAIN_VIDEO is a hook to "DC5 Off" power well. which can disallow DC5/6 in order to allow dc3co. Cc: jani.nik...@intel.com Cc: imre.d...@intel.com Cc: animesh.ma...@intel.com Signed-off-by: Anshuman Gupta ---

[Intel-gfx] [PATCH v2 05/10] drm/i915/tgl:Added helper function to prefer dc3co over dc5.

2019-07-17 Thread Anshuman Gupta
This patch check if it is only edp display connected and crtc has psr2 capability, then it sets the prefer_dc3co flag to true. It also enable DC3CO PSR2 transcoder early exitline event in haswell_crtc_enable() function. TODO: B. Specs says dc3co should be allow only in video playback case,

[Intel-gfx] [PATCH v2 04/10] drm/i915/tgl:Added mutual exclusive handling for DC3CO and DC5/6.

2019-07-17 Thread Anshuman Gupta
As per B.Spces DC5 and DC6 not allowed when DC3CO is enabled. and DC3CO should be enabled only during VIDEO playback. Which essentially means both can DC5 and DC3CO can not be enabled at same time. This patch makes DC3CO and DC5 mutual exclusive. Cc: jani.nik...@intel.com Cc: imre.d...@intel.com

[Intel-gfx] [PATCH v2 00/10] DC3CO Support for TGL.

2019-07-17 Thread Anshuman Gupta
Resending this series as earlier submission has missed last patch of series, my sincere apology for spamming. This update is a rebased and has addressed few review comment provided by Imre on IRC. DMC f/w DC3CO entry/exit sequence can be found at DC3CO HAS. I am able to validate that DC3CO

[Intel-gfx] [PATCH v2 01/10] drm/i915/tgl:Added DC3CO required register and bits.

2019-07-17 Thread Anshuman Gupta
This patch adds following definition to i915_reg.h 1. DC_STATE_EN register DC3CO bit fields and masks. 2. Transcoder EXITLINE register and its bit fields and mask. v2: Commit log typo fixing. Cc: jani.nik...@intel.com Cc: imre.d...@intel.com Cc: animesh.ma...@intel.com Signed-off-by: Anshuman

[Intel-gfx] [PATCH v2 02/10] i915:Added DC3CO mask to allowed_dc_mask and gen9_dc_mask.

2019-07-17 Thread Anshuman Gupta
This patch enables dc3co state in enable_dc module param and adds dc3co enable mask to allowed_dc_mask and gen9_dc_mask. Cc: jani.nik...@intel.com Cc: imre.d...@intel.com Cc: animesh.ma...@intel.com Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_display_power.c | 13

[Intel-gfx] [PATCH v2 03/10] i915:Added DC3CO power well.

2019-07-17 Thread Anshuman Gupta
This patch adds a new "DC3CO Off" power well and adds its power domain which are inherits from "DC Off" power well. These power domains will disallow DC3CO when any external display are connected and at time of modeset and aux programming. This patch also changes "DC Off" power well to "DC5 Off"

Re: [Intel-gfx] [PATCH 1/5] drm/i915/userptr: Beware recursive lock_page()

2019-07-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-17 14:46:15) > > On 17/07/2019 14:35, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-07-17 14:23:55) > >> > >> On 17/07/2019 14:17, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2019-07-17 14:09:00) > > On 16/07/2019 16:37, Chris Wilson wrote: >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove obsolete engine clenaup (rev2)

2019-07-17 Thread Patchwork
== Series Details == Series: drm/i915: Remove obsolete engine clenaup (rev2) URL : https://patchwork.freedesktop.org/series/63791/ State : success == Summary == CI Bug Log - changes from CI_DRM_6498 -> Patchwork_13673 Summary ---

Re: [Intel-gfx] [PATCH 2/5] drm/i915/gt: Push engine stopping into reset-prepare

2019-07-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-17 14:42:15) > > On 17/07/2019 14:30, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-07-17 14:21:50) > >> > >> On 17/07/2019 14:08, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2019-07-17 14:04:34) > > On 16/07/2019 13:49, Chris Wilson wrote: >

Re: [Intel-gfx] [PATCH 1/5] drm/i915/userptr: Beware recursive lock_page()

2019-07-17 Thread Tvrtko Ursulin
On 17/07/2019 14:35, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2019-07-17 14:23:55) >> >> On 17/07/2019 14:17, Chris Wilson wrote: >>> Quoting Tvrtko Ursulin (2019-07-17 14:09:00) On 16/07/2019 16:37, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2019-07-16 16:25:22) >>

Re: [Intel-gfx] [PATCH 3/5] drm/i915/execlists: Process interrupted context on reset

2019-07-17 Thread Chris Wilson
Quoting Chris Wilson (2019-07-17 14:40:26) > Quoting Tvrtko Ursulin (2019-07-17 14:31:00) > > > > On 16/07/2019 13:49, Chris Wilson wrote: > > > By stopping the rings, we may trigger an arbitration point resulting in > > > a premature context-switch (i.e. a completion event before the request > >

Re: [Intel-gfx] [PATCH 2/5] drm/i915/gt: Push engine stopping into reset-prepare

2019-07-17 Thread Tvrtko Ursulin
On 17/07/2019 14:30, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-17 14:21:50) On 17/07/2019 14:08, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-17 14:04:34) On 16/07/2019 13:49, Chris Wilson wrote: Push the engine stop into the back reset_prepare (where it already was!)

Re: [Intel-gfx] [PATCH 4/5] drm/i915/execlists: Cancel breadcrumb on preempting the virtual engine

2019-07-17 Thread Tvrtko Ursulin
On 16/07/2019 13:49, Chris Wilson wrote: As we unwind the requests for a preemption event, we return a virtual request back to its original virtual engine (so that it is available for execution on any of its siblings). In the process, this means that its breadcrumb should no longer be

Re: [Intel-gfx] [PATCH 3/5] drm/i915/execlists: Process interrupted context on reset

2019-07-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-17 14:31:00) > > On 16/07/2019 13:49, Chris Wilson wrote: > > By stopping the rings, we may trigger an arbitration point resulting in > > a premature context-switch (i.e. a completion event before the request > > is actually complete). This clears the active

Re: [Intel-gfx] [PATCH 1/5] drm/i915/userptr: Beware recursive lock_page()

2019-07-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-17 14:23:55) > > On 17/07/2019 14:17, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-07-17 14:09:00) > >> > >> On 16/07/2019 16:37, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2019-07-16 16:25:22) > > On 16/07/2019 13:49, Chris Wilson wrote: >

Re: [Intel-gfx] [PATCH 3/5] drm/i915/execlists: Process interrupted context on reset

2019-07-17 Thread Tvrtko Ursulin
On 16/07/2019 13:49, Chris Wilson wrote: By stopping the rings, we may trigger an arbitration point resulting in a premature context-switch (i.e. a completion event before the request is actually complete). This clears the active context before the reset, but we must remember to rewind the

Re: [Intel-gfx] [PATCH 2/5] drm/i915/gt: Push engine stopping into reset-prepare

2019-07-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-17 14:21:50) > > On 17/07/2019 14:08, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-07-17 14:04:34) > >> > >> On 16/07/2019 13:49, Chris Wilson wrote: > >>> Push the engine stop into the back reset_prepare (where it already was!) > >>> This allows us to

Re: [Intel-gfx] [PATCH] drm/i915: Remove obsolete engine clenaup

2019-07-17 Thread Tvrtko Ursulin
On 17/07/2019 14:24, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-17 14:18:56) On 17/07/2019 08:46, Chris Wilson wrote: Remove the outer layer cleanup of engine stubs; it no longer tries to Who is "it"? i915_drv.c preallocate and so is not responsible for either the allocation

[Intel-gfx] [PATCH] drm/i915: Remove obsolete engine cleanup

2019-07-17 Thread Chris Wilson
Remove the outer layer cleanup of engine stubs; as i915_drv itself no longer tries to preallocate and so is not responsible for either the allocation or free. By the time we call the cleanup function, we already have cleaned up the engines. v2: Lack of symmetry between mmio_probe and mmio_release

Re: [Intel-gfx] [PATCH] drm/i915: Remove obsolete engine clenaup

2019-07-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-17 14:18:56) > > On 17/07/2019 08:46, Chris Wilson wrote: > > Remove the outer layer cleanup of engine stubs; it no longer tries to > > Who is "it"? i915_drv.c > > preallocate and so is not responsible for either the allocation or free. > > By the time we call

Re: [Intel-gfx] [PATCH 1/5] drm/i915/userptr: Beware recursive lock_page()

2019-07-17 Thread Tvrtko Ursulin
On 17/07/2019 14:17, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-17 14:09:00) On 16/07/2019 16:37, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-16 16:25:22) On 16/07/2019 13:49, Chris Wilson wrote: Following a try_to_unmap() we may want to remove the userptr and so call

Re: [Intel-gfx] [PATCH 2/5] drm/i915/gt: Push engine stopping into reset-prepare

2019-07-17 Thread Tvrtko Ursulin
On 17/07/2019 14:08, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-17 14:04:34) On 16/07/2019 13:49, Chris Wilson wrote: Push the engine stop into the back reset_prepare (where it already was!) This allows us to avoid dangerously setting the RING registers to 0 for logical contexts. If

Re: [Intel-gfx] [PATCH] drm/i915: Remove obsolete engine clenaup

2019-07-17 Thread Tvrtko Ursulin
On 17/07/2019 08:46, Chris Wilson wrote: > Remove the outer layer cleanup of engine stubs; it no longer tries to Who is "it"? > preallocate and so is not responsible for either the allocation or free. > By the time we call the cleanup function, we already have cleaned up the > engines. I see:

Re: [Intel-gfx] [PATCH 1/5] drm/i915/userptr: Beware recursive lock_page()

2019-07-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-17 14:09:00) > > On 16/07/2019 16:37, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-07-16 16:25:22) > >> > >> On 16/07/2019 13:49, Chris Wilson wrote: > >>> Following a try_to_unmap() we may want to remove the userptr and so call > >>> put_pages(). However,

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt (rev2)

2019-07-17 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt (rev2) URL : https://patchwork.freedesktop.org/series/63809/ State : success == Summary == CI Bug Log - changes from CI_DRM_6498 -> Patchwork_13672

Re: [Intel-gfx] [igt-dev] [PATCH V6 i-g-t 5/6] lib/igt_kms: Add igt_output_clone_pipe for cloning

2019-07-17 Thread Ser, Simon
On Tue, 2019-07-16 at 22:47 -0300, Rodrigo Siqueira wrote: > On 07/12, Ser, Simon wrote: > > So, to test these last two patches we'd need specific hardware right? > > Because VKMS doesn't support cloning yet (does it?). > > hmmm... actually, VKMS successfully pass in this test. However, if you >

Re: [Intel-gfx] [PATCH 1/5] drm/i915/userptr: Beware recursive lock_page()

2019-07-17 Thread Tvrtko Ursulin
On 16/07/2019 16:37, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-16 16:25:22) On 16/07/2019 13:49, Chris Wilson wrote: Following a try_to_unmap() we may want to remove the userptr and so call put_pages(). However, try_to_unmap() acquires the page lock and so we must avoid recursively

Re: [Intel-gfx] [PATCH 2/5] drm/i915/gt: Push engine stopping into reset-prepare

2019-07-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-17 14:04:34) > > On 16/07/2019 13:49, Chris Wilson wrote: > > Push the engine stop into the back reset_prepare (where it already was!) > > This allows us to avoid dangerously setting the RING registers to 0 for > > logical contexts. If we clear the register on a

Re: [Intel-gfx] PR- GUC v33 (BXT,SKL,GLK.KBL,ICL)

2019-07-17 Thread Josh Boyer
On Mon, Jul 8, 2019 at 5:53 PM Srivatsa, Anusha wrote: > > Hi, > > Can these i915 changes be merged to the linux-firmware.git? > > The following changes since commit 70e43940b05e8d6e0c5f15b5e2d67760f1581ece: > > linux-firmware: rsi: add firmware image for redpine 9116 chipset > (2019-06-28

Re: [Intel-gfx] [PATCH 2/5] drm/i915/gt: Push engine stopping into reset-prepare

2019-07-17 Thread Tvrtko Ursulin
On 16/07/2019 13:49, Chris Wilson wrote: Push the engine stop into the back reset_prepare (where it already was!) This allows us to avoid dangerously setting the RING registers to 0 for logical contexts. If we clear the register on a live context, those invalid register values are recorded in

Re: [Intel-gfx] [igt-dev] [PATCH V6 i-g-t 2/6] kms_writeback: Add initial writeback tests

2019-07-17 Thread Ser, Simon
On Tue, 2019-07-16 at 22:21 -0300, Rodrigo Siqueira wrote: > On 07/12, Ser, Simon wrote: > > On Thu, 2019-07-11 at 23:44 -0300, Rodrigo Siqueira wrote: > > > On 07/10, Ser, Simon wrote: > > > > Hi, > > > > > > > > Thanks for the patch! Here are a few comments. > > > > > > > > For bonus points,

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Make sure cdclk is high enough for DP audio on VLV/CHV

2019-07-17 Thread Patchwork
== Series Details == Series: drm/i915: Make sure cdclk is high enough for DP audio on VLV/CHV URL : https://patchwork.freedesktop.org/series/63808/ State : success == Summary == CI Bug Log - changes from CI_DRM_6498 -> Patchwork_13671

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Update description of i915.enable_guc modparam

2019-07-17 Thread Patchwork
== Series Details == Series: drm/i915: Update description of i915.enable_guc modparam URL : https://patchwork.freedesktop.org/series/63804/ State : success == Summary == CI Bug Log - changes from CI_DRM_6496_full -> Patchwork_13669_full

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Make sure cdclk is high enough for DP audio on VLV/CHV

2019-07-17 Thread Patchwork
== Series Details == Series: drm/i915: Make sure cdclk is high enough for DP audio on VLV/CHV URL : https://patchwork.freedesktop.org/series/63808/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Make sure cdclk is high enough for DP audio on

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Move aliasing_ppgtt underneath its i915_ggtt

2019-07-17 Thread Patchwork
== Series Details == Series: drm/i915: Move aliasing_ppgtt underneath its i915_ggtt URL : https://patchwork.freedesktop.org/series/63806/ State : success == Summary == CI Bug Log - changes from CI_DRM_6498 -> Patchwork_13670 Summary

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Cancel breadcrumb on preempting the virtual engine

2019-07-17 Thread Chris Wilson
Quoting Chris Wilson (2019-07-15 13:02:14) > As we unwind the requests for a preemption event, we return a virtual > request back to its original virtual engine (so that it is available for > execution on any of its siblings). In the process, this means that its > breadcrumb should no longer be

[Intel-gfx] [PATCH] drm/i915/gt: Provde a local intel_context.vm

2019-07-17 Thread Chris Wilson
Track the currently bound address space used by the HW context. Minor conversions to use the local intel_context.vm are made, leaving behind some more surgery required to make intel_context the primary through the selftests. Signed-off-by: Chris Wilson ---

[Intel-gfx] [PATCH 3/3] drm/i915/gt: Provde a local intel_context.vm

2019-07-17 Thread Chris Wilson
Track the currently bound address space used by the HW context. Minor conversions to use the local intel_context.vm are made, leaving behind some more surgery required to make intel_context the primary through the selftests. Signed-off-by: Chris Wilson ---

[Intel-gfx] [PATCH 1/3] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt

2019-07-17 Thread Chris Wilson
The aliasing_ppgtt provides a PIN_USER alias for the global gtt, so move it under the i915_ggtt to simplify later transformations to enable intel_context.vm. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 7 +- .../drm/i915/gem/selftests/i915_gem_context.c | 2

Re: [Intel-gfx] [igt-dev] [PATCH V6 i-g-t 2/6] kms_writeback: Add initial writeback tests

2019-07-17 Thread Ser, Simon
Thanks for the clarification! On Tue, 2019-07-16 at 16:22 +0100, liviu.du...@arm.com wrote: > > > > +static void invalid_out_fence(igt_output_t *output, igt_fb_t > > > > *valid_fb, igt_fb_t *invalid_fb) > > > > +{ > > > > + int i, ret; > > > > + int32_t out_fence; > > > > +

[Intel-gfx] [PATCH 2/3] drm/i915/gt: Hook up intel_context_fini()

2019-07-17 Thread Chris Wilson
Prior to freeing the struct, call the fini function to cleanup the common members. Currently this only calls the debug functions to mark the structs as destroyed, but may be extended to real work in future. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_context.c| 6 ++

[Intel-gfx] [PATCH] drm/i915: Make sure cdclk is high enough for DP audio on VLV/CHV

2019-07-17 Thread Ville Syrjala
From: Ville Syrjälä On VLV/CHV there is some kind of linkage between the cdclk frequency and the DP link frequency. The spec says: "For DP audio configuration, cdclk frequency shall be set to meet the following requirements: DP Link Frequency(MHz) | Cdclk frequency(MHz) 270

Re: [Intel-gfx] [PATCH] drm/i915/vbt: Fix VBT parsing for the PSR section

2019-07-17 Thread Ville Syrjälä
On Tue, Jul 16, 2019 at 03:03:21PM -0700, Dhinakaran Pandiyan wrote: > A single 32-bit PSR2 training pattern field follows the sixteen element > array of PSR table entries in the VBT spec. But, we incorrectly define > this PSR2 field for each of the PSR table entries. As a result, the PSR1 >

Re: [Intel-gfx] [PATCH] drm/i915: Update description of i915.enable_guc modparam

2019-07-17 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-07-17 11:47:51) > On Wed, 17 Jul 2019 12:44:18 +0200, Tvrtko Ursulin > wrote: > > > From: Tvrtko Ursulin > > > > Commit f774f0964919 ("drm/i915/guc: Turn on GuC/HuC auto mode") changed > > the default from 0 to -1 but forgot to update the description. > > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Update description of i915.enable_guc modparam

2019-07-17 Thread Patchwork
== Series Details == Series: drm/i915: Update description of i915.enable_guc modparam URL : https://patchwork.freedesktop.org/series/63804/ State : success == Summary == CI Bug Log - changes from CI_DRM_6496 -> Patchwork_13669 Summary

[Intel-gfx] [PATCH] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt

2019-07-17 Thread Chris Wilson
The aliasing_ppgtt provides a PIN_USER alias for the global gtt, so move it under the i915_ggtt to simplify later transformations to enable intel_context.vm. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 7 +- .../drm/i915/gem/selftests/i915_gem_context.c | 2

Re: [Intel-gfx] [PATCH] drm/i915: Update description of i915.enable_guc modparam

2019-07-17 Thread Michal Wajdeczko
On Wed, 17 Jul 2019 12:44:18 +0200, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Commit f774f0964919 ("drm/i915/guc: Turn on GuC/HuC auto mode") changed the default from 0 to -1 but forgot to update the description. Signed-off-by: Tvrtko Ursulin Fixes: f774f0964919 ("drm/i915/guc: Turn on

  1   2   >