Re: [Intel-gfx] [PATCH v3 4/8] drm/i915/uc: Unify uc_fw status tracking

2019-07-24 Thread Michal Wajdeczko
On Thu, 25 Jul 2019 02:18:09 +0200, Daniele Ceraolo Spurio wrote: We currently track fetch and load status separately, but the 2 are actually sequential in the uc lifetime (fetch must complete before we can attempt the load!). Unifying the 2 variables we can better follow the sequential

Re: [Intel-gfx] [PATCH v3 3/8] drm/i915/uc: Unify uC FW selection

2019-07-24 Thread Michal Wajdeczko
On Thu, 25 Jul 2019 02:18:08 +0200, Daniele Ceraolo Spurio wrote: Instead of having 2 identical functions for GuC and HuC firmware selection, we can unify the selection logic and just use different lists based on FW type. Note that the revid is not relevant for current blobs, but the

Re: [Intel-gfx] [PATCH v3 2/8] drm/i915: Fix handling of non-supported uC

2019-07-24 Thread Michal Wajdeczko
On Thu, 25 Jul 2019 02:18:07 +0200, Daniele Ceraolo Spurio wrote: There are 2 issues around handling of missing uC support: - We treat lack of uC HW and lack of uC FW definition as 2 different cases, but both of them mean that we don't support the uC on the platform we're running on. -

[Intel-gfx] ✗ Fi.CI.BAT: failure for uC fw path unification + misc clean-up (rev3)

2019-07-24 Thread Patchwork
== Series Details == Series: uC fw path unification + misc clean-up (rev3) URL : https://patchwork.freedesktop.org/series/64039/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6545 -> Patchwork_13741 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for uC fw path unification + misc clean-up (rev3)

2019-07-24 Thread Patchwork
== Series Details == Series: uC fw path unification + misc clean-up (rev3) URL : https://patchwork.freedesktop.org/series/64039/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/uc: Unify uC platform check Okay! Commit: drm/i915: Fix handling

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for uC fw path unification + misc clean-up (rev3)

2019-07-24 Thread Patchwork
== Series Details == Series: uC fw path unification + misc clean-up (rev3) URL : https://patchwork.freedesktop.org/series/64039/ State : warning == Summary == $ dim checkpatch origin/drm-tip cbaf15df0ad3 drm/i915/uc: Unify uC platform check c38f4e39f2fe drm/i915: Fix handling of non-supported

[Intel-gfx] [PATCH v3 6/8] drm/i915/huc: Copy huc rsa only once

2019-07-24 Thread Daniele Ceraolo Spurio
The binary is perma-pinned and the rsa is not going to change, so copy it only once and not on every load. v2: onion unwind (Chris) Signed-off-by: Daniele Ceraolo Spurio Cc: Fernando Pacheco Reviewed-by: Chris Wilson #v1 --- drivers/gpu/drm/i915/gt/uc/intel_huc.c| 27

[Intel-gfx] [PATCH v3 8/8] drm/i915/uc: Unify uC firmware upload

2019-07-24 Thread Daniele Ceraolo Spurio
The way we load the firmwares is the same for both GuC and HuC, the only difference is in the wopcm destination address and the dma flags, so we easily can move the logic to a common function and pass in offset and flags. The only other difference in the uplaod path are some the extra steps that

[Intel-gfx] [PATCH v3 0/8] uC fw path unification + misc clean-up

2019-07-24 Thread Daniele Ceraolo Spurio
I've now unified the no uC HW and no uC FW cases as well, as requested by Michal. I've also added sanitization of the enable_guc parameter when we don't have support for GuC/HuC because otherwise we end up paths we shouldn't be in on a platform with no uC. Cc: Michal Wajdeczko Cc: Chris Wilson

[Intel-gfx] [PATCH v3 4/8] drm/i915/uc: Unify uc_fw status tracking

2019-07-24 Thread Daniele Ceraolo Spurio
We currently track fetch and load status separately, but the 2 are actually sequential in the uc lifetime (fetch must complete before we can attempt the load!). Unifying the 2 variables we can better follow the sequential states and improve our trackng of the uC state. Also, sprinkle some

[Intel-gfx] [PATCH v3 5/8] drm/i915/uc: Move xfer rsa logic to common function

2019-07-24 Thread Daniele Ceraolo Spurio
The way we copy the RSA is the same for GuC and HuC, so we can move the logic in a common function. this will also make any update needed for local memory easier. v2: return the number of copied bytes and check it (Chris) Signed-off-by: Daniele Ceraolo Spurio Reviewed-by: Chris Wilson #v1

[Intel-gfx] [PATCH v3 7/8] drm/i915/uc: Plumb the gt through fw_upload

2019-07-24 Thread Daniele Ceraolo Spurio
The gt is our new central structure for uc-related code, so we can use that instead of jumping back to i915 via the fw object. Since we have it in the upload function it is easy to pass it through the lower levels of the xfer process instead of continuosly jumping via uc_fw->uc->gt, which will

[Intel-gfx] [PATCH v3 1/8] drm/i915/uc: Unify uC platform check

2019-07-24 Thread Daniele Ceraolo Spurio
We have several HAS_* checks for GuC and HuC but we mostly use HAS_GUC and HAS_HUC, with only 1 exception. Since our HW always has either both uC or neither of them, just replace all the checks with a unified HAS_UC. v2: use HAS_GT_UC (Michal) v3: fix comment (Michal) Signed-off-by: Daniele

[Intel-gfx] [PATCH v3 3/8] drm/i915/uc: Unify uC FW selection

2019-07-24 Thread Daniele Ceraolo Spurio
Instead of having 2 identical functions for GuC and HuC firmware selection, we can unify the selection logic and just use different lists based on FW type. Note that the revid is not relevant for current blobs, but the upcoming CML will be identified as CFL rev 5, so by considering the revid

[Intel-gfx] [PATCH v3 2/8] drm/i915: Fix handling of non-supported uC

2019-07-24 Thread Daniele Ceraolo Spurio
There are 2 issues around handling of missing uC support: - We treat lack of uC HW and lack of uC FW definition as 2 different cases, but both of them mean that we don't support the uC on the platform we're running on. - We rely on the modparam to decide if we can take uC paths or not, but

Re: [Intel-gfx] [PATCH 18/22] drm/i915/tgl: Define MOCS entries for Tigerlake

2019-07-24 Thread Lucas De Marchi
On Thu, Jul 18, 2019 at 10:09:27AM -0700, Daniele Ceraolo Spurio wrote: On 7/18/19 6:08 AM, Ville Syrjälä wrote: On Fri, Jul 12, 2019 at 06:09:36PM -0700, Lucas De Marchi wrote: From: Tomasz Lis The MOCS table is published as part of bspec, and versioned. Entries are supposed to never be

Re: [Intel-gfx] [PATCH v7 2/4] drm/panel: set display info in panel attach

2019-07-24 Thread dbasehore .
Hi Sam, thanks for pointing out the potential conflict. On Tue, Jul 23, 2019 at 2:19 AM Sam Ravnborg wrote: > > Hi Derek. > > On Tue, Jul 09, 2019 at 07:16:57PM -0700, Derek Basehore wrote: > > Devicetree systems can set panel orientation via a panel binding, but > > there's no way, as is, to

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: Fix GuC documentation links

2019-07-24 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Fix GuC documentation links URL : https://patchwork.freedesktop.org/series/64190/ State : success == Summary == CI Bug Log - changes from CI_DRM_6545_full -> Patchwork_13740_full

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Refactor to expand subslice mask (rev 2)

2019-07-24 Thread Summers, Stuart
On Wed, 2019-07-24 at 21:01 +, Patchwork wrote: > == Series Details == > > Series: Refactor to expand subslice mask (rev 2) > URL : https://patchwork.freedesktop.org/series/64188/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_6545_full -> Patchwork_13739_full >

[Intel-gfx] ✗ Fi.CI.IGT: failure for Refactor to expand subslice mask (rev 2)

2019-07-24 Thread Patchwork
== Series Details == Series: Refactor to expand subslice mask (rev 2) URL : https://patchwork.freedesktop.org/series/64188/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6545_full -> Patchwork_13739_full Summary ---

Re: [Intel-gfx] screen freeze with 5.2-rc6 Dell XPS-13 skylake i915

2019-07-24 Thread Souza, Jose
On Wed, 2019-07-24 at 22:39 +0200, Paul Bolle wrote: > Hi Jose, > > Souza, Jose schreef op wo 24-07-2019 om 20:27 [+]: > > We fixed the patch instead of revert it, it is merged on drm-tip > > and on > > his way to linux-stable. > > That should be (drm-tip) commit b5ea9c933700 ("drm/i915/vbt:

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gem: Make caps.scheduler static

2019-07-24 Thread Patchwork
== Series Details == Series: drm/i915/gem: Make caps.scheduler static URL : https://patchwork.freedesktop.org/series/64186/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6545_full -> Patchwork_13738_full Summary ---

Re: [Intel-gfx] screen freeze with 5.2-rc6 Dell XPS-13 skylake i915

2019-07-24 Thread Paul Bolle
Hi Jose, Souza, Jose schreef op wo 24-07-2019 om 20:27 [+]: > We fixed the patch instead of revert it, it is merged on drm-tip and on > his way to linux-stable. That should be (drm-tip) commit b5ea9c933700 ("drm/i915/vbt: Fix VBT parsing for the PSR section"). Correct? > Huge thanks again

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Flush all user surfaces prior to first use

2019-07-24 Thread Francisco Jerez
Chris Wilson writes: > Since userspace has the ability to bypass the CPU cache from within its > unprivileged command stream, we have to flush the CPU cache to memory > in order to overwrite the previous contents on creation. > > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen > Cc:

Re: [Intel-gfx] screen freeze with 5.2-rc6 Dell XPS-13 skylake i915

2019-07-24 Thread Souza, Jose
Hi Paul We fixed the patch instead of revert it, it is merged on drm-tip and on his way to linux-stable. Huge thanks again On Wed, 2019-07-24 at 21:23 +0200, Paul Bolle wrote: > Hi Jose, > > James Bottomley schreef op do 18-07-2019 om 06:29 [+0900]: > > On Wed, 2019-07-17 at 23:27 +0200, Paul

Re: [Intel-gfx] [PATCH 3/3] drm/i915/uc: Update drawing for firmware layout

2019-07-24 Thread Daniele Ceraolo Spurio
On 7/24/19 1:09 PM, Michal Wajdeczko wrote: On Wed, 24 Jul 2019 19:44:46 +0200, Daniele Ceraolo Spurio wrote: On 7/24/19 10:34 AM, Michal Wajdeczko wrote: Sphinx was rendering firmware layout as html table, but since we want to add sizes relations switch to plain text graphics.  

Re: [Intel-gfx] [PATCH 3/3] drm/i915/uc: Update drawing for firmware layout

2019-07-24 Thread Michal Wajdeczko
On Wed, 24 Jul 2019 19:44:46 +0200, Daniele Ceraolo Spurio wrote: On 7/24/19 10:34 AM, Michal Wajdeczko wrote: Sphinx was rendering firmware layout as html table, but since we want to add sizes relations switch to plain text graphics. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo

Re: [Intel-gfx] [PATCH 2/3] drm/i915/uc: Move uc firmware layout definitions to dedicated file

2019-07-24 Thread Daniele Ceraolo Spurio
On 7/24/19 1:01 PM, Michal Wajdeczko wrote: On Wed, 24 Jul 2019 19:50:37 +0200, Daniele Ceraolo Spurio wrote: On 7/24/19 10:34 AM, Michal Wajdeczko wrote: Generic uc firmware layout definitions are unlikely to change and are separate to other GuC specific definitions.  Signed-off-by:

Re: [Intel-gfx] [PATCH] drm/i915: Disable atomics in L3 for gen9

2019-07-24 Thread Francisco Jerez
Chris Wilson writes: > Quoting Francisco Jerez (2019-07-23 23:19:13) >> Chris Wilson writes: >> >> > Quoting Tvrtko Ursulin (2019-07-22 12:41:36) >> >> >> >> On 20/07/2019 15:31, Chris Wilson wrote: >> >> > Enabling atomic operations in L3 leads to unrecoverable GPU hangs, as >> >> > the

Re: [Intel-gfx] [PATCH 2/3] drm/i915/uc: Move uc firmware layout definitions to dedicated file

2019-07-24 Thread Michal Wajdeczko
On Wed, 24 Jul 2019 19:50:37 +0200, Daniele Ceraolo Spurio wrote: On 7/24/19 10:34 AM, Michal Wajdeczko wrote: Generic uc firmware layout definitions are unlikely to change and are separate to other GuC specific definitions. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Fix premature release of context on reset

2019-07-24 Thread Patchwork
== Series Details == Series: drm/i915/guc: Fix premature release of context on reset URL : https://patchwork.freedesktop.org/series/64181/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6545_full -> Patchwork_13737_full

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Fix GuC documentation links

2019-07-24 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Fix GuC documentation links URL : https://patchwork.freedesktop.org/series/64190/ State : success == Summary == CI Bug Log - changes from CI_DRM_6545 -> Patchwork_13740

[Intel-gfx] ✓ Fi.CI.IGT: success for Associate ddc adapters with connectors (rev2)

2019-07-24 Thread Patchwork
== Series Details == Series: Associate ddc adapters with connectors (rev2) URL : https://patchwork.freedesktop.org/series/63558/ State : success == Summary == CI Bug Log - changes from CI_DRM_6545_full -> Patchwork_13736_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for Refactor to expand subslice mask (rev 2)

2019-07-24 Thread Patchwork
== Series Details == Series: Refactor to expand subslice mask (rev 2) URL : https://patchwork.freedesktop.org/series/64188/ State : success == Summary == CI Bug Log - changes from CI_DRM_6545 -> Patchwork_13739 Summary ---

Re: [Intel-gfx] screen freeze with 5.2-rc6 Dell XPS-13 skylake i915

2019-07-24 Thread Paul Bolle
Hi Jose, James Bottomley schreef op do 18-07-2019 om 06:29 [+0900]: > On Wed, 2019-07-17 at 23:27 +0200, Paul Bolle wrote: > > I've just reached a day of uptime with your revert. (The proper > > uptime is just a fraction of a day, this being a laptop.) Anyhow, no > > screen freezes occurred

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/5] drm/i915: Split i915_gem_init_hw into GT and i915 parts (rev2)

2019-07-24 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Split i915_gem_init_hw into GT and i915 parts (rev2) URL : https://patchwork.freedesktop.org/series/64164/ State : success == Summary == CI Bug Log - changes from CI_DRM_6545_full -> Patchwork_13734_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Make caps.scheduler static

2019-07-24 Thread Patchwork
== Series Details == Series: drm/i915/gem: Make caps.scheduler static URL : https://patchwork.freedesktop.org/series/64186/ State : success == Summary == CI Bug Log - changes from CI_DRM_6545 -> Patchwork_13738 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: Fix GuC documentation links

2019-07-24 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Fix GuC documentation links URL : https://patchwork.freedesktop.org/series/64190/ State : warning == Summary == $ dim checkpatch origin/drm-tip b6534971a681 drm/i915: Fix GuC documentation links -:9:

Re: [Intel-gfx] [PATCH 2/3] drm/i915/uc: Move uc firmware layout definitions to dedicated file

2019-07-24 Thread Daniele Ceraolo Spurio
On 7/24/19 10:34 AM, Michal Wajdeczko wrote: Generic uc firmware layout definitions are unlikely to change and are separate to other GuC specific definitions. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Keeping things that apply to HuC as well in a generic file seems

Re: [Intel-gfx] [PATCH 3/3] drm/i915/uc: Update drawing for firmware layout

2019-07-24 Thread Daniele Ceraolo Spurio
On 7/24/19 10:34 AM, Michal Wajdeczko wrote: Sphinx was rendering firmware layout as html table, but since we want to add sizes relations switch to plain text graphics. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw_abi.h | 25

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Fix GuC documentation links

2019-07-24 Thread Daniele Ceraolo Spurio
On 7/24/19 10:34 AM, Michal Wajdeczko wrote: We moved GuC related files to new location but we missed to update .rst file with links. References: commit 0f261b241d9c ("drm/i915/uc: move GuC and HuC files under gt/uc/") Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Chris

Re: [Intel-gfx] [PATCH stable v5.2] drm/i915/vbt: Fix VBT parsing for the PSR section

2019-07-24 Thread Rodrigo Vivi
On Wed, Jul 24, 2019 at 05:27:42PM +, Souza, Jose wrote: > On Wed, 2019-07-24 at 14:06 +0200, Greg KH wrote: > > On Mon, Jul 22, 2019 at 04:13:25PM -0700, Dhinakaran Pandiyan wrote: > > > A single 32-bit PSR2 training pattern field follows the sixteen > > > element > > > array of PSR table

[Intel-gfx] [PATCH 3/3] drm/i915/uc: Update drawing for firmware layout

2019-07-24 Thread Michal Wajdeczko
Sphinx was rendering firmware layout as html table, but since we want to add sizes relations switch to plain text graphics. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw_abi.h | 25 +--- 1 file changed, 11 insertions(+),

[Intel-gfx] [PATCH 1/3] drm/i915: Fix GuC documentation links

2019-07-24 Thread Michal Wajdeczko
We moved GuC related files to new location but we missed to update .rst file with links. References: commit 0f261b241d9c ("drm/i915/uc: move GuC and HuC files under gt/uc/") Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Chris Wilson --- Documentation/gpu/i915.rst | 10

[Intel-gfx] [PATCH 2/3] drm/i915/uc: Move uc firmware layout definitions to dedicated file

2019-07-24 Thread Michal Wajdeczko
Generic uc firmware layout definitions are unlikely to change and are separate to other GuC specific definitions. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio --- Documentation/gpu/i915.rst | 2 +- drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h | 70

Re: [Intel-gfx] [PATCH v2 3/8] drm/i915/uc: Unify uc_fw status tracking

2019-07-24 Thread Daniele Ceraolo Spurio
On 7/24/19 10:24 AM, Michal Wajdeczko wrote: On Wed, 24 Jul 2019 18:37:52 +0200, Daniele Ceraolo Spurio wrote: -    uc_fw->load_status = INTEL_UC_FIRMWARE_SUCCESS; -    DRM_DEBUG_DRIVER("%s fw load %s\n", - intel_uc_fw_type_repr(uc_fw->type), -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Refactor to expand subslice mask (rev 2)

2019-07-24 Thread Patchwork
== Series Details == Series: Refactor to expand subslice mask (rev 2) URL : https://patchwork.freedesktop.org/series/64188/ State : warning == Summary == $ dim checkpatch origin/drm-tip d83520f343cd drm/i915: Use variable for debugfs device status c7ec1447ee8f drm/i915: Add function to set

Re: [Intel-gfx] [PATCH stable v5.2] drm/i915/vbt: Fix VBT parsing for the PSR section

2019-07-24 Thread Souza, Jose
On Wed, 2019-07-24 at 14:06 +0200, Greg KH wrote: > On Mon, Jul 22, 2019 at 04:13:25PM -0700, Dhinakaran Pandiyan wrote: > > A single 32-bit PSR2 training pattern field follows the sixteen > > element > > array of PSR table entries in the VBT spec. But, we incorrectly > > define > > this PSR2

Re: [Intel-gfx] [PATCH v2 3/8] drm/i915/uc: Unify uc_fw status tracking

2019-07-24 Thread Michal Wajdeczko
On Wed, 24 Jul 2019 18:37:52 +0200, Daniele Ceraolo Spurio wrote: -uc_fw->load_status = INTEL_UC_FIRMWARE_SUCCESS; -DRM_DEBUG_DRIVER("%s fw load %s\n", - intel_uc_fw_type_repr(uc_fw->type), - intel_uc_fw_status_repr(uc_fw->load_status)); +uc_fw->status =

Re: [Intel-gfx] [PATCH v5 18/24] drm/ast: Provide ddc symlink in connector sysfs directory

2019-07-24 Thread Thomas Zimmermann
Am 24.07.19 um 15:59 schrieb Andrzej Pietrasiewicz: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/gpu/drm/ast/ast_mode.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git

Re: [Intel-gfx] [PATCH v5 17/24] drm/mgag200: Provide ddc symlink in connector sysfs directory

2019-07-24 Thread Thomas Zimmermann
Am 24.07.19 um 15:59 schrieb Andrzej Pietrasiewicz: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/gpu/drm/mgag200/mgag200_mode.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git

Re: [Intel-gfx] [PATCH v5 02/24] drm: Add drm_connector_init() variant with ddc

2019-07-24 Thread Thomas Zimmermann
Hi Am 24.07.19 um 15:59 schrieb Andrzej Pietrasiewicz: > Allow passing ddc adapter pointer to the init function. Even if > drm_connector_init() sometime in the future decides to e.g. memset() all > connector fields to zeros, the newly added function ensures that at its > completion the ddc member

[Intel-gfx] [PATCH 4/9] drm/i915: Add EU stride runtime parameter

2019-07-24 Thread Stuart Summers
Add a new SSEU runtime parameter, eu_stride, which is used to mirror the userspace concept of a range of EUs per subslice. This patch simply adds the parameter and updates usage in the QUERY_TOPOLOGY_INFO handler. Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/gt/intel_sseu.c | 1 +

[Intel-gfx] [PATCH 3/9] drm/i915: Add subslice stride runtime parameter

2019-07-24 Thread Stuart Summers
Add a new parameter, ss_stride, to the runtime info structure. This is used to mirror the userspace concept of subslice stride, which is a range of subslices per slice. This patch simply adds the definition and updates usage in the QUERY_TOPOLOGY_INFO handler. Signed-off-by: Stuart Summers ---

[Intel-gfx] [PATCH 1/9] drm/i915: Use variable for debugfs device status

2019-07-24 Thread Stuart Summers
Use a local variable to find SSEU runtime information in various debugfs functions. Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/i915_debugfs.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c

[Intel-gfx] [PATCH 7/9] drm/i915: Refactor instdone loops on new subslice functions

2019-07-24 Thread Stuart Summers
Refactor instdone loops to use the new intel_sseu_has_subslice function. Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/gt/intel_engine_cs.c| 3 +- drivers/gpu/drm/i915/gt/intel_engine_types.h | 31 ++-- drivers/gpu/drm/i915/gt/intel_hangcheck.c| 3 +-

[Intel-gfx] [PATCH 2/9] drm/i915: Add function to set SSEU info per platform

2019-07-24 Thread Stuart Summers
Add a new function to allow each platform to set maximum slice, subslice, and EU information to reduce code duplication. Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/gt/intel_sseu.c | 8 + drivers/gpu/drm/i915/gt/intel_sseu.h | 3 ++ drivers/gpu/drm/i915/i915_debugfs.c

[Intel-gfx] [PATCH 6/9] drm/i915: Add function to determine if a slice has a subslice

2019-07-24 Thread Stuart Summers
Add a new function to determine whether a particular slice has a given subslice. Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/gt/intel_sseu.h | 10 ++ drivers/gpu/drm/i915/intel_device_info.c | 9 - 2 files changed, 14 insertions(+), 5 deletions(-) diff --git

[Intel-gfx] [PATCH 0/9] Refactor to expand subslice mask (rev 2)

2019-07-24 Thread Stuart Summers
Currently, the subslice_mask runtime parameter is stored as an array of subslices per slice. Expand the subslice mask array to better match what is presented to userspace through the I915_QUERY_TOPOLOGY_INFO ioctl. The index into this array is then calculated: slice * subslice stride + subslice

[Intel-gfx] [PATCH 5/9] drm/i915: Add function to set subslices

2019-07-24 Thread Stuart Summers
Add a new function to set a range of subslices for a specified slice based on a given mask. Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/gt/intel_sseu.c | 10 + drivers/gpu/drm/i915/gt/intel_sseu.h | 3 ++ drivers/gpu/drm/i915/intel_device_info.c | 53

[Intel-gfx] [PATCH 9/9] drm/i915: Expand subslice mask

2019-07-24 Thread Stuart Summers
Currently, the subslice_mask runtime parameter is stored as an array of subslices per slice. Expand the subslice mask array to better match what is presented to userspace through the I915_QUERY_TOPOLOGY_INFO ioctl. The index into this array is then calculated: slice * subslice stride + subslice

[Intel-gfx] [PATCH 8/9] drm/i915: Add new function to copy subslices for a slice

2019-07-24 Thread Stuart Summers
Add a new function to copy subslices for a specified slice between intel_sseu structures for the purpose of determining power-gate status. Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/i915_debugfs.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Fix premature release of context on reset

2019-07-24 Thread Patchwork
== Series Details == Series: drm/i915/guc: Fix premature release of context on reset URL : https://patchwork.freedesktop.org/series/64181/ State : success == Summary == CI Bug Log - changes from CI_DRM_6545 -> Patchwork_13737 Summary

Re: [Intel-gfx] [PATCH v2 3/8] drm/i915/uc: Unify uc_fw status tracking

2019-07-24 Thread Daniele Ceraolo Spurio
On 7/24/2019 5:35 AM, Michal Wajdeczko wrote: On Wed, 24 Jul 2019 04:21:48 +0200, Daniele Ceraolo Spurio wrote: We currently track fetch and load status separately, but the 2 are actually sequential in the uc lifetime (fetch must complete before we can attempt the load!). Unifying the 2

[Intel-gfx] ✓ Fi.CI.BAT: success for Associate ddc adapters with connectors (rev2)

2019-07-24 Thread Patchwork
== Series Details == Series: Associate ddc adapters with connectors (rev2) URL : https://patchwork.freedesktop.org/series/63558/ State : success == Summary == CI Bug Log - changes from CI_DRM_6545 -> Patchwork_13736 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Unshare the idle-barrier from other kernel requests (rev2)

2019-07-24 Thread Patchwork
== Series Details == Series: drm/i915: Unshare the idle-barrier from other kernel requests (rev2) URL : https://patchwork.freedesktop.org/series/64171/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6545 -> Patchwork_13735

Re: [Intel-gfx] [PATCH v2 2/8] drm/i915/uc: Unify uC FW selection

2019-07-24 Thread Daniele Ceraolo Spurio
On 7/24/2019 4:31 AM, Michal Wajdeczko wrote: On Wed, 24 Jul 2019 04:21:47 +0200, Daniele Ceraolo Spurio wrote: Instead of having 2 identical functions for GuC and HuC firmware selection, we can unify the selection logic and just use different lists based on FW type. Note that the revid

[Intel-gfx] [PATCH] drm/i915/gem: Make caps.scheduler static

2019-07-24 Thread Chris Wilson
We do not notify userspace when the scheduler capabilities are changed (due to wedging the driver) and as such userspace will expect the caps to be static and unchanging. Make it so, and so we only need to compute our caps once during driver registration. Signed-off-by: Chris Wilson Cc: Tvrtko

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Split i915_gem_init_hw into GT and i915 parts (rev2)

2019-07-24 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Split i915_gem_init_hw into GT and i915 parts (rev2) URL : https://patchwork.freedesktop.org/series/64164/ State : success == Summary == CI Bug Log - changes from CI_DRM_6545 -> Patchwork_13734

Re: [Intel-gfx] [RFC PATCH] drm/i915/guc: Fix premature release of context on reset

2019-07-24 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-07-24 16:05:25) > When using GuC submission, some execlists originated helper functions > are reused. One of them, used inside guc_reset() and > guc_cancel_requests() callbacks introduced by commit 292ad25c22d9 > ("drm/i915/guc: Implement reset locally"),

Re: [Intel-gfx] [RFC PATCH] drm/i915/guc: Fix premature release of context on reset

2019-07-24 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-07-24 16:05:25) > When using GuC submission, some execlists originated helper functions > are reused. One of them, used inside guc_reset() and > guc_cancel_requests() callbacks introduced by commit 292ad25c22d9 > ("drm/i915/guc: Implement reset locally"),

[Intel-gfx] [RFC PATCH] drm/i915/guc: Fix premature release of context on reset

2019-07-24 Thread Janusz Krzysztofik
When using GuC submission, some execlists originated helper functions are reused. One of them, used inside guc_reset() and guc_cancel_requests() callbacks introduced by commit 292ad25c22d9 ("drm/i915/guc: Implement reset locally"), unfortunately calls execlists_schedule_out() helper instead of

Re: [Intel-gfx] [PATCH] drm/i915: Disable atomics in L3 for gen9

2019-07-24 Thread Chris Wilson
Quoting Francisco Jerez (2019-07-23 23:19:13) > Chris Wilson writes: > > > Quoting Tvrtko Ursulin (2019-07-22 12:41:36) > >> > >> On 20/07/2019 15:31, Chris Wilson wrote: > >> > Enabling atomic operations in L3 leads to unrecoverable GPU hangs, as > >> > the machine stops responding

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Associate ddc adapters with connectors (rev2)

2019-07-24 Thread Patchwork
== Series Details == Series: Associate ddc adapters with connectors (rev2) URL : https://patchwork.freedesktop.org/series/63558/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8ca228e56f33 drm: Include ddc adapter pointer in struct drm_connector c9a7fb60189d drm: Add

Re: [Intel-gfx] [PATCH v2 5/8] drm/i915/huc: Copy huc rsa only once

2019-07-24 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-07-24 13:55:23) > On Wed, 24 Jul 2019 04:21:50 +0200, Daniele Ceraolo Spurio > wrote: > > > The binary is perma-pinned and the rsa is not going to change, so copy > > it only once and not on every load. > > as this new location is accessible from the GuC, what

[Intel-gfx] [PATCH v5 24/24] drm/i915: Provide ddc symlink in hdmi connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/i915/display/intel_hdmi.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c

[Intel-gfx] [PATCH v5 23/24] drm/radeon: Provide ddc symlink in connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/radeon/radeon_connectors.c | 141 +++-- 1 file changed, 105 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c

[Intel-gfx] [PATCH v5 20/24] drm/bridge: dw-hdmi: Provide ddc symlink in connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 46 --- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c

[Intel-gfx] [PATCH v5 21/24] drm/bridge: ti-tfp410: Provide ddc symlink in connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/bridge/ti-tfp410.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c

[Intel-gfx] [PATCH v5 22/24] drm/amdgpu: Provide ddc symlink in connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- .../gpu/drm/amd/amdgpu/amdgpu_connectors.c| 95 ++- 1 file changed, 69 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c

[Intel-gfx] [PATCH v5 19/24] drm/bridge: dumb-vga-dac: Provide ddc symlink in connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/bridge/dumb-vga-dac.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c

[Intel-gfx] [PATCH v5 18/24] drm/ast: Provide ddc symlink in connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/ast/ast_mode.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c index

[Intel-gfx] [PATCH v5 17/24] drm/mgag200: Provide ddc symlink in connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/mgag200/mgag200_mode.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c

[Intel-gfx] [PATCH v5 14/24] drm: zte: Provide ddc symlink in vga connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/zte/zx_vga.c | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/zte/zx_vga.c b/drivers/gpu/drm/zte/zx_vga.c index

[Intel-gfx] [PATCH v5 16/24] drm: sti: Provide ddc symlink in hdmi connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/sti/sti_hdmi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c index

[Intel-gfx] [PATCH v5 15/24] drm/tilcdc: Provide ddc symlink in connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c index

[Intel-gfx] [PATCH v5 12/24] drm/vc4: Provide ddc symlink in connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/vc4/vc4_hdmi.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index

[Intel-gfx] [PATCH v5 13/24] drm: zte: Provide ddc symlink in hdmi connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/zte/zx_hdmi.c | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/zte/zx_hdmi.c b/drivers/gpu/drm/zte/zx_hdmi.c index

[Intel-gfx] [PATCH v5 10/24] drm/imx: imx-ldb: Provide ddc symlink in connector's sysfs

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/imx/imx-ldb.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c index

[Intel-gfx] [PATCH v5 11/24] drm/imx: imx-tve: Provide ddc symlink in connector's sysfs

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/imx/imx-tve.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c index

[Intel-gfx] [PATCH v5 08/24] drm/mediatek: Provide ddc symlink in hdmi connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c

[Intel-gfx] [PATCH v5 06/24] drm/msm/hdmi: Provide ddc symlink in hdmi connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c

[Intel-gfx] [PATCH v5 09/24] drm/tegra: Provide ddc symlink in output connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/tegra/drm.h| 1 - drivers/gpu/drm/tegra/hdmi.c | 7 --- drivers/gpu/drm/tegra/output.c | 12 ++-- drivers/gpu/drm/tegra/sor.c| 13 +++-- 4 files

[Intel-gfx] [PATCH v5 07/24] drm/sun4i: hdmi: Provide ddc symlink in sun4i hdmi connector sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/sun4i/sun4i_hdmi.h | 1 - drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 21 +++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git

[Intel-gfx] [PATCH v5 04/24] drm: rockchip: Provide ddc symlink in rk3066_hdmi sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/rockchip/rk3066_hdmi.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c

[Intel-gfx] [PATCH v5 05/24] drm: rockchip: Provide ddc symlink in inno_hdmi sysfs directory

2019-07-24 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/rockchip/inno_hdmi.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c

[Intel-gfx] [PATCH v5 03/24] drm/exynos: Provide ddc symlink in connector's sysfs

2019-07-24 Thread Andrzej Pietrasiewicz
Switch to using the ddc provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/exynos/exynos_hdmi.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c

[Intel-gfx] [PATCH v5 02/24] drm: Add drm_connector_init() variant with ddc

2019-07-24 Thread Andrzej Pietrasiewicz
Allow passing ddc adapter pointer to the init function. Even if drm_connector_init() sometime in the future decides to e.g. memset() all connector fields to zeros, the newly added function ensures that at its completion the ddc member of connector is correctly set. Signed-off-by: Andrzej

[Intel-gfx] [PATCH v5 01/24] drm: Include ddc adapter pointer in struct drm_connector

2019-07-24 Thread Andrzej Pietrasiewicz
Add generic code which creates symbolic links in sysfs, pointing to ddc interface used by a particular video output. For example: ls -l /sys/class/drm/card0-HDMI-A-1/ddc lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0-HDMI-A-1/ddc \ -> ../../../../soc/1388.i2c/i2c-2 This

[Intel-gfx] [PATCH v5 00/24] Associate ddc adapters with connectors

2019-07-24 Thread Andrzej Pietrasiewicz
It is difficult for a user to know which of the i2c adapters is for which drm connector. This series addresses this problem. The idea is to have a symbolic link in connector's sysfs directory, e.g.: ls -l /sys/class/drm/card0-HDMI-A-1/ddc lrwxrwxrwx 1 root root 0 Jun 24 10:42

  1   2   >