On Thu, 25 Jul 2019 02:18:09 +0200, Daniele Ceraolo Spurio
wrote:
We currently track fetch and load status separately, but the 2 are
actually sequential in the uc lifetime (fetch must complete before we
can attempt the load!). Unifying the 2 variables we can better follow
the sequential
On Thu, 25 Jul 2019 02:18:08 +0200, Daniele Ceraolo Spurio
wrote:
Instead of having 2 identical functions for GuC and HuC firmware
selection, we can unify the selection logic and just use different lists
based on FW type.
Note that the revid is not relevant for current blobs, but the
On Thu, 25 Jul 2019 02:18:07 +0200, Daniele Ceraolo Spurio
wrote:
There are 2 issues around handling of missing uC support:
- We treat lack of uC HW and lack of uC FW definition as 2 different
cases, but both of them mean that we don't support the uC on the
platform we're running on.
-
== Series Details ==
Series: uC fw path unification + misc clean-up (rev3)
URL : https://patchwork.freedesktop.org/series/64039/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6545 -> Patchwork_13741
Summary
---
== Series Details ==
Series: uC fw path unification + misc clean-up (rev3)
URL : https://patchwork.freedesktop.org/series/64039/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915/uc: Unify uC platform check
Okay!
Commit: drm/i915: Fix handling
== Series Details ==
Series: uC fw path unification + misc clean-up (rev3)
URL : https://patchwork.freedesktop.org/series/64039/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
cbaf15df0ad3 drm/i915/uc: Unify uC platform check
c38f4e39f2fe drm/i915: Fix handling of non-supported
The binary is perma-pinned and the rsa is not going to change, so copy
it only once and not on every load.
v2: onion unwind (Chris)
Signed-off-by: Daniele Ceraolo Spurio
Cc: Fernando Pacheco
Reviewed-by: Chris Wilson #v1
---
drivers/gpu/drm/i915/gt/uc/intel_huc.c| 27
The way we load the firmwares is the same for both GuC and HuC, the only
difference is in the wopcm destination address and the dma flags, so we
easily can move the logic to a common function and pass in offset and
flags. The only other difference in the uplaod path are some the extra
steps that
I've now unified the no uC HW and no uC FW cases as well, as requested
by Michal. I've also added sanitization of the enable_guc parameter
when we don't have support for GuC/HuC because otherwise we end up paths
we shouldn't be in on a platform with no uC.
Cc: Michal Wajdeczko
Cc: Chris Wilson
We currently track fetch and load status separately, but the 2 are
actually sequential in the uc lifetime (fetch must complete before we
can attempt the load!). Unifying the 2 variables we can better follow
the sequential states and improve our trackng of the uC state.
Also, sprinkle some
The way we copy the RSA is the same for GuC and HuC, so we can move the
logic in a common function. this will also make any update needed for
local memory easier.
v2: return the number of copied bytes and check it (Chris)
Signed-off-by: Daniele Ceraolo Spurio
Reviewed-by: Chris Wilson #v1
The gt is our new central structure for uc-related code, so we can use
that instead of jumping back to i915 via the fw object. Since we have it
in the upload function it is easy to pass it through the lower levels of
the xfer process instead of continuosly jumping via uc_fw->uc->gt, which
will
We have several HAS_* checks for GuC and HuC but we mostly use HAS_GUC
and HAS_HUC, with only 1 exception. Since our HW always has either
both uC or neither of them, just replace all the checks with a unified
HAS_UC.
v2: use HAS_GT_UC (Michal)
v3: fix comment (Michal)
Signed-off-by: Daniele
Instead of having 2 identical functions for GuC and HuC firmware
selection, we can unify the selection logic and just use different lists
based on FW type.
Note that the revid is not relevant for current blobs, but the upcoming
CML will be identified as CFL rev 5, so by considering the revid
There are 2 issues around handling of missing uC support:
- We treat lack of uC HW and lack of uC FW definition as 2 different
cases, but both of them mean that we don't support the uC on the
platform we're running on.
- We rely on the modparam to decide if we can take uC paths or not, but
On Thu, Jul 18, 2019 at 10:09:27AM -0700, Daniele Ceraolo Spurio wrote:
On 7/18/19 6:08 AM, Ville Syrjälä wrote:
On Fri, Jul 12, 2019 at 06:09:36PM -0700, Lucas De Marchi wrote:
From: Tomasz Lis
The MOCS table is published as part of bspec, and versioned. Entries
are supposed to never be
Hi Sam, thanks for pointing out the potential conflict.
On Tue, Jul 23, 2019 at 2:19 AM Sam Ravnborg wrote:
>
> Hi Derek.
>
> On Tue, Jul 09, 2019 at 07:16:57PM -0700, Derek Basehore wrote:
> > Devicetree systems can set panel orientation via a panel binding, but
> > there's no way, as is, to
== Series Details ==
Series: series starting with [1/3] drm/i915: Fix GuC documentation links
URL : https://patchwork.freedesktop.org/series/64190/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6545_full -> Patchwork_13740_full
On Wed, 2019-07-24 at 21:01 +, Patchwork wrote:
> == Series Details ==
>
> Series: Refactor to expand subslice mask (rev 2)
> URL : https://patchwork.freedesktop.org/series/64188/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_6545_full -> Patchwork_13739_full
>
== Series Details ==
Series: Refactor to expand subslice mask (rev 2)
URL : https://patchwork.freedesktop.org/series/64188/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6545_full -> Patchwork_13739_full
Summary
---
On Wed, 2019-07-24 at 22:39 +0200, Paul Bolle wrote:
> Hi Jose,
>
> Souza, Jose schreef op wo 24-07-2019 om 20:27 [+]:
> > We fixed the patch instead of revert it, it is merged on drm-tip
> > and on
> > his way to linux-stable.
>
> That should be (drm-tip) commit b5ea9c933700 ("drm/i915/vbt:
== Series Details ==
Series: drm/i915/gem: Make caps.scheduler static
URL : https://patchwork.freedesktop.org/series/64186/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6545_full -> Patchwork_13738_full
Summary
---
Hi Jose,
Souza, Jose schreef op wo 24-07-2019 om 20:27 [+]:
> We fixed the patch instead of revert it, it is merged on drm-tip and on
> his way to linux-stable.
That should be (drm-tip) commit b5ea9c933700 ("drm/i915/vbt: Fix VBT parsing
for the PSR section"). Correct?
> Huge thanks again
Chris Wilson writes:
> Since userspace has the ability to bypass the CPU cache from within its
> unprivileged command stream, we have to flush the CPU cache to memory
> in order to overwrite the previous contents on creation.
>
> Signed-off-by: Chris Wilson
> Cc: Joonas Lahtinen
> Cc:
Hi Paul
We fixed the patch instead of revert it, it is merged on drm-tip and on
his way to linux-stable.
Huge thanks again
On Wed, 2019-07-24 at 21:23 +0200, Paul Bolle wrote:
> Hi Jose,
>
> James Bottomley schreef op do 18-07-2019 om 06:29 [+0900]:
> > On Wed, 2019-07-17 at 23:27 +0200, Paul
On 7/24/19 1:09 PM, Michal Wajdeczko wrote:
On Wed, 24 Jul 2019 19:44:46 +0200, Daniele Ceraolo Spurio
wrote:
On 7/24/19 10:34 AM, Michal Wajdeczko wrote:
Sphinx was rendering firmware layout as html table, but since
we want to add sizes relations switch to plain text graphics.
On Wed, 24 Jul 2019 19:44:46 +0200, Daniele Ceraolo Spurio
wrote:
On 7/24/19 10:34 AM, Michal Wajdeczko wrote:
Sphinx was rendering firmware layout as html table, but since
we want to add sizes relations switch to plain text graphics.
Signed-off-by: Michal Wajdeczko
Cc: Daniele Ceraolo
On 7/24/19 1:01 PM, Michal Wajdeczko wrote:
On Wed, 24 Jul 2019 19:50:37 +0200, Daniele Ceraolo Spurio
wrote:
On 7/24/19 10:34 AM, Michal Wajdeczko wrote:
Generic uc firmware layout definitions are unlikely to change and
are separate to other GuC specific definitions.
Signed-off-by:
Chris Wilson writes:
> Quoting Francisco Jerez (2019-07-23 23:19:13)
>> Chris Wilson writes:
>>
>> > Quoting Tvrtko Ursulin (2019-07-22 12:41:36)
>> >>
>> >> On 20/07/2019 15:31, Chris Wilson wrote:
>> >> > Enabling atomic operations in L3 leads to unrecoverable GPU hangs, as
>> >> > the
On Wed, 24 Jul 2019 19:50:37 +0200, Daniele Ceraolo Spurio
wrote:
On 7/24/19 10:34 AM, Michal Wajdeczko wrote:
Generic uc firmware layout definitions are unlikely to change and
are separate to other GuC specific definitions.
Signed-off-by: Michal Wajdeczko
Cc: Daniele Ceraolo Spurio
== Series Details ==
Series: drm/i915/guc: Fix premature release of context on reset
URL : https://patchwork.freedesktop.org/series/64181/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6545_full -> Patchwork_13737_full
== Series Details ==
Series: series starting with [1/3] drm/i915: Fix GuC documentation links
URL : https://patchwork.freedesktop.org/series/64190/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6545 -> Patchwork_13740
== Series Details ==
Series: Associate ddc adapters with connectors (rev2)
URL : https://patchwork.freedesktop.org/series/63558/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6545_full -> Patchwork_13736_full
Summary
== Series Details ==
Series: Refactor to expand subslice mask (rev 2)
URL : https://patchwork.freedesktop.org/series/64188/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6545 -> Patchwork_13739
Summary
---
Hi Jose,
James Bottomley schreef op do 18-07-2019 om 06:29 [+0900]:
> On Wed, 2019-07-17 at 23:27 +0200, Paul Bolle wrote:
> > I've just reached a day of uptime with your revert. (The proper
> > uptime is just a fraction of a day, this being a laptop.) Anyhow, no
> > screen freezes occurred
== Series Details ==
Series: series starting with [1/5] drm/i915: Split i915_gem_init_hw into GT and
i915 parts (rev2)
URL : https://patchwork.freedesktop.org/series/64164/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6545_full -> Patchwork_13734_full
== Series Details ==
Series: drm/i915/gem: Make caps.scheduler static
URL : https://patchwork.freedesktop.org/series/64186/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6545 -> Patchwork_13738
Summary
---
== Series Details ==
Series: series starting with [1/3] drm/i915: Fix GuC documentation links
URL : https://patchwork.freedesktop.org/series/64190/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
b6534971a681 drm/i915: Fix GuC documentation links
-:9:
On 7/24/19 10:34 AM, Michal Wajdeczko wrote:
Generic uc firmware layout definitions are unlikely to change and
are separate to other GuC specific definitions.
Signed-off-by: Michal Wajdeczko
Cc: Daniele Ceraolo Spurio
Keeping things that apply to HuC as well in a generic file seems
On 7/24/19 10:34 AM, Michal Wajdeczko wrote:
Sphinx was rendering firmware layout as html table, but since
we want to add sizes relations switch to plain text graphics.
Signed-off-by: Michal Wajdeczko
Cc: Daniele Ceraolo Spurio
---
drivers/gpu/drm/i915/gt/uc/intel_uc_fw_abi.h | 25
On 7/24/19 10:34 AM, Michal Wajdeczko wrote:
We moved GuC related files to new location but we missed to update
.rst file with links.
References: commit 0f261b241d9c ("drm/i915/uc: move GuC and HuC files under
gt/uc/")
Signed-off-by: Michal Wajdeczko
Cc: Daniele Ceraolo Spurio
Cc: Chris
On Wed, Jul 24, 2019 at 05:27:42PM +, Souza, Jose wrote:
> On Wed, 2019-07-24 at 14:06 +0200, Greg KH wrote:
> > On Mon, Jul 22, 2019 at 04:13:25PM -0700, Dhinakaran Pandiyan wrote:
> > > A single 32-bit PSR2 training pattern field follows the sixteen
> > > element
> > > array of PSR table
Sphinx was rendering firmware layout as html table, but since
we want to add sizes relations switch to plain text graphics.
Signed-off-by: Michal Wajdeczko
Cc: Daniele Ceraolo Spurio
---
drivers/gpu/drm/i915/gt/uc/intel_uc_fw_abi.h | 25 +---
1 file changed, 11 insertions(+),
We moved GuC related files to new location but we missed to update
.rst file with links.
References: commit 0f261b241d9c ("drm/i915/uc: move GuC and HuC files under
gt/uc/")
Signed-off-by: Michal Wajdeczko
Cc: Daniele Ceraolo Spurio
Cc: Chris Wilson
---
Documentation/gpu/i915.rst | 10
Generic uc firmware layout definitions are unlikely to change and
are separate to other GuC specific definitions.
Signed-off-by: Michal Wajdeczko
Cc: Daniele Ceraolo Spurio
---
Documentation/gpu/i915.rst | 2 +-
drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h | 70
On 7/24/19 10:24 AM, Michal Wajdeczko wrote:
On Wed, 24 Jul 2019 18:37:52 +0200, Daniele Ceraolo Spurio
wrote:
- uc_fw->load_status = INTEL_UC_FIRMWARE_SUCCESS;
- DRM_DEBUG_DRIVER("%s fw load %s\n",
- intel_uc_fw_type_repr(uc_fw->type),
-
== Series Details ==
Series: Refactor to expand subslice mask (rev 2)
URL : https://patchwork.freedesktop.org/series/64188/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
d83520f343cd drm/i915: Use variable for debugfs device status
c7ec1447ee8f drm/i915: Add function to set
On Wed, 2019-07-24 at 14:06 +0200, Greg KH wrote:
> On Mon, Jul 22, 2019 at 04:13:25PM -0700, Dhinakaran Pandiyan wrote:
> > A single 32-bit PSR2 training pattern field follows the sixteen
> > element
> > array of PSR table entries in the VBT spec. But, we incorrectly
> > define
> > this PSR2
On Wed, 24 Jul 2019 18:37:52 +0200, Daniele Ceraolo Spurio
wrote:
-uc_fw->load_status = INTEL_UC_FIRMWARE_SUCCESS;
-DRM_DEBUG_DRIVER("%s fw load %s\n",
- intel_uc_fw_type_repr(uc_fw->type),
- intel_uc_fw_status_repr(uc_fw->load_status));
+uc_fw->status =
Am 24.07.19 um 15:59 schrieb Andrzej Pietrasiewicz:
> Use the ddc pointer provided by the generic connector.
>
> Signed-off-by: Andrzej Pietrasiewicz
> ---
> drivers/gpu/drm/ast/ast_mode.c | 13 -
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git
Am 24.07.19 um 15:59 schrieb Andrzej Pietrasiewicz:
> Use the ddc pointer provided by the generic connector.
>
> Signed-off-by: Andrzej Pietrasiewicz
> ---
> drivers/gpu/drm/mgag200/mgag200_mode.c | 13 +++--
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git
Hi
Am 24.07.19 um 15:59 schrieb Andrzej Pietrasiewicz:
> Allow passing ddc adapter pointer to the init function. Even if
> drm_connector_init() sometime in the future decides to e.g. memset() all
> connector fields to zeros, the newly added function ensures that at its
> completion the ddc member
Add a new SSEU runtime parameter, eu_stride, which is
used to mirror the userspace concept of a range of EUs
per subslice.
This patch simply adds the parameter and updates usage
in the QUERY_TOPOLOGY_INFO handler.
Signed-off-by: Stuart Summers
---
drivers/gpu/drm/i915/gt/intel_sseu.c | 1 +
Add a new parameter, ss_stride, to the runtime info
structure. This is used to mirror the userspace concept
of subslice stride, which is a range of subslices per slice.
This patch simply adds the definition and updates usage
in the QUERY_TOPOLOGY_INFO handler.
Signed-off-by: Stuart Summers
---
Use a local variable to find SSEU runtime information
in various debugfs functions.
Signed-off-by: Stuart Summers
---
drivers/gpu/drm/i915/i915_debugfs.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
Refactor instdone loops to use the new intel_sseu_has_subslice
function.
Signed-off-by: Stuart Summers
---
drivers/gpu/drm/i915/gt/intel_engine_cs.c| 3 +-
drivers/gpu/drm/i915/gt/intel_engine_types.h | 31 ++--
drivers/gpu/drm/i915/gt/intel_hangcheck.c| 3 +-
Add a new function to allow each platform to set maximum
slice, subslice, and EU information to reduce code duplication.
Signed-off-by: Stuart Summers
---
drivers/gpu/drm/i915/gt/intel_sseu.c | 8 +
drivers/gpu/drm/i915/gt/intel_sseu.h | 3 ++
drivers/gpu/drm/i915/i915_debugfs.c
Add a new function to determine whether a particular slice
has a given subslice.
Signed-off-by: Stuart Summers
---
drivers/gpu/drm/i915/gt/intel_sseu.h | 10 ++
drivers/gpu/drm/i915/intel_device_info.c | 9 -
2 files changed, 14 insertions(+), 5 deletions(-)
diff --git
Currently, the subslice_mask runtime parameter is stored as an
array of subslices per slice. Expand the subslice mask array to
better match what is presented to userspace through the
I915_QUERY_TOPOLOGY_INFO ioctl. The index into this array is
then calculated:
slice * subslice stride + subslice
Add a new function to set a range of subslices for a
specified slice based on a given mask.
Signed-off-by: Stuart Summers
---
drivers/gpu/drm/i915/gt/intel_sseu.c | 10 +
drivers/gpu/drm/i915/gt/intel_sseu.h | 3 ++
drivers/gpu/drm/i915/intel_device_info.c | 53
Currently, the subslice_mask runtime parameter is stored as an
array of subslices per slice. Expand the subslice mask array to
better match what is presented to userspace through the
I915_QUERY_TOPOLOGY_INFO ioctl. The index into this array is
then calculated:
slice * subslice stride + subslice
Add a new function to copy subslices for a specified slice
between intel_sseu structures for the purpose of determining
power-gate status.
Signed-off-by: Stuart Summers
---
drivers/gpu/drm/i915/i915_debugfs.c | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff
== Series Details ==
Series: drm/i915/guc: Fix premature release of context on reset
URL : https://patchwork.freedesktop.org/series/64181/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6545 -> Patchwork_13737
Summary
On 7/24/2019 5:35 AM, Michal Wajdeczko wrote:
On Wed, 24 Jul 2019 04:21:48 +0200, Daniele Ceraolo Spurio
wrote:
We currently track fetch and load status separately, but the 2 are
actually sequential in the uc lifetime (fetch must complete before we
can attempt the load!). Unifying the 2
== Series Details ==
Series: Associate ddc adapters with connectors (rev2)
URL : https://patchwork.freedesktop.org/series/63558/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6545 -> Patchwork_13736
Summary
---
== Series Details ==
Series: drm/i915: Unshare the idle-barrier from other kernel requests (rev2)
URL : https://patchwork.freedesktop.org/series/64171/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6545 -> Patchwork_13735
On 7/24/2019 4:31 AM, Michal Wajdeczko wrote:
On Wed, 24 Jul 2019 04:21:47 +0200, Daniele Ceraolo Spurio
wrote:
Instead of having 2 identical functions for GuC and HuC firmware
selection, we can unify the selection logic and just use different lists
based on FW type.
Note that the revid
We do not notify userspace when the scheduler capabilities are changed
(due to wedging the driver) and as such userspace will expect the caps
to be static and unchanging. Make it so, and so we only need to compute
our caps once during driver registration.
Signed-off-by: Chris Wilson
Cc: Tvrtko
== Series Details ==
Series: series starting with [1/5] drm/i915: Split i915_gem_init_hw into GT and
i915 parts (rev2)
URL : https://patchwork.freedesktop.org/series/64164/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6545 -> Patchwork_13734
Quoting Janusz Krzysztofik (2019-07-24 16:05:25)
> When using GuC submission, some execlists originated helper functions
> are reused. One of them, used inside guc_reset() and
> guc_cancel_requests() callbacks introduced by commit 292ad25c22d9
> ("drm/i915/guc: Implement reset locally"),
Quoting Janusz Krzysztofik (2019-07-24 16:05:25)
> When using GuC submission, some execlists originated helper functions
> are reused. One of them, used inside guc_reset() and
> guc_cancel_requests() callbacks introduced by commit 292ad25c22d9
> ("drm/i915/guc: Implement reset locally"),
When using GuC submission, some execlists originated helper functions
are reused. One of them, used inside guc_reset() and
guc_cancel_requests() callbacks introduced by commit 292ad25c22d9
("drm/i915/guc: Implement reset locally"), unfortunately calls
execlists_schedule_out() helper instead of
Quoting Francisco Jerez (2019-07-23 23:19:13)
> Chris Wilson writes:
>
> > Quoting Tvrtko Ursulin (2019-07-22 12:41:36)
> >>
> >> On 20/07/2019 15:31, Chris Wilson wrote:
> >> > Enabling atomic operations in L3 leads to unrecoverable GPU hangs, as
> >> > the machine stops responding
== Series Details ==
Series: Associate ddc adapters with connectors (rev2)
URL : https://patchwork.freedesktop.org/series/63558/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
8ca228e56f33 drm: Include ddc adapter pointer in struct drm_connector
c9a7fb60189d drm: Add
Quoting Michal Wajdeczko (2019-07-24 13:55:23)
> On Wed, 24 Jul 2019 04:21:50 +0200, Daniele Ceraolo Spurio
> wrote:
>
> > The binary is perma-pinned and the rsa is not going to change, so copy
> > it only once and not on every load.
>
> as this new location is accessible from the GuC, what
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/i915/display/intel_hdmi.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/radeon/radeon_connectors.c | 141 +++--
1 file changed, 105 insertions(+), 36 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 46 ---
1 file changed, 24 insertions(+), 22 deletions(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/bridge/ti-tfp410.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
---
.../gpu/drm/amd/amdgpu/amdgpu_connectors.c| 95 ++-
1 file changed, 69 insertions(+), 26 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/bridge/dumb-vga-dac.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/ast/ast_mode.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/mgag200/mgag200_mode.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/zte/zx_vga.c | 31 +--
1 file changed, 13 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/zte/zx_vga.c b/drivers/gpu/drm/zte/zx_vga.c
index
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/sti/sti_hdmi.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
index
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
index
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/zte/zx_hdmi.c | 31 +--
1 file changed, 13 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/zte/zx_hdmi.c b/drivers/gpu/drm/zte/zx_hdmi.c
index
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/imx/imx-ldb.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c
index
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/imx/imx-tve.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c
index
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/mediatek/mtk_hdmi.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c
b/drivers/gpu/drm/mediatek/mtk_hdmi.c
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/tegra/drm.h| 1 -
drivers/gpu/drm/tegra/hdmi.c | 7 ---
drivers/gpu/drm/tegra/output.c | 12 ++--
drivers/gpu/drm/tegra/sor.c| 13 +++--
4 files
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/sun4i/sun4i_hdmi.h | 1 -
drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 21 +++--
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/rockchip/rk3066_hdmi.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/rockchip/inno_hdmi.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c
Switch to using the ddc provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
Allow passing ddc adapter pointer to the init function. Even if
drm_connector_init() sometime in the future decides to e.g. memset() all
connector fields to zeros, the newly added function ensures that at its
completion the ddc member of connector is correctly set.
Signed-off-by: Andrzej
Add generic code which creates symbolic links in sysfs, pointing to ddc
interface used by a particular video output. For example:
ls -l /sys/class/drm/card0-HDMI-A-1/ddc
lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0-HDMI-A-1/ddc \
-> ../../../../soc/1388.i2c/i2c-2
This
It is difficult for a user to know which of the i2c adapters is for which
drm connector. This series addresses this problem.
The idea is to have a symbolic link in connector's sysfs directory, e.g.:
ls -l /sys/class/drm/card0-HDMI-A-1/ddc
lrwxrwxrwx 1 root root 0 Jun 24 10:42
1 - 100 of 138 matches
Mail list logo