[Intel-gfx] ✓ Fi.CI.BAT: success for TGL TC enabling v2-CI (rev2)

2019-09-20 Thread Patchwork
== Series Details == Series: TGL TC enabling v2-CI (rev2) URL : https://patchwork.freedesktop.org/series/67022/ State : success == Summary == CI Bug Log - changes from CI_DRM_6932 -> Patchwork_14486 Summary --- **SUCCESS** No

Re: [Intel-gfx] [PATCH v2 08/13] drm/i915/tgl: Add dkl phy programming sequences

2019-09-20 Thread Souza, Jose
On Fri, 2019-09-20 at 14:44 -0700, Lucas De Marchi wrote: > On Wed, Sep 18, 2019 at 5:07 PM José Roberto de Souza > wrote: > > From: Clinton A Taylor > > > > Added DKL Phy sequences and helpers functions to program voltage > > swing, clock gating and dp mode. > > > > It is not written in DP

[Intel-gfx] [PATCH i-g-t] i915/gem_exec_balancer: Check for scheduling bonded-pairs on the same engine

2019-09-20 Thread Chris Wilson
The expectation for bonded submission is that they are run concurrently, in parallel on multiple engines. However, given a lack of constraints in the scheduler's selection combined with timeslicing could mean that the bonded requests could be run in opposite order on the same engine. With just the

[Intel-gfx] ✗ Fi.CI.BAT: failure for TGL TC enabling v2-CI

2019-09-20 Thread Patchwork
== Series Details == Series: TGL TC enabling v2-CI URL : https://patchwork.freedesktop.org/series/67022/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6932 -> Patchwork_14485 Summary --- **FAILURE** Serious

Re: [Intel-gfx] [PATCH v2 08/13] drm/i915/tgl: Add dkl phy programming sequences

2019-09-20 Thread Lucas De Marchi
On Wed, Sep 18, 2019 at 5:07 PM José Roberto de Souza wrote: > > From: Clinton A Taylor > > Added DKL Phy sequences and helpers functions to program voltage > swing, clock gating and dp mode. > > It is not written in DP enabling sequence but "PHY Clockgating > programming" states that clock

Re: [Intel-gfx] [PATCH] drm/i915: Allow set context SSEU on platforms after gen 11

2019-09-20 Thread Summers, Stuart
On Fri, 2019-09-20 at 22:29 +0100, Chris Wilson wrote: > Quoting Summers, Stuart (2019-09-20 22:09:46) > > On Thu, 2019-09-19 at 08:00 +0100, Tvrtko Ursulin wrote: > > > On 18/09/2019 18:31, Stuart Summers wrote: > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110559 > > > > > >

Re: [Intel-gfx] [PATCH] drm/i915: Allow set context SSEU on platforms after gen 11

2019-09-20 Thread Chris Wilson
Quoting Summers, Stuart (2019-09-20 22:09:46) > On Thu, 2019-09-19 at 08:00 +0100, Tvrtko Ursulin wrote: > > On 18/09/2019 18:31, Stuart Summers wrote: > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110559 > > > > Unless there was some discussion I missed we can't just turn it on >

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/selftests: Verify the LRC register layout between init and HW

2019-09-20 Thread Chris Wilson
Quoting Patchwork (2019-09-20 22:08:48) > == Series Details == > > Series: series starting with [1/2] drm/i915/selftests: Verify the LRC > register layout between init and HW > URL : https://patchwork.freedesktop.org/series/67018/ > State : success > > == Summary == > > CI Bug Log - changes

Re: [Intel-gfx] [PATCH] drm/i915: Allow set context SSEU on platforms after gen 11

2019-09-20 Thread Summers, Stuart
On Wed, 2019-09-18 at 13:39 -0700, Daniele Ceraolo Spurio wrote: > > On 9/18/19 10:31 AM, Stuart Summers wrote: > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110559 > > > > What's the planned usage here? TGL HW only supports slice-level > power-gating and with only 1 slice on TGL

Re: [Intel-gfx] [PATCH] drm/i915: Allow set context SSEU on platforms after gen 11

2019-09-20 Thread Summers, Stuart
On Thu, 2019-09-19 at 08:00 +0100, Tvrtko Ursulin wrote: > On 18/09/2019 18:31, Stuart Summers wrote: > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110559 > > Unless there was some discussion I missed we can't just turn it on > to > work around a SKIP in IGT. Feature was

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/selftests: Verify the LRC register layout between init and HW

2019-09-20 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: Verify the LRC register layout between init and HW URL : https://patchwork.freedesktop.org/series/67018/ State : success == Summary == CI Bug Log - changes from CI_DRM_6932 -> Patchwork_14484

Re: [Intel-gfx] [PATCH v2 07/13] drm/i915/tgl: TC helper function to return pin mapping

2019-09-20 Thread Lucas De Marchi
On Fri, Sep 20, 2019 at 1:54 PM Lucas De Marchi wrote: > > On Wed, Sep 18, 2019 at 5:07 PM José Roberto de Souza > wrote: > > > > From: Clinton A Taylor > > > > Add a helper function to return pin map for use during dkl phy > > DP_MODE settings, PORT_TX_DFLEXPA1 exist on ICL but we don't need

[Intel-gfx] [PATCH CI 2/6] drm/i915/tgl: Finish modular FIA support on registers

2019-09-20 Thread José Roberto de Souza
If platform supports and has modular FIA is enabled, the registers bits also change, example: reading TC3 registers with modular FIA enabled, driver should read from FIA2 but with TC1 bits offsets. It is described in BSpec 50231 for DFLEXDPSP, other registers don't have the BSpec description but

[Intel-gfx] [PATCH CI 1/6] drm/i915/tgl: Add missing ddi clock select during DP init sequence

2019-09-20 Thread José Roberto de Souza
From: Clinton A Taylor Step 4.b was complete missed because it is only required to TC and TBT. Bspec: 49190 Reviewed-by: Imre Deak Reviewed-by: Lucas De Marchi Signed-off-by: Clinton A Taylor Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_ddi.c | 5 - 1

[Intel-gfx] [PATCH CI 0/6] TGL TC enabling v2-CI

2019-09-20 Thread José Roberto de Souza
Patches from https://patchwork.freedesktop.org/series/66695/#rev2 that got rv-b and don't have dependencies over other patches, for CI testing. Clinton A Taylor (2): drm/i915/tgl: Add missing ddi clock select during DP init sequence drm/i915/tgl/pll: Set update_active_dpll José Roberto de

[Intel-gfx] [PATCH CI 5/6] drm/i915/icl: Unify disable and enable phy clock gating functions

2019-09-20 Thread José Roberto de Souza
Adding a enable parameters allow us to share most of the code between enable and disable functions. v3: Renamed icl_phy_clock_gating() to icl_phy_set_clock_gating() Reviewed-by: Lucas De Marchi Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_ddi.c | 73

[Intel-gfx] [PATCH CI 3/6] drm/i915/tgl/pll: Set update_active_dpll

2019-09-20 Thread José Roberto de Souza
From: Clinton A Taylor Commit 24a7bfe0c2d7 ("drm/i915: Keep the TypeC port mode fixed when the port is active") added this new hook while in parallel TGL upstream was happening and this was missed. Without this driver will crash when TC DDI is added and driver is preparing to do a full modeset.

[Intel-gfx] [PATCH CI 4/6] drm/i915/tgl: Add dkl phy registers

2019-09-20 Thread José Roberto de Souza
From: Vandita Kulkarni These are the registers needed to program Dekel phy. Some register definitions will be reused from MG PHY definitions, so adding a comment on those. Bspec: 49295 Reviewed-by: Lucas De Marchi Signed-off-by: Vandita Kulkarni Signed-off-by: Clinton A Taylor

[Intel-gfx] [PATCH CI 6/6] drm/i915/tgl: Check the UC health of tc controllers after power on

2019-09-20 Thread José Roberto de Souza
New step added for TGL, required for us to check the TC microcontroller health after power on TC aux. BSpec: 49294 Reviewed-by: Imre Deak Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display_power.c | 13 + 1 file changed, 13 insertions(+) diff

Re: [Intel-gfx] [PATCH v2 07/13] drm/i915/tgl: TC helper function to return pin mapping

2019-09-20 Thread Lucas De Marchi
On Wed, Sep 18, 2019 at 5:07 PM José Roberto de Souza wrote: > > From: Clinton A Taylor > > Add a helper function to return pin map for use during dkl phy > DP_MODE settings, PORT_TX_DFLEXPA1 exist on ICL but we don't need it. > > The user of this function will come in future TC patches. > >

Re: [Intel-gfx] [PATCH v2 06/13] drm/i915/tgl: Add support for dkl pll write

2019-09-20 Thread Lucas De Marchi
On Wed, Sep 18, 2019 at 5:07 PM José Roberto de Souza wrote: > > From: Vandita Kulkarni > > Add a new function to write to dkl phy pll registers. As per the > bspec all the registers are read modify write. > > Signed-off-by: Vandita Kulkarni > Signed-off-by: José Roberto de Souza >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/selftests: Verify the LRC register layout between init and HW

2019-09-20 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: Verify the LRC register layout between init and HW URL : https://patchwork.freedesktop.org/series/67018/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2b9117e29756 drm/i915/selftests: Verify the LRC

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/6] drm/i915: add i915_driver_modeset_remove()

2019-09-20 Thread Patchwork
== Series Details == Series: series starting with [v2,1/6] drm/i915: add i915_driver_modeset_remove() URL : https://patchwork.freedesktop.org/series/67013/ State : success == Summary == CI Bug Log - changes from CI_DRM_6931 -> Patchwork_14483

[Intel-gfx] [PATCH 2/2] drm/i915/tgl: Swap engines for rc6/powersaving

2019-09-20 Thread Chris Wilson
Disable rc6 to re-enable all engines. It seems that the multi-engine machine lockup is tied to rc6; disabling it makes a gem-sync --run basic-store-all survive for a few hours, whereas without we expect it to die within seconds. The only question is how does CI fare with the exchange? For testing

[Intel-gfx] [PATCH 1/2] drm/i915/selftests: Verify the LRC register layout between init and HW

2019-09-20 Thread Chris Wilson
Before we submit the first context to HW, we need to construct a valid image of the register state. This layout is defined by the HW and should match the layout generated by HW when it saves the context image. Asserting that this should be equivalent should help avoid any undefined behaviour and

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/6] drm/i915: add i915_driver_modeset_remove()

2019-09-20 Thread Patchwork
== Series Details == Series: series starting with [v2,1/6] drm/i915: add i915_driver_modeset_remove() URL : https://patchwork.freedesktop.org/series/67013/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4f0318a8e293 drm/i915: add i915_driver_modeset_remove() 78b6e3b96f95

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl: Swap engines for rc6/powersaving

2019-09-20 Thread Chris Wilson
Quoting Patchwork (2019-09-20 20:52:03) > == Series Details == > > Series: drm/i915/tgl: Swap engines for rc6/powersaving > URL : https://patchwork.freedesktop.org/series/67010/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_6931 -> Patchwork_14482 >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl: Swap engines for rc6/powersaving

2019-09-20 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Swap engines for rc6/powersaving URL : https://patchwork.freedesktop.org/series/67010/ State : success == Summary == CI Bug Log - changes from CI_DRM_6931 -> Patchwork_14482 Summary ---

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: pass i915 to intel_modeset_init() and intel_modeset_init_hw()

2019-09-20 Thread Jani Nikula
On Fri, 20 Sep 2019, Jani Nikula wrote: > In general, prefer struct drm_i915_private * over struct drm_device * > when either will do. Rename the local variables to i915. No functional > changes. This one was also already Reviewed-by: Chris Wilson in

Re: [Intel-gfx] [PATCH v2 1/6] drm/i915: add i915_driver_modeset_remove()

2019-09-20 Thread Jani Nikula
Please ignore the two patches here. Critical fumble. BR, Jani. On Fri, 20 Sep 2019, Jani Nikula wrote: > For completeness, add counterpart to i915_driver_modeset_probe() and > remove the asymmetry in the probe/remove parts. No functional changes. > > Reviewed-by: Chris Wilson >

[Intel-gfx] [PATCH v2 6/6] drm/i915: pass i915 to intel_modeset_init() and intel_modeset_init_hw()

2019-09-20 Thread Jani Nikula
In general, prefer struct drm_i915_private * over struct drm_device * when either will do. Rename the local variables to i915. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 69 ++--

[Intel-gfx] [PATCH v2 4/6] drm/i915: abstract intel_panel_sanitize_ssc() from intel_modeset_init()

2019-09-20 Thread Jani Nikula
The code is too specific and detailed to have open in a high level function. Abstract away. As a drive-by improvement switch to using enableddisabled() in logging and git rid of a redundant !!. No functional changes. v2: drop the !! while at it too (Chris) Reviewed-by: Chris Wilson

[Intel-gfx] [PATCH v2 1/6] drm/i915: add i915_driver_modeset_remove()

2019-09-20 Thread Jani Nikula
For completeness, add counterpart to i915_driver_modeset_probe() and remove the asymmetry in the probe/remove parts. No functional changes. Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.c | 25 +++-- 1 file changed, 15 insertions(+),

[Intel-gfx] [PATCH v2 2/6] drm/i915: pass i915 to i915_driver_modeset_probe()

2019-09-20 Thread Jani Nikula
In general, prefer struct drm_i915_private * over struct drm_device * when either will do. Rename the local variable to i915. No functional changes. Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.c | 59 - 1 file changed,

[Intel-gfx] [PATCH v2 3/6] drm/i915: pass i915 to intel_modeset_driver_remove()

2019-09-20 Thread Jani Nikula
In general, prefer struct drm_i915_private * over struct drm_device * when either will do. Rename the local variable to i915. Also propagate to intel_hpd_poll_fini(). No functional changes. Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c |

[Intel-gfx] [PATCH v2 5/6] drm/i915: abstract intel_mode_config_init() from intel_modeset_init()

2019-09-20 Thread Jani Nikula
The i915 specific mode config init code is too specific and detailed to have open in a high level function. Abstract away. No functional changes. v2: nest drm_mode_config_init() in the function too (Chris) Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula ---

[Intel-gfx] [PATCH v2 1/6] drm/i915: add i915_driver_modeset_remove()

2019-09-20 Thread Jani Nikula
For completeness, add counterpart to i915_driver_modeset_probe() and remove the asymmetry in the probe/remove parts. No functional changes. Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.c | 25 +++-- 1 file changed, 15 insertions(+),

[Intel-gfx] [PATCH v2 2/6] drm/i915: pass i915 to i915_driver_modeset_probe()

2019-09-20 Thread Jani Nikula
In general, prefer struct drm_i915_private * over struct drm_device * when either will do. Rename the local variable to i915. No functional changes. Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.c | 59 - 1 file changed,

Re: [Intel-gfx] [PATCH 00/12] drm/i915: YCbCr output fixes and prep work for YCbCr 4:4:4 output

2019-09-20 Thread Ville Syrjälä
On Thu, Jul 18, 2019 at 05:50:41PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > I was playing around with YCbCr 4:4:4 output and noticed several > things wrong in our code. So I fixed it all and tossed in the > prep work for YCbCr 4:4:4 output on ilk+. > > Ville Syrjälä (12): >

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,v2,1/6] drm/i915/display/icl: Save Master transcoder in slave's crtc_state for Transcoder Port Sync (rev2)

2019-09-20 Thread Patchwork
== Series Details == Series: series starting with [CI,v2,1/6] drm/i915/display/icl: Save Master transcoder in slave's crtc_state for Transcoder Port Sync (rev2) URL : https://patchwork.freedesktop.org/series/66956/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6929 ->

[Intel-gfx] [PATCH] drm/i915/tgl: Swap engines for rc6/powersaving

2019-09-20 Thread Chris Wilson
Disable rc6 to re-enable all engines. It seems that the multi-engine machine lockup is tied to rc6; disabling it makes a gem-sync --run basic-store-all survive for a few hours, whereas without we expect it to die within seconds. The only question is how does CI fare with the exchange? For testing

Re: [Intel-gfx] [PATCH v2 09/13] drm/i915/icl: Unify disable and enable phy clock gating functions

2019-09-20 Thread Lucas De Marchi
On Wed, Sep 18, 2019 at 5:07 PM José Roberto de Souza wrote: > > Adding a enable parameters allow us to share most of the code between > enable and disable functions. > > Signed-off-by: José Roberto de Souza > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 71 > 1

Re: [Intel-gfx] [drm-intel:drm-intel-next-queued 6/7] drivers/gpu/drm/i915/display/intel_color.c:1576 ilk_read_lut_10() error: potential null dereference 'blob'. (drm_property_create_blob returns null

2019-09-20 Thread Ville Syrjälä
On Sat, Sep 21, 2019 at 01:55:25AM +0800, kbuild test robot wrote: > tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued > head: 4bb6a9d5d9a8289673c4cb0786d44be8a63c21db > commit: 6b97b118d4d542c7bc25b725c6de3947fffb921b [6/7] drm/i915/display: > Extract ilk_read_luts() > >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,v2,1/6] drm/i915/display/icl: Save Master transcoder in slave's crtc_state for Transcoder Port Sync (rev2)

2019-09-20 Thread Patchwork
== Series Details == Series: series starting with [CI,v2,1/6] drm/i915/display/icl: Save Master transcoder in slave's crtc_state for Transcoder Port Sync (rev2) URL : https://patchwork.freedesktop.org/series/66956/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915/guc: Enable guc logging on guc log relay write

2019-09-20 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/guc: Enable guc logging on guc log relay write URL : https://patchwork.freedesktop.org/series/67009/ State : success == Summary == CI Bug Log - changes from CI_DRM_6929 -> Patchwork_14480

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/2] drm/i915/uc: Update HuC firmware naming convention and load latest HuC

2019-09-20 Thread Daniele Ceraolo Spurio
On 9/20/19 5:51 AM, Patchwork wrote: == Series Details == Series: series starting with [CI,1/2] drm/i915/uc: Update HuC firmware naming convention and load latest HuC URL : https://patchwork.freedesktop.org/series/66955/ State : failure == Summary == CI Bug Log - changes from

[Intel-gfx] [drm-intel:drm-intel-next-queued 6/7] drivers/gpu/drm/i915/display/intel_color.c:1576 ilk_read_lut_10() error: potential null dereference 'blob'. (drm_property_create_blob returns null)

2019-09-20 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued head: 4bb6a9d5d9a8289673c4cb0786d44be8a63c21db commit: 6b97b118d4d542c7bc25b725c6de3947fffb921b [6/7] drm/i915/display: Extract ilk_read_luts() If you fix the issue, kindly add following tag Reported-by: kbuild test robot

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915/guc: Enable guc logging on guc log relay write

2019-09-20 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/guc: Enable guc logging on guc log relay write URL : https://patchwork.freedesktop.org/series/67009/ State : warning == Summary == $ dim checkpatch origin/drm-tip 46eb3a716fff drm/i915/guc: Enable guc logging on guc log

[Intel-gfx] ✗ Fi.CI.BUILD: failure for treewide: remove unused argument in lock_release()

2019-09-20 Thread Patchwork
== Series Details == Series: treewide: remove unused argument in lock_release() URL : https://patchwork.freedesktop.org/series/67007/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK

Re: [Intel-gfx] [PATCH] drm/i915: Prevent bonded requests from overtaking each other on preemption

2019-09-20 Thread Bloomfield, Jon
> -Original Message- > From: Chris Wilson > Sent: Friday, September 20, 2019 9:04 AM > To: Bloomfield, Jon ; intel- > g...@lists.freedesktop.org; Tvrtko Ursulin > Subject: RE: [Intel-gfx] [PATCH] drm/i915: Prevent bonded requests from > overtaking each other on preemption > > Quoting

[Intel-gfx] [CI 2/2] HAX: force enable_guc=2

2019-09-20 Thread Robert M. Fosha
From: Anusha Srivatsa Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index d29ade3b7de6..f9fbb1f2fabf 100644 ---

[Intel-gfx] [CI 1/2] drm/i915/guc: Enable guc logging on guc log relay write

2019-09-20 Thread Robert M. Fosha
Creating and opening the GuC log relay file enables and starts the relay potentially before the caller is ready to consume logs. Change the behavior so that relay starts only on an explicit call to the write function (with a value of '1'). Other values flush the log relay as before. v2: Style

Re: [Intel-gfx] [PATCH 01/23] drm/i915/dp: Fix dsc bpp calculations, v2.

2019-09-20 Thread Ville Syrjälä
On Fri, Sep 20, 2019 at 01:42:13PM +0200, Maarten Lankhorst wrote: > There was a integer wraparound when mode_clock became too high, > and we didn't correct for the FEC overhead factor when dividing, > with the calculations breaking at HBR3. > > As a result our calculated bpp was way too high,

Re: [Intel-gfx] [PATCH -next] treewide: remove unused argument in lock_release()

2019-09-20 Thread Will Deacon
On Fri, Sep 20, 2019 at 08:50:36AM -0400, Qian Cai wrote: > On Fri, 2019-09-20 at 10:38 +0100, Will Deacon wrote: > > On Thu, Sep 19, 2019 at 12:09:40PM -0400, Qian Cai wrote: > > > Since the commit b4adfe8e05f1 ("locking/lockdep: Remove unused argument > > > in __lock_release"), @nested is no

Re: [Intel-gfx] [PATCH -next] treewide: remove unused argument in lock_release()

2019-09-20 Thread Will Deacon
On Thu, Sep 19, 2019 at 12:09:40PM -0400, Qian Cai wrote: > Since the commit b4adfe8e05f1 ("locking/lockdep: Remove unused argument > in __lock_release"), @nested is no longer used in lock_release(), so > remove it from all lock_release() calls and friends. > > Signed-off-by: Qian Cai > ---

Re: [Intel-gfx] [PATCH -next] treewide: remove unused argument in lock_release()

2019-09-20 Thread Qian Cai
On Fri, 2019-09-20 at 10:38 +0100, Will Deacon wrote: > On Thu, Sep 19, 2019 at 12:09:40PM -0400, Qian Cai wrote: > > Since the commit b4adfe8e05f1 ("locking/lockdep: Remove unused argument > > in __lock_release"), @nested is no longer used in lock_release(), so > > remove it from all

[Intel-gfx] [PATCH -next] treewide: remove unused argument in lock_release()

2019-09-20 Thread Qian Cai
Since the commit b4adfe8e05f1 ("locking/lockdep: Remove unused argument in __lock_release"), @nested is no longer used in lock_release(), so remove it from all lock_release() calls and friends. Signed-off-by: Qian Cai --- drivers/gpu/drm/drm_connector.c | 2 +-

Re: [Intel-gfx] [PATCH 12/21] drm/i915: Mark up address spaces that may need to allocate

2019-09-20 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-09-20 17:22:42) > > On 02/09/2019 05:02, Chris Wilson wrote: > > Since we cannot allocate underneath the vm->mutex (it is used in the > > direct-reclaim paths), we need to shift the allocations off into a > > mutexless worker with fence recursion prevention. To know

Re: [Intel-gfx] [PATCH 15/21] drm/i915: Coordinate i915_active with its own mutex

2019-09-20 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-09-20 17:14:43) > > On 02/09/2019 05:02, Chris Wilson wrote: > > diff --git a/drivers/gpu/drm/i915/gt/intel_timeline_types.h > > b/drivers/gpu/drm/i915/gt/intel_timeline_types.h > > index 2b1baf2fcc8e..6d7ac129ce8a 100644 > > ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Mark contents as dirty on a write fault

2019-09-20 Thread Patchwork
== Series Details == Series: drm/i915: Mark contents as dirty on a write fault URL : https://patchwork.freedesktop.org/series/67000/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6928 -> Patchwork_14478 Summary ---

Re: [Intel-gfx] [PATCH 12/21] drm/i915: Mark up address spaces that may need to allocate

2019-09-20 Thread Tvrtko Ursulin
On 02/09/2019 05:02, Chris Wilson wrote: Since we cannot allocate underneath the vm->mutex (it is used in the direct-reclaim paths), we need to shift the allocations off into a mutexless worker with fence recursion prevention. To know when we need this protection, we mark up the address spaces

Re: [Intel-gfx] [PATCH 16/21] drm/i915: Move idle barrier cleanup into engine-pm

2019-09-20 Thread Tvrtko Ursulin
On 02/09/2019 05:02, Chris Wilson wrote: Now that we now longer need to guarantee that the active callback is under the struct_mutex, we can lift it out of the i915_gem_park() and into the engine parking itself. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_pm.c| 19

Re: [Intel-gfx] [PATCH 15/21] drm/i915: Coordinate i915_active with its own mutex

2019-09-20 Thread Tvrtko Ursulin
On 02/09/2019 05:02, Chris Wilson wrote: Forgo the struct_mutex serialisation for i915_active, and interpose its own mutex handling for active/retire. This is a multi-layered sleight-of-hand. First, we had to ensure that no active/retire callbacks accidentally inverted the mutex ordering

Re: [Intel-gfx] [PATCH] video/hdmi: Fix AVI bar unpack

2019-09-20 Thread Ville Syrjälä
On Fri, Sep 20, 2019 at 04:58:53PM +0200, Thierry Reding wrote: > On Thu, Sep 19, 2019 at 04:28:53PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > The bar values are little endian, not big endian. The pack > > function did it right but the unpack got it wrong. Fix it. > > > > Cc:

Re: [Intel-gfx] [PATCH v9 0/8] drm/i915/dp: Support for DP HDR outputs

2019-09-20 Thread Ville Syrjälä
On Thu, Sep 19, 2019 at 10:53:03PM +0300, Gwan-gyeong Mun wrote: > Support for HDR10 video was introduced in DisplayPort 1.4. > On GLK+ platform, in order to use DisplayPort HDR10, we need to support > BT.2020 colorimetry and HDR Static metadata. > It implements the CTA-861-G standard for

Re: [Intel-gfx] [PATCH] drm/i915: Prevent bonded requests from overtaking each other on preemption

2019-09-20 Thread Chris Wilson
Quoting Chris Wilson (2019-09-20 17:03:34) > Quoting Bloomfield, Jon (2019-09-20 16:50:57) > > > -Original Message- > > > From: Intel-gfx On Behalf Of > > > Tvrtko > > > Ursulin > > > Sent: Friday, September 20, 2019 8:12 AM > > > To: Chris Wilson ; > > > intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [PATCH] drm/i915: Prevent bonded requests from overtaking each other on preemption

2019-09-20 Thread Chris Wilson
Quoting Bloomfield, Jon (2019-09-20 16:50:57) > > -Original Message- > > From: Intel-gfx On Behalf Of > > Tvrtko > > Ursulin > > Sent: Friday, September 20, 2019 8:12 AM > > To: Chris Wilson ; intel-gfx@lists.freedesktop.org > > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Prevent bonded

Re: [Intel-gfx] [PATCH v9 04/10] drm/i915/dsb: Indexed register write function for DSB.

2019-09-20 Thread Animesh Manna
On 9/20/2019 5:48 PM, Jani Nikula wrote: On Fri, 20 Sep 2019, Animesh Manna wrote: DSB can program large set of data through indexed register write (opcode 0x9) in one shot. DSB feature can be used for bulk register programming e.g. gamma lut programming, HDR meta data programming. v1:

Re: [Intel-gfx] [PATCH] drm/i915: Prevent bonded requests from overtaking each other on preemption

2019-09-20 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-09-20 16:12:23) > > On 20/09/2019 15:57, Chris Wilson wrote: > > Quoting Chris Wilson (2019-09-20 09:36:24) > >> Force bonded requests to run on distinct engines so that they cannot be > >> shuffled onto the same engine where timeslicing will reverse the order. > >> A

Re: [Intel-gfx] [PATCH] drm/i915: Prevent bonded requests from overtaking each other on preemption

2019-09-20 Thread Bloomfield, Jon
> -Original Message- > From: Intel-gfx On Behalf Of Tvrtko > Ursulin > Sent: Friday, September 20, 2019 8:12 AM > To: Chris Wilson ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Prevent bonded requests from > overtaking each other on preemption > > > On

[Intel-gfx] ✓ Fi.CI.BAT: success for DSB enablement. (rev9)

2019-09-20 Thread Patchwork
== Series Details == Series: DSB enablement. (rev9) URL : https://patchwork.freedesktop.org/series/63013/ State : success == Summary == CI Bug Log - changes from CI_DRM_6928 -> Patchwork_14477 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for DSB enablement. (rev9)

2019-09-20 Thread Patchwork
== Series Details == Series: DSB enablement. (rev9) URL : https://patchwork.freedesktop.org/series/63013/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915/dsb: feature flag added for display state buffer. Okay!

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for DSB enablement. (rev9)

2019-09-20 Thread Patchwork
== Series Details == Series: DSB enablement. (rev9) URL : https://patchwork.freedesktop.org/series/63013/ State : warning == Summary == $ dim checkpatch origin/drm-tip 396d115d8cc6 drm/i915/dsb: feature flag added for display state buffer. 5a60554c2d5d drm/i915/dsb: DSB context creation.

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/23] drm/i915/dp: Fix dsc bpp calculations, v2.

2019-09-20 Thread Patchwork
== Series Details == Series: series starting with [01/23] drm/i915/dp: Fix dsc bpp calculations, v2. URL : https://patchwork.freedesktop.org/series/66998/ State : success == Summary == CI Bug Log - changes from CI_DRM_6928 -> Patchwork_14476

Re: [Intel-gfx] [PATCH] drm/i915: Prevent bonded requests from overtaking each other on preemption

2019-09-20 Thread Tvrtko Ursulin
On 20/09/2019 15:57, Chris Wilson wrote: Quoting Chris Wilson (2019-09-20 09:36:24) Force bonded requests to run on distinct engines so that they cannot be shuffled onto the same engine where timeslicing will reverse the order. A bonded request will often wait on a semaphore signaled by its

Re: [Intel-gfx] [PATCH] drm/i915: Prevent bonded requests from overtaking each other on preemption

2019-09-20 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-09-20 15:51:35) > > On 20/09/2019 13:42, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-09-20 13:24:47) > >> > >> On 20/09/2019 09:36, Chris Wilson wrote: > >>> Force bonded requests to run on distinct engines so that they cannot be > >>> shuffled onto the same

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/23] drm/i915/dp: Fix dsc bpp calculations, v2.

2019-09-20 Thread Patchwork
== Series Details == Series: series starting with [01/23] drm/i915/dp: Fix dsc bpp calculations, v2. URL : https://patchwork.freedesktop.org/series/66998/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915/dp: Fix dsc bpp calculations, v2. Okay!

Re: [Intel-gfx] [PATCH] video/hdmi: Fix AVI bar unpack

2019-09-20 Thread Thierry Reding
On Thu, Sep 19, 2019 at 04:28:53PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > The bar values are little endian, not big endian. The pack > function did it right but the unpack got it wrong. Fix it. > > Cc: sta...@vger.kernel.org > Cc: linux-me...@vger.kernel.org > Cc: Martin Bugge >

Re: [Intel-gfx] [PATCH] drm/i915: Prevent bonded requests from overtaking each other on preemption

2019-09-20 Thread Chris Wilson
Quoting Chris Wilson (2019-09-20 09:36:24) > Force bonded requests to run on distinct engines so that they cannot be > shuffled onto the same engine where timeslicing will reverse the order. > A bonded request will often wait on a semaphore signaled by its master, > creating an implicit dependency

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/23] drm/i915/dp: Fix dsc bpp calculations, v2.

2019-09-20 Thread Patchwork
== Series Details == Series: series starting with [01/23] drm/i915/dp: Fix dsc bpp calculations, v2. URL : https://patchwork.freedesktop.org/series/66998/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5a06a0350a83 drm/i915/dp: Fix dsc bpp calculations, v2. 30142b729b5c HAX

Re: [Intel-gfx] [PATCH] drm/i915: Prevent bonded requests from overtaking each other on preemption

2019-09-20 Thread Tvrtko Ursulin
On 20/09/2019 13:42, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-09-20 13:24:47) On 20/09/2019 09:36, Chris Wilson wrote: Force bonded requests to run on distinct engines so that they cannot be shuffled onto the same engine where timeslicing will reverse the order. A bonded request will

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Restrict qgv points which don't have enough bandwidth. (rev2)

2019-09-20 Thread Patchwork
== Series Details == Series: drm/i915: Restrict qgv points which don't have enough bandwidth. (rev2) URL : https://patchwork.freedesktop.org/series/66993/ State : success == Summary == CI Bug Log - changes from CI_DRM_6928 -> Patchwork_14475

Re: [Intel-gfx] [PATCH 10/12] drm/i915: Document ILK+ pipe csc matrix better

2019-09-20 Thread Ville Syrjälä
On Fri, Sep 20, 2019 at 02:24:32PM +, Mun, Gwan-gyeong wrote: > On Thu, 2019-07-18 at 17:50 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Add comments to explain the ilk pipe csc operation a bit better. > > > > Signed-off-by: Ville Syrjälä > > --- > >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Restrict qgv points which don't have enough bandwidth. (rev2)

2019-09-20 Thread Patchwork
== Series Details == Series: drm/i915: Restrict qgv points which don't have enough bandwidth. (rev2) URL : https://patchwork.freedesktop.org/series/66993/ State : warning == Summary == $ dim checkpatch origin/drm-tip 58676dcb1195 drm/i915: Restrict qgv points which don't have enough

Re: [Intel-gfx] [PATCH 10/12] drm/i915: Document ILK+ pipe csc matrix better

2019-09-20 Thread Mun, Gwan-gyeong
On Thu, 2019-07-18 at 17:50 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Add comments to explain the ilk pipe csc operation a bit better. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_color.c | 26 +--- > -- > 1 file changed, 21

[Intel-gfx] ✓ Fi.CI.BAT: success for Docs: fix incorrect use of kernel-doc format in structure description. (rev2)

2019-09-20 Thread Patchwork
== Series Details == Series: Docs: fix incorrect use of kernel-doc format in structure description. (rev2) URL : https://patchwork.freedesktop.org/series/66922/ State : success == Summary == CI Bug Log - changes from CI_DRM_6928 -> Patchwork_14474

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add TigerLake bandwidth checking (rev5)

2019-09-20 Thread Patchwork
== Series Details == Series: drm/i915: Add TigerLake bandwidth checking (rev5) URL : https://patchwork.freedesktop.org/series/66817/ State : success == Summary == CI Bug Log - changes from CI_DRM_6928 -> Patchwork_14473 Summary ---

Re: [Intel-gfx] [PATCH v2] drm/i915: Restrict qgv points which don't have enough bandwidth.

2019-09-20 Thread Lisovskiy, Stanislav
On Fri, 2019-09-20 at 16:19 +0300, Ville Syrjälä wrote: > On Fri, Sep 20, 2019 at 01:44:13PM +0300, Stanislav Lisovskiy wrote: > > According to BSpec 53998, we should try to > > restrict qgv points, which can't provide > > enough bandwidth for desired display configuration. > > > > Currently we

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Add memory type decoding for bandwidth checking

2019-09-20 Thread James Ausmus
On Fri, Sep 20, 2019 at 03:29:06PM +0300, Ville Syrjälä wrote: > On Thu, Sep 19, 2019 at 03:16:40PM -0700, James Ausmus wrote: > > The memory type values have changed in TGL, so we need to translate them > > differently than ICL. > > > > BSpec: 53998 > > > > Cc: Ville Syrjälä > > Cc: Stanislav

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: save AUD_FREQ_CNTRL state at audio domain suspend

2019-09-20 Thread Patchwork
== Series Details == Series: drm/i915: save AUD_FREQ_CNTRL state at audio domain suspend URL : https://patchwork.freedesktop.org/series/66991/ State : success == Summary == CI Bug Log - changes from CI_DRM_6928 -> Patchwork_14472 Summary

Re: [Intel-gfx] [PATCH v2] drm/i915: Restrict qgv points which don't have enough bandwidth.

2019-09-20 Thread Ville Syrjälä
On Fri, Sep 20, 2019 at 01:44:13PM +0300, Stanislav Lisovskiy wrote: > According to BSpec 53998, we should try to > restrict qgv points, which can't provide > enough bandwidth for desired display configuration. > > Currently we are just comparing against all of > those and take minimum(worst

[Intel-gfx] status of the " CRTC background color" series

2019-09-20 Thread Jean-Jacques Hiblot
Hi all, Any update on this series ? Last time I looked, everything looked ready and waiting to be merged. JJ ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Prevent bonded requests from overtaking each other on preemption

2019-09-20 Thread Patchwork
== Series Details == Series: drm/i915: Prevent bonded requests from overtaking each other on preemption URL : https://patchwork.freedesktop.org/series/66990/ State : success == Summary == CI Bug Log - changes from CI_DRM_6928 -> Patchwork_14471

Re: [Intel-gfx] [PATCH 03/12] drm/i915: Fix AVI infoframe quantization range for YCbCr output

2019-09-20 Thread Mun, Gwan-gyeong
On Thu, 2019-07-18 at 17:50 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > We're configuring the AVI infoframe quantization range bits as if > we're always transmitting RGB pixels. Let's fix this so that we > correctly indicate limited range YCC quantization range when > transmitting

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/2] drm/i915/uc: Update HuC firmware naming convention and load latest HuC

2019-09-20 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/uc: Update HuC firmware naming convention and load latest HuC URL : https://patchwork.freedesktop.org/series/66955/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6925_full -> Patchwork_14466_full

Re: [Intel-gfx] [PATCH] drm/i915: Prevent bonded requests from overtaking each other on preemption

2019-09-20 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-09-20 13:24:47) > > On 20/09/2019 09:36, Chris Wilson wrote: > > Force bonded requests to run on distinct engines so that they cannot be > > shuffled onto the same engine where timeslicing will reverse the order. > > A bonded request will often wait on a semaphore

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Prevent bonded requests from overtaking each other on preemption

2019-09-20 Thread Patchwork
== Series Details == Series: drm/i915: Prevent bonded requests from overtaking each other on preemption URL : https://patchwork.freedesktop.org/series/66990/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7885378114ae drm/i915: Prevent bonded requests from overtaking each

[Intel-gfx] ✓ Fi.CI.BAT: success for mdev based hardware virtio offloading support

2019-09-20 Thread Patchwork
== Series Details == Series: mdev based hardware virtio offloading support URL : https://patchwork.freedesktop.org/series/66989/ State : success == Summary == CI Bug Log - changes from CI_DRM_6928 -> Patchwork_14470 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: Mark contents as dirty on a write fault

2019-09-20 Thread Chris Wilson
Quoting Chris Wilson (2019-09-20 13:22:13) > Quoting Chris Wilson (2019-09-20 13:18:21) > > Since dropping the set-to-gtt-domain in commit a679f58d0510 ("drm/i915: > > Flush pages on acquisition"), we no longer mark the contents as dirty on > > a write fault. This has the issue of us then not

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Add memory type decoding for bandwidth checking

2019-09-20 Thread Ville Syrjälä
On Thu, Sep 19, 2019 at 03:16:40PM -0700, James Ausmus wrote: > The memory type values have changed in TGL, so we need to translate them > differently than ICL. > > BSpec: 53998 > > Cc: Ville Syrjälä > Cc: Stanislav Lisovskiy > Signed-off-by: James Ausmus > --- >

  1   2   >