Re: [Intel-gfx] [PATCH v2 08/14] video: fbdev: make fbops member of struct fb_info a const pointer

2019-11-29 Thread kbuild test robot
Hi Jani, I love your patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v5.4 next-20191129] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Use the correct PCH transcoder for LPT/WPT in intel_sanitize_frame_start_delay()

2019-11-29 Thread Patchwork
== Series Details == Series: drm/i915: Use the correct PCH transcoder for LPT/WPT in intel_sanitize_frame_start_delay() URL : https://patchwork.freedesktop.org/series/70175/ State : success == Summary == CI Bug Log - changes from CI_DRM_7438_full -> Patchwork_15496_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Keep engine awake during live_coherency

2019-11-29 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Keep engine awake during live_coherency URL : https://patchwork.freedesktop.org/series/70227/ State : success == Summary == CI Bug Log - changes from CI_DRM_7447 -> Patchwork_15520 Summary

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] drm/i915/dp: Take display powerwell before intel_dp_detect_dpcd

2019-11-29 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/dp: Take display powerwell before intel_dp_detect_dpcd URL : https://patchwork.freedesktop.org/series/70226/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7447 -> Patchwork_15519

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/fbc: Fix FBC for glk+ (rev5)

2019-11-29 Thread Patchwork
== Series Details == Series: drm/i915/fbc: Fix FBC for glk+ (rev5) URL : https://patchwork.freedesktop.org/series/70062/ State : success == Summary == CI Bug Log - changes from CI_DRM_7438_full -> Patchwork_15492_full Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915/dp: Take display powerwell before intel_dp_detect_dpcd

2019-11-29 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/dp: Take display powerwell before intel_dp_detect_dpcd URL : https://patchwork.freedesktop.org/series/70226/ State : warning == Summary == $ dim checkpatch origin/drm-tip ee6e1886d4fa drm/i915/dp: Take display powerwell

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gen7: Re-enable full-ppgtt for ivb & hsw (rev4)

2019-11-29 Thread Patchwork
== Series Details == Series: drm/i915/gen7: Re-enable full-ppgtt for ivb & hsw (rev4) URL : https://patchwork.freedesktop.org/series/70184/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7447 -> Patchwork_15518 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gen7: Re-enable full-ppgtt for ivb & hsw (rev4)

2019-11-29 Thread Patchwork
== Series Details == Series: drm/i915/gen7: Re-enable full-ppgtt for ivb & hsw (rev4) URL : https://patchwork.freedesktop.org/series/70184/ State : warning == Summary == $ dim checkpatch origin/drm-tip caf306d7c8fa drm/i915/gen7: Re-enable full-ppgtt for ivb & hsw -:148:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/vlv_dsi: Control panel and backlight enable GPIOs on BYT

2019-11-29 Thread Patchwork
== Series Details == Series: drm/i915/vlv_dsi: Control panel and backlight enable GPIOs on BYT URL : https://patchwork.freedesktop.org/series/70223/ State : success == Summary == CI Bug Log - changes from CI_DRM_7447 -> Patchwork_15517

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Provide ddc symlink in hdmi connector sysfs directory (rev2)

2019-11-29 Thread Patchwork
== Series Details == Series: drm/i915: Provide ddc symlink in hdmi connector sysfs directory (rev2) URL : https://patchwork.freedesktop.org/series/70161/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7438_full -> Patchwork_15491_full

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Keep engine awake during live_coherency

2019-11-29 Thread Matthew Auld
On Fri, 29 Nov 2019 at 22:27, Chris Wilson wrote: > > Keep the engine awake and so avoid frequent cycling in and out of > powersaving mode to eliminate the unnecessary overhead and speed up the > testing. > > Signed-off-by: Chris Wilson > Cc: Matthew Auld Reviewed-by: Matthew Auld

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: i915_display_info cleanup

2019-11-29 Thread Patchwork
== Series Details == Series: drm/i915: i915_display_info cleanup URL : https://patchwork.freedesktop.org/series/70222/ State : success == Summary == CI Bug Log - changes from CI_DRM_7447 -> Patchwork_15516 Summary --- **SUCCESS**

[Intel-gfx] [PATCH] drm/i915/selftests: Keep engine awake during live_coherency

2019-11-29 Thread Chris Wilson
Keep the engine awake and so avoid frequent cycling in and out of powersaving mode to eliminate the unnecessary overhead and speed up the testing. Signed-off-by: Chris Wilson Cc: Matthew Auld --- drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c | 2 ++ 1 file changed, 2 insertions(+)

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: i915_display_info cleanup

2019-11-29 Thread Patchwork
== Series Details == Series: drm/i915: i915_display_info cleanup URL : https://patchwork.freedesktop.org/series/70222/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6356e0862ab6 drm/i915: Use drm_rect to simplify plane {crtc, src}_{x, y, w, h} printing -:41:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/execlists: Ensure the tasklet is decoupled upon shutdown (rev2)

2019-11-29 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Ensure the tasklet is decoupled upon shutdown (rev2) URL : https://patchwork.freedesktop.org/series/70221/ State : failure == Summary == Applying: drm/i915/execlists: Ensure the tasklet is decoupled upon shutdown Using index info to reconstruct

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gem: Take timeline->mutex to walk list-of-requests

2019-11-29 Thread Patchwork
== Series Details == Series: drm/i915/gem: Take timeline->mutex to walk list-of-requests URL : https://patchwork.freedesktop.org/series/70216/ State : failure == Summary == Applying: drm/i915/gem: Take timeline->mutex to walk list-of-requests Using index info to reconstruct a base tree... M

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable second DBuf slice for ICL and TGL (rev3)

2019-11-29 Thread Patchwork
== Series Details == Series: Enable second DBuf slice for ICL and TGL (rev3) URL : https://patchwork.freedesktop.org/series/70059/ State : success == Summary == CI Bug Log - changes from CI_DRM_7446 -> Patchwork_15513 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for Revert "drm/i915: use a separate context for gpu relocs"

2019-11-29 Thread Patchwork
== Series Details == Series: Revert "drm/i915: use a separate context for gpu relocs" URL : https://patchwork.freedesktop.org/series/70208/ State : failure == Summary == Applying: Revert "drm/i915: use a separate context for gpu relocs" Using index info to reconstruct a base tree... M

Re: [Intel-gfx] [PATCH v2 14/14] auxdisplay: constify fb ops

2019-11-29 Thread Daniel Vetter
On Fri, Nov 29, 2019 at 09:16:42PM +0100, Miguel Ojeda wrote: > On Fri, Nov 29, 2019 at 4:24 PM Daniel Vetter wrote: > > > > Oh, another display subsystem? Intriguing ... > > > > Reviewed-by: Daniel Vetter > > It is intended for displays that are not intended as the usual/main > display, e.g.

[Intel-gfx] [CI 1/2] drm/i915/dp: Take display powerwell before intel_dp_detect_dpcd

2019-11-29 Thread Chris Wilson
Prevent a circular lockdep reference caused by waking up the runtime-pm from inside intel_dp_aux_xfer() deep within several layers of mutexes. <7> [401.102396] [drm:intel_runtime_suspend [i915]] Device suspended <4> [401.115284] <4> [401.115288]

[Intel-gfx] [CI 2/2] drm/i915: Serialise i915_active_wait() with its retirement

2019-11-29 Thread Chris Wilson
As the i915_active.retire() may be running on another CPU as we detect that the i915_active is idle, we may not wait for the retirement itself. Wait for the remote callback by waiting for the retirement worker. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112424 Signed-off-by: Chris

[Intel-gfx] [CI] drm/i915/gen7: Re-enable full-ppgtt for ivb & hsw

2019-11-29 Thread Chris Wilson
After much hair pulling, resort to preallocating the ppGTT entries on init to circumvent the apparent lack of PD invalidate following the write to PP_DCLV upon switching mm between contexts (and here the same context after binding new objects). However, the details of that PP_DCLV invalidate are

Re: [Intel-gfx] [PATCH 0/2] drm/i915/vlv_dsi: Control panel and backlight enable GPIOs on BYT

2019-11-29 Thread Andy Shevchenko
On Fri, Nov 29, 2019 at 07:58:34PM +0100, Hans de Goede wrote: > Hi All, > > On Bay Trail devices the MIPI power on/off sequences for DSI LCD panels > do not control the LCD panel- and backlight-enable GPIOs. So far, when > the VBT indicates we should use the SoC for backlight control, we have >

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gen7: Re-enable full-ppgtt for ivb & hsw (rev3)

2019-11-29 Thread Patchwork
== Series Details == Series: drm/i915/gen7: Re-enable full-ppgtt for ivb & hsw (rev3) URL : https://patchwork.freedesktop.org/series/70184/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7444 -> Patchwork_15511 Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: Take display powerwell before intel_dp_detect_dpcd

2019-11-29 Thread Patchwork
== Series Details == Series: drm/i915/dp: Take display powerwell before intel_dp_detect_dpcd URL : https://patchwork.freedesktop.org/series/70204/ State : success == Summary == CI Bug Log - changes from CI_DRM_7444 -> Patchwork_15510

[Intel-gfx] [PATCH 0/2] drm/i915/vlv_dsi: Control panel and backlight enable GPIOs on BYT

2019-11-29 Thread Hans de Goede
Hi All, On Bay Trail devices the MIPI power on/off sequences for DSI LCD panels do not control the LCD panel- and backlight-enable GPIOs. So far, when the VBT indicates we should use the SoC for backlight control, we have been relying on these GPIOs being configured as output and driven high by

[Intel-gfx] [PATCH 1/2] pinctrl: baytrail: Add GPIO lookup and pinctrl-map for i915 DSI panel ctrl

2019-11-29 Thread Hans de Goede
On Bay Trail devices the MIPI power on/off sequences for DSI LCD panels do not control the LCD panel and backlight GPIOs. So far we have been relying on these GPIOs being configured as output and driven high by the Video BIOS (GOP) when it initializes the panel. This does not work when the device

[Intel-gfx] [PATCH 2/2] drm/i915/vlv_dsi: Control panel and backlight enable GPIOs on BYT

2019-11-29 Thread Hans de Goede
On Bay Trail devices the MIPI power on/off sequences for DSI LCD panels do not control the LCD panel- and backlight-enable GPIOs. So far, when the VBT indicates we should use the SoC for backlight control, we have been relying on these GPIOs being configured as output and driven high by the Video

[Intel-gfx] [PATCH v2 6/9] drm/i915: Use drm_modeset_lock_all() in debugfs display info

2019-11-29 Thread Ville Syrjala
From: Ville Syrjälä Make out life easier by just grabbing all modeset locks around the display_info dump. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_debugfs.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c

[Intel-gfx] [PATCH v2 7/9] drm/i915: Use the canonical [CRTC:%d:%s]/etc. format in i915_display_info

2019-11-29 Thread Ville Syrjala
From: Ville Syrjälä Use the canonicalt "[CRTC:%d:%s]" format for the obj id/name in the debugfs display_info dump. Everyone should already be familiar with the format since it's used in the debug logs extensively. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_debugfs.c | 14

[Intel-gfx] [PATCH v2 9/9] drm/i915: Stop using connector->encoder and encoder->crtc links in i915_display_info

2019-11-29 Thread Ville Syrjala
From: Ville Syrjälä Migrate away from the legacy encoder->crtc and connector->encoder links in the debugfs display_info code. Other users still remain so can't kill these off yet. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.h | 7

[Intel-gfx] [PATCH v2 3/9] drm/i915: Reorganize plane/fb dump in debugfs

2019-11-29 Thread Ville Syrjala
From: Ville Syrjälä Eliminate the special cases for the primary and cursor planes and just dump all the information consistently for all the planes. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_debugfs.c | 48 +++-- 1 file changed, 11 insertions(+), 37

[Intel-gfx] [PATCH v2 8/9] drm/i915: Dump both the uapi and hw states for crtcs and planes

2019-11-29 Thread Ville Syrjala
From: Ville Syrjälä Let's make the display info more useful by dumping both the uapi and hw states for each crtc/plane. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_debugfs.c | 116 +--- 1 file changed, 73 insertions(+), 43 deletions(-) diff --git

[Intel-gfx] [PATCH v2 4/9] drm/i915: Refactor debugfs display info code

2019-11-29 Thread Ville Syrjala
From: Ville Syrjälä Pull the crtc dumping stuff into a nice function so the loop over the crtcs doesn't look like crap. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_debugfs.c | 52 - 1 file changed, 28 insertions(+), 24 deletions(-) diff --git

[Intel-gfx] [PATCH v2 1/9] drm/i915: Use drm_rect to simplify plane {crtc, src}_{x, y, w, h} printing

2019-11-29 Thread Ville Syrjala
From: Ville Syrjälä Use DRM_RECT_FMT & co. to simpify the code. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_debugfs.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c

[Intel-gfx] [PATCH v2 2/9] drm/i915: Switch to intel_ types in debugfs display_info

2019-11-29 Thread Ville Syrjala
From: Ville Syrjälä Switch to using intel_ types in the debugfs display_info code. Should make it easier to handle bigjoiner etc. in the future. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_debugfs.c | 119 ++-- 1 file changed, 59 insertions(+), 60

[Intel-gfx] [PATCH v2 0/9] drm/i915: i915_display_info cleanup

2019-11-29 Thread Ville Syrjala
From: Ville Syrjälä Now that igt no longer parses the display_info from debugfs we can actually make it a bit more sane. I already posted the first five patches once, but I added a bit more on top for the hw vs. uapi split (now we try to dump both). And I also took the opportunity to start

[Intel-gfx] [PATCH v2 5/9] drm/i915: Dump the mode for the crtc just the once

2019-11-29 Thread Ville Syrjala
From: Ville Syrjälä No point in repeating the crtc mode for each cloned encoder. Just print it once, and avoid using multiple lines for it. And while at let's polish the fixed mode print to fit on one line as well. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_debugfs.c | 27

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: Take display powerwell before intel_dp_detect_dpcd

2019-11-29 Thread Patchwork
== Series Details == Series: drm/i915/dp: Take display powerwell before intel_dp_detect_dpcd URL : https://patchwork.freedesktop.org/series/70204/ State : warning == Summary == $ dim checkpatch origin/drm-tip e2310f59c054 drm/i915/dp: Take display powerwell before intel_dp_detect_dpcd -:20:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Report frequency as zero while GPU is sleeping (rev2)

2019-11-29 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Report frequency as zero while GPU is sleeping (rev2) URL : https://patchwork.freedesktop.org/series/70168/ State : success == Summary == CI Bug Log - changes from CI_DRM_7444 -> Patchwork_15509

Re: [Intel-gfx] [PATCH v2 01/14] drm/i915/fbc: Disable fbc by default on all glk+

2019-11-29 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v5.3.13, v4.19.86, v4.14.156, v4.9.203, v4.4.203. v5.3.13: Build OK! v4.19.86:

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for bios: dot not discard address space (rev2)

2019-11-29 Thread Lucas De Marchi
On Wed, Nov 27, 2019 at 12:12 PM Patchwork wrote: > > == Series Details == > > Series: bios: dot not discard address space (rev2) > URL : https://patchwork.freedesktop.org/series/70075/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_7430_full -> Patchwork_15459_full >

[Intel-gfx] ✓ Fi.CI.BAT: success for video, drm, etc: constify fbops in struct fb_info

2019-11-29 Thread Patchwork
== Series Details == Series: video, drm, etc: constify fbops in struct fb_info URL : https://patchwork.freedesktop.org/series/70198/ State : success == Summary == CI Bug Log - changes from CI_DRM_7444 -> Patchwork_15507 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Wait only on the expected barrier

2019-11-29 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Wait only on the expected barrier URL : https://patchwork.freedesktop.org/series/70200/ State : failure == Summary == Applying: drm/i915/selftests: Wait only on the expected barrier Using index info to reconstruct a base tree... M

Re: [Intel-gfx] [PATCH] drm/i915: Use the correct PCH transcoder for LPT/WPT in intel_sanitize_frame_start_delay()

2019-11-29 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä >Sent: Friday, November 29, 2019 7:21 PM >To: Shankar, Uma >Cc: 'intel-gfx@lists.freedesktop.org' >Subject: Re: [PATCH] drm/i915: Use the correct PCH transcoder for LPT/WPT in >intel_sanitize_frame_start_delay() > >On Fri, Nov 29, 2019 at

[Intel-gfx] [PATCH] drm/i915/execlists: Ensure the tasklet is decoupled upon shutdown

2019-11-29 Thread Chris Wilson
As we only cancel the timers asynchronously, they may still be running on another CPU as we shutdown, raising one last softirq. So be safe and make sure the tasklet is flushed before destroying the engine's memory. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_lrc.c | 10

[Intel-gfx] [PATCH] drm/i915/execlists: Ensure the tasklet is decoupled upon shutdown

2019-11-29 Thread Chris Wilson
Be safe and make sure the tasklet is flushed before destroying the engine's memory. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_lrc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c index

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/tgl: Drop preemption to see if that helps

2019-11-29 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Drop preemption to see if that helps URL : https://patchwork.freedesktop.org/series/70153/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7436_full -> Patchwork_15483_full Summary

Re: [Intel-gfx] [PATCH] drm/i915/gem: Take timeline->mutex to walk list-of-requests

2019-11-29 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-11-29 16:25:08) > > On 29/11/2019 15:18, Chris Wilson wrote: > > Though the context is closed and so no more requests can be added to the > > timeline, retirement can still be removing requests. It can even be > > removing the very request we are inspecting and so

Re: [Intel-gfx] [PATCH] drm/i915/gem: Take timeline->mutex to walk list-of-requests

2019-11-29 Thread Tvrtko Ursulin
On 29/11/2019 15:18, Chris Wilson wrote: Though the context is closed and so no more requests can be added to the timeline, retirement can still be removing requests. It can even be removing the very request we are inspecting and so cause us to wander into dead links. Serialise with the

Re: [Intel-gfx] [PATCH v2 00/14] video, drm, etc: constify fbops in struct fb_info

2019-11-29 Thread Daniel Vetter
On Fri, Nov 29, 2019 at 12:29:30PM +0200, Jani Nikula wrote: > This is v2 of https://patchwork.freedesktop.org/series/70119/ > > I wanted to make our struct fb_ops const because we don't modify > it... and this is what I ended up with to fix it and a bunch of others. > > I would appreciate acks

Re: [Intel-gfx] [PATCH v2 06/14] video: fbmem: use const pointer for fb_ops

2019-11-29 Thread Daniel Vetter
On Fri, Nov 29, 2019 at 12:29:36PM +0200, Jani Nikula wrote: > Use const for fb_ops to let us make the info->fbops pointer const in the > future. > > v2: rebase > > Cc: linux-fb...@vger.kernel.org > Signed-off-by: Jani Nikula I guess my r-b got lost on this, not sure, anyway. Reviewed-by:

Re: [Intel-gfx] [PATCH v2 14/14] auxdisplay: constify fb ops

2019-11-29 Thread Daniel Vetter
On Fri, Nov 29, 2019 at 12:29:44PM +0200, Jani Nikula wrote: > Now that the fbops member of struct fb_info is const, we can start > making the ops const as well. > > Cc: Miguel Ojeda Sandonis > Cc: Robin van der Gracht > Signed-off-by: Jani Nikula > --- > drivers/auxdisplay/cfag12864bfb.c | 2

Re: [Intel-gfx] [PATCH v2 01/14] video: fb_defio: preserve user fb_ops

2019-11-29 Thread Daniel Vetter
On Fri, Nov 29, 2019 at 12:29:31PM +0200, Jani Nikula wrote: > Modifying fb_ops directly to override fb_mmap with fb_deferred_io_mmap > and then resetting it to NULL afterwards causes problems all over the > place. First, it prevents making the fbops member of struct fb_info a > const pointer,

[Intel-gfx] [PATCH] drm/i915/gem: Take timeline->mutex to walk list-of-requests

2019-11-29 Thread Chris Wilson
Though the context is closed and so no more requests can be added to the timeline, retirement can still be removing requests. It can even be removing the very request we are inspecting and so cause us to wander into dead links. Serialise with the retirement by taking the timeline->mutex used for

Re: [Intel-gfx] [PATCH v2 02/14] drm/fb-helper: don't preserve fb_ops across deferred IO use

2019-11-29 Thread Noralf Trønnes
Den 29.11.2019 11.29, skrev Jani Nikula: > Deferred IO now preserves the fb_ops. > > v2: Remove the no-op vfree, drop a local var (Noralf) > > Cc: Noralf Trønnes > Cc: dri-de...@lists.freedesktop.org > Reviewed-by: Daniel Vetter > Signed-off-by: Jani Nikula > --- Reviewed-by: Noralf

Re: [Intel-gfx] [PATCH v2 01/14] video: fb_defio: preserve user fb_ops

2019-11-29 Thread Noralf Trønnes
Den 29.11.2019 11.29, skrev Jani Nikula: > Modifying fb_ops directly to override fb_mmap with fb_deferred_io_mmap > and then resetting it to NULL afterwards causes problems all over the > place. First, it prevents making the fbops member of struct fb_info a > const pointer, which means we can't

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Always lock the drm_mm around insert/remove

2019-11-29 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Always lock the drm_mm around insert/remove URL : https://patchwork.freedesktop.org/series/70196/ State : success == Summary == CI Bug Log - changes from CI_DRM_7442 -> Patchwork_15506

Re: [Intel-gfx] [PATCH] drm/i915: Use the correct PCH transcoder for LPT/WPT in intel_sanitize_frame_start_delay()

2019-11-29 Thread Ville Syrjälä
On Fri, Nov 29, 2019 at 11:56:42AM +, Shankar, Uma wrote: > > > >-Original Message- > >From: Shankar, Uma > >Sent: Friday, November 29, 2019 5:18 PM > >To: Ville Syrjala ; > >intel-gfx@lists.freedesktop.org > >Subject: RE: [PATCH] drm/i915: Use the correct PCH transcoder for LPT/WPT

[Intel-gfx] [PATCH v7 1/4] drm/i915: Remove skl_ddl_allocation struct

2019-11-29 Thread Stanislav Lisovskiy
Current consensus that it is redundant as we already have skl_ddb_values struct out there, also this struct contains only single member which makes it unnecessary. v2: As dirty_pipes soon going to be nuked away from skl_ddb_values, evacuating enabled_slices to safer in dev_priv.

[Intel-gfx] [PATCH v7 3/4] drm/i915: Manipulate DBuf slices properly

2019-11-29 Thread Stanislav Lisovskiy
Start manipulating DBuf slices as a mask, but not as a total number, as current approach doesn't give us full control on all combinations of slices, which we might need(like enabling S2 only can't enabled by setting enabled_slices=1). Removed wrong code from intel_get_ddb_size as it doesn't match

[Intel-gfx] [PATCH v7 2/4] drm/i915: Move dbuf slice update to proper place

2019-11-29 Thread Stanislav Lisovskiy
Current DBuf slices update wasn't done in proper plane, especially its "post" part, which should disable those only once vblank had passed and all other changes are committed. v2: Fix to use dev_priv and intel_atomic_state instead of skl_ddb_values (to be nuked in Villes patch)

[Intel-gfx] [PATCH v7 4/4] drm/i915: Correctly map DBUF slices to pipes

2019-11-29 Thread Stanislav Lisovskiy
Added proper DBuf slice mapping to correspondent pipes, depending on pipe configuration as stated in BSpec. v2: - Remove unneeded braces - Stop using macro for DBuf assignments as it seems to reduce readability. v3: Start using enabled slices mask in dev_priv Signed-off-by:

[Intel-gfx] [PATCH v7 0/4] Enable second DBuf slice for ICL and TGL

2019-11-29 Thread Stanislav Lisovskiy
Those patch series, do some initial preparation DBuf manipulating code cleanups, i.e remove redundant structures/code, switch to mask based DBuf manupulation, get into use DBuf assignment according to BSpec rules. Stanislav Lisovskiy (4): drm/i915: Remove skl_ddl_allocation struct drm/i915:

Re: [Intel-gfx] [PATCH] Revert "drm/i915: use a separate context for gpu relocs"

2019-11-29 Thread Mika Kuoppala
Chris Wilson writes: > Since commit c45e788d95b4 ("drm/i915/tgl: Suspend pre-parser across GTT > invalidations"), we now disable the advanced preparser on Tigerlake for the > invalidation phase at the start of the batch, we no longer need to emit > the GPU relocations from a second context as

[Intel-gfx] [PATCH] Revert "drm/i915: use a separate context for gpu relocs"

2019-11-29 Thread Chris Wilson
Since commit c45e788d95b4 ("drm/i915/tgl: Suspend pre-parser across GTT invalidations"), we now disable the advanced preparser on Tigerlake for the invalidation phase at the start of the batch, we no longer need to emit the GPU relocations from a second context as they are now flushed inlined.

[Intel-gfx] ✓ Fi.CI.IGT: success for adding gamma state checker for icl+ platforms (rev7)

2019-11-29 Thread Patchwork
== Series Details == Series: adding gamma state checker for icl+ platforms (rev7) URL : https://patchwork.freedesktop.org/series/66811/ State : success == Summary == CI Bug Log - changes from CI_DRM_7432_full -> Patchwork_15468_full

Re: [Intel-gfx] [PATCH 1/3] ACPI / LPSS: Rename pwm_backlight pwm-lookup to pwm_soc_backlight

2019-11-29 Thread Rafael J. Wysocki
On Tuesday, November 19, 2019 4:18:16 PM CET Hans de Goede wrote: > At least Bay Trail (BYT) and Cherry Trail (CHT) devices can use 1 of 2 > different PWM controllers for controlling the LCD's backlight brightness. > Either the one integrated into the PMIC or the one integrated into the > SoC (the

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl: Implement Wa_1604555607

2019-11-29 Thread Ramalingam C
On 2019-11-29 at 11:49:24 +, Tvrtko Ursulin wrote: > > On 28/11/2019 03:17, Patchwork wrote: > > == Series Details == > > > > Series: drm/i915/tgl: Implement Wa_1604555607 > > URL : https://patchwork.freedesktop.org/series/70134/ > > State : success > > > > > > > > == Linux commits ==

[Intel-gfx] [CI] drm/i915/gen7: Re-enable full-ppgtt for ivb & hsw

2019-11-29 Thread Chris Wilson
After much hair pulling, resort to preallocating the ppGTT entries on init to circumvent the apparent lack of PD invalidate following the write to PP_DCLV upon switching mm between contexts (and here the same context after binding new objects). However, the details of that PP_DCLV invalidate are

Re: [Intel-gfx] [PATCH i-g-t] i915/perf_pmu: Check that while parked, we report min freq or below

2019-11-29 Thread Tvrtko Ursulin
On 29/11/2019 11:45, Chris Wilson wrote: While the HW is parked, the GPU should be turned off and clocks stop (i.e. running at 0Hz). We should report either the last frequency we program (which should be the minimum legal value) or a more truthful 0. Signed-off-by: Chris Wilson Cc: Tvrtko

Re: [Intel-gfx] [PATCH] drm/i915: Use the correct PCH transcoder for LPT/WPT in intel_sanitize_frame_start_delay()

2019-11-29 Thread Shankar, Uma
>-Original Message- >From: Shankar, Uma >Sent: Friday, November 29, 2019 5:18 PM >To: Ville Syrjala ; >intel-gfx@lists.freedesktop.org >Subject: RE: [PATCH] drm/i915: Use the correct PCH transcoder for LPT/WPT in >intel_sanitize_frame_start_delay() > > > >>-Original Message-

Re: [Intel-gfx] [PATCH i-g-t] i915/perf_pmu: Check that while parked, we report min freq or below

2019-11-29 Thread Tvrtko Ursulin
On 29/11/2019 11:45, Chris Wilson wrote: While the HW is parked, the GPU should be turned off and clocks stop (i.e. running at 0Hz). We should report either the last frequency we program (which should be the minimum legal value) or a more truthful 0. Signed-off-by: Chris Wilson Cc: Tvrtko

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl: Implement Wa_1604555607

2019-11-29 Thread Tvrtko Ursulin
On 28/11/2019 03:17, Patchwork wrote: == Series Details == Series: drm/i915/tgl: Implement Wa_1604555607 URL : https://patchwork.freedesktop.org/series/70134/ State : success == Summary == CI Bug Log - changes from CI_DRM_7434 -> Patchwork_15481

Re: [Intel-gfx] [PATCH] drm/i915: Use the correct PCH transcoder for LPT/WPT in intel_sanitize_frame_start_delay()

2019-11-29 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjala >Sent: Thursday, November 28, 2019 11:54 PM >To: intel-gfx@lists.freedesktop.org >Cc: Shankar, Uma >Subject: [PATCH] drm/i915: Use the correct PCH transcoder for LPT/WPT in >intel_sanitize_frame_start_delay() > >From: Ville Syrjälä > >LPT/WPT

[Intel-gfx] [PATCH i-g-t] i915/perf_pmu: Check that while parked, we report min freq or below

2019-11-29 Thread Chris Wilson
While the HW is parked, the GPU should be turned off and clocks stop (i.e. running at 0Hz). We should report either the last frequency we program (which should be the minimum legal value) or a more truthful 0. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- tests/perf_pmu.c | 40

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Wait only on the expected barrier

2019-11-29 Thread Tvrtko Ursulin
On 29/11/2019 10:34, Chris Wilson wrote: Wait on only the last request on the kernel_context after emitting a barrier so that we do not wait for everything in general and by doing so cause an accidental emission of the barrier! Bugzilla; https://bugs.freedesktop.org/show_bug.cgi?id=112405

Re: [Intel-gfx] [PATCH] drm/i915: Serialise i915_active_wait() with its retirement

2019-11-29 Thread Tvrtko Ursulin
On 29/11/2019 11:28, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-11-29 11:15:46) On 29/11/2019 09:39, Chris Wilson wrote: As the i915_active.retire() may be running on another CPU as we detect that the i915_active is idle, we may not wait for the retirement itself. Wait for the remote

Re: [Intel-gfx] [PATCH v2 14/14] drm/i915/fbc: Reallocate cfb if we need more of it

2019-11-29 Thread Ville Syrjälä
On Fri, Nov 29, 2019 at 09:48:45AM +0100, Maarten Lankhorst wrote: > Op 28-11-2019 om 16:59 schreef Ville Syrjälä: > > On Thu, Nov 28, 2019 at 04:48:04PM +0100, Maarten Lankhorst wrote: > >> Op 27-11-2019 om 21:12 schreef Ville Syrjala: > >>> From: Ville Syrjälä > >>> > >>> The code assumes we

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] overlay: Believe in 0MHz

2019-11-29 Thread Tvrtko Ursulin
On 28/11/2019 18:04, Chris Wilson wrote: Tvrtko proposed reporting 0MHz when idle, but the overlay didn't believe that would be possible and stripped from its graphs! Signed-off-by: Chris Wilson --- overlay/overlay.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff

[Intel-gfx] [PATCH] drm/i915/dp: Take display powerwell before intel_dp_detect_dpcd

2019-11-29 Thread Chris Wilson
Prevent a circular lockdep reference caused by waking up the runtime-pm from inside intel_dp_aux_xfer() deep within several layers of mutexes. <7> [401.102396] [drm:intel_runtime_suspend [i915]] Device suspended <4> [401.115284] <4> [401.115288]

Re: [Intel-gfx] [PATCH] drm/i915: Serialise i915_active_wait() with its retirement

2019-11-29 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-11-29 11:15:46) > > On 29/11/2019 09:39, Chris Wilson wrote: > > As the i915_active.retire() may be running on another CPU as we detect > > that the i915_active is idle, we may not wait for the retirement itself. > > Wait for the remote callback by waiting for the

Re: [Intel-gfx] [PATCH] drm/i915: Serialise i915_active_wait() with its retirement

2019-11-29 Thread Tvrtko Ursulin
On 29/11/2019 09:39, Chris Wilson wrote: As the i915_active.retire() may be running on another CPU as we detect that the i915_active is idle, we may not wait for the retirement itself. Wait for the remote callback by waiting for the retirement worker. Bugzilla:

[Intel-gfx] [PATCH v2] drm/i915/pmu: Report frequency as zero while GPU is sleeping

2019-11-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We used to report the minimum possible frequency as both requested and active while GPU was in sleep state. This was a consequence of sampling the value from the "current frequency" field in our software tracking. This was strictly speaking wrong, but given that until

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Serialise i915_active_wait() with its retirement

2019-11-29 Thread Patchwork
== Series Details == Series: drm/i915: Serialise i915_active_wait() with its retirement URL : https://patchwork.freedesktop.org/series/70195/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7440 -> Patchwork_15505 Summary

Re: [Intel-gfx] [PATCH v2 12/14] media: constify fb ops across all drivers

2019-11-29 Thread Jani Nikula
On Fri, 29 Nov 2019, Jani Nikula wrote: > Now that the fbops member of struct fb_info is const, we can start > making the ops const as well. > > Remove the redundant fbops assignments while at it. > > v2: > - actually add const in vivid > - fix typo (Christophe de Dinechin) > > Cc: Hans Verkuil

Re: [Intel-gfx] [PATCH v2 10/14] video: constify fb ops across all drivers

2019-11-29 Thread Jani Nikula
On Fri, 29 Nov 2019, Jani Nikula wrote: > Now that the fbops member of struct fb_info is const, we can start > making the ops const as well. > > This does not cover all drivers; some actually modify the fbops struct, > for example to adjust for different configurations, and others do more >

[Intel-gfx] [PATCH] drm/i915/selftests: Wait only on the expected barrier

2019-11-29 Thread Chris Wilson
Wait on only the last request on the kernel_context after emitting a barrier so that we do not wait for everything in general and by doing so cause an accidental emission of the barrier! Bugzilla; https://bugs.freedesktop.org/show_bug.cgi?id=112405 Signed-off-by: Chris Wilson ---

[Intel-gfx] [PATCH v2 14/14] auxdisplay: constify fb ops

2019-11-29 Thread Jani Nikula
Now that the fbops member of struct fb_info is const, we can start making the ops const as well. Cc: Miguel Ojeda Sandonis Cc: Robin van der Gracht Signed-off-by: Jani Nikula --- drivers/auxdisplay/cfag12864bfb.c | 2 +- drivers/auxdisplay/ht16k33.c | 2 +- 2 files changed, 2

[Intel-gfx] [PATCH v2 13/14] samples: vfio-mdev: constify fb ops

2019-11-29 Thread Jani Nikula
Now that the fbops member of struct fb_info is const, we can start making the ops const as well. v2: fix typo (Christophe de Dinechin) Cc: Kirti Wankhede Cc: k...@vger.kernel.org Reviewed-by: Daniel Vetter Signed-off-by: Jani Nikula --- samples/vfio-mdev/mdpy-fb.c | 2 +- 1 file changed, 1

[Intel-gfx] [PATCH v2 10/14] video: constify fb ops across all drivers

2019-11-29 Thread Jani Nikula
Now that the fbops member of struct fb_info is const, we can start making the ops const as well. This does not cover all drivers; some actually modify the fbops struct, for example to adjust for different configurations, and others do more involved things that I'd rather not touch in practically

[Intel-gfx] [PATCH v2 12/14] media: constify fb ops across all drivers

2019-11-29 Thread Jani Nikula
Now that the fbops member of struct fb_info is const, we can start making the ops const as well. Remove the redundant fbops assignments while at it. v2: - actually add const in vivid - fix typo (Christophe de Dinechin) Cc: Hans Verkuil Cc: Andy Walls Cc: linux-me...@vger.kernel.org Cc:

[Intel-gfx] [PATCH v2 04/14] video: udlfb: don't restore fb_mmap after deferred IO cleanup

2019-11-29 Thread Jani Nikula
Deferred IO now preserves the fb_ops. Cc: Bernie Thompson Cc: linux-fb...@vger.kernel.org Reviewed-by: Daniel Vetter Signed-off-by: Jani Nikula --- drivers/video/fbdev/udlfb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c index

[Intel-gfx] [PATCH v2 07/14] video: omapfb: use const pointer for fb_ops

2019-11-29 Thread Jani Nikula
Use const for fb_ops to let us make the info->fbops pointer const in the future. Cc: linux-fb...@vger.kernel.org Cc: linux-o...@vger.kernel.org Reviewed-by: Daniel Vetter Signed-off-by: Jani Nikula --- drivers/video/fbdev/omap/omapfb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Intel-gfx] [PATCH v2 11/14] HID: picoLCD: constify fb ops

2019-11-29 Thread Jani Nikula
Now that the fbops member of struct fb_info is const, we can start making the ops const as well. v2: fix typo (Christophe de Dinechin) Cc: Bruno Prémont Cc: linux-in...@vger.kernel.org Reviewed-by: Daniel Vetter Signed-off-by: Jani Nikula --- drivers/hid/hid-picolcd_fb.c | 3 +-- 1 file

[Intel-gfx] [PATCH v2 08/14] video: fbdev: make fbops member of struct fb_info a const pointer

2019-11-29 Thread Jani Nikula
Now that we no longer modify the fbops, or hold non-const pointers to it, we can make it const. After this, we can start making the fbops const all over the place. Cc: linux-fb...@vger.kernel.org Reviewed-by: Daniel Vetter Signed-off-by: Jani Nikula --- include/linux/fb.h | 2 +- 1 file

[Intel-gfx] [PATCH v2 06/14] video: fbmem: use const pointer for fb_ops

2019-11-29 Thread Jani Nikula
Use const for fb_ops to let us make the info->fbops pointer const in the future. v2: rebase Cc: linux-fb...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/video/fbdev/core/fbmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/core/fbmem.c

[Intel-gfx] [PATCH v2 02/14] drm/fb-helper: don't preserve fb_ops across deferred IO use

2019-11-29 Thread Jani Nikula
Deferred IO now preserves the fb_ops. v2: Remove the no-op vfree, drop a local var (Noralf) Cc: Noralf Trønnes Cc: dri-de...@lists.freedesktop.org Reviewed-by: Daniel Vetter Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_fb_helper.c | 25 +++-- 1 file changed, 3

[Intel-gfx] [PATCH v2 09/14] drm: constify fb ops across all drivers

2019-11-29 Thread Jani Nikula
Now that the fbops member of struct fb_info is const, we can start making the ops const as well. Cc: dri-de...@lists.freedesktop.org Reviewed-by: Daniel Vetter Signed-off-by: Jani Nikula --- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c| 2 +- drivers/gpu/drm/armada/armada_fbdev.c

[Intel-gfx] [PATCH v2 05/14] video: fbdev: vesafb: modify the static fb_ops directly

2019-11-29 Thread Jani Nikula
Avoid modifying the fb_ops via info->fbops to let us make the pointer const in the future. Cc: linux-fb...@vger.kernel.org Reviewed-by: Daniel Vetter Signed-off-by: Jani Nikula --- drivers/video/fbdev/vesafb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

  1   2   >