[Intel-gfx] ✗ Fi.CI.IGT: failure for mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()

2020-05-23 Thread Patchwork
== Series Details == Series: mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages() URL : https://patchwork.freedesktop.org/series/77598/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8529_full -> Patchwork_17765_full

[Intel-gfx] ✓ Fi.CI.BAT: success for mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()

2020-05-23 Thread Patchwork
== Series Details == Series: mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages() URL : https://patchwork.freedesktop.org/series/77598/ State : success == Summary == CI Bug Log - changes from CI_DRM_8529 -> Patchwork_17765

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()

2020-05-23 Thread Patchwork
== Series Details == Series: mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages() URL : https://patchwork.freedesktop.org/series/77598/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()

2020-05-23 Thread Patchwork
== Series Details == Series: mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages() URL : https://patchwork.freedesktop.org/series/77598/ State : warning == Summary == $ dim checkpatch origin/drm-tip cda3a034f4d1 mm/gup: move __get_user_pages_fast() down a few lines in gup.c -:111:

[Intel-gfx] ✗ Fi.CI.BUILD: failure for mm/gup: fixup gup.c for "mm/gup: refactor and de-duplicate gup_fast() code"

2020-05-23 Thread Patchwork
== Series Details == Series: mm/gup: fixup gup.c for "mm/gup: refactor and de-duplicate gup_fast() code" URL : https://patchwork.freedesktop.org/series/77597/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK

[Intel-gfx] [PATCH v2 3/4] mm/gup: introduce pin_user_pages_fast_only()

2020-05-23 Thread John Hubbard
This is the FOLL_PIN equivalent of __get_user_pages_fast(), except with a more descriptive name, and gup_flags instead of a boolean "write" in the argument list. Signed-off-by: John Hubbard --- include/linux/mm.h | 2 ++ mm/gup.c | 36 2 files

[Intel-gfx] [PATCH v2 0/4] mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()

2020-05-23 Thread John Hubbard
The purpose of posting this series is to launch a test in the intel-gfx-ci tree. (The patches have already been merged into Andrew's linux-mm tree.) This applies to today's linux.git (note the base-commit tag at the bottom). Changes since V1: * Fixed a bug in the refactoring patch: added

Re: [Intel-gfx] [PATCH 0/4] mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()

2020-05-23 Thread John Hubbard
On 2020-05-22 04:40, Souptick Joarder wrote: ... 3) Make it easy for an upcoming patch from Souptick, which aims to convert __get_user_pages_fast() to use a gup_flags argument, instead of a bool writeable arg. Also, if this series looks good, we can ask Souptick to change the name

[Intel-gfx] [PATCH v2 1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c

2020-05-23 Thread John Hubbard
This is in order to avoid a forward declaration of internal_get_user_pages_fast(), in the next patch. This is code movement only--all generated code should be identical. Signed-off-by: John Hubbard --- mm/gup.c | 112 +++ 1 file changed, 56

[Intel-gfx] [PATCH v2 2/4] mm/gup: refactor and de-duplicate gup_fast() code

2020-05-23 Thread John Hubbard
There were two nearly identical sets of code for gup_fast() style of walking the page tables with interrupts disabled. This has lead to the usual maintenance problems that arise from having duplicated code. There is already a core internal routine in gup.c for gup_fast(), so just enhance it very

[Intel-gfx] [PATCH] mm/gup: fixup gup.c for "mm/gup: refactor and de-duplicate gup_fast() code"

2020-05-23 Thread John Hubbard
Include FOLL_FAST_ONLY in the list of flags to *not* WARN() on, in internal_get_user_pages_fast(). Cc: Chris Wilson Cc: Daniel Vetter Cc: David Airlie Cc: Jani Nikula Cc: "Joonas Lahtinen" Cc: Matthew Auld Cc: Matthew Wilcox Cc: Rodrigo Vivi Cc: Souptick Joarder Cc: Tvrtko Ursulin

Re: [Intel-gfx] [PATCH] mm/gup: fixup gup.c for "mm/gup: refactor and de-duplicate gup_fast() code"

2020-05-23 Thread John Hubbard
On 2020-05-21 19:46, Chris Wilson wrote: Quoting John Hubbard (2020-05-22 00:38:41) Include FOLL_FAST_ONLY in the list of flags to *not* WARN() on, in internal_get_user_pages_fast(). Cc: Chris Wilson Cc: Daniel Vetter Cc: David Airlie Cc: Jani Nikula Cc: "Joonas Lahtinen" Cc: Matthew Auld

[Intel-gfx] [PATCH v2 4/4] drm/i915: convert get_user_pages() --> pin_user_pages()

2020-05-23 Thread John Hubbard
This code was using get_user_pages*(), in a "Case 2" scenario (DMA/RDMA), using the categorization from [1]. That means that it's time to convert the get_user_pages*() + put_page() calls to pin_user_pages*() + unpin_user_pages() calls. There is some helpful background in [2]: basically, this is a

Re: [Intel-gfx] [PATCH v11] drm/i915/dsb: Pre allocate and late cleanup of cmd buffer

2020-05-23 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Animesh > Manna > Sent: Wednesday, May 20, 2020 6:38 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; Daniel Vetter > ; > Lankhorst, Maarten > Subject: [Intel-gfx] [PATCH v11] drm/i915/dsb: Pre allocate and late cleanup

Re: [Intel-gfx] [PATCH v2 0/4] mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()

2020-05-23 Thread Chris Wilson
Quoting John Hubbard (2020-05-22 06:19:27) > The purpose of posting this series is to launch a test in the > intel-gfx-ci tree. (The patches have already been merged into Andrew's > linux-mm tree.) > > This applies to today's linux.git (note the base-commit tag at the > bottom). > > Changes

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dsi: Dont forget to clean up the connector on error (rev2)

2020-05-23 Thread Patchwork
== Series Details == Series: drm/i915/dsi: Dont forget to clean up the connector on error (rev2) URL : https://patchwork.freedesktop.org/series/77011/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8527_full -> Patchwork_17763_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c (rev2)

2020-05-23 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c (rev2) URL : https://patchwork.freedesktop.org/series/77566/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8527_full -> Patchwork_17762_full