[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable HDR on MCA LSPCON based Gen9 devices (rev12)

2020-11-26 Thread Patchwork
== Series Details == Series: Enable HDR on MCA LSPCON based Gen9 devices (rev12) URL : https://patchwork.freedesktop.org/series/68081/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable HDR on MCA LSPCON based Gen9 devices (rev12)

2020-11-26 Thread Patchwork
== Series Details == Series: Enable HDR on MCA LSPCON based Gen9 devices (rev12) URL : https://patchwork.freedesktop.org/series/68081/ State : warning == Summary == $ dim checkpatch origin/drm-tip 07f151724145 drm/i915/display: Add HDR Capability detection for LSPCON 015b28ecdd00

Re: [Intel-gfx] [PATCH v6 00/18] HDCP 2.2 and HDCP 1.4 Gen12 DP MST support

2020-11-26 Thread Karthik B S
On 11/26/2020 1:07 PM, Anshuman Gupta wrote: This is v6 version to test with IGT https://patchwork.freedesktop.org/series/82987/ This v6 has added a new patch to series to avoid a crash reported on Chrome-OS and has addressed the few cosmetics review comments from Ram. It has been also tested

Re: [Intel-gfx] [drm/i915/gem] 59dd13ad31: phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second -54.0% regression

2020-11-26 Thread Xing Zhengjun
On 11/27/2020 5:34 AM, Chris Wilson wrote: Quoting Xing Zhengjun (2020-11-26 01:44:55) On 11/25/2020 4:47 AM, Chris Wilson wrote: Quoting Oliver Sang (2020-11-19 07:20:18) On Fri, Nov 13, 2020 at 04:27:13PM +0200, Joonas Lahtinen wrote: Hi, Could you add intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [PATCH] drm/i915/display: Record the plane update times for debugging

2020-11-26 Thread kernel test robot
Hi Chris, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip v5.10-rc5 next-20201126] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [Intel-gfx] [PATCH] drm/i915/display: Record the plane update times for debugging

2020-11-26 Thread kernel test robot
Hi Chris, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip v5.10-rc5 next-20201126] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [Intel-gfx] [drm/i915/gem] 59dd13ad31: phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second -54.0% regression

2020-11-26 Thread Chris Wilson
Quoting Xing Zhengjun (2020-11-26 01:44:55) > > > On 11/25/2020 4:47 AM, Chris Wilson wrote: > > Quoting Oliver Sang (2020-11-19 07:20:18) > >> On Fri, Nov 13, 2020 at 04:27:13PM +0200, Joonas Lahtinen wrote: > >>> Hi, > >>> > >>> Could you add intel-gfx@lists.freedesktop.org into reports going

[Intel-gfx] [PATCH] drm/i915/display: Record the plane update times for debugging

2020-11-26 Thread Chris Wilson
Since we try and estimate how long we require to update the registers to perform a plane update, it is of vital importance that we measure the distribution of plane updates to better guide our estimate. If we underestimate how long it takes to perform the plane update, we may slip into the next

[Intel-gfx] [PATCH] drm/i915/display: Record the plane update times for debugging

2020-11-26 Thread Chris Wilson
Since we try and estimate how long we require to update the registers to perform a plane update, it is of vital importance that we measure the distribution of plane updates to better guide our estimate. If we underestimate how long it takes to perform the plane update, we may slip into the next

[Intel-gfx] [v12 12/15] drm/i915/display: Implement infoframes readback for LSPCON

2020-11-26 Thread Uma Shankar
Implemented Infoframes enabled readback for LSPCON devices. This will help align the implementation with state readback infrastructure. v2: Added proper bitmask of enabled infoframes as per Ville's recommendation. v3: Added pcon specific infoframe types instead of using the HSW one's, as

[Intel-gfx] [v12 04/15] drm/i915/display: Fixes quantization range for YCbCr output

2020-11-26 Thread Uma Shankar
This patch fixes the quantization range for YCbCr output on Lspcon based devices. v2: Re-phrased the description and added Ville's Rb. Signed-off-by: Uma Shankar Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_lspcon.c | 17 +++-- 1 file changed, 11

[Intel-gfx] [v12 13/15] drm/i915/display: Implement DRM infoframe read for LSPCON

2020-11-26 Thread Uma Shankar
Implement Read back of HDR metadata infoframes i.e Dynamic Range and Mastering Infoframe for LSPCON devices. v2: Added proper bitmask of enabled infoframes as per Ville's recommendation. v3: Dropped a redundant wrapper as per Ville's comment. v4: Dropped a redundant print, added Ville's RB.

[Intel-gfx] [v12 15/15] drm/i915/display: [NOT FOR MERGE] Reduce blanking to support 4k60@10bpp for LSPCON

2020-11-26 Thread Uma Shankar
Blanking needs to be reduced to incorporate DP and HDMI timing/link bandwidth limitations for CEA modes (4k@60 at 10 bpp). DP can drive 17.28Gbs while 4k modes (VIC97 etc) at 10 bpp required 17.8 Gbps. This will cause mode to blank out. Reduced Htotal by shortening the back porch and front porch

[Intel-gfx] [v12 14/15] drm/i915/lspcon: Do not send DRM infoframes to non-HDMI sinks

2020-11-26 Thread Uma Shankar
Non-HDMI sinks shouldn't be sent Dynamic Range and Mastering infoframes. Check for that when using LSPCON. Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_ddi.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] [v12 11/15] drm/i915/lspcon: Create separate infoframe_enabled helper

2020-11-26 Thread Uma Shankar
Lspcon has Infoframes as well as DIP for HDR metadata(DRM Infoframe). Create a separate mechanism for lspcon compared to HDMI in order to address the same and ensure future scalability. v2: Streamlined this as per Ville's suggestions, making sure that HDMI infoframe versions are directly returned

[Intel-gfx] [v12 10/15] drm/i915/display: Enable HDR for Parade based lspcon

2020-11-26 Thread Uma Shankar
Enable HDR for LSPCON based on Parade along with MCA. v2: Added a helper for status reg as suggested by Ville. v3: Removed a redundant variable, added Ville's RB. Signed-off-by: Uma Shankar Signed-off-by: Vipin Anand Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_lspcon.c

[Intel-gfx] [v12 09/15] drm/i915/display: Nuke bogus lspcon check

2020-11-26 Thread Uma Shankar
Dropped a irrelevant lspcon check from intel_hdmi_add_properties function. Suggested-by: Ville Syrjälä Signed-off-by: Uma Shankar Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_hdmi.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git

[Intel-gfx] [v12 08/15] drm/i915/display: Enable colorspace programming for LSPCON devices

2020-11-26 Thread Uma Shankar
Enable HDMI Colorspace for LSPCON based devices. Sending Colorimetry data for HDR using AVI infoframe. LSPCON firmware expects this and though SOC drives DP, for HDMI panel AVI infoframe is sent to the LSPCON device which transfers the same to HDMI sink. v2: Dropped state managed in drm core as

[Intel-gfx] [v12 07/15] drm/i915: Split intel_attach_colorspace_property() into HDMI vs. DP variants

2020-11-26 Thread Uma Shankar
From: Ville Syrjälä With LSPCON we use the AVI infoframe to convey the colorimetry information (as opposed to DP MSA/SDP), so the property we expose should match the values we can stuff into the infoframe. Ie. we must use the HDMI variant of the property, even though we drive LSPCON in PCON

[Intel-gfx] [v12 05/15] drm/i915/display: Add a WARN for invalid output range and format

2020-11-26 Thread Uma Shankar
Add a WARN to rule out an invalid output range and format combination. This is to align the lspcon code with compute_avi_infoframes. Signed-off-by: Uma Shankar Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_lspcon.c | 4 1 file changed, 4 insertions(+) diff --git

[Intel-gfx] [v12 06/15] drm/i915/display: Attach content type property for LSPCON

2020-11-26 Thread Uma Shankar
Content type is supported on HDMI sink devices. Attached the property for the same for LSPCON based devices. v2: Added the content type programming when we are attaching the property to connector, as suggested by Ville. Signed-off-by: Uma Shankar Reviewed-by: Ville Syrjälä ---

[Intel-gfx] [v12 02/15] drm/i915/display: Enable HDR on gen9 devices with MCA Lspcon

2020-11-26 Thread Uma Shankar
Gen9 hardware supports HDMI2.0 through LSPCON chips. Extending HDR support for MCA LSPCON based GEN9 devices. SOC will drive LSPCON as DP and send HDR metadata as standard DP SDP packets. LSPCON will be set to operate in PCON mode, will receive the metadata and create Dynamic Range and Mastering

[Intel-gfx] [v12 03/15] drm/i915/display: Attach HDR property for capable Gen9 devices

2020-11-26 Thread Uma Shankar
Attach HDR property for Gen9 devices with MCA LSPCON chips. v2: Cleaned HDR property attachment logic based on capability as per Jani Nikula's suggestion. v3: Fixed the HDR property attachment logic as per the new changes by Kai-Feng to align with lspcon detection failure on some devices. v4:

[Intel-gfx] [v12 00/15] Enable HDR on MCA LSPCON based Gen9 devices

2020-11-26 Thread Uma Shankar
Gen9 hardware supports HDMI2.0 through LSPCON chips. Extending HDR support for MCA and Parade LSPCON based GEN9 devices. SOC will drive LSPCON as DP and send HDR metadata as standard DP SDP packets. LSPCON will be set to operate in PCON mode, will receive the metadata and create Dynamic Range and

[Intel-gfx] [v12 01/15] drm/i915/display: Add HDR Capability detection for LSPCON

2020-11-26 Thread Uma Shankar
LSPCON firmware exposes HDR capability through LPCON_CAPABILITIES DPCD register. LSPCON implementations capable of supporting HDR set HDR_CAPABILITY bit in LSPCON_CAPABILITIES to 1. This patch reads the same, detects the HDR capability and adds this to intel_lspcon struct. v2: Addressed Jani

Re: [Intel-gfx] [PATCH] drm/i915: Split intel_attach_colorspace_property() into HDMI vs. DP variants

2020-11-26 Thread Shankar, Uma
> -Original Message- > From: Ville Syrjala > Sent: Thursday, November 26, 2020 10:41 PM > To: intel-gfx@lists.freedesktop.org > Cc: Shankar, Uma > Subject: [PATCH] drm/i915: Split intel_attach_colorspace_property() into HDMI > vs. DP variants > > From: Ville Syrjälä > > With LSPCON

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pmu: Deprecate I915_PMU_LAST and optimize state tracking

2020-11-26 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Deprecate I915_PMU_LAST and optimize state tracking URL : https://patchwork.freedesktop.org/series/84305/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9395_full -> Patchwork_18991_full

Re: [Intel-gfx] [v11 07/13] i915/display: Enable BT2020 for HDR on LSPCON devices

2020-11-26 Thread Shankar, Uma
> -Original Message- > From: Ville Syrjälä > Sent: Thursday, November 26, 2020 10:43 PM > To: Shankar, Uma > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [v11 07/13] i915/display: Enable BT2020 for HDR on LSPCON devices > > On Thu, Nov 26, 2020 at 01:44:39PM +0530, Uma Shankar

Re: [Intel-gfx] [v11 09/13] drm/i915/display: Implement infoframes readback for LSPCON

2020-11-26 Thread Shankar, Uma
> -Original Message- > From: Ville Syrjälä > Sent: Thursday, November 26, 2020 11:14 PM > To: Shankar, Uma > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [v11 09/13] drm/i915/display: Implement infoframes readback for > LSPCON > > On Thu, Nov 26, 2020 at 06:32:02PM +0200, Ville

Re: [Intel-gfx] [v11 01/13] drm/i915/display: Add HDR Capability detection for LSPCON

2020-11-26 Thread Shankar, Uma
> -Original Message- > From: Ville Syrjälä > Sent: Thursday, November 26, 2020 9:56 PM > To: Shankar, Uma > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [v11 01/13] drm/i915/display: Add HDR Capability detection for > LSPCON > > On Thu, Nov 26, 2020 at 01:44:33PM +0530, Uma

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Deprecate I915_PMU_LAST and optimize state tracking

2020-11-26 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-11-26 18:58:20) > > On 26/11/2020 16:56, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2020-11-26 16:47:03) > >> -static unsigned int config_enabled_bit(u64 config) > >> +static unsigned int is_tracked_config(const u64 config) > >> { > >> - if

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Split intel_attach_colorspace_property() into HDMI vs. DP variants

2020-11-26 Thread Patchwork
== Series Details == Series: drm/i915: Split intel_attach_colorspace_property() into HDMI vs. DP variants URL : https://patchwork.freedesktop.org/series/84309/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9395 -> Patchwork_18992

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Deprecate I915_PMU_LAST and optimize state tracking

2020-11-26 Thread Tvrtko Ursulin
On 26/11/2020 16:56, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-11-26 16:47:03) -static unsigned int config_enabled_bit(u64 config) +static unsigned int is_tracked_config(const u64 config) { - if (is_engine_config(config)) + unsigned int val; +/** + * Non-engine events

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Program mocs:63 for cache eviction on gen9 (rev2)

2020-11-26 Thread Patchwork
== Series Details == Series: drm/i915/gt: Program mocs:63 for cache eviction on gen9 (rev2) URL : https://patchwork.freedesktop.org/series/84293/ State : success == Summary == CI Bug Log - changes from CI_DRM_9394_full -> Patchwork_18990_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Deprecate I915_PMU_LAST and optimize state tracking

2020-11-26 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Deprecate I915_PMU_LAST and optimize state tracking URL : https://patchwork.freedesktop.org/series/84305/ State : success == Summary == CI Bug Log - changes from CI_DRM_9395 -> Patchwork_18991

Re: [Intel-gfx] [v11 09/13] drm/i915/display: Implement infoframes readback for LSPCON

2020-11-26 Thread Ville Syrjälä
On Thu, Nov 26, 2020 at 06:32:02PM +0200, Ville Syrjälä wrote: > On Thu, Nov 26, 2020 at 01:44:41PM +0530, Uma Shankar wrote: > > Implemented Infoframes enabled readback for LSPCON devices. > > This will help align the implementation with state readback > > infrastructure. > > > > v2: Added

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/5] drm/i915/gt: Decouple completed requests on unwind

2020-11-26 Thread Patchwork
== Series Details == Series: series starting with [CI,1/5] drm/i915/gt: Decouple completed requests on unwind URL : https://patchwork.freedesktop.org/series/84301/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9394_full -> Patchwork_18989_full

Re: [Intel-gfx] [v11 07/13] i915/display: Enable BT2020 for HDR on LSPCON devices

2020-11-26 Thread Ville Syrjälä
On Thu, Nov 26, 2020 at 01:44:39PM +0530, Uma Shankar wrote: > Enable Colorspace as BT2020 if driving HDR content.Sending Colorimetry > data for HDR using AVI infoframe. LSPCON firmware expects this and though > SOC drives DP, for HDMI panel AVI infoframe is sent to the LSPCON device > which

[Intel-gfx] [PATCH] drm/i915: Split intel_attach_colorspace_property() into HDMI vs. DP variants

2020-11-26 Thread Ville Syrjala
From: Ville Syrjälä With LSPCON we use the AVI infoframe to convey the colorimetry information (as opposed to DP MSA/SDP), so the property we expose should match the values we can stuff into the infoframe. Ie. we must use the HDMI variant of the property, even though we drive LSPCON in PCON

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Deprecate I915_PMU_LAST and optimize state tracking

2020-11-26 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-11-26 16:47:03) > -static unsigned int config_enabled_bit(u64 config) > +static unsigned int is_tracked_config(const u64 config) > { > - if (is_engine_config(config)) > + unsigned int val; > +/** > + * Non-engine events that we need to track

Re: [Intel-gfx] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-26 Thread Karol Herbst
On Thu, Nov 26, 2020 at 4:28 PM Geert Uytterhoeven wrote: > > Hi Miguel, > > On Thu, Nov 26, 2020 at 3:54 PM Miguel Ojeda > wrote: > > On Wed, Nov 25, 2020 at 11:44 PM Edward Cree wrote: > > > To make the intent clear, you have to first be certain that you > > > understand the intent;

[Intel-gfx] [PATCH] drm/i915/pmu: Deprecate I915_PMU_LAST and optimize state tracking

2020-11-26 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Adding any kinds of "last" abi markers is usually a mistake which I repeated when implementing the PMU because it felt convenient at the time. This patch marks I915_PMU_LAST as deprecated and stops the internal implementation using it for sizing the event status bitmask and

Re: [Intel-gfx] [v11 09/13] drm/i915/display: Implement infoframes readback for LSPCON

2020-11-26 Thread Ville Syrjälä
On Thu, Nov 26, 2020 at 01:44:41PM +0530, Uma Shankar wrote: > Implemented Infoframes enabled readback for LSPCON devices. > This will help align the implementation with state readback > infrastructure. > > v2: Added proper bitmask of enabled infoframes as per Ville's > recommendation. > > v3:

Re: [Intel-gfx] [v11 05/13] drm/i915/display: Add a WARN for invalid output range and format

2020-11-26 Thread Ville Syrjälä
On Thu, Nov 26, 2020 at 01:44:37PM +0530, Uma Shankar wrote: > Add a WARN to rule out an invalid output range and format > combination. This is to align the lspcon code with > compute_avi_infoframes. > > Signed-off-by: Uma Shankar Reviewed-by: Ville Syrjälä > --- >

Re: [Intel-gfx] [v11 06/13] drm/i915/display: Attach content type property for LSPCON

2020-11-26 Thread Ville Syrjälä
On Thu, Nov 26, 2020 at 01:44:38PM +0530, Uma Shankar wrote: > Content type is supported on HDMI sink devices. Attached the > property for the same for LSPCON based devices. > > v2: Added the content type programming when we are attaching > the property to connector, as suggested by Ville. > >

Re: [Intel-gfx] [v11 04/13] drm/i915/display: Enable quantization range for HDR on LSPCON devices

2020-11-26 Thread Ville Syrjälä
On Thu, Nov 26, 2020 at 01:44:36PM +0530, Uma Shankar wrote: > This patch handles the quantization range for Lspcon. I would state it as "fixes quantization range for YCbCr output" or something along those lins. Reviewed-by: Ville Syrjälä > > Signed-off-by: Uma Shankar > --- >

Re: [Intel-gfx] [v11 01/13] drm/i915/display: Add HDR Capability detection for LSPCON

2020-11-26 Thread Ville Syrjälä
On Thu, Nov 26, 2020 at 01:44:33PM +0530, Uma Shankar wrote: > LSPCON firmware exposes HDR capability through LPCON_CAPABILITIES > DPCD register. LSPCON implementations capable of supporting > HDR set HDR_CAPABILITY bit in LSPCON_CAPABILITIES to 1. This patch > reads the same, detects the HDR

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tools/intel_gpu_top: Fixup imc event parsing

2020-11-26 Thread Tvrtko Ursulin
On 26/11/2020 15:48, Chris Wilson wrote: After combining rapl_parse and imc_parse into a single pmu_parse, I left the "energy-" prefixes used by rapl (but not imc) in place. Lift the prefix to rapl_open() so that pmu_parse() does work for both rapl and imc! Reported-by: Tvrtko Ursulin Fixes:

Re: [Intel-gfx] [PATCH] drm/i915/gt: Program mocs:63 for cache eviction on gen9

2020-11-26 Thread Ville Syrjälä
On Thu, Nov 26, 2020 at 02:08:41PM +, Chris Wilson wrote: > Ville noticed that the last mocs entry is used unconditionally by the HW > when it performs cache evictions, and noted that while the value is not > meant to be writable by the driver, we should program it to a reasonable > value

[Intel-gfx] [PATCH i-g-t] tools/intel_gpu_top: Fixup imc event parsing

2020-11-26 Thread Chris Wilson
After combining rapl_parse and imc_parse into a single pmu_parse, I left the "energy-" prefixes used by rapl (but not imc) in place. Lift the prefix to rapl_open() so that pmu_parse() does work for both rapl and imc! Reported-by: Tvrtko Ursulin Fixes: d0b71b967ccd ("tools/intel_gpu_top:

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/perf: also include Gen11 in OATAILPTR workaround

2020-11-26 Thread Patchwork
== Series Details == Series: drm/i915/perf: also include Gen11 in OATAILPTR workaround URL : https://patchwork.freedesktop.org/series/84292/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9393_full -> Patchwork_18987_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Program mocs:63 for cache eviction on gen9 (rev2)

2020-11-26 Thread Patchwork
== Series Details == Series: drm/i915/gt: Program mocs:63 for cache eviction on gen9 (rev2) URL : https://patchwork.freedesktop.org/series/84293/ State : success == Summary == CI Bug Log - changes from CI_DRM_9394 -> Patchwork_18990

Re: [Intel-gfx] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-26 Thread Geert Uytterhoeven
Hi Miguel, On Thu, Nov 26, 2020 at 3:54 PM Miguel Ojeda wrote: > On Wed, Nov 25, 2020 at 11:44 PM Edward Cree wrote: > > To make the intent clear, you have to first be certain that you > > understand the intent; otherwise by adding either a break or a > > fallthrough to suppress the warning

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Program mocs:63 for cache eviction on gen9 (rev2)

2020-11-26 Thread Patchwork
== Series Details == Series: drm/i915/gt: Program mocs:63 for cache eviction on gen9 (rev2) URL : https://patchwork.freedesktop.org/series/84293/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2eb485b74704 drm/i915/gt: Program mocs:63 for cache eviction on gen9 -:26:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/5] drm/i915/gt: Decouple completed requests on unwind

2020-11-26 Thread Patchwork
== Series Details == Series: series starting with [CI,1/5] drm/i915/gt: Decouple completed requests on unwind URL : https://patchwork.freedesktop.org/series/84301/ State : success == Summary == CI Bug Log - changes from CI_DRM_9394 -> Patchwork_18989

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/5] drm/i915/gt: Decouple completed requests on unwind

2020-11-26 Thread Patchwork
== Series Details == Series: series starting with [CI,1/5] drm/i915/gt: Decouple completed requests on unwind URL : https://patchwork.freedesktop.org/series/84301/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/5] drm/i915/gt: Decouple completed requests on unwind

2020-11-26 Thread Patchwork
== Series Details == Series: series starting with [CI,1/5] drm/i915/gt: Decouple completed requests on unwind URL : https://patchwork.freedesktop.org/series/84301/ State : warning == Summary == $ dim checkpatch origin/drm-tip 61722d006160 drm/i915/gt: Decouple completed requests on unwind

Re: [Intel-gfx] [PATCH] drm/i915/gt: Program mocs:63 for cache eviction on gen9

2020-11-26 Thread Chris Wilson
Quoting Ville Syrjälä (2020-11-26 14:08:24) > On Thu, Nov 26, 2020 at 10:55:39AM +, Chris Wilson wrote: > > Ville noticed that the last mocs entry is used unconditionally by the HW > > when it performs cache evictions, and noted that while the value is not > > meant to be writable by the

Re: [Intel-gfx] [PATCH] drm/i915/display: Warn about types of backlight not handled

2020-11-26 Thread Jani Nikula
On Wed, 25 Nov 2020, Imre Deak wrote: > On Fri, Nov 20, 2020 at 11:57:48AM -0800, José Roberto de Souza wrote: >> Right now we are only explicitly handling the backlight of types >> INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE, INTEL_BACKLIGHT_DSI_DCS and >> INTEL_BACKLIGHT_DISPLAY_DDI all others are

[Intel-gfx] [PATCH] drm/i915/gt: Program mocs:63 for cache eviction on gen9

2020-11-26 Thread Chris Wilson
Ville noticed that the last mocs entry is used unconditionally by the HW when it performs cache evictions, and noted that while the value is not meant to be writable by the driver, we should program it to a reasonable value nevertheless. As it turns out, we can change the value of mocs:63 and the

Re: [Intel-gfx] [PATCH] drm/i915/gt: Program mocs:63 for cache eviction on gen9

2020-11-26 Thread Ville Syrjälä
On Thu, Nov 26, 2020 at 10:55:39AM +, Chris Wilson wrote: > Ville noticed that the last mocs entry is used unconditionally by the HW > when it performs cache evictions, and noted that while the value is not > meant to be writable by the driver, we should program it to a reasonable > value

[Intel-gfx] [CI 1/5] drm/i915/gt: Decouple completed requests on unwind

2020-11-26 Thread Chris Wilson
Since the introduction of preempt-to-busy, requests can complete in the background, even while they are not on the engine->active.requests list. As such, the engine->active.request list itself is not in strict retirement order, and we have to scan the entire list while unwinding to not miss any.

[Intel-gfx] [CI 3/5] drm/i915/gt: Protect context lifetime with RCU

2020-11-26 Thread Chris Wilson
Allow a brief period for continued access to a dead intel_context by deferring the release of the struct until after an RCU grace period. As we are using a dedicated slab cache for the contexts, we can defer the release of the slab pages via RCU, with the caveat that individual structs may be

[Intel-gfx] [CI 5/5] drm/i915/gt: Move the breadcrumb to the signaler if completed upon cancel

2020-11-26 Thread Chris Wilson
If while we are cancelling the breadcrumb signaling, we find that the request is already completed, move it to the irq signaler and let it be signaled. v2: Tweak reference counting so that we only acquire a new reference on adding to a signal list, as opposed to a hidden i915_request_put of the

[Intel-gfx] [CI 4/5] drm/i915/gt: Split the breadcrumb spinlock between global and contexts

2020-11-26 Thread Chris Wilson
As we funnel more and more contexts into the breadcrumbs on an engine, the hold time of b->irq_lock grows. As we may then contend with the b->irq_lock during request submission, this increases the burden upon the engine->active.lock and so directly impacts both our execution latency and client

[Intel-gfx] [CI 2/5] drm/i915/gt: Check for a completed last request once

2020-11-26 Thread Chris Wilson
Pull the repeated check for the last active request being completed to a single spot, when deciding whether or not execlist preemption is required. In doing so, we remove the tasklet kick, introduced with the completion checks in commit 35f3fd8182ba ("drm/i915/execlists: Workaround switching back

Re: [Intel-gfx] [RFC] drm/i915/dp: PPS registers doesn't require AUX power

2020-11-26 Thread Ville Syrjälä
On Thu, Nov 26, 2020 at 03:09:50PM +0530, Anshuman Gupta wrote: > On 2020-11-25 at 18:24:44 +0200, Imre Deak wrote: > > +Ville. > Hi Ville , > Let me provide you some context over the issue which requires your input. > TGL on chorome OS has observed some display glitches when brightness is being

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Program mocs:63 for cache eviction on gen9

2020-11-26 Thread Patchwork
== Series Details == Series: drm/i915/gt: Program mocs:63 for cache eviction on gen9 URL : https://patchwork.freedesktop.org/series/84293/ State : success == Summary == CI Bug Log - changes from CI_DRM_9393 -> Patchwork_18988 Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for HDCP 2.2 and HDCP 1.4 Gen12 DP MST support (rev5)

2020-11-26 Thread Patchwork
== Series Details == Series: HDCP 2.2 and HDCP 1.4 Gen12 DP MST support (rev5) URL : https://patchwork.freedesktop.org/series/82998/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9392_full -> Patchwork_18986_full Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Program mocs:63 for cache eviction on gen9

2020-11-26 Thread Patchwork
== Series Details == Series: drm/i915/gt: Program mocs:63 for cache eviction on gen9 URL : https://patchwork.freedesktop.org/series/84293/ State : warning == Summary == $ dim checkpatch origin/drm-tip eb703e13ad7c drm/i915/gt: Program mocs:63 for cache eviction on gen9 -:24:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: also include Gen11 in OATAILPTR workaround

2020-11-26 Thread Patchwork
== Series Details == Series: drm/i915/perf: also include Gen11 in OATAILPTR workaround URL : https://patchwork.freedesktop.org/series/84292/ State : success == Summary == CI Bug Log - changes from CI_DRM_9393 -> Patchwork_18987 Summary

Re: [Intel-gfx] [RFC v2 6/8] drm/i915/dp: Enable Intel's HDR backlight interface (only SDR for now)

2020-11-26 Thread Jani Nikula
On Wed, 16 Sep 2020, Lyude Paul wrote: > So-recently a bunch of laptops on the market have started using DPCD > backlight controls instead of the traditional DDI backlight controls. > Originally we thought we had this handled by adding VESA backlight > control support to i915, but the story ended

[Intel-gfx] ✗ Fi.CI.IGT: failure for Enable HDR on MCA LSPCON based Gen9 devices (rev11)

2020-11-26 Thread Patchwork
== Series Details == Series: Enable HDR on MCA LSPCON based Gen9 devices (rev11) URL : https://patchwork.freedesktop.org/series/68081/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9392_full -> Patchwork_18985_full Summary

Re: [Intel-gfx] [RFC v2 3/8] drm/i915: Keep track of pwm-related backlight hooks separately

2020-11-26 Thread Jani Nikula
On Thu, 26 Nov 2020, Dave Airlie wrote: > On Thu, 17 Sept 2020 at 03:19, Lyude Paul wrote: >> >> Currently, every different type of backlight hook that i915 supports is >> pretty straight forward - you have a backlight, probably through PWM >> (but maybe DPCD), with a single set of

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: Move the breadcrumb to the signaler if completed upon cancel

2020-11-26 Thread Tvrtko Ursulin
On 25/11/2020 19:56, Chris Wilson wrote: If while we are cancelling the breadcrumb signaling, we find that the request is already completed, move it to the irq signaler and let it be signaled. v2: Tweak reference counting so that we only acquire a new reference on adding to a signal list, as

[Intel-gfx] [PATCH i-g-t v2] i915/gem_exec_schedule: Try to spot unfairness

2020-11-26 Thread Chris Wilson
An important property for multi-client systems is that each client gets a 'fair' allotment of system time. (Where fairness is at the whim of the context properties, such as priorities.) This test forks N independent clients (albeit they happen to share a single vm), and does an equal amount of

[Intel-gfx] [PATCH] drm/i915/gt: Program mocs:63 for cache eviction on gen9

2020-11-26 Thread Chris Wilson
Ville noticed that the last mocs entry is used unconditionally by the HW when it performs cache evictions, and noted that while the value is not meant to be writable by the driver, we should program it to a reasonable value nevertheless. As it turns out, we can change the value of mocs:63 and the

Re: [Intel-gfx] [RFC v2 2/8] drm/i915: Rename pwm_* backlight callbacks to ext_pwm_*

2020-11-26 Thread Jani Nikula
On Wed, 16 Sep 2020, Lyude Paul wrote: > Since we're going to need to add a set of lower-level PWM backlight > control hooks to be shared by normal backlight controls and HDR > backlight controls in SDR mode, let's add a prefix to the external PWM > backlight functions so that the difference

[Intel-gfx] [PATCH] drm/i915/perf: also include Gen11 in OATAILPTR workaround

2020-11-26 Thread Lionel Landwerlin
CI shows this workaround is also needed on Gen11. Signed-off-by: Lionel Landwerlin Fixes: 059a0beb486344 ("drm/i915/perf: workaround register corruption in OATAILPTR") --- drivers/gpu/drm/i915/i915_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Intel-gfx] [RFC v2 1/8] drm/i915/dp: Program source OUI on eDP panels

2020-11-26 Thread Jani Nikula
On Wed, 16 Sep 2020, Lyude Paul wrote: > Since we're about to start adding support for Intel's magic HDR > backlight interface over DPCD, we need to ensure we're properly > programming this field so that Intel specific sink services are exposed. > Otherwise, 0x300-0x3ff will just read zeroes. > >

[Intel-gfx] ✓ Fi.CI.BAT: success for HDCP 2.2 and HDCP 1.4 Gen12 DP MST support (rev5)

2020-11-26 Thread Patchwork
== Series Details == Series: HDCP 2.2 and HDCP 1.4 Gen12 DP MST support (rev5) URL : https://patchwork.freedesktop.org/series/82998/ State : success == Summary == CI Bug Log - changes from CI_DRM_9392 -> Patchwork_18986 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for HDCP 2.2 and HDCP 1.4 Gen12 DP MST support (rev5)

2020-11-26 Thread Patchwork
== Series Details == Series: HDCP 2.2 and HDCP 1.4 Gen12 DP MST support (rev5) URL : https://patchwork.freedesktop.org/series/82998/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for HDCP 2.2 and HDCP 1.4 Gen12 DP MST support (rev5)

2020-11-26 Thread Patchwork
== Series Details == Series: HDCP 2.2 and HDCP 1.4 Gen12 DP MST support (rev5) URL : https://patchwork.freedesktop.org/series/82998/ State : warning == Summary == $ dim checkpatch origin/drm-tip fede738db387 drm/i915/hdcp: Update CP property in update_pipe -:24: WARNING:COMMIT_LOG_LONG_LINE:

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable HDR on MCA LSPCON based Gen9 devices (rev11)

2020-11-26 Thread Patchwork
== Series Details == Series: Enable HDR on MCA LSPCON based Gen9 devices (rev11) URL : https://patchwork.freedesktop.org/series/68081/ State : success == Summary == CI Bug Log - changes from CI_DRM_9392 -> Patchwork_18985 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/display: Defer initial modeset until after GGTT is initialised

2020-11-26 Thread Matthew Auld
On Wed, 25 Nov 2020 at 19:30, Chris Wilson wrote: > > Prior to sanitizing the GGTT, the only operations around in > intel_display_init_nogem() are those to reserve the preallocated (and > active) regions in the GGTT leftover from the BIOS. Trying to allocate a > GGTT vma (such as

Re: [Intel-gfx] [RFC] drm/i915/dp: PPS registers doesn't require AUX power

2020-11-26 Thread Anshuman Gupta
On 2020-11-25 at 18:24:44 +0200, Imre Deak wrote: > +Ville. Hi Ville , Let me provide you some context over the issue which requires your input. TGL on chorome OS has observed some display glitches when brightness is being updated at very fast rate. This has surfaced out two issue. 1. Getting the

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable HDR on MCA LSPCON based Gen9 devices (rev11)

2020-11-26 Thread Patchwork
== Series Details == Series: Enable HDR on MCA LSPCON based Gen9 devices (rev11) URL : https://patchwork.freedesktop.org/series/68081/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable HDR on MCA LSPCON based Gen9 devices (rev11)

2020-11-26 Thread Patchwork
== Series Details == Series: Enable HDR on MCA LSPCON based Gen9 devices (rev11) URL : https://patchwork.freedesktop.org/series/68081/ State : warning == Summary == $ dim checkpatch origin/drm-tip e7d69665cf73 drm/i915/display: Add HDR Capability detection for LSPCON b5fa510007a1

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/tgl: Fix REVID macros for TGL to fetch correct stepping

2020-11-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/tgl: Fix REVID macros for TGL to fetch correct stepping URL : https://patchwork.freedesktop.org/series/84285/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9390_full -> Patchwork_18984_full

[Intel-gfx] [PULL] drm-misc-fixes

2020-11-26 Thread Maxime Ripard
Hi Dave, Daniel, Here's this week round of fixes for drm-misc Maxime drm-misc-fixes-2020-11-26: A bunch of fixes for vc4 fixing some coexistence issue between wifi and HDMI, unsupported modes, and vblank timeouts, a fix for ast to reload the gamma LUT after changing the plane format and a

Re: [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color

2020-11-26 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Monday, November 23, 2020 8:27 PM > To: intel-gfx@lists.freedesktop.org > Cc: Chery, Nanley G ; Rafael Antognolli > ; Pandiyan, Dhinakaran > ; Kondapally, Kalyan > > Subject: [Intel-gfx] [PATCH 1/2] drm/framebuffer: